@loucompanion/forge-bridge 0.1.1-dev.32d4dd5874ee → 0.1.1-dev.54464ef723de
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/bridge/bridge.service.d.ts +1 -0
- package/dist/bridge/bridge.service.js +151 -23
- package/dist/bridge/bridge.types.d.ts +13 -2
- package/dist/cli/cli.service.js +225 -10
- package/dist/cli/local-config.d.ts +1 -0
- package/dist/cli/local-config.js +22 -3
- package/dist/config.js +1 -1
- package/dist/session/internals.d.ts +1 -1
- package/dist/session/phase-completion.d.ts +65 -4
- package/dist/session/phase-completion.js +2160 -124
- package/dist/session/provider-cli/provider-cli.base.d.ts +4 -3
- package/dist/session/provider-cli/provider-cli.service.d.ts +13 -5
- package/dist/session/provider-cli/provider-cli.service.js +1913 -177
- package/dist/session/provider-cli/provider-cli.types.d.ts +5 -0
- package/dist/session/provider-cli/provider-usage.d.ts +25 -0
- package/dist/session/provider-cli/provider-usage.js +64 -0
- package/dist/session/qa-sidecar-validation.d.ts +3 -0
- package/dist/session/qa-sidecar-validation.js +44 -0
- package/dist/session/session.service.js +53 -15
- package/dist/session/session.types.d.ts +126 -0
- package/dist/session/session.types.js +261 -2
- package/dist/version.d.ts +1 -1
- package/dist/version.js +1 -1
- package/dist/worktree/artifact-injector.d.ts +1 -0
- package/dist/worktree/artifact-injector.js +78 -4
- package/dist/worktree/worktree.service.d.ts +1 -0
- package/dist/worktree/worktree.service.js +132 -6
- package/dist/worktree/worktree.types.d.ts +8 -1
- package/package.json +8 -3
|
@@ -1,15 +1,60 @@
|
|
|
1
1
|
import crypto from "node:crypto";
|
|
2
2
|
import fs from "node:fs/promises";
|
|
3
|
+
import os from "node:os";
|
|
3
4
|
import path from "node:path";
|
|
4
5
|
import { execFile, spawn } from "node:child_process";
|
|
5
6
|
import readline from "node:readline";
|
|
6
7
|
import { promisify } from "node:util";
|
|
7
8
|
import { GitClient } from "../../shared/git/git.js";
|
|
8
9
|
import { resolveCursorAgentDirectLaunch } from "../../shared/cursor-agent/cursor-agent.launch.js";
|
|
10
|
+
import { ensureNoSymbolicLinkPathSegments, isPathUnderRoot, sha256File } from "../qa-sidecar-validation.js";
|
|
9
11
|
import { buildSpecBody, selectLaneCommand } from "../../worktree/artifact-injector.js";
|
|
10
|
-
import { codexMcpConfigArgs,
|
|
12
|
+
import { codexMcpConfigArgs, completionPhaseFromDispatch, completionPromptForDebugCycle, completionPromptForDevelopCycle, completionPromptForPhase, completionPromptForQaCycle, completionRedactionEnv, expectedCompletionToolName, expectedDebugCompletionToolName, expectedQaCompletionToolName, prepareCompletionToolRuntime, readCompletionArtifact, usesDebugCycleCompletion, usesDevelopCycleCompletion, writeCompletionArtifact, artifactRootFor, artifactRootForOwner, debugCompletionPhaseOrder, qaCompletionGateOrder } from "../phase-completion.js";
|
|
13
|
+
import { addUsage, buildProviderUsageEvent, emptyUsage, hasUsage, readUsageNumber } from "./provider-usage.js";
|
|
11
14
|
const fakeWorkerModel = "server-local-fake-worker";
|
|
12
15
|
const execFileAsync = promisify(execFile);
|
|
16
|
+
const developCyclePhaseOrder = ["implementation", "self_review", "validation"];
|
|
17
|
+
const allowedProviderParentEnvNames = [
|
|
18
|
+
"PATH",
|
|
19
|
+
"HOME",
|
|
20
|
+
"USERPROFILE",
|
|
21
|
+
"TMPDIR",
|
|
22
|
+
"TEMP",
|
|
23
|
+
"TMP",
|
|
24
|
+
"LANG"
|
|
25
|
+
];
|
|
26
|
+
const windowsAllowedProviderParentEnvNames = [
|
|
27
|
+
"SystemRoot",
|
|
28
|
+
"ComSpec",
|
|
29
|
+
"PATHEXT",
|
|
30
|
+
"APPDATA",
|
|
31
|
+
"LOCALAPPDATA"
|
|
32
|
+
];
|
|
33
|
+
function buildProviderChildEnvironment(requestEnv) {
|
|
34
|
+
const env = {};
|
|
35
|
+
for (const [key, value] of Object.entries(process.env)) {
|
|
36
|
+
if (typeof value === "string" && isAllowedProviderParentEnv(key)) {
|
|
37
|
+
env[key] = value;
|
|
38
|
+
}
|
|
39
|
+
}
|
|
40
|
+
if (requestEnv) {
|
|
41
|
+
for (const [key, value] of Object.entries(requestEnv)) {
|
|
42
|
+
const trimmedKey = key.trim();
|
|
43
|
+
if (trimmedKey.length > 0) {
|
|
44
|
+
env[trimmedKey] = value;
|
|
45
|
+
}
|
|
46
|
+
}
|
|
47
|
+
}
|
|
48
|
+
return env;
|
|
49
|
+
}
|
|
50
|
+
function isAllowedProviderParentEnv(key) {
|
|
51
|
+
return isAllowedProviderParentEnvName(key, allowedProviderParentEnvNames)
|
|
52
|
+
|| key.toUpperCase().startsWith("LC_")
|
|
53
|
+
|| (process.platform === "win32" && isAllowedProviderParentEnvName(key, windowsAllowedProviderParentEnvNames));
|
|
54
|
+
}
|
|
55
|
+
function isAllowedProviderParentEnvName(key, allowedNames) {
|
|
56
|
+
return allowedNames.some((allowed) => allowed.toLowerCase() === key.toLowerCase());
|
|
57
|
+
}
|
|
13
58
|
export class RoutingProviderCliService {
|
|
14
59
|
realProvider;
|
|
15
60
|
deterministicProvider;
|
|
@@ -22,15 +67,25 @@ export class RoutingProviderCliService {
|
|
|
22
67
|
? await this.deterministicProvider.runImplementation(context)
|
|
23
68
|
: await this.realProvider.runImplementation(context);
|
|
24
69
|
}
|
|
70
|
+
async runArchitect(context) {
|
|
71
|
+
return isFakeWorkerModel(context.dispatch.execution.model)
|
|
72
|
+
? await this.deterministicProvider.runArchitect(context)
|
|
73
|
+
: await this.realProvider.runArchitect(context);
|
|
74
|
+
}
|
|
25
75
|
async runConflictResolve(context) {
|
|
26
76
|
return isFakeWorkerModel(context.dispatch.execution.model)
|
|
27
77
|
? await this.deterministicProvider.runConflictResolve(context)
|
|
28
78
|
: await this.realProvider.runConflictResolve(context);
|
|
29
79
|
}
|
|
30
|
-
async runQa(
|
|
31
|
-
return isFakeWorkerModel(dispatch.execution.model)
|
|
32
|
-
? await this.deterministicProvider.runQa(
|
|
33
|
-
: await this.realProvider.runQa(
|
|
80
|
+
async runQa(context) {
|
|
81
|
+
return isFakeWorkerModel(context.dispatch.execution.model)
|
|
82
|
+
? await this.deterministicProvider.runQa(context)
|
|
83
|
+
: await this.realProvider.runQa(context);
|
|
84
|
+
}
|
|
85
|
+
async runDraft(context) {
|
|
86
|
+
return isFakeWorkerModel(context.dispatch.execution.model)
|
|
87
|
+
? await this.deterministicProvider.runDraft(context)
|
|
88
|
+
: await this.realProvider.runDraft(context);
|
|
34
89
|
}
|
|
35
90
|
}
|
|
36
91
|
export class ProcessBackedProviderCliService {
|
|
@@ -40,9 +95,65 @@ export class ProcessBackedProviderCliService {
|
|
|
40
95
|
this.processRunner = processRunner;
|
|
41
96
|
this.git = git;
|
|
42
97
|
}
|
|
98
|
+
async runDraft(context) {
|
|
99
|
+
const { dispatch } = context;
|
|
100
|
+
if (!dispatch.draft) {
|
|
101
|
+
throw new Error("Draft dispatch context is missing.");
|
|
102
|
+
}
|
|
103
|
+
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "forge-bridge-draft-"));
|
|
104
|
+
const command = buildProviderCliCommand(dispatch, {
|
|
105
|
+
worktreePath: tempDir,
|
|
106
|
+
prompt: buildDraftPrompt(dispatch),
|
|
107
|
+
skipGitRepoCheck: true
|
|
108
|
+
});
|
|
109
|
+
await context.emit({
|
|
110
|
+
role: "runner",
|
|
111
|
+
kind: "checkpoint",
|
|
112
|
+
content: `Starting provider CLI Draft: ${formatProviderCliCommand(command)}`,
|
|
113
|
+
eventType: "provider_cli_started"
|
|
114
|
+
});
|
|
115
|
+
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
116
|
+
try {
|
|
117
|
+
const result = await this.processRunner.run({
|
|
118
|
+
command: command.command,
|
|
119
|
+
args: command.args,
|
|
120
|
+
cwd: tempDir,
|
|
121
|
+
env: providerProcessEnv(dispatch)
|
|
122
|
+
}, {
|
|
123
|
+
onStdoutLine: async (line) => {
|
|
124
|
+
for (const event of outputState.consume(line)) {
|
|
125
|
+
await context.emit(event);
|
|
126
|
+
}
|
|
127
|
+
}
|
|
128
|
+
}, context.signal);
|
|
129
|
+
if (result.exitCode !== 0) {
|
|
130
|
+
throw new Error(`Provider CLI exited with code ${result.exitCode}${summarizeStderr(result.stderr)}.`);
|
|
131
|
+
}
|
|
132
|
+
const content = outputState.finalMessage ?? result.stdout.trim();
|
|
133
|
+
if (!content) {
|
|
134
|
+
throw new Error("Provider CLI completed without returning a draft.");
|
|
135
|
+
}
|
|
136
|
+
const json = extractJsonObject(content);
|
|
137
|
+
await context.emit({
|
|
138
|
+
role: "assistant",
|
|
139
|
+
kind: "message",
|
|
140
|
+
content: json,
|
|
141
|
+
eventType: "draft_complete"
|
|
142
|
+
});
|
|
143
|
+
await emitProviderUsageEvent(context.emit, dispatch, outputState);
|
|
144
|
+
return {
|
|
145
|
+
summary: "Draft generated through Forge Runner."
|
|
146
|
+
};
|
|
147
|
+
}
|
|
148
|
+
finally {
|
|
149
|
+
await fs.rm(tempDir, { recursive: true, force: true });
|
|
150
|
+
}
|
|
151
|
+
}
|
|
43
152
|
async runImplementation(context) {
|
|
44
153
|
const { dispatch, worktree } = context;
|
|
45
154
|
const phase = completionPhaseFromDispatch(dispatch);
|
|
155
|
+
const developCycle = usesDevelopCycleCompletion(dispatch);
|
|
156
|
+
const debugCycle = usesDebugCycleCompletion(dispatch);
|
|
46
157
|
const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
|
|
47
158
|
await fs.mkdir(metadataRoot, { recursive: true });
|
|
48
159
|
const laneCommand = selectLaneCommand(dispatch.artifacts, dispatch.execution.lane, dispatch.cycleRun.phase);
|
|
@@ -56,7 +167,11 @@ export class ProcessBackedProviderCliService {
|
|
|
56
167
|
const completionTools = await prepareCompletionToolRuntime({ dispatch, worktree, phase });
|
|
57
168
|
const command = buildProviderCliCommand(dispatch, {
|
|
58
169
|
worktreePath: worktree.worktreePath,
|
|
59
|
-
prompt:
|
|
170
|
+
prompt: debugCycle
|
|
171
|
+
? buildDebugCyclePrompt(dispatch, phase)
|
|
172
|
+
: developCycle
|
|
173
|
+
? buildDevelopCyclePrompt(dispatch, phase)
|
|
174
|
+
: buildImplementationPrompt(dispatch, phase),
|
|
60
175
|
completionTools
|
|
61
176
|
});
|
|
62
177
|
await context.emit({
|
|
@@ -68,26 +183,33 @@ export class ProcessBackedProviderCliService {
|
|
|
68
183
|
await context.emit({
|
|
69
184
|
role: "runner",
|
|
70
185
|
kind: "checkpoint",
|
|
71
|
-
content:
|
|
186
|
+
content: debugCycle
|
|
187
|
+
? "Forge Debug completion tools configured for debug_repro -> debug_root_cause -> debug_fix -> debug_regression; provider must call each MCP completion tool before exit."
|
|
188
|
+
: developCycle
|
|
189
|
+
? "Forge completion tools configured for implementation -> self_review -> validation; provider must call each MCP completion tool before exit."
|
|
190
|
+
: `Forge completion tools configured for ${phase}; provider must call the MCP completion tool before exit.`,
|
|
72
191
|
eventType: "completion_tools_configured"
|
|
73
192
|
});
|
|
74
193
|
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
194
|
+
const liveCompletionEvents = new LiveCompletionArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, phase, developCycle, debugCycle, context.emit);
|
|
75
195
|
let result;
|
|
76
196
|
try {
|
|
197
|
+
liveCompletionEvents.start();
|
|
77
198
|
result = await this.processRunner.run({
|
|
78
199
|
command: command.command,
|
|
79
200
|
args: command.args,
|
|
80
|
-
cwd: worktree.worktreePath
|
|
201
|
+
cwd: worktree.worktreePath,
|
|
202
|
+
env: providerProcessEnv(dispatch)
|
|
81
203
|
}, {
|
|
82
204
|
onStdoutLine: async (line) => {
|
|
83
|
-
const event
|
|
84
|
-
if (event) {
|
|
205
|
+
for (const event of outputState.consume(line)) {
|
|
85
206
|
await context.emit(event);
|
|
86
207
|
}
|
|
87
208
|
}
|
|
88
209
|
}, context.signal);
|
|
89
210
|
}
|
|
90
211
|
finally {
|
|
212
|
+
await liveCompletionEvents.stop();
|
|
91
213
|
await cleanupCompletionTools(completionTools, context.emit);
|
|
92
214
|
}
|
|
93
215
|
if (result.exitCode !== 0) {
|
|
@@ -100,17 +222,23 @@ export class ProcessBackedProviderCliService {
|
|
|
100
222
|
content: `Provider CLI completed: ${command.command} exit ${result.exitCode}${outputState.sessionLabel ? ` ${outputState.sessionLabel}` : ""}.`,
|
|
101
223
|
eventType: "provider_cli_completed"
|
|
102
224
|
});
|
|
225
|
+
await emitProviderUsageEvent(context.emit, dispatch, outputState);
|
|
103
226
|
const committed = await commitWorktreeChanges(this.git, worktree.worktreePath, dispatch.workItem.id);
|
|
104
|
-
const
|
|
105
|
-
|
|
106
|
-
|
|
227
|
+
const completionArtifacts = await readCompletionArtifactsForRun(worktree.worktreePath, dispatch.workItem.id, phase, developCycle, debugCycle);
|
|
228
|
+
for (const artifact of completionArtifacts) {
|
|
229
|
+
if (!liveCompletionEvents.hasEmitted(completionPhaseFromArtifact(artifact))) {
|
|
230
|
+
await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, artifact);
|
|
231
|
+
await emitPhaseCompletionEvent(context.emit, artifact);
|
|
232
|
+
await emitPhaseGateEvents(context.emit, artifact);
|
|
233
|
+
}
|
|
107
234
|
}
|
|
235
|
+
const completionArtifact = completionArtifacts[0];
|
|
108
236
|
if (outputState.finalMessage) {
|
|
109
237
|
await context.emit({
|
|
110
238
|
role: "assistant",
|
|
111
239
|
kind: "message",
|
|
112
240
|
content: outputState.finalMessage,
|
|
113
|
-
eventType: "
|
|
241
|
+
eventType: "provider_final_message"
|
|
114
242
|
});
|
|
115
243
|
}
|
|
116
244
|
else {
|
|
@@ -118,11 +246,11 @@ export class ProcessBackedProviderCliService {
|
|
|
118
246
|
role: "assistant",
|
|
119
247
|
kind: "message",
|
|
120
248
|
content: `${dispatch.execution.provider} CLI completed for ${worktree.branchName}.`,
|
|
121
|
-
eventType: "
|
|
249
|
+
eventType: "provider_final_message"
|
|
122
250
|
});
|
|
123
251
|
}
|
|
124
252
|
return {
|
|
125
|
-
summary: `${dispatch.execution.provider} CLI completed ${worktree.branchName} (${phase}, ${committed.commitSha.slice(0, 12)}).`,
|
|
253
|
+
summary: `${dispatch.execution.provider} CLI completed ${worktree.branchName} (${debugCycle ? "debug cycle" : developCycle ? "develop cycle" : phase}, ${committed.commitSha.slice(0, 12)}).`,
|
|
126
254
|
spec: {
|
|
127
255
|
repoPath: worktree.worktreePath,
|
|
128
256
|
path: specPath,
|
|
@@ -130,67 +258,212 @@ export class ProcessBackedProviderCliService {
|
|
|
130
258
|
producedBy: "forge-lane-command",
|
|
131
259
|
status: "approved"
|
|
132
260
|
},
|
|
133
|
-
artifact: completionArtifact
|
|
261
|
+
artifact: completionArtifact,
|
|
262
|
+
artifacts: completionArtifacts
|
|
134
263
|
};
|
|
135
264
|
}
|
|
136
|
-
async
|
|
265
|
+
async runArchitect(context) {
|
|
266
|
+
const { dispatch, worktree } = context;
|
|
267
|
+
const completionTools = await prepareCompletionToolRuntime({ dispatch, worktree, phase: "architect" });
|
|
137
268
|
const command = buildProviderCliCommand(dispatch, {
|
|
138
|
-
|
|
269
|
+
worktreePath: worktree.worktreePath,
|
|
270
|
+
prompt: buildArchitectPrompt(dispatch),
|
|
271
|
+
completionTools
|
|
139
272
|
});
|
|
140
|
-
|
|
273
|
+
const commandText = formatProviderCliCommand(command);
|
|
274
|
+
await context.emit({
|
|
141
275
|
role: "runner",
|
|
142
276
|
kind: "checkpoint",
|
|
143
|
-
content: `Starting provider CLI
|
|
277
|
+
content: `Starting provider CLI Architect: ${commandText} in ${worktree.worktreePath}`,
|
|
144
278
|
eventType: "provider_cli_started"
|
|
145
279
|
});
|
|
280
|
+
await context.emit({
|
|
281
|
+
role: "runner",
|
|
282
|
+
kind: "checkpoint",
|
|
283
|
+
content: "Forge Architect completion tools configured; provider must call forge.complete_architect_plan before exit.",
|
|
284
|
+
eventType: "completion_tools_configured"
|
|
285
|
+
});
|
|
146
286
|
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
147
|
-
const
|
|
148
|
-
|
|
149
|
-
|
|
150
|
-
|
|
151
|
-
|
|
152
|
-
|
|
153
|
-
|
|
154
|
-
|
|
155
|
-
|
|
287
|
+
const liveArchitectEvents = new LiveArchitectArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, context.emit);
|
|
288
|
+
let result;
|
|
289
|
+
try {
|
|
290
|
+
liveArchitectEvents.start();
|
|
291
|
+
result = await this.processRunner.run({
|
|
292
|
+
command: command.command,
|
|
293
|
+
args: command.args,
|
|
294
|
+
cwd: worktree.worktreePath,
|
|
295
|
+
env: providerProcessEnv(dispatch)
|
|
296
|
+
}, {
|
|
297
|
+
onStdoutLine: async (line) => {
|
|
298
|
+
for (const event of outputState.consume(line)) {
|
|
299
|
+
await context.emit(event);
|
|
300
|
+
}
|
|
156
301
|
}
|
|
157
|
-
}
|
|
158
|
-
}
|
|
302
|
+
}, context.signal);
|
|
303
|
+
}
|
|
304
|
+
finally {
|
|
305
|
+
await liveArchitectEvents.stop();
|
|
306
|
+
await cleanupCompletionTools(completionTools, context.emit);
|
|
307
|
+
}
|
|
159
308
|
if (result.exitCode !== 0) {
|
|
160
309
|
const stderr = clip(result.stderr.trim() || result.stdout.trim(), 1200);
|
|
161
310
|
throw new Error(`${command.command} exited ${result.exitCode}${stderr ? `: ${stderr}` : ""}`);
|
|
162
311
|
}
|
|
163
|
-
await emit({
|
|
312
|
+
await context.emit({
|
|
313
|
+
role: "runner",
|
|
314
|
+
kind: "checkpoint",
|
|
315
|
+
content: `Provider CLI Architect completed: ${command.command} exit ${result.exitCode}${outputState.sessionLabel ? ` ${outputState.sessionLabel}` : ""}.`,
|
|
316
|
+
eventType: "provider_cli_completed"
|
|
317
|
+
});
|
|
318
|
+
await emitProviderUsageEvent(context.emit, dispatch, outputState);
|
|
319
|
+
const architectArtifact = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, "architect");
|
|
320
|
+
if (!architectArtifact) {
|
|
321
|
+
throw new Error("Provider CLI Architect completed but did not call the Forge Architect completion tool.");
|
|
322
|
+
}
|
|
323
|
+
if (!liveArchitectEvents.hasEmitted()) {
|
|
324
|
+
await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, architectArtifact);
|
|
325
|
+
await emitArchitectStructuredEvents(context.emit, worktree.worktreePath, dispatch.workItem.id, architectArtifact);
|
|
326
|
+
}
|
|
327
|
+
await context.emit({
|
|
328
|
+
role: "assistant",
|
|
329
|
+
kind: "message",
|
|
330
|
+
content: outputState.finalMessage || `${dispatch.execution.provider} CLI produced an Architect plan for ${worktree.branchName}.`,
|
|
331
|
+
eventType: "architect_complete"
|
|
332
|
+
});
|
|
333
|
+
const specPath = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id, "spec.md");
|
|
334
|
+
const specBody = await fs.readFile(specPath, "utf8").catch(() => `# ${dispatch.workItem.title}\n\nArchitect plan pending approval.\n`);
|
|
335
|
+
return {
|
|
336
|
+
summary: `${dispatch.execution.provider} CLI Architect plan produced.`,
|
|
337
|
+
spec: {
|
|
338
|
+
repoPath: worktree.worktreePath,
|
|
339
|
+
path: specPath,
|
|
340
|
+
body: specBody,
|
|
341
|
+
producedBy: `${dispatch.execution.provider}-cli`,
|
|
342
|
+
status: "pending_approval"
|
|
343
|
+
},
|
|
344
|
+
artifact: architectArtifact,
|
|
345
|
+
artifacts: [architectArtifact]
|
|
346
|
+
};
|
|
347
|
+
}
|
|
348
|
+
async runQa(context) {
|
|
349
|
+
const { dispatch, worktree } = context;
|
|
350
|
+
const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
|
|
351
|
+
await fs.mkdir(metadataRoot, { recursive: true });
|
|
352
|
+
const laneCommand = selectLaneCommand(dispatch.artifacts, dispatch.execution.lane, dispatch.cycleRun.phase);
|
|
353
|
+
if (!laneCommand) {
|
|
354
|
+
throw new Error(`Lane command for lane '${dispatch.execution.lane}' phase '${dispatch.cycleRun.phase}' was not resolved.`);
|
|
355
|
+
}
|
|
356
|
+
const specBody = buildSpecBody(laneCommand, dispatch.workItem, "qa");
|
|
357
|
+
const specPath = path.join(metadataRoot, "spec.md");
|
|
358
|
+
await fs.writeFile(specPath, specBody, "utf8");
|
|
359
|
+
await fs.writeFile(path.join(metadataRoot, "spec.meta.json"), JSON.stringify({ schema_version: 1, status: "approved", produced_by: "forge-lane-command" }) + "\n", "utf8");
|
|
360
|
+
const completionTools = await prepareCompletionToolRuntime({ dispatch, worktree, phase: "qa" });
|
|
361
|
+
const command = buildProviderCliCommand(dispatch, {
|
|
362
|
+
worktreePath: worktree.worktreePath,
|
|
363
|
+
prompt: buildQaPrompt(dispatch, specBody),
|
|
364
|
+
completionTools
|
|
365
|
+
});
|
|
366
|
+
const commandText = formatProviderCliCommand(command);
|
|
367
|
+
await context.emit({
|
|
368
|
+
role: "runner",
|
|
369
|
+
kind: "checkpoint",
|
|
370
|
+
content: `Starting provider CLI QA: ${commandText} in ${worktree.worktreePath}`,
|
|
371
|
+
eventType: "provider_cli_started"
|
|
372
|
+
});
|
|
373
|
+
await context.emit({
|
|
374
|
+
role: "runner",
|
|
375
|
+
kind: "checkpoint",
|
|
376
|
+
content: "Forge QA completion tools configured; provider must call all seven QA MCP gates before exit.",
|
|
377
|
+
eventType: "completion_tools_configured"
|
|
378
|
+
});
|
|
379
|
+
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
380
|
+
const liveQaEvents = new LiveQaArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, dispatch, context.emit);
|
|
381
|
+
let result;
|
|
382
|
+
try {
|
|
383
|
+
liveQaEvents.start();
|
|
384
|
+
result = await this.processRunner.run({
|
|
385
|
+
command: command.command,
|
|
386
|
+
args: command.args,
|
|
387
|
+
cwd: worktree.worktreePath,
|
|
388
|
+
env: providerProcessEnv(dispatch)
|
|
389
|
+
}, {
|
|
390
|
+
onStdoutLine: async (line) => {
|
|
391
|
+
for (const event of outputState.consume(line)) {
|
|
392
|
+
await context.emit(event);
|
|
393
|
+
}
|
|
394
|
+
}
|
|
395
|
+
}, context.signal);
|
|
396
|
+
}
|
|
397
|
+
finally {
|
|
398
|
+
await liveQaEvents.stop();
|
|
399
|
+
await cleanupCompletionTools(completionTools, context.emit);
|
|
400
|
+
}
|
|
401
|
+
if (result.exitCode !== 0) {
|
|
402
|
+
const stderr = clip(result.stderr.trim() || result.stdout.trim(), 1200);
|
|
403
|
+
throw new Error(`${command.command} exited ${result.exitCode}${stderr ? `: ${stderr}` : ""}`);
|
|
404
|
+
}
|
|
405
|
+
await context.emit({
|
|
164
406
|
role: "runner",
|
|
165
407
|
kind: "checkpoint",
|
|
166
408
|
content: `Provider CLI QA completed: ${command.command} exit ${result.exitCode}${outputState.sessionLabel ? ` ${outputState.sessionLabel}` : ""}.`,
|
|
167
409
|
eventType: "provider_cli_completed"
|
|
168
410
|
});
|
|
411
|
+
await emitProviderUsageEvent(context.emit, dispatch, outputState);
|
|
412
|
+
const qaArtifact = await readQaCompletionArtifactBundle(worktree.worktreePath, dispatch.workItem.id, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId);
|
|
413
|
+
if (!qaArtifact) {
|
|
414
|
+
const verdictOnly = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, "qa");
|
|
415
|
+
throw new Error(verdictOnly
|
|
416
|
+
? "Provider CLI QA completed but did not produce the complete durable QA artifact bundle."
|
|
417
|
+
: "Provider CLI QA completed but did not call the Forge QA completion tool.");
|
|
418
|
+
}
|
|
419
|
+
enforceQaBrowserLaunchTargetGate(dispatch, qaArtifact);
|
|
420
|
+
if (!liveQaEvents.hasEmitted()) {
|
|
421
|
+
await emitQaArtifactRecorded(context.emit, worktree.worktreePath, qaArtifact);
|
|
422
|
+
await emitQaStructuredEvents(context.emit, qaArtifact);
|
|
423
|
+
}
|
|
424
|
+
const status = (qaArtifact.status ?? "unknown").trim().toLowerCase();
|
|
425
|
+
const statusSummary = status === "pass"
|
|
426
|
+
? "passed"
|
|
427
|
+
: status === "blocked"
|
|
428
|
+
? "blocked"
|
|
429
|
+
: "found rework";
|
|
169
430
|
return {
|
|
170
|
-
summary: `${dispatch.execution.provider} CLI QA
|
|
431
|
+
summary: `${dispatch.execution.provider} CLI QA ${statusSummary}.`,
|
|
432
|
+
spec: {
|
|
433
|
+
repoPath: worktree.worktreePath,
|
|
434
|
+
path: specPath,
|
|
435
|
+
body: specBody,
|
|
436
|
+
producedBy: "forge-lane-command",
|
|
437
|
+
status: "approved"
|
|
438
|
+
},
|
|
439
|
+
artifact: qaArtifact,
|
|
440
|
+
artifacts: [qaArtifact]
|
|
171
441
|
};
|
|
172
442
|
}
|
|
173
443
|
async runConflictResolve(context) {
|
|
174
444
|
const { dispatch, worktree } = context;
|
|
445
|
+
const addressComments = isPullRequestCommentsDispatch(dispatch);
|
|
175
446
|
const command = buildProviderCliCommand(dispatch, {
|
|
176
447
|
worktreePath: worktree.worktreePath,
|
|
177
|
-
prompt:
|
|
448
|
+
prompt: addressComments
|
|
449
|
+
? buildPullRequestCommentsPrompt(dispatch, worktree.branchName)
|
|
450
|
+
: buildConflictResolvePrompt(dispatch, worktree.branchName)
|
|
178
451
|
});
|
|
179
452
|
await context.emit({
|
|
180
453
|
role: "runner",
|
|
181
454
|
kind: "checkpoint",
|
|
182
|
-
content: `Starting provider CLI conflict resolve: ${formatProviderCliCommand(command)} in ${worktree.worktreePath}`,
|
|
455
|
+
content: `Starting provider CLI ${addressComments ? "PR comment address" : "conflict resolve"}: ${formatProviderCliCommand(command)} in ${worktree.worktreePath}`,
|
|
183
456
|
eventType: "provider_cli_started"
|
|
184
457
|
});
|
|
185
458
|
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
186
459
|
const result = await this.processRunner.run({
|
|
187
460
|
command: command.command,
|
|
188
461
|
args: command.args,
|
|
189
|
-
cwd: worktree.worktreePath
|
|
462
|
+
cwd: worktree.worktreePath,
|
|
463
|
+
env: providerProcessEnv(dispatch)
|
|
190
464
|
}, {
|
|
191
465
|
onStdoutLine: async (line) => {
|
|
192
|
-
const event
|
|
193
|
-
if (event) {
|
|
466
|
+
for (const event of outputState.consume(line)) {
|
|
194
467
|
await context.emit(event);
|
|
195
468
|
}
|
|
196
469
|
}
|
|
@@ -201,14 +474,19 @@ export class ProcessBackedProviderCliService {
|
|
|
201
474
|
}
|
|
202
475
|
const committed = await commitWorktreeChanges(this.git, worktree.worktreePath, dispatch.workItem.id);
|
|
203
476
|
await this.git.run(worktree.worktreePath, ["push", "origin", `HEAD:${worktree.branchName}`]);
|
|
477
|
+
await emitProviderUsageEvent(context.emit, dispatch, outputState);
|
|
204
478
|
await context.emit({
|
|
205
479
|
role: "assistant",
|
|
206
480
|
kind: "message",
|
|
207
|
-
content: outputState.finalMessage ||
|
|
208
|
-
|
|
481
|
+
content: outputState.finalMessage || (addressComments
|
|
482
|
+
? `${dispatch.execution.provider} CLI addressed pull request comments for ${worktree.branchName}.`
|
|
483
|
+
: `${dispatch.execution.provider} CLI resolved merge conflicts for ${worktree.branchName}.`),
|
|
484
|
+
eventType: addressComments ? "pr_comments_complete" : "conflict_resolve_complete"
|
|
209
485
|
});
|
|
210
486
|
return {
|
|
211
|
-
summary:
|
|
487
|
+
summary: addressComments
|
|
488
|
+
? `${dispatch.execution.provider} CLI addressed PR comments on ${worktree.branchName} (${committed.commitSha.slice(0, 12)}).`
|
|
489
|
+
: `${dispatch.execution.provider} CLI resolved conflicts on ${worktree.branchName} (${committed.commitSha.slice(0, 12)}).`
|
|
212
490
|
};
|
|
213
491
|
}
|
|
214
492
|
}
|
|
@@ -217,9 +495,22 @@ export class DeterministicProviderCliService {
|
|
|
217
495
|
constructor(git = new GitClient()) {
|
|
218
496
|
this.git = git;
|
|
219
497
|
}
|
|
498
|
+
async runDraft(context) {
|
|
499
|
+
const content = JSON.stringify(deterministicDraftPayload(context.dispatch));
|
|
500
|
+
await context.emit({
|
|
501
|
+
role: "assistant",
|
|
502
|
+
kind: "message",
|
|
503
|
+
content,
|
|
504
|
+
eventType: "draft_complete"
|
|
505
|
+
});
|
|
506
|
+
await context.emit(buildProviderUsageEvent(context.dispatch, estimatedDeterministicUsage()));
|
|
507
|
+
return { summary: "forge-bridge generated deterministic draft." };
|
|
508
|
+
}
|
|
220
509
|
async runImplementation(context) {
|
|
221
510
|
const { dispatch, worktree } = context;
|
|
222
511
|
const phase = completionPhaseFromDispatch(dispatch);
|
|
512
|
+
const developCycle = usesDevelopCycleCompletion(dispatch);
|
|
513
|
+
const debugCycle = usesDebugCycleCompletion(dispatch);
|
|
223
514
|
const providerCommand = buildProviderCliCommand(dispatch);
|
|
224
515
|
const providerCommandText = formatProviderCliCommand(providerCommand);
|
|
225
516
|
const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
|
|
@@ -250,9 +541,179 @@ export class DeterministicProviderCliService {
|
|
|
250
541
|
content: `Created bridge changeset at ${changesetPath}`,
|
|
251
542
|
eventType: "changeset"
|
|
252
543
|
});
|
|
253
|
-
const
|
|
254
|
-
|
|
255
|
-
|
|
544
|
+
const phases = debugCycle
|
|
545
|
+
? debugCompletionPhaseOrder
|
|
546
|
+
: developCycle
|
|
547
|
+
? ["implementation", "self_review", "validation"]
|
|
548
|
+
: [phase];
|
|
549
|
+
const completionArtifacts = [];
|
|
550
|
+
for (const completionPhase of phases) {
|
|
551
|
+
await writeCompletionArtifact({
|
|
552
|
+
worktreePath: worktree.worktreePath,
|
|
553
|
+
workItemId: dispatch.workItem.id,
|
|
554
|
+
phase: completionPhase,
|
|
555
|
+
producedBy: "forge-bridge",
|
|
556
|
+
redactionSecrets: exactRedactionSecrets(dispatch)
|
|
557
|
+
}, isDebugCompletionPhaseForProvider(completionPhase)
|
|
558
|
+
? expectedDebugCompletionToolName(completionPhase)
|
|
559
|
+
: expectedCompletionToolName(completionPhase), deterministicCompletionPayload(completionPhase, dispatch, changesetBody));
|
|
560
|
+
const completionArtifact = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, completionPhase);
|
|
561
|
+
if (!completionArtifact) {
|
|
562
|
+
throw new Error(`Deterministic provider did not produce the Forge ${completionPhase} completion artifact.`);
|
|
563
|
+
}
|
|
564
|
+
completionArtifacts.push(completionArtifact);
|
|
565
|
+
await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, completionArtifact);
|
|
566
|
+
await context.emit({
|
|
567
|
+
role: "assistant",
|
|
568
|
+
kind: "message",
|
|
569
|
+
content: `${completionPhase.replace(/_/g, " ")} complete. forge-bridge produced deterministic phase artifacts.`,
|
|
570
|
+
eventType: phaseCompleteEventType(completionPhase)
|
|
571
|
+
});
|
|
572
|
+
}
|
|
573
|
+
await context.emit(buildProviderUsageEvent(dispatch, estimatedDeterministicUsage()));
|
|
574
|
+
return {
|
|
575
|
+
summary: `forge-bridge completed ${worktree.branchName} (${debugCycle ? "debug cycle" : developCycle ? "develop cycle" : phase}).`,
|
|
576
|
+
spec: {
|
|
577
|
+
repoPath: worktree.worktreePath,
|
|
578
|
+
path: specPath,
|
|
579
|
+
body: specBody,
|
|
580
|
+
producedBy: "forge-lane-command",
|
|
581
|
+
status: "approved"
|
|
582
|
+
},
|
|
583
|
+
artifact: completionArtifacts[0],
|
|
584
|
+
artifacts: completionArtifacts
|
|
585
|
+
};
|
|
586
|
+
}
|
|
587
|
+
async runArchitect(context) {
|
|
588
|
+
const { dispatch, worktree } = context;
|
|
589
|
+
const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
|
|
590
|
+
await fs.mkdir(metadataRoot, { recursive: true });
|
|
591
|
+
const specBody = `---\ntitle: "${dispatch.workItem.title}"\nstatus: pending_approval\nproduced_by: forge-bridge\n---\n\n# ${dispatch.workItem.title}\n\nArchitect plan pending approval.\n`;
|
|
592
|
+
const specPath = path.join(metadataRoot, "spec.md");
|
|
593
|
+
await fs.writeFile(specPath, specBody, "utf8");
|
|
594
|
+
await fs.writeFile(path.join(metadataRoot, "spec.meta.json"), JSON.stringify({ schema_version: 1, status: "pending_approval", produced_by: "forge-bridge" }) + "\n", "utf8");
|
|
595
|
+
await writeCompletionArtifact({
|
|
596
|
+
worktreePath: worktree.worktreePath,
|
|
597
|
+
workItemId: dispatch.workItem.id,
|
|
598
|
+
phase: "architect",
|
|
599
|
+
producedBy: "forge-bridge",
|
|
600
|
+
redactionSecrets: exactRedactionSecrets(dispatch),
|
|
601
|
+
architectCycle: true
|
|
602
|
+
}, expectedCompletionToolName("architect"), deterministicArchitectPayload(dispatch));
|
|
603
|
+
const artifact = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, "architect");
|
|
604
|
+
if (!artifact) {
|
|
605
|
+
throw new Error("Deterministic provider did not produce the Forge Architect completion artifact.");
|
|
606
|
+
}
|
|
607
|
+
await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, artifact);
|
|
608
|
+
await emitArchitectStructuredEvents(context.emit, worktree.worktreePath, dispatch.workItem.id, artifact);
|
|
609
|
+
await context.emit({
|
|
610
|
+
role: "assistant",
|
|
611
|
+
kind: "message",
|
|
612
|
+
content: "Architect plan complete. forge-bridge produced deterministic planning artifacts.",
|
|
613
|
+
eventType: "architect_complete"
|
|
614
|
+
});
|
|
615
|
+
return {
|
|
616
|
+
summary: "forge-bridge completed Architect plan (deterministic).",
|
|
617
|
+
spec: {
|
|
618
|
+
repoPath: worktree.worktreePath,
|
|
619
|
+
path: specPath,
|
|
620
|
+
body: specBody,
|
|
621
|
+
producedBy: "forge-bridge",
|
|
622
|
+
status: "pending_approval"
|
|
623
|
+
},
|
|
624
|
+
artifact,
|
|
625
|
+
artifacts: [artifact]
|
|
626
|
+
};
|
|
627
|
+
}
|
|
628
|
+
async runQa(context) {
|
|
629
|
+
const { dispatch, worktree } = context;
|
|
630
|
+
await context.emit({
|
|
631
|
+
role: "worker",
|
|
632
|
+
kind: "message",
|
|
633
|
+
content: `Planning ${dispatch.execution.provider} QA checks through forge-bridge.`,
|
|
634
|
+
eventType: "qa_plan"
|
|
635
|
+
});
|
|
636
|
+
const qaBrowser = dispatch.qaBrowser;
|
|
637
|
+
const launchTarget = qaBrowser?.launchTarget ?? null;
|
|
638
|
+
const missingLaunchTarget = qaBrowser?.required === true && !hasLaunchTarget(launchTarget);
|
|
639
|
+
const browserSidecar = !missingLaunchTarget && qaBrowser?.required === true && launchTarget
|
|
640
|
+
? deterministicBrowserSidecar(dispatch.workItem.id, launchTarget, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId)
|
|
641
|
+
: null;
|
|
642
|
+
const browserChecks = browserSidecar && launchTarget
|
|
643
|
+
? [deterministicBrowserCheck(launchTarget, browserSidecar.relativePath)]
|
|
644
|
+
: [];
|
|
645
|
+
const sidecars = await writeQaSidecarFiles(worktree.worktreePath, browserSidecar ? [browserSidecar] : []);
|
|
646
|
+
const summary = missingLaunchTarget
|
|
647
|
+
? "QA blocked because browser testing is required but no app launch target was provided."
|
|
648
|
+
: "All checks passed. forge-bridge QA completed.";
|
|
649
|
+
const criterion = dispatch.workItem.acceptanceCriteria.trim() || "Forge QA evidence exists";
|
|
650
|
+
for (const gate of qaCompletionGateOrder) {
|
|
651
|
+
await writeCompletionArtifact({
|
|
652
|
+
worktreePath: worktree.worktreePath,
|
|
653
|
+
workItemId: dispatch.workItem.id,
|
|
654
|
+
phase: "qa",
|
|
655
|
+
producedBy: "forge-bridge",
|
|
656
|
+
redactionSecrets: exactRedactionSecrets(dispatch),
|
|
657
|
+
qaCycle: true,
|
|
658
|
+
ownerType: dispatch.cycleRun.ownerType ?? undefined,
|
|
659
|
+
ownerId: dispatch.cycleRun.ownerId ?? undefined
|
|
660
|
+
}, expectedQaCompletionToolName(gate), deterministicQaGatePayload({
|
|
661
|
+
gate,
|
|
662
|
+
criterion,
|
|
663
|
+
summary,
|
|
664
|
+
missingLaunchTarget,
|
|
665
|
+
browserChecks,
|
|
666
|
+
sidecars
|
|
667
|
+
}));
|
|
668
|
+
const gateArtifact = await readQaGateArtifact(qaArtifactRootForDispatch(worktree.worktreePath, dispatch.workItem.id, dispatch), gate);
|
|
669
|
+
if (gateArtifact) {
|
|
670
|
+
await emitQaGateAccepted(context.emit, worktree.worktreePath, gateArtifact, nextQaGate(gate));
|
|
671
|
+
}
|
|
672
|
+
}
|
|
673
|
+
const qaArtifact = await readQaCompletionArtifactBundle(worktree.worktreePath, dispatch.workItem.id, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId);
|
|
674
|
+
if (!qaArtifact) {
|
|
675
|
+
throw new Error("Deterministic QA did not produce the complete durable QA artifact bundle.");
|
|
676
|
+
}
|
|
677
|
+
await emitQaArtifactRecorded(context.emit, worktree.worktreePath, qaArtifact);
|
|
678
|
+
await emitQaStructuredEvents(context.emit, qaArtifact);
|
|
679
|
+
await context.emit(buildProviderUsageEvent(dispatch, estimatedDeterministicUsage()));
|
|
680
|
+
return {
|
|
681
|
+
summary: missingLaunchTarget ? "forge-bridge QA blocked." : "forge-bridge QA passed.",
|
|
682
|
+
artifact: qaArtifact,
|
|
683
|
+
artifacts: [qaArtifact]
|
|
684
|
+
};
|
|
685
|
+
}
|
|
686
|
+
async runConflictResolve(context) {
|
|
687
|
+
const { dispatch, worktree } = context;
|
|
688
|
+
const addressComments = isPullRequestCommentsDispatch(dispatch);
|
|
689
|
+
await this.git.run(worktree.worktreePath, ["commit", "--allow-empty", "-m", `forge bridge ${addressComments ? "pr comments" : "conflict resolve"} for ${dispatch.workItem.id.slice(0, 8)}`]);
|
|
690
|
+
await context.emit(buildProviderUsageEvent(dispatch, estimatedDeterministicUsage()));
|
|
691
|
+
await context.emit({
|
|
692
|
+
role: "assistant",
|
|
693
|
+
kind: "message",
|
|
694
|
+
content: addressComments
|
|
695
|
+
? `Deterministic PR comment addressing completed for ${worktree.branchName}.`
|
|
696
|
+
: `Deterministic conflict resolve completed for ${worktree.branchName}.`,
|
|
697
|
+
eventType: addressComments ? "pr_comments_complete" : "conflict_resolve_complete"
|
|
698
|
+
});
|
|
699
|
+
return {
|
|
700
|
+
summary: addressComments
|
|
701
|
+
? `forge-bridge addressed PR comments for ${worktree.branchName}.`
|
|
702
|
+
: `forge-bridge resolved conflicts for ${worktree.branchName}.`
|
|
703
|
+
};
|
|
704
|
+
}
|
|
705
|
+
}
|
|
706
|
+
function phaseCompleteEventType(phase) {
|
|
707
|
+
return phase === "implementation" ? "implementation_complete" : `${phase}_complete`;
|
|
708
|
+
}
|
|
709
|
+
function isDebugCompletionPhaseForProvider(phase) {
|
|
710
|
+
return debugCompletionPhaseOrder.includes(phase);
|
|
711
|
+
}
|
|
712
|
+
function deterministicCompletionPayload(phase, dispatch, changesetBody) {
|
|
713
|
+
const changesetHash = sha256(changesetBody);
|
|
714
|
+
const criterion = dispatch.workItem.acceptanceCriteria || "Deterministic bridge changeset exists";
|
|
715
|
+
if (phase === "implementation") {
|
|
716
|
+
return {
|
|
256
717
|
status: "pass",
|
|
257
718
|
summary: "forge-bridge produced a deterministic implementation changeset.",
|
|
258
719
|
plan: [{ step: "Create deterministic changeset", status: "done" }],
|
|
@@ -261,78 +722,937 @@ export class DeterministicProviderCliService {
|
|
|
261
722
|
docs_added_or_updated: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Deterministic evidence document created for the run." }],
|
|
262
723
|
acceptance_criteria: [
|
|
263
724
|
{
|
|
264
|
-
criterion
|
|
265
|
-
evidence: `FORGE_PHASE5_CHANGESET.md was committed with content hash ${
|
|
725
|
+
criterion,
|
|
726
|
+
evidence: `FORGE_PHASE5_CHANGESET.md was committed with content hash ${changesetHash}.`,
|
|
266
727
|
status: "satisfied"
|
|
267
728
|
}
|
|
268
729
|
],
|
|
269
730
|
known_gaps: [],
|
|
270
|
-
next_phase_context: "Review FORGE_PHASE5_CHANGESET.md and the bridge commit before validation."
|
|
271
|
-
produced_by: "forge-bridge",
|
|
272
|
-
content_hash: sha256(changesetBody)
|
|
731
|
+
next_phase_context: "Review FORGE_PHASE5_CHANGESET.md and the bridge commit before validation."
|
|
273
732
|
};
|
|
274
|
-
|
|
275
|
-
|
|
276
|
-
const artifactPath = completionArtifactJsonPath(worktree.worktreePath, dispatch.workItem.id, "implementation");
|
|
277
|
-
const reportPath = completionArtifactReportPath(worktree.worktreePath, dispatch.workItem.id, "implementation");
|
|
278
|
-
await fs.writeFile(artifactPath, verdictJson + "\n", "utf8");
|
|
279
|
-
await fs.writeFile(reportPath, report, "utf8");
|
|
280
|
-
await context.emit({
|
|
281
|
-
role: "assistant",
|
|
282
|
-
kind: "message",
|
|
283
|
-
content: "Implementation complete. forge-bridge produced deterministic phase artifacts.",
|
|
284
|
-
eventType: "implementation_complete"
|
|
285
|
-
});
|
|
733
|
+
}
|
|
734
|
+
if (phase === "debug_repro") {
|
|
286
735
|
return {
|
|
287
|
-
|
|
288
|
-
|
|
289
|
-
|
|
290
|
-
|
|
291
|
-
|
|
292
|
-
|
|
293
|
-
|
|
736
|
+
status: "pass",
|
|
737
|
+
summary: "forge-bridge reproduced the bug deterministically.",
|
|
738
|
+
repro_steps: ["Run the deterministic fake-worker debug reproduction."],
|
|
739
|
+
observed: "The configured bug scenario is reproducible in deterministic bridge mode.",
|
|
740
|
+
expected: "The bug scenario should be fixed before QA handoff.",
|
|
741
|
+
evidence: [{ kind: "changeset", path: "FORGE_PHASE5_CHANGESET.md", content_hash: changesetHash }]
|
|
742
|
+
};
|
|
743
|
+
}
|
|
744
|
+
if (phase === "debug_root_cause") {
|
|
745
|
+
return {
|
|
746
|
+
status: "pass",
|
|
747
|
+
summary: "forge-bridge isolated a deterministic root cause.",
|
|
748
|
+
root_cause: "The deterministic fake-worker bug is represented by the generated changeset evidence.",
|
|
749
|
+
evidence: [{ kind: "changeset", path: "FORGE_PHASE5_CHANGESET.md", content_hash: changesetHash }],
|
|
750
|
+
eliminated_alternatives: [{ summary: "No alternate deterministic fake-worker path was implicated." }],
|
|
751
|
+
risk_area: "forge-bridge deterministic debug lane"
|
|
752
|
+
};
|
|
753
|
+
}
|
|
754
|
+
if (phase === "debug_fix") {
|
|
755
|
+
return {
|
|
756
|
+
status: "pass",
|
|
757
|
+
summary: "forge-bridge applied a deterministic debug fix.",
|
|
758
|
+
changed_files: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Recorded deterministic debug fix evidence." }],
|
|
759
|
+
tests_added_or_updated: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Deterministic debug evidence doubles as fake-worker regression coverage." }],
|
|
760
|
+
remaining_risks: [],
|
|
761
|
+
resolved_findings: (dispatch.qaRework?.findingIds ?? []).map((qaId) => ({
|
|
762
|
+
qa_id: qaId,
|
|
763
|
+
status: "resolved",
|
|
764
|
+
summary: `Resolved deterministic QA finding ${qaId}.`,
|
|
765
|
+
evidence: { path: "FORGE_PHASE5_CHANGESET.md", content_hash: changesetHash },
|
|
766
|
+
changed_files: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Recorded deterministic debug fix evidence." }],
|
|
767
|
+
tests_added_or_updated: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Deterministic fake-worker regression evidence." }],
|
|
768
|
+
regression_evidence: [{ command: "forge-bridge deterministic debug regression", status: "pass" }]
|
|
769
|
+
}))
|
|
770
|
+
};
|
|
771
|
+
}
|
|
772
|
+
if (phase === "debug_regression") {
|
|
773
|
+
return {
|
|
774
|
+
status: "pass",
|
|
775
|
+
summary: "forge-bridge proved the deterministic debug regression is QA-ready.",
|
|
776
|
+
commands: [{ command: "forge-bridge deterministic debug regression", exit_code: 0, status: "pass", summary: "Deterministic debug regression completed." }],
|
|
777
|
+
required_regressions: ["Original deterministic repro no longer fails."],
|
|
778
|
+
build_status: "not_applicable",
|
|
779
|
+
test_status: "pass",
|
|
780
|
+
repro_negative: true,
|
|
781
|
+
qa_ready: true
|
|
782
|
+
};
|
|
783
|
+
}
|
|
784
|
+
if (phase === "self_review") {
|
|
785
|
+
return {
|
|
786
|
+
status: "pass",
|
|
787
|
+
summary: "forge-bridge fake worker completed deterministic self-review.",
|
|
788
|
+
reviewed_diff: true,
|
|
789
|
+
findings: [],
|
|
790
|
+
security_review: {
|
|
791
|
+
status: "pass",
|
|
792
|
+
notes: "No secret handling, auth, or destructive behavior changes were introduced by the deterministic changeset."
|
|
294
793
|
},
|
|
295
|
-
|
|
296
|
-
|
|
297
|
-
|
|
298
|
-
|
|
299
|
-
|
|
300
|
-
|
|
794
|
+
edge_case_review: {
|
|
795
|
+
status: "pass",
|
|
796
|
+
notes: "The deterministic fake-worker changeset is intentionally narrow and repeatable."
|
|
797
|
+
},
|
|
798
|
+
design_review: {
|
|
799
|
+
status: "not_applicable",
|
|
800
|
+
screenshots: [],
|
|
801
|
+
notes: "No UI changes."
|
|
802
|
+
},
|
|
803
|
+
deterministic_comparison: {
|
|
301
804
|
status: "pass",
|
|
302
|
-
|
|
805
|
+
command_or_tool: "git diff --stat HEAD~1..HEAD",
|
|
806
|
+
notes: `Reviewed deterministic changeset with content hash ${changesetHash}.`
|
|
807
|
+
},
|
|
808
|
+
fixes_applied: [],
|
|
809
|
+
remaining_risks: []
|
|
810
|
+
};
|
|
811
|
+
}
|
|
812
|
+
return {
|
|
813
|
+
status: "pass",
|
|
814
|
+
summary: "forge-bridge fake worker completed deterministic validation.",
|
|
815
|
+
commands: [
|
|
816
|
+
{
|
|
817
|
+
command: "git status --short && git diff --check",
|
|
818
|
+
exit_code: 0,
|
|
819
|
+
status: "pass",
|
|
820
|
+
summary: "Deterministic validation command completed for the fake-worker changeset."
|
|
821
|
+
}
|
|
822
|
+
],
|
|
823
|
+
acceptance_criteria: [
|
|
824
|
+
{
|
|
825
|
+
criterion,
|
|
826
|
+
evidence: `FORGE_PHASE5_CHANGESET.md exists with content hash ${changesetHash}.`,
|
|
827
|
+
status: "satisfied"
|
|
828
|
+
}
|
|
829
|
+
],
|
|
830
|
+
build_status: "pass",
|
|
831
|
+
test_status: "pass",
|
|
832
|
+
lint_status: "not_applicable",
|
|
833
|
+
design_status: "not_applicable",
|
|
834
|
+
drift_checks: [
|
|
835
|
+
{
|
|
836
|
+
command_or_tool: "git diff --check",
|
|
837
|
+
status: "pass",
|
|
838
|
+
summary: "No deterministic drift or whitespace errors were reported for the fake-worker changeset."
|
|
839
|
+
}
|
|
840
|
+
],
|
|
841
|
+
ready_for_dev_test: true
|
|
842
|
+
};
|
|
843
|
+
}
|
|
844
|
+
function deterministicArchitectPayload(dispatch) {
|
|
845
|
+
const planId = `architect-${dispatch.workItem.id.replace(/-/g, "")}`;
|
|
846
|
+
return {
|
|
847
|
+
status: "pass",
|
|
848
|
+
summary: "forge-bridge produced a deterministic Architect plan.",
|
|
849
|
+
implementation_plan: {
|
|
850
|
+
schema_version: 1,
|
|
851
|
+
plan_id: planId,
|
|
852
|
+
story_id: dispatch.workItem.id,
|
|
853
|
+
phases: [
|
|
854
|
+
{ id: "phase-1", name: "Foundation", tasks: ["task-1"], gate: "phase-1-gate" }
|
|
855
|
+
],
|
|
856
|
+
tasks: [
|
|
857
|
+
{
|
|
858
|
+
id: "task-1",
|
|
859
|
+
title: `Implement ${dispatch.workItem.title}`,
|
|
860
|
+
phase: "phase-1",
|
|
861
|
+
summary: "Deterministic bridge Architect task proving MCP artifact contract persistence.",
|
|
862
|
+
acceptance_criteria: [dispatch.workItem.acceptanceCriteria || `Preserve story intent for ${dispatch.workItem.title}`],
|
|
863
|
+
tests: [
|
|
864
|
+
{ command: "dotnet test /home/dillon/repos/Forge/Forge.sln --filter Architect", purpose: "Architect bridge contract regression" }
|
|
865
|
+
]
|
|
866
|
+
}
|
|
867
|
+
],
|
|
868
|
+
dependencies: [],
|
|
869
|
+
phase_gates: [
|
|
870
|
+
{ id: "phase-1-gate", phase: "phase-1", checks: ["Task tests pass", "Artifacts validate"] }
|
|
871
|
+
]
|
|
872
|
+
},
|
|
873
|
+
qa_plan: {
|
|
874
|
+
schema_version: 1,
|
|
875
|
+
plan_id: planId,
|
|
876
|
+
final_qa: [
|
|
877
|
+
{ id: "qa-1", coverage: `Verify Architect plan artifacts and pending approval status for ${dispatch.workItem.title}` }
|
|
878
|
+
]
|
|
879
|
+
},
|
|
880
|
+
report_markdown: `# Architect Report\n\nWork item: ${dispatch.workItem.id}\nTitle: ${dispatch.workItem.title}\n\nVerdict: pass\n\nDeterministic bridge Architect plan produced for pending approval.\n`
|
|
881
|
+
};
|
|
882
|
+
}
|
|
883
|
+
function deterministicQaGatePayload(options) {
|
|
884
|
+
const blocked = options.missingLaunchTarget;
|
|
885
|
+
const skippedBecauseBlocked = blocked
|
|
886
|
+
? {
|
|
887
|
+
status: "skipped",
|
|
888
|
+
summary: "Skipped because browser QA was blocked by missing launch target.",
|
|
889
|
+
reason: "Upstream browser QA blocker prevents meaningful downstream evidence."
|
|
890
|
+
}
|
|
891
|
+
: null;
|
|
892
|
+
switch (options.gate) {
|
|
893
|
+
case "qa_plan":
|
|
894
|
+
return {
|
|
895
|
+
status: "pass",
|
|
896
|
+
summary: "Deterministic QA plan recorded.",
|
|
897
|
+
checklist: [
|
|
898
|
+
"Review the validated work item against acceptance criteria.",
|
|
899
|
+
"Run deterministic regression evidence.",
|
|
900
|
+
"Confirm no in-scope QA findings remain."
|
|
901
|
+
],
|
|
902
|
+
acceptance_criteria: [options.criterion]
|
|
903
|
+
};
|
|
904
|
+
case "qa_regression":
|
|
905
|
+
return {
|
|
906
|
+
status: "pass",
|
|
907
|
+
summary: "Deterministic regression QA completed.",
|
|
908
|
+
commands: [
|
|
909
|
+
{
|
|
910
|
+
command: "forge-bridge deterministic QA",
|
|
911
|
+
exit_code: 0,
|
|
912
|
+
status: "pass",
|
|
913
|
+
summary: "Deterministic regression evidence completed."
|
|
914
|
+
}
|
|
915
|
+
],
|
|
916
|
+
notes: "Regression gate passed in deterministic fake-worker mode."
|
|
917
|
+
};
|
|
918
|
+
case "qa_api":
|
|
919
|
+
return {
|
|
920
|
+
status: "skipped",
|
|
921
|
+
summary: "No API/backend surface was identified for deterministic QA.",
|
|
922
|
+
reason: "The deterministic fake-worker changeset does not exercise API/backend behavior."
|
|
923
|
+
};
|
|
924
|
+
case "qa_manual_web":
|
|
925
|
+
return blocked
|
|
926
|
+
? {
|
|
927
|
+
status: "blocked",
|
|
928
|
+
summary: "Browser QA could not run because no app launch target was provided.",
|
|
929
|
+
blocker_reason: "missing_app_launch_target"
|
|
930
|
+
}
|
|
931
|
+
: options.browserChecks.length > 0
|
|
932
|
+
? {
|
|
933
|
+
status: "pass",
|
|
934
|
+
summary: "Deterministic browser QA exercised the configured launch target.",
|
|
935
|
+
browser_checks: options.browserChecks,
|
|
936
|
+
sidecars: options.sidecars,
|
|
937
|
+
notes: "Browser sidecar evidence recorded."
|
|
938
|
+
}
|
|
939
|
+
: {
|
|
940
|
+
status: "skipped",
|
|
941
|
+
summary: "Manual web QA was not required for this deterministic run.",
|
|
942
|
+
reason: "Forge did not require browser QA and no launch target was necessary."
|
|
943
|
+
};
|
|
944
|
+
case "qa_bug_repro":
|
|
945
|
+
return skippedBecauseBlocked ?? {
|
|
946
|
+
status: "skipped",
|
|
947
|
+
summary: "No failed QA observation required bug reproduction.",
|
|
948
|
+
reason: "No defects or candidate bugs were observed."
|
|
949
|
+
};
|
|
950
|
+
case "qa_findings":
|
|
951
|
+
return skippedBecauseBlocked ?? {
|
|
952
|
+
status: "pass",
|
|
953
|
+
summary: "No QA findings or candidate bugs were identified.",
|
|
954
|
+
findings: [],
|
|
955
|
+
candidate_bugs: []
|
|
956
|
+
};
|
|
957
|
+
case "qa_verdict":
|
|
958
|
+
return {
|
|
959
|
+
status: blocked ? "blocked" : "pass",
|
|
960
|
+
summary: options.summary,
|
|
961
|
+
checklist: [
|
|
962
|
+
"Review the validated work item against acceptance criteria.",
|
|
963
|
+
"Run deterministic regression evidence.",
|
|
964
|
+
blocked ? "Record missing browser launch target blocker." : "Confirm no in-scope QA findings remain."
|
|
965
|
+
],
|
|
966
|
+
tested_acceptance_criteria: blocked ? [] : [options.criterion],
|
|
967
|
+
commands: blocked
|
|
968
|
+
? []
|
|
969
|
+
: [
|
|
970
|
+
{
|
|
971
|
+
command: "forge-bridge deterministic QA",
|
|
972
|
+
exit_code: 0,
|
|
973
|
+
status: "pass",
|
|
974
|
+
summary: "Deterministic QA command completed."
|
|
975
|
+
}
|
|
976
|
+
],
|
|
977
|
+
browser_checks: blocked ? [] : options.browserChecks,
|
|
978
|
+
sidecars: blocked ? [] : options.sidecars,
|
|
979
|
+
notes: options.summary,
|
|
980
|
+
findings: [],
|
|
981
|
+
candidate_bugs: [],
|
|
982
|
+
blocker_reason: blocked ? "missing_app_launch_target" : null,
|
|
983
|
+
report_markdown: `# QA report\n\n${options.summary}\n`
|
|
984
|
+
};
|
|
985
|
+
}
|
|
986
|
+
}
|
|
987
|
+
const qaArtifactFileNames = {
|
|
988
|
+
plan: "qa.plan.json",
|
|
989
|
+
evidence: "qa.evidence.json",
|
|
990
|
+
findings: "qa.findings.json",
|
|
991
|
+
verdict: "qa.verdict.json",
|
|
992
|
+
report: "qa.report.md"
|
|
993
|
+
};
|
|
994
|
+
const qaGateArtifactFileNames = {
|
|
995
|
+
qa_plan: "qa.plan.json",
|
|
996
|
+
qa_regression: "qa.regression.json",
|
|
997
|
+
qa_api: "qa.api.json",
|
|
998
|
+
qa_manual_web: "qa.manual-web.json",
|
|
999
|
+
qa_bug_repro: "qa.bug-repro.json",
|
|
1000
|
+
qa_findings: "qa.findings.json",
|
|
1001
|
+
qa_verdict: "qa.verdict.json"
|
|
1002
|
+
};
|
|
1003
|
+
function hasLaunchTarget(target) {
|
|
1004
|
+
return Boolean(target?.url?.trim()
|
|
1005
|
+
|| target?.ready_url?.trim()
|
|
1006
|
+
|| target?.command?.trim()
|
|
1007
|
+
|| (target?.routes ?? []).some((route) => route.trim().length > 0));
|
|
1008
|
+
}
|
|
1009
|
+
function deterministicBrowserSidecar(workItemId, target, ownerType, ownerId) {
|
|
1010
|
+
const route = primaryLaunchRoute(target);
|
|
1011
|
+
return {
|
|
1012
|
+
relativePath: qaArtifactRelativePath(workItemId, "qa/screenshots/deterministic-browser-check.txt", ownerType, ownerId),
|
|
1013
|
+
content: `Deterministic Forge QA browser evidence\nRoute: ${route}\nConsole errors: []\nNetwork errors: []\nResponsive checks: desktop, mobile\n`
|
|
1014
|
+
};
|
|
1015
|
+
}
|
|
1016
|
+
function deterministicBrowserCheck(target, screenshotPath) {
|
|
1017
|
+
const route = primaryLaunchRoute(target);
|
|
1018
|
+
return {
|
|
1019
|
+
route,
|
|
1020
|
+
url: route,
|
|
1021
|
+
status: "pass",
|
|
1022
|
+
summary: "Deterministic browser QA exercised the configured launch target.",
|
|
1023
|
+
actions: ["open launch target", "walk acceptance criteria", "check console/network summaries", "check responsive viewport"],
|
|
1024
|
+
screenshots: [screenshotPath],
|
|
1025
|
+
console_errors: [],
|
|
1026
|
+
network_errors: [],
|
|
1027
|
+
responsive_checks: ["desktop", "mobile"]
|
|
1028
|
+
};
|
|
1029
|
+
}
|
|
1030
|
+
function primaryLaunchRoute(target) {
|
|
1031
|
+
return target.ready_url?.trim()
|
|
1032
|
+
|| target.url?.trim()
|
|
1033
|
+
|| target.routes.find((route) => route.trim().length > 0)?.trim()
|
|
1034
|
+
|| "app launch command";
|
|
1035
|
+
}
|
|
1036
|
+
async function writeQaSidecarFiles(worktreePath, files) {
|
|
1037
|
+
const sidecars = [];
|
|
1038
|
+
for (const file of files) {
|
|
1039
|
+
const fullPath = path.resolve(worktreePath, file.relativePath);
|
|
1040
|
+
const relativePath = path.relative(worktreePath, fullPath).split(path.sep).join("/");
|
|
1041
|
+
if (relativePath.startsWith("..") || path.isAbsolute(relativePath)) {
|
|
1042
|
+
throw new Error(`QA sidecar path must stay under the worktree: ${file.relativePath}`);
|
|
1043
|
+
}
|
|
1044
|
+
await fs.mkdir(path.dirname(fullPath), { recursive: true });
|
|
1045
|
+
await fs.writeFile(fullPath, file.content, "utf8");
|
|
1046
|
+
sidecars.push({
|
|
1047
|
+
path: relativePath,
|
|
1048
|
+
content_hash: sha256(file.content),
|
|
1049
|
+
bytes: Buffer.byteLength(file.content, "utf8")
|
|
1050
|
+
});
|
|
1051
|
+
}
|
|
1052
|
+
return sidecars;
|
|
1053
|
+
}
|
|
1054
|
+
async function emitQaArtifactRecorded(emit, worktreePath, artifact) {
|
|
1055
|
+
const relativePath = path.relative(worktreePath, artifact.path) || path.basename(artifact.path);
|
|
1056
|
+
await emit({
|
|
1057
|
+
role: "tool",
|
|
1058
|
+
kind: "tool_result",
|
|
1059
|
+
content: `Forge QA artifact recorded ${relativePath} (${artifact.status}).`,
|
|
1060
|
+
eventType: "qa_artifact_recorded"
|
|
1061
|
+
});
|
|
1062
|
+
await emit({
|
|
1063
|
+
role: "hook",
|
|
1064
|
+
kind: "checkpoint",
|
|
1065
|
+
content: `phase_gate: qa artifact accepted with status ${artifact.status}.`,
|
|
1066
|
+
eventType: "phase_gate"
|
|
1067
|
+
});
|
|
1068
|
+
}
|
|
1069
|
+
async function readQaCompletionArtifactBundle(worktreePath, workItemId, ownerType, ownerId) {
|
|
1070
|
+
const artifact = await readCompletionArtifact(worktreePath, workItemId, "qa", ownerType, ownerId);
|
|
1071
|
+
if (!artifact || !await hasCompleteQaArtifactBundle(worktreePath, workItemId, ownerType, ownerId)) {
|
|
1072
|
+
return null;
|
|
1073
|
+
}
|
|
1074
|
+
const artifactRoot = ownerType && ownerId
|
|
1075
|
+
? artifactRootForOwner(worktreePath, ownerType, ownerId)
|
|
1076
|
+
: artifactRootFor(worktreePath, workItemId);
|
|
1077
|
+
const planJson = await fs.readFile(path.join(artifactRoot, qaArtifactFileNames.plan), "utf8");
|
|
1078
|
+
const evidenceJson = await fs.readFile(path.join(artifactRoot, qaArtifactFileNames.evidence), "utf8");
|
|
1079
|
+
const findingsJson = await fs.readFile(path.join(artifactRoot, qaArtifactFileNames.findings), "utf8");
|
|
1080
|
+
await validateQaBundleSidecarReferences(worktreePath, workItemId, ownerType, ownerId);
|
|
1081
|
+
return {
|
|
1082
|
+
...artifact,
|
|
1083
|
+
planJson,
|
|
1084
|
+
evidenceJson,
|
|
1085
|
+
findingsJson
|
|
1086
|
+
};
|
|
1087
|
+
}
|
|
1088
|
+
async function hasCompleteQaArtifactBundle(worktreePath, workItemId, ownerType, ownerId) {
|
|
1089
|
+
const artifactRoot = ownerType && ownerId
|
|
1090
|
+
? artifactRootForOwner(worktreePath, ownerType, ownerId)
|
|
1091
|
+
: artifactRootFor(worktreePath, workItemId);
|
|
1092
|
+
for (const fileName of Object.values(qaArtifactFileNames)) {
|
|
1093
|
+
try {
|
|
1094
|
+
const stat = await fs.stat(path.join(artifactRoot, fileName));
|
|
1095
|
+
if (!stat.isFile()) {
|
|
1096
|
+
return false;
|
|
1097
|
+
}
|
|
1098
|
+
}
|
|
1099
|
+
catch (error) {
|
|
1100
|
+
if (isNodeError(error) && error.code === "ENOENT") {
|
|
1101
|
+
return false;
|
|
1102
|
+
}
|
|
1103
|
+
throw error;
|
|
1104
|
+
}
|
|
1105
|
+
}
|
|
1106
|
+
return true;
|
|
1107
|
+
}
|
|
1108
|
+
function enforceQaBrowserLaunchTargetGate(dispatch, artifact) {
|
|
1109
|
+
const qaBrowser = dispatch.qaBrowser;
|
|
1110
|
+
if (!qaBrowser?.required || hasLaunchTarget(qaBrowser.launchTarget ?? null)) {
|
|
1111
|
+
return;
|
|
1112
|
+
}
|
|
1113
|
+
const verdict = parseJsonLine(artifact.verdictJson) ?? {};
|
|
1114
|
+
const status = normalizedString(stringField(verdict, "status") ?? artifact.status ?? "");
|
|
1115
|
+
const blockerReason = normalizedString(stringField(verdict, "blocker_reason") ?? "");
|
|
1116
|
+
if (status !== "blocked" || blockerReason !== "missing_app_launch_target") {
|
|
1117
|
+
throw new Error("QA browser testing is required but no app launch target was provided; provider must return blocked with blocker_reason missing_app_launch_target.");
|
|
1118
|
+
}
|
|
1119
|
+
}
|
|
1120
|
+
async function validateQaBundleSidecarReferences(worktreePath, workItemId, ownerType, ownerId) {
|
|
1121
|
+
const artifactRoot = ownerType && ownerId
|
|
1122
|
+
? artifactRootForOwner(worktreePath, ownerType, ownerId)
|
|
1123
|
+
: artifactRootFor(worktreePath, workItemId);
|
|
1124
|
+
const evidence = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.evidence));
|
|
1125
|
+
const sidecars = arrayField(evidence, "sidecars");
|
|
1126
|
+
if (sidecars.length === 0) {
|
|
1127
|
+
return;
|
|
1128
|
+
}
|
|
1129
|
+
const qaSidecarRoot = path.resolve(artifactRoot, "qa");
|
|
1130
|
+
for (const [index, sidecar] of sidecars.entries()) {
|
|
1131
|
+
const sidecarPath = stringField(sidecar, "path");
|
|
1132
|
+
const expectedHash = stringField(sidecar, "content_hash");
|
|
1133
|
+
const expectedBytes = sidecar.bytes;
|
|
1134
|
+
if (!sidecarPath || !expectedHash || typeof expectedBytes !== "number" || !Number.isFinite(expectedBytes) || expectedBytes <= 0) {
|
|
1135
|
+
throw new Error(`QA sidecar ${index} must include path, content_hash, and positive bytes.`);
|
|
1136
|
+
}
|
|
1137
|
+
if (path.isAbsolute(sidecarPath)) {
|
|
1138
|
+
throw new Error(`QA sidecar ${index} path must be relative to the worktree.`);
|
|
1139
|
+
}
|
|
1140
|
+
const fullPath = path.resolve(worktreePath, sidecarPath);
|
|
1141
|
+
if (!isPathUnderRoot(qaSidecarRoot, fullPath)) {
|
|
1142
|
+
const ownerDirectory = ownerType && ownerId && ownerType.trim().toLowerCase() === "story" ? "stories" : "work-items";
|
|
1143
|
+
const ownerSegment = ownerType && ownerId ? ownerId : workItemId;
|
|
1144
|
+
throw new Error(`QA sidecar ${index} path must be under .forge/${ownerDirectory}/${ownerSegment}/artifacts/qa/.`);
|
|
1145
|
+
}
|
|
1146
|
+
const stat = await fs.lstat(fullPath).catch((error) => {
|
|
1147
|
+
if (isNodeError(error) && error.code === "ENOENT") {
|
|
1148
|
+
throw new Error(`QA sidecar ${index} file does not exist: ${sidecarPath}`);
|
|
303
1149
|
}
|
|
304
|
-
|
|
1150
|
+
throw error;
|
|
1151
|
+
});
|
|
1152
|
+
if (!stat.isFile() || stat.isSymbolicLink()) {
|
|
1153
|
+
throw new Error(`QA sidecar ${index} must reference a regular file.`);
|
|
1154
|
+
}
|
|
1155
|
+
await ensureNoSymbolicLinkPathSegments(qaSidecarRoot, path.dirname(fullPath), `QA sidecar ${index} path must not traverse symbolic links.`);
|
|
1156
|
+
if (stat.size !== expectedBytes) {
|
|
1157
|
+
throw new Error(`QA sidecar ${index} bytes do not match the referenced file.`);
|
|
1158
|
+
}
|
|
1159
|
+
const actualHash = await sha256File(fullPath);
|
|
1160
|
+
if (actualHash !== expectedHash.trim().toLowerCase()) {
|
|
1161
|
+
throw new Error(`QA sidecar ${index} content_hash does not match the referenced file.`);
|
|
1162
|
+
}
|
|
305
1163
|
}
|
|
306
|
-
|
|
1164
|
+
}
|
|
1165
|
+
async function emitQaStructuredEvents(emit, artifact) {
|
|
1166
|
+
const artifactRoot = path.dirname(artifact.path);
|
|
1167
|
+
const plan = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.plan));
|
|
1168
|
+
const evidence = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.evidence));
|
|
1169
|
+
const findings = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.findings));
|
|
1170
|
+
const verdict = parseJsonLine(artifact.verdictJson) ?? {};
|
|
1171
|
+
const status = stringField(verdict, "status") ?? artifact.status ?? "unknown";
|
|
1172
|
+
const checklist = stringArrayField(plan, "checklist");
|
|
1173
|
+
await emit({
|
|
1174
|
+
role: "worker",
|
|
1175
|
+
kind: "message",
|
|
1176
|
+
content: checklist.length > 0
|
|
1177
|
+
? `QA plan: ${checklist.join("; ")}`
|
|
1178
|
+
: "QA plan recorded.",
|
|
1179
|
+
eventType: "qa_plan"
|
|
1180
|
+
});
|
|
1181
|
+
for (const browserCheck of arrayField(evidence, "browser_checks")) {
|
|
307
1182
|
await emit({
|
|
308
1183
|
role: "worker",
|
|
309
|
-
kind: "
|
|
310
|
-
content: `
|
|
311
|
-
eventType: "
|
|
1184
|
+
kind: "checkpoint",
|
|
1185
|
+
content: `QA browser check: ${summarizeQaObject(browserCheck)}`,
|
|
1186
|
+
eventType: "qa_browser_check"
|
|
312
1187
|
});
|
|
1188
|
+
}
|
|
1189
|
+
for (const finding of [...arrayField(findings, "findings"), ...arrayField(findings, "candidate_bugs")]) {
|
|
313
1190
|
await emit({
|
|
314
|
-
role: "
|
|
315
|
-
kind: "
|
|
316
|
-
content:
|
|
317
|
-
eventType: "
|
|
1191
|
+
role: "worker",
|
|
1192
|
+
kind: "checkpoint",
|
|
1193
|
+
content: `QA finding: ${summarizeQaObject(finding)}`,
|
|
1194
|
+
eventType: "qa_finding"
|
|
318
1195
|
});
|
|
319
|
-
return {
|
|
320
|
-
summary: "forge-bridge QA passed."
|
|
321
|
-
};
|
|
322
1196
|
}
|
|
323
|
-
|
|
324
|
-
|
|
325
|
-
|
|
326
|
-
|
|
327
|
-
|
|
328
|
-
|
|
329
|
-
|
|
330
|
-
|
|
331
|
-
|
|
332
|
-
|
|
333
|
-
|
|
334
|
-
|
|
1197
|
+
await emit({
|
|
1198
|
+
role: "assistant",
|
|
1199
|
+
kind: "message",
|
|
1200
|
+
content: status === "blocked"
|
|
1201
|
+
? `QA blocked: ${stringField(verdict, "summary") ?? "No summary provided."}`
|
|
1202
|
+
: `QA completed with status ${status}: ${stringField(verdict, "summary") ?? "No summary provided."}`,
|
|
1203
|
+
eventType: status === "blocked" ? "qa_blocked" : "qa_complete"
|
|
1204
|
+
});
|
|
1205
|
+
}
|
|
1206
|
+
function qaArtifactRootForDispatch(worktreePath, workItemId, dispatch) {
|
|
1207
|
+
return dispatch.cycleRun.ownerType && dispatch.cycleRun.ownerId
|
|
1208
|
+
? artifactRootForOwner(worktreePath, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId)
|
|
1209
|
+
: artifactRootFor(worktreePath, workItemId);
|
|
1210
|
+
}
|
|
1211
|
+
async function readQaGateArtifact(artifactRoot, gate) {
|
|
1212
|
+
const artifactPath = path.join(artifactRoot, qaGateArtifactFileNames[gate]);
|
|
1213
|
+
try {
|
|
1214
|
+
const stat = await fs.stat(artifactPath);
|
|
1215
|
+
if (!stat.isFile()) {
|
|
1216
|
+
return null;
|
|
1217
|
+
}
|
|
1218
|
+
}
|
|
1219
|
+
catch (error) {
|
|
1220
|
+
if (isNodeError(error) && error.code === "ENOENT") {
|
|
1221
|
+
return null;
|
|
1222
|
+
}
|
|
1223
|
+
throw error;
|
|
1224
|
+
}
|
|
1225
|
+
const payload = await readJsonObjectFile(artifactPath);
|
|
1226
|
+
return {
|
|
1227
|
+
gate,
|
|
1228
|
+
path: artifactPath,
|
|
1229
|
+
status: stringField(payload, "status") ?? "unknown",
|
|
1230
|
+
producedBy: stringField(payload, "produced_by") ?? stringField(payload, "producedBy") ?? undefined,
|
|
1231
|
+
contentHash: stringField(payload, "content_hash") ?? undefined
|
|
1232
|
+
};
|
|
1233
|
+
}
|
|
1234
|
+
function nextQaGate(gate) {
|
|
1235
|
+
const index = qaCompletionGateOrder.indexOf(gate);
|
|
1236
|
+
return index >= 0 ? qaCompletionGateOrder[index + 1] ?? null : null;
|
|
1237
|
+
}
|
|
1238
|
+
async function emitQaGateAccepted(emit, worktreePath, artifact, nextGate) {
|
|
1239
|
+
const relativePath = path.relative(worktreePath, artifact.path).split(path.sep).join("/");
|
|
1240
|
+
await emit({
|
|
1241
|
+
role: "hook",
|
|
1242
|
+
kind: artifact.status === "blocked" ? "error" : "checkpoint",
|
|
1243
|
+
content: `phase_gate: ${artifact.gate} artifact accepted with status ${artifact.status}.`,
|
|
1244
|
+
eventType: "phase_gate",
|
|
1245
|
+
data: JSON.stringify({
|
|
1246
|
+
phase: "qa",
|
|
1247
|
+
qa_gate: artifact.gate,
|
|
1248
|
+
status: artifact.status,
|
|
1249
|
+
artifact_relative_paths: [relativePath],
|
|
1250
|
+
content_hash: artifact.contentHash ?? null,
|
|
1251
|
+
produced_by: artifact.producedBy ?? null
|
|
1252
|
+
})
|
|
1253
|
+
});
|
|
1254
|
+
if (!nextGate) {
|
|
1255
|
+
return;
|
|
1256
|
+
}
|
|
1257
|
+
await emit({
|
|
1258
|
+
role: "hook",
|
|
1259
|
+
kind: "checkpoint",
|
|
1260
|
+
content: `phase_progression: ${artifact.gate} -> ${nextGate}`,
|
|
1261
|
+
eventType: "phase_gate",
|
|
1262
|
+
data: JSON.stringify({
|
|
1263
|
+
phase: "qa",
|
|
1264
|
+
from_gate: artifact.gate,
|
|
1265
|
+
to_gate: nextGate
|
|
1266
|
+
})
|
|
1267
|
+
});
|
|
1268
|
+
}
|
|
1269
|
+
class LiveQaArtifactEmitter {
|
|
1270
|
+
worktreePath;
|
|
1271
|
+
workItemId;
|
|
1272
|
+
dispatch;
|
|
1273
|
+
emit;
|
|
1274
|
+
emittedBundle = false;
|
|
1275
|
+
emittedGates = new Set();
|
|
1276
|
+
timer = null;
|
|
1277
|
+
pending = Promise.resolve();
|
|
1278
|
+
constructor(worktreePath, workItemId, dispatch, emit) {
|
|
1279
|
+
this.worktreePath = worktreePath;
|
|
1280
|
+
this.workItemId = workItemId;
|
|
1281
|
+
this.dispatch = dispatch;
|
|
1282
|
+
this.emit = emit;
|
|
1283
|
+
}
|
|
1284
|
+
start() {
|
|
1285
|
+
void this.pollQueued();
|
|
1286
|
+
this.timer = setInterval(() => {
|
|
1287
|
+
void this.pollQueued();
|
|
1288
|
+
}, 250);
|
|
1289
|
+
}
|
|
1290
|
+
async stop() {
|
|
1291
|
+
if (this.timer) {
|
|
1292
|
+
clearInterval(this.timer);
|
|
1293
|
+
this.timer = null;
|
|
1294
|
+
}
|
|
1295
|
+
await this.pollQueued();
|
|
1296
|
+
}
|
|
1297
|
+
hasEmitted() {
|
|
1298
|
+
return this.emittedBundle;
|
|
1299
|
+
}
|
|
1300
|
+
pollQueued() {
|
|
1301
|
+
this.pending = this.pending
|
|
1302
|
+
.then(() => this.poll())
|
|
1303
|
+
.catch(() => undefined);
|
|
1304
|
+
return this.pending;
|
|
1305
|
+
}
|
|
1306
|
+
async poll() {
|
|
1307
|
+
await this.emitAvailableGateEvents();
|
|
1308
|
+
if (this.emittedBundle) {
|
|
1309
|
+
return;
|
|
1310
|
+
}
|
|
1311
|
+
const artifact = await readQaCompletionArtifactBundle(this.worktreePath, this.workItemId, this.dispatch.cycleRun.ownerType, this.dispatch.cycleRun.ownerId);
|
|
1312
|
+
if (!artifact) {
|
|
1313
|
+
return;
|
|
1314
|
+
}
|
|
1315
|
+
enforceQaBrowserLaunchTargetGate(this.dispatch, artifact);
|
|
1316
|
+
this.emittedBundle = true;
|
|
1317
|
+
await emitQaArtifactRecorded(this.emit, this.worktreePath, artifact);
|
|
1318
|
+
await emitQaStructuredEvents(this.emit, artifact);
|
|
1319
|
+
}
|
|
1320
|
+
async emitAvailableGateEvents() {
|
|
1321
|
+
const artifactRoot = qaArtifactRootForDispatch(this.worktreePath, this.workItemId, this.dispatch);
|
|
1322
|
+
for (const gate of qaCompletionGateOrder) {
|
|
1323
|
+
if (this.emittedGates.has(gate)) {
|
|
1324
|
+
continue;
|
|
1325
|
+
}
|
|
1326
|
+
const artifact = await readQaGateArtifact(artifactRoot, gate);
|
|
1327
|
+
if (!artifact) {
|
|
1328
|
+
return;
|
|
1329
|
+
}
|
|
1330
|
+
this.emittedGates.add(gate);
|
|
1331
|
+
await emitQaGateAccepted(this.emit, this.worktreePath, artifact, nextQaGate(gate));
|
|
1332
|
+
}
|
|
1333
|
+
}
|
|
1334
|
+
}
|
|
1335
|
+
class LiveArchitectArtifactEmitter {
|
|
1336
|
+
worktreePath;
|
|
1337
|
+
workItemId;
|
|
1338
|
+
emit;
|
|
1339
|
+
emitted = false;
|
|
1340
|
+
timer = null;
|
|
1341
|
+
pending = Promise.resolve();
|
|
1342
|
+
constructor(worktreePath, workItemId, emit) {
|
|
1343
|
+
this.worktreePath = worktreePath;
|
|
1344
|
+
this.workItemId = workItemId;
|
|
1345
|
+
this.emit = emit;
|
|
1346
|
+
}
|
|
1347
|
+
start() {
|
|
1348
|
+
void this.pollQueued();
|
|
1349
|
+
this.timer = setInterval(() => {
|
|
1350
|
+
void this.pollQueued();
|
|
1351
|
+
}, 250);
|
|
1352
|
+
}
|
|
1353
|
+
async stop() {
|
|
1354
|
+
if (this.timer) {
|
|
1355
|
+
clearInterval(this.timer);
|
|
1356
|
+
this.timer = null;
|
|
1357
|
+
}
|
|
1358
|
+
await this.pollQueued();
|
|
1359
|
+
}
|
|
1360
|
+
hasEmitted() {
|
|
1361
|
+
return this.emitted;
|
|
1362
|
+
}
|
|
1363
|
+
pollQueued() {
|
|
1364
|
+
this.pending = this.pending
|
|
1365
|
+
.then(() => this.poll())
|
|
1366
|
+
.catch(() => undefined);
|
|
1367
|
+
return this.pending;
|
|
1368
|
+
}
|
|
1369
|
+
async poll() {
|
|
1370
|
+
if (this.emitted || !await hasCompleteArchitectArtifactBundle(this.worktreePath, this.workItemId)) {
|
|
1371
|
+
return;
|
|
1372
|
+
}
|
|
1373
|
+
const artifact = await readCompletionArtifact(this.worktreePath, this.workItemId, "architect");
|
|
1374
|
+
if (!artifact) {
|
|
1375
|
+
return;
|
|
1376
|
+
}
|
|
1377
|
+
this.emitted = true;
|
|
1378
|
+
await emitCompletionArtifactRecorded(this.emit, this.worktreePath, artifact);
|
|
1379
|
+
await emitArchitectStructuredEvents(this.emit, this.worktreePath, this.workItemId, artifact);
|
|
1380
|
+
}
|
|
1381
|
+
}
|
|
1382
|
+
async function hasCompleteArchitectArtifactBundle(worktreePath, workItemId) {
|
|
1383
|
+
const artifactRoot = artifactRootFor(worktreePath, workItemId);
|
|
1384
|
+
for (const fileName of ["implementation.plan.json", "qa.plan.json", "architect.verdict.json", "architect.report.md"]) {
|
|
1385
|
+
try {
|
|
1386
|
+
const stat = await fs.stat(path.join(artifactRoot, fileName));
|
|
1387
|
+
if (!stat.isFile()) {
|
|
1388
|
+
return false;
|
|
1389
|
+
}
|
|
1390
|
+
}
|
|
1391
|
+
catch (error) {
|
|
1392
|
+
if (isNodeError(error) && error.code === "ENOENT") {
|
|
1393
|
+
return false;
|
|
1394
|
+
}
|
|
1395
|
+
throw error;
|
|
1396
|
+
}
|
|
1397
|
+
}
|
|
1398
|
+
return true;
|
|
1399
|
+
}
|
|
1400
|
+
async function emitArchitectStructuredEvents(emit, worktreePath, workItemId, artifact) {
|
|
1401
|
+
const artifactRoot = artifactRootFor(worktreePath, workItemId);
|
|
1402
|
+
const implementationPlan = await readJsonObjectFile(path.join(artifactRoot, "implementation.plan.json"));
|
|
1403
|
+
const qaPlan = await readJsonObjectFile(path.join(artifactRoot, "qa.plan.json"));
|
|
1404
|
+
const verdict = parseJsonLine(artifact.verdictJson) ?? {};
|
|
1405
|
+
const status = stringField(verdict, "status") ?? artifact.status ?? "unknown";
|
|
1406
|
+
const planId = stringField(implementationPlan, "plan_id") ?? "unknown";
|
|
1407
|
+
await emit({
|
|
1408
|
+
role: "worker",
|
|
1409
|
+
kind: "checkpoint",
|
|
1410
|
+
content: `Architect plan recorded: ${planId} with ${arrayField(implementationPlan, "phases").length} phases and ${arrayField(implementationPlan, "tasks").length} tasks.`,
|
|
1411
|
+
eventType: "architect_plan"
|
|
1412
|
+
});
|
|
1413
|
+
await emit({
|
|
1414
|
+
role: "worker",
|
|
1415
|
+
kind: "checkpoint",
|
|
1416
|
+
content: `Architect QA seed recorded with ${arrayField(qaPlan, "final_qa").length} final QA items.`,
|
|
1417
|
+
eventType: "architect_qa_seed"
|
|
1418
|
+
});
|
|
1419
|
+
await emit({
|
|
1420
|
+
role: "hook",
|
|
1421
|
+
kind: status === "pass" ? "checkpoint" : "error",
|
|
1422
|
+
content: `architect_mcp_complete: ${status === "pass" ? "accepted" : "recorded"} - ${stringField(verdict, "summary") ?? "Architect completion payload recorded."}`,
|
|
1423
|
+
eventType: "architect_mcp_complete"
|
|
1424
|
+
});
|
|
1425
|
+
}
|
|
1426
|
+
async function readJsonObjectFile(filePath) {
|
|
1427
|
+
const content = await fs.readFile(filePath, "utf8").catch(() => "");
|
|
1428
|
+
return parseJsonLine(content) ?? {};
|
|
1429
|
+
}
|
|
1430
|
+
function arrayField(source, key) {
|
|
1431
|
+
const value = source[key];
|
|
1432
|
+
if (!Array.isArray(value)) {
|
|
1433
|
+
return [];
|
|
1434
|
+
}
|
|
1435
|
+
return value.filter((entry) => Boolean(entry) && typeof entry === "object" && !Array.isArray(entry));
|
|
1436
|
+
}
|
|
1437
|
+
function stringArrayField(source, key) {
|
|
1438
|
+
const value = source[key];
|
|
1439
|
+
if (!Array.isArray(value)) {
|
|
1440
|
+
return [];
|
|
1441
|
+
}
|
|
1442
|
+
return value.filter((entry) => typeof entry === "string" && entry.trim().length > 0);
|
|
1443
|
+
}
|
|
1444
|
+
function summarizeQaObject(source) {
|
|
1445
|
+
return clip(stringField(source, "title")
|
|
1446
|
+
?? stringField(source, "summary")
|
|
1447
|
+
?? stringField(source, "id")
|
|
1448
|
+
?? JSON.stringify(source), 500);
|
|
1449
|
+
}
|
|
1450
|
+
function qaArtifactRelativePath(workItemId, fileName, ownerType, ownerId) {
|
|
1451
|
+
if (ownerType && ownerId) {
|
|
1452
|
+
const ownerDirectory = ownerType.trim().toLowerCase() === "story" ? "stories" : "work-items";
|
|
1453
|
+
return [".forge", ownerDirectory, ownerId, "artifacts", fileName].join("/");
|
|
1454
|
+
}
|
|
1455
|
+
return [".forge", "work-items", workItemId, "artifacts", fileName].join("/");
|
|
1456
|
+
}
|
|
1457
|
+
async function emitCompletionArtifactRecorded(emit, worktreePath, artifact) {
|
|
1458
|
+
const relativePath = path.relative(worktreePath, artifact.path) || path.basename(artifact.path);
|
|
1459
|
+
await emit({
|
|
1460
|
+
role: "tool",
|
|
1461
|
+
kind: "checkpoint",
|
|
1462
|
+
content: `Forge completion tool validation passed for ${artifact.phase ?? "unknown"} (${artifact.status}).`,
|
|
1463
|
+
eventType: "completion_tool_validation_passed",
|
|
1464
|
+
data: JSON.stringify({
|
|
1465
|
+
phase: artifact.phase ?? "unknown",
|
|
1466
|
+
status: artifact.status,
|
|
1467
|
+
artifact_relative_paths: [relativePath.split(path.sep).join("/")]
|
|
1468
|
+
})
|
|
1469
|
+
});
|
|
1470
|
+
await emit({
|
|
1471
|
+
role: "tool",
|
|
1472
|
+
kind: "tool_result",
|
|
1473
|
+
content: `Forge completion tool recorded ${artifact.phase ?? "unknown"} artifact ${relativePath} (${artifact.status}).`,
|
|
1474
|
+
eventType: "completion_tool_artifact_recorded",
|
|
1475
|
+
data: JSON.stringify({
|
|
1476
|
+
phase: artifact.phase ?? "unknown",
|
|
1477
|
+
status: artifact.status,
|
|
1478
|
+
artifact_relative_paths: [relativePath.split(path.sep).join("/")]
|
|
1479
|
+
})
|
|
1480
|
+
});
|
|
1481
|
+
}
|
|
1482
|
+
async function emitPhaseCompletionEvent(emit, artifact) {
|
|
1483
|
+
const phase = completionPhaseFromArtifact(artifact);
|
|
1484
|
+
await emit({
|
|
1485
|
+
role: "assistant",
|
|
1486
|
+
kind: "message",
|
|
1487
|
+
content: `${phase.replace(/_/g, " ")} completion artifact recorded with status ${artifact.status}.`,
|
|
1488
|
+
eventType: phaseCompleteEventType(phase)
|
|
1489
|
+
});
|
|
1490
|
+
}
|
|
1491
|
+
async function emitPhaseGateEvents(emit, artifact) {
|
|
1492
|
+
const phase = completionPhaseFromArtifact(artifact);
|
|
1493
|
+
const status = (artifact.status ?? "").trim().toLowerCase() || "unknown";
|
|
1494
|
+
await emit({
|
|
1495
|
+
role: "hook",
|
|
1496
|
+
kind: "checkpoint",
|
|
1497
|
+
content: `phase_gate: ${phase} artifact accepted with status ${status}.`,
|
|
1498
|
+
eventType: "phase_gate"
|
|
1499
|
+
});
|
|
1500
|
+
if (status !== "pass") {
|
|
1501
|
+
return;
|
|
1502
|
+
}
|
|
1503
|
+
const progression = phase === "implementation"
|
|
1504
|
+
? "phase_progression: implementation -> self_review"
|
|
1505
|
+
: phase === "self_review"
|
|
1506
|
+
? "phase_progression: self_review -> validation"
|
|
1507
|
+
: phase === "debug_repro"
|
|
1508
|
+
? "phase_progression: debug_repro -> debug_root_cause"
|
|
1509
|
+
: phase === "debug_root_cause"
|
|
1510
|
+
? "phase_progression: debug_root_cause -> debug_fix"
|
|
1511
|
+
: phase === "debug_fix"
|
|
1512
|
+
? "phase_progression: debug_fix -> debug_regression"
|
|
1513
|
+
: phase === "debug_regression"
|
|
1514
|
+
? "phase_progression: debug_regression -> QA ready"
|
|
1515
|
+
: "phase_progression: validation -> QA ready";
|
|
1516
|
+
await emit({
|
|
1517
|
+
role: "hook",
|
|
1518
|
+
kind: "checkpoint",
|
|
1519
|
+
content: progression,
|
|
1520
|
+
eventType: "phase_gate"
|
|
1521
|
+
});
|
|
1522
|
+
}
|
|
1523
|
+
function completionPhaseFromArtifact(artifact) {
|
|
1524
|
+
const phase = artifact.phase?.trim();
|
|
1525
|
+
return phase === "self_review" || phase === "validation" || phase === "implementation" || phase === "qa"
|
|
1526
|
+
|| phase === "architect" || phase === "debug_repro" || phase === "debug_root_cause" || phase === "debug_fix" || phase === "debug_regression"
|
|
1527
|
+
? phase
|
|
1528
|
+
: "implementation";
|
|
1529
|
+
}
|
|
1530
|
+
class LiveCompletionArtifactEmitter {
|
|
1531
|
+
worktreePath;
|
|
1532
|
+
workItemId;
|
|
1533
|
+
emit;
|
|
1534
|
+
phases;
|
|
1535
|
+
emitted = new Set();
|
|
1536
|
+
timer = null;
|
|
1537
|
+
pending = Promise.resolve();
|
|
1538
|
+
constructor(worktreePath, workItemId, phase, developCycle, debugCycle, emit) {
|
|
1539
|
+
this.worktreePath = worktreePath;
|
|
1540
|
+
this.workItemId = workItemId;
|
|
1541
|
+
this.emit = emit;
|
|
1542
|
+
if (debugCycle && isDebugCompletionPhaseForProvider(phase)) {
|
|
1543
|
+
this.phases = debugCompletionPhaseOrder.slice(debugCompletionPhaseOrder.indexOf(phase));
|
|
1544
|
+
}
|
|
1545
|
+
else {
|
|
1546
|
+
this.phases = developCycle
|
|
1547
|
+
? developCyclePhaseOrder.slice(developCyclePhaseOrder.indexOf(phase))
|
|
1548
|
+
: [phase];
|
|
1549
|
+
}
|
|
1550
|
+
}
|
|
1551
|
+
start() {
|
|
1552
|
+
void this.pollQueued();
|
|
1553
|
+
this.timer = setInterval(() => {
|
|
1554
|
+
void this.pollQueued();
|
|
1555
|
+
}, 250);
|
|
1556
|
+
}
|
|
1557
|
+
async stop() {
|
|
1558
|
+
if (this.timer) {
|
|
1559
|
+
clearInterval(this.timer);
|
|
1560
|
+
this.timer = null;
|
|
1561
|
+
}
|
|
1562
|
+
await this.pollQueued();
|
|
335
1563
|
}
|
|
1564
|
+
hasEmitted(phase) {
|
|
1565
|
+
return this.emitted.has(phase);
|
|
1566
|
+
}
|
|
1567
|
+
pollQueued() {
|
|
1568
|
+
this.pending = this.pending
|
|
1569
|
+
.then(() => this.poll())
|
|
1570
|
+
.catch(() => undefined);
|
|
1571
|
+
return this.pending;
|
|
1572
|
+
}
|
|
1573
|
+
async poll() {
|
|
1574
|
+
for (const phase of this.phases) {
|
|
1575
|
+
if (this.emitted.has(phase)) {
|
|
1576
|
+
continue;
|
|
1577
|
+
}
|
|
1578
|
+
const artifact = await readCompletionArtifact(this.worktreePath, this.workItemId, phase);
|
|
1579
|
+
if (!artifact) {
|
|
1580
|
+
return;
|
|
1581
|
+
}
|
|
1582
|
+
this.emitted.add(phase);
|
|
1583
|
+
await emitCompletionArtifactRecorded(this.emit, this.worktreePath, artifact);
|
|
1584
|
+
await emitPhaseCompletionEvent(this.emit, artifact);
|
|
1585
|
+
await emitPhaseGateEvents(this.emit, artifact);
|
|
1586
|
+
if ((artifact.status ?? "").trim().toLowerCase() !== "pass") {
|
|
1587
|
+
return;
|
|
1588
|
+
}
|
|
1589
|
+
}
|
|
1590
|
+
}
|
|
1591
|
+
}
|
|
1592
|
+
async function readCompletionArtifactsForRun(worktreePath, workItemId, phase, developCycle, debugCycle) {
|
|
1593
|
+
if (!developCycle && !debugCycle) {
|
|
1594
|
+
const artifact = await readCompletionArtifact(worktreePath, workItemId, phase);
|
|
1595
|
+
if (!artifact) {
|
|
1596
|
+
throw new Error(`Provider CLI completed but did not call the Forge ${phase} completion tool.`);
|
|
1597
|
+
}
|
|
1598
|
+
return [artifact];
|
|
1599
|
+
}
|
|
1600
|
+
const expectedPhases = debugCycle && isDebugCompletionPhaseForProvider(phase)
|
|
1601
|
+
? debugCompletionPhaseOrder.slice(debugCompletionPhaseOrder.indexOf(phase))
|
|
1602
|
+
: ["implementation", "self_review", "validation"];
|
|
1603
|
+
const artifacts = [];
|
|
1604
|
+
for (const expectedPhase of expectedPhases) {
|
|
1605
|
+
const artifact = await readCompletionArtifact(worktreePath, workItemId, expectedPhase);
|
|
1606
|
+
if (!artifact) {
|
|
1607
|
+
if (artifacts.length === 0) {
|
|
1608
|
+
throw new Error(`Provider CLI completed but did not call the Forge ${expectedPhase} completion tool.`);
|
|
1609
|
+
}
|
|
1610
|
+
const previous = artifacts[artifacts.length - 1];
|
|
1611
|
+
if ((previous.status ?? "").trim().toLowerCase() === "pass") {
|
|
1612
|
+
throw new Error(`Provider CLI completed after ${previous.phase} passed but did not call the Forge ${expectedPhase} completion tool.`);
|
|
1613
|
+
}
|
|
1614
|
+
return artifacts;
|
|
1615
|
+
}
|
|
1616
|
+
artifacts.push(artifact);
|
|
1617
|
+
if ((artifact.status ?? "").trim().toLowerCase() !== "pass") {
|
|
1618
|
+
return artifacts;
|
|
1619
|
+
}
|
|
1620
|
+
}
|
|
1621
|
+
return artifacts;
|
|
1622
|
+
}
|
|
1623
|
+
function providerProcessEnv(dispatch) {
|
|
1624
|
+
const env = {
|
|
1625
|
+
...completionRedactionEnv(exactRedactionSecrets(dispatch)),
|
|
1626
|
+
...providerCredentialEnv(dispatch)
|
|
1627
|
+
};
|
|
1628
|
+
return Object.keys(env).length > 0 ? env : undefined;
|
|
1629
|
+
}
|
|
1630
|
+
function providerCredentialEnv(dispatch) {
|
|
1631
|
+
const secret = dispatch.apiKeySecretGrant?.secret;
|
|
1632
|
+
if (!secret || !dispatch.execution.requiresApiKeySecretGrant) {
|
|
1633
|
+
return {};
|
|
1634
|
+
}
|
|
1635
|
+
const provider = dispatch.execution.provider.trim().toLowerCase();
|
|
1636
|
+
if (provider === "codex" || provider === "openai") {
|
|
1637
|
+
return { OPENAI_API_KEY: secret };
|
|
1638
|
+
}
|
|
1639
|
+
return {};
|
|
1640
|
+
}
|
|
1641
|
+
function exactRedactionSecrets(dispatch) {
|
|
1642
|
+
return dispatch.apiKeySecretGrant?.secret ? [dispatch.apiKeySecretGrant.secret] : [];
|
|
1643
|
+
}
|
|
1644
|
+
async function emitProviderUsageEvent(emit, dispatch, outputState) {
|
|
1645
|
+
const usage = outputState.usage;
|
|
1646
|
+
if (hasUsage(usage)) {
|
|
1647
|
+
await emit(buildProviderUsageEvent(dispatch, usage));
|
|
1648
|
+
}
|
|
1649
|
+
}
|
|
1650
|
+
function estimatedDeterministicUsage() {
|
|
1651
|
+
return addUsage(emptyUsage("estimated"), {
|
|
1652
|
+
inputTokens: 1000,
|
|
1653
|
+
outputTokens: 400,
|
|
1654
|
+
source: "estimated"
|
|
1655
|
+
});
|
|
336
1656
|
}
|
|
337
1657
|
export class StreamingProviderProcessRunner {
|
|
338
1658
|
async run(request, handlers = {}, signal) {
|
|
@@ -340,6 +1660,7 @@ export class StreamingProviderProcessRunner {
|
|
|
340
1660
|
return await new Promise((resolve, reject) => {
|
|
341
1661
|
const child = spawn(launch.command, launch.args, {
|
|
342
1662
|
cwd: request.cwd,
|
|
1663
|
+
env: buildProviderChildEnvironment(request.env),
|
|
343
1664
|
stdio: ["ignore", "pipe", "pipe"],
|
|
344
1665
|
windowsHide: true
|
|
345
1666
|
});
|
|
@@ -474,9 +1795,6 @@ function quoteWindowsCommandLineArg(value) {
|
|
|
474
1795
|
}
|
|
475
1796
|
return `"${value.replace(/(\\*)"/g, '$1$1\\"').replace(/(\\+)$/g, "$1$1")}"`;
|
|
476
1797
|
}
|
|
477
|
-
async function fileExists(inputPath) {
|
|
478
|
-
return fs.stat(inputPath).then((stat) => stat.isFile()).catch(() => false);
|
|
479
|
-
}
|
|
480
1798
|
async function readProcessLines(stream, onLine) {
|
|
481
1799
|
const reader = readline.createInterface({ input: stream });
|
|
482
1800
|
try {
|
|
@@ -494,12 +1812,69 @@ function isFakeWorkerModel(model) {
|
|
|
494
1812
|
function sha256(content) {
|
|
495
1813
|
return crypto.createHash("sha256").update(content).digest("hex");
|
|
496
1814
|
}
|
|
1815
|
+
function buildDraftPrompt(dispatch) {
|
|
1816
|
+
const draft = dispatch.draft;
|
|
1817
|
+
if (!draft) {
|
|
1818
|
+
throw new Error("Draft prompt is missing.");
|
|
1819
|
+
}
|
|
1820
|
+
return `${draft.systemPrompt}
|
|
1821
|
+
|
|
1822
|
+
Draft kind: ${draft.kind}
|
|
1823
|
+
|
|
1824
|
+
${draft.userPrompt}
|
|
1825
|
+
|
|
1826
|
+
Return ONLY the requested JSON object. Do not wrap it in markdown and do not modify files.`;
|
|
1827
|
+
}
|
|
1828
|
+
function extractJsonObject(content) {
|
|
1829
|
+
let trimmed = content.trim();
|
|
1830
|
+
if (trimmed.startsWith("```")) {
|
|
1831
|
+
const firstNewline = trimmed.indexOf("\n");
|
|
1832
|
+
const lastFence = trimmed.lastIndexOf("```");
|
|
1833
|
+
if (firstNewline >= 0 && lastFence > firstNewline) {
|
|
1834
|
+
trimmed = trimmed.slice(firstNewline + 1, lastFence).trim();
|
|
1835
|
+
}
|
|
1836
|
+
}
|
|
1837
|
+
const start = trimmed.indexOf("{");
|
|
1838
|
+
const end = trimmed.lastIndexOf("}");
|
|
1839
|
+
return start >= 0 && end >= start ? trimmed.slice(start, end + 1) : trimmed;
|
|
1840
|
+
}
|
|
1841
|
+
function summarizeStderr(stderr) {
|
|
1842
|
+
const trimmed = stderr.trim();
|
|
1843
|
+
return trimmed ? `: ${clip(trimmed, 1000)}` : "";
|
|
1844
|
+
}
|
|
1845
|
+
function deterministicDraftPayload(dispatch) {
|
|
1846
|
+
const kind = dispatch.draft?.kind ?? "work_item";
|
|
1847
|
+
if (kind === "work_order") {
|
|
1848
|
+
return {
|
|
1849
|
+
title: "Deterministic runner Work Order draft",
|
|
1850
|
+
summary: "Forge Runner generated this deterministic Work Order draft.",
|
|
1851
|
+
objective: "Validate runner-backed Draft generation.",
|
|
1852
|
+
planningPacket: "Runner-backed draft generation returned a Work Order JSON payload.",
|
|
1853
|
+
decompositionContext: "Use this deterministic fixture only in bridge tests.",
|
|
1854
|
+
assumptions: ["Forge Runner dispatch is available."],
|
|
1855
|
+
warnings: []
|
|
1856
|
+
};
|
|
1857
|
+
}
|
|
1858
|
+
if (kind === "story") {
|
|
1859
|
+
return {
|
|
1860
|
+
title: "Deterministic runner Story draft",
|
|
1861
|
+
description: "Forge Runner generated this deterministic Story draft.",
|
|
1862
|
+
acceptanceCriteria: "Given runner-backed Draft generation, when Forge requests a Story draft, then JSON is returned.",
|
|
1863
|
+
points: 3
|
|
1864
|
+
};
|
|
1865
|
+
}
|
|
1866
|
+
return {
|
|
1867
|
+
title: "Deterministic runner Work Item draft",
|
|
1868
|
+
description: "Forge Runner generated this deterministic Work Item draft.",
|
|
1869
|
+
acceptanceCriteria: "Given runner-backed Draft generation, when Forge requests a draft, then JSON is returned.",
|
|
1870
|
+
reproSteps: "Run Draft with a Forge Runner provider selected.",
|
|
1871
|
+
systemInfo: "forge-bridge deterministic provider",
|
|
1872
|
+
points: 1
|
|
1873
|
+
};
|
|
1874
|
+
}
|
|
497
1875
|
export function formatProviderCliCommand(command) {
|
|
498
1876
|
return [command.command, ...command.args].map(singleLine).join(" ");
|
|
499
1877
|
}
|
|
500
|
-
function yamlQuotedScalar(value) {
|
|
501
|
-
return JSON.stringify(singleLine(value));
|
|
502
|
-
}
|
|
503
1878
|
function singleLine(value) {
|
|
504
1879
|
return value.replace(/\s+/g, " ").trim();
|
|
505
1880
|
}
|
|
@@ -508,16 +1883,19 @@ export function buildProviderCliCommand(dispatch, run) {
|
|
|
508
1883
|
const normalizedProvider = provider.toLowerCase();
|
|
509
1884
|
const model = dispatch.execution.model.trim();
|
|
510
1885
|
if (normalizedProvider === "codex") {
|
|
511
|
-
const args = ["exec"];
|
|
1886
|
+
const args = run ? ["-s", "workspace-write", "-a", "never", "exec"] : ["exec"];
|
|
512
1887
|
if (run?.completionTools) {
|
|
513
1888
|
args.push(...codexMcpConfigArgs(run.completionTools));
|
|
514
1889
|
}
|
|
515
1890
|
args.push("--model", model);
|
|
516
1891
|
if (run) {
|
|
517
|
-
args.push("--json"
|
|
1892
|
+
args.push("--json");
|
|
518
1893
|
if (run.worktreePath) {
|
|
519
1894
|
args.push("--cd", run.worktreePath);
|
|
520
1895
|
}
|
|
1896
|
+
if (run.skipGitRepoCheck) {
|
|
1897
|
+
args.push("--skip-git-repo-check");
|
|
1898
|
+
}
|
|
521
1899
|
args.push(run.prompt ?? "");
|
|
522
1900
|
}
|
|
523
1901
|
return { command: "codex", args };
|
|
@@ -538,11 +1916,37 @@ export function buildProviderCliCommand(dispatch, run) {
|
|
|
538
1916
|
}
|
|
539
1917
|
return { command: provider, args };
|
|
540
1918
|
}
|
|
1919
|
+
function buildArchitectPrompt(dispatch) {
|
|
1920
|
+
return `You are Forge's Architect lane running locally in a prepared git worktree.
|
|
1921
|
+
|
|
1922
|
+
Work item: ${dispatch.workItem.id} — ${dispatch.workItem.title}
|
|
1923
|
+
|
|
1924
|
+
Plan only. Do not implement source changes, do not create Develop phase artifacts, and do not mark the spec approved.
|
|
1925
|
+
Read injected Forge context under .forge plus the repository shape, then produce a repo-grounded implementation DAG with task tests, phase gates, final QA coverage, and a pending-approval spec.
|
|
1926
|
+
${architectRevisionInstruction(dispatch)}
|
|
1927
|
+
Forge owns protocol files: write Architect artifacts only through the completion MCP tool.
|
|
1928
|
+
|
|
1929
|
+
${completionPromptForPhase("architect")}
|
|
1930
|
+
|
|
1931
|
+
Finish only after calling forge.complete_architect_plan with implementation_plan, qa_plan, status, summary, and report/report_markdown.`;
|
|
1932
|
+
}
|
|
1933
|
+
function architectRevisionInstruction(dispatch) {
|
|
1934
|
+
if (!dispatch.architectRevision) {
|
|
1935
|
+
return "";
|
|
1936
|
+
}
|
|
1937
|
+
return `
|
|
1938
|
+
Architect revision context:
|
|
1939
|
+
- Previous plan id: ${dispatch.architectRevision.priorPlanId}
|
|
1940
|
+
- Previous content hash: ${dispatch.architectRevision.priorContentHash}
|
|
1941
|
+
- Reviewer feedback: ${dispatch.architectRevision.feedback}
|
|
1942
|
+
Revise the prior plan in response to the feedback. Preserve accepted scope and only change what the feedback requires.`;
|
|
1943
|
+
}
|
|
541
1944
|
function buildImplementationPrompt(dispatch, phase = completionPhaseFromDispatch(dispatch)) {
|
|
542
1945
|
return `You are Forge's ${phase.replace(/_/g, " ")} phase runner running locally in a prepared git worktree.
|
|
543
1946
|
|
|
544
1947
|
Read .forge/work-items/${dispatch.workItem.id}/spec.md and any prior phase artifacts required by this phase.
|
|
545
1948
|
${phaseWorkInstruction(phase)}
|
|
1949
|
+
${qaReworkImplementationInstruction(dispatch)}
|
|
546
1950
|
Use the repository's existing conventions. Run relevant tests when practical.
|
|
547
1951
|
Forge owns protocol files: worktree prep, injected .forge commands/hooks/skills, phase verdict artifacts, reports, and commits.
|
|
548
1952
|
Read Forge-provided context under .forge when needed, but do not edit .forge files or create Forge verdict/report artifacts by hand.
|
|
@@ -551,20 +1955,162 @@ ${completionPromptForPhase(phase)}
|
|
|
551
1955
|
|
|
552
1956
|
Finish with a concise summary of changed files and verification after calling the completion tool.`;
|
|
553
1957
|
}
|
|
1958
|
+
function buildDevelopCyclePrompt(dispatch, phase = completionPhaseFromDispatch(dispatch)) {
|
|
1959
|
+
return `You are Forge's develop-cycle runner running locally in a prepared git worktree.
|
|
1960
|
+
|
|
1961
|
+
Read .forge/work-items/${dispatch.workItem.id}/spec.md, implement the work item, self-review the diff, then validate it in this same provider session.
|
|
1962
|
+
Start in the ${phase.replace(/_/g, " ")} phase. Do not stop after implementation if it passes; continue through self-review and validation using the next instruction returned by each completion tool.
|
|
1963
|
+
${qaReworkImplementationInstruction(dispatch)}
|
|
1964
|
+
Use the repository's existing conventions. Run relevant tests when practical.
|
|
1965
|
+
Forge owns protocol files: worktree prep, injected .forge commands/hooks/skills, phase verdict artifacts, reports, and commits.
|
|
1966
|
+
Read Forge-provided context under .forge when needed, but do not edit .forge files or create Forge verdict/report artifacts by hand.
|
|
1967
|
+
|
|
1968
|
+
${completionPromptForDevelopCycle(phase)}
|
|
1969
|
+
|
|
1970
|
+
Finish with a concise summary of changed files and verification after the validation completion tool has accepted the work, or after the current phase tool records a non-pass blocker.`;
|
|
1971
|
+
}
|
|
1972
|
+
function buildDebugCyclePrompt(dispatch, phase = completionPhaseFromDispatch(dispatch)) {
|
|
1973
|
+
return `You are Forge's Debug lane running locally in a prepared git worktree for a bug work item.
|
|
1974
|
+
|
|
1975
|
+
Read .forge/work-items/${dispatch.workItem.id}/spec.md, reproduce or characterize the bug, isolate root cause, apply the smallest safe fix, then prove the regression in this same provider session.
|
|
1976
|
+
Start in the ${phase.replace(/_/g, " ")} gate. Do not stop after a passing Debug gate; continue through the next Debug MCP instruction returned by the tool server until debug_regression is accepted or the current gate records a non-pass blocker.
|
|
1977
|
+
${debugQaReworkInstruction(dispatch)}
|
|
1978
|
+
Use the repository's existing conventions. Run focused tests when practical, especially the original repro and required regressions.
|
|
1979
|
+
Forge owns protocol files: worktree prep, injected .forge commands/hooks/skills, Debug verdict artifacts, reports, and commits.
|
|
1980
|
+
Read Forge-provided context under .forge when needed, but do not edit .forge files or create Forge Debug artifacts by hand.
|
|
1981
|
+
|
|
1982
|
+
${completionPromptForDebugCycle(isDebugCompletionPhaseForProvider(phase) ? phase : "debug_repro")}
|
|
1983
|
+
|
|
1984
|
+
Finish with a concise summary of changed files and verification after the debug_regression completion tool has accepted the work, or after the current Debug gate tool records a non-pass blocker.`;
|
|
1985
|
+
}
|
|
1986
|
+
function qaReworkImplementationInstruction(dispatch) {
|
|
1987
|
+
if (!dispatch.qaRework) {
|
|
1988
|
+
return "";
|
|
1989
|
+
}
|
|
1990
|
+
return `
|
|
1991
|
+
QA rework context:
|
|
1992
|
+
- Attempt ${dispatch.qaRework.attempt}/${dispatch.qaRework.maxAttempts}
|
|
1993
|
+
- Rework packet: ${dispatch.qaRework.packetPath}
|
|
1994
|
+
- Required QA finding IDs: ${dispatch.qaRework.findingIds.join(", ")}
|
|
1995
|
+
Read the packet JSON and fix or explicitly dispute each listed finding. The implementation completion artifact must include resolved_findings entries for every required QA ID with qa_id, status, summary, evidence, changed_files, tests_added_or_updated, and regression_evidence.
|
|
1996
|
+
Use only these resolved_findings status values: resolved, disputed, or not_reproduced. Use resolved when the finding was fixed; do not use fixed.`;
|
|
1997
|
+
}
|
|
1998
|
+
function debugQaReworkInstruction(dispatch) {
|
|
1999
|
+
if (!dispatch.qaRework) {
|
|
2000
|
+
return "";
|
|
2001
|
+
}
|
|
2002
|
+
return `
|
|
2003
|
+
QA rework context for Debug:
|
|
2004
|
+
- Attempt ${dispatch.qaRework.attempt}/${dispatch.qaRework.maxAttempts}
|
|
2005
|
+
- Rework packet: ${dispatch.qaRework.packetPath}
|
|
2006
|
+
- Required QA finding IDs: ${dispatch.qaRework.findingIds.join(", ")}
|
|
2007
|
+
Read the packet JSON, reproduce or characterize each listed finding, fix or explicitly dispute it, and include resolved_findings entries for every required QA ID in forge.complete_debug_fix with qa_id, status, summary, evidence, changed_files, tests_added_or_updated, and regression_evidence.
|
|
2008
|
+
Use only these resolved_findings status values: resolved, disputed, or not_reproduced. Use resolved when the finding was fixed; do not use fixed.`;
|
|
2009
|
+
}
|
|
2010
|
+
function qaReworkRetestInstruction(dispatch) {
|
|
2011
|
+
if (!dispatch.qaRework) {
|
|
2012
|
+
return "";
|
|
2013
|
+
}
|
|
2014
|
+
return `
|
|
2015
|
+
QA retest context:
|
|
2016
|
+
- Rework attempt ${dispatch.qaRework.attempt}/${dispatch.qaRework.maxAttempts}
|
|
2017
|
+
- Rework packet: ${dispatch.qaRework.packetPath}
|
|
2018
|
+
- Priority finding IDs: ${dispatch.qaRework.findingIds.join(", ")}
|
|
2019
|
+
Prioritize retesting the listed QA findings and their required regressions before deciding pass, needs_rework, or blocked.`;
|
|
2020
|
+
}
|
|
554
2021
|
function phaseWorkInstruction(phase) {
|
|
555
2022
|
if (phase === "self_review") {
|
|
556
2023
|
return "Review the implementation diff, apply safe fixes when needed, and record remaining risks explicitly.";
|
|
557
2024
|
}
|
|
558
2025
|
if (phase === "validation") {
|
|
559
|
-
return "Run the validation commands and deterministic drift checks needed to prove the work is ready for
|
|
2026
|
+
return "Run the validation commands and deterministic drift checks needed to prove the work is ready for QA.";
|
|
560
2027
|
}
|
|
561
2028
|
return "Implement the work item and keep the change focused.";
|
|
562
2029
|
}
|
|
563
|
-
function
|
|
564
|
-
|
|
2030
|
+
function qaBrowserInstruction(dispatch) {
|
|
2031
|
+
const qaBrowser = dispatch.qaBrowser;
|
|
2032
|
+
if (!qaBrowser) {
|
|
2033
|
+
return "Browser/app launch context: not provided by Forge.";
|
|
2034
|
+
}
|
|
2035
|
+
const launchTarget = qaBrowser.launchTarget;
|
|
2036
|
+
if (qaBrowser.required && !hasLaunchTarget(launchTarget ?? null)) {
|
|
2037
|
+
return `Browser/app launch context:\n- UI/browser QA is required for this item.\n- No app launch target was provided.\n- Return blocked with blocker_reason: missing_app_launch_target instead of pretending browser testing occurred.\n- Artifact sidecars path when available: ${qaBrowser.artifactsPath || `.forge/work-items/${dispatch.workItem.id}/artifacts/qa`}`;
|
|
2038
|
+
}
|
|
2039
|
+
if (!launchTarget) {
|
|
2040
|
+
return `Browser/app launch context:\n- UI/browser QA is not required by Forge heuristics for this item.\n- If you determine browser testing is needed, return blocked with blocker_reason: missing_app_launch_target unless you can safely identify a launch target from the repo.\n- Browser sidecars path: ${qaBrowser.artifactsPath || `.forge/work-items/${dispatch.workItem.id}/artifacts/qa`}`;
|
|
2041
|
+
}
|
|
2042
|
+
const routes = launchTarget.routes.length > 0 ? launchTarget.routes.join(", ") : "not specified";
|
|
2043
|
+
return `Browser/app launch context:\n- Browser QA required: ${qaBrowser.required ? "yes" : "no, unless the diff/AC requires it"}\n- URL: ${launchTarget.url || "not specified"}\n- Ready URL: ${launchTarget.ready_url || "not specified"}\n- Launch command: ${launchTarget.command || "not specified"}\n- Working directory: ${launchTarget.working_directory || "repo root"}\n- Routes to cover: ${routes}\n- Notes: ${launchTarget.notes || "none"}\n- Browser sidecars path: ${qaBrowser.artifactsPath || `.forge/work-items/${dispatch.workItem.id}/artifacts/qa`}`;
|
|
2044
|
+
}
|
|
2045
|
+
function storyQaInstruction(dispatch) {
|
|
2046
|
+
const storyQa = dispatch.storyQa;
|
|
2047
|
+
if (!storyQa) {
|
|
2048
|
+
return "";
|
|
2049
|
+
}
|
|
2050
|
+
const childLines = storyQa.childTasks.map((child) => {
|
|
2051
|
+
const dependencies = child.dependencyWorkItemIds.length > 0
|
|
2052
|
+
? child.dependencyWorkItemIds.join(", ")
|
|
2053
|
+
: "none";
|
|
2054
|
+
const validation = child.validationArtifact
|
|
2055
|
+
? `${child.validationArtifact.status} (${child.validationArtifact.path || "artifact path unavailable"})`
|
|
2056
|
+
: "missing";
|
|
2057
|
+
const childQa = child.qaArtifact
|
|
2058
|
+
? `${child.qaArtifact.status} (${child.qaArtifact.path || "artifact path unavailable"})`
|
|
2059
|
+
: "not present";
|
|
2060
|
+
return `- ${child.title} (${child.workItemId}, architect ${child.architectTaskId}, phase ${child.phaseId}/${child.phaseOrder}); deps: ${dependencies}; validation: ${validation}; child QA: ${childQa}`;
|
|
2061
|
+
}).join("\n");
|
|
2062
|
+
const finalQa = storyQa.finalQaChecks.length > 0
|
|
2063
|
+
? storyQa.finalQaChecks.map((check) => `- ${check}`).join("\n")
|
|
2064
|
+
: "- No final QA checks were provided in qa.plan.final_qa.";
|
|
2065
|
+
return `Story QA integration context:
|
|
2066
|
+
- Story work item: ${storyQa.storyWorkItemId}
|
|
2067
|
+
- Plan: ${storyQa.planId} / ${storyQa.planContentHash}
|
|
2068
|
+
- Story worktree: ${storyQa.worktreeKey}
|
|
2069
|
+
- Branch: ${storyQa.branch}
|
|
2070
|
+
- Architect implementation.plan.json provided: ${storyQa.implementationPlanJson ? "yes" : "no"}
|
|
2071
|
+
- Architect qa.plan.json provided: ${storyQa.qaPlanJson ? "yes" : "no"}
|
|
2072
|
+
Materialized child tasks and evidence:
|
|
2073
|
+
${childLines || "- No child tasks were provided."}
|
|
2074
|
+
Architect final QA checks:
|
|
2075
|
+
${finalQa}
|
|
2076
|
+
This is parent Story QA: inspect the integrated Story result, all current-plan child specs/evidence, and the final worktree state. Do not treat the final child task as separately signed off.`;
|
|
2077
|
+
}
|
|
2078
|
+
function buildQaPrompt(dispatch, laneSpec) {
|
|
2079
|
+
return `You are Forge's QA lane running locally in a prepared git worktree.
|
|
2080
|
+
|
|
2081
|
+
First read and follow the injected QA lane command at .forge/work-items/${dispatch.workItem.id}/spec.md. It defines the required gated QA skill workflow for this run.
|
|
2082
|
+
|
|
2083
|
+
Injected QA lane command and work item spec:
|
|
2084
|
+
${laneSpec}
|
|
2085
|
+
|
|
2086
|
+
---
|
|
2087
|
+
|
|
2088
|
+
Work item: ${dispatch.workItem.id}
|
|
2089
|
+
Title: ${dispatch.workItem.title}
|
|
2090
|
+
Description:
|
|
2091
|
+
${dispatch.workItem.description || "Not provided."}
|
|
2092
|
+
|
|
2093
|
+
Acceptance criteria:
|
|
2094
|
+
${dispatch.workItem.acceptanceCriteria || "Not specified."}
|
|
2095
|
+
|
|
2096
|
+
Repro steps / scenario:
|
|
2097
|
+
${dispatch.workItem.reproSteps || "Not provided."}
|
|
2098
|
+
|
|
2099
|
+
System info / environment notes:
|
|
2100
|
+
${dispatch.workItem.systemInfo || "Not provided."}
|
|
565
2101
|
|
|
566
|
-
|
|
567
|
-
|
|
2102
|
+
${storyQaInstruction(dispatch)}
|
|
2103
|
+
Inspect the validated implementation and Forge artifacts under .forge/work-items/${dispatch.workItem.id}/artifacts/ when present, especially implementation, self-review, and validation evidence.
|
|
2104
|
+
${qaBrowserInstruction(dispatch)}
|
|
2105
|
+
${qaReworkRetestInstruction(dispatch)}
|
|
2106
|
+
QA is read-mostly: inspect code, run commands, and exercise browser/app flows when available, but do not edit product source or tests.
|
|
2107
|
+
Record concrete evidence. For UI/browser work, include browser_checks with URLs/routes, actions, observed results, screenshots/traces when available, console errors, failed network requests, and responsive checks. Store browser sidecars under .forge/work-items/${dispatch.workItem.id}/artifacts/qa/.
|
|
2108
|
+
Report in-scope defects as actionable findings with repro steps, expected/actual behavior, evidence, likely area, required fix, and required regression.
|
|
2109
|
+
Out-of-scope or follow-up issues belong in candidate_bugs instead of blocking the current item.
|
|
2110
|
+
|
|
2111
|
+
${completionPromptForQaCycle()}
|
|
2112
|
+
|
|
2113
|
+
Finish with a concise summary only after forge.complete_qa_verdict accepts the QA bundle.`;
|
|
568
2114
|
}
|
|
569
2115
|
function buildConflictResolvePrompt(dispatch, branchName) {
|
|
570
2116
|
const targetBranch = dispatch.cycleRun.requestedBase || dispatch.repo.defaultBranch || "main";
|
|
@@ -579,6 +2125,34 @@ Keep the original work item intent intact:
|
|
|
579
2125
|
|
|
580
2126
|
Finish with a concise summary of the conflicts resolved and verification performed.`;
|
|
581
2127
|
}
|
|
2128
|
+
function buildPullRequestCommentsPrompt(dispatch, branchName) {
|
|
2129
|
+
const pr = dispatch.pullRequest;
|
|
2130
|
+
const targetBranch = pr?.targetBranch || dispatch.cycleRun.requestedBase || dispatch.repo.defaultBranch || "main";
|
|
2131
|
+
const prLocator = pr
|
|
2132
|
+
? `PR #${pr.number}${pr.url ? ` (${pr.url})` : ""}`
|
|
2133
|
+
: "the open pull request for this work item";
|
|
2134
|
+
return `You are Forge's Pull Request Comments lane running locally in a prepared git worktree.
|
|
2135
|
+
|
|
2136
|
+
The current branch is the pull request branch ${branchName}. Address unresolved review comments on ${prLocator}.
|
|
2137
|
+
PR context:
|
|
2138
|
+
- Provider: ${pr?.provider || "not provided"}
|
|
2139
|
+
- Source branch: ${pr?.sourceBranch || branchName}
|
|
2140
|
+
- Target branch: ${targetBranch}
|
|
2141
|
+
- Unresolved comments: ${pr?.unresolvedThreads ?? "unknown"}
|
|
2142
|
+
|
|
2143
|
+
Use the PR URL, local git metadata, and available GitHub tooling/auth to inspect unresolved review threads. Make focused code or test changes that answer the feedback, commit the changes, and push ${branchName} to origin.
|
|
2144
|
+
After the push succeeds, Forge will resolve the addressed review threads through the pull request API.
|
|
2145
|
+
If the review thread contents are unavailable, stop with a clear summary of what could not be accessed instead of guessing.
|
|
2146
|
+
Keep the original work item intent intact:
|
|
2147
|
+
- Work item: ${dispatch.workItem.id}
|
|
2148
|
+
- Title: ${dispatch.workItem.title}
|
|
2149
|
+
- Acceptance criteria: ${dispatch.workItem.acceptanceCriteria || "Not specified"}
|
|
2150
|
+
|
|
2151
|
+
Finish with a concise summary of comments addressed and verification performed.`;
|
|
2152
|
+
}
|
|
2153
|
+
function isPullRequestCommentsDispatch(dispatch) {
|
|
2154
|
+
return dispatch.cycleRun.kind.trim().toLowerCase() === "pr_comments";
|
|
2155
|
+
}
|
|
582
2156
|
async function cleanupCompletionTools(completionTools, emit) {
|
|
583
2157
|
try {
|
|
584
2158
|
await completionTools.cleanup();
|
|
@@ -626,37 +2200,41 @@ class CursorStreamJsonState {
|
|
|
626
2200
|
sessionId = null;
|
|
627
2201
|
finalMessage = null;
|
|
628
2202
|
emittedSession = false;
|
|
2203
|
+
accumulatedUsage = null;
|
|
629
2204
|
get sessionLabel() {
|
|
630
2205
|
return this.sessionId ? `session ${this.sessionId}` : null;
|
|
631
2206
|
}
|
|
2207
|
+
get usage() {
|
|
2208
|
+
return this.accumulatedUsage;
|
|
2209
|
+
}
|
|
632
2210
|
consume(line) {
|
|
633
2211
|
const event = parseJsonLine(line);
|
|
634
2212
|
if (!event) {
|
|
635
|
-
return
|
|
2213
|
+
return [];
|
|
636
2214
|
}
|
|
637
2215
|
const type = stringField(event, "type");
|
|
638
2216
|
if (type === "system" && stringField(event, "subtype") === "init") {
|
|
639
2217
|
this.sessionId = stringField(event, "session_id");
|
|
640
2218
|
if (this.sessionId && !this.emittedSession) {
|
|
641
2219
|
this.emittedSession = true;
|
|
642
|
-
return {
|
|
643
|
-
|
|
644
|
-
|
|
645
|
-
|
|
646
|
-
|
|
647
|
-
|
|
2220
|
+
return [{
|
|
2221
|
+
role: "runner",
|
|
2222
|
+
kind: "checkpoint",
|
|
2223
|
+
content: `Cursor session started: ${this.sessionId}.`,
|
|
2224
|
+
eventType: "provider_thread_started"
|
|
2225
|
+
}];
|
|
648
2226
|
}
|
|
649
2227
|
}
|
|
650
2228
|
if (type === "assistant") {
|
|
651
2229
|
const text = assistantMessageText(event);
|
|
652
2230
|
if (text) {
|
|
653
2231
|
this.finalMessage = clip(text, 4000);
|
|
654
|
-
return {
|
|
655
|
-
|
|
656
|
-
|
|
657
|
-
|
|
658
|
-
|
|
659
|
-
|
|
2232
|
+
return [{
|
|
2233
|
+
role: "assistant",
|
|
2234
|
+
kind: "message",
|
|
2235
|
+
content: this.finalMessage,
|
|
2236
|
+
eventType: "provider_message"
|
|
2237
|
+
}];
|
|
660
2238
|
}
|
|
661
2239
|
}
|
|
662
2240
|
if (type === "tool_call") {
|
|
@@ -665,23 +2243,23 @@ class CursorStreamJsonState {
|
|
|
665
2243
|
if (subtype === "started") {
|
|
666
2244
|
const summary = formatCursorToolCallStarted(toolCall);
|
|
667
2245
|
if (summary) {
|
|
668
|
-
return {
|
|
669
|
-
|
|
670
|
-
|
|
671
|
-
|
|
672
|
-
|
|
673
|
-
|
|
2246
|
+
return [{
|
|
2247
|
+
role: "worker",
|
|
2248
|
+
kind: "checkpoint",
|
|
2249
|
+
content: summary,
|
|
2250
|
+
eventType: "provider_tool_call"
|
|
2251
|
+
}];
|
|
674
2252
|
}
|
|
675
2253
|
}
|
|
676
2254
|
if (subtype === "completed") {
|
|
677
2255
|
const completed = formatCursorToolCallCompleted(toolCall);
|
|
678
2256
|
if (completed) {
|
|
679
|
-
return {
|
|
680
|
-
|
|
681
|
-
|
|
682
|
-
|
|
683
|
-
|
|
684
|
-
|
|
2257
|
+
return [{
|
|
2258
|
+
role: "worker",
|
|
2259
|
+
kind: completed.kind,
|
|
2260
|
+
content: completed.content,
|
|
2261
|
+
eventType: completed.kind === "file_edit" ? "provider_file_edit" : "provider_tool_call"
|
|
2262
|
+
}];
|
|
685
2263
|
}
|
|
686
2264
|
}
|
|
687
2265
|
}
|
|
@@ -690,16 +2268,32 @@ class CursorStreamJsonState {
|
|
|
690
2268
|
if (result) {
|
|
691
2269
|
this.finalMessage = clip(result, 4000);
|
|
692
2270
|
}
|
|
2271
|
+
this.accumulateUsage(event);
|
|
693
2272
|
}
|
|
694
2273
|
if (type === "error" || (type === "result" && event.is_error === true)) {
|
|
695
|
-
return {
|
|
696
|
-
|
|
697
|
-
|
|
698
|
-
|
|
699
|
-
|
|
700
|
-
|
|
2274
|
+
return [{
|
|
2275
|
+
role: "runner",
|
|
2276
|
+
kind: "error",
|
|
2277
|
+
content: clip(line.trim(), 1000),
|
|
2278
|
+
eventType: "provider_cli_error"
|
|
2279
|
+
}];
|
|
701
2280
|
}
|
|
702
|
-
return
|
|
2281
|
+
return [];
|
|
2282
|
+
}
|
|
2283
|
+
accumulateUsage(event) {
|
|
2284
|
+
const usage = objectField(event, "usage");
|
|
2285
|
+
const durationMs = readUsageNumber(event, "duration_ms") || readUsageNumber(event, "duration_api_ms");
|
|
2286
|
+
if (Object.keys(usage).length === 0 && durationMs === 0) {
|
|
2287
|
+
return;
|
|
2288
|
+
}
|
|
2289
|
+
this.accumulatedUsage = addUsage(this.accumulatedUsage ?? emptyUsage("provider_reported"), {
|
|
2290
|
+
inputTokens: readUsageNumber(usage, "inputTokens"),
|
|
2291
|
+
outputTokens: readUsageNumber(usage, "outputTokens"),
|
|
2292
|
+
cacheReadTokens: readUsageNumber(usage, "cacheReadTokens"),
|
|
2293
|
+
cacheCreationTokens: readUsageNumber(usage, "cacheWriteTokens"),
|
|
2294
|
+
providerDurationMs: durationMs > 0 ? durationMs : null,
|
|
2295
|
+
source: "provider_reported"
|
|
2296
|
+
});
|
|
703
2297
|
}
|
|
704
2298
|
}
|
|
705
2299
|
function formatCursorToolCallStarted(toolCall) {
|
|
@@ -805,42 +2399,47 @@ class CodexJsonState {
|
|
|
805
2399
|
threadId = null;
|
|
806
2400
|
finalMessage = null;
|
|
807
2401
|
emittedThread = false;
|
|
2402
|
+
accumulatedUsage = null;
|
|
808
2403
|
get sessionLabel() {
|
|
809
2404
|
return this.threadId ? `thread ${this.threadId}` : null;
|
|
810
2405
|
}
|
|
2406
|
+
get usage() {
|
|
2407
|
+
return this.accumulatedUsage;
|
|
2408
|
+
}
|
|
811
2409
|
consume(line) {
|
|
812
2410
|
const event = parseJsonLine(line);
|
|
813
2411
|
if (!event) {
|
|
814
|
-
return
|
|
2412
|
+
return [];
|
|
815
2413
|
}
|
|
816
2414
|
const type = stringField(event, "type") ?? "";
|
|
817
2415
|
if (type === "thread.started") {
|
|
818
2416
|
this.threadId = stringField(event, "thread_id");
|
|
819
2417
|
if (this.threadId && !this.emittedThread) {
|
|
820
2418
|
this.emittedThread = true;
|
|
821
|
-
return {
|
|
822
|
-
|
|
823
|
-
|
|
824
|
-
|
|
825
|
-
|
|
826
|
-
|
|
2419
|
+
return [{
|
|
2420
|
+
role: "runner",
|
|
2421
|
+
kind: "checkpoint",
|
|
2422
|
+
content: `Codex thread started: ${this.threadId}.`,
|
|
2423
|
+
eventType: "provider_thread_started"
|
|
2424
|
+
}];
|
|
827
2425
|
}
|
|
828
2426
|
}
|
|
829
2427
|
if (type === "turn.completed") {
|
|
830
|
-
|
|
831
|
-
|
|
832
|
-
|
|
833
|
-
|
|
834
|
-
|
|
835
|
-
|
|
2428
|
+
this.accumulateUsage(event);
|
|
2429
|
+
return [{
|
|
2430
|
+
role: "runner",
|
|
2431
|
+
kind: "checkpoint",
|
|
2432
|
+
content: "Codex turn completed.",
|
|
2433
|
+
eventType: "provider_turn_completed"
|
|
2434
|
+
}];
|
|
836
2435
|
}
|
|
837
2436
|
if (type === "turn.failed" || type === "error") {
|
|
838
|
-
return {
|
|
839
|
-
|
|
840
|
-
|
|
841
|
-
|
|
842
|
-
|
|
843
|
-
|
|
2437
|
+
return [{
|
|
2438
|
+
role: "runner",
|
|
2439
|
+
kind: "error",
|
|
2440
|
+
content: clip(line.trim(), 1000),
|
|
2441
|
+
eventType: "provider_cli_error"
|
|
2442
|
+
}];
|
|
844
2443
|
}
|
|
845
2444
|
if (type === "item.completed" || type === "item.updated") {
|
|
846
2445
|
const item = objectField(event, "item");
|
|
@@ -849,29 +2448,153 @@ class CodexJsonState {
|
|
|
849
2448
|
const text = stringField(item, "text");
|
|
850
2449
|
if (text) {
|
|
851
2450
|
this.finalMessage = clip(text, 4000);
|
|
852
|
-
return {
|
|
853
|
-
|
|
854
|
-
|
|
855
|
-
|
|
856
|
-
|
|
857
|
-
|
|
2451
|
+
return [{
|
|
2452
|
+
role: "assistant",
|
|
2453
|
+
kind: "message",
|
|
2454
|
+
content: this.finalMessage,
|
|
2455
|
+
eventType: "provider_message"
|
|
2456
|
+
}];
|
|
858
2457
|
}
|
|
859
2458
|
}
|
|
860
2459
|
if (itemType === "command_execution") {
|
|
861
2460
|
const command = stringField(item, "command");
|
|
862
2461
|
const status = stringField(item, "status");
|
|
863
2462
|
if (command) {
|
|
864
|
-
return {
|
|
865
|
-
|
|
866
|
-
|
|
867
|
-
|
|
868
|
-
|
|
869
|
-
|
|
2463
|
+
return [{
|
|
2464
|
+
role: "worker",
|
|
2465
|
+
kind: "checkpoint",
|
|
2466
|
+
content: `Codex command ${status || "completed"}: ${clip(command, 500)}`,
|
|
2467
|
+
eventType: "provider_command"
|
|
2468
|
+
}];
|
|
870
2469
|
}
|
|
871
2470
|
}
|
|
872
2471
|
}
|
|
873
|
-
|
|
2472
|
+
const mcpEvents = formatCodexMcpToolCallEvents(type, event);
|
|
2473
|
+
if (mcpEvents.length > 0) {
|
|
2474
|
+
return mcpEvents;
|
|
2475
|
+
}
|
|
2476
|
+
return [];
|
|
2477
|
+
}
|
|
2478
|
+
accumulateUsage(event) {
|
|
2479
|
+
const usage = objectField(event, "usage");
|
|
2480
|
+
if (Object.keys(usage).length === 0) {
|
|
2481
|
+
return;
|
|
2482
|
+
}
|
|
2483
|
+
this.accumulatedUsage = addUsage(this.accumulatedUsage ?? emptyUsage("provider_reported"), {
|
|
2484
|
+
inputTokens: readUsageNumber(usage, "input_tokens"),
|
|
2485
|
+
outputTokens: readUsageNumber(usage, "output_tokens"),
|
|
2486
|
+
cacheReadTokens: readUsageNumber(usage, "cached_input_tokens"),
|
|
2487
|
+
reasoningOutputTokens: readUsageNumber(usage, "reasoning_output_tokens"),
|
|
2488
|
+
source: "provider_reported"
|
|
2489
|
+
});
|
|
2490
|
+
}
|
|
2491
|
+
}
|
|
2492
|
+
function formatCodexMcpToolCallEvents(type, event) {
|
|
2493
|
+
if (type !== "item.started" && type !== "item.updated" && type !== "item.completed") {
|
|
2494
|
+
return [];
|
|
2495
|
+
}
|
|
2496
|
+
const item = objectField(event, "item");
|
|
2497
|
+
const itemType = stringField(item, "type") ?? "";
|
|
2498
|
+
const serverName = mcpServerName(item);
|
|
2499
|
+
const toolName = mcpToolName(item);
|
|
2500
|
+
const isMcpItem = itemType.toLowerCase().includes("mcp")
|
|
2501
|
+
|| Boolean(serverName)
|
|
2502
|
+
|| (toolName ? isForgeCompletionTool(toolName) || toolName.toLowerCase().includes("mcp") : false);
|
|
2503
|
+
if (!isMcpItem || !toolName) {
|
|
2504
|
+
return [];
|
|
2505
|
+
}
|
|
2506
|
+
const status = normalizedString(stringField(item, "status")
|
|
2507
|
+
?? stringField(event, "status")
|
|
2508
|
+
?? (type === "item.started" ? "started" : type === "item.completed" ? "completed" : "updated"));
|
|
2509
|
+
const failed = status === "failed" || status === "error" || status === "cancelled" || Boolean(item.error);
|
|
2510
|
+
const completed = failed || type === "item.completed" || status === "completed" || status === "succeeded" || status === "success";
|
|
2511
|
+
const started = type === "item.started" || status === "started" || status === "running" || status === "in_progress";
|
|
2512
|
+
const data = safeProviderMcpData(item, serverName ?? "unknown", toolName, status);
|
|
2513
|
+
const label = `${serverName ?? "unknown"}.${toolName}`;
|
|
2514
|
+
if (failed) {
|
|
2515
|
+
const summary = mcpErrorSummary(item) ?? "MCP tool call failed.";
|
|
2516
|
+
const events = [{
|
|
2517
|
+
role: "tool",
|
|
2518
|
+
kind: "error",
|
|
2519
|
+
content: `MCP tool call failed: ${label} - ${summary}`,
|
|
2520
|
+
eventType: "provider_mcp_call_failed",
|
|
2521
|
+
data
|
|
2522
|
+
}];
|
|
2523
|
+
if (isForgeCompletionTool(toolName)) {
|
|
2524
|
+
events.push({
|
|
2525
|
+
role: "tool",
|
|
2526
|
+
kind: "error",
|
|
2527
|
+
content: `Forge completion tool validation failed: ${label} - ${summary}`,
|
|
2528
|
+
eventType: "completion_tool_validation_failed",
|
|
2529
|
+
data
|
|
2530
|
+
});
|
|
2531
|
+
}
|
|
2532
|
+
return events;
|
|
2533
|
+
}
|
|
2534
|
+
if (completed) {
|
|
2535
|
+
return [{
|
|
2536
|
+
role: "tool",
|
|
2537
|
+
kind: "checkpoint",
|
|
2538
|
+
content: `MCP tool call completed: ${label}.`,
|
|
2539
|
+
eventType: "provider_mcp_call_completed",
|
|
2540
|
+
data
|
|
2541
|
+
}];
|
|
2542
|
+
}
|
|
2543
|
+
if (started) {
|
|
2544
|
+
return [{
|
|
2545
|
+
role: "tool",
|
|
2546
|
+
kind: "checkpoint",
|
|
2547
|
+
content: `MCP tool call started: ${label}.`,
|
|
2548
|
+
eventType: "provider_mcp_call_started",
|
|
2549
|
+
data
|
|
2550
|
+
}];
|
|
2551
|
+
}
|
|
2552
|
+
return [];
|
|
2553
|
+
}
|
|
2554
|
+
function mcpServerName(item) {
|
|
2555
|
+
return stringField(item, "server")
|
|
2556
|
+
?? stringField(item, "server_name")
|
|
2557
|
+
?? stringField(item, "mcp_server")
|
|
2558
|
+
?? stringField(objectField(item, "mcp"), "server")
|
|
2559
|
+
?? stringField(objectField(item, "mcp"), "server_name");
|
|
2560
|
+
}
|
|
2561
|
+
function mcpToolName(item) {
|
|
2562
|
+
return stringField(item, "tool")
|
|
2563
|
+
?? stringField(item, "tool_name")
|
|
2564
|
+
?? stringField(item, "name")
|
|
2565
|
+
?? stringField(objectField(item, "function"), "name")
|
|
2566
|
+
?? stringField(objectField(item, "mcp"), "tool")
|
|
2567
|
+
?? stringField(objectField(item, "mcp"), "tool_name");
|
|
2568
|
+
}
|
|
2569
|
+
function mcpErrorSummary(item) {
|
|
2570
|
+
const direct = stringField(item, "error")
|
|
2571
|
+
?? stringField(item, "error_message")
|
|
2572
|
+
?? stringField(item, "message");
|
|
2573
|
+
if (direct) {
|
|
2574
|
+
return clip(direct, 600);
|
|
874
2575
|
}
|
|
2576
|
+
const error = objectField(item, "error");
|
|
2577
|
+
return stringField(error, "message")
|
|
2578
|
+
?? stringField(error, "summary")
|
|
2579
|
+
?? stringField(objectField(item, "result"), "error")
|
|
2580
|
+
?? null;
|
|
2581
|
+
}
|
|
2582
|
+
function safeProviderMcpData(item, serverName, toolName, status) {
|
|
2583
|
+
const elapsedMs = numericField(item, "elapsed_ms") ?? numericField(item, "duration_ms");
|
|
2584
|
+
return JSON.stringify(stripUndefined({
|
|
2585
|
+
server_name: serverName,
|
|
2586
|
+
tool_name: toolName,
|
|
2587
|
+
status,
|
|
2588
|
+
elapsed_ms: elapsedMs,
|
|
2589
|
+
error_summary: mcpErrorSummary(item)
|
|
2590
|
+
}));
|
|
2591
|
+
}
|
|
2592
|
+
function isForgeCompletionTool(toolName) {
|
|
2593
|
+
const normalized = toolName.trim().toLowerCase();
|
|
2594
|
+
return normalized.startsWith("forge.complete_")
|
|
2595
|
+
|| normalized.startsWith("complete_")
|
|
2596
|
+
|| normalized.includes("forge.complete_")
|
|
2597
|
+
|| normalized.includes("complete_architect_plan");
|
|
875
2598
|
}
|
|
876
2599
|
function objectField(source, key) {
|
|
877
2600
|
const value = source[key];
|
|
@@ -883,3 +2606,16 @@ function stringField(source, key) {
|
|
|
883
2606
|
const value = source[key];
|
|
884
2607
|
return typeof value === "string" && value.trim().length > 0 ? value : null;
|
|
885
2608
|
}
|
|
2609
|
+
function numericField(source, key) {
|
|
2610
|
+
const value = source[key];
|
|
2611
|
+
return typeof value === "number" && Number.isFinite(value) ? value : null;
|
|
2612
|
+
}
|
|
2613
|
+
function stripUndefined(value) {
|
|
2614
|
+
return Object.fromEntries(Object.entries(value).filter(([, entry]) => entry !== undefined));
|
|
2615
|
+
}
|
|
2616
|
+
function normalizedString(value) {
|
|
2617
|
+
return value.trim().toLowerCase().replace(/-/g, "_");
|
|
2618
|
+
}
|
|
2619
|
+
function isNodeError(error) {
|
|
2620
|
+
return error instanceof Error && "code" in error;
|
|
2621
|
+
}
|