@lotics/ui 47.2.1 → 47.3.0

package/docs/reviewing.md

@@ -10,6 +10,24 @@ Everything here is about a screen **that already renders**. Building one starts
 
 ---
 
+## The kit's peer ranges are a resolution contract, not a floor
+
+`lucide-react-native` sat at `>=0.460.0` — unbounded — while `icon.tsx` deep-imports
+`lucide-react-native/dist/esm/icons/<name>` to keep the ~1650-icon barrel out of the
+Metro bundle. lucide later shipped an `exports` map listing only `.` and `./icons`, so
+that path stopped being publicly exported, and every resolver that honours `exports`
+(Vite's dep optimizer among them) began refusing it. Nothing in this repo changed; the
+range simply accepted the version that changed the rules.
+
+It surfaced late and looked intermittent because a warm `.vite` cache never re-resolves
+— only a fresh install hits it, which is why it kept coming back and kept getting
+patched as a symptom (clear the cache, add a local `exclude`).
+
+**A peer range with no upper bound on a package we deep-import is a standing invitation
+for this.** When the kit reaches past a package's public entry points, bound the range,
+and say in the code why the deep path is being used at all.
+
+
 ## The method
 
 **"Looks off" is where a finding starts.** Trust the impression and use measurement to say

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lotics/ui",
-  "version": "47.2.1",
+  "version": "47.3.0",
   "type": "module",
   "exports": {
     "./accordion": "./src/accordion.tsx",
@@ -355,7 +355,7 @@
     "@react-native-picker/picker": ">=2.0.0",
     "expo-image": ">=3.0.0",
     "lucide-react": ">=0.460.0",
-    "lucide-react-native": ">=0.460.0",
+    "lucide-react-native": "^0.562.0",
     "react": "^19.2.0",
     "react-dom": "^19.2.0",
     "react-native": ">=0.85.0",

package/src/vite.mjs

@@ -102,11 +102,44 @@ export const loticsOptimizeDeps = [
  *   const base = loticsResolve();
  *   resolve: { ...base, alias: [...base.alias, { find: "x", replacement: "y" }] }
  */
+/**
+ * Absolute path to lucide's ESM icon directory, or null when it isn't installed.
+ *
+ * `icon.tsx` deep-imports `lucide-react-native/dist/esm/icons/<name>` to keep the
+ * ~1650-icon barrel out of the Metro bundle. lucide 0.562 ships an `exports` map
+ * listing only `.` and `./icons`, so that specifier is not publicly exported —
+ * and Vite's dep optimizer, which honours `exports`, refuses it outright:
+ * `Missing "./dist/esm/icons/activity" specifier`. The rollup build resolves it
+ * anyway, so the failure is dev-only, and it stayed hidden because a warm
+ * `.vite` cache never re-resolves. Any app installing fresh hits it immediately.
+ *
+ * Resolving the package's own ESM entry and walking to its sibling `icons/`
+ * gives the optimizer a real path, so no consumer has to touch its vite config
+ * and no bundle changes. `import.meta.resolve` (not `createRequire`) because we
+ * need the ESM condition — the require condition lands in `dist/cjs`.
+ */
+function lucideIconsDir() {
+  try {
+    // `import.meta.resolve`, and string-slicing rather than `node:path` /
+    // `node:url`, because this module must stay a zero-import leaf — see the
+    // header. The ESM condition matters: the require condition lands in
+    // `dist/cjs`, whose icons are CJS and would defeat the point.
+    const url = import.meta.resolve("lucide-react-native");
+    if (!url.startsWith("file://")) return null;
+    const file = decodeURIComponent(url.slice("file://".length));
+    return `${file.slice(0, file.lastIndexOf("/"))}/icons`;
+  } catch {
+    return null;
+  }
+}
+
 export function loticsResolve() {
   const uiSrc = process.env.LOTICS_UI_SRC;
+  const icons = lucideIconsDir();
   return {
     alias: [
       ...(uiSrc ? [{ find: /^@lotics\/ui\/(.+)$/, replacement: `${uiSrc}/$1` }] : []),
+      ...(icons ? [{ find: /^lucide-react-native\/dist\/esm\/icons\/(.+)$/, replacement: `${icons}/$1` }] : []),
       { find: "react-native", replacement: "react-native-web" },
     ],
     extensions: [".web.tsx", ".web.ts", ".web.js", ".tsx", ".ts", ".jsx", ".js", ".mjs", ".mts"],