@lotics/ui 26.4.0 → 26.4.1

package/docs/catalog.md

@@ -649,7 +649,9 @@ source (`src/<module>.tsx`/`.ts`) is the API reference.
 - **`use_form`** — `useForm`: THE batch draft-form state hook — `values` = `initialValues` +
   an edits overlay (a revalidation refreshes untouched fields, no sync effect), `validate`
   (sync/async, gates submit, editing clears the field's error), `onSubmit(values, helpers)`
-  with a re-entry-guarded `submitting`, and `changes`/`changed` — the touched-fields diff
+  with a re-entry-guarded `submitting` — an error `onSubmit` reports itself via
+  `setFieldError` (a rejected write, say) SURVIVES, because each attempt clears the previous
+  attempt's errors on the way IN, not on the way out — and `changes`/`changed` — the touched-fields diff
   that feeds DIFF-writes (send only edited fields); `setFieldValue` (curried or direct) +
   `setValues`/`setFieldError`/`reset`. Pairs with the Form\* family for dialog/settings
   forms — the draft-validate-COMMIT-together twin of the self-persisting Inline\* editors.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lotics/ui",
-  "version": "26.4.0",
+  "version": "26.4.1",
   "type": "module",
   "exports": {
     "./vite": {

package/src/use_form.ts

@@ -116,9 +116,14 @@ function reducer<T>(prevState: FormState<T>, action: Action<T>): FormState<T> {
       if (prevState.submitting === action.submitting) return prevState;
       return { ...prevState, submitting: action.submitting };
     case "SUBMIT":
+      // Deliberately does NOT clear errors. This fires after `onSubmit` returns,
+      // and a handler that caught a server rejection and called `setFieldError`
+      // returns normally — so wiping here erased the only report of the failure
+      // and the press looked like it did nothing. Nothing needs the wipe:
+      // editing a field clears that field's error, and a `validate` pass
+      // replaces the whole set.
       return {
         ...prevState,
-        errors: {},
         submitting: false,
         submitCount: prevState.submitCount + 1,
       };
@@ -228,14 +233,14 @@ export function useForm<T>(props: UseFormProps<T>): FormHandler<T> {
     if (!onSubmit) return;
     if (submittingRef.current) return;
 
-    if (validate !== undefined) {
-      const nextErrors = await validate(values);
-
-      if (nextErrors && Object.keys(nextErrors).length) {
-        setErrors(nextErrors);
-        return;
-      }
-    }
+    // The previous attempt's errors are cleared HERE, before this one runs —
+    // not after `onSubmit` returns. Clearing afterwards erased the very error a
+    // handler had just set from a rejected write, so the press looked like it
+    // did nothing; never clearing left that error on screen after a later
+    // attempt succeeded. Clearing up front does both jobs.
+    const nextErrors = validate ? ((await validate(values)) ?? {}) : {};
+    setErrors(nextErrors);
+    if (Object.keys(nextErrors).length) return;
 
     submittingRef.current = true;
     dispatch({ type: "SET_SUBMITTING", submitting: true });