@lotics/cli 0.86.2 → 0.87.1

package/dist/package_commands.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/package_commands.test.js

@@ -1,415 +0,0 @@
-import { describe, it, expect, vi } from "vitest";
-import fs from "node:fs";
-import path from "node:path";
-import { tmpdir } from "node:os";
-import { parseResolveFlags, parseBindToFlags, parseRenameFlags, readLocalAppManifest, formatExtractReport, appRelease, packageUpgradeByPackageId, packageDoctor, } from "./package_commands.js";
-import { parseArgs } from "./args.js";
-describe("parseRenameFlags", () => {
-    it("parses old=new pairs", () => {
-        expect(parseRenameFlags(["item=deal", "don_hang=orders"])).toEqual([
-            { from: "item", to: "deal" },
-            { from: "don_hang", to: "orders" },
-        ]);
-        expect(parseRenameFlags(["e.f=name"])).toEqual([{ from: "e.f", to: "name" }]);
-        expect(parseRenameFlags([])).toEqual([]);
-    });
-    it("rejects a malformed rename", () => {
-        expect(() => parseRenameFlags(["nope"])).toThrow(/expected old=new/);
-        expect(() => parseRenameFlags(["=x"])).toThrow(/expected old=new/);
-        expect(() => parseRenameFlags(["x="])).toThrow(/expected old=new/);
-    });
-});
-describe("readLocalAppManifest", () => {
-    function withManifest(lotics, fn) {
-        const dir = fs.mkdtempSync(path.join(tmpdir(), "lotics-app-test-"));
-        try {
-            fs.writeFileSync(path.join(dir, "package.json"), JSON.stringify({ name: "crm", lotics }));
-            return fn(dir);
-        }
-        finally {
-            fs.rmSync(dir, { recursive: true, force: true });
-        }
-    }
-    it("reads app_id + knowledge + config from a pulled app project", () => {
-        withManifest({
-            app_id: "app_x",
-            knowledge: [{ alias: "sop", doc_id: "kdc_1" }],
-            config: [{ alias: "page_size", label: "Page size", type: "number", default: 25 }],
-        }, (dir) => {
-            expect(readLocalAppManifest(dir)).toEqual({
-                app_id: "app_x",
-                knowledge: [{ alias: "sop", doc_id: "kdc_1" }],
-                config: [{ alias: "page_size", label: "Page size", type: "number", default: 25 }],
-            });
-        });
-    });
-    it("defaults knowledge + config to empty arrays when the manifest omits them", () => {
-        withManifest({ app_id: "app_x" }, (dir) => {
-            expect(readLocalAppManifest(dir)).toEqual({ app_id: "app_x", knowledge: [], config: [] });
-        });
-    });
-    it("validates each config knob against the shared schema, throwing NAMING the bad alias", () => {
-        withManifest({
-            app_id: "app_x",
-            // A select knob with no `options` — the shared schema rejects it.
-            config: [{ alias: "theme", label: "Theme", type: "select", default: "light" }],
-        }, (dir) => {
-            expect(() => readLocalAppManifest(dir)).toThrow(/lotics\.config knob "theme"/);
-        });
-    });
-    it("returns null when the dir has no package.json", () => {
-        const dir = fs.mkdtempSync(path.join(tmpdir(), "lotics-empty-"));
-        try {
-            expect(readLocalAppManifest(dir)).toBeNull();
-        }
-        finally {
-            fs.rmSync(dir, { recursive: true, force: true });
-        }
-    });
-});
-describe("parseResolveFlags", () => {
-    it("maps 'recreate' and ids to their resolution shapes", () => {
-        expect(parseResolveFlags(["fields.deal.stage=recreate", "templates.quote=dtl_abc"])).toEqual({
-            "fields.deal.stage": "recreate",
-            "templates.quote": { bind_to: "dtl_abc" },
-        });
-    });
-    it("maps modified-core consents 'revert' and 'keep' as literals", () => {
-        expect(parseResolveFlags(["queries.tasks=revert", "workflows.notify=keep"])).toEqual({
-            "queries.tasks": "revert",
-            "workflows.notify": "keep",
-        });
-    });
-    it("rejects entries without a key=value shape", () => {
-        expect(() => parseResolveFlags(["fields.deal.stage"])).toThrow(/Invalid --resolve/);
-        expect(() => parseResolveFlags(["=recreate"])).toThrow(/Invalid --resolve/);
-        expect(() => parseResolveFlags(["fields.deal.stage="])).toThrow(/Invalid --resolve/);
-    });
-});
-describe("parseResolveFlags — the one namespaced grammar", () => {
-    it("passes knowledge verbs through under knowledge.<alias> keys", () => {
-        expect(parseResolveFlags([
-            "knowledge.pricing=apply",
-            "knowledge.faq=keep",
-            "knowledge.old=archive",
-            "knowledge.gone=recreate",
-            "knowledge.legacy=unbind",
-        ])).toEqual({
-            "knowledge.pricing": "apply",
-            "knowledge.faq": "keep",
-            "knowledge.old": "archive",
-            "knowledge.gone": "recreate",
-            "knowledge.legacy": "unbind",
-        });
-    });
-    it("passes template consents through under template.<alias> keys", () => {
-        expect(parseResolveFlags(["template.quote=revert", "template.invoice=keep"])).toEqual({
-            "template.quote": "revert",
-            "template.invoice": "keep",
-        });
-    });
-    it("maps a non-verb value to a bind_to id on any key (roles rebind, knowledge adopt)", () => {
-        expect(parseResolveFlags(["roles.approver=grp_new", "knowledge.faq=kdc_existing"])).toEqual({
-            "roles.approver": { bind_to: "grp_new" },
-            "knowledge.faq": { bind_to: "kdc_existing" },
-        });
-    });
-});
-describe("parseBindToFlags", () => {
-    it("maps each alias to its consent doc id", () => {
-        expect(parseBindToFlags(["playbook=kdc_1", "faq=kdc_2"])).toEqual({
-            playbook: "kdc_1",
-            faq: "kdc_2",
-        });
-    });
-    it("rejects entries without an alias=id shape", () => {
-        expect(() => parseBindToFlags(["playbook"])).toThrow(/Invalid --bind-to/);
-        expect(() => parseBindToFlags(["=kdc_1"])).toThrow(/Invalid --bind-to/);
-        expect(() => parseBindToFlags(["playbook="])).toThrow(/Invalid --bind-to/);
-    });
-});
-describe("parseArgs — app publish --rename", () => {
-    it("captures repeated --rename flags with the positional app id", () => {
-        const { command, subcommand, toolArgs, flags } = parseArgs([
-            "app",
-            "publish",
-            "app_x",
-            "--rename",
-            "item=deal",
-            "--rename",
-            "e.f=name",
-        ]);
-        expect(command).toBe("app");
-        expect(subcommand).toBe("publish");
-        expect(toolArgs).toBe("app_x");
-        expect(flags.rename).toEqual(["item=deal", "e.f=name"]);
-    });
-    it("throws when --rename has no value", () => {
-        expect(() => parseArgs(["app", "publish", "--rename"])).toThrow(/--rename requires a value/);
-        expect(() => parseArgs(["app", "publish", "--rename", "--yes"])).toThrow(/--rename requires a value/);
-    });
-});
-describe("parseArgs — package list-content", () => {
-    it("parses the list-content subcommand with no positional", () => {
-        const { command, subcommand, toolArgs } = parseArgs(["package", "list-content"]);
-        expect(command).toBe("package");
-        expect(subcommand).toBe("list-content");
-        expect(toolArgs).toBeUndefined();
-    });
-    it("captures --workspace for a scoped list-content", () => {
-        const { subcommand, flags } = parseArgs([
-            "package",
-            "list-content",
-            "--workspace",
-            "wsp_dev",
-        ]);
-        expect(subcommand).toBe("list-content");
-        expect(flags.workspace).toBe("wsp_dev");
-    });
-});
-describe("appRelease — knowledge + config declaration forwarding", () => {
-    const pageSizeKnob = { alias: "page_size", label: "Page size", type: "number", default: 25 };
-    const previewResult = {
-        package_id: "apg_1",
-        version: 2,
-        added_aliases: [],
-        changed_artifacts: [],
-        knowledge: { added: ["guide"], removed: [], changed: [] },
-        config: { added: ["page_size"], removed: [], changed: [] },
-        findings: [],
-    };
-    /** A mock client capturing the knowledge + config forwarded to preview + release. */
-    function mockClient(overridePreview) {
-        const preview = [];
-        const release = [];
-        const result = { ...previewResult, ...overridePreview };
-        const client = {
-            previewPackageRelease: async (app_id, opts = {}) => {
-                preview.push({ app_id, opts });
-                return result;
-            },
-            releasePackage: async (app_id, body) => {
-                release.push({ app_id, body });
-                return { ...result, findings: undefined };
-            },
-        };
-        return { client, preview, release };
-    }
-    function withManifestDir(lotics, fn) {
-        const dir = fs.mkdtempSync(path.join(tmpdir(), "lotics-rel-"));
-        fs.writeFileSync(path.join(dir, "package.json"), JSON.stringify({ name: "app", lotics }));
-        return fn(dir).finally(() => fs.rmSync(dir, { recursive: true, force: true }));
-    }
-    it("forwards the manifest's knowledge + config declarations from the app's own project", async () => {
-        vi.spyOn(console, "error").mockImplementation(() => undefined);
-        const { client, preview, release } = mockClient();
-        await withManifestDir({ app_id: "app_x", knowledge: [{ alias: "guide", doc_id: "kdc_1" }], config: [pageSizeKnob] }, async (dir) => {
-            await appRelease(client, { app_id: ".", changelog: "ship", yes: true, projectDir: dir });
-        });
-        expect(preview[0]).toEqual({
-            app_id: "app_x",
-            opts: { knowledge: [{ alias: "guide", doc_id: "kdc_1" }], config: [pageSizeKnob] },
-        });
-        expect(release[0].body).toEqual({
-            changelog: "ship",
-            knowledge: [{ alias: "guide", doc_id: "kdc_1" }],
-            config: [pageSizeKnob],
-        });
-        vi.restoreAllMocks();
-    });
-    it("omits knowledge + config (reconstruct/carry-forward) when the manifest declares neither", async () => {
-        vi.spyOn(console, "error").mockImplementation(() => undefined);
-        const { client, preview, release } = mockClient();
-        await withManifestDir({ app_id: "app_x" }, async (dir) => {
-            await appRelease(client, { app_id: ".", changelog: "ship", yes: true, projectDir: dir });
-        });
-        expect(preview[0].opts).toEqual({ knowledge: undefined, config: undefined });
-        expect(release[0].body).toEqual({ changelog: "ship", knowledge: undefined, config: undefined });
-        vi.restoreAllMocks();
-    });
-    it("omits knowledge + config for a bare app id whose manifest is a DIFFERENT app", async () => {
-        vi.spyOn(console, "error").mockImplementation(() => undefined);
-        const { client, preview } = mockClient();
-        await withManifestDir({ app_id: "app_other", knowledge: [{ alias: "guide", doc_id: "kdc_1" }], config: [pageSizeKnob] }, async (dir) => {
-            await appRelease(client, { app_id: "app_x", changelog: "ship", yes: true, projectDir: dir });
-        });
-        expect(preview[0]).toEqual({ app_id: "app_x", opts: { knowledge: undefined, config: undefined } });
-        vi.restoreAllMocks();
-    });
-    it("warns LOUDLY when a SENT config declaration is ignored by a pre-declaration server (deploy skew)", async () => {
-        const errs = [];
-        vi.spyOn(console, "error").mockImplementation((msg) => {
-            errs.push(String(msg));
-        });
-        // A pre-declaration server omits `config` from the preview echo.
-        const { client } = mockClient({ config: undefined });
-        await withManifestDir({ app_id: "app_x", config: [pageSizeKnob] }, async (dir) => {
-            await appRelease(client, { app_id: ".", changelog: "ship", yes: true, projectDir: dir });
-        });
-        expect(errs.some((e) => /server ignored the config declaration/.test(e))).toBe(true);
-        vi.restoreAllMocks();
-    });
-});
-describe("packageUpgradeByPackageId — kind-branched by the package read", () => {
-    /**
-     * A mock client recording which upgrade path a `lotics upgrade <apg_>` takes.
-     * `kind` drives the branch: a content package resolves THIS workspace's content
-     * installation from the package id (the `pci_` never surfaces) and runs the
-     * content upgrade; an app package fleet-upgrades the org.
-     */
-    function mockClient(opts) {
-        const calls = { previewContent: [], fleet: [], listedWorkspaces: [] };
-        const client = {
-            getPackage: async (package_id) => ({
-                id: package_id,
-                name: "Ops corpus",
-                kind: opts.kind,
-                latest_version: 3,
-                is_official: false,
-                retired_at: null,
-            }),
-            getWorkspaceId: () => "wsp_1",
-            listContentInstallations: async (workspace_id) => {
-                calls.listedWorkspaces.push(workspace_id);
-                return (opts.installations ?? []).map((i) => ({
-                    ...i,
-                    workspace_id,
-                    package_version: 2,
-                    app_id: null,
-                    binding: { knowledge: {}, templates: {} },
-                    installed_by: null,
-                    created_at: "",
-                    updated_at: "",
-                    package_registry: null,
-                }));
-            },
-            previewContentInstallationUpgrade: async (installation_id) => {
-                calls.previewContent.push(installation_id);
-                return { from_version: 2, to_version: 2, entries: [], templates: [] };
-            },
-            fleetUpgradePackage: async (package_id) => {
-                calls.fleet.push(package_id);
-                return { package_id, target_version: 3, installations: [] };
-            },
-        };
-        return { client, calls };
-    }
-    const args = { version: undefined, resolve: [], bindTo: [], applyAll: false };
-    it("routes a CONTENT package to this workspace's content installation (resolved from the package id)", async () => {
-        vi.spyOn(console, "error").mockImplementation(() => undefined);
-        const { client, calls } = mockClient({
-            kind: "content",
-            installations: [{ id: "pci_1", package_id: "apg_content" }],
-        });
-        await packageUpgradeByPackageId(client, { package_id: "apg_content", ...args });
-        expect(calls.listedWorkspaces).toEqual(["wsp_1"]);
-        expect(calls.previewContent).toEqual(["pci_1"]); // resolved apg_ → pci_ client-side
-        expect(calls.fleet).toEqual([]); // never a fleet run for content
-        vi.restoreAllMocks();
-    });
-    it("routes an APP package to the org fleet upgrade", async () => {
-        vi.spyOn(console, "error").mockImplementation(() => undefined);
-        const { client, calls } = mockClient({ kind: "app" });
-        await packageUpgradeByPackageId(client, { package_id: "apg_app", ...args });
-        expect(calls.fleet).toEqual(["apg_app"]);
-        expect(calls.previewContent).toEqual([]);
-        expect(calls.listedWorkspaces).toEqual([]); // no content resolution for an app package
-        vi.restoreAllMocks();
-    });
-    it("errors clearly when a content package is not installed in this workspace", async () => {
-        vi.spyOn(console, "error").mockImplementation(() => undefined);
-        const { client } = mockClient({ kind: "content", installations: [] });
-        await expect(packageUpgradeByPackageId(client, { package_id: "apg_content", ...args })).rejects.toThrow(/not installed in this workspace[\s\S]*lotics install apg_content/);
-        vi.restoreAllMocks();
-    });
-});
-describe("formatExtractReport", () => {
-    it("groups findings errors → warnings → info and formats each line", () => {
-        const { lines, hasError } = formatExtractReport([
-            { severity: "info", area: "queries.items", message: "inverted cleanly" },
-            { severity: "error", area: "fields.deal.stage", message: "button field is not portable" },
-            { severity: "warning", area: "workflows.notify", message: "legacy key retained" },
-            { severity: "error", area: "queries.deals", message: "round-trip mismatch" },
-        ]);
-        expect(lines).toEqual([
-            "  [error] fields.deal.stage: button field is not portable",
-            "  [error] queries.deals: round-trip mismatch",
-            "  [warning] workflows.notify: legacy key retained",
-            "  [info] queries.items: inverted cleanly",
-        ]);
-        expect(hasError).toBe(true);
-    });
-    it("reports no error when only warnings/info are present", () => {
-        const { lines, hasError } = formatExtractReport([
-            { severity: "warning", area: "a", message: "w" },
-            { severity: "info", area: "b", message: "i" },
-        ]);
-        expect(lines).toEqual(["  [warning] a: w", "  [info] b: i"]);
-        expect(hasError).toBe(false);
-    });
-    it("handles an empty report", () => {
-        expect(formatExtractReport([])).toEqual({ lines: [], hasError: false });
-    });
-});
-describe("packageDoctor — content package-id form", () => {
-    function mockClient(preview) {
-        return {
-            getWorkspaceId: () => "wsp_1",
-            listContentInstallations: async () => [
-                {
-                    id: "pci_1",
-                    package_id: "apg_corpus",
-                    workspace_id: "wsp_1",
-                    package_version: preview.from_version,
-                    app_id: null,
-                    binding: { knowledge: {}, templates: {} },
-                    installed_by: null,
-                    created_at: "",
-                    updated_at: "",
-                    package_registry: {
-                        name: "Ops corpus",
-                        kind: "content",
-                        is_official: false,
-                        latest_version: preview.to_version,
-                        update_available: preview.to_version > preview.from_version,
-                    },
-                },
-            ],
-            previewContentInstallationUpgrade: async () => preview,
-        };
-    }
-    it("reports a healthy, pristine install without failing the check", async () => {
-        const lines = [];
-        vi.spyOn(console, "error").mockImplementation((msg) => void lines.push(msg));
-        const before = process.exitCode;
-        await packageDoctor(mockClient({ from_version: 3, to_version: 3, entries: [], templates: [] }), { app_id: "apg_corpus" });
-        expect(lines.join("\n")).toContain("Ops corpus — content installation of apg_corpus");
-        expect(lines.join("\n")).toContain("Installed: v3   Latest: v3");
-        expect(lines.join("\n")).toContain("Binding: healthy");
-        expect(lines.join("\n")).toContain("Content: pristine");
-        expect(process.exitCode).toBe(before);
-        vi.restoreAllMocks();
-    });
-    it("reports drift (non-zero exit) and local edits with their consent framing", async () => {
-        const lines = [];
-        vi.spyOn(console, "error").mockImplementation((msg) => void lines.push(msg));
-        await packageDoctor(mockClient({
-            from_version: 2,
-            to_version: 3,
-            entries: [
-                { alias: "sop", name: "SOP", change: "drifted", modified: false, doc_id: null },
-                { alias: "pricing", name: "Pricing", change: "changed", modified: true, doc_id: "kdc_2" },
-            ],
-            templates: [{ kind: "template", alias: "bien_ban" }],
-        }), { app_id: "apg_corpus" });
-        const out = lines.join("\n");
-        expect(out).toContain("→ update available");
-        expect(out).toContain('knowledge.sop "SOP" (bound doc is gone)');
-        expect(out).toContain("--resolve knowledge.<alias>=recreate|unbind");
-        expect(out).toContain('knowledge.pricing "Pricing"');
-        expect(out).toContain("template.bien_ban");
-        expect(process.exitCode).toBe(1);
-        process.exitCode = 0;
-        vi.restoreAllMocks();
-    });
-});