@lotics/cli 0.86.0 → 0.86.2

package/dist/package_commands.test.js

@@ -2,7 +2,7 @@ import { describe, it, expect, vi } from "vitest";
 import fs from "node:fs";
 import path from "node:path";
 import { tmpdir } from "node:os";
-import { parseResolveFlags, parseBindToFlags, parseRenameFlags, readLocalAppManifest, formatExtractReport, appRelease, packageUpgradeByPackageId, } from "./package_commands.js";
+import { parseResolveFlags, parseBindToFlags, parseRenameFlags, readLocalAppManifest, formatExtractReport, appRelease, packageUpgradeByPackageId, packageDoctor, } from "./package_commands.js";
 import { parseArgs } from "./args.js";
 describe("parseRenameFlags", () => {
     it("parses old=new pairs", () => {
@@ -20,21 +20,42 @@ describe("parseRenameFlags", () => {
     });
 });
 describe("readLocalAppManifest", () => {
-    it("reads app_id + knowledge from a pulled app project", () => {
+    function withManifest(lotics, fn) {
         const dir = fs.mkdtempSync(path.join(tmpdir(), "lotics-app-test-"));
         try {
-            fs.writeFileSync(path.join(dir, "package.json"), JSON.stringify({
-                name: "crm",
-                lotics: { app_id: "app_x", knowledge: [{ alias: "sop", doc_id: "kdc_1" }] },
-            }));
-            expect(readLocalAppManifest(dir)).toEqual({
-                app_id: "app_x",
-                knowledge: [{ alias: "sop", doc_id: "kdc_1" }],
-            });
+            fs.writeFileSync(path.join(dir, "package.json"), JSON.stringify({ name: "crm", lotics }));
+            return fn(dir);
         }
         finally {
             fs.rmSync(dir, { recursive: true, force: true });
         }
+    }
+    it("reads app_id + knowledge + config from a pulled app project", () => {
+        withManifest({
+            app_id: "app_x",
+            knowledge: [{ alias: "sop", doc_id: "kdc_1" }],
+            config: [{ alias: "page_size", label: "Page size", type: "number", default: 25 }],
+        }, (dir) => {
+            expect(readLocalAppManifest(dir)).toEqual({
+                app_id: "app_x",
+                knowledge: [{ alias: "sop", doc_id: "kdc_1" }],
+                config: [{ alias: "page_size", label: "Page size", type: "number", default: 25 }],
+            });
+        });
+    });
+    it("defaults knowledge + config to empty arrays when the manifest omits them", () => {
+        withManifest({ app_id: "app_x" }, (dir) => {
+            expect(readLocalAppManifest(dir)).toEqual({ app_id: "app_x", knowledge: [], config: [] });
+        });
+    });
+    it("validates each config knob against the shared schema, throwing NAMING the bad alias", () => {
+        withManifest({
+            app_id: "app_x",
+            // A select knob with no `options` — the shared schema rejects it.
+            config: [{ alias: "theme", label: "Theme", type: "select", default: "light" }],
+        }, (dir) => {
+            expect(() => readLocalAppManifest(dir)).toThrow(/lotics\.config knob "theme"/);
+        });
     });
     it("returns null when the dir has no package.json", () => {
         const dir = fs.mkdtempSync(path.join(tmpdir(), "lotics-empty-"));
@@ -146,27 +167,30 @@ describe("parseArgs — package list-content", () => {
         expect(flags.workspace).toBe("wsp_dev");
     });
 });
-describe("appRelease — knowledge declaration forwarding", () => {
+describe("appRelease — knowledge + config declaration forwarding", () => {
+    const pageSizeKnob = { alias: "page_size", label: "Page size", type: "number", default: 25 };
     const previewResult = {
         package_id: "apg_1",
         version: 2,
         added_aliases: [],
         changed_artifacts: [],
         knowledge: { added: ["guide"], removed: [], changed: [] },
+        config: { added: ["page_size"], removed: [], changed: [] },
         findings: [],
     };
-    /** A mock client capturing the knowledge forwarded to preview + release. */
-    function mockClient() {
+    /** A mock client capturing the knowledge + config forwarded to preview + release. */
+    function mockClient(overridePreview) {
         const preview = [];
         const release = [];
+        const result = { ...previewResult, ...overridePreview };
         const client = {
             previewPackageRelease: async (app_id, opts = {}) => {
                 preview.push({ app_id, opts });
-                return previewResult;
+                return result;
             },
             releasePackage: async (app_id, body) => {
                 release.push({ app_id, body });
-                return { ...previewResult, findings: undefined };
+                return { ...result, findings: undefined };
             },
         };
         return { client, preview, release };
@@ -176,33 +200,53 @@ describe("appRelease — knowledge declaration forwarding", () => {
         fs.writeFileSync(path.join(dir, "package.json"), JSON.stringify({ name: "app", lotics }));
         return fn(dir).finally(() => fs.rmSync(dir, { recursive: true, force: true }));
     }
-    it("forwards the manifest's knowledge declaration from the app's own project", async () => {
+    it("forwards the manifest's knowledge + config declarations from the app's own project", async () => {
         vi.spyOn(console, "error").mockImplementation(() => undefined);
         const { client, preview, release } = mockClient();
-        await withManifestDir({ app_id: "app_x", knowledge: [{ alias: "guide", doc_id: "kdc_1" }] }, async (dir) => {
+        await withManifestDir({ app_id: "app_x", knowledge: [{ alias: "guide", doc_id: "kdc_1" }], config: [pageSizeKnob] }, async (dir) => {
             await appRelease(client, { app_id: ".", changelog: "ship", yes: true, projectDir: dir });
         });
-        expect(preview[0]).toEqual({ app_id: "app_x", opts: { knowledge: [{ alias: "guide", doc_id: "kdc_1" }] } });
-        expect(release[0].body).toEqual({ changelog: "ship", knowledge: [{ alias: "guide", doc_id: "kdc_1" }] });
+        expect(preview[0]).toEqual({
+            app_id: "app_x",
+            opts: { knowledge: [{ alias: "guide", doc_id: "kdc_1" }], config: [pageSizeKnob] },
+        });
+        expect(release[0].body).toEqual({
+            changelog: "ship",
+            knowledge: [{ alias: "guide", doc_id: "kdc_1" }],
+            config: [pageSizeKnob],
+        });
         vi.restoreAllMocks();
     });
-    it("omits knowledge (reconstruct from the pin) when the manifest declares none", async () => {
+    it("omits knowledge + config (reconstruct/carry-forward) when the manifest declares neither", async () => {
         vi.spyOn(console, "error").mockImplementation(() => undefined);
         const { client, preview, release } = mockClient();
         await withManifestDir({ app_id: "app_x" }, async (dir) => {
             await appRelease(client, { app_id: ".", changelog: "ship", yes: true, projectDir: dir });
         });
-        expect(preview[0].opts).toEqual({ knowledge: undefined });
-        expect(release[0].body).toEqual({ changelog: "ship", knowledge: undefined });
+        expect(preview[0].opts).toEqual({ knowledge: undefined, config: undefined });
+        expect(release[0].body).toEqual({ changelog: "ship", knowledge: undefined, config: undefined });
         vi.restoreAllMocks();
     });
-    it("omits knowledge for a bare app id whose manifest is a DIFFERENT app", async () => {
+    it("omits knowledge + config for a bare app id whose manifest is a DIFFERENT app", async () => {
         vi.spyOn(console, "error").mockImplementation(() => undefined);
         const { client, preview } = mockClient();
-        await withManifestDir({ app_id: "app_other", knowledge: [{ alias: "guide", doc_id: "kdc_1" }] }, async (dir) => {
+        await withManifestDir({ app_id: "app_other", knowledge: [{ alias: "guide", doc_id: "kdc_1" }], config: [pageSizeKnob] }, async (dir) => {
             await appRelease(client, { app_id: "app_x", changelog: "ship", yes: true, projectDir: dir });
         });
-        expect(preview[0]).toEqual({ app_id: "app_x", opts: { knowledge: undefined } });
+        expect(preview[0]).toEqual({ app_id: "app_x", opts: { knowledge: undefined, config: undefined } });
+        vi.restoreAllMocks();
+    });
+    it("warns LOUDLY when a SENT config declaration is ignored by a pre-declaration server (deploy skew)", async () => {
+        const errs = [];
+        vi.spyOn(console, "error").mockImplementation((msg) => {
+            errs.push(String(msg));
+        });
+        // A pre-declaration server omits `config` from the preview echo.
+        const { client } = mockClient({ config: undefined });
+        await withManifestDir({ app_id: "app_x", config: [pageSizeKnob] }, async (dir) => {
+            await appRelease(client, { app_id: ".", changelog: "ship", yes: true, projectDir: dir });
+        });
+        expect(errs.some((e) => /server ignored the config declaration/.test(e))).toBe(true);
         vi.restoreAllMocks();
     });
 });
@@ -307,3 +351,65 @@ describe("formatExtractReport", () => {
         expect(formatExtractReport([])).toEqual({ lines: [], hasError: false });
     });
 });
+describe("packageDoctor — content package-id form", () => {
+    function mockClient(preview) {
+        return {
+            getWorkspaceId: () => "wsp_1",
+            listContentInstallations: async () => [
+                {
+                    id: "pci_1",
+                    package_id: "apg_corpus",
+                    workspace_id: "wsp_1",
+                    package_version: preview.from_version,
+                    app_id: null,
+                    binding: { knowledge: {}, templates: {} },
+                    installed_by: null,
+                    created_at: "",
+                    updated_at: "",
+                    package_registry: {
+                        name: "Ops corpus",
+                        kind: "content",
+                        is_official: false,
+                        latest_version: preview.to_version,
+                        update_available: preview.to_version > preview.from_version,
+                    },
+                },
+            ],
+            previewContentInstallationUpgrade: async () => preview,
+        };
+    }
+    it("reports a healthy, pristine install without failing the check", async () => {
+        const lines = [];
+        vi.spyOn(console, "error").mockImplementation((msg) => void lines.push(msg));
+        const before = process.exitCode;
+        await packageDoctor(mockClient({ from_version: 3, to_version: 3, entries: [], templates: [] }), { app_id: "apg_corpus" });
+        expect(lines.join("\n")).toContain("Ops corpus — content installation of apg_corpus");
+        expect(lines.join("\n")).toContain("Installed: v3   Latest: v3");
+        expect(lines.join("\n")).toContain("Binding: healthy");
+        expect(lines.join("\n")).toContain("Content: pristine");
+        expect(process.exitCode).toBe(before);
+        vi.restoreAllMocks();
+    });
+    it("reports drift (non-zero exit) and local edits with their consent framing", async () => {
+        const lines = [];
+        vi.spyOn(console, "error").mockImplementation((msg) => void lines.push(msg));
+        await packageDoctor(mockClient({
+            from_version: 2,
+            to_version: 3,
+            entries: [
+                { alias: "sop", name: "SOP", change: "drifted", modified: false, doc_id: null },
+                { alias: "pricing", name: "Pricing", change: "changed", modified: true, doc_id: "kdc_2" },
+            ],
+            templates: [{ kind: "template", alias: "bien_ban" }],
+        }), { app_id: "apg_corpus" });
+        const out = lines.join("\n");
+        expect(out).toContain("→ update available");
+        expect(out).toContain('knowledge.sop "SOP" (bound doc is gone)');
+        expect(out).toContain("--resolve knowledge.<alias>=recreate|unbind");
+        expect(out).toContain('knowledge.pricing "Pricing"');
+        expect(out).toContain("template.bien_ban");
+        expect(process.exitCode).toBe(1);
+        process.exitCode = 0;
+        vi.restoreAllMocks();
+    });
+});