@lotics/cli 0.76.0 → 0.83.0

package/dist/cli_dispatch.test.js

@@ -1,11 +1,14 @@
 /**
- * Dispatch smoke test over the BUILT CLI artifact — every `package` subcommand
- * must route to its own handler, proven by its usage/refusal line appearing on
- * a bare invocation. The dispatch in cli.ts is one hand-rolled argv walk with
- * subcommand names repeated across command families (`doctor` exists in both
- * `workspace` and `package`) and split positional conventions (`toolArgs` +
- * `restArgs`), and nothing else tests it: `package yank` shipped dispatched
- * inside the WORKSPACE family and surfaced only on the first live invocation.
+ * Dispatch smoke test over the BUILT CLI artifact — every `package` subcommand,
+ * the top-level consumer verbs (`install`/`uninstall`/`upgrade`), and the app
+ * author verbs (publish/release/unpublish) must route to their own handler,
+ * proven by the usage/refusal line appearing on a bare invocation. The dispatch
+ * in cli.ts is one hand-rolled argv walk with subcommand names repeated across
+ * command families (`doctor` exists in both `workspace` and `package`) and split
+ * positional conventions (top-level verbs read the id from `subcommand`; the
+ * `package` family from `toolArgs`), and nothing else tests it: `package yank`
+ * shipped dispatched inside the WORKSPACE family and surfaced only on the first
+ * live invocation.
  *
  * The fake API key satisfies `requireClient` (client construction is offline);
  * every asserted path exits before any network call. Spawns run in an empty
@@ -48,18 +51,11 @@ describe("lotics package <subcommand> dispatch", () => {
     // subcommand's OWN usage line — reaching it proves family routing AND that
     // the usage gate fires before any network/filesystem work.
     const usageCases = [
-        ["install", /Usage: lotics package install/],
-        ["uninstall", /Usage: lotics package uninstall/],
         ["config", /Usage: lotics package config/],
-        ["retire", /Usage: lotics package retire <package_id>/],
         ["show", /Usage: lotics package show <package_id>/],
-        ["upgrade", /Usage: lotics package upgrade/],
         ["yank", /Usage: lotics package yank <package_id> <version>/],
-        ["rebind-role", /Usage: lotics package rebind-role/],
-        ["fleet-upgrade", /Usage: lotics package fleet-upgrade/],
-        ["extract", /Usage: lotics package extract/],
-        ["adopt", /Usage: lotics package adopt/],
-        ["new", /Usage: lotics package new/],
+        // Folded into the upgrade grammar — the removed verb must redirect loudly.
+        ["rebind-role", /folded into the upgrade grammar[\s\S]*--resolve roles\./],
     ];
     for (const [sub, usage] of usageCases) {
         it(`routes "package ${sub}" to its handler (usage on missing args)`, () => {
@@ -69,16 +65,30 @@ describe("lotics package <subcommand> dispatch", () => {
             expect(status).toBe(1);
         });
     }
-    // Path-defaulting subcommands: in an empty cwd they must fail on the missing
-    // package project — their handler's message, not the dispatcher's. (`sync`
-    // is excluded: it validates the dev workspace over the network BEFORE
-    // reading the project, so it can't be smoke-tested offline.)
-    const projectCases = ["build", "publish"];
-    for (const sub of projectCases) {
-        it(`routes "package ${sub}" to its handler (missing project in empty cwd)`, () => {
+    // The high-traffic consumer verbs MOVED to the top level. The old
+    // `lotics package <verb>` forms must REJECT with a redirect (never silently
+    // do nothing) — proving the removal is loud and points to the new form.
+    const movedForms = [
+        ["install", /moved to the top level.*lotics install/],
+        ["uninstall", /moved to the top level.*lotics uninstall/],
+        ["upgrade", /moved to the top level.*lotics upgrade/],
+        ["fleet-upgrade", /moved to the top level.*lotics upgrade <package_id>/],
+    ];
+    for (const [sub, redirect] of movedForms) {
+        it(`rejects the moved "package ${sub}" form with a top-level redirect`, () => {
             const { status, stderr } = runCli(["package", sub]);
-            expect(stderr).toMatch(/No package\.json in|not a package project/);
-            expect(stderr).not.toMatch(/Unknown package subcommand/);
+            expect(stderr).toMatch(redirect);
+            expect(status).toBe(1);
+        });
+    }
+    // Deleted author-loop + package-project surfaces must be GONE, not silently
+    // absorbed: each now falls through to the unknown-subcommand refusal. Content
+    // packages are published via the `publish_content`/`release_content` tools
+    // (`lotics run …`), apps via `lotics app publish`/`release`.
+    for (const sub of ["dev", "sync", "reset", "extract", "adopt", "retire", "release", "new", "build", "publish"]) {
+        it(`rejects the removed "package ${sub}" subcommand`, () => {
+            const { status, stderr } = runCli(["package", sub]);
+            expect(stderr).toMatch(/Unknown package subcommand/);
             expect(status).toBe(1);
         });
     }
@@ -88,3 +98,45 @@ describe("lotics package <subcommand> dispatch", () => {
         expect(status).toBe(1);
     });
 });
+describe("lotics top-level consumer-verb dispatch", () => {
+    // The noun-less consumer verbs route from the top level (the package id is the
+    // second positional → `subcommand`), each proven by its OWN usage line on a
+    // bare invocation — reaching it fires before any network work.
+    const usageCases = [
+        ["install", /Usage: lotics install <package_id>/],
+        ["uninstall", /Usage: lotics uninstall <app_id\|pci_id>/],
+        ["upgrade", /Usage: lotics upgrade <app_id \| pci_id \| package_id>/],
+    ];
+    for (const [verb, usage] of usageCases) {
+        it(`routes top-level "${verb}" to its handler (usage on missing id)`, () => {
+            const { status, stderr } = runCli([verb]);
+            expect(stderr).toMatch(usage);
+            expect(stderr).not.toMatch(/Unknown command/);
+            expect(status).toBe(1);
+        });
+    }
+});
+describe("lotics app author-verb dispatch", () => {
+    // `app publish` (no id, empty cwd) must fail on the missing local app
+    // manifest — its handler's message, proving routing without any network.
+    it('routes "app publish" to its handler (no app id in empty cwd)', () => {
+        const { status, stderr } = runCli(["app", "publish"]);
+        expect(stderr).toMatch(/No app id/);
+        expect(stderr).not.toMatch(/Unknown app subcommand/);
+        expect(status).toBe(1);
+    });
+    // `app release` requires -m before any resolution.
+    it('routes "app release" to its handler (usage on missing -m)', () => {
+        const { status, stderr } = runCli(["app", "release"]);
+        expect(stderr).toMatch(/Usage: lotics app release/);
+        expect(stderr).not.toMatch(/Unknown app subcommand/);
+        expect(status).toBe(1);
+    });
+    // `app unpublish` requires an id.
+    it('routes "app unpublish" to its handler (usage on missing id)', () => {
+        const { status, stderr } = runCli(["app", "unpublish"]);
+        expect(stderr).toMatch(/Usage: lotics app unpublish/);
+        expect(stderr).not.toMatch(/Unknown app subcommand/);
+        expect(status).toBe(1);
+    });
+});