@lota-sdk/core 0.1.14 → 0.1.15

package/src/services/memory.service.ts

@@ -24,10 +24,12 @@ import {
   scopedRetrievalToMap,
 } from '../runtime/retrieval-adapters'
 import { getRuntimeConfig } from '../runtime/runtime-config'
-import { createMemoryRerankerAgent, memoryRerankerPrompt } from '../system-agents/memory-reranker.agent'
-import { createOrgMemoryAgent, orgMemoryPrompt } from '../system-agents/memory.agent'
+import { createMemoryRerankerAgent, MEMORY_RERANKER_PROMPT } from '../system-agents/memory-reranker.agent'
+import { createOrgMemoryAgent, ORG_MEMORY_PROMPT } from '../system-agents/memory.agent'
+import { toError } from '../utils/errors'
+import { compactWhitespace } from '../utils/string'
 import { assessMemoryImportance, clampMemoryImportance } from './memory-assessment.service'
-import { formatMemoryResults, formatRerankedResults, getCandidateLimit } from './memory.utils'
+import { formatMemoryResults, formatRerankedResults, getCandidateLimit } from './memory-utils'
 
 const ORG_MEMORY_TYPE = 'fact'
 const RERANK_CANDIDATE_MAX_CHARS = 500
@@ -72,7 +74,7 @@ class MemoryService {
     const cached = cache.get(cacheKey)
     if (cached) return cached
 
-    const memory = new Memory({ createAgent: createOrgMemoryAgent }, { customPrompt: orgMemoryPrompt })
+    const memory = new Memory({ createAgent: createOrgMemoryAgent }, { customPrompt: ORG_MEMORY_PROMPT })
 
     cache.set(cacheKey, memory)
     aiLogger.debug`Memory client created and cached for ${cacheKey}`
@@ -85,7 +87,7 @@ class MemoryService {
   }
 
   private truncateCandidateText(value: string): string {
-    const normalized = value.replace(/\s+/g, ' ').trim()
+    const normalized = compactWhitespace(value)
     if (normalized.length <= RERANK_CANDIDATE_MAX_CHARS) return normalized
     return `${normalized.slice(0, RERANK_CANDIDATE_MAX_CHARS)}...`
   }
@@ -125,7 +127,7 @@ class MemoryService {
   }
 
   private normalizeConversationText(value: string, maxChars: number): string {
-    const normalized = value.replace(/\s+/g, ' ').trim()
+    const normalized = compactWhitespace(value)
     if (!normalized) return ''
     if (normalized.length <= maxChars) return normalized
     return `${normalized.slice(0, maxChars - 3)}...`
@@ -146,7 +148,7 @@ class MemoryService {
   }
 
   private normalizePreSeededMemoryText(value: string): string {
-    const normalized = value.replace(/\s+/g, ' ').trim()
+    const normalized = compactWhitespace(value)
     if (normalized.length <= PRESEEDED_MEMORY_MAX_CHARS) return normalized
     return `${normalized.slice(0, PRESEEDED_MEMORY_MAX_CHARS - 3)}...`
   }
@@ -232,7 +234,7 @@ class MemoryService {
       return await helperModelRuntime.generateHelperStructured({
         tag: 'memory-reranker',
         createAgent: createMemoryRerankerAgent,
-        defaultSystemPrompt: memoryRerankerPrompt,
+        defaultSystemPrompt: MEMORY_RERANKER_PROMPT,
         messages: [
           {
             role: 'user',
@@ -269,7 +271,7 @@ class MemoryService {
       return await helperModelRuntime.generateHelperStructured({
         tag: 'memory-reranker-multi-scope',
         createAgent: createMemoryRerankerAgent,
-        defaultSystemPrompt: memoryRerankerPrompt,
+        defaultSystemPrompt: MEMORY_RERANKER_PROMPT,
         messages: [
           {
             role: 'user',
@@ -334,7 +336,7 @@ class MemoryService {
       aiLogger.debug`Organization memory search completed (resultLength: ${results.length}, preview: ${results.slice(0, 100)})`
       return results
     } catch (error: unknown) {
-      const normalizedError = error instanceof Error ? error : new Error(String(error))
+      const normalizedError = toError(error)
       aiLogger.error`Organization memory search failed: ${normalizedError}`
       throw normalizedError
     }
@@ -348,7 +350,8 @@ class MemoryService {
       if (stale.length === 0) return ''
       const items = stale.map((m) => `- [NEEDS REVIEW] ${m.content}`).join('\n')
       return `Memories flagged for review (parent fact was superseded):\n${items}`
-    } catch {
+    } catch (error) {
+      aiLogger.warn`Failed to get stale memories: ${error}`
       return ''
     }
   }
@@ -359,7 +362,7 @@ class MemoryService {
     options?: { fastMode?: boolean; limit?: number },
   ): Promise<string> {
     const orgScopeId = scopeId(ORG_SCOPE_PREFIX, orgId)
-    aiLogger.info`[MEMORY_DEBUG] searchOrganizationMemoriesRaw - orgId: "${orgId}", scopeId: "${orgScopeId}"`
+    aiLogger.debug`searchOrganizationMemoriesRaw - orgId: "${orgId}", scopeId: "${orgScopeId}"`
     const memory = this.getOrgMemory(orgId)
     const fastMode = options?.fastMode ?? true
     const searchK = getRuntimeConfig().memory.searchK
@@ -376,7 +379,7 @@ class MemoryService {
       aiLogger.debug`Organization memory search (raw) completed (candidates: ${candidates.length})`
       return formatMemoryResults(candidates)
     } catch (error: unknown) {
-      const normalizedError = error instanceof Error ? error : new Error(String(error))
+      const normalizedError = toError(error)
       aiLogger.error`Organization memory search (raw) failed: ${normalizedError}`
       throw normalizedError
     }
@@ -397,7 +400,7 @@ class MemoryService {
       aiLogger.debug`Agent memory search completed (agentName: ${agentName}, resultLength: ${results.length}, preview: ${results.slice(0, 100)})`
       return results
     } catch (error: unknown) {
-      const normalizedError = error instanceof Error ? error : new Error(String(error))
+      const normalizedError = toError(error)
       aiLogger.error`Agent memory search failed: ${normalizedError}`
       throw normalizedError
     }
@@ -467,7 +470,7 @@ class MemoryService {
     const deduped: MemoryRecord[] = []
     const seen = new Set<string>()
     for (const memory of combined) {
-      const normalizedKey = memory.content.replace(/\s+/g, ' ').trim().toLowerCase()
+      const normalizedKey = compactWhitespace(memory.content).toLowerCase()
       if (!normalizedKey || seen.has(normalizedKey)) continue
       seen.add(normalizedKey)
       deduped.push(memory)
@@ -594,7 +597,7 @@ class MemoryService {
     durability?: MemoryRecord['durability']
   }): Promise<string> {
     const orgScopeId = scopeId(ORG_SCOPE_PREFIX, orgId)
-    aiLogger.info`[MEMORY_DEBUG] createOrganizationMemory - orgId: "${orgId}", scopeId: "${orgScopeId}", content preview: "${content.slice(0, 50)}"`
+    aiLogger.debug`createOrganizationMemory - orgId: "${orgId}", scopeId: "${orgScopeId}", content preview: "${content.slice(0, 50)}"`
     const memory = this.getOrgMemory(orgId)
     try {
       return await memory.insert(content, {
@@ -762,7 +765,7 @@ class MemoryService {
     }
 
     const orgScopeId = scopeId(ORG_SCOPE_PREFIX, orgId)
-    aiLogger.info`[MEMORY_DEBUG] addConversationMemories - orgId: "${orgId}", scopeId: "${orgScopeId}", sourceId: ${sourceId ?? 'none'}`
+    aiLogger.debug`addConversationMemories - orgId: "${orgId}", scopeId: "${orgScopeId}", sourceId: ${sourceId ?? 'none'}`
 
     const orgMemory = this.getOrgMemory(orgId)
     let assessedImportance: number | undefined
@@ -833,7 +836,7 @@ class MemoryService {
       })
       aiLogger.debug`Conversation memories added to ${scopes.length} scope(s) from ${messages.length} message(s)`
     } catch (error: unknown) {
-      const normalizedError = error instanceof Error ? error : new Error(String(error))
+      const normalizedError = toError(error)
       aiLogger.error`Memory write failed: ${normalizedError}`
       throw normalizedError
     }

package/src/services/organization-member.service.ts

@@ -23,7 +23,7 @@ const sdkOrganizationMemberSchema = z.object({
   createdAt: z.iso.datetime(),
 })
 
-export type SdkOrganizationMemberRecord = z.infer<typeof organizationMemberRecordSchema>
+type SdkOrganizationMemberRecord = z.infer<typeof organizationMemberRecordSchema>
 export type SdkOrganizationMember = z.infer<typeof sdkOrganizationMemberSchema>
 
 class OrganizationMemberService extends BaseService<typeof organizationMemberRecordSchema> {

package/src/services/plan-artifact.service.ts

@@ -17,6 +17,7 @@ class PlanArtifactService {
   }): Promise<PlanArtifactRecord[]> {
     const records: PlanArtifactRecord[] = []
 
+    // Sequential: SurrealDB transactions require ordered operations
     for (const artifact of params.artifacts) {
       const artifactId = new RecordId(TABLES.PLAN_ARTIFACT, Bun.randomUUIDv7())
       const created = await params.tx

package/src/services/plan-executor.service.ts

@@ -26,9 +26,11 @@ import { ensureRecordId, recordIdToString } from '../db/record-id'
 import { databaseService } from '../db/service'
 import type { DatabaseTransaction } from '../db/service'
 import { TABLES } from '../db/tables'
+import { isRecord } from '../utils/string'
 import { planApprovalService } from './plan-approval.service'
 import { planArtifactService } from './plan-artifact.service'
 import { planCheckpointService } from './plan-checkpoint.service'
+import { readPathValue } from './plan-helpers'
 import { planRunService } from './plan-run.service'
 import type { PlanValidationIssueInput } from './plan-validator.service'
 import { planValidatorService } from './plan-validator.service'
@@ -37,24 +39,6 @@ const SUCCESSFUL_TERMINAL_NODE_STATUSES = new Set(['completed', 'partial', 'skip
 const HUMAN_NODE_TYPES = new Set(['human-input', 'human-approval', 'human-review-edit', 'human-decision'])
 const STRUCTURAL_NODE_TYPES = new Set(['switch', 'join'])
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return Boolean(value) && typeof value === 'object' && !Array.isArray(value)
-}
-
-function readPathValue(source: unknown, path: string): unknown {
-  if (!path.trim()) return source
-
-  let current: unknown = source
-  for (const segment of path
-    .split('.')
-    .map((part) => part.trim())
-    .filter(Boolean)) {
-    if (!isRecord(current)) return undefined
-    current = current[segment]
-  }
-  return current
-}
-
 function setPathValue(target: Record<string, unknown>, path: string, value: unknown) {
   const segments = path
     .split('.')

package/src/services/plan-helpers.ts

@@ -0,0 +1,15 @@
+import { isRecord } from '../utils/string'
+
+export function readPathValue(source: unknown, path: string): unknown {
+  if (!path.trim()) return source
+
+  let current: unknown = source
+  for (const segment of path
+    .split('.')
+    .map((part) => part.trim())
+    .filter(Boolean)) {
+    if (!isRecord(current)) return undefined
+    current = current[segment]
+  }
+  return current
+}

package/src/services/plan-validator.service.ts

@@ -8,6 +8,9 @@ import type {
   PlanValidationIssueSeverity,
 } from '@lota-sdk/shared'
 
+import { isRecord } from '../utils/string'
+import { readPathValue } from './plan-helpers'
+
 const STRUCTURAL_NODE_TYPES = new Set(['switch', 'join'])
 const HUMAN_NODE_TYPES = new Set(['human-input', 'human-approval', 'human-review-edit', 'human-decision'])
 
@@ -46,24 +49,6 @@ function createIssue(params: {
   }
 }
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return Boolean(value) && typeof value === 'object' && !Array.isArray(value)
-}
-
-function readPathValue(source: unknown, path: string): unknown {
-  if (!path.trim()) return source
-
-  let current: unknown = source
-  for (const segment of path
-    .split('.')
-    .map((part) => part.trim())
-    .filter(Boolean)) {
-    if (!isRecord(current)) return undefined
-    current = current[segment]
-  }
-  return current
-}
-
 function hasAllFields(value: unknown, fields: string[]): boolean {
   if (!isRecord(value)) return false
   return fields.every((field) => readPathValue(value, field) !== undefined)

package/src/services/recent-activity-title.service.ts

@@ -1,20 +1,13 @@
 import { createHelperModelRuntime } from '../runtime/helper-model'
+import { normalizeTitle } from '../runtime/title-helpers'
 import {
   createRecentActivityTitleRefinerAgent,
-  recentActivityTitleRefinerPrompt,
+  RECENT_ACTIVITY_TITLE_REFINER_PROMPT,
 } from '../system-agents/recent-activity-title-refiner.agent'
-import { compactWhitespace } from '../utils/string'
 import { recentActivityService } from './recent-activity.service'
 
 const RECENT_ACTIVITY_TITLE_TIMEOUT_MS = 60_000
 
-function normalizeTitle(value: string): string {
-  const normalized = compactWhitespace(value)
-    .replace(/^["'`]+|["'`]+$/g, '')
-    .replace(/[.!?,;:]+$/g, '')
-  return normalized.length <= 80 ? normalized : normalized.slice(0, 80).trim()
-}
-
 function buildRefinementPromptInput(
   candidate: Awaited<ReturnType<typeof recentActivityService.getRefinementCandidate>>,
 ) {
@@ -52,7 +45,7 @@ class RecentActivityTitleService {
       await this.helperRuntime.generateHelperText({
         tag: 'recent-activity-title-refinement',
         createAgent: createRecentActivityTitleRefinerAgent,
-        defaultSystemPrompt: recentActivityTitleRefinerPrompt,
+        defaultSystemPrompt: RECENT_ACTIVITY_TITLE_REFINER_PROMPT,
         timeoutMs: RECENT_ACTIVITY_TITLE_TIMEOUT_MS,
         messages: [{ role: 'user', content: promptInput }],
       }),

package/src/services/recent-activity.service.ts

@@ -166,18 +166,12 @@ class RecentActivityService {
   }): Promise<RecentActivity[]> {
     await databaseService.connect()
 
-    const items: RecentActivity[] = []
-    for (const candidate of params.events) {
-      const recorded = await this.recordEvent({
-        orgId: params.orgId,
-        userId: params.userId,
-        source: params.source,
-        event: candidate,
-      })
-      items.push(recorded.item)
-    }
-
-    return items
+    const results = await Promise.all(
+      params.events.map((candidate) =>
+        this.recordEvent({ orgId: params.orgId, userId: params.userId, source: params.source, event: candidate }),
+      ),
+    )
+    return results.map((r) => r.item)
   }
 
   async recordEvent(params: {

package/src/services/workstream-message.service.ts

@@ -1,3 +1,5 @@
+import { createHash } from 'node:crypto'
+
 import { parseRowMetadata, toTimestamp, withCreatedAtMetadata } from '@lota-sdk/shared'
 import type { ChatMessage } from '@lota-sdk/shared'
 import { RecordId, surql } from 'surrealdb'
@@ -33,14 +35,21 @@ function toMessageId(value: string | RecordIdRef): string {
   return recordIdToString(value, TABLES.WORKSTREAM_MESSAGE)
 }
 
+/**
+ * Builds a collision-free row id by hashing the workstream + message id pair.
+ * Previous implementation replaced non-alphanumeric chars with '_', which was
+ * lossy (e.g. "msg:foo" and "msg_foo" mapped to the same row id).
+ * Now uses a 32-char SHA-256 hex prefix -- short enough for ergonomic ids,
+ * long enough (128 bits) to make collisions negligible.
+ */
 function toWorkstreamMessageRowId(workstreamId: RecordIdRef, messageId: string): RecordId {
-  const workstreamPart = recordIdToString(workstreamId, TABLES.WORKSTREAM).replace(/[^a-zA-Z0-9_-]/g, '_')
-  const messagePart = messageId.replace(/[^a-zA-Z0-9_-]/g, '_')
-  return new RecordId(TABLES.WORKSTREAM_MESSAGE, `${workstreamPart}__${messagePart}`)
+  const workstreamStr = recordIdToString(workstreamId, TABLES.WORKSTREAM)
+  const digest = createHash('sha256').update(`${workstreamStr}\0${messageId}`).digest('hex').slice(0, 32)
+  return new RecordId(TABLES.WORKSTREAM_MESSAGE, digest)
 }
 
 function toChatMessage(row: WorkstreamMessageRow): ChatMessage {
-  const rowCreatedAt = toTimestamp(row.createdAt)
+  const rowCreatedAt = toTimestamp(row.createdAt) ?? Date.now()
   const metadata = withCreatedAtMetadata(parseRowMetadata(row.metadata), rowCreatedAt)
 
   return { id: row.messageId, role: row.role, parts: (row.parts ?? []) as ChatMessage['parts'], metadata }
@@ -74,16 +83,16 @@ class WorkstreamMessageService {
   async upsertMessages(params: { workstreamId: RecordIdRef; messages: ChatMessage[] }): Promise<void> {
     const workstreamId = params.workstreamId
 
-    for (const message of params.messages) {
+    const upsertPromises = params.messages.map(async (message) => {
       const messageId = message.id.trim()
-      if (!messageId) continue
+      if (!messageId) return
 
       const role = message.role
       const parts = Array.isArray(message.parts)
         ? message.parts.map((part) => structuredClone(part) as Record<string, unknown>)
         : []
       if (parts.length === 0) {
-        if (role === 'assistant') continue
+        if (role === 'assistant') return
         throw new Error(`Refusing to persist workstream message "${messageId}" with empty parts`)
       }
       const rowId = toWorkstreamMessageRowId(workstreamId, messageId)
@@ -93,7 +102,9 @@ class WorkstreamMessageService {
         WorkstreamMessageExistingRowSchema,
       )
       const persistedCreatedAt =
-        existingRow === null ? toTimestamp(message.metadata?.createdAt) : toTimestamp(existingRow.createdAt)
+        existingRow === null
+          ? (toTimestamp(message.metadata?.createdAt) ?? Date.now())
+          : (toTimestamp(existingRow.createdAt) ?? Date.now())
       const metadata = withCreatedAtMetadata({ ...message.metadata, createdAt: persistedCreatedAt })
 
       await databaseService.upsert(
@@ -105,12 +116,15 @@ class WorkstreamMessageService {
           role,
           parts,
           metadata,
-          createdAt: existingRow ? new Date(toTimestamp(existingRow.createdAt)) : new Date(persistedCreatedAt),
+          createdAt: existingRow
+            ? new Date(toTimestamp(existingRow.createdAt) ?? Date.now())
+            : new Date(persistedCreatedAt),
         },
         WorkstreamMessageRowSchema,
         { mutation: 'content' },
       )
-    }
+    })
+    await Promise.all(upsertPromises)
   }
 
   async listMessages(workstreamId: RecordIdRef): Promise<ChatMessage[]> {
@@ -151,7 +165,7 @@ class WorkstreamMessageService {
       throw new Error(`Workstream cursor message not found: ${cursorMessageId}`)
     }
 
-    const cursorCreatedAt = new Date(toTimestamp(cursorRow.createdAt))
+    const cursorCreatedAt = new Date(toTimestamp(cursorRow.createdAt) ?? Date.now())
     const cursorId = toWorkstreamMessageRowId(workstreamId, cursorMessageId)
     const rows = await databaseService.query<unknown>(surql`
       SELECT * FROM workstreamMessage
@@ -195,7 +209,7 @@ class WorkstreamMessageService {
       .map((message) => ({
         id: message.id,
         role: message.role as 'user' | 'assistant',
-        createdAt: new Date(toTimestamp(message.metadata?.createdAt)).toISOString(),
+        createdAt: new Date(toTimestamp(message.metadata?.createdAt) ?? Date.now()).toISOString(),
         content: message.parts
           .flatMap((part) => (part.type === 'text' && typeof part.text === 'string' ? [part.text] : []))
           .join('\n')
@@ -273,10 +287,6 @@ class WorkstreamMessageService {
   async listAllMessages(workstreamId: RecordIdRef): Promise<ChatMessage[]> {
     return await this.listMessages(workstreamId)
   }
-
-  async addAttachments(): Promise<void> {
-    // Attachments are no longer persisted via workstreamMessage service in AI SDK mode.
-  }
 }
 
 export const workstreamMessageService = new WorkstreamMessageService()

package/src/services/workstream-title.service.ts

@@ -3,21 +3,13 @@ import { WORKSTREAM } from '@lota-sdk/shared'
 import { chatLogger } from '../config/logger'
 import type { RecordIdRef } from '../db/record-id'
 import { createHelperModelRuntime } from '../runtime/helper-model'
-import { deriveTitle, limitTitleWords } from '../runtime/title-helpers'
+import { deriveTitle, limitTitleWords, normalizeTitle } from '../runtime/title-helpers'
 import {
   createWorkstreamTitleGeneratorAgent,
   WORKSTREAM_TITLE_GENERATOR_PROMPT,
 } from '../system-agents/title-generator.agent'
-import { compactWhitespace } from '../utils/string'
 import { workstreamService } from './workstream.service'
 
-function normalizeTitle(value: string): string {
-  const normalized = compactWhitespace(value)
-    .replace(/^["'`]+|["'`]+$/g, '')
-    .replace(/[.!?,;:]+$/g, '')
-  return normalized.length <= 80 ? normalized : normalized.slice(0, 80).trim()
-}
-
 class WorkstreamTitleService {
   helperRuntime = createHelperModelRuntime()