@lota-sdk/core 0.1.13 → 0.1.15

package/src/services/workstream-message.service.ts

@@ -1,3 +1,5 @@
+import { createHash } from 'node:crypto'
+
 import { parseRowMetadata, toTimestamp, withCreatedAtMetadata } from '@lota-sdk/shared'
 import type { ChatMessage } from '@lota-sdk/shared'
 import { RecordId, surql } from 'surrealdb'
@@ -33,14 +35,21 @@ function toMessageId(value: string | RecordIdRef): string {
   return recordIdToString(value, TABLES.WORKSTREAM_MESSAGE)
 }
 
+/**
+ * Builds a collision-free row id by hashing the workstream + message id pair.
+ * Previous implementation replaced non-alphanumeric chars with '_', which was
+ * lossy (e.g. "msg:foo" and "msg_foo" mapped to the same row id).
+ * Now uses a 32-char SHA-256 hex prefix -- short enough for ergonomic ids,
+ * long enough (128 bits) to make collisions negligible.
+ */
 function toWorkstreamMessageRowId(workstreamId: RecordIdRef, messageId: string): RecordId {
-  const workstreamPart = recordIdToString(workstreamId, TABLES.WORKSTREAM).replace(/[^a-zA-Z0-9_-]/g, '_')
-  const messagePart = messageId.replace(/[^a-zA-Z0-9_-]/g, '_')
-  return new RecordId(TABLES.WORKSTREAM_MESSAGE, `${workstreamPart}__${messagePart}`)
+  const workstreamStr = recordIdToString(workstreamId, TABLES.WORKSTREAM)
+  const digest = createHash('sha256').update(`${workstreamStr}\0${messageId}`).digest('hex').slice(0, 32)
+  return new RecordId(TABLES.WORKSTREAM_MESSAGE, digest)
 }
 
 function toChatMessage(row: WorkstreamMessageRow): ChatMessage {
-  const rowCreatedAt = toTimestamp(row.createdAt)
+  const rowCreatedAt = toTimestamp(row.createdAt) ?? Date.now()
   const metadata = withCreatedAtMetadata(parseRowMetadata(row.metadata), rowCreatedAt)
 
   return { id: row.messageId, role: row.role, parts: (row.parts ?? []) as ChatMessage['parts'], metadata }
@@ -74,16 +83,16 @@ class WorkstreamMessageService {
   async upsertMessages(params: { workstreamId: RecordIdRef; messages: ChatMessage[] }): Promise<void> {
     const workstreamId = params.workstreamId
 
-    for (const message of params.messages) {
+    const upsertPromises = params.messages.map(async (message) => {
       const messageId = message.id.trim()
-      if (!messageId) continue
+      if (!messageId) return
 
       const role = message.role
       const parts = Array.isArray(message.parts)
         ? message.parts.map((part) => structuredClone(part) as Record<string, unknown>)
         : []
       if (parts.length === 0) {
-        if (role === 'assistant') continue
+        if (role === 'assistant') return
         throw new Error(`Refusing to persist workstream message "${messageId}" with empty parts`)
       }
       const rowId = toWorkstreamMessageRowId(workstreamId, messageId)
@@ -93,7 +102,9 @@ class WorkstreamMessageService {
         WorkstreamMessageExistingRowSchema,
       )
       const persistedCreatedAt =
-        existingRow === null ? toTimestamp(message.metadata?.createdAt) : toTimestamp(existingRow.createdAt)
+        existingRow === null
+          ? (toTimestamp(message.metadata?.createdAt) ?? Date.now())
+          : (toTimestamp(existingRow.createdAt) ?? Date.now())
       const metadata = withCreatedAtMetadata({ ...message.metadata, createdAt: persistedCreatedAt })
 
       await databaseService.upsert(
@@ -105,12 +116,15 @@ class WorkstreamMessageService {
           role,
           parts,
           metadata,
-          createdAt: existingRow ? new Date(toTimestamp(existingRow.createdAt)) : new Date(persistedCreatedAt),
+          createdAt: existingRow
+            ? new Date(toTimestamp(existingRow.createdAt) ?? Date.now())
+            : new Date(persistedCreatedAt),
         },
         WorkstreamMessageRowSchema,
         { mutation: 'content' },
       )
-    }
+    })
+    await Promise.all(upsertPromises)
   }
 
   async listMessages(workstreamId: RecordIdRef): Promise<ChatMessage[]> {
@@ -151,7 +165,7 @@ class WorkstreamMessageService {
       throw new Error(`Workstream cursor message not found: ${cursorMessageId}`)
     }
 
-    const cursorCreatedAt = new Date(toTimestamp(cursorRow.createdAt))
+    const cursorCreatedAt = new Date(toTimestamp(cursorRow.createdAt) ?? Date.now())
     const cursorId = toWorkstreamMessageRowId(workstreamId, cursorMessageId)
     const rows = await databaseService.query<unknown>(surql`
       SELECT * FROM workstreamMessage
@@ -195,7 +209,7 @@ class WorkstreamMessageService {
       .map((message) => ({
         id: message.id,
         role: message.role as 'user' | 'assistant',
-        createdAt: new Date(toTimestamp(message.metadata?.createdAt)).toISOString(),
+        createdAt: new Date(toTimestamp(message.metadata?.createdAt) ?? Date.now()).toISOString(),
         content: message.parts
           .flatMap((part) => (part.type === 'text' && typeof part.text === 'string' ? [part.text] : []))
           .join('\n')
@@ -273,10 +287,6 @@ class WorkstreamMessageService {
   async listAllMessages(workstreamId: RecordIdRef): Promise<ChatMessage[]> {
     return await this.listMessages(workstreamId)
   }
-
-  async addAttachments(): Promise<void> {
-    // Attachments are no longer persisted via workstreamMessage service in AI SDK mode.
-  }
 }
 
 export const workstreamMessageService = new WorkstreamMessageService()

package/src/services/workstream-title.service.ts

@@ -3,21 +3,13 @@ import { WORKSTREAM } from '@lota-sdk/shared'
 import { chatLogger } from '../config/logger'
 import type { RecordIdRef } from '../db/record-id'
 import { createHelperModelRuntime } from '../runtime/helper-model'
-import { deriveTitle, limitTitleWords } from '../runtime/title-helpers'
+import { deriveTitle, limitTitleWords, normalizeTitle } from '../runtime/title-helpers'
 import {
   createWorkstreamTitleGeneratorAgent,
   WORKSTREAM_TITLE_GENERATOR_PROMPT,
 } from '../system-agents/title-generator.agent'
-import { compactWhitespace } from '../utils/string'
 import { workstreamService } from './workstream.service'
 
-function normalizeTitle(value: string): string {
-  const normalized = compactWhitespace(value)
-    .replace(/^["'`]+|["'`]+$/g, '')
-    .replace(/[.!?,;:]+$/g, '')
-  return normalized.length <= 80 ? normalized : normalized.slice(0, 80).trim()
-}
-
 class WorkstreamTitleService {
   helperRuntime = createHelperModelRuntime()