@lota-sdk/core 0.1.11 → 0.1.13

package/src/services/learned-skill.service.ts

@@ -1,19 +1,28 @@
-import { recordIdStringSchema } from '@lota-sdk/shared/schemas/common'
+import { recordIdStringSchema } from '@lota-sdk/shared'
 import { BoundQuery } from 'surrealdb'
 import { z } from 'zod'
 
 import { renderLearnedSkillInstructions } from '../ai/definitions'
+import { lotaDebugLogger } from '../config/debug-logger'
 import { serverLogger } from '../config/logger'
 import { ensureRecordId } from '../db/record-id'
 import { databaseService } from '../db/service'
 import { TABLES } from '../db/tables'
 import { getDefaultEmbeddings } from '../embeddings/provider'
+import { getRedisConnection } from '../redis'
 
 const embeddings = getDefaultEmbeddings()
 
 const PROMOTION_MIN_USES = 5
 const PROMOTION_MIN_SUCCESS_RATE = 0.6
 
+const SKILL_EXISTS_TTL_SECONDS = 120
+const SKILL_EXISTS_KEY_PREFIX = 'skill-exists'
+
+function skillExistsKey(orgId: string, agentId: string): string {
+  return `${SKILL_EXISTS_KEY_PREFIX}:${orgId}:${agentId}`
+}
+
 const LearnedSkillRowSchema = z.object({
   id: recordIdStringSchema,
   name: z.string(),
@@ -51,7 +60,7 @@ const SearchResultRowSchema = z.object({
 
 type SearchResultRow = z.infer<typeof SearchResultRowSchema>
 
-export interface CreateLearnedSkillInput {
+interface CreateLearnedSkillInput {
   name: string
   description: string
   instructions: string
@@ -66,7 +75,7 @@ export interface CreateLearnedSkillInput {
   hash: string
 }
 
-export interface UpdateLearnedSkillInput {
+interface UpdateLearnedSkillInput {
   name?: string
   description?: string
   instructions?: string
@@ -80,7 +89,7 @@ export interface UpdateLearnedSkillInput {
   supersedes?: string
 }
 
-export interface RetrieveForTurnParams {
+interface RetrieveForTurnParams {
   orgId: string
   agentId: string
   query: string
@@ -107,7 +116,9 @@ class LearnedSkillService {
       hash: input.hash,
     }
 
-    return databaseService.create(TABLES.LEARNED_SKILL, data, LearnedSkillRowSchema)
+    const result = await databaseService.create(TABLES.LEARNED_SKILL, data, LearnedSkillRowSchema)
+    await this.invalidateSkillExistsCache(input.organizationId, input.agentId)
+    return result
   }
 
   async update(skillId: string, input: UpdateLearnedSkillInput): Promise<LearnedSkillRow> {
@@ -133,12 +144,16 @@ class LearnedSkillService {
 
   async archive(skillId: string): Promise<void> {
     const ref = ensureRecordId(skillId, TABLES.LEARNED_SKILL)
+    const skill = await this.getById(skillId)
     await databaseService.update(
       TABLES.LEARNED_SKILL,
       ref,
       { status: 'archived', archivedAt: new Date().toISOString(), updatedAt: new Date().toISOString() },
       LearnedSkillRowSchema,
     )
+    if (skill) {
+      await this.invalidateSkillExistsCache(String(skill.organizationId), skill.agentId ?? null)
+    }
   }
 
   async getById(skillId: string): Promise<LearnedSkillRow | null> {
@@ -149,27 +164,60 @@ class LearnedSkillService {
     )
   }
 
+  private async hasSkillsForAgent(orgId: string, agentId: string): Promise<boolean> {
+    const redis = getRedisConnection()
+    const key = skillExistsKey(orgId, agentId)
+
+    const cached = await redis.get(key)
+    if (cached !== null) return cached === '1'
+
+    const orgRef = ensureRecordId(orgId, TABLES.ORGANIZATION)
+    const rows = await databaseService.query<{ id: unknown }>(
+      new BoundQuery(
+        `SELECT id FROM ${TABLES.LEARNED_SKILL}
+         WHERE organizationId = $orgRef
+           AND status IN ['learned', 'verified', 'promoted']
+           AND archivedAt IS NONE
+           AND (agentId IS NONE OR agentId = $agentId)
+         LIMIT 1`,
+        { orgRef, agentId },
+      ),
+    )
+
+    const exists = rows.length > 0
+    await redis.set(key, exists ? '1' : '0', 'EX', SKILL_EXISTS_TTL_SECONDS)
+    return exists
+  }
+
+  private async invalidateSkillExistsCache(orgId: string, agentId: string | null): Promise<void> {
+    const redis = getRedisConnection()
+    const pattern = `${SKILL_EXISTS_KEY_PREFIX}:${orgId}:*`
+    const keys = await redis.keys(pattern)
+    if (keys.length > 0) {
+      await redis.del(...keys)
+    }
+    // Also set the specific key if we know a skill was just created
+    if (agentId) {
+      await redis.set(skillExistsKey(orgId, agentId), '1', 'EX', SKILL_EXISTS_TTL_SECONDS)
+    }
+  }
+
   async searchForTurn(params: RetrieveForTurnParams): Promise<SearchResultRow[]> {
-    const orgRef = ensureRecordId(params.orgId, TABLES.ORGANIZATION)
+    const timer = lotaDebugLogger.timer('learned-skills')
+
+    const hasSkills = await this.hasSkillsForAgent(params.orgId, params.agentId)
+    if (!hasSkills) {
+      lotaDebugLogger.step('learned-skills: skipped — no skills for org+agent')
+      return []
+    }
+    timer.step('has-skills-check')
+
     const queryEmbedding = await embeddings.embedQuery(params.query)
+    timer.step('embed-query')
     if (queryEmbedding.length === 0) return []
 
-    const candidateLimit = params.limit * 4
+    const orgRef = ensureRecordId(params.orgId, TABLES.ORGANIZATION)
     const sql = `
-      LET $candidateRows = (
-        SELECT
-          id,
-          vector::distance::knn() AS distance
-        FROM ${TABLES.LEARNED_SKILL}
-        WHERE organizationId = $organizationId
-          AND status IN ['learned', 'verified', 'promoted']
-          AND archivedAt IS NONE
-          AND confidence >= $minConfidence
-          AND (agentId IS NONE OR agentId = $agentId)
-          AND embedding <|${candidateLimit}|> $embedding
-        ORDER BY distance ASC
-      );
-
       SELECT
         type::string(id) AS id,
         name,
@@ -178,9 +226,13 @@ class LearnedSkillService {
         confidence,
         vector::similarity::cosine(embedding, $embedding) AS similarity
       FROM ${TABLES.LEARNED_SKILL}
-      WHERE id IN $candidateRows.id
+      WHERE organizationId = $organizationId
+        AND status IN ['learned', 'verified', 'promoted']
+        AND archivedAt IS NONE
+        AND confidence >= $minConfidence
+        AND (agentId IS NONE OR agentId = $agentId)
+        AND embedding <|${params.limit}|> $embedding
       ORDER BY similarity DESC
-      LIMIT $limit
     `
 
     const rows = await databaseService.query<unknown>(
@@ -189,9 +241,9 @@ class LearnedSkillService {
         embedding: queryEmbedding,
         agentId: params.agentId,
         minConfidence: params.minConfidence,
-        limit: params.limit,
       }),
     )
+    timer.step('knn-query')
 
     return rows.map((row) => SearchResultRowSchema.parse(row)).filter((row) => row.similarity >= 0.3)
   }
@@ -253,24 +305,15 @@ class LearnedSkillService {
     if (descEmbedding.length === 0) return null
 
     const sql = `
-      LET $candidateRows = (
-        SELECT
-          id,
-          vector::distance::knn() AS distance
-        FROM ${TABLES.LEARNED_SKILL}
-        WHERE organizationId = $organizationId
-          AND status IN ['learned', 'verified', 'promoted']
-          AND archivedAt IS NONE
-          AND embedding <|3|> $embedding
-        ORDER BY distance ASC
-      );
-
       SELECT *,
         type::string(id) AS id,
         type::string(organizationId) AS organizationId,
         vector::similarity::cosine(embedding, $embedding) AS similarity
       FROM ${TABLES.LEARNED_SKILL}
-      WHERE id IN $candidateRows.id
+      WHERE organizationId = $organizationId
+        AND status IN ['learned', 'verified', 'promoted']
+        AND archivedAt IS NONE
+        AND embedding <|3|> $embedding
       ORDER BY similarity DESC
       LIMIT 1
     `

package/src/services/memory.service.ts

@@ -1,7 +1,6 @@
 import { z } from 'zod'
 
 import { agentRoster } from '../config/agent-defaults'
-import { env } from '../config/env-shapes'
 import { aiLogger } from '../config/logger'
 import { Memory } from '../db/memory'
 import { isUniqueIndexConflict } from '../db/memory-store.helpers'
@@ -24,6 +23,7 @@ import {
   executeScopedRetrieval,
   scopedRetrievalToMap,
 } from '../runtime/retrieval-adapters'
+import { getRuntimeConfig } from '../runtime/runtime-config'
 import { createMemoryRerankerAgent, memoryRerankerPrompt } from '../system-agents/memory-reranker.agent'
 import { createOrgMemoryAgent, orgMemoryPrompt } from '../system-agents/memory.agent'
 import { assessMemoryImportance, clampMemoryImportance } from './memory-assessment.service'
@@ -304,7 +304,7 @@ class MemoryService {
     scopeId: string
     memoryType: MemoryType
   }): Promise<string> {
-    const limit = env.MEMORY_SEARCH_K
+    const limit = getRuntimeConfig().memory.searchK
     const candidateLimit = getCandidateLimit(limit)
 
     const candidates = await memory.searchCandidates(query, { scopeId, limit: candidateLimit, memoryType })
@@ -362,7 +362,8 @@ class MemoryService {
     aiLogger.info`[MEMORY_DEBUG] searchOrganizationMemoriesRaw - orgId: "${orgId}", scopeId: "${orgScopeId}"`
     const memory = this.getOrgMemory(orgId)
     const fastMode = options?.fastMode ?? true
-    const limit = options?.limit ?? (fastMode ? Math.min(env.MEMORY_SEARCH_K, 4) : env.MEMORY_SEARCH_K)
+    const searchK = getRuntimeConfig().memory.searchK
+    const limit = options?.limit ?? (fastMode ? Math.min(searchK, 4) : searchK)
 
     try {
       const candidates = await memory.searchCandidates(query, {
@@ -489,7 +490,7 @@ class MemoryService {
     fastMode?: boolean
     allowMultiScopeRerank?: boolean
   }): Promise<string> {
-    const limit = Math.min(env.MEMORY_SEARCH_K, MAX_MEMORY_RESULTS_PER_SCOPE)
+    const limit = Math.min(getRuntimeConfig().memory.searchK, MAX_MEMORY_RESULTS_PER_SCOPE)
     const candidateLimit = fastMode ? limit : getCandidateLimit(limit)
     const orgScopeId = scopeId(ORG_SCOPE_PREFIX, orgId)
     const orgMemory = this.getOrgMemory(orgId)

package/src/services/mutating-approval.service.ts

@@ -6,7 +6,7 @@ import { workstreamMessageService } from './workstream-message.service'
 
 const APPROVAL_VERIFICATION_MESSAGE_WINDOW = 20
 
-export type VerifyMutatingApproval = (params: {
+type VerifyMutatingApproval = (params: {
   workstreamId: string
   approvalReason: string
   approvalToken: string

package/src/services/organization-member.service.ts

@@ -1,4 +1,4 @@
-import { recordIdStringSchema } from '@lota-sdk/shared/schemas/common'
+import { recordIdStringSchema } from '@lota-sdk/shared'
 import { z } from 'zod'
 
 import { BaseService } from '../db/base.service'

package/src/services/organization.service.ts

@@ -1,4 +1,4 @@
-import { recordIdStringSchema } from '@lota-sdk/shared/schemas/common'
+import { recordIdStringSchema } from '@lota-sdk/shared'
 import { z } from 'zod'
 
 import { BaseService } from '../db/base.service'

package/src/services/plan-approval.service.ts

@@ -1,5 +1,5 @@
-import { PlanApprovalSchema } from '@lota-sdk/shared/schemas/execution-plan'
-import type { PlanApprovalRecord, PlanApprovalStatus } from '@lota-sdk/shared/schemas/execution-plan'
+import { PlanApprovalSchema } from '@lota-sdk/shared'
+import type { PlanApprovalRecord, PlanApprovalStatus } from '@lota-sdk/shared'
 import { RecordId } from 'surrealdb'
 
 import type { RecordIdInput } from '../db/record-id'

package/src/services/plan-artifact.service.ts

@@ -1,6 +1,5 @@
-import { PlanArtifactSchema } from '@lota-sdk/shared/schemas/execution-plan'
-import type { PlanArtifactRecord } from '@lota-sdk/shared/schemas/execution-plan'
-import type { PlanArtifactSubmission } from '@lota-sdk/shared/schemas/tools'
+import { PlanArtifactSchema } from '@lota-sdk/shared'
+import type { PlanArtifactRecord, PlanArtifactSubmission } from '@lota-sdk/shared'
 import { RecordId } from 'surrealdb'
 
 import type { RecordIdInput } from '../db/record-id'

package/src/services/plan-builder.service.ts

@@ -1,4 +1,4 @@
-import type { PlanDraft } from '@lota-sdk/shared/schemas/execution-plan'
+import type { PlanDraft } from '@lota-sdk/shared'
 
 function buildImplicitLinearEdges(draft: PlanDraft) {
   if (draft.edges.length > 0 || draft.nodes.length <= 1) {

package/src/services/plan-checkpoint.service.ts

@@ -1,5 +1,5 @@
-import { PlanCheckpointSchema } from '@lota-sdk/shared/schemas/execution-plan'
-import type { PlanCheckpointRecord, PlanRunStatus } from '@lota-sdk/shared/schemas/execution-plan'
+import { PlanCheckpointSchema } from '@lota-sdk/shared'
+import type { PlanCheckpointRecord, PlanRunStatus } from '@lota-sdk/shared'
 import { RecordId } from 'surrealdb'
 
 import type { RecordIdInput } from '../db/record-id'

package/src/services/plan-compiler.service.ts

@@ -1,4 +1,4 @@
-import type { PlanDraft, PlanNodeSpec, PlanNodeSpecRecord } from '@lota-sdk/shared/schemas/execution-plan'
+import type { PlanDraft, PlanNodeSpec, PlanNodeSpecRecord } from '@lota-sdk/shared'
 
 import { planValidatorService } from './plan-validator.service'
 
@@ -9,7 +9,7 @@ export interface CompiledPlanNode {
   downstreamNodeIds: string[]
 }
 
-export interface CompiledPlanDraft {
+interface CompiledPlanDraft {
   draft: PlanDraft
   nodes: CompiledPlanNode[]
 }

package/src/services/plan-executor.service.ts

@@ -1,23 +1,24 @@
-import {
-  PlanEventSchema,
-  PlanNodeAttemptSchema,
-  PlanNodeRunSchema,
-  PlanRunSchema,
-  PlanValidationIssueSchema,
-} from '@lota-sdk/shared/schemas/execution-plan'
 import type {
+  ExecutionPlanToolResultData,
   PlanEventRecord,
   PlanEventType,
   PlanFailureAction,
   PlanFailureClass,
+  PlanNodeResultSubmission,
   PlanNodeRunRecord,
   PlanNodeSpecRecord,
   PlanRunRecord,
   PlanSpecRecord,
   PlanValidationIssueRecord,
   SerializableExecutionPlan,
-} from '@lota-sdk/shared/schemas/execution-plan'
-import type { ExecutionPlanToolResultData, PlanNodeResultSubmission } from '@lota-sdk/shared/schemas/tools'
+} from '@lota-sdk/shared'
+import {
+  PlanEventSchema,
+  PlanNodeAttemptSchema,
+  PlanNodeRunSchema,
+  PlanRunSchema,
+  PlanValidationIssueSchema,
+} from '@lota-sdk/shared'
 import { RecordId } from 'surrealdb'
 
 import type { RecordIdInput } from '../db/record-id'

package/src/services/plan-run.service.ts

@@ -9,7 +9,7 @@ import {
   PlanRunSchema,
   PlanSpecSchema,
   PlanValidationIssueSchema,
-} from '@lota-sdk/shared/schemas/execution-plan'
+} from '@lota-sdk/shared'
 import type {
   PlanApprovalRecord,
   PlanArtifactRecord,
@@ -29,7 +29,7 @@ import type {
   SerializablePlanEvent,
   SerializablePlanNode,
   SerializablePlanValidationIssue,
-} from '@lota-sdk/shared/schemas/execution-plan'
+} from '@lota-sdk/shared'
 
 import type { RecordIdInput } from '../db/record-id'
 import { ensureRecordId, recordIdToString } from '../db/record-id'

package/src/services/plan-validator.service.ts

@@ -3,10 +3,10 @@ import type {
   PlanDataSchema,
   PlanDraft,
   PlanFailureClass,
+  PlanNodeResultSubmission,
   PlanNodeSpec,
   PlanValidationIssueSeverity,
-} from '@lota-sdk/shared/schemas/execution-plan'
-import type { PlanNodeResultSubmission } from '@lota-sdk/shared/schemas/tools'
+} from '@lota-sdk/shared'
 
 const STRUCTURAL_NODE_TYPES = new Set(['switch', 'join'])
 const HUMAN_NODE_TYPES = new Set(['human-input', 'human-approval', 'human-review-edit', 'human-decision'])
@@ -19,12 +19,12 @@ export interface PlanValidationIssueInput {
   nodeId?: string
 }
 
-export interface DraftValidationResult {
+interface DraftValidationResult {
   blocking: PlanValidationIssueInput[]
   warnings: PlanValidationIssueInput[]
 }
 
-export interface NodeResultValidationResult {
+interface NodeResultValidationResult {
   blocking: PlanValidationIssueInput[]
   warnings: PlanValidationIssueInput[]
   failureClass: PlanFailureClass | null

package/src/services/recent-activity-title.service.ts

@@ -58,7 +58,7 @@ class RecentActivityTitleService {
       }),
     )
     if (
-      !recentActivityService.isChiefTitleUseful({
+      !recentActivityService.isAgentTitleUseful({
         currentTitle: candidate.title,
         systemTitle: candidate.systemTitle,
         candidateTitle: refinedTitle,

package/src/services/recent-activity.service.ts

@@ -8,13 +8,13 @@ import {
   RecentActivitySchema,
   RecentActivitySourceSchema,
   RecentActivityTitleSourceSchema,
-} from '@lota-sdk/shared/schemas/recent-activity'
+} from '@lota-sdk/shared'
 import type {
   RecentActivity,
   RecentActivityEvent,
   RecentActivityEventInput,
   RecentActivitySource,
-} from '@lota-sdk/shared/schemas/recent-activity'
+} from '@lota-sdk/shared'
 import { RecordId } from 'surrealdb'
 import { z } from 'zod'
 
@@ -83,18 +83,16 @@ function buildDeterministicRecordId(table: string, key: string): RecordId {
   return new RecordId(table, digest)
 }
 
-function shouldKeepExistingChiefTitle(existing: RecentActivityRow | null): boolean {
-  return existing?.titleSource === 'chief' && compactWhitespace(existing.title).length > 0
+function shouldKeepExistingAgentTitle(existing: RecentActivityRow | null): boolean {
+  return existing?.titleSource === 'agent' && compactWhitespace(existing.title).length > 0
 }
 
 function buildRecentActivityAreaKey(
-  row: Pick<RecentActivityRow, 'deepLink' | 'kind' | 'mergeKey' | 'metadata'>,
+  row: Pick<RecentActivityRow, 'targetKind' | 'targetId' | 'kind' | 'mergeKey' | 'metadata'>,
 ): string {
-  const target = row.deepLink.search
-
-  if (target.docId) return `document:${target.docId}`
-  if (target.chat) return `workstream:${target.chat}`
-  if (target.agent) return `agent:${target.agent}`
+  if (row.targetId) {
+    return `${row.targetKind}:${row.targetId}`
+  }
 
   const normalizedWebsiteUrl = row.metadata?.normalizedWebsiteUrl
   if (row.kind === 'website-intelligence.viewed' && normalizedWebsiteUrl) {
@@ -230,8 +228,8 @@ class RecentActivityService {
       { mutation: 'merge' },
     )
 
-    const keepExistingChiefTitle = shouldKeepExistingChiefTitle(existingRecent)
-    const visibleTitle = keepExistingChiefTitle && existingRecent ? existingRecent.title : parsedEvent.title
+    const keepExistingAgentTitle = shouldKeepExistingAgentTitle(existingRecent)
+    const visibleTitle = keepExistingAgentTitle && existingRecent ? existingRecent.title : parsedEvent.title
     const recentRow = await databaseService.upsert(
       TABLES.RECENT_ACTIVITY,
       recentRecordId,
@@ -244,7 +242,7 @@ class RecentActivityService {
         targetId: parsedEvent.targetId,
         title: visibleTitle,
         systemTitle: parsedEvent.title,
-        titleSource: keepExistingChiefTitle ? 'chief' : 'system',
+        titleSource: keepExistingAgentTitle ? 'agent' : 'system',
         sourceLabel: parsedEvent.sourceLabel,
         deepLink: parsedEvent.deepLink,
         metadata: parsedEvent.metadata,
@@ -326,7 +324,7 @@ class RecentActivityService {
     const updated = await databaseService.update(
       TABLES.RECENT_ACTIVITY,
       activityRef,
-      { title: nextTitle, titleSource: 'chief', titleRefinedAt: new Date() },
+      { title: nextTitle, titleSource: 'agent', titleRefinedAt: new Date() },
       RecentActivityRowSchema,
       { mutation: 'merge' },
     )
@@ -365,7 +363,7 @@ class RecentActivityService {
     return activity.titleSource === 'system'
   }
 
-  isChiefTitleUseful(params: { currentTitle: string; systemTitle: string; candidateTitle: string }): boolean {
+  isAgentTitleUseful(params: { currentTitle: string; systemTitle: string; candidateTitle: string }): boolean {
     const candidate = compactWhitespace(params.candidateTitle)
     if (!candidate) return false
 
@@ -385,7 +383,7 @@ class RecentActivityService {
       'follow up',
       'conversation',
       'chat',
-      'chief task',
+      'agent task',
       'recent activity',
       'workstream update',
     ])

package/src/services/user.service.ts

@@ -1,5 +1,5 @@
-import type { SdkUser, SdkUserRecord } from '@lota-sdk/shared/schemas/user'
-import { sdkUserRecordSchema, sdkUserSchema } from '@lota-sdk/shared/schemas/user'
+import type { SdkUser, SdkUserRecord } from '@lota-sdk/shared'
+import { sdkUserRecordSchema, sdkUserSchema } from '@lota-sdk/shared'
 
 import { BaseService } from '../db/base.service'
 import { ensureRecordId, recordIdToString } from '../db/record-id'

package/src/services/workstream-message.service.ts

@@ -1,6 +1,5 @@
-import { toTimestamp, withCreatedAtMetadata } from '@lota-sdk/shared/runtime/chat-message-metadata'
-import { parseRowMetadata } from '@lota-sdk/shared/schemas/chat-message'
-import type { ChatMessage } from '@lota-sdk/shared/schemas/chat-message'
+import { parseRowMetadata, toTimestamp, withCreatedAtMetadata } from '@lota-sdk/shared'
+import type { ChatMessage } from '@lota-sdk/shared'
 import { RecordId, surql } from 'surrealdb'
 import { z } from 'zod'
 

package/src/services/workstream-title.service.ts

@@ -1,4 +1,4 @@
-import { WORKSTREAM } from '@lota-sdk/shared/constants/workstream'
+import { WORKSTREAM } from '@lota-sdk/shared'
 
 import { chatLogger } from '../config/logger'
 import type { RecordIdRef } from '../db/record-id'