@loopress/cli 0.32.2 → 0.33.0

package/dist/commands/plugin/audit.js

@@ -1,5 +1,6 @@
 import got from 'got';
 import { LoopressCommand } from '../../lib/base.js';
+import { errorMessage, isRecord } from '../../lib/narrow.js';
 import { withSpinner } from '../../lib/spinner.js';
 import { pinVersion } from '../../types/plugin.js';
 import { compareVersions } from '../../utils/version.js';
@@ -19,8 +20,8 @@ export default class Audit extends LoopressCommand {
         }
         const advisories = [];
         const health = [];
-        for (const slug of slugs) {
-            const found = await withSpinner(`Auditing ${slug}`, async () => this.auditOne(slug, pinVersion(manifest[slug])));
+        for (const [slug, pin] of Object.entries(manifest)) {
+            const found = await withSpinner(`Auditing ${slug}`, async () => this.auditOne(slug, pinVersion(pin)));
             advisories.push(...found.advisories);
             health.push(...found.health);
         }
@@ -59,11 +60,17 @@ export default class Audit extends LoopressCommand {
         catch (error) {
             // Never swallow this into an empty list: a clean audit must mean "no advisories found",
             // not "the advisory service was unreachable". Fail the command instead.
-            throw new Error(`Could not reach the vulnerability database (wpvulnerability.net) for "${slug}": ${error.message}. ` +
+            throw new Error(`Could not reach the vulnerability database (wpvulnerability.net) for "${slug}": ${errorMessage(error)}. ` +
                 'Audit aborted so a service outage is not reported as a clean result.', { cause: error });
         }
-        const list = Array.isArray(body?.data?.vulnerability) ? body.data.vulnerability : [];
-        return list.map((raw) => normalizeAdvisory(raw));
+        // A 200 with the wrong shape (degraded service) must not read as "no advisories" either.
+        const list = body?.data?.vulnerability;
+        if (!Array.isArray(list) || list.some((raw) => !isRecord(raw))) {
+            throw new TypeError(`Unexpected answer from the vulnerability database (wpvulnerability.net) for "${slug}". ` +
+                'Audit aborted so a malformed response is not reported as a clean result.');
+        }
+        // Already all objects (checked above), the filter only carries that to the type.
+        return list.filter((raw) => isRecord(raw)).map((raw) => normalizeAdvisory(raw));
     }
     report(advisories, health, count) {
         if (advisories.length === 0 && health.length === 0) {
@@ -93,26 +100,28 @@ function advisoryMeta(a) {
     return parts.length > 0 ? ` (${parts.join(', ')})` : '';
 }
 function normalizeAdvisory(raw) {
-    const cvss = (raw.cvss ?? {});
-    const source = Array.isArray(raw.source) ? raw.source : [];
-    const cve = typeof raw.cve === 'string' ? raw.cve : source.find((s) => s.id?.startsWith('CVE-'))?.id;
+    const cvss = isRecord(raw.cvss) ? raw.cvss : {};
+    const sourceIds = Array.isArray(raw.source) ? raw.source.map((s) => (isRecord(s) && typeof s.id === 'string' ? s.id : '')) : [];
+    const cve = typeof raw.cve === 'string' ? raw.cve : sourceIds.find((id) => id.startsWith('CVE-'));
     const range = extractRange(raw);
     return {
         cve,
         fixedIn: range.max?.op === 'lt' ? range.max.version : undefined,
         range,
-        score: cvss.score,
-        severity: cvss.severity,
+        score: typeof cvss.score === 'number' ? cvss.score : undefined,
+        severity: typeof cvss.severity === 'string' ? cvss.severity : undefined,
         title: typeof raw.name === 'string' ? decodeEntities(raw.name) : 'Unnamed advisory',
     };
 }
 // wpvulnerability's `operator`: `max_version` with `max_operator` "lt" (fixed in that version),
 // "le" (affected up to it, no fix yet) or "eq" (that version only), and an optional lower bound `min_version` with
 // `min_operator` "gt" or "ge". No upper bound means every version from the lower one on.
+function toBound(version, operator) {
+    return typeof version === 'string' && version !== '' && typeof operator === 'string' ? { op: operator, version } : undefined;
+}
 function extractRange(raw) {
-    const op = (raw.operator ?? {});
-    const bound = (version, operator) => typeof version === 'string' && version !== '' && typeof operator === 'string' ? { op: operator, version } : undefined;
-    return { max: bound(op.max_version, op.max_operator), min: bound(op.min_version, op.min_operator) };
+    const op = isRecord(raw.operator) ? raw.operator : {};
+    return { max: toBound(op.max_version, op.max_operator), min: toBound(op.min_version, op.min_operator) };
 }
 // A bound we can't evaluate (odd version strings, unknown operator) counts as affected: a false
 // positive is safer than hiding an advisory.
@@ -121,7 +130,8 @@ function affects(version, range) {
         if (!bound)
             return true;
         const order = compareVersions(version, bound.version);
-        return order === null || !Object.hasOwn(ok, bound.op) || ok[bound.op](order);
+        const check = Object.hasOwn(ok, bound.op) ? ok[bound.op] : undefined;
+        return order === null || !check || check(order);
     };
     return (within(range.min, { ge: (o) => o >= 0, gt: (o) => o > 0 }) && within(range.max, { eq: (o) => o === 0, le: (o) => o <= 0, lt: (o) => o < 0 }));
 }
@@ -147,9 +157,19 @@ function describeHealth(slug, pinned, info) {
     }
     const lastUpdated = typeof info.last_updated === 'string' ? info.last_updated : null;
     if (lastUpdated) {
-        const years = (Date.now() - Date.parse(lastUpdated)) / (365 * 24 * 3600 * 1000);
+        const years = (Date.now() - parseWordPressDate(lastUpdated)) / (365 * 24 * 3600 * 1000);
         if (years > 2)
             notes.push({ message: `last updated ${lastUpdated.slice(0, 10)} (possibly abandoned)`, slug });
     }
     return notes;
 }
+// WordPress.org's plugins API returns `last_updated` as "2015-03-04 10:00am GMT", which
+// Date.parse() reads as NaN. Rewrite that form to ISO, and leave anything else to Date.parse().
+function parseWordPressDate(value) {
+    const match = /^(\d{4}-\d{2}-\d{2}) (\d{1,2}):(\d{2})(am|pm) GMT$/i.exec(value);
+    if (!match)
+        return Date.parse(value);
+    const [, day, hour, minute, half] = match;
+    const hours = (Number(hour) % 12) + (half?.toLowerCase() === 'pm' ? 12 : 0);
+    return Date.parse(`${day}T${String(hours).padStart(2, '0')}:${minute}:00Z`);
+}

package/dist/commands/plugin/pull.js

@@ -5,7 +5,8 @@ import { readFile } from 'node:fs/promises';
 import { join } from 'node:path';
 import { LoopressCommand } from '../../lib/base.js';
 import { isInteractive } from '../../lib/interactive.js';
-import { getComposerManagedSlugs, NOT_ON_WORDPRESS_ORG, pullIntoComposerJson, } from '../../utils/composer.js';
+import {} from '../../types/plugin.js';
+import { getComposerManagedSlugs, NOT_ON_WORDPRESS_ORG, parseComposerJson, pullIntoComposerJson, } from '../../utils/composer.js';
 import { writeLocalConfig } from '../../utils/loopress-config.js';
 import { mergePluginManifest, parseInstalledPlugins } from '../../utils/plugins.js';
 export default class Pull extends LoopressCommand {
@@ -29,7 +30,7 @@ export default class Pull extends LoopressCommand {
         const raw = await this.wp.get('wp/v2/plugins');
         const composerJsonPath = join(process.cwd(), this.rootDir, 'composer.json');
         const composerJson = existsSync(composerJsonPath)
-            ? JSON.parse(await readFile(composerJsonPath, 'utf8'))
+            ? parseComposerJson(await readFile(composerJsonPath, 'utf8'))
             : undefined;
         const declared = new Set(composerJson ? getComposerManagedSlugs(composerJson) : Object.keys(this.localConfig.plugins ?? {}));
         const all = parseInstalledPlugins(raw);

package/dist/commands/plugin/push.js

@@ -6,7 +6,7 @@ import { confirmUninstall } from '../../lib/interactive.js';
 import { PushCommand } from '../../lib/push-command.js';
 import { isLocalEnvironment, isNotFoundError } from '../../lib/wp-client.js';
 import { pinActive, pinVersion, pinVersions, } from '../../types/plugin.js';
-import { requireToInstall, toIntent, wpackagistRequire } from '../../utils/composer.js';
+import { parseComposerJson, requireToInstall, toIntent, wpackagistRequire } from '../../utils/composer.js';
 import { isDowngrade, parseCollisions, SYNC_TIMEOUT_MS, } from '../../utils/plugin-sync.js';
 import { diffPlugins, lockedWpackagistSlugs, parseInstalledPlugins } from '../../utils/plugins.js';
 import { isExactVersion } from '../../utils/version.js';
@@ -177,7 +177,7 @@ export default class Push extends PushCommand {
     async loadSource(activate) {
         const composerJsonPath = join(process.cwd(), this.rootDir, 'composer.json');
         if (existsSync(composerJsonPath)) {
-            const composerJson = JSON.parse(await readFile(composerJsonPath, 'utf8'));
+            const composerJson = parseComposerJson(await readFile(composerJsonPath, 'utf8'));
             const includeDev = isLocalEnvironment(this.siteConfig.name);
             const manifest = wpackagistRequire(composerJson, 'plugin', includeDev);
             if (Object.keys(manifest).length === 0) {

package/dist/commands/plugin/status.js

@@ -2,6 +2,7 @@ import { existsSync } from 'node:fs';
 import { join } from 'node:path';
 import { LoopressCommand } from '../../lib/base.js';
 import { isNotFoundError } from '../../lib/wp-client.js';
+import {} from '../../types/plugin.js';
 import { diffPlugins, lockedWpackagistSlugs, parseInstalledPlugins } from '../../utils/plugins.js';
 export default class Status extends LoopressCommand {
     static description = 'Compare the plugins on WordPress against loopress.json and report drift (missing, wrong version, inactive, untracked)';
@@ -64,7 +65,8 @@ export default class Status extends LoopressCommand {
             drift,
             inactive,
             missing,
-            status: drift ? 'drift' : 'in-sync',
+            // Drift exits with code 1 above, so only the untracked-active report gets here.
+            status: 'in-sync',
             unexpectedlyActive,
             untrackedActive,
             wrongVersion,

package/dist/commands/project/config.js

@@ -3,12 +3,14 @@ import { Command } from '@oclif/core';
 import { configManager } from '../../config/project-config.manager.js';
 import { bootstrapLoopressFull } from '../../lib/bootstrap-full-install.js';
 import { isInteractive } from '../../lib/interactive.js';
+import { errorMessage } from '../../lib/narrow.js';
 import { isLoopressFullActive } from '../../lib/plugin-detection.js';
 import { withSpinner } from '../../lib/spinner.js';
 import { sweepTempAdmins } from '../../lib/temp-admin.js';
 import { authorizeWithBrowser } from '../../lib/wp-authorize-flow.js';
 import { isLocalEnvironment, WpClient } from '../../lib/wp-client.js';
 import { diagnoseWpSite } from '../../lib/wp-site-diagnostic.js';
+import {} from '../../types/config.js';
 import { pluralize } from '../../utils/pluralize.js';
 const NEW_PROJECT = '__new__';
 const AUTH_BROWSER = 'browser';
@@ -121,7 +123,7 @@ export default class Config extends Command {
             }));
         }
         catch (error) {
-            this.warn(error.message);
+            this.warn(errorMessage(error));
         }
     }
     async promptManualCredentials() {
@@ -157,7 +159,7 @@ export default class Config extends Command {
             return { appPassword: password, user: userLogin };
         }
         catch (error) {
-            this.warn(`${error.message}\nFalling back to manual credential entry.`);
+            this.warn(`${errorMessage(error)}\nFalling back to manual credential entry.`);
             return this.promptManualCredentials();
         }
     }
@@ -171,10 +173,9 @@ export default class Config extends Command {
                 ],
                 message: 'Project',
             });
-            if (choice !== NEW_PROJECT) {
-                const project = projects.find((p) => p.id === choice);
+            const project = projects.find((p) => p.id === choice);
+            if (project)
                 return { projectId: project.id, projectName: project.name };
-            }
         }
         const existingNames = new Set(projects.map((project) => project.name.trim().toLowerCase()));
         const projectName = await input({
@@ -197,7 +198,7 @@ export default class Config extends Command {
                 this.log(`✓ Removed ${pluralize(removed.length, 'leftover temporary admin account')}: ${removed.join(', ')}`);
         }
         catch (error) {
-            this.warn(error.message);
+            this.warn(errorMessage(error));
         }
     }
 }

package/dist/commands/project/pull.js

@@ -3,7 +3,9 @@ import { Listr } from 'listr2';
 import { authManager } from '../../config/auth.manager.js';
 import { configManager } from '../../config/project-config.manager.js';
 import { ApiClient } from '../../lib/api-client.js';
+import { errorMessage } from '../../lib/narrow.js';
 import { withoutSpinner } from '../../lib/spinner.js';
+import {} from '../../types/config.js';
 import { pluralize } from '../../utils/pluralize.js';
 export default class Pull extends Command {
     static description = 'Pull projects and environments from your Loopress account that are not configured locally yet';
@@ -42,7 +44,7 @@ export default class Pull extends Command {
             return await api.get('projects');
         }
         catch (error) {
-            this.error(`Could not fetch projects from the API: ${error.message}`);
+            this.error(`Could not fetch projects from the API: ${errorMessage(error)}`);
         }
     }
     // Reuse a local project already linked to this API project instead of always minting a new

package/dist/commands/project/push.js

@@ -6,7 +6,9 @@ import { configManager } from '../../config/project-config.manager.js';
 import { ApiClient } from '../../lib/api-client.js';
 import { LoopressCommand } from '../../lib/base.js';
 import { isInteractive } from '../../lib/interactive.js';
+import { errorMessage } from '../../lib/narrow.js';
 import { withoutSpinner } from '../../lib/spinner.js';
+import {} from '../../types/config.js';
 import { pluralize } from '../../utils/pluralize.js';
 import { toSlug } from '../../utils/to-slug.js';
 export default class Push extends Command {
@@ -57,7 +59,7 @@ export default class Push extends Command {
                 task.output = envPlan.action === 'create' ? 'Created on the API' : 'Linked to the API';
         }
         catch (error) {
-            const message = `Failed to push "${envPlan.env.name}": ${error.message}`;
+            const message = `Failed to push "${envPlan.env.name}": ${errorMessage(error)}`;
             if (task)
                 task.output = message;
             throw error;
@@ -94,7 +96,7 @@ export default class Push extends Command {
                 task.output = plan.action === 'create' ? 'Created on the API' : 'Linked to the API';
         }
         catch (error) {
-            const message = `Failed to push project "${plan.project.name}": ${error.message}`;
+            const message = `Failed to push project "${plan.project.name}": ${errorMessage(error)}`;
             if (task)
                 task.output = message;
             throw error;
@@ -138,7 +140,7 @@ export default class Push extends Command {
             return await api.get('projects');
         }
         catch (error) {
-            this.warn(`Could not fetch existing projects from the API, will create everything as new: ${error.message}`);
+            this.warn(`Could not fetch existing projects from the API, will create everything as new: ${errorMessage(error)}`);
             return [];
         }
     }
@@ -203,7 +205,7 @@ export default class Push extends Command {
                     await this.pushCredentials(api, plan.apiProjectId, envPlan.apiEnvironmentId, envPlan.env);
                 }
                 catch (error) {
-                    this.warn(`Failed to push "${plan.project.name}/${envPlan.env.name}": ${error.message}`);
+                    this.warn(`Failed to push "${plan.project.name}/${envPlan.env.name}": ${errorMessage(error)}`);
                 }
             }
         }

package/dist/commands/project/{remove.d.ts → rm.d.ts}

@@ -1,5 +1,6 @@
 import { Command } from '@oclif/core';
 export default class Remove extends Command {
+    static aliases: string[];
     static description: string;
     static examples: string[];
     run(): Promise<void>;

package/dist/commands/project/{remove.js → rm.js}

@@ -2,8 +2,9 @@ import { checkbox } from '@inquirer/prompts';
 import { Command } from '@oclif/core';
 import { configManager } from '../../config/project-config.manager.js';
 export default class Remove extends Command {
+    static aliases = ['project:remove'];
     static description = 'Remove one or more WordPress projects or environments';
-    static examples = ['$ lps project remove'];
+    static examples = ['$ lps project rm'];
     async run() {
         await this.parse(Remove);
         const projects = configManager.listProjects();
@@ -38,7 +39,7 @@ export default class Remove extends Command {
             this.log('Nothing removed.');
             return;
         }
-        const selected = chosen.map((index) => targets[Number(index)]);
+        const selected = chosen.flatMap((index) => targets[Number(index)] ?? []);
         const projectsToRemove = new Map(selected.filter((target) => target.kind === 'project').map((target) => [target.projectId, target.projectName]));
         const envsToRemove = selected.filter((target) => target.kind === 'env' && !projectsToRemove.has(target.projectId));
         for (const projectId of projectsToRemove.keys())

package/dist/commands/project/switch.js

@@ -10,18 +10,20 @@ export default class Switch extends Command {
         if (projects.length === 0) {
             this.error('No projects configured. Run `lps project config` first.');
         }
-        const projectId = projects.length === 1
-            ? projects[0].id
+        const [only] = projects;
+        const currentId = projects.find((project) => project.isCurrent)?.id;
+        const projectId = only && projects.length === 1
+            ? only.id
             : await select({
                 choices: projects.map((project) => ({
                     name: `${project.name}${project.isCurrent ? ' [current]' : ''}`,
                     value: project.id,
                 })),
-                default: projects.find((project) => project.isCurrent)?.id,
+                ...(currentId !== undefined && { default: currentId }),
                 message: 'Select project',
             });
         configManager.setCurrent(projectId);
         const project = projects.find((candidate) => candidate.id === projectId);
-        this.log(`✓ Switched to "${project.name}"`);
+        this.log(`✓ Switched to "${project?.name ?? projectId}"`);
     }
 }

package/dist/commands/promote.js

@@ -8,7 +8,9 @@ import { configManager } from '../config/project-config.manager.js';
 import { LoopressCommand } from '../lib/base.js';
 import { isInteractive } from '../lib/interactive.js';
 import { stdoutToStderr } from '../lib/json-delegation.js';
+import { errorMessage } from '../lib/narrow.js';
 import { PushCommand } from '../lib/push-command.js';
+import {} from '../types/config.js';
 import { readLocalConfig } from '../utils/loopress-config.js';
 import { resolveResourceDir, RESOURCE_DIR_DEFAULTS } from '../utils/resource-dirs.js';
 export default class Promote extends Command {
@@ -56,7 +58,7 @@ export default class Promote extends Command {
                 // A partial pull must never be pushed onward: stop before touching <to>.
                 // "untouched" is only true of <to>: a real (non dry-run) pull has already rewritten the files.
                 const filesNote = dryRun ? '' : ` Your local files may already hold part of ${from.name}, review them before pushing.`;
-                this.error(`Pull from ${from.name} failed, nothing was pushed to ${to.name}.${filesNote} ${error.message}`);
+                this.error(`Pull from ${from.name} failed, nothing was pushed to ${to.name}.${filesNote} ${errorMessage(error)}`);
             }
             this.log(`\n=== Pushing to ${to.name} (${to.url}) ===`);
             await stdoutToStderr(this.jsonEnabled(), async () => this.config.runCommand('push', [...this.delegateArgv(to.name, dryRun), ...(overwrite ? ['--overwrite'] : [])]));
@@ -78,7 +80,10 @@ export default class Promote extends Command {
     // resource dir would land outside the copy, in the user's real files, during a dry run.
     async assertDirsInsideProject(projectDir) {
         const localConfig = await readLocalConfig();
-        const dirs = [localConfig.rootDir ?? '.', ...Object.keys(RESOURCE_DIR_DEFAULTS).map((kind) => resolveResourceDir(kind, localConfig))];
+        // Object.keys() is typed string[] even on an `as const` object: these are its own keys.
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- see above
+        const kinds = Object.keys(RESOURCE_DIR_DEFAULTS);
+        const dirs = [localConfig.rootDir ?? '.', ...kinds.map((kind) => resolveResourceDir(kind, localConfig))];
         const outside = dirs.find((dir) => {
             const rel = relative(projectDir, resolve(projectDir, dir));
             return rel.startsWith('..') || isAbsolute(rel);

package/dist/commands/pull.d.ts

@@ -19,5 +19,7 @@ export default class Pull extends LoopressCommand {
     run(): Promise<PullResult>;
     private buildArgv;
     private globalStylesSkipNote;
+    private projectUses;
+    private unavailable;
 }
 export {};

package/dist/commands/pull.js

@@ -1,6 +1,7 @@
 import { LoopressCommand } from '../lib/base.js';
+import { missingIntegration, missingModule } from '../lib/capabilities.js';
 import { stdoutToStderr } from '../lib/json-delegation.js';
-import { INTEGRATION_MISSING } from '../lib/plugin-detection.js';
+import { errorMessage } from '../lib/narrow.js';
 import { pluralize } from '../utils/pluralize.js';
 import { projectUses, resolveResourceDir } from '../utils/resource-dirs.js';
 import { globalStylesSkipNote } from '../utils/theme-styles-format.js';
@@ -15,10 +16,11 @@ const PULL_TARGETS = [
     { commandId: 'meta:pull', label: 'post meta', supportsYes: true },
     { commandId: 'role:pull', label: 'roles', supportsYes: true },
     { commandId: 'acf:pull', label: 'ACF', needsPlugin: 'acf', supportsYes: true },
-    { commandId: 'api:pull', label: 'API routes', supportsYes: true },
-    { commandId: 'hook:pull', label: 'hooks', supportsYes: true },
+    { commandId: 'api:pull', label: 'API routes', needsPlugin: 'api', supportsYes: true },
+    { commandId: 'hook:pull', label: 'hooks', needsPlugin: 'hooks', supportsYes: true },
+    { commandId: 'block:pull', label: 'dynamic blocks', needsPlugin: 'block', supportsYes: true },
     { commandId: 'form:pull', label: 'forms', needsPlugin: 'form', supportsYes: true },
-    { commandId: 'pattern:pull', label: 'patterns', supportsYes: true },
+    { commandId: 'pattern:pull', label: 'patterns', needsPlugin: 'pattern', supportsYes: true },
     // Templates and parts have no pull. Global Styles are pulled only once the project tracks them,
     // see globalStylesSkipNote.
     { commandId: 'theme:style:pull', label: 'Global Styles' },
@@ -26,8 +28,15 @@ const PULL_TARGETS = [
     { commandId: 'option:pull', label: 'options', supportsYes: true },
     { commandId: 'snippet:pull', label: 'snippets', needsPlugin: 'snippets', supportsYes: true },
 ];
+// Why this site can't give the target. Composer has no directory to tell whether the project
+// uses it: never pulled from Light, which has nothing to give.
+function missingFor(target, capabilities) {
+    if (target.commandId === 'composer:pull')
+        return missingModule('dependencies', 'Composer files', capabilities);
+    return target.needsPlugin === undefined ? undefined : missingIntegration(target.needsPlugin, capabilities);
+}
 export default class Pull extends LoopressCommand {
-    static description = 'Pull every tracked resource from WordPress into local files in one run: composer dependencies, plugins, post types, taxonomies, post meta, roles, ACF, API routes, hooks, forms, patterns, Global Styles, menus, options, and snippets';
+    static description = 'Pull every tracked resource from WordPress into local files in one run: composer dependencies, plugins, post types, taxonomies, post meta, roles, ACF, API routes, hooks, dynamic blocks, forms, patterns, Global Styles, menus, options, and snippets';
     static enableJsonFlag = true;
     static examples = ['$ lps pull', '$ lps pull --env staging', '$ lps pull --dry-run'];
     static flags = {
@@ -37,7 +46,7 @@ export default class Pull extends LoopressCommand {
     failedCount = 0;
     async run() {
         const results = [];
-        this.warnRemovedSeoModule();
+        const capabilities = await this.capabilities();
         for (const target of PULL_TARGETS) {
             const skipNote = target.commandId === 'theme:style:pull' ? await this.globalStylesSkipNote() : undefined;
             if (skipNote) {
@@ -45,6 +54,11 @@ export default class Pull extends LoopressCommand {
                 results.push({ label: target.label, status: 'skipped' });
                 continue;
             }
+            const unavailable = this.unavailable(target, capabilities);
+            if (unavailable) {
+                results.push(unavailable);
+                continue;
+            }
             this.log(`\n→ Pulling ${target.label}...`);
             try {
                 await stdoutToStderr(this.jsonEnabled(), async () => this.config.runCommand(target.commandId, this.buildArgv(target)));
@@ -52,18 +66,7 @@ export default class Pull extends LoopressCommand {
                 results.push({ label: target.label, status: 'pulled' });
             }
             catch (error) {
-                const { message } = error;
-                // A site without ACF (or a form or snippet plugin) is the common case, not a failure,
-                // as long as the project doesn't use that resource: a vanilla site must pull, and a
-                // promote must not stop on it. A project that does use it still fails.
-                if (target.needsPlugin && INTEGRATION_MISSING.test(message) && !projectUses(target.needsPlugin, this.localConfig)) {
-                    // oclif's catch already set exitCode to 1 for the sub-command; a real failure still
-                    // exits non-zero through the this.error() below.
-                    process.exitCode = undefined;
-                    this.log(`→ ${target.label}: not configured, skipped`);
-                    results.push({ label: target.label, status: 'skipped' });
-                    continue;
-                }
+                const message = errorMessage(error);
                 this.failedCount++;
                 this.log(`✗ ${target.label} failed: ${message}`);
                 results.push({ error: message, label: target.label, status: 'failed' });
@@ -97,4 +100,25 @@ export default class Pull extends LoopressCommand {
             return undefined;
         }
     }
+    // Composer has no directory: counted as unused, see missingFor.
+    projectUses(target) {
+        return target.needsPlugin !== undefined && projectUses(target.needsPlugin, this.localConfig);
+    }
+    // A site without ACF (or a form or snippet plugin) is the common case, not a failure, as
+    // long as the project doesn't use that resource: a vanilla site must pull, and a promote
+    // must not stop on it. A project that does use it still fails, without asking the site.
+    // Same for a Loopress Full feature on Light.
+    unavailable(target, capabilities) {
+        const missing = missingFor(target, capabilities);
+        if (!missing)
+            return undefined;
+        if (!this.projectUses(target)) {
+            this.log(`\n→ ${target.label}: ${missing.needsFull ? missing.reason : 'not configured'}, skipped`);
+            return { label: target.label, status: 'skipped' };
+        }
+        this.failedCount++;
+        const error = `${missing.reason} on ${this.siteConfig.name}`;
+        this.log(`\n✗ ${target.label} failed: ${error}`);
+        return { error, label: target.label, status: 'failed' };
+    }
 }

package/dist/commands/push.d.ts

@@ -18,9 +18,10 @@ export default class Push extends LoopressCommand {
         'dry-run': import("@oclif/core/interfaces").BooleanFlag<boolean>;
     };
     run(): Promise<PushResult>;
+    private applySiteSteps;
     private buildArgv;
-    private composerDeclaresPlugins;
     private composerJsonPath;
+    private declaredPlugins;
     private globalStylesSkipNote;
     private guardProductionPush;
     private skippedTargets;