@loopflowhq/agent-pack 0.3.0 → 0.5.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.cursor/commands/lfq-get-ticket-context.md +4 -0
- package/.cursor/commands/lfq-next-best-action.md +3 -0
- package/.cursor/commands/lfq-start-next-best-action.md +4 -0
- package/.cursor/commands/lfq-start-next-phase.md +4 -0
- package/loopflowhq/README.md +5 -7
- package/loopflowhq/agent.md +77 -22
- package/loopflowhq/commands/get-ticket-context.md +25 -0
- package/loopflowhq/commands/next-best-action.md +36 -0
- package/loopflowhq/commands/start-next-best-action.md +53 -0
- package/loopflowhq/commands/start-next-phase.md +49 -0
- package/loopflowhq/phases/epic-close.md +25 -0
- package/loopflowhq/phases/{discovery.md → epic-discovery.md} +8 -4
- package/loopflowhq/phases/epic-implement.md +26 -0
- package/loopflowhq/phases/{plan.md → epic-plan.md} +7 -2
- package/loopflowhq/phases/{refine.md → epic-refine.md} +7 -2
- package/loopflowhq/phases/followup-close.md +21 -0
- package/loopflowhq/phases/followup-review.md +25 -0
- package/loopflowhq/phases/shared-close-checklist.md +15 -0
- package/loopflowhq/phases/shared-execution-checklist.md +33 -0
- package/loopflowhq/phases/shared-planning-checklist.md +17 -0
- package/loopflowhq/phases/story-close.md +27 -0
- package/loopflowhq/phases/story-implement.md +33 -0
- package/loopflowhq/phases/story-plan.md +35 -0
- package/loopflowhq/phases/story-review.md +40 -0
- package/loopflowhq/phases/task-close.md +20 -0
- package/loopflowhq/phases/task-define.md +32 -0
- package/loopflowhq/phases/task-implement.md +25 -0
- package/package.json +1 -1
- package/.cursor/commands/lfq01-discovery.md +0 -24
- package/.cursor/commands/lfq02-planning.md +0 -71
- package/.cursor/commands/lfq03-implementing.md +0 -25
- package/.cursor/commands/lfq04-review.md +0 -85
- package/.cursor/commands/lfq05-testing.md +0 -55
- package/.cursor/commands/lfq06-shipping.md +0 -61
- package/.cursor/commands/lfq07-learning.md +0 -22
- package/.cursor/commands/lfq08-adjusting.md +0 -22
- package/loopflowhq/phases/close.md +0 -21
- package/loopflowhq/phases/define.md +0 -21
- package/loopflowhq/phases/implement.md +0 -21
- package/loopflowhq/phases/review.md +0 -20
|
@@ -0,0 +1,33 @@
|
|
|
1
|
+
# Ticket Type: Story - Phase: Implement
|
|
2
|
+
|
|
3
|
+
Goal: make the change in code, with tests and minimal risk.
|
|
4
|
+
|
|
5
|
+
## Inputs
|
|
6
|
+
|
|
7
|
+
- LoopFlowHQ ticket ID (pattern: `LOOPF-<number>` / regex: `LOOPF-\\d+`)
|
|
8
|
+
- Approved plan
|
|
9
|
+
- Ticket subtasks (if present)
|
|
10
|
+
|
|
11
|
+
## Outputs (minimum)
|
|
12
|
+
|
|
13
|
+
- Code changes
|
|
14
|
+
- Tests added/updated for the acceptance criteria (or explicit justification if not added)
|
|
15
|
+
- Verification evidence (commands run, expected outputs) posted in the ticket chat
|
|
16
|
+
- PR link for human review (when applicable to your repo workflow)
|
|
17
|
+
|
|
18
|
+
## Agent checklist
|
|
19
|
+
|
|
20
|
+
- Load ticket context + start/end phase transitions (see `loopflowhq/agent.md`).
|
|
21
|
+
- Ensure subtasks are loaded (`get_ticket_context` or `get_ticket_subtasks`) when present.
|
|
22
|
+
- If a parent Epic exists, load it too (read-only) for additional constraints.
|
|
23
|
+
- No human-in-the-loop in this phase:
|
|
24
|
+
- implement based on the approved plan + acceptance criteria
|
|
25
|
+
- do not block on questions; if assumptions are required, proceed safely and log them in ticket chat
|
|
26
|
+
- if the plan/AC is missing or clearly stale, stop and send the ticket back to Story Plan instead of guessing
|
|
27
|
+
- Implement the acceptance criteria from the ticket.
|
|
28
|
+
- Implement in small diffs; keep scope tight.
|
|
29
|
+
- Follow `loopflowhq/phases/shared-execution-checklist.md`.
|
|
30
|
+
- If you must make assumptions, document them in the ticket chat and proceed when safe.
|
|
31
|
+
- When the story is implemented:
|
|
32
|
+
- open a PR (if your workflow uses PRs for Story Review) and post the PR link + a concise change summary in the ticket chat
|
|
33
|
+
- move the ticket to Story Review: set `phase=review`, `phase_state=ready`
|
|
@@ -0,0 +1,35 @@
|
|
|
1
|
+
# Ticket Type: Story - Phase: Plan
|
|
2
|
+
|
|
3
|
+
Goal: decide the smallest safe implementation plan (small diffs) with verification, and make the story implementation-ready.
|
|
4
|
+
|
|
5
|
+
## Inputs
|
|
6
|
+
|
|
7
|
+
- LoopFlowHQ ticket ID (pattern: `LOOPF-<number>` / regex: `LOOPF-\\d+`)
|
|
8
|
+
- Final requirements + constraints
|
|
9
|
+
- System constraints (tech stack, performance, security, rollout)
|
|
10
|
+
|
|
11
|
+
## Outputs (minimum)
|
|
12
|
+
|
|
13
|
+
- Updated ticket title + description:
|
|
14
|
+
- clear problem statement
|
|
15
|
+
- explicit scope + non-goals
|
|
16
|
+
- Concrete, testable acceptance criteria
|
|
17
|
+
- Plan stored in the ticket description as a `## Plan` section:
|
|
18
|
+
- small, atomic, independently committable subtasks
|
|
19
|
+
- explicit verification steps (tests/lint/build/manual)
|
|
20
|
+
- Risks and rollback notes (if needed)
|
|
21
|
+
|
|
22
|
+
## Agent checklist
|
|
23
|
+
|
|
24
|
+
- Load ticket context (see `loopflowhq/agent.md`).
|
|
25
|
+
- This is a human-in-the-loop phase:
|
|
26
|
+
- ask the minimum clarification questions needed to remove ambiguity
|
|
27
|
+
- do not implement code in this phase
|
|
28
|
+
- Scan the codebase/docs to confirm whether the work is already partially or fully implemented.
|
|
29
|
+
- Use `loopflowhq/phases/shared-planning-checklist.md`.
|
|
30
|
+
- Ensure the subtask plan covers `loopflowhq/phases/shared-execution-checklist.md`.
|
|
31
|
+
- Keep subtasks small (mergeable on their own).
|
|
32
|
+
- Save the `## Plan` section into the ticket description via `update_ticket`.
|
|
33
|
+
- When the plan is agreed and the ticket is implementation-ready:
|
|
34
|
+
- set `phase=plan`, `phase_state=done`
|
|
35
|
+
|
|
@@ -0,0 +1,40 @@
|
|
|
1
|
+
# Ticket Type: Story - Phase: Review
|
|
2
|
+
|
|
3
|
+
Goal: human review of the implemented PR: validate correctness, quality, and alignment with requirements.
|
|
4
|
+
|
|
5
|
+
## Inputs
|
|
6
|
+
|
|
7
|
+
- LoopFlowHQ ticket ID (pattern: `LOOPF-<number>` / regex: `LOOPF-\\d+`)
|
|
8
|
+
- PR link (required)
|
|
9
|
+
- Deployed preview URL (if available)
|
|
10
|
+
- Implemented changes (code + tests)
|
|
11
|
+
- Acceptance criteria
|
|
12
|
+
|
|
13
|
+
## Outputs (minimum)
|
|
14
|
+
|
|
15
|
+
- Review notes captured in ticket chat (approval or requested changes)
|
|
16
|
+
- One of:
|
|
17
|
+
- Approved: set `phase=review`, `phase_state=done` and move to Close (`phase=close`, `phase_state=ready`)
|
|
18
|
+
- Changes requested: set `phase=review`, `phase_state=changes_requested` with an actionable list
|
|
19
|
+
|
|
20
|
+
## Agent checklist
|
|
21
|
+
|
|
22
|
+
- Load ticket context (see `loopflowhq/agent.md`).
|
|
23
|
+
- This is a human-in-the-loop phase:
|
|
24
|
+
- do not implement code in this phase
|
|
25
|
+
- ask questions / request clarifications from the human reviewer when needed
|
|
26
|
+
- Review focus:
|
|
27
|
+
- acceptance criteria is demonstrably met
|
|
28
|
+
- correctness + regressions + edge cases
|
|
29
|
+
- tests and coverage for critical paths
|
|
30
|
+
- UI behavior (states, responsiveness, a11y) when applicable
|
|
31
|
+
- Approval path:
|
|
32
|
+
- post a concise approval note in ticket chat
|
|
33
|
+
- set `phase=review`, `phase_state=done`
|
|
34
|
+
- move to Close (`phase=close`, `phase_state=ready`)
|
|
35
|
+
- Changes requested path:
|
|
36
|
+
- ask for each comment in enough detail to be actionable (repro steps, expected vs actual, screenshots if relevant)
|
|
37
|
+
- collect a complete list ("any more?") before switching phases
|
|
38
|
+
- post a single consolidated list of requested changes in ticket chat
|
|
39
|
+
- set `phase=review`, `phase_state=changes_requested`
|
|
40
|
+
|
|
@@ -0,0 +1,20 @@
|
|
|
1
|
+
# Ticket Type: Task - Phase: Close
|
|
2
|
+
|
|
3
|
+
Goal: ship the task, close the loop, and leave the system clean.
|
|
4
|
+
|
|
5
|
+
## Inputs
|
|
6
|
+
|
|
7
|
+
- LoopFlowHQ ticket ID (pattern: `LOOPF-<number>` / regex: `LOOPF-\\d+`)
|
|
8
|
+
- PR link (from Task Implement)
|
|
9
|
+
- Any rollout/release constraints
|
|
10
|
+
|
|
11
|
+
## Outputs (minimum)
|
|
12
|
+
|
|
13
|
+
- “What shipped” summary
|
|
14
|
+
- Ship/deploy evidence (merge link, deploy link/logs, or release notes)
|
|
15
|
+
|
|
16
|
+
## Agent checklist
|
|
17
|
+
|
|
18
|
+
- Use `loopflowhq/phases/shared-close-checklist.md`.
|
|
19
|
+
- When shipping is complete:
|
|
20
|
+
- set `phase=close`, `phase_state=done`
|
|
@@ -0,0 +1,32 @@
|
|
|
1
|
+
# Ticket Type: Task - Phase: Define
|
|
2
|
+
|
|
3
|
+
Goal: turn a vague task into an executable shape (what, why, constraints) and a minimal plan.
|
|
4
|
+
|
|
5
|
+
## Inputs
|
|
6
|
+
|
|
7
|
+
- LoopFlowHQ ticket ID (pattern: `LOOPF-<number>` / regex: `LOOPF-\\d+`)
|
|
8
|
+
- Ticket title/description (may be vague)
|
|
9
|
+
- Any context from prior messages
|
|
10
|
+
|
|
11
|
+
## Outputs (minimum)
|
|
12
|
+
|
|
13
|
+
- Clear problem statement (1-3 sentences)
|
|
14
|
+
- Constraints and non-goals
|
|
15
|
+
- Concrete acceptance criteria (or a proposal to confirm)
|
|
16
|
+
- A minimal `## Plan` section with small, atomic subtasks (when applicable)
|
|
17
|
+
- Define summary captured in the ticket chat (via `post_ticket_message`)
|
|
18
|
+
|
|
19
|
+
## Agent checklist
|
|
20
|
+
|
|
21
|
+
- Load ticket context (see `loopflowhq/agent.md`).
|
|
22
|
+
- Ask the minimum clarification questions needed to remove ambiguity.
|
|
23
|
+
- Propose acceptance criteria if missing; get confirmation.
|
|
24
|
+
- Identify dependencies/risks early (APIs, migrations, permissions, rollout).
|
|
25
|
+
- Use `loopflowhq/phases/shared-planning-checklist.md` when a plan is needed.
|
|
26
|
+
- Update the ticket title/description/AC and write the `## Plan` section via `update_ticket`.
|
|
27
|
+
- If the task needs explicit execution steps, create/update task subtasks via `update_ticket_subtasks`.
|
|
28
|
+
- Post a concise Define summary via `post_ticket_message`:
|
|
29
|
+
- what changed in the ticket (title/description/AC)
|
|
30
|
+
- the plan summary (high level)
|
|
31
|
+
- key assumptions/risks
|
|
32
|
+
|
|
@@ -0,0 +1,25 @@
|
|
|
1
|
+
# Ticket Type: Task - Phase: Implement
|
|
2
|
+
|
|
3
|
+
Goal: make the change in code, with tests and minimal risk.
|
|
4
|
+
|
|
5
|
+
## Inputs
|
|
6
|
+
|
|
7
|
+
- LoopFlowHQ ticket ID (pattern: `LOOPF-<number>` / regex: `LOOPF-\\d+`)
|
|
8
|
+
- Defined scope + acceptance criteria (from Define phase or ticket)
|
|
9
|
+
|
|
10
|
+
## Outputs (minimum)
|
|
11
|
+
|
|
12
|
+
- Code changes
|
|
13
|
+
- Tests (or explicit justification if not added)
|
|
14
|
+
- Verification evidence (commands run, expected outputs)
|
|
15
|
+
|
|
16
|
+
## Agent checklist
|
|
17
|
+
|
|
18
|
+
- Load ticket context + start/end phase transitions (see `loopflowhq/agent.md`).
|
|
19
|
+
- Implement the acceptance criteria from the ticket; if unclear or missing, ask before proceeding.
|
|
20
|
+
- Implement in small diffs; keep changes scoped.
|
|
21
|
+
- Write/update tests that cover the acceptance criteria (or document why tests are not feasible).
|
|
22
|
+
- Run the project's standard checks (lint/typecheck/test/build) when applicable.
|
|
23
|
+
- Call out any behavior changes and migrations.
|
|
24
|
+
- When the task is complete, move the ticket to Close (`phase=close`, `phase_state=ready`) and summarize in ticket chat.
|
|
25
|
+
|
package/package.json
CHANGED
|
@@ -1,24 +0,0 @@
|
|
|
1
|
-
# lfq01-discovery — Discovery step
|
|
2
|
-
|
|
3
|
-
**Requirement:** Ticket key or URL may be in the command; if omitted, infer from conversation context (see lfq-ticket-workflow.md §1). Ask only if no ticket can be inferred or if multiple tickets are referenced and the intended one is unclear.
|
|
4
|
-
|
|
5
|
-
**When asking questions:** Use an interactive CLI style — ask one question at a time, wait for the user's answer, then ask the next. This makes it easier to answer.
|
|
6
|
-
|
|
7
|
-
**Ticket workflow:** For resolve ticket ID, load ticket, and when-done steps (post summary, transition, confirm), follow **lfq-ticket-workflow.md**. This step uses Discovery typed transitions: start with `phase=discovery`, `phase_state=in_progress`, and finish with `phase=discovery`, `phase_state=done` via `update_ticket`.
|
|
8
|
-
|
|
9
|
-
## Discovery work
|
|
10
|
-
|
|
11
|
-
- Explore scope and clarify requirements.
|
|
12
|
-
- Analyze codebase and identify ambiguities.
|
|
13
|
-
- Ask clarification questions **here in this chat**, one at a time (interactive CLI style). Wait for each answer before asking the next. Do **not** send questions via LoopFlowHQ MCP — ask the user directly in the conversation.
|
|
14
|
-
<!-- Optionally post questions/answers to the ticket via `post_ticket_agent_questions` (one at a time) or summarize in `post_ticket_message` when done. -->
|
|
15
|
-
- Document findings for next steps.
|
|
16
|
-
|
|
17
|
-
## Summary example (for post_ticket_message)
|
|
18
|
-
|
|
19
|
-
```
|
|
20
|
-
## Discovery done
|
|
21
|
-
- Scope: [brief]
|
|
22
|
-
- Clarifications received: [key points]
|
|
23
|
-
- Open questions / risks: [if any]
|
|
24
|
-
```
|
|
@@ -1,71 +0,0 @@
|
|
|
1
|
-
# lfq02-planning — Planning step
|
|
2
|
-
|
|
3
|
-
**Requirement:** Ticket key or URL may be in the command; if omitted, infer from conversation context (see lfq-ticket-workflow.md §1). Ask only if no ticket can be inferred or if multiple tickets are referenced and the intended one is unclear.
|
|
4
|
-
|
|
5
|
-
**When asking questions:** Use an interactive CLI style — ask one question at a time, wait for the user's answer, then ask the next. This makes it easier to answer.
|
|
6
|
-
|
|
7
|
-
**Ticket workflow:** For resolve ticket ID, load ticket and context, and when-done steps, follow **lfq-ticket-workflow.md**. This step uses Planning typed transitions: start with `phase=plan`, `phase_state=in_progress`, finish with `phase=plan`, `phase_state=done` via `update_ticket`. Use prior step summaries (e.g. Discovery done) as context.
|
|
8
|
-
|
|
9
|
-
**What this step does:** Read the repo and prior context only. Produce a markdown plan and save it in the LFQ ticket (update ticket description with a **Plan** section via `update_ticket` action / REST API). Do **not** change any files in the repo. Documentation steps (ADRs, feature docs) are only TODOs in the plan—they are done in a later step, not in this phase. **Think:** Does this work require updating the `/privacy` page (e.g. new data collection, third-party services, cookies)? If so, add a plan item for it.
|
|
10
|
-
|
|
11
|
-
---
|
|
12
|
-
|
|
13
|
-
## Plan requirements
|
|
14
|
-
|
|
15
|
-
- Include clear, minimal, concise steps.
|
|
16
|
-
- **Scope:** Do NOT add extra scope or unnecessary complexity beyond explicitly clarified details.
|
|
17
|
-
- **Step style:** Steps should be modular, elegant, minimal, and integrate seamlessly within the existing codebase.
|
|
18
|
-
|
|
19
|
-
---
|
|
20
|
-
|
|
21
|
-
## Plan structure (save in LFQ ticket)
|
|
22
|
-
|
|
23
|
-
Produce a markdown plan with this structure. Preserve any existing ticket description and add or update a clear `## Plan` section with the content below.
|
|
24
|
-
|
|
25
|
-
**Title**
|
|
26
|
-
After discovery, check the ticket context and adjust the name of the ticket
|
|
27
|
-
|
|
28
|
-
**## TLDR**
|
|
29
|
-
|
|
30
|
-
Short summary of what we're building and why.
|
|
31
|
-
|
|
32
|
-
**## Critical Decisions**
|
|
33
|
-
|
|
34
|
-
Key architectural/implementation choices made during exploration:
|
|
35
|
-
|
|
36
|
-
- Decision 1: [choice] - [brief rationale]
|
|
37
|
-
- Decision 2: [choice] - [brief rationale]
|
|
38
|
-
|
|
39
|
-
**## Documentation**
|
|
40
|
-
|
|
41
|
-
When the work warrants documentation, add **plan items** (TODOs) for later—do not write docs in this phase:
|
|
42
|
-
|
|
43
|
-
- **ADRs** (docs-adr): For significant architectural decisions. Plan path: `docs/decisions/NNN-slug.md`.
|
|
44
|
-
- **Feature docs** (docs-feature): For major features with non-obvious implementation. Plan path: `docs/FEATURE_NAME.md`.
|
|
45
|
-
- **Privacy page** (`/privacy`): When the work involves new data collection, third-party services, cookies, or processing of user data, add a plan item to update the privacy page if required.
|
|
46
|
-
|
|
47
|
-
**## Tasks**
|
|
48
|
-
|
|
49
|
-
- [ ] 🟥 **Step 1: [Name]**
|
|
50
|
-
- [ ] 🟥 Subtask 1
|
|
51
|
-
- [ ] 🟥 Subtask 2
|
|
52
|
-
|
|
53
|
-
- [ ] 🟥 **Step 2: [Name]**
|
|
54
|
-
- [ ] 🟥 Subtask 1
|
|
55
|
-
- [ ] 🟥 Subtask 2
|
|
56
|
-
|
|
57
|
-
- [ ] 🟥 **Document: [Create ADR for X | Create feature doc for Y]** (when warranted)
|
|
58
|
-
|
|
59
|
-
...
|
|
60
|
-
|
|
61
|
-
---
|
|
62
|
-
|
|
63
|
-
Again, it's still not time to build yet. Just write the clear plan document. No extra complexity or extra scope beyond what we discussed. Save it in the LFQ ticket by updating the ticket description with a **Plan** section (do not save to a file, do not change any repo files).
|
|
64
|
-
|
|
65
|
-
## Summary example (for post_ticket_message)
|
|
66
|
-
|
|
67
|
-
```
|
|
68
|
-
## Planning done
|
|
69
|
-
- Plan: stored in ticket description (Plan section)
|
|
70
|
-
- Steps: [count]
|
|
71
|
-
```
|
|
@@ -1,25 +0,0 @@
|
|
|
1
|
-
# lfq03-implementing — Implementing step
|
|
2
|
-
|
|
3
|
-
**Requirement:** Ticket key or URL may be in the command; if omitted, infer from conversation context (see lfq-ticket-workflow.md §1). Ask only if no ticket can be inferred or if multiple tickets are referenced and the intended one is unclear.
|
|
4
|
-
|
|
5
|
-
**When asking questions:** Use an interactive CLI style — ask one question at a time, wait for the user's answer, then ask the next. This makes it easier to answer.
|
|
6
|
-
|
|
7
|
-
**Ticket workflow:** For resolve ticket ID, load ticket and context, and when-done steps, follow **lfq-ticket-workflow.md**. This step uses Implementing typed transitions: start with `phase=implement`, `phase_state=in_progress`, finish with `phase=implement`, `phase_state=done` via `update_ticket`. Use prior step summaries (Discovery, Planning) and the plan document (e.g. in `docs/plans/`) as context.
|
|
8
|
-
|
|
9
|
-
## Implementing work
|
|
10
|
-
|
|
11
|
-
- Follow `execute.md`: implement precisely as planned.
|
|
12
|
-
- Update the plan document with emoji status as you progress.
|
|
13
|
-
- Adhere to project rules (Design, coding-patterns, UX).
|
|
14
|
-
- **Do not** create a branch, commit, or open a PR in this step.
|
|
15
|
-
|
|
16
|
-
## When implementation is done
|
|
17
|
-
|
|
18
|
-
- Post the summary via `post_ticket_message`, then call `update_ticket` with `phase=implement` and `phase_state=done`. Do not run git commit or advance the ticket to the next step.
|
|
19
|
-
|
|
20
|
-
## Summary example (for post_ticket_message)
|
|
21
|
-
|
|
22
|
-
```
|
|
23
|
-
## Implementing done
|
|
24
|
-
- Changes: [brief list of files/areas touched]
|
|
25
|
-
```
|
|
@@ -1,85 +0,0 @@
|
|
|
1
|
-
# lfq04-review — Review step
|
|
2
|
-
|
|
3
|
-
**Requirement:** Ticket key or URL may be in the command; if omitted, infer from conversation context (see lfq-ticket-workflow.md §1). Ask only if no ticket can be inferred or if multiple tickets are referenced and the intended one is unclear.
|
|
4
|
-
|
|
5
|
-
**When asking questions:** Use an interactive CLI style — ask one question at a time, wait for the user's answer, then ask the next. This makes it easier to answer.
|
|
6
|
-
|
|
7
|
-
**Ticket workflow:** For resolve ticket ID, load ticket and context, and when-done steps, follow **lfq-ticket-workflow.md**. This step uses Review typed transitions: start with `phase=review`, `phase_state=in_progress`, finish with `phase=review`, `phase_state=done` via `update_ticket`. Use prior step summaries (Implementing done) as context.
|
|
8
|
-
|
|
9
|
-
---
|
|
10
|
-
|
|
11
|
-
## 1. Perform code review
|
|
12
|
-
|
|
13
|
-
Follow the same checks and output structure as **review.md**:
|
|
14
|
-
|
|
15
|
-
**Check for:**
|
|
16
|
-
|
|
17
|
-
- **Logging** — No console.log, use proper logger with context
|
|
18
|
-
- **Error handling** — Try-catch for async, centralized handlers, helpful messages
|
|
19
|
-
- **TypeScript** — No `any`, proper interfaces, no @ts-ignore
|
|
20
|
-
- **Production readiness** — No debug statements, no TODOs, no hardcoded secrets
|
|
21
|
-
- **React/Hooks** — Effects have cleanup, dependencies complete, no infinite loops
|
|
22
|
-
- **Performance** — No unnecessary re-renders, expensive calcs memoized
|
|
23
|
-
- **Security** — Auth checked, inputs validated, RLS in place
|
|
24
|
-
- **Architecture** — Follows existing patterns, code in correct directory
|
|
25
|
-
|
|
26
|
-
**Severity levels:** CRITICAL (security, data loss, crashes), HIGH (bugs, performance, bad UX), MEDIUM (code quality, maintainability), LOW (style, minor).
|
|
27
|
-
|
|
28
|
-
---
|
|
29
|
-
|
|
30
|
-
## 2. Fix all issues, then re-review
|
|
31
|
-
|
|
32
|
-
- If **any issues** are found (Critical, High, Medium, or Low):
|
|
33
|
-
1. **Fix every issue** (apply suggested fixes or equivalent).
|
|
34
|
-
2. **Re-run the review** on the changed code until there are no remaining issues, or you explicitly document why a finding is not fixed (e.g. deferred, out of scope).
|
|
35
|
-
- Only after all issues are fixed or documented do you post the review and mark the step done.
|
|
36
|
-
|
|
37
|
-
---
|
|
38
|
-
|
|
39
|
-
## 3. Store review in ticket chat (no .review files)
|
|
40
|
-
|
|
41
|
-
- **Do not** write the review to `.review/<ticket-key>.md` or any file under `.review/`.
|
|
42
|
-
- Post the **full review** as a single ticket message using **`post_ticket_message`** so the review lives in the ticket chat.
|
|
43
|
-
|
|
44
|
-
**Message content format** (use this exact structure in the posted message):
|
|
45
|
-
|
|
46
|
-
```markdown
|
|
47
|
-
## Code review
|
|
48
|
-
|
|
49
|
-
### ✅ Looks Good
|
|
50
|
-
|
|
51
|
-
- [Item 1]
|
|
52
|
-
- [Item 2]
|
|
53
|
-
|
|
54
|
-
### ⚠️ Issues Found
|
|
55
|
-
|
|
56
|
-
- **[Severity]** [File:line] - [Issue description]
|
|
57
|
-
- Fix: [Suggested fix]
|
|
58
|
-
(If none: "None.")
|
|
59
|
-
|
|
60
|
-
### 📊 Summary
|
|
61
|
-
|
|
62
|
-
- Files reviewed: X
|
|
63
|
-
- Critical issues: 0 (after fixes)
|
|
64
|
-
- Warnings: 0 (after fixes)
|
|
65
|
-
|
|
66
|
-
**Outcome:** Passed. [One line: e.g. "Changes are minimal and follow existing patterns." / "All issues fixed and re-verified."]
|
|
67
|
-
```
|
|
68
|
-
|
|
69
|
-
Then add the step-done line:
|
|
70
|
-
|
|
71
|
-
```markdown
|
|
72
|
-
## Review done
|
|
73
|
-
|
|
74
|
-
- Outcome: [passed / issues fixed and re-verified]
|
|
75
|
-
- Critical issues: 0
|
|
76
|
-
```
|
|
77
|
-
|
|
78
|
-
(You may combine the "Code review" and "Review done" blocks into one `post_ticket_message` call.)
|
|
79
|
-
|
|
80
|
-
---
|
|
81
|
-
|
|
82
|
-
## 4. Mark step done
|
|
83
|
-
|
|
84
|
-
- Call **`update_ticket`** with `ticket`, `phase`: `review`, `phase_state`: `done` (legacy `status` should stay compatible).
|
|
85
|
-
- Confirm to the user that the review step is complete and the ticket is ready for the next step (e.g. testing).
|
|
@@ -1,55 +0,0 @@
|
|
|
1
|
-
# lfq05-testing — Testing step
|
|
2
|
-
|
|
3
|
-
**Requirement:** Ticket key or URL may be in the command; if omitted, infer from conversation context (see lfq-ticket-workflow.md §1). Ask only if no ticket can be inferred or if multiple tickets are referenced and the intended one is unclear.
|
|
4
|
-
|
|
5
|
-
**When asking questions:** Use an interactive CLI style — ask one question at a time, wait for the user's answer, then ask the next. This makes it easier to answer.
|
|
6
|
-
|
|
7
|
-
**Ticket workflow:** For resolve ticket ID, load ticket and context, and when-done steps, follow **lfq-ticket-workflow.md**. This step validates release readiness and keeps ticket in close-stage execution (`phase=close`, typically `phase_state=in_progress`). Use prior step summaries (Implementing, Review) as context.
|
|
8
|
-
|
|
9
|
-
**Do not:** Create a PR or push commits in this step. Commit, push, and PR creation belong to the Shipping step (lfq06-shipping).
|
|
10
|
-
|
|
11
|
-
## Understand ticket and acceptance criteria
|
|
12
|
-
|
|
13
|
-
1. **Ticket description** — Read and understand the full ticket description. Ensure you know what the ticket is asking for.
|
|
14
|
-
2. **Acceptance criteria** — If the ticket has acceptance criteria (e.g. in the description or as a list), treat them as the source of truth for "done."
|
|
15
|
-
3. **Validate implementation** — Go through each acceptance criterion and confirm it is implemented in code or behavior. If any are missing, implement or fix before considering testing complete.
|
|
16
|
-
4. **Validate docs** — If the change affects architecture, behavior, or features, ensure the appropriate docs are updated (e.g. ADRs in `docs/adr/`, feature docs in `docs/`, READMEs). Documentation should match the current implementation.
|
|
17
|
-
|
|
18
|
-
## Testing work
|
|
19
|
-
|
|
20
|
-
1. **Clean debug code** — Before running the linter, remove all debug code:
|
|
21
|
-
- Remove all `console.log` statements (except browser `console.log` relevant to users in production)
|
|
22
|
-
- Remove any debug logs calling `127.0.0.1` or `localhost`
|
|
23
|
-
- Clean up any temporary debug code
|
|
24
|
-
|
|
25
|
-
2. **Run linter** — Execute `npm run lint` to check code quality and catch any linting issues in **all projects** in `apps/` (e.g. webapp and website).
|
|
26
|
-
|
|
27
|
-
3. **Test build** — Run `npm run build` to ensure **all projects** build successfully without errors.
|
|
28
|
-
|
|
29
|
-
4. **Run tests** — Execute `npm run test` to run all test suites in **all projects** and ensure everything passes.
|
|
30
|
-
|
|
31
|
-
5. **Manual verification** — If applicable, run the dev server and smoke-test the change (e.g. key flows, UI, or APIs).
|
|
32
|
-
|
|
33
|
-
6. **Address issues** — Fix any failures or issues found during lint, build, tests, or manual verification.
|
|
34
|
-
|
|
35
|
-
## Checklist
|
|
36
|
-
|
|
37
|
-
- [ ] Ticket description understood; acceptance criteria (if any) identified
|
|
38
|
-
- [ ] All acceptance criteria validated as implemented
|
|
39
|
-
- [ ] Appropriate docs updated (ADRs, feature docs in `docs/`, etc.) and match implementation
|
|
40
|
-
- [ ] Debug code cleaned up (console.log, 127.0.0.1 calls, etc.)
|
|
41
|
-
- [ ] Linter passes with no errors for **all projects** in `apps/`
|
|
42
|
-
- [ ] Build completes successfully for **all projects** in `apps/`
|
|
43
|
-
- [ ] All tests pass for **all projects** in `apps/`
|
|
44
|
-
- [ ] Manual verification done if applicable
|
|
45
|
-
|
|
46
|
-
## Summary example (for post_ticket_message)
|
|
47
|
-
|
|
48
|
-
```
|
|
49
|
-
## Testing done
|
|
50
|
-
- Ticket/AC: [brief note that description and acceptance criteria were checked and met]
|
|
51
|
-
- Docs: [updated / N/A]
|
|
52
|
-
- Tests: passing
|
|
53
|
-
- Build: passing
|
|
54
|
-
- Notes: [any manual verification]
|
|
55
|
-
```
|
|
@@ -1,61 +0,0 @@
|
|
|
1
|
-
# lfq06-shipping — Shipping step
|
|
2
|
-
|
|
3
|
-
**Requirement:** Ticket key or URL may be in the command; if omitted, infer from conversation context (see lfq-ticket-workflow.md §1). Ask only if no ticket can be inferred or if multiple tickets are referenced and the intended one is unclear.
|
|
4
|
-
|
|
5
|
-
**When asking questions:** Use an interactive CLI style — ask one question at a time, wait for the user's answer, then ask the next. This makes it easier to answer.
|
|
6
|
-
|
|
7
|
-
**Ticket workflow:** For resolve ticket ID, load ticket and context, and when-done steps, follow **lfq-ticket-workflow.md**. This step executes close/shipping work: keep `phase=close`, move from `phase_state=in_progress` to `phase_state=done` when shipping is complete. Use prior step summaries (PR link, branch) as context.
|
|
8
|
-
|
|
9
|
-
## 1. Ensure we are not on main with uncommitted changes
|
|
10
|
-
|
|
11
|
-
If `git branch --show-current` is `main` **and** `git status --porcelain` is non-empty:
|
|
12
|
-
|
|
13
|
-
1. **Derive branch name from uncommitted files** (see create-branch.md as inspiration):
|
|
14
|
-
- Run `git status --porcelain` to inspect changed files
|
|
15
|
-
- Infer type from paths: `docs/` → docs, `*.test.*` or `__tests__/` → test, config files → chore, `.github/` → ci, CSS → style, bug-fix cues → fix, new components/features → feat, refactors → refactor, perf cues → perf
|
|
16
|
-
- Suggest branch name: `<type>/short-description` (e.g. `feat/LOOPF-30-substate-icons`). Ask user if unclear
|
|
17
|
-
2. **Move uncommitted changes onto a new branch** (same flow as create-branch.md):
|
|
18
|
-
- `git stash push -u -m "cursor-ship"`
|
|
19
|
-
- `git fetch origin main` && `git pull origin main`
|
|
20
|
-
- `git checkout -b <branch-name>`
|
|
21
|
-
- `git stash pop`
|
|
22
|
-
|
|
23
|
-
If already on a feature branch with uncommitted changes, skip to step 2. If on main with no changes and no existing PR, ask the user what to ship.
|
|
24
|
-
|
|
25
|
-
## 2. Commit and push
|
|
26
|
-
|
|
27
|
-
- Stage changes: `git add .` (or stage selectively)
|
|
28
|
-
- **Commit message:** Follow Conventional Commits (commitlint / husky). Format: `type(scope): subject` with optional body bullets. Types: `feat`, `fix`, `chore`, `docs`, `style`, `refactor`, `perf`, `test`, `build`, `ci`, `revert`. Scope: `web`, `api`, `mcp`, `deps`, `ci`, `docs`. Subject: imperative, lowercase.
|
|
29
|
-
- Commit: `git commit -m "..."` (use `-F` with temp file if multi-line)
|
|
30
|
-
- Push: `git push -u origin <branch>`
|
|
31
|
-
|
|
32
|
-
## 3. Prepare a PR
|
|
33
|
-
|
|
34
|
-
- Create PR targeting `main`
|
|
35
|
-
- **PR title:** Use same Conventional Commits format as the commit (e.g. `feat(web): add substate icons`) — release-please parses PR titles and merge commits for changelog
|
|
36
|
-
- **PR body:** Reference ticket(s), e.g. `Closes LOOPF-30` or `Related to LOOPF-30`
|
|
37
|
-
- Do **not** merge the PR unless the user explicitly asks to merge
|
|
38
|
-
|
|
39
|
-
### PR title gating (required)
|
|
40
|
-
|
|
41
|
-
- **Husky only checks local commit messages**, not PR titles.
|
|
42
|
-
- Add a PR title check in CI so merges are blocked unless the title is Conventional Commits:
|
|
43
|
-
- Recommended: use `amannn/action-semantic-pull-request` in `.github/workflows/pr-title.yml` and require it in branch protection.
|
|
44
|
-
- If a PR title fails, fix the title before merge so the merge commit is parseable by release-please.
|
|
45
|
-
|
|
46
|
-
## 4. Post-PR shipping work (when PR exists)
|
|
47
|
-
|
|
48
|
-
- Merge the PR to `main` **only if the user explicitly requests it**
|
|
49
|
-
|
|
50
|
-
## 5. Mark tickets done
|
|
51
|
-
|
|
52
|
-
When shipping work is complete (PR created and, if requested, merged): call `update_ticket` with `phase=close`, `phase_state=done` (and compatible legacy `status`). Post summary via `post_ticket_message`.
|
|
53
|
-
|
|
54
|
-
## Summary example (for post_ticket_message)
|
|
55
|
-
|
|
56
|
-
```
|
|
57
|
-
## Shipping done
|
|
58
|
-
- Branch: [branch name]
|
|
59
|
-
- PR: [PR link]
|
|
60
|
-
- Merged: [yes/no, PR link if merged]
|
|
61
|
-
```
|
|
@@ -1,22 +0,0 @@
|
|
|
1
|
-
# lfq07-learning — Learning step
|
|
2
|
-
|
|
3
|
-
**Requirement:** Ticket key or URL may be in the command; if omitted, infer from conversation context (see lfq-ticket-workflow.md §1). Ask only if no ticket can be inferred or if multiple tickets are referenced and the intended one is unclear.
|
|
4
|
-
|
|
5
|
-
**When asking questions:** Use an interactive CLI style — ask one question at a time, wait for the user's answer, then ask the next. This makes it easier to answer.
|
|
6
|
-
|
|
7
|
-
**Ticket workflow:** For resolve ticket ID, load ticket and context, and when-done steps, follow **lfq-ticket-workflow.md**. This step is a post-delivery analysis step; it usually does not require a phase change and should keep typed workflow coherent for the ticket type. Use prior step summaries (what was shipped, outcomes) as context.
|
|
8
|
-
|
|
9
|
-
## Learning work
|
|
10
|
-
|
|
11
|
-
- Reflect on what was delivered: outcomes, metrics, user feedback if available.
|
|
12
|
-
- Document lessons learned, surprises, or improvements for next time.
|
|
13
|
-
- Identify any adjustments to process or scope.
|
|
14
|
-
|
|
15
|
-
## Summary example (for post_ticket_message)
|
|
16
|
-
|
|
17
|
-
```
|
|
18
|
-
## Learning done
|
|
19
|
-
- Outcomes: [what we observed]
|
|
20
|
-
- Lessons: [key takeaways]
|
|
21
|
-
- Adjustments: [if any]
|
|
22
|
-
```
|
|
@@ -1,22 +0,0 @@
|
|
|
1
|
-
# lfq08-adjusting — Adjusting step
|
|
2
|
-
|
|
3
|
-
**Requirement:** Ticket key or URL may be in the command; if omitted, infer from conversation context (see lfq-ticket-workflow.md §1). Ask only if no ticket can be inferred or if multiple tickets are referenced and the intended one is unclear.
|
|
4
|
-
|
|
5
|
-
**When asking questions:** Use an interactive CLI style — ask one question at a time, wait for the user's answer, then ask the next. This makes it easier to answer.
|
|
6
|
-
|
|
7
|
-
**Ticket workflow:** For resolve ticket ID, load ticket and context, and when-done steps, follow **lfq-ticket-workflow.md**. This step applies post-delivery adjustments (often via followup tickets) and should keep typed workflow coherent with the ticket type. Use prior step summaries (Learning done, lessons) as context.
|
|
8
|
-
|
|
9
|
-
## Adjusting work
|
|
10
|
-
|
|
11
|
-
- Based on Learning outcomes: apply process or scope adjustments.
|
|
12
|
-
- Create follow-up tickets if needed.
|
|
13
|
-
- Update documentation or runbooks.
|
|
14
|
-
- Decide if ticket can move to Done.
|
|
15
|
-
|
|
16
|
-
## Summary example (for post_ticket_message)
|
|
17
|
-
|
|
18
|
-
```
|
|
19
|
-
## Adjusting done
|
|
20
|
-
- Adjustments: [what was done]
|
|
21
|
-
- Follow-ups: [ticket keys if any]
|
|
22
|
-
```
|
|
@@ -1,21 +0,0 @@
|
|
|
1
|
-
# Phase: Close
|
|
2
|
-
|
|
3
|
-
Goal: finish the loop: ship, document, and leave the system clean.
|
|
4
|
-
|
|
5
|
-
## Inputs
|
|
6
|
-
|
|
7
|
-
- Approved outcome (or explicit cancellation reason)
|
|
8
|
-
- Any rollout/release constraints
|
|
9
|
-
|
|
10
|
-
## Outputs (minimum)
|
|
11
|
-
|
|
12
|
-
- “What shipped” summary
|
|
13
|
-
- Verification steps (and results)
|
|
14
|
-
- Followups created if needed
|
|
15
|
-
|
|
16
|
-
## Agent checklist
|
|
17
|
-
|
|
18
|
-
- Ensure the ticket summary matches what actually changed.
|
|
19
|
-
- If cancelled, record why and whether a followup is needed.
|
|
20
|
-
- Prefer small cleanup over “nice-to-have” refactors.
|
|
21
|
-
|
|
@@ -1,21 +0,0 @@
|
|
|
1
|
-
# Phase: Define
|
|
2
|
-
|
|
3
|
-
Goal: turn a vague task into an executable shape (what, why, constraints).
|
|
4
|
-
|
|
5
|
-
## Inputs
|
|
6
|
-
|
|
7
|
-
- Ticket title (may be vague)
|
|
8
|
-
- Any context from prior messages
|
|
9
|
-
|
|
10
|
-
## Outputs (minimum)
|
|
11
|
-
|
|
12
|
-
- Clear problem statement (1-3 sentences)
|
|
13
|
-
- Constraints and non-goals
|
|
14
|
-
- Concrete acceptance criteria (or a proposal to confirm)
|
|
15
|
-
|
|
16
|
-
## Agent checklist
|
|
17
|
-
|
|
18
|
-
- Ask the minimum questions needed to remove ambiguity.
|
|
19
|
-
- Propose acceptance criteria if missing; get confirmation.
|
|
20
|
-
- Identify dependencies/risks early (APIs, migrations, permissions, rollout).
|
|
21
|
-
|
|
@@ -1,21 +0,0 @@
|
|
|
1
|
-
# Phase: Implement
|
|
2
|
-
|
|
3
|
-
Goal: make the change in code, with tests and minimal risk.
|
|
4
|
-
|
|
5
|
-
## Inputs
|
|
6
|
-
|
|
7
|
-
- Approved plan
|
|
8
|
-
- Acceptance criteria
|
|
9
|
-
|
|
10
|
-
## Outputs (minimum)
|
|
11
|
-
|
|
12
|
-
- Code changes
|
|
13
|
-
- Tests (or explicit justification if not added)
|
|
14
|
-
- Verification evidence (commands run, expected outputs)
|
|
15
|
-
|
|
16
|
-
## Agent checklist
|
|
17
|
-
|
|
18
|
-
- Implement in small diffs; keep changes scoped.
|
|
19
|
-
- Run the project’s standard checks (lint/typecheck/test/build) when applicable.
|
|
20
|
-
- Call out any behavior changes and migrations.
|
|
21
|
-
|
|
@@ -1,20 +0,0 @@
|
|
|
1
|
-
# Phase: Review
|
|
2
|
-
|
|
3
|
-
Goal: validate correctness, quality, and alignment with requirements.
|
|
4
|
-
|
|
5
|
-
## Inputs
|
|
6
|
-
|
|
7
|
-
- Implemented changes
|
|
8
|
-
- Acceptance criteria
|
|
9
|
-
|
|
10
|
-
## Outputs (minimum)
|
|
11
|
-
|
|
12
|
-
- Review notes (bugs, risks, missing tests)
|
|
13
|
-
- Decision: approve or request changes
|
|
14
|
-
|
|
15
|
-
## Agent checklist
|
|
16
|
-
|
|
17
|
-
- Prioritize correctness and regressions over style.
|
|
18
|
-
- Ensure acceptance criteria is demonstrably met.
|
|
19
|
-
- If changes are requested, be explicit about what must change and why.
|
|
20
|
-
|