@loopback/example-validation-app 7.0.2 → 7.0.4

package/CHANGELOG.md

@@ -3,6 +3,27 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.0.4](https://github.com/loopbackio/loopback-next/compare/@loopback/example-validation-app@7.0.3...@loopback/example-validation-app@7.0.4) (2025-08-11)
+
+**Note:** Version bump only for package @loopback/example-validation-app
+
+
+
+
+
+## [7.0.3](https://github.com/loopbackio/loopback-next/compare/@loopback/example-validation-app@7.0.2...@loopback/example-validation-app@7.0.3) (2025-07-15)
+
+
+### Bug Fixes
+
+* adding tests and comments illustrating the discriminator bug issue ([82a33cc](https://github.com/loopbackio/loopback-next/commit/82a33cc840266c1707f73a1b3e71a0224e456f26))
+* illustrate the discriminator bug and fix in loopback rest request-body-validator ([9fa3593](https://github.com/loopbackio/loopback-next/commit/9fa35934b067ae804e3cd19c06b9d290571da798))
+* removal of comments and implementation of bug fix ([f0da7dd](https://github.com/loopbackio/loopback-next/commit/f0da7dd6fdf119a4ce0e083997c4d5bdad3a0b9c))
+
+
+
+
+
 ## [7.0.2](https://github.com/loopbackio/loopback-next/compare/@loopback/example-validation-app@7.0.1...@loopback/example-validation-app@7.0.2) (2025-06-12)
 
 **Note:** Version bump only for package @loopback/example-validation-app

package/dist/__tests__/acceptance/validate-discriminator.acceptance.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/__tests__/acceptance/validate-discriminator.acceptance.js

@@ -0,0 +1,78 @@
+"use strict";
+// Copyright IBM Corp. and LoopBack contributors 2020. All Rights Reserved.
+// Node module: @loopback/example-validation-app
+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+Object.defineProperty(exports, "__esModule", { value: true });
+const testlab_1 = require("@loopback/testlab");
+const test_helper_1 = require("./test-helper");
+const validCat = {
+    name: 'Kitty',
+    weight: 5,
+    kind: 'Cat',
+    animalProperties: {
+        color: 'grey',
+        whiskerLength: 2,
+    },
+};
+const validDog = {
+    name: 'Rex',
+    weight: 5,
+    kind: 'Dog',
+    animalProperties: {
+        breed: 'poodle',
+        barkVolume: 5,
+    },
+};
+describe('validate properties based on discriminated schemas', () => {
+    let client;
+    let app;
+    before(givenAClient);
+    after(async () => {
+        await app.stop();
+    });
+    async function givenAClient() {
+        ({ app, client } = await (0, test_helper_1.setupApplication)());
+    }
+    it('should pass with valid cat properties', async () => {
+        await client.post('/pets').send(validCat).expect(200);
+    });
+    it('should pass with valid dog properties', async () => {
+        await client.post('/pets').send(validDog).expect(200);
+    });
+    it('should fail with error indicating invalid barkVolume type', async () => {
+        const invalidDog = { ...validDog };
+        invalidDog.animalProperties.barkVolume = 'loud';
+        const response = await client.post('/pets').send(invalidDog).expect(422);
+        (0, testlab_1.expect)(response.body.error.details.length).to.equal(1);
+        (0, testlab_1.expect)(response.body.error.details[0].message).to.equal('must be number');
+        (0, testlab_1.expect)(response.body.error.details).to.deepEqual([
+            {
+                code: 'type',
+                info: {
+                    type: 'number',
+                },
+                message: 'must be number',
+                path: '/animalProperties/barkVolume',
+            },
+        ]);
+    });
+    it('should fail with error indicating invalid whiskerLength type', async () => {
+        const invalidCat = { ...validCat };
+        invalidCat.animalProperties.whiskerLength = 'long';
+        const response = await client.post('/pets').send(invalidCat).expect(422);
+        (0, testlab_1.expect)(response.body.error.details.length).to.equal(1);
+        (0, testlab_1.expect)(response.body.error.details[0].message).to.equal('must be number');
+        (0, testlab_1.expect)(response.body.error.details).to.deepEqual([
+            {
+                code: 'type',
+                info: {
+                    type: 'number',
+                },
+                message: 'must be number',
+                path: '/animalProperties/whiskerLength',
+            },
+        ]);
+    });
+});
+//# sourceMappingURL=validate-discriminator.acceptance.js.map

package/dist/__tests__/acceptance/validate-discriminator.acceptance.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"validate-discriminator.acceptance.js","sourceRoot":"","sources":["../../../src/__tests__/acceptance/validate-discriminator.acceptance.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;AAEhE,+CAAiD;AAEjD,+CAA+C;AAE/C,MAAM,QAAQ,GAAG;IACf,IAAI,EAAE,OAAO;IACb,MAAM,EAAE,CAAC;IACT,IAAI,EAAE,KAAK;IACX,gBAAgB,EAAE;QAChB,KAAK,EAAE,MAAM;QACb,aAAa,EAAE,CAAC;KACjB;CACF,CAAC;AAEF,MAAM,QAAQ,GAAG;IACf,IAAI,EAAE,KAAK;IACX,MAAM,EAAE,CAAC;IACT,IAAI,EAAE,KAAK;IACX,gBAAgB,EAAE;QAChB,KAAK,EAAE,QAAQ;QACf,UAAU,EAAE,CAAC;KACd;CACF,CAAC;AAEF,QAAQ,CAAC,oDAAoD,EAAE,GAAG,EAAE;IAClE,IAAI,MAAc,CAAC;IACnB,IAAI,GAA0B,CAAC;IAE/B,MAAM,CAAC,YAAY,CAAC,CAAC;IAErB,KAAK,CAAC,KAAK,IAAI,EAAE;QACf,MAAM,GAAG,CAAC,IAAI,EAAE,CAAC;IACnB,CAAC,CAAC,CAAC;IAEH,KAAK,UAAU,YAAY;QACzB,CAAC,EAAC,GAAG,EAAE,MAAM,EAAC,GAAG,MAAM,IAAA,8BAAgB,GAAE,CAAC,CAAC;IAC7C,CAAC;IAED,EAAE,CAAC,uCAAuC,EAAE,KAAK,IAAI,EAAE;QACrD,MAAM,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;IACxD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uCAAuC,EAAE,KAAK,IAAI,EAAE;QACrD,MAAM,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;IACxD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2DAA2D,EAAE,KAAK,IAAI,EAAE;QACzE,MAAM,UAAU,GAAG,EAAC,GAAG,QAAQ,EAAC,CAAC;QACjC,UAAU,CAAC,gBAAgB,CAAC,UAAU,GAAG,MAA2B,CAAC;QACrE,MAAM,QAAQ,GAAG,MAAM,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QAEzE,IAAA,gBAAM,EAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;QACvD,IAAA,gBAAM,EAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;QAC1E,IAAA,gBAAM,EAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,SAAS,CAAC;YAC/C;gBACE,IAAI,EAAE,MAAM;gBACZ,IAAI,EAAE;oBACJ,IAAI,EAAE,QAAQ;iBACf;gBACD,OAAO,EAAE,gBAAgB;gBACzB,IAAI,EAAE,8BAA8B;aACrC;SACF,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,KAAK,IAAI,EAAE;QAC5E,MAAM,UAAU,GAAG,EAAC,GAAG,QAAQ,EAAC,CAAC;QACjC,UAAU,CAAC,gBAAgB,CAAC,aAAa,GAAG,MAA2B,CAAC;QACxE,MAAM,QAAQ,GAAG,MAAM,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QAEzE,IAAA,gBAAM,EAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;QACvD,IAAA,gBAAM,EAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;QAC1E,IAAA,gBAAM,EAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,SAAS,CAAC;YAC/C;gBACE,IAAI,EAAE,MAAM;gBACZ,IAAI,EAAE;oBACJ,IAAI,EAAE,QAAQ;iBACf;gBACD,OAAO,EAAE,gBAAgB;gBACzB,IAAI,EAAE,iCAAiC;aACxC;SACF,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/application.js

@@ -23,6 +23,11 @@ class ValidationApplication extends (0, boot_1.BootMixin)((0, service_proxy_1.Se
         this.sequence(sequence_1.MySequence);
         // Set up default home page
         this.static('/', path_1.default.join(__dirname, '../public'));
+        this.bind(rest_1.RestBindings.REQUEST_BODY_PARSER_OPTIONS).to({
+            validation: {
+                discriminator: true,
+            },
+        });
         // Customize @loopback/rest-explorer configuration here
         this.configure(rest_explorer_1.RestExplorerBindings.COMPONENT).to({
             path: '/explorer',

package/dist/application.js.map

@@ -1 +1 @@
-{"version":3,"file":"application.js","sourceRoot":"","sources":["../src/application.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;;;AAEhE,yCAAyC;AACzC,yCAAyE;AACzE,qDAAqD;AACrD,yCAA+C;AAC/C,2DAGiC;AACjC,2DAAqD;AACrD,wDAAwB;AACxB,0FAA2F;AAC3F,yCAAsC;AAItC,MAAa,qBAAsB,SAAQ,IAAA,gBAAS,EAClD,IAAA,4BAAY,EAAC,IAAA,4BAAe,EAAC,sBAAe,CAAC,CAAC,CAC/C;IACC,YAAY,UAA6B,EAAE;QACzC,KAAK,CAAC,OAAO,CAAC,CAAC;QAEf,IAAI,CAAC,GAAG,CAAC,IAAA,6BAAsB,EAAC,+DAAiC,CAAC,CAAC,CAAC;QAEpE,6BAA6B;QAC7B,IAAI,CAAC,QAAQ,CAAC,qBAAU,CAAC,CAAC;QAE1B,2BAA2B;QAC3B,IAAI,CAAC,MAAM,CAAC,GAAG,EAAE,cAAI,CAAC,IAAI,CAAC,SAAS,EAAE,WAAW,CAAC,CAAC,CAAC;QAEpD,uDAAuD;QACvD,IAAI,CAAC,SAAS,CAAC,oCAAoB,CAAC,SAAS,CAAC,CAAC,EAAE,CAAC;YAChD,IAAI,EAAE,WAAW;SAClB,CAAC,CAAC;QACH,IAAI,CAAC,SAAS,CAAC,qCAAqB,CAAC,CAAC;QAEtC,IAAI,CAAC,WAAW,GAAG,SAAS,CAAC;QAC7B,mDAAmD;QACnD,IAAI,CAAC,WAAW,GAAG;YACjB,WAAW,EAAE;gBACX,8CAA8C;gBAC9C,IAAI,EAAE,CAAC,aAAa,CAAC;gBACrB,UAAU,EAAE,CAAC,gBAAgB,CAAC;gBAC9B,MAAM,EAAE,IAAI;aACb;SACF,CAAC;IACJ,CAAC;CACF;AA/BD,sDA+BC"}
+{"version":3,"file":"application.js","sourceRoot":"","sources":["../src/application.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;;;AAEhE,yCAAyC;AACzC,yCAAyE;AACzE,qDAAqD;AACrD,yCAA6D;AAC7D,2DAGiC;AACjC,2DAAqD;AACrD,wDAAwB;AACxB,0FAA2F;AAC3F,yCAAsC;AAItC,MAAa,qBAAsB,SAAQ,IAAA,gBAAS,EAClD,IAAA,4BAAY,EAAC,IAAA,4BAAe,EAAC,sBAAe,CAAC,CAAC,CAC/C;IACC,YAAY,UAA6B,EAAE;QACzC,KAAK,CAAC,OAAO,CAAC,CAAC;QAEf,IAAI,CAAC,GAAG,CAAC,IAAA,6BAAsB,EAAC,+DAAiC,CAAC,CAAC,CAAC;QAEpE,6BAA6B;QAC7B,IAAI,CAAC,QAAQ,CAAC,qBAAU,CAAC,CAAC;QAE1B,2BAA2B;QAC3B,IAAI,CAAC,MAAM,CAAC,GAAG,EAAE,cAAI,CAAC,IAAI,CAAC,SAAS,EAAE,WAAW,CAAC,CAAC,CAAC;QAEpD,IAAI,CAAC,IAAI,CAAC,mBAAY,CAAC,2BAA2B,CAAC,CAAC,EAAE,CAAC;YACrD,UAAU,EAAE;gBACV,aAAa,EAAE,IAAI;aACpB;SACF,CAAC,CAAC;QAEH,uDAAuD;QACvD,IAAI,CAAC,SAAS,CAAC,oCAAoB,CAAC,SAAS,CAAC,CAAC,EAAE,CAAC;YAChD,IAAI,EAAE,WAAW;SAClB,CAAC,CAAC;QACH,IAAI,CAAC,SAAS,CAAC,qCAAqB,CAAC,CAAC;QAEtC,IAAI,CAAC,WAAW,GAAG,SAAS,CAAC;QAC7B,mDAAmD;QACnD,IAAI,CAAC,WAAW,GAAG;YACjB,WAAW,EAAE;gBACX,8CAA8C;gBAC9C,IAAI,EAAE,CAAC,aAAa,CAAC;gBACrB,UAAU,EAAE,CAAC,gBAAgB,CAAC;gBAC9B,MAAM,EAAE,IAAI;aACb;SACF,CAAC;IACJ,CAAC;CACF;AArCD,sDAqCC"}

package/dist/controllers/index.d.ts

@@ -1 +1,2 @@
 export * from './coffee-shop.controller';
+export * from './pet.controller';

package/dist/controllers/index.js

@@ -6,4 +6,5 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const tslib_1 = require("tslib");
 tslib_1.__exportStar(require("./coffee-shop.controller"), exports);
+tslib_1.__exportStar(require("./pet.controller"), exports);
 //# sourceMappingURL=index.js.map

package/dist/controllers/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/controllers/index.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;;AAEhE,mEAAyC"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/controllers/index.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;;AAEhE,mEAAyC;AACzC,2DAAiC"}

package/dist/controllers/pet.controller.d.ts

@@ -0,0 +1,5 @@
+import { Pet } from '../models';
+export declare class PetController {
+    constructor();
+    create(request: Pet): Promise<Pet>;
+}

package/dist/controllers/pet.controller.js

@@ -0,0 +1,36 @@
+"use strict";
+// Copyright IBM Corp. and LoopBack contributors 2020. All Rights Reserved.
+// Node module: @loopback/example-validation-app
+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.PetController = void 0;
+const tslib_1 = require("tslib");
+const rest_1 = require("@loopback/rest");
+const models_1 = require("../models");
+class PetController {
+    constructor() { }
+    async create(request) {
+        return request;
+    }
+}
+exports.PetController = PetController;
+tslib_1.__decorate([
+    (0, rest_1.post)('/pets'),
+    tslib_1.__param(0, (0, rest_1.requestBody)({
+        content: {
+            'application/json': {
+                schema: {
+                    discriminator: {
+                        propertyName: 'kind',
+                    },
+                    oneOf: [{ 'x-ts-type': models_1.Cat }, { 'x-ts-type': models_1.Dog }],
+                },
+            },
+        },
+    })),
+    tslib_1.__metadata("design:type", Function),
+    tslib_1.__metadata("design:paramtypes", [models_1.Pet]),
+    tslib_1.__metadata("design:returntype", Promise)
+], PetController.prototype, "create", null);
+//# sourceMappingURL=pet.controller.js.map

package/dist/controllers/pet.controller.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pet.controller.js","sourceRoot":"","sources":["../../src/controllers/pet.controller.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;;;AAEhE,yCAAiD;AACjD,sCAAwC;AAExC,MAAa,aAAa;IACxB,gBAAe,CAAC;IAGV,AAAN,KAAK,CAAC,MAAM,CAaV,OAAY;QAEZ,OAAO,OAAO,CAAC;IACjB,CAAC;CACF;AArBD,sCAqBC;AAjBO;IADL,IAAA,WAAI,EAAC,OAAO,CAAC;IAEX,mBAAA,IAAA,kBAAW,EAAC;QACX,OAAO,EAAE;YACP,kBAAkB,EAAE;gBAClB,MAAM,EAAE;oBACN,aAAa,EAAE;wBACb,YAAY,EAAE,MAAM;qBACrB;oBACD,KAAK,EAAE,CAAC,EAAC,WAAW,EAAE,YAAG,EAAC,EAAE,EAAC,WAAW,EAAE,YAAG,EAAC,CAAC;iBAChD;aACF;SACF;KACF,CAAC,CAAA;;6CACO,YAAG;;2CAGb"}

package/dist/middleware/validation-error.middleware.js

@@ -34,7 +34,8 @@ let ValidationErrorMiddlewareProvider = class ValidationErrorMiddlewareProvider
     handleError(context, err) {
         var _a;
         // 2. customize error for particular endpoint
-        if (context.request.url === '/coffee-shops') {
+        if (context.request.url === '/coffee-shops' ||
+            context.request.url === '/pets') {
             // if this is a validation error from the PATCH method, customize it
             // for other validation errors, the default AJV error object will be sent
             if (err.statusCode === 422 && context.request.method === 'PATCH') {

package/dist/middleware/validation-error.middleware.js.map

@@ -1 +1 @@
-{"version":3,"file":"validation-error.middleware.js","sourceRoot":"","sources":["../../src/middleware/validation-error.middleware.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;;;AAEhE,yCAA4D;AAC5D,yCAUwB;AASjB,IAAM,iCAAiC,GAAvC,MAAM,iCAAiC;IAC5C,YAEY,QAAkB,EAElB,kBAAuC;QAFvC,aAAQ,GAAR,QAAQ,CAAU;QAElB,uBAAkB,GAAlB,kBAAkB,CAAqB;IAChD,CAAC;IAEJ,KAAK,CAAC,KAAK;QACT,MAAM,UAAU,GAAe,KAAK,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE;YACjD,IAAI;gBACF,MAAM,MAAM,GAAG,MAAM,IAAI,EAAE,CAAC;gBAC5B,OAAO,MAAM,CAAC;aACf;YAAC,OAAO,GAAG,EAAE;gBACZ,OAAO,IAAI,CAAC,WAAW,CAAC,GAAG,EAAE,GAAG,CAAC,CAAC;aACnC;QACH,CAAC,CAAC;QACF,OAAO,UAAU,CAAC;IACpB,CAAC;IAED;;;;;OAKG;IACH,WAAW,CACT,OAA0B,EAC1B,GAAyB;;QAEzB,6CAA6C;QAC7C,IAAI,OAAO,CAAC,OAAO,CAAC,GAAG,KAAK,eAAe,EAAE;YAC3C,oEAAoE;YACpE,yEAAyE;YACzE,IAAI,GAAG,CAAC,UAAU,KAAK,GAAG,IAAI,OAAO,CAAC,OAAO,CAAC,MAAM,KAAK,OAAO,EAAE;gBAChE,MAAM,iBAAiB,GAAG,wCAAwC,CAAC;gBAEnE,IAAI,eAAe,GAAG,EAAE,CAAC;gBACzB,IAAI,MAAA,IAAI,CAAC,kBAAkB,0CAAE,KAAK,EAAE;oBAClC,eAAe,GAAG,EAAC,KAAK,EAAE,GAAG,CAAC,KAAK,EAAC,CAAC;iBACtC;gBAED,mDAAmD;gBACnD,0CAA0C;gBAC1C,MAAM,SAAS,GAAG;oBAChB,UAAU,EAAE,GAAG;oBACf,OAAO,EAAE,iBAAiB;oBAC1B,UAAU,EAAE,yCAAyC;oBACrD,IAAI,EAAE,mBAAmB;oBACzB,GAAG,eAAe;iBACnB,CAAC;gBAEF,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;gBAE7C,gEAAgE;gBAChE,IAAI,CAAC,QAAQ,CAAC,GAAG,EAAE,GAAG,CAAC,UAAU,EAAE,OAAO,CAAC,OAAO,CAAC,CAAC;gBAEpD,wBAAwB;gBACxB,OAAO,OAAO,CAAC,QAAQ,CAAC;aACzB;iBAAM;gBACL,MAAM,GAAG,CAAC;aACX;SACF;IACH,CAAC;CACF,CAAA;AAhEY,8EAAiC;4CAAjC,iCAAiC;IAP7C,IAAA,iBAAU,EACT,IAAA,mBAAY,EAAC;QACX,KAAK,EAAE,iBAAiB;QACxB,cAAc,EAAE,2BAAoB,CAAC,aAAa;QAClD,gBAAgB,EAAE,2BAAoB,CAAC,IAAI;KAC5C,CAAC,CACH;IAGI,mBAAA,IAAA,aAAM,EAAC,mBAAY,CAAC,eAAe,CAAC,SAAS,CAAC,CAAA;IAE9C,mBAAA,IAAA,aAAM,EAAC,mBAAY,CAAC,oBAAoB,EAAE,EAAC,QAAQ,EAAE,IAAI,EAAC,CAAC,CAAA;;GAJnD,iCAAiC,CAgE7C"}
+{"version":3,"file":"validation-error.middleware.js","sourceRoot":"","sources":["../../src/middleware/validation-error.middleware.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;;;AAEhE,yCAA4D;AAC5D,yCAUwB;AASjB,IAAM,iCAAiC,GAAvC,MAAM,iCAAiC;IAC5C,YAEY,QAAkB,EAElB,kBAAuC;QAFvC,aAAQ,GAAR,QAAQ,CAAU;QAElB,uBAAkB,GAAlB,kBAAkB,CAAqB;IAChD,CAAC;IAEJ,KAAK,CAAC,KAAK;QACT,MAAM,UAAU,GAAe,KAAK,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE;YACjD,IAAI;gBACF,MAAM,MAAM,GAAG,MAAM,IAAI,EAAE,CAAC;gBAC5B,OAAO,MAAM,CAAC;aACf;YAAC,OAAO,GAAG,EAAE;gBACZ,OAAO,IAAI,CAAC,WAAW,CAAC,GAAG,EAAE,GAAG,CAAC,CAAC;aACnC;QACH,CAAC,CAAC;QACF,OAAO,UAAU,CAAC;IACpB,CAAC;IAED;;;;;OAKG;IACH,WAAW,CACT,OAA0B,EAC1B,GAAyB;;QAEzB,6CAA6C;QAC7C,IACE,OAAO,CAAC,OAAO,CAAC,GAAG,KAAK,eAAe;YACvC,OAAO,CAAC,OAAO,CAAC,GAAG,KAAK,OAAO,EAC/B;YACA,oEAAoE;YACpE,yEAAyE;YACzE,IAAI,GAAG,CAAC,UAAU,KAAK,GAAG,IAAI,OAAO,CAAC,OAAO,CAAC,MAAM,KAAK,OAAO,EAAE;gBAChE,MAAM,iBAAiB,GAAG,wCAAwC,CAAC;gBAEnE,IAAI,eAAe,GAAG,EAAE,CAAC;gBACzB,IAAI,MAAA,IAAI,CAAC,kBAAkB,0CAAE,KAAK,EAAE;oBAClC,eAAe,GAAG,EAAC,KAAK,EAAE,GAAG,CAAC,KAAK,EAAC,CAAC;iBACtC;gBAED,mDAAmD;gBACnD,0CAA0C;gBAC1C,MAAM,SAAS,GAAG;oBAChB,UAAU,EAAE,GAAG;oBACf,OAAO,EAAE,iBAAiB;oBAC1B,UAAU,EAAE,yCAAyC;oBACrD,IAAI,EAAE,mBAAmB;oBACzB,GAAG,eAAe;iBACnB,CAAC;gBAEF,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;gBAE7C,gEAAgE;gBAChE,IAAI,CAAC,QAAQ,CAAC,GAAG,EAAE,GAAG,CAAC,UAAU,EAAE,OAAO,CAAC,OAAO,CAAC,CAAC;gBAEpD,wBAAwB;gBACxB,OAAO,OAAO,CAAC,QAAQ,CAAC;aACzB;iBAAM;gBACL,MAAM,GAAG,CAAC;aACX;SACF;IACH,CAAC;CACF,CAAA;AAnEY,8EAAiC;4CAAjC,iCAAiC;IAP7C,IAAA,iBAAU,EACT,IAAA,mBAAY,EAAC;QACX,KAAK,EAAE,iBAAiB;QACxB,cAAc,EAAE,2BAAoB,CAAC,aAAa;QAClD,gBAAgB,EAAE,2BAAoB,CAAC,IAAI;KAC5C,CAAC,CACH;IAGI,mBAAA,IAAA,aAAM,EAAC,mBAAY,CAAC,eAAe,CAAC,SAAS,CAAC,CAAA;IAE9C,mBAAA,IAAA,aAAM,EAAC,mBAAY,CAAC,oBAAoB,EAAE,EAAC,QAAQ,EAAE,IAAI,EAAC,CAAC,CAAA;;GAJnD,iCAAiC,CAmE7C"}

package/dist/models/index.d.ts

@@ -1 +1,2 @@
 export * from './coffee-shop.model';
+export * from './pet.model';

package/dist/models/index.js

@@ -6,4 +6,5 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const tslib_1 = require("tslib");
 tslib_1.__exportStar(require("./coffee-shop.model"), exports);
+tslib_1.__exportStar(require("./pet.model"), exports);
 //# sourceMappingURL=index.js.map

package/dist/models/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/models/index.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;;AAEhE,8DAAoC"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/models/index.ts"],"names":[],"mappings":";AAAA,2EAA2E;AAC3E,gDAAgD;AAChD,+CAA+C;AAC/C,gEAAgE;;;AAEhE,8DAAoC;AACpC,sDAA4B"}

package/dist/models/pet.model.d.ts

@@ -0,0 +1,23 @@
+import { Model } from '@loopback/repository';
+export declare class CatProperties extends Model {
+    color: string;
+    whiskerLength: number;
+}
+export declare class DogProperties extends Model {
+    breed: string;
+    barkVolume: number;
+}
+export declare class Pet extends Model {
+    name: string;
+    weight?: number;
+    kind: string;
+    animalProperties: CatProperties | DogProperties;
+}
+export declare class Dog extends Pet {
+    kind: string;
+    animalProperties: DogProperties;
+}
+export declare class Cat extends Pet {
+    kind: string;
+    animalProperties: CatProperties;
+}

package/dist/models/pet.model.js

@@ -0,0 +1,112 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.Cat = exports.Dog = exports.Pet = exports.DogProperties = exports.CatProperties = void 0;
+const tslib_1 = require("tslib");
+const repository_1 = require("@loopback/repository");
+let CatProperties = class CatProperties extends repository_1.Model {
+};
+exports.CatProperties = CatProperties;
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: String,
+        required: true,
+    }),
+    tslib_1.__metadata("design:type", String)
+], CatProperties.prototype, "color", void 0);
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: Number,
+        required: true,
+    }),
+    tslib_1.__metadata("design:type", Number)
+], CatProperties.prototype, "whiskerLength", void 0);
+exports.CatProperties = CatProperties = tslib_1.__decorate([
+    (0, repository_1.model)()
+], CatProperties);
+let DogProperties = class DogProperties extends repository_1.Model {
+};
+exports.DogProperties = DogProperties;
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: String,
+        required: true,
+    }),
+    tslib_1.__metadata("design:type", String)
+], DogProperties.prototype, "breed", void 0);
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: Number,
+        required: true,
+    }),
+    tslib_1.__metadata("design:type", Number)
+], DogProperties.prototype, "barkVolume", void 0);
+exports.DogProperties = DogProperties = tslib_1.__decorate([
+    (0, repository_1.model)()
+], DogProperties);
+let Pet = class Pet extends repository_1.Model {
+};
+exports.Pet = Pet;
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: String,
+        required: true,
+    }),
+    tslib_1.__metadata("design:type", String)
+], Pet.prototype, "name", void 0);
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: Number,
+        required: false,
+    }),
+    tslib_1.__metadata("design:type", Number)
+], Pet.prototype, "weight", void 0);
+exports.Pet = Pet = tslib_1.__decorate([
+    (0, repository_1.model)()
+], Pet);
+let Dog = class Dog extends Pet {
+};
+exports.Dog = Dog;
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: String,
+        jsonSchema: {
+            enum: ['Dog'],
+        },
+        required: true,
+    }),
+    tslib_1.__metadata("design:type", String)
+], Dog.prototype, "kind", void 0);
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: DogProperties,
+        required: true,
+    }),
+    tslib_1.__metadata("design:type", DogProperties)
+], Dog.prototype, "animalProperties", void 0);
+exports.Dog = Dog = tslib_1.__decorate([
+    (0, repository_1.model)()
+], Dog);
+let Cat = class Cat extends Pet {
+};
+exports.Cat = Cat;
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: String,
+        jsonSchema: {
+            enum: ['Cat'],
+        },
+        required: true,
+    }),
+    tslib_1.__metadata("design:type", String)
+], Cat.prototype, "kind", void 0);
+tslib_1.__decorate([
+    (0, repository_1.property)({
+        type: CatProperties,
+        required: true,
+    }),
+    tslib_1.__metadata("design:type", CatProperties)
+], Cat.prototype, "animalProperties", void 0);
+exports.Cat = Cat = tslib_1.__decorate([
+    (0, repository_1.model)()
+], Cat);
+//# sourceMappingURL=pet.model.js.map

package/dist/models/pet.model.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pet.model.js","sourceRoot":"","sources":["../../src/models/pet.model.ts"],"names":[],"mappings":";;;;AAAA,qDAA4D;AAGrD,IAAM,aAAa,GAAnB,MAAM,aAAc,SAAQ,kBAAK;CAYvC,CAAA;AAZY,sCAAa;AAKxB;IAJC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,MAAM;QACZ,QAAQ,EAAE,IAAI;KACf,CAAC;;4CACY;AAMd;IAJC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,MAAM;QACZ,QAAQ,EAAE,IAAI;KACf,CAAC;;oDACoB;wBAXX,aAAa;IADzB,IAAA,kBAAK,GAAE;GACK,aAAa,CAYzB;AAGM,IAAM,aAAa,GAAnB,MAAM,aAAc,SAAQ,kBAAK;CAYvC,CAAA;AAZY,sCAAa;AAKxB;IAJC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,MAAM;QACZ,QAAQ,EAAE,IAAI;KACf,CAAC;;4CACY;AAMd;IAJC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,MAAM;QACZ,QAAQ,EAAE,IAAI;KACf,CAAC;;iDACiB;wBAXR,aAAa;IADzB,IAAA,kBAAK,GAAE;GACK,aAAa,CAYzB;AAGM,IAAM,GAAG,GAAT,MAAM,GAAI,SAAQ,kBAAK;CAgB7B,CAAA;AAhBY,kBAAG;AAKd;IAJC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,MAAM;QACZ,QAAQ,EAAE,IAAI;KACf,CAAC;;iCACW;AAMb;IAJC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,MAAM;QACZ,QAAQ,EAAE,KAAK;KAChB,CAAC;;mCACc;cAXL,GAAG;IADf,IAAA,kBAAK,GAAE;GACK,GAAG,CAgBf;AAGM,IAAM,GAAG,GAAT,MAAM,GAAI,SAAQ,GAAG;CAe3B,CAAA;AAfY,kBAAG;AAQd;IAPC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,MAAM;QACZ,UAAU,EAAE;YACV,IAAI,EAAE,CAAC,KAAK,CAAC;SACd;QACD,QAAQ,EAAE,IAAI;KACf,CAAC;;iCACW;AAMb;IAJC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,aAAa;QACnB,QAAQ,EAAE,IAAI;KACf,CAAC;sCACgB,aAAa;6CAAC;cAdrB,GAAG;IADf,IAAA,kBAAK,GAAE;GACK,GAAG,CAef;AAGM,IAAM,GAAG,GAAT,MAAM,GAAI,SAAQ,GAAG;CAe3B,CAAA;AAfY,kBAAG;AAQd;IAPC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,MAAM;QACZ,UAAU,EAAE;YACV,IAAI,EAAE,CAAC,KAAK,CAAC;SACd;QACD,QAAQ,EAAE,IAAI;KACf,CAAC;;iCACW;AAMb;IAJC,IAAA,qBAAQ,EAAC;QACR,IAAI,EAAE,aAAa;QACnB,QAAQ,EAAE,IAAI;KACf,CAAC;sCACgB,aAAa;6CAAC;cAdrB,GAAG;IADf,IAAA,kBAAK,GAAE;GACK,GAAG,CAef"}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@loopback/example-validation-app",
   "description": "An example demonstrating how to add validation in a LoopBack 4 application",
-  "version": "7.0.2",
+  "version": "7.0.4",
   "keywords": [
     "loopback",
     "LoopBack",
@@ -50,23 +50,23 @@
     "access": "public"
   },
   "dependencies": {
-    "@loopback/boot": "^8.0.2",
-    "@loopback/core": "^7.0.1",
-    "@loopback/repository": "^8.0.1",
-    "@loopback/rest": "^15.0.2",
-    "@loopback/rest-explorer": "^8.0.2",
-    "@loopback/service-proxy": "^8.0.1",
-    "strong-error-handler": "^5.0.20",
+    "@loopback/boot": "^8.0.4",
+    "@loopback/core": "^7.0.3",
+    "@loopback/repository": "^8.0.3",
+    "@loopback/rest": "^15.0.4",
+    "@loopback/rest-explorer": "^8.0.4",
+    "@loopback/service-proxy": "^8.0.3",
+    "strong-error-handler": "^5.0.22",
     "tslib": "^2.8.1"
   },
   "devDependencies": {
-    "@loopback/build": "^12.0.1",
-    "@loopback/eslint-config": "^16.0.0",
-    "@loopback/testlab": "^8.0.1",
+    "@loopback/build": "^12.0.3",
+    "@loopback/eslint-config": "^16.0.1",
+    "@loopback/testlab": "^8.0.3",
     "@types/node": "^16.18.126",
     "eslint": "^8.57.1",
     "source-map-support": "^0.5.21",
     "typescript": "~5.2.2"
   },
-  "gitHead": "996458bc9c8f2f8ac8958987df00db1842b46223"
+  "gitHead": "292b33022f1d9eb85ded26e7b07a3d7a47d3b2e8"
 }

package/src/__tests__/acceptance/validate-discriminator.acceptance.ts

@@ -0,0 +1,89 @@
+// Copyright IBM Corp. and LoopBack contributors 2020. All Rights Reserved.
+// Node module: @loopback/example-validation-app
+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+
+import {Client, expect} from '@loopback/testlab';
+import {ValidationApplication} from '../..';
+import {setupApplication} from './test-helper';
+
+const validCat = {
+  name: 'Kitty',
+  weight: 5,
+  kind: 'Cat',
+  animalProperties: {
+    color: 'grey',
+    whiskerLength: 2,
+  },
+};
+
+const validDog = {
+  name: 'Rex',
+  weight: 5,
+  kind: 'Dog',
+  animalProperties: {
+    breed: 'poodle',
+    barkVolume: 5,
+  },
+};
+
+describe('validate properties based on discriminated schemas', () => {
+  let client: Client;
+  let app: ValidationApplication;
+
+  before(givenAClient);
+
+  after(async () => {
+    await app.stop();
+  });
+
+  async function givenAClient() {
+    ({app, client} = await setupApplication());
+  }
+
+  it('should pass with valid cat properties', async () => {
+    await client.post('/pets').send(validCat).expect(200);
+  });
+
+  it('should pass with valid dog properties', async () => {
+    await client.post('/pets').send(validDog).expect(200);
+  });
+
+  it('should fail with error indicating invalid barkVolume type', async () => {
+    const invalidDog = {...validDog};
+    invalidDog.animalProperties.barkVolume = 'loud' as unknown as number;
+    const response = await client.post('/pets').send(invalidDog).expect(422);
+
+    expect(response.body.error.details.length).to.equal(1);
+    expect(response.body.error.details[0].message).to.equal('must be number');
+    expect(response.body.error.details).to.deepEqual([
+      {
+        code: 'type',
+        info: {
+          type: 'number',
+        },
+        message: 'must be number',
+        path: '/animalProperties/barkVolume',
+      },
+    ]);
+  });
+
+  it('should fail with error indicating invalid whiskerLength type', async () => {
+    const invalidCat = {...validCat};
+    invalidCat.animalProperties.whiskerLength = 'long' as unknown as number;
+    const response = await client.post('/pets').send(invalidCat).expect(422);
+
+    expect(response.body.error.details.length).to.equal(1);
+    expect(response.body.error.details[0].message).to.equal('must be number');
+    expect(response.body.error.details).to.deepEqual([
+      {
+        code: 'type',
+        info: {
+          type: 'number',
+        },
+        message: 'must be number',
+        path: '/animalProperties/whiskerLength',
+      },
+    ]);
+  });
+});

package/src/application.ts

@@ -6,7 +6,7 @@
 import {BootMixin} from '@loopback/boot';
 import {ApplicationConfig, createBindingFromClass} from '@loopback/core';
 import {RepositoryMixin} from '@loopback/repository';
-import {RestApplication} from '@loopback/rest';
+import {RestApplication, RestBindings} from '@loopback/rest';
 import {
   RestExplorerBindings,
   RestExplorerComponent,
@@ -32,6 +32,12 @@ export class ValidationApplication extends BootMixin(
     // Set up default home page
     this.static('/', path.join(__dirname, '../public'));
 
+    this.bind(RestBindings.REQUEST_BODY_PARSER_OPTIONS).to({
+      validation: {
+        discriminator: true,
+      },
+    });
+
     // Customize @loopback/rest-explorer configuration here
     this.configure(RestExplorerBindings.COMPONENT).to({
       path: '/explorer',

package/src/controllers/index.ts

@@ -4,3 +4,4 @@
 // License text available at https://opensource.org/licenses/MIT
 
 export * from './coffee-shop.controller';
+export * from './pet.controller';

package/src/controllers/pet.controller.ts

@@ -0,0 +1,30 @@
+// Copyright IBM Corp. and LoopBack contributors 2020. All Rights Reserved.
+// Node module: @loopback/example-validation-app
+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+
+import {post, requestBody} from '@loopback/rest';
+import {Cat, Dog, Pet} from '../models';
+
+export class PetController {
+  constructor() {}
+
+  @post('/pets')
+  async create(
+    @requestBody({
+      content: {
+        'application/json': {
+          schema: {
+            discriminator: {
+              propertyName: 'kind',
+            },
+            oneOf: [{'x-ts-type': Cat}, {'x-ts-type': Dog}],
+          },
+        },
+      },
+    })
+    request: Pet,
+  ): Promise<Pet> {
+    return request;
+  }
+}

package/src/middleware/validation-error.middleware.ts

@@ -54,7 +54,10 @@ export class ValidationErrorMiddlewareProvider implements Provider<Middleware> {
     err: HttpErrors.HttpError,
   ): Response | undefined {
     // 2. customize error for particular endpoint
-    if (context.request.url === '/coffee-shops') {
+    if (
+      context.request.url === '/coffee-shops' ||
+      context.request.url === '/pets'
+    ) {
       // if this is a validation error from the PATCH method, customize it
       // for other validation errors, the default AJV error object will be sent
       if (err.statusCode === 422 && context.request.method === 'PATCH') {

package/src/models/index.ts

@@ -4,3 +4,4 @@
 // License text available at https://opensource.org/licenses/MIT
 
 export * from './coffee-shop.model';
+export * from './pet.model';

package/src/models/pet.model.ts

@@ -0,0 +1,86 @@
+import {Model, model, property} from '@loopback/repository';
+
+@model()
+export class CatProperties extends Model {
+  @property({
+    type: String,
+    required: true,
+  })
+  color: string;
+
+  @property({
+    type: Number,
+    required: true,
+  })
+  whiskerLength: number;
+}
+
+@model()
+export class DogProperties extends Model {
+  @property({
+    type: String,
+    required: true,
+  })
+  breed: string;
+
+  @property({
+    type: Number,
+    required: true,
+  })
+  barkVolume: number;
+}
+
+@model()
+export class Pet extends Model {
+  @property({
+    type: String,
+    required: true,
+  })
+  name: string;
+
+  @property({
+    type: Number,
+    required: false,
+  })
+  weight?: number;
+
+  kind: string;
+
+  animalProperties: CatProperties | DogProperties;
+}
+
+@model()
+export class Dog extends Pet {
+  @property({
+    type: String,
+    jsonSchema: {
+      enum: ['Dog'],
+    },
+    required: true,
+  })
+  kind: string;
+
+  @property({
+    type: DogProperties,
+    required: true,
+  })
+  animalProperties: DogProperties;
+}
+
+@model()
+export class Cat extends Pet {
+  @property({
+    type: String,
+    jsonSchema: {
+      enum: ['Cat'],
+    },
+    required: true,
+  })
+  kind: string;
+
+  @property({
+    type: CatProperties,
+    required: true,
+  })
+  animalProperties: CatProperties;
+}