@loopback/build 1.5.5 → 1.7.1

package/CHANGELOG.md

@@ -3,6 +3,45 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.7.1](https://github.com/strongloop/loopback-next/compare/@loopback/build@1.7.0...@loopback/build@1.7.1) (2019-06-06)
+
+**Note:** Version bump only for package @loopback/build
+
+
+
+
+
+# [1.7.0](https://github.com/strongloop/loopback-next/compare/@loopback/build@1.6.1...@loopback/build@1.7.0) (2019-06-03)
+
+
+### Features
+
+* replace tslint with eslint ([44185a7](https://github.com/strongloop/loopback-next/commit/44185a7))
+
+
+
+
+
+## [1.6.1](https://github.com/strongloop/loopback-next/compare/@loopback/build@1.6.0...@loopback/build@1.6.1) (2019-05-31)
+
+**Note:** Version bump only for package @loopback/build
+
+
+
+
+
+# [1.6.0](https://github.com/strongloop/loopback-next/compare/@loopback/build@1.5.5...@loopback/build@1.6.0) (2019-05-30)
+
+
+### Features
+
+* **build:** add eslint scripts and default configs ([a6abe86](https://github.com/strongloop/loopback-next/commit/a6abe86))
+* **tsdocs:** add integration with api-extractor/documenter ([c8d9572](https://github.com/strongloop/loopback-next/commit/c8d9572))
+
+
+
+
+
 ## [1.5.5](https://github.com/strongloop/loopback-next/compare/@loopback/build@1.5.4...@loopback/build@1.5.5) (2019-05-23)
 
 **Note:** Version bump only for package @loopback/build

package/README.md

@@ -6,6 +6,7 @@ LoopBack 4 or other TypeScript modules, including:
 - lb-tsc: Use
   [`tsc`](https://www.typescriptlang.org/docs/handbook/compiler-options.html) to
   compile typescript files
+- lb-eslint: Run [`eslint`](https://typescript-eslint.io/)
 - lb-tslint: Run [`tslint`](https://github.com/palantir/tslint)
 - lb-prettier: Run [`prettier`](https://github.com/prettier/prettier)
 - lb-mocha: Run [`mocha`](https://mochajs.org/) to execute test cases
@@ -32,13 +33,13 @@ To use `@loopback/build` for your package:
     "build": "lb-tsc",
     "build:watch": "lb-tsc --watch",
     "clean": "lb-clean",
-    "lint": "npm run prettier:check && npm run tslint",
-    "lint:fix": "npm run prettier:fix && npm run tslint:fix",
+    "lint": "npm run prettier:check && npm run eslint",
+    "lint:fix": "npm run prettier:fix && npm run eslint:fix",
     "prettier:cli": "lb-prettier \"**/*.ts\" \"**/*.js\"",
     "prettier:check": "npm run prettier:cli -- -l",
     "prettier:fix": "npm run prettier:cli -- --write",
-    "tslint": "lb-tslint",
-    "tslint:fix": "npm run tslint -- --fix",
+    "eslint": "lb-eslint --report-unused-disable-directives .",
+    "eslint:fix": "npm run eslint -- --fix",
     "pretest": "npm run clean && npm run build",
     "test": "lb-mocha \"dist/__tests__\"",
     "posttest": "npm run lint",
@@ -54,7 +55,7 @@ Now you run the scripts, such as:
 - `npm run build` - Compile TypeScript files and copy resources (non `.ts`
   files) to outDir
 - `npm test` - Run all mocha tests
-- `npm run lint` - Run `tslint` and `prettier` on source files
+- `npm run lint` - Run `eslint` and `prettier` on source files
 
 3.  Override default configurations in your project
 

package/bin/compile-package.js

@@ -36,7 +36,7 @@ function run(argv, options) {
     '--copy-resources',
   );
 
-  var target;
+  let target;
 
   // --copy-resources is not a TS Compiler option so we remove it from the
   // list of compiler options to avoid compiler errors.
@@ -47,7 +47,7 @@ function run(argv, options) {
   if (!isTargetSet) {
     // Find the last non-option argument as the `target`
     // For example `-p tsconfig.json es2017` or `es2017 -p tsconfig.json`
-    for (var i = compilerOpts.length - 1; i >= 0; i--) {
+    for (let i = compilerOpts.length - 1; i >= 0; i--) {
       target = compilerOpts[i];
       // It's an option
       if (target.indexOf('-') === 0) {
@@ -69,7 +69,7 @@ function run(argv, options) {
     }
   }
 
-  var outDir;
+  let outDir;
 
   if (isOutDirSet) {
     const outDirIx = compilerOpts.indexOf('--outDir');
@@ -79,14 +79,15 @@ function run(argv, options) {
     outDir = path.join(packageDir, utils.getDistribution(target));
   }
 
-  var tsConfigFile;
+  let tsConfigFile;
 
+  let rootDir;
   if (!isProjectSet) {
-    var rootDir = utils.getRootDir();
+    rootDir = utils.getRootDir();
     tsConfigFile = utils.getConfigFile('tsconfig.build.json', 'tsconfig.json');
     if (tsConfigFile === path.join(rootDir, 'config/tsconfig.build.json')) {
       // No local tsconfig.build.json or tsconfig.json found
-      var baseConfigFile = path.join(rootDir, 'config/tsconfig.common.json');
+      let baseConfigFile = path.join(rootDir, 'config/tsconfig.common.json');
       baseConfigFile = path.relative(packageDir, baseConfigFile);
       if (baseConfigFile.indexOf('..' + path.sep) !== 0) {
         // tsconfig only supports relative or rooted path

package/bin/generate-apidocs.js

@@ -10,7 +10,7 @@ function run(argv, options) {
   const utils = require('./utils');
   const fs = require('fs-extra');
   const path = require('path');
-  var tsPath;
+  let tsPath;
   try {
     tsPath = require.resolve('typedoc/node_modules/typescript/package.json');
   } catch (e) {

package/bin/run-clean.js

@@ -27,8 +27,8 @@ function run(argv, options) {
   const rimraf = require('rimraf');
   const path = require('path');
   const utils = require('./utils');
-  var globPatterns = argv.slice(2);
-  var removed = [];
+  let globPatterns = argv.slice(2);
+  const removed = [];
   if (!globPatterns.length) {
     globPatterns = [utils.getDistribution()];
   }
@@ -36,7 +36,7 @@ function run(argv, options) {
   if (typeof options === 'boolean') options = {dryRun: options};
   options = options || {};
   globPatterns.forEach(pattern => {
-    var relativePath = path.relative(process.cwd(), pattern);
+    const relativePath = path.relative(process.cwd(), pattern);
     if (relativePath.indexOf('..') !== -1) {
       if (!options.dryRun) {
         console.error(

package/bin/run-eslint.js

@@ -0,0 +1,49 @@
+#!/usr/bin/env node
+// Copyright IBM Corp. 2017,2018. All Rights Reserved.
+// Node module: @loopback/build
+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+
+/*
+========
+
+Usage:
+  node ./bin/run-eslint
+
+========
+*/
+
+'use strict';
+
+function run(argv, options) {
+  const utils = require('./utils');
+
+  const eslintOpts = argv.slice(2);
+
+  const isConfigSet = utils.isOptionSet(eslintOpts, '-c', '--config');
+  const isExtSet = utils.isOptionSet(eslintOpts, '--ext');
+
+  const eslintConfigFile = isConfigSet
+    ? null
+    : utils.getConfigFile('.eslintrc.js', '.eslintrc.json');
+
+  const eslintIgnoreFile = utils.getConfigFile('.eslintignore');
+
+  const args = [];
+  if (eslintConfigFile) {
+    args.push('-c', eslintConfigFile);
+  }
+  if (eslintIgnoreFile) {
+    args.push('--ignore-path', eslintIgnoreFile);
+  }
+
+  if (!isExtSet) {
+    args.push('--ext', '.js,.ts');
+  }
+  args.push(...eslintOpts);
+
+  return utils.runCLI('eslint/bin/eslint', args, options);
+}
+
+module.exports = run;
+if (require.main === module) run(process.argv);

package/bin/utils.js

@@ -31,7 +31,7 @@ function getDistribution(target) {
   if (!target) {
     target = getCompilationTarget();
   }
-  var dist;
+  let dist;
   switch (target) {
     case 'es2018':
       dist = 'dist10';
@@ -71,8 +71,8 @@ function getPackageDir() {
  * @param {string} defaultName Default file
  */
 function getConfigFile(name, defaultName) {
-  var dir = getPackageDir();
-  var configFile = path.join(dir, name);
+  const dir = getPackageDir();
+  let configFile = path.join(dir, name);
   if (!fs.existsSync(configFile)) {
     debug('%s does not exist', configFile);
     if (defaultName) {
@@ -132,7 +132,7 @@ function runCLI(cli, args, options) {
     args = options.nodeArgs.concat(args);
   }
   debug('Spawn %s %s', process.execPath, args.join(' '));
-  var child = spawn(
+  const child = spawn(
     process.execPath, // Typically '/usr/local/bin/node'
     args,
     Object.assign(
@@ -167,7 +167,7 @@ function runShell(command, args, options) {
   if (options.dryRun) {
     return util.format('%s %s', command, args.join(' '));
   }
-  var child = spawn(
+  const child = spawn(
     command,
     args,
     Object.assign(

package/config/.eslintignore

@@ -0,0 +1,4 @@
+node_modules/
+dist/
+coverage/
+api-docs/

package/config/.eslintrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  extends: '@loopback/eslint-config',
+};

package/docs.json

@@ -8,6 +8,7 @@
     "bin/run-mocha.js",
     "bin/run-prettier.js",
     "bin/run-tslint.js",
+    "bin/run-eslint.js",
     "bin/select-dist.js",
     "bin/utils.js"
   ],

package/index.js

@@ -16,3 +16,9 @@ exports.clean = require('./bin/run-clean');
 const utils = require('./bin/utils');
 exports.runCLI = utils.runCLI;
 exports.runShell = utils.runShell;
+
+const path = require('path');
+exports.typeScriptPath = path.resolve(
+  require.resolve('typescript/package.json'),
+  '..',
+);

package/package.json

@@ -5,7 +5,7 @@
     "type": "git",
     "url": "https://github.com/strongloop/loopback-next.git"
   },
-  "version": "1.5.5",
+  "version": "1.7.1",
   "engines": {
     "node": ">=8.9"
   },
@@ -14,11 +14,18 @@
   "copyright.owner": "IBM Corp.",
   "license": "MIT",
   "dependencies": {
-    "@loopback/tslint-config": "^2.0.4",
-    "@types/mocha": "^5.0.0",
+    "@loopback/eslint-config": "^1.1.1",
+    "@loopback/tslint-config": "^2.1.0",
+    "@types/mocha": "^5.2.7",
     "@types/node": "^10.11.2",
+    "@typescript-eslint/eslint-plugin": "^1.9.0",
+    "@typescript-eslint/parser": "^1.9.0",
     "cross-spawn": "^6.0.5",
     "debug": "^4.0.1",
+    "eslint": "^5.16.0",
+    "eslint-config-prettier": "^4.3.0",
+    "eslint-plugin-eslint-plugin": "^2.1.0",
+    "eslint-plugin-mocha": "^5.3.0",
     "fs-extra": "^8.0.1",
     "glob": "^7.1.4",
     "mocha": "^6.1.4",
@@ -27,11 +34,12 @@
     "rimraf": "^2.6.2",
     "source-map-support": "^0.5.12",
     "strong-docs": "^4.2.0",
-    "tslint": "^5.15.0",
-    "typescript": "^3.4.3"
+    "tslint": "^5.17.0",
+    "typescript": "~3.5.1"
   },
   "bin": {
     "lb-tsc": "./bin/compile-package.js",
+    "lb-eslint": "./bin/run-eslint.js",
     "lb-tslint": "./bin/run-tslint.js",
     "lb-prettier": "./bin/run-prettier.js",
     "lb-mocha": "./bin/run-mocha.js",
@@ -44,5 +52,5 @@
     "test": "npm run mocha",
     "mocha": "node bin/run-mocha --timeout 30000 \"test/integration/*.js\""
   },
-  "gitHead": "ed94785609c511c5e76a38173f66ba1d7e80c9e5"
+  "gitHead": "84f2a09c401f44f3156d90b8d65e9d0a2a4bc78e"
 }

package/src/fail-on-console-logs.js

@@ -47,7 +47,7 @@ process.on('warning', warning => {
 
 process.on('exit', code => {
   if (!warnings.length) {
-    for (w of warnings) {
+    for (const w of warnings) {
       originalConsole.warn(w);
     }
   }