@loontail/minecraft-kit 0.2.0 → 0.3.0

package/dist/index.d.ts

@@ -576,11 +576,16 @@ interface ExtractNativeAction {
     readonly destination: string;
     readonly exclude: readonly string[];
 }
-/** A Forge processor invocation. */
+/**
+ * A Forge processor invocation. `Main-Class` is intentionally NOT carried here — the
+ * runner reads it from `classpath[0]`'s manifest at execution time, because the JAR is
+ * not guaranteed to exist on disk during planning (newer Forge versions ship some
+ * processor JARs as regular Maven libraries instead of bundling them in the installer).
+ */
 interface RunForgeProcessorAction {
     readonly kind: typeof InstallActionKinds.RUN_FORGE_PROCESSOR;
     readonly index: number;
-    readonly mainClass: string;
+    /** First entry is the processor JAR; remaining entries are its declared classpath. */
     readonly classpath: readonly string[];
     readonly args: readonly string[];
     readonly outputs: Readonly<Record<string, string>>;

package/dist/index.js

@@ -551,14 +551,16 @@ function planLibraryDownloads(input) {
       );
       if (!seenPaths.has(targetPath)) {
         seenPaths.add(targetPath);
-        downloads.push({
-          kind: InstallActionKinds.DOWNLOAD_FILE,
-          url: artifact.url,
-          target: targetPath,
-          ...artifact.sha1 !== void 0 ? { expectedSha1: artifact.sha1 } : {},
-          ...artifact.size !== void 0 ? { expectedSize: artifact.size } : {},
-          category: input.category
-        });
+        if (artifact.url) {
+          downloads.push({
+            kind: InstallActionKinds.DOWNLOAD_FILE,
+            url: artifact.url,
+            target: targetPath,
+            ...artifact.sha1 !== void 0 ? { expectedSha1: artifact.sha1 } : {},
+            ...artifact.size !== void 0 ? { expectedSize: artifact.size } : {},
+            category: input.category
+          });
+        }
         classpathFiles.push(targetPath);
       }
     }
@@ -567,14 +569,16 @@ function planLibraryDownloads(input) {
       const targetPath = path.join(targetPaths.librariesDir(input.directory), native.relativePath);
       if (!seenPaths.has(targetPath)) {
         seenPaths.add(targetPath);
-        downloads.push({
-          kind: InstallActionKinds.DOWNLOAD_FILE,
-          url: native.url,
-          target: targetPath,
-          ...native.sha1 !== void 0 ? { expectedSha1: native.sha1 } : {},
-          ...native.size !== void 0 ? { expectedSize: native.size } : {},
-          category: input.category
-        });
+        if (native.url) {
+          downloads.push({
+            kind: InstallActionKinds.DOWNLOAD_FILE,
+            url: native.url,
+            target: targetPath,
+            ...native.sha1 !== void 0 ? { expectedSha1: native.sha1 } : {},
+            ...native.size !== void 0 ? { expectedSize: native.size } : {},
+            category: input.category
+          });
+        }
       }
       nativeExtractions.push({
         kind: InstallActionKinds.EXTRACT_NATIVE,
@@ -1379,7 +1383,7 @@ async function buildProcessorActions(input) {
       continue;
     }
     if (!evaluateRules([], { system: input.system })) ;
-    const action = await buildProcessorAction({
+    const action = buildProcessorAction({
       processor,
       directory: input.directory,
       tokens,
@@ -1394,19 +1398,11 @@ function processorAppliesToClient(processor) {
   if (!processor.sides || processor.sides.length === 0) return true;
   return processor.sides.includes("client");
 }
-async function buildProcessorAction(input) {
+function buildProcessorAction(input) {
   const jarPath = path.join(
     targetPaths.librariesDir(input.directory),
     mavenRelativePathFor(input.processor.jar)
   );
-  const mainClass = await readJarMainClass(jarPath);
-  if (!mainClass) {
-    throw new MinecraftKitError(
-      "FORGE_INSTALLER_INVALID",
-      `Processor jar has no Main-Class: ${input.processor.jar}`,
-      { context: { filePath: jarPath } }
-    );
-  }
   const classpath = [
     jarPath,
     ...input.processor.classpath.map(
@@ -1425,7 +1421,6 @@ async function buildProcessorAction(input) {
   return {
     kind: InstallActionKinds.RUN_FORGE_PROCESSOR,
     index: input.index,
-    mainClass,
     classpath,
     args,
     outputs
@@ -1767,16 +1762,32 @@ function isWrite(action) {
 }
 async function runProcessor(input) {
   const startedAt = Date.now();
+  const processorJar = input.action.classpath[0];
+  if (processorJar === void 0) {
+    throw new MinecraftKitError(
+      "FORGE_INSTALLER_INVALID",
+      "Forge processor has an empty classpath",
+      { context: { processorIndex: input.action.index } }
+    );
+  }
+  const mainClass = await readJarMainClass(processorJar);
+  if (!mainClass) {
+    throw new MinecraftKitError(
+      "FORGE_INSTALLER_INVALID",
+      `Forge processor jar has no Main-Class: ${processorJar}`,
+      { context: { filePath: processorJar } }
+    );
+  }
   const classpathSeparator = process.platform === "win32" ? ";" : ":";
   const args = [
     "-cp",
     input.action.classpath.join(classpathSeparator),
-    input.action.mainClass,
+    mainClass,
     ...input.action.args
   ];
   input.onEvent?.({
     type: "forge:processor-started",
-    processor: { index: input.action.index, mainClass: input.action.mainClass },
+    processor: { index: input.action.index, mainClass },
     total: input.total
   });
   const stderrTail = [];
@@ -1791,11 +1802,11 @@ async function runProcessor(input) {
   if (exit.code !== 0) {
     throw new MinecraftKitError(
       "FORGE_PROCESSOR_FAILED",
-      `Forge processor exited with code ${exit.code ?? "(signal)"}: ${input.action.mainClass}`,
+      `Forge processor exited with code ${exit.code ?? "(signal)"}: ${mainClass}`,
       {
         context: {
           exitCode: exit.code ?? void 0,
-          mainClass: input.action.mainClass,
+          mainClass,
           stderr: stderrTail.join("\n")
         }
       }
@@ -1803,7 +1814,7 @@ async function runProcessor(input) {
   }
   input.onEvent?.({
     type: "forge:processor-completed",
-    processor: { index: input.action.index, mainClass: input.action.mainClass },
+    processor: { index: input.action.index, mainClass },
     exitCode: exit.code ?? 0,
     durationMs: Date.now() - startedAt
   });
@@ -1818,7 +1829,7 @@ async function runProcessor(input) {
     }
     input.onEvent?.({
       type: "forge:processor-output-verified",
-      processor: { index: input.action.index, mainClass: input.action.mainClass },
+      processor: { index: input.action.index, mainClass },
       path: outputPath
     });
   }