@loomhelm/multi-task-flow 0.2.8 → 0.2.9

package/toolkit/skills/support-manifest.json

@@ -28,6 +28,7 @@
   "skills/multi-task-flow/tests/pr-details.test.ts",
   "skills/multi-task-flow/tests/service-lifecycle.test.ts",
   "skills/multi-task-flow/tests/single-delivery-unit.test.ts",
+  "skills/multi-task-flow/tests/delivery-topology.test.ts",
   "skills/multi-task-flow/tests/ui/graph-controller.test.tsx",
   "skills/multi-task-flow/tests/ui/pr-status.test.ts",
   "skills/multi-task-flow/tests/ui/resource-popover.test.ts",

package/toolkit/skills/multi-task-flow/scripts/serve.ts

@@ -1,218 +0,0 @@
-import { fileURLToPath } from "node:url";
-import { Runtime } from "../../bin/modules/core/runtime";
-import { homedir } from "node:os";
-import { join } from "node:path";
-import { ContractError, requireCondition } from "../lib/errors";
-import { defaultRoot, safeId } from "../lib/store";
-import { startDashboard } from "../lib/server";
-import {
-  defaultRegistryDir,
-  PortRegistry,
-  RegistryError,
-} from "../../bin/modules/workspace/port_registry";
-
-const args = process.argv.slice(2);
-function flag(name: string): string {
-  const index = args.indexOf(name);
-  const value = index >= 0 ? args[index + 1] : undefined;
-  requireCondition(
-    !!value && !value.startsWith("--"),
-    "INVALID_ARGUMENTS",
-    `Missing ${name}`,
-  );
-  return value;
-}
-
-function optionalFlag(name: string): string | undefined {
-  const index = args.indexOf(name);
-  if (index < 0) return undefined;
-  const value = args[index + 1];
-  requireCondition(
-    !!value && !value.startsWith("--"),
-    "INVALID_ARGUMENTS",
-    `Missing ${name}`,
-  );
-  return value;
-}
-
-function registryJson(
-  registry: string,
-  command: string,
-  options: string[],
-  failureCode = "LEASE_OPERATION_FAILED",
-): Record<string, unknown> {
-  const result = Runtime.spawnSync(
-    [process.execPath, "--no-install", registry, "--json", command, ...options],
-    { stdout: "pipe", stderr: "pipe" },
-  );
-  const stderr = result.stderr.toString().trim();
-  requireCondition(
-    result.exitCode === 0,
-    failureCode,
-    stderr || `Port lease command failed: ${command}`,
-    5,
-  );
-  try {
-    return JSON.parse(result.stdout.toString());
-  } catch {
-    throw new ContractError(
-      failureCode,
-      `Port lease command returned invalid JSON: ${command}`,
-      5,
-    );
-  }
-}
-
-let scope = "";
-let service = "";
-let port = 0;
-let dashboard: Awaited<ReturnType<typeof startDashboard>> | undefined;
-let heartbeatTimer: ReturnType<typeof setInterval> | undefined;
-let leaseRegistered = false;
-let shutdownPromise: Promise<void> | undefined;
-
-const registry = fileURLToPath(new URL('../../global-port-manager/scripts/port_registry.' + (import.meta.url.endsWith('.js') ? 'js' : 'ts'), import.meta.url));
-
-async function shutdown(exitCode: number): Promise<void> {
-  if (shutdownPromise) return shutdownPromise;
-  shutdownPromise = (async () => {
-    let finalCode = exitCode;
-    if (heartbeatTimer) clearInterval(heartbeatTimer);
-    if (leaseRegistered) {
-      try {
-        registryJson(registry, "release-service", [
-          "--scope-id",
-          scope,
-          "--service",
-          service,
-          "--port",
-          String(port),
-          "--pid",
-          String(process.pid),
-        ]);
-      } catch {
-        finalCode = 1;
-      }
-      leaseRegistered = false;
-    }
-    try {
-      await dashboard?.stop();
-    } catch {
-      finalCode = 1;
-    }
-    dashboard = undefined;
-    process.exitCode = finalCode;
-  })();
-  return shutdownPromise;
-}
-
-try {
-  const runId = safeId(flag("--run"));
-  scope = flag("--scope-id");
-  service = flag("--service");
-  port = Number(flag("--port"));
-  const agentSession = optionalFlag("--agent-session");
-  requireCondition(
-    Number.isInteger(port) && port > 0 && port <= 65535,
-    "INVALID_PORT",
-    "An allocated port is required",
-  );
-  const root = process.env.TASK_ORCHESTRATION_DATA_ROOT ?? defaultRoot();
-  const assetsDir = args.includes("--custom-view")
-    ? join(root, "runs", runId, "view")
-    : join(import.meta.dir, "..", "dist");
-  const portRegistry = new PortRegistry(defaultRegistryDir());
-  const activeDashboard = await portRegistry
-    .claimAndRun(
-      {
-        scopeId: scope,
-        service,
-        port,
-        pid: process.pid,
-        ...(agentSession === undefined ? {} : { agentSession }),
-      },
-      async () => {
-        const startedDashboard = await startDashboard({
-          root,
-          runId,
-          port,
-          assetsDir,
-        });
-        // Publish the cleanup handle before claim verification or persistence.
-        dashboard = startedDashboard;
-        return startedDashboard;
-      },
-    )
-    .catch((error) => {
-      if (error instanceof RegistryError)
-        throw new ContractError("LEASE_UNAVAILABLE", error.message, 5);
-      throw error;
-    });
-  dashboard = activeDashboard;
-  leaseRegistered = true;
-  const heartbeatLease = () => {
-    const heartbeatOptions = [
-      "--scope-id",
-      scope,
-      "--service",
-      service,
-      "--port",
-      String(port),
-      "--pid",
-      String(process.pid),
-      "--expected-pid",
-      String(process.pid),
-    ];
-    if (agentSession) heartbeatOptions.push("--agent-session", agentSession);
-    registryJson(registry, "heartbeat", heartbeatOptions);
-  };
-  try {
-    heartbeatLease();
-  } catch {
-    throw new ContractError(
-      "LEASE_HEARTBEAT_FAILED",
-      "Port lease heartbeat failed",
-      5,
-    );
-  }
-  heartbeatTimer = setInterval(() => {
-    if (shutdownPromise) return;
-    try {
-      heartbeatLease();
-    } catch {
-      console.error(
-        JSON.stringify({
-          ok: false,
-          code: "LEASE_HEARTBEAT_FAILED",
-          message: "Port lease heartbeat failed",
-        }),
-      );
-      void shutdown(5);
-    }
-  }, 30_000);
-  console.log(
-    JSON.stringify({
-      ok: true,
-      url: `http://127.0.0.1:${activeDashboard.port}/s/${activeDashboard.token}/`,
-      port: activeDashboard.port,
-      scope_id: scope,
-      service,
-      agent_session_recorded: Boolean(agentSession),
-    }),
-  );
-  const close = () => {
-    void shutdown(0);
-  };
-  process.once("SIGTERM", close);
-  process.once("SIGINT", close);
-} catch (error) {
-  const code = error instanceof ContractError ? error.code : "SERVER_ERROR";
-  console.error(
-    JSON.stringify({
-      ok: false,
-      code,
-      message: error instanceof Error ? error.message : "Server failed",
-    }),
-  );
-  await shutdown(error instanceof ContractError ? error.exitCode : 1);
-}

package/toolkit/skills/multi-task-flow/tests/serve.test.ts

@@ -1,194 +0,0 @@
-import { createServer } from "node:net";
-import { mkdtemp, mkdir, realpath, rm, writeFile } from "node:fs/promises";
-import { tmpdir } from "node:os";
-import { join, resolve } from "node:path";
-import { describe, expect, test } from "bun:test";
-import { PortRegistry } from "../../bin/modules/workspace/port_registry";
-import { createDemoLedger } from "../examples/orchestration-viewer/ledger";
-import { LedgerStore } from "../lib/store";
-
-async function freePort(): Promise<number> {
-  const listener = createServer();
-  await new Promise<void>((resolvePromise, reject) => {
-    listener.once("error", reject);
-    listener.listen(0, "127.0.0.1", () => resolvePromise());
-  });
-  const address = listener.address();
-  const port =
-    typeof address === "object" && address !== null ? address.port : 0;
-  await new Promise<void>((resolvePromise, reject) => {
-    listener.close((error) => (error ? reject(error) : resolvePromise()));
-  });
-  return port;
-}
-
-async function readLine(stream: ReadableStream<Uint8Array>): Promise<string> {
-  const reader = stream.getReader();
-  const decoder = new TextDecoder();
-  let output = "";
-  try {
-    while (true) {
-      const chunk = await reader.read();
-      if (chunk.done)
-        throw new Error("serve.ts exited before announcing its URL");
-      output += decoder.decode(chunk.value, { stream: true });
-      const newline = output.indexOf("\n");
-      if (newline >= 0) return output.slice(0, newline);
-    }
-  } finally {
-    reader.releaseLock();
-  }
-}
-
-describe("multi-task dashboard service wrapper", () => {
-  test("records its pid/session and releases its lease on SIGTERM", async () => {
-    const root = await mkdtemp(
-      join(await realpath(tmpdir()), "multi-task-serve-"),
-    );
-    const dataRoot = join(root, "data");
-    const registryRoot = join(root, "registry");
-    const repoRoot = resolve(import.meta.dir, "../../..");
-    const run = createDemoLedger();
-    const runStore = new LedgerStore(dataRoot, run.orchestration_id);
-    const viewRoot = join(runStore.runPath, "view");
-    const port = await freePort();
-    let child: ReturnType<typeof Bun.spawn> | undefined;
-    let duplicate: ReturnType<typeof Bun.spawn> | undefined;
-    try {
-      runStore.create(run);
-      await mkdir(viewRoot, { recursive: true });
-      await writeFile(
-        join(viewRoot, "index.html"),
-        "<!doctype html><title>test</title>",
-      );
-      await writeFile(join(viewRoot, "app.js"), "");
-      await writeFile(join(viewRoot, "app.css"), "");
-
-      const registry = new PortRegistry(registryRoot);
-      await registry.register({
-        scopeId: "scope-test",
-        service: "dashboard",
-        port,
-        project: "test",
-        repoRoot,
-        branch: "test",
-        worktreePath: repoRoot,
-      });
-
-      child = Bun.spawn(
-        [
-          process.execPath,
-          join(import.meta.dir, "../scripts/serve.ts"),
-          "--run",
-          run.orchestration_id,
-          "--scope-id",
-          "scope-test",
-          "--service",
-          "dashboard",
-          "--port",
-          String(port),
-          "--agent-session",
-          "native-session-test",
-          "--custom-view",
-        ],
-        {
-          cwd: repoRoot,
-          env: {
-            ...process.env,
-            CODEX_HOME: repoRoot,
-            CODEX_PORT_REGISTRY_DIR: registryRoot,
-            TASK_ORCHESTRATION_DATA_ROOT: dataRoot,
-          },
-          stdout: "pipe",
-          stderr: "pipe",
-        },
-      );
-
-      const stdout = child.stdout;
-      if (stdout === undefined || typeof stdout === "number")
-        throw new Error("serve.ts stdout is not piped");
-      const announcement = JSON.parse(await readLine(stdout));
-      expect(announcement).toMatchObject({
-        ok: true,
-        port,
-        scope_id: "scope-test",
-        service: "dashboard",
-        agent_session_recorded: true,
-      });
-
-      const runningRows = await registry.readRows();
-      expect(runningRows).toHaveLength(1);
-      expect(runningRows[0]).toMatchObject({
-        scope_id: "scope-test",
-        service: "dashboard",
-        port: String(port),
-        agent_session: "native-session-test",
-        pid: String(child.pid),
-      });
-
-      duplicate = Bun.spawn(
-        [
-          process.execPath,
-          join(import.meta.dir, "../scripts/serve.ts"),
-          "--run",
-          run.orchestration_id,
-          "--scope-id",
-          "scope-test",
-          "--service",
-          "dashboard",
-          "--port",
-          String(port),
-          "--agent-session",
-          "native-session-test-duplicate",
-          "--custom-view",
-        ],
-        {
-          cwd: repoRoot,
-          env: {
-            ...process.env,
-            CODEX_HOME: repoRoot,
-            CODEX_PORT_REGISTRY_DIR: registryRoot,
-            TASK_ORCHESTRATION_DATA_ROOT: dataRoot,
-          },
-          stdout: "pipe",
-          stderr: "pipe",
-        },
-      );
-      const duplicateExit = await duplicate.exited;
-      const duplicateStderr = duplicate.stderr;
-      const duplicateOutput =
-        duplicateStderr === undefined || typeof duplicateStderr === "number"
-          ? ""
-          : await new Response(duplicateStderr).text();
-      duplicate = undefined;
-      expect(duplicateExit).toBe(5);
-      expect(duplicateOutput).toContain('"code":"LEASE_UNAVAILABLE"');
-      expect(await registry.readRows()).toEqual(runningRows);
-
-      process.kill(child.pid, "SIGTERM");
-      const stderr = child.stderr;
-      const exitCode = await child.exited;
-      child = undefined;
-      if (exitCode !== 0 && stderr !== undefined && typeof stderr !== "number")
-        throw new Error(
-          `serve.ts exited with ${exitCode}: ${await new Response(stderr).text()}`,
-        );
-      expect(exitCode).toBe(0);
-      expect(await registry.readRows()).toHaveLength(0);
-    } finally {
-      if (duplicate) {
-        try {
-          process.kill(duplicate.pid, "SIGKILL");
-        } catch {}
-        await duplicate.exited;
-      }
-      if (child) {
-        try {
-          process.kill(child.pid, "SIGKILL");
-        } catch {}
-        await child.exited;
-      }
-      await rm(root, { recursive: true, force: true });
-    }
-  }, 10_000);
-});