@longarc/mdash 3.1.1 → 3.1.3

package/src/warrant/engine.ts

@@ -19,6 +19,7 @@ import {
   generateTimestamp,
   sha256Object,
   hmacSeal,
+  hmacVerify,
   deriveKey,
 } from '../core/crypto.js';
 
@@ -65,7 +66,7 @@ export interface Warrant {
   policy_id: string;
   /** Current state */
   state: WarrantState;
-  /** Accountability tier */
+  /** Liability tier */
   tier: WarrantTier;
   /** Operational constraints */
   constraints: WarrantConstraints;
@@ -125,10 +126,18 @@ export class WarrantCache {
   private cache: Map<WarrantId, CacheEntry> = new Map();
   private speculative: Map<string, WarrantId[]> = new Map(); // agent_id -> warrant_ids
   private revocations: Set<WarrantId> = new Set();
+  private verifyKey: CryptoKey | null = null;
   
   private readonly DEFAULT_TTL = 5 * 60 * 1000; // 5 minutes
   private readonly SPECULATIVE_TTL = 60 * 1000; // 60 seconds (WARRANT-INV-001)
   
+  /**
+   * P2 SECURITY: Set verification key for seal checks on retrieval
+   */
+  setVerificationKey(key: CryptoKey): void {
+    this.verifyKey = key;
+  }
+  
   /**
    * Store a warrant in cache
    */
@@ -175,6 +184,45 @@ export class WarrantCache {
     return entry.warrant;
   }
   
+  /**
+   * P2 SECURITY: Get warrant with seal verification
+   * Use for security-critical operations to prevent cache poisoning
+   */
+  async getVerified(id: WarrantId): Promise<Warrant | SpeculativeWarrant | null> {
+    const warrant = this.get(id);
+    if (!warrant) return null;
+    
+    // If no verification key set, fall back to unverified (log warning)
+    if (!this.verifyKey) {
+      console.warn('WarrantCache.getVerified called without verification key');
+      return warrant;
+    }
+    
+    // Verify seal integrity
+    const warrantData = {
+      _v: 1,
+      id: warrant.id,
+      agent_id: warrant.agent_id,
+      policy_id: warrant.policy_id,
+      state: warrant.state === 'SPECULATIVE' ? 'SPECULATIVE' : warrant.state,
+      tier: warrant.tier,
+      constraints: warrant.constraints,
+      created_at: warrant.created_at,
+      expires_at: warrant.expires_at,
+      issued_by: warrant.issued_by,
+    };
+    
+    const isValid = await hmacVerify(warrantData, warrant.seal, this.verifyKey);
+    if (!isValid) {
+      // P2 SECURITY: Cache poisoning detected - remove and return null
+      console.error(`SECURITY: Warrant seal verification failed for ${id}`);
+      this.cache.delete(id);
+      return null;
+    }
+    
+    return warrant;
+  }
+  
   /**
    * Get speculative warrants for an agent
    * For pre-staged activation
@@ -261,6 +309,11 @@ export class WarrantEngine {
   private eventLog: WarrantEvent[] = [];
   private lastEventHash: Hash | null = null;
   
+  // P3 SECURITY: Rate limiting for warrant creation
+  private creationRateLimits: Map<string, { count: number; windowStart: number }> = new Map();
+  private readonly CREATION_RATE_LIMIT = 100; // Max warrants per issuer per minute
+  private readonly CREATION_RATE_WINDOW_MS = 60 * 1000;
+  
   constructor(commitmentEngine: CommitmentEngine) {
     this.cache = new WarrantCache();
     this.commitmentEngine = commitmentEngine;
@@ -271,6 +324,8 @@ export class WarrantEngine {
    */
   async initialize(sealKey: string): Promise<void> {
     this.key = await deriveKey(sealKey);
+    // P2 SECURITY: Enable seal verification on cache retrieval
+    this.cache.setVerificationKey(this.key);
   }
   
   /**
@@ -289,6 +344,9 @@ export class WarrantEngine {
       throw new Error('Engine not initialized. Call initialize() first.');
     }
     
+    // P3 SECURITY: Rate limit warrant creation per issuer
+    this.checkCreationRateLimit(params.issued_by);
+    
     const startTime = performance.now();
     
     const id = generateWarrantId();
@@ -545,6 +603,28 @@ export class WarrantEngine {
     return true;
   }
   
+  /**
+   * P3 SECURITY: Check rate limit for warrant creation
+   * Prevents DoS via cache flooding
+   */
+  private checkCreationRateLimit(issuerId: string): void {
+    const now = Date.now();
+    let limiter = this.creationRateLimits.get(issuerId);
+    
+    // Reset window if expired
+    if (!limiter || now - limiter.windowStart > this.CREATION_RATE_WINDOW_MS) {
+      limiter = { count: 0, windowStart: now };
+    }
+    
+    limiter.count++;
+    this.creationRateLimits.set(issuerId, limiter);
+    
+    if (limiter.count > this.CREATION_RATE_LIMIT) {
+      console.warn(`[WARRANT] Rate limit exceeded for issuer: ${issuerId}`);
+      throw new Error('Warrant creation rate limit exceeded');
+    }
+  }
+  
   /**
    * Log a warrant event with hash chain
    */
@@ -590,6 +670,14 @@ export class WarrantEngine {
     return [...this.eventLog];
   }
   
+  /**
+   * Check if a warrant has been revoked
+   * P1 SECURITY: Used for TOCTOU protection in execute flow
+   */
+  isRevoked(id: WarrantId): boolean {
+    return this.cache.isRevoked(id);
+  }
+  
   /**
    * Get cache statistics
    */

package/src/zk/engine.ts

@@ -25,6 +25,7 @@ import {
   sha256Object,
   hmacSeal,
   deriveKey,
+  constantTimeEqual,
 } from '../core/crypto.js';
 
 import { CommitmentEngine, Commitment } from '../core/commitment.js';
@@ -395,7 +396,8 @@ export class ZKProofsEngine {
         verifier: 'mdash-zk-engine-v3',
       };
       
-      // Re-seal with proof included
+      // Re-seal with proof included (SA-2026-009: zero seal before computing)
+      item.document.seal = '' as Seal;
       item.document.seal = await hmacSeal(item.document, this.key!);
       
       // Commit to L1
@@ -537,12 +539,14 @@ export class ZKProofsEngine {
       return { valid: false, errors };
     }
 
-    // 3. Verify seal
+    // 3. Verify seal (SA-2026-009: constant-time comparison closes verification gap)
     const docForSeal = { ...document };
     docForSeal.seal = '' as Seal;
     const expectedSeal = await hmacSeal(docForSeal, this.key);
-    // Note: In production, seal verification would be more robust
-    
+    if (!constantTimeEqual(expectedSeal, document.seal)) {
+      errors.push('Seal verification failed');
+    }
+
     // 4. Verify proof structure
     if (!document.proof.verifier_key_hash) {
       errors.push('Missing verifier key hash');

package/tsconfig.json

@@ -17,5 +17,5 @@
     "resolveJsonModule": true
   },
   "include": ["src/**/*"],
-  "exclude": ["node_modules", "dist", "src/__tests__"]
+  "exclude": ["node_modules", "dist", "src/**/__tests__"]
 }