@loneexile/omp-superpowers 7.0.0-omp.1 → 7.0.0-omp.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -6,6 +6,25 @@ A version is `<upstream version>-omp.<n>`: the upstream release this fork is syn
6
6
 
7
7
  ## [Unreleased]
8
8
 
9
+ ## [7.0.0-omp.3] - 2026-10-16
10
+
11
+ ### Changed
12
+
13
+ - **A small change no longer goes through the full process.** brainstorming's small-change row said "build it through the normal workflow", which left it to a plan and a subagent run. It now has its own path: after the in-chat approval the session builds it itself, test first, runs the covering tests and the suite once, and commits once, with no design document, plan or subagents. A new behavior such as a `--quiet` flag can be small. Security, auth, concurrency, money, migrations, changes one revert cannot undo, new config files or stored formats, changes to existing behavior (defaults, exit codes, error handling, what happens with no input), new interfaces other code builds on and new dependencies never are: in a live run before that list was written, a request for a `--format` flag and a `~/.wcrc` config file was sized small and committed with no design, and the commit also changed what the tool does with no input. In a measured herdr-tunnel feature (2026-09-21), the brainstorm, plan and finish phases took 1h41m of its 3h52m agent time.
14
+ - **One approval for design, plan and method.** A playback no longer waits for its own answer; it rides along with the next question. For software, the plan is written right after the builder check, and writing-plans asks once for approval of the design, the plan, the execution method and the workspace (a new branch in this checkout by default, so no `/move`), picking the method itself and naming its reason instead of asking the partner to choose. In the same feature, 16h55m of 20h48m wall clock was waiting for the partner's reply across the brainstorm, plan and finish prompts; this removes some of those prompts, not the time a partner takes to answer the rest. The combined plan-review and method prompt alone waited 1h42m.
15
+ - **subagent-driven-development reviews per task only where risk earns it, and runs independent tasks in parallel.** writing-plans marks security, auth, concurrency, migration or persisted-format, money and destructive tasks `**Review:** per-task`, and a plan with such a mark runs subagent-driven unless the partner says otherwise. The controller's pre-flight scan turns the marks into a review list and the scan table into waves: tasks with no shared file or interface (lockfiles, manifests and test-time ports count as shared) run in parallel, up to three, each in its own `omp worktree add` worktree. Every dispatch for a wave task, reviewers included, names its worktree. A wave task's covering tests run on the merged tree before the merge commits (`git merge --no-ff --no-commit`), a failure goes back to its implementer as a counted round, and the full suite runs once after each wave. A task reviewed at final gets the controller's own run of its covering tests instead of a task reviewer, and `sdd-final-reviewer` does the task review's work on it, and on any rebased or wave-fix code, before the seams. 6.4.2-omp.3 removed parallel waves because they rode on `task.isolation`, whose patch merge leaves no commits and whose agents cannot be resumed; these waves use git worktrees and keep both. Across six measured SDD runs, task reviews and re-reviews took 2h28m and final reviews 1h24m, against 7h06m of implementation, and every task ran in sequence.
16
+ - **`sdd-final-reviewer` always reports crashes and lost data.** A crash (an uncaught exception, a traceback) or lost data on input a user can give is a finding, never a "Declined to judge" line, whatever the plan or spec says about that input. In a live SDD run on a three-task plan, the final reviewer listed a traceback on a bad `--larger-than` value under "Declined to judge", and the branch kept it; per-task reviews now cover fewer tasks, so the final review is where such a crash gets caught.
17
+
18
+ ### Fixed
19
+
20
+ - **The `task.isolation` notes match omp 18.11.0.** They said isolated work always returns as an uncommitted patch and an isolated agent cannot be messaged. Measured in two scratch runs on 18.11.0 (the bundled `task` agent, and an `sdd-implementer` seat on cursor-sdk): `merge: branch` keeps a subagent's commits and cherry-picks them onto the parent branch as it finishes, under new ids, and deletes the task branch; a same-file conflict leaves `omp/task/<id>` behind. A `write agent://<id>` to an isolated agent answers `Delivered` although its result says it "cannot be resumed or messaged", and the fix it then committed never reached the parent branch while the session ran; after the session ended it sat on a leftover `omp/task/<id>` branch that also repeated the already-merged commit. `pi-tools.md` now says never to send an isolated subagent a follow-up, and how to recover one that went out (cherry-pick only its new commits). SDD still uses its own worktrees, because its fix rounds resume the implementer.
21
+
22
+ ## [7.0.0-omp.2] - 2026-10-11
23
+
24
+ ### Changed
25
+
26
+ - **Specs and plans save to `docs/specs/` and `docs/plans/`.** Upstream saves them under `docs/superpowers/`. brainstorming's written design and writing-plans' plan file now go to the shorter paths, and the example plan paths in executing-plans, subagent-driven-development and requesting-code-review match. `.superpowers/` (the SDD workspace and the brainstorm companion's files) is unchanged. Existing plans under `docs/superpowers/plans/` still run: SDD and executing-plans take any plan path. `scripts/check-npm-package.sh` now fails if a shipped file names `docs/superpowers`, and fails rather than passes if that search errors.
27
+
9
28
  ## [7.0.0-omp.1] - 2026-10-11
10
29
 
11
30
  Synced to upstream [v7.0.0](https://github.com/obra/superpowers/blob/v7.0.0/RELEASE-NOTES.md).
@@ -84,7 +103,9 @@ First release, synced to upstream [v6.4.2](https://github.com/obra/superpowers/b
84
103
  - The fork's rewritten subagent-driven-development text invokes its helper scripts through `bash` as well, so a package extractor that drops exec bits cannot break them.
85
104
  - `sdd-final-reviewer` carries upstream's new review rules from `code-reviewer.md`, the template it replaces in SDD's final review: the spec is a vision document (behavior it is silent on is graded by what a reasonable person expects), and a "Declined to judge" section that the controller rules on and ledgers like a plan conflict.
86
105
 
87
- [Unreleased]: https://github.com/LoneExile/omp-superpowers/compare/v7.0.0-omp.1...HEAD
106
+ [Unreleased]: https://github.com/LoneExile/omp-superpowers/compare/v7.0.0-omp.3...HEAD
107
+ [7.0.0-omp.3]: https://github.com/LoneExile/omp-superpowers/releases/tag/v7.0.0-omp.3
108
+ [7.0.0-omp.2]: https://github.com/LoneExile/omp-superpowers/releases/tag/v7.0.0-omp.2
88
109
  [7.0.0-omp.1]: https://github.com/LoneExile/omp-superpowers/releases/tag/v7.0.0-omp.1
89
110
  [6.4.2-omp.4]: https://github.com/LoneExile/omp-superpowers/releases/tag/v6.4.2-omp.4
90
111
  [6.4.2-omp.3]: https://github.com/LoneExile/omp-superpowers/releases/tag/v6.4.2-omp.3
package/README.md CHANGED
@@ -8,7 +8,8 @@ This fork keeps the skills and fixes the omp side:
8
8
 
9
9
  - the injected tool mapping tells the truth about `task`, `todo`, `read`/`grep`/`glob`
10
10
  - **five omp agents** (`agents/sdd-*.md`) give every subagent-driven-development seat its own model, thinking level, and tool set
11
- - subagent-driven-development is rewritten around them: three-round fix loop, structured reviewer output, implementers one at a time
11
+ - subagent-driven-development is rewritten around them: three-round fix loop, structured reviewer output, independent tasks in parallel worktrees, a task review only where a task's risk earns it
12
+ - a small change skips the design document, plan and subagents, and a project asks for one approval of design, plan and execution method together
12
13
 
13
14
  ## Install
14
15
 
@@ -41,9 +42,9 @@ Agent definitions are read **per dispatch**, so a reinstall takes effect on the
41
42
 
42
43
  The skills drive themselves once loaded. The usual path:
43
44
 
44
- 1. `read skill://brainstorming` — turn an idea into a design
45
- 2. `read skill://writing-plans` — produce `docs/superpowers/plans/<date>-<name>.md`
46
- 3. `read skill://subagent-driven-development` — execute the plan task by task via subagents. If you choose Native at the plan handoff, `executing-plans` runs instead: the session does every task itself, and only the final review is a subagent (`sdd-final-reviewer`)
45
+ 1. `read skill://brainstorming` — turn an idea into a design. A small change stops here: after you approve it in chat, the session builds it itself, test first, and commits once
46
+ 2. `read skill://writing-plans` — produce `docs/plans/<date>-<name>.md`, pick the execution method, and ask once for approval of the design, the plan and the method together
47
+ 3. `read skill://subagent-driven-development` — execute the plan via subagents, independent tasks in parallel. If you swap to Native in that approval, `executing-plans` runs instead: the session does every task itself, and only the final review is a subagent (`sdd-final-reviewer`)
47
48
  4. `read skill://finishing-a-development-branch` — merge / PR / discard
48
49
 
49
50
  On omp the agent invokes a skill by reading it (`read skill://<name>`); you can also invoke one explicitly with `/skill:<name>`.
@@ -54,10 +55,15 @@ On omp the agent invokes a skill by reading it (`read skill://<name>`); you can
54
55
 
55
56
  ```mermaid
56
57
  flowchart TD
57
- B["task-brief: one task's text from the plan"] --> I
58
- I["sdd-implementer: TDD, commit, report file"] --> P["review-package: git diff -U10 to a file"]
58
+ S["pre-flight scan: review list + waves"] --> B
59
+ B["task-brief: one task's text from the plan; a wave of 2+ gets a worktree per task"] --> I
60
+ I["sdd-implementer: TDD, commit, report file"] --> L{"on the review list?"}
61
+ L -->|"no: review at final"| T["controller runs the covering tests"]
62
+ T -->|"pass"| D
63
+ T -->|"fail: fix round"| I
64
+ L -->|"yes: risk class"| P["review-package: git diff -U10 to a file"]
59
65
  P --> R["sdd-reviewer: spec + quality, structured result"]
60
- R -->|"approved"| D["ledger: Task N complete"]
66
+ R -->|"approved"| D["merge the task branch; ledger: Task N complete"]
61
67
  R -->|"Critical or Important findings"| F
62
68
  F["fix round 1 or 2: resume sdd-implementer"] --> RR["sdd-rereviewer: verdict per finding"]
63
69
  RR -->|"all addressed"| D
@@ -65,9 +71,9 @@ flowchart TD
65
71
  E --> RR
66
72
  RR -->|"still open after round 3"| A["controller adjudicates and parks with a ruling"]
67
73
  A --> D
68
- D --> N{"more tasks?"}
74
+ D --> N{"more waves?"}
69
75
  N -->|"yes"| B
70
- N -->|"no"| W["sdd-final-reviewer: whole-branch, once per plan"]
76
+ N -->|"no"| W["sdd-final-reviewer: whole-branch, once per plan; does the task review's work for review-at-final tasks"]
71
77
  W --> X["finishing-a-development-branch"]
72
78
 
73
79
  classDef seat fill:#1e3a8a,stroke:#3b82f6,color:#dbeafe
@@ -144,7 +150,7 @@ Rules that are easy to get wrong:
144
150
 
145
151
  | setting | why |
146
152
  |---|---|
147
- | `task.isolation.enabled` (+ `isolation.backend`, default `auto`) | off by default. SDD does not use it: implementers run one at a time, because isolated work returns as an applied patch with no per-task commits, and an isolated subagent cannot be messaged for fix rounds. Older omp builds spelled this `task.isolation.mode`; check `omp config get task.isolation.enabled` on your build |
153
+ | `task.isolation.enabled` (+ `isolation.backend`, default `auto`) | off by default. SDD does not use it. Under the default `merge: patch` isolated work returns as an uncommitted patch; `merge: branch` keeps commits but applies them as each task ends, before review, under new ids. Either way, an isolated subagent cannot take a fix round: on omp 18.11.0 a message to one is delivered, but its fix never reaches your branch while the session runs. Parallel tasks get their own `omp worktree add` worktrees instead. Older omp builds spelled this `task.isolation.mode`; check `omp config get task.isolation.enabled` on your build |
148
154
  | `task.enableEffort` | exposes per-dispatch `effort` (`"lo"`, `"med"`, `"hi"`); `"hi"` maps to the model's top supported level, capped by `task.maxEffort`. SDD uses `effort: "hi"` for high-risk task reviews, and for escalation only when a host override lowers that seat |
149
155
  | `task.showResolvedModelBadge` (default off) | shows the model each subagent actually ran. A seat whose pinned provider has no credentials silently runs on another model |
150
156
  | `task.enableLsp`, `astGrep.enabled` (both default off) | omp only activates `lsp` and `ast_grep` in subagents when these are on |
@@ -155,14 +161,16 @@ Rules that are easy to get wrong:
155
161
  - `.pi/extensions/superpowers.ts` — the injected mapping names `task`, `todo`, the `sdd-*` roster, and the no-`model:`-field rule; it also re-arms on `session_switch`, skips subagent sessions, and ignores an `agent_end` that will auto-continue; it tells a dispatching session to name the checks each subagent must run, since omp 18.4.12 tells subagents to leave builds, tests and smoke runs to the main agent unless their assignment explicitly instructs them; its last paragraph points a vibe-mode director (tools include `vibe_spawn` but not `task`) at the *Vibe mode* section of `pi-tools.md`
156
162
  - `.omp-plugin/plugin.json` — new. Marks the repo root as an omp-native plugin so a marketplace or `--plugin-dir` install keeps each agent's `model:` line
157
163
  - `skills/using-superpowers/references/pi-tools.md` — same, as the reference doc; it also gains a *Checks* subsection (the 18.4.12 subagent hand-off rule, and why every dispatch names its checks) and a *Vibe mode* section: what a director keeps and lacks, how skill actions map onto `vibe_*` and workers, and the worktree and request-budget limits
158
- - `agents/sdd-*.md` — new. Each seat's `model:` is a pin plus a role fallback (`@task` or `@slow`), and all set `readSummarize: false`. `sdd-final-reviewer` reviews the whole branch for both ways of running a plan. It reads `requesting-code-review/code-reviewer.md` at run time and applies its What to Check, Calibration, severity definitions and Critical Rules, while carrying upstream's vision-document and Declined-to-judge rules in its own body. Descriptions name roles, never models
159
- - `skills/subagent-driven-development/` — *Model Selection* → *Agent Selection*; fix-loop cap 5 → 3 with a round-3 escalation seat; a proven-trivial-fix route that replaces a re-review with a one-command proof; implementers run one at a time; the scripts directory resolves via `realpath skill://subagent-driven-development/scripts`; fix rounds resume the implementer with `write agent://<id>` (id ledgered) and full results are read at `agent://<id>`; task review scales with risk through `effort: "hi"`; the controller checks reviewer results; templates show omp's real `{ context, tasks: [{ agent, task, solutionSpace }] }` wire shape and the reviewers' structured fields; one omp paragraph for vibe mode, where a director (no `task` or `bash`) hands the whole run to one `good` worker that dispatches the seats itself
164
+ - `skills/brainstorming/` — a defined small-change path: after the in-chat approval the session builds it itself, test first, runs the covering tests and the suite once, and commits once, with no design document, plan or subagents (a new behavior such as a `--quiet` flag can be small; security, auth, concurrency, money, migrations, changes one revert cannot undo, new config files or stored formats, changes to existing behavior, new interfaces other code builds on and new dependencies never are); a playback rides along with the next question instead of waiting for its own answer; for software, the plan is written right after the builder check so the design and the plan get one approval
165
+ - `agents/sdd-*.md` — new. Each seat's `model:` is a pin plus a role fallback (`@task` or `@slow`), and all set `readSummarize: false`. `sdd-final-reviewer` reviews the whole branch for both ways of running a plan; after subagent-driven-development it does the task review's work on every task left to it (`review at final`) before the seams. It reads `requesting-code-review/code-reviewer.md` at run time and applies its What to Check, Calibration, severity definitions and Critical Rules, while carrying upstream's vision-document and Declined-to-judge rules in its own body; a crash or lost data on user input is always a finding, never a Declined-to-judge line. Descriptions name roles, never models
166
+ - `skills/subagent-driven-development/` — *Model Selection* → *Agent Selection*; fix-loop cap 5 → 3 with a round-3 escalation seat; a proven-trivial-fix route that replaces a re-review with a one-command proof; the pre-flight scan builds a review list (plan-marked or ruled high-risk tasks get a task review, the rest get the controller's own covering-test run and the final review) and waves (tasks with no shared file or interface run in parallel, up to three, each in its own `omp worktree add` worktree, merged back with `--no-ff`); the scripts directory resolves via `realpath skill://subagent-driven-development/scripts`; fix rounds resume the implementer with `write agent://<id>` (id ledgered) and full results are read at `agent://<id>`; task review scales with risk through `effort: "hi"`; the controller checks reviewer results; templates show omp's real `{ context, tasks: [{ agent, task, solutionSpace }] }` wire shape and the reviewers' structured fields; one omp paragraph for vibe mode, where a director (no `task` or `bash`) hands the whole run to one `good` worker that dispatches the seats itself
160
167
  - `skills/executing-plans/` — one additive omp paragraph in *Final Review*: the `task` tool has no `model:` field, so the final review goes to `sdd-final-reviewer` (its model is what the host maps that agent to), told that no task was reviewed; it also resolves the scripts directory with `realpath` and reads full results at `agent://<id>`; one more omp paragraph for vibe mode, where a director hands the whole run to one `good` worker
161
168
  - `skills/using-git-worktrees/` — additive omp section: `/wt` is the user's one-line answer to the consent question (moves the session, carries WIP); when the agent creates the worktree itself it uses `omp worktree add` under `~/.omp/wt/` (the only place `omp worktree list`/`clear` manage), knows that command leaves uncommitted changes behind, and asks for `/move <path>` because `cd` never moves the tools' cwd. Also: clone-first falls back to a plain checkout without `node_modules` (no copy-on-write, or in-repo targets); setup and tests use the bash tool's `cwd` parameter until `/move`; `omp worktree clear --all` is warned against, since it force-removes every worktree, uncommitted work included; omp's bash rewrites a literal `git worktree add` into `omp worktree add` only without shell expansion; vibe mode refuses `/move` and `/wt`, so the worktree and `/move` come before `/vibe`, or every worker brief carries the absolute path
162
- - `skills/writing-plans/` — one added line in *Execution Handoff*: in vibe mode both execution approaches run in one `good` worker the director briefs, not in its own session
169
+ - `skills/writing-plans/` — *Execution Handoff* picks the method itself and asks for one approval of the design, the plan and the method; *Review Marks* (and a self-review check) mark security, auth, concurrency, migration, money and destructive tasks `**Review:** per-task`; tasks that share no file or interface can run in parallel; in vibe mode both execution approaches run in one `good` worker the director briefs, not in its own session
163
170
  - `README.md` — this file: rewritten for omp (install, seats, overrides, maintenance); upstream's multi-harness README is gone
164
171
  - `tests/pi/test-pi-extension.mjs` — covers the extension's lifecycle (bootstrap on start, `session_switch`, compaction; none for subagents or an auto-continuing `agent_end`), the action table in `pi-tools.md`, the seat table against the names in `agents/*.md`, and the `.omp-plugin/plugin.json` manifest; the package-name assertion is gone (`scripts/check-npm-package.sh` checks the published name)
165
172
  - `package.json` — the npm identity: `@loneexile/omp-superpowers`, `<upstream version>-omp.<n>` versions, a `files` allowlist (the extension, `skills/`, `agents/`), `publishConfig`, `omp`/`oh-my-pi` keywords; `main` is dropped, since it pointed at the OpenCode plugin this package does not ship
173
+ - Spec and plan paths — `docs/specs/` and `docs/plans/` instead of upstream's `docs/superpowers/specs/` and `docs/superpowers/plans/`: brainstorming's *Where it goes*, writing-plans' save path and handoff lines, and the example plan paths in executing-plans, subagent-driven-development and requesting-code-review. `.superpowers/` (the SDD workspace, brainstorm companion files) is unchanged. `scripts/check-npm-package.sh` fails if a shipped file names `docs/superpowers/`
166
174
  - `CHANGELOG.md`, `.github/workflows/` (CI, npm release), `scripts/check-npm-package.sh` — new
167
175
 
168
176
  Everything else is upstream, unmodified.
@@ -177,10 +185,12 @@ git rebase upstream/main
177
185
  git push --force-with-lease origin main
178
186
  ```
179
187
 
180
- Expect conflicts in `skills/subagent-driven-development/`, `pi-tools.md`, `README.md`, and `package.json` whenever upstream touches them — this fork rewrites those files rather than appending to them (README.md is never a partial conflict). In `package.json` keep the fork's identity and set `version` to `<new upstream version>-omp.1`: CI's package check fails until the version's base matches the upstream version in `.claude-plugin/plugin.json`. `agents/`, the extension's mapping paragraph, and the omp blocks in `using-git-worktrees` are additive.
188
+ Expect conflicts in `skills/subagent-driven-development/`, `skills/brainstorming/`, `skills/writing-plans/`, `pi-tools.md`, `README.md`, and `package.json` whenever upstream touches them — this fork rewrites those files rather than appending to them (README.md is never a partial conflict). In `package.json` keep the fork's identity and set `version` to `<new upstream version>-omp.1`: CI's package check fails until the version's base matches the upstream version in `.claude-plugin/plugin.json`. `agents/`, the extension's mapping paragraph, and the omp blocks in `using-git-worktrees` are additive.
181
189
 
182
190
  A clean rebase is not the whole sync. Upstream's edits to text this fork replaced never reach the replacement, so read upstream's diff for those files and port what still applies. The v6.4.x sync needed two: `bash scripts/...` invocations in the SDD text, and `code-reviewer.md`'s new review rules. Upstream edits to `code-reviewer.md`'s What to Check, Calibration, severity definitions and Critical Rules now reach `sdd-final-reviewer` without porting, because it reads the file at run time. Edits to the vision-document or Declined-to-judge sections still need porting into the agent body, which carries them itself.
183
191
 
192
+ The fork changes upstream's `docs/superpowers/specs` and `docs/superpowers/plans` lines in brainstorming, writing-plans, executing-plans, subagent-driven-development and requesting-code-review. When upstream edits around one of them, `-X theirs` keeps the fork's whole conflicting hunk, so read upstream's diff of those lines and port the rest of the hunk. New upstream text naming `docs/superpowers/` fails `check-npm-package.sh` until it says `docs/specs/` or `docs/plans/`.
193
+
184
194
  ### Releasing
185
195
 
186
196
  1. Set `version` in `package.json`, move CHANGELOG.md's *Unreleased* entries under that version, commit, push, and wait for CI.
@@ -194,7 +204,7 @@ gh release create "v$v" --target main --title "v$v" --notes-file /tmp/notes.md
194
204
 
195
205
  ### New omp versions
196
206
 
197
- Before trusting a new omp release, re-check the harness facts this fork depends on — against the **running binary**, not an npm source tree that may lag it. `~/.bun/install/global/node_modules/@oh-my-pi/pi-coding-agent/src` routinely lags `omp --version` (a 17.4.2 tree sat beside an 18.1.17 binary while this README was written, and the isolation setting had been renamed in between). The fork was last verified against omp 18.4.10; its vibe-mode text and the subagent check rule were re-checked against 18.4.12. To read the exact running version's source, pack it into a temp dir: `cd "$(mktemp -d)" && npm pack @oh-my-pi/pi-coding-agent@$(omp --version | cut -d/ -f2) && tar xzf *.tgz` (source under `package/src`). The live oracles are `omp config list --json` (every setting and its default), the `task` tool's own description in a session (agent roster, item fields), a `session_init.resolvedModel` line in a subagent transcript (what actually resolved), and `grep -a` on the binary for an exact string when you need to know whether a code path exists.
207
+ Before trusting a new omp release, re-check the harness facts this fork depends on — against the **running binary**, not an npm source tree that may lag it. `~/.bun/install/global/node_modules/@oh-my-pi/pi-coding-agent/src` routinely lags `omp --version` (a 17.4.2 tree sat beside an 18.1.17 binary while this README was written, and the isolation setting had been renamed in between). The fork was last verified against omp 18.4.10; its vibe-mode text and the subagent check rule were re-checked against 18.4.12, and the `task.isolation` notes against 18.11.0. To read the exact running version's source, pack it into a temp dir: `cd "$(mktemp -d)" && npm pack @oh-my-pi/pi-coding-agent@$(omp --version | cut -d/ -f2) && tar xzf *.tgz` (source under `package/src`). The live oracles are `omp config list --json` (every setting and its default), the `task` tool's own description in a session (agent roster, item fields), a `session_init.resolvedModel` line in a subagent transcript (what actually resolved), and `grep -a` on the binary for an exact string when you need to know whether a code path exists.
198
208
 
199
209
  ## License
200
210
 
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: sdd-final-reviewer
3
- description: "Superpowers final whole-branch reviewer, dispatched once per plan: after subagent-driven-development it checks the seams between reviewed tasks; after an inline executing-plans run it is the only review the branch gets. Triages the ledger lines it is given."
3
+ description: "Superpowers final whole-branch reviewer, dispatched once per plan: after subagent-driven-development it reviews the tasks left to it and the seams between all of them; after an inline executing-plans run it is the only review the branch gets. Triages the ledger lines it is given."
4
4
  tools: read, grep, glob, bash, lsp, ast_grep
5
5
  # thinkingLevel is the seat's reasoning tier; an explicit :level on the model
6
6
  # string (or on a task.agentModelOverrides entry) takes precedence over it.
@@ -15,7 +15,7 @@ readSummarize: false
15
15
 
16
16
  You review a whole branch once, at the end of a plan. Your dispatch gives the merge-base..HEAD review package, the plan/spec paths, the ledger lines to triage, and how the plan ran:
17
17
 
18
- - **subagent-driven-development:** every task went through its own task review, except the fixes the controller applied itself on the proven-trivial route (ledger lines `Task <N>: applied … proof: …`, passed in the dispatch), which skipped the re-review: check each such fix and its proof as if no one had. Per-task reviews cannot see cross-file seams; you can, so spend your attention there.
18
+ - **subagent-driven-development:** the dispatch names the tasks that had their own task review (`review per-task`, with a risk class) and the tasks that did not (`review at final`). Do the task review's work on every `review at final` task first, as for an inline run below. Then the seams: per-task reviews cannot see cross-file seams, so spend your attention there, deepest around the `review per-task` classes. Fixes the controller applied itself on the proven-trivial route (ledger lines `Task <N>: applied … proof: …`, passed in the dispatch) skipped the re-review: check each such fix and its proof as if no one had.
19
19
  - **executing-plans (inline):** no task was reviewed, and you are the only fresh review this branch gets. Do the task reviews' work across the whole branch first — every plan requirement present, nothing extra, the code sound, and tests that can fail (would deleting a fix, or a plausible regression, leave them green?) — then the seams.
20
20
 
21
21
  If the dispatch does not say how the plan ran, review it as an inline run.
@@ -24,10 +24,11 @@ If the dispatch does not say how the plan ran, review it as an inline run.
24
24
  - Read `skill://requesting-code-review/code-reviewer.md` first and apply its **What to Check** (plan alignment, code quality, architecture, testing, production readiness), its **Calibration**, its Critical / Important / Minor definitions (under *Output Format → Issues*), and its **Critical Rules**. Its Output Format layout, Recommendations, Assessment, and Read-Only Review section do not apply: `<output>` below governs the result, and the bash limits below govern the checkout.
25
25
  - Read the package in full, from line 1, with an explicit range: a bare `read` returns only the first 300 lines, `<path>:1-3000` returns up to 3,000 per call, and when the footer says `[Showing lines … of N. Use :M to continue]` you continue with `:M-<M+2999>` until you have read all N lines. Never judge from a partial read. A line over 768 characters arrives truncated — `grep -n` the file to see one in full.
26
26
  - Then trace every patch-introduced type, value, or contract across its consuming side: the dispatch point is often outside the diff — read it before concluding the producer is correct.
27
- - If the dispatch names a high-risk change class (concurrency, security, a data migration), start there and go deeper.
27
+ - If the dispatch names a high-risk change class (concurrency, security, a data migration), go deepest there, after any task left to you for its task review. Code the dispatch lists as `rebased` or `Wave <K>: fix` had no task review: check it as if no one had.
28
28
  - Bash is read-only: `git log`, `git show`, `git diff`, running a focused test. Never edit, never run the whole suite.
29
29
  - Read-only is your rule, not the harness's: omp mounts MCP and extension tools on you as `xd://` devices reached through `write`, and the `tools:` list cannot remove them. Never call an `xd://` device, or any extension or MCP tool, that executes code, writes files, or changes external state — nor a memory tool that writes (`retain`, `memory_edit`) if your tool list shows one.
30
30
  - The spec is a vision document: it says what the software must do, not every input, environment, or condition it will meet. Where it is silent, a reasonable person's expectation is the requirement — the spec's silence is not permission. Grade such findings by their effect on that person, not by whether the spec mentions the trigger.
31
+ - A crash (an uncaught exception, a traceback) or lost data on input a user can give is always a finding, never a `Declined to judge` line, whatever the plan or spec says about that input.
31
32
  - If the dispatch carries the plan's Review Focus list, check each item deliberately: those are inputs and failure modes the plan's tests do not exercise.
32
33
  - Triage the ledger lines you were given: which deferred minors must be fixed before merge, which rulings you overturn — say why in one line each.
33
34
  - You do not dispatch subagents.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@loneexile/omp-superpowers",
3
- "version": "7.0.0-omp.1",
3
+ "version": "7.0.0-omp.3",
4
4
  "description": "obra/superpowers adapted for Oh My Pi (omp): a truthful task/todo tool mapping and five subagent-driven-development agents, each with its own model, thinking level, and tools.",
5
5
  "type": "module",
6
6
  "keywords": [
@@ -31,7 +31,8 @@ Your first message is two things, in this order:
31
31
  have you just start, they can say so. If they take you up on it, this
32
32
  skill is done: state any significant how-it-gets-made choice
33
33
  (platform, language, medium) in one plain line, then do what they
34
- asked through the normal workflow.
34
+ asked the way its size calls for (Size the Work, below). Their opt-out
35
+ is the approval a small change needs.
35
36
  2. One open question that gets them describing. Ask about a real moment
36
37
  or a concrete picture: "What's the moment you find yourself wishing
37
38
  this existed?" or "Tell me about the people who'll be in the room."
@@ -113,12 +114,15 @@ conversation.
113
114
 
114
115
  Play back as you go. As soon as you understand one part well enough to
115
116
  describe it (what it's for and who it serves, say, or how one piece
116
- behaves), describe that part back in about 200-300 words, then return to
117
- questions about the next part. Playback and questions alternate through
118
- the whole conversation; the last chunk covers whatever is left.
117
+ behaves), describe that part back in about 200-300 words. A playback
118
+ doesn't wait for its own answer: send it in the same message as your
119
+ next question, with one line saying they can correct anything in it in
120
+ their reply. The last chunk covers whatever is left and goes out with
121
+ the size you pick; for a small change, it ends by asking whether to
122
+ build it.
119
123
 
120
124
  Mark anything you're guessing as your guess; only what they said goes in
121
- as theirs. End each chunk by asking what's wrong or missing.
125
+ as theirs.
122
126
 
123
127
  Before you send a chunk, check it: does it describe something they'll
124
128
  look at, like a page, a screen, a schedule, or a printout? If so, and
@@ -134,9 +138,41 @@ words. They can override it.
134
138
  | Size | The full description | Then |
135
139
  |------|----------------------|------|
136
140
  | A quick, clear task | the request itself | do it |
137
- | A small change | in chat | build it through the normal workflow |
141
+ | A small change | in chat | the small-change path, below |
138
142
  | A project with a written design | a written design document | a full plan (for software: superpowers:writing-plans) |
139
143
 
144
+ **A small change** is one you can describe in a few lines of chat: it
145
+ stays inside one area of the work, adds nothing that other parts will
146
+ build on, and one revert undoes it. Adding a behavior can be small (a new
147
+ `--quiet` flag). These are never small; size them as projects: security,
148
+ authentication, concurrency, money, data migrations, anything one revert
149
+ cannot undo, and in software a new config file or stored format, a change
150
+ to existing behavior (a default, an exit code, error handling, what
151
+ happens with no input), a new interface other code builds on (plugins, a
152
+ public API), or a new dependency.
153
+
154
+ **The small-change path.** Once they approve the description, build it
155
+ yourself, in this session: no design document, no plan, no subagents.
156
+ For software:
157
+
158
+ 1. Run `git status --short` first and note anything that isn't yours. On
159
+ the default branch or a detached HEAD, start a branch for the change
160
+ (`git switch -c <topic>`), unless they told you to work where you are.
161
+ 2. Test first (superpowers:test-driven-development): a failing test,
162
+ then the code that makes it pass. A change no test can cover
163
+ (configuration, docs) gets the cheapest check that can fail instead:
164
+ a build, a lint, a parse. Their approval of the description covers
165
+ that exception.
166
+ 3. Run the tests that cover the change, then the full suite once.
167
+ 4. Commit once, staging your own files by path, never with `-a` or `-A`.
168
+ 5. Before you call it done, follow
169
+ superpowers:verification-before-completion: name the commit, the
170
+ command you ran, what it printed, and any changes in the tree that
171
+ aren't yours.
172
+
173
+ Your human partner reviews that commit; it is the only review a small
174
+ change gets. Outside software, make the change and show it to them.
175
+
140
176
  If it grows mid-task, stop, say so, and step up a size.
141
177
 
142
178
  If this is really several independent projects, say so, agree on an
@@ -154,14 +190,16 @@ could plan from without going back to your human partner. Cover:
154
190
  - what's left to the builder
155
191
 
156
192
  **Where it goes:** in a software repo,
157
- `docs/superpowers/specs/YYYY-MM-DD-<topic>-design.md`, committed.
193
+ `docs/specs/YYYY-MM-DD-<topic>-design.md`, committed.
158
194
  Otherwise, ask. Your human partner's preferences override both.
159
195
 
160
196
  **Builder check:** dispatch a fresh subagent with
161
197
  `builder-check-prompt.md` in this directory. When you tell your human
162
- partner you're writing it up, say a reviewer will read it first and you
163
- may come back once with a few questions. Don't hand over the document
164
- until the check is back. Sort what the builder asks into three piles:
198
+ partner you're writing it up, say a reviewer will read it first, that you
199
+ may come back once with a few questions, and, for software, that the
200
+ plan comes with it. Don't hand over the document until the check is
201
+ back. Without a subagent tool, read the document as that builder
202
+ yourself. Sort what the builder asks into three piles:
165
203
 
166
204
  - **Answered already** by the conversation or the project: put the answer
167
205
  in the document.
@@ -170,26 +208,31 @@ until the check is back. Sort what the builder asks into three piles:
170
208
  - **Theirs:** only your human partner can answer it, and the answer changes
171
209
  what gets built.
172
210
 
173
- Bring the "theirs" pile in one message, most important first. Update the
174
- document with their answers, then hand it over with a short list of the
175
- calls you made so they can check those while reading. That's the only
176
- round of questions the check produces. Without a subagent tool, read the
177
- document as that builder yourself.
211
+ Bring the "theirs" pile in one message, most important first. That's the
212
+ only round of questions the check produces. Update the document with
213
+ their answers. Then, for software, don't hand the document over on its
214
+ own: invoke superpowers:writing-plans and write the plan now, so your
215
+ human partner approves the design and its plan in one reading. The plan's
216
+ handoff asks for that approval and lists the calls you made. Outside
217
+ software, hand the document over with a short list of the calls you made
218
+ so they can check those while reading.
178
219
 
179
220
  <HARD-GATE>
180
221
  Nothing gets built until your human partner approves the full
181
- description: in chat for a small change, the document for a project.
182
- Building includes writing product code, scaffolding, installing
183
- dependencies, creating projects, and invoking an implementation skill.
184
- Reading and exploring are fine.
222
+ description: in chat for a small change; for a software project, the
223
+ design document and its plan together, in one approval; otherwise the
224
+ document. Building includes writing product code, scaffolding,
225
+ installing dependencies, creating projects, and invoking an
226
+ implementation skill. Reading, exploring, and writing the plan are fine.
185
227
 
186
228
  Two exceptions. If they opted out of the questions, the skill is done
187
229
  and the gate goes with it. A spike they said yes to may be built; it
188
230
  stays labeled throwaway, and keeping what it produced is a new request
189
231
  that comes back through this gate.
190
232
 
191
- After a project's document is approved, the next step is the plan. For
192
- software, invoke superpowers:writing-plans and no other skill.
233
+ The next step after the builder check is the plan. For software, write
234
+ it before the approval: invoke superpowers:writing-plans and no other
235
+ skill. Outside software, the plan follows the document's approval.
193
236
  </HARD-GATE>
194
237
 
195
238
  ## Red Flags
@@ -200,6 +243,7 @@ software, invoke superpowers:writing-plans and no other skill.
200
243
  | "I'll fill in sensible defaults" | Good. Say them out loud. A default they never heard is one they couldn't reject. |
201
244
  | "I should explain the process first" | Ask your question. The process shows itself. |
202
245
  | "They said 'sounds good' to the idea" | Approval covers what you showed them. A description you haven't written isn't approved. |
246
+ | "I'll get the design approved, then write the plan" | For software, write the plan first, so they approve both in one reading. A change to the design updates the plan before you ask again. |
203
247
  | "The spike works, I'll keep building on it" | Keeping it is a new request. Back through the gate. |
204
248
 
205
249
  ## Visual Companion
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: executing-plans
3
- description: Use when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is available
3
+ description: Use when executing an implementation plan in the current session as the implementer yourself — your human partner approved inline execution, or no subagent tool is available
4
4
  ---
5
5
 
6
6
  # Executing Plans
@@ -10,7 +10,7 @@ subagent per task, no reviewer per task. One fresh-context review of the
10
10
  whole branch at the end.
11
11
 
12
12
  **Why inline:** Subagent-driven development pays for a fresh implementer
13
- and a fresh reviewer on every task, each re-reading the codebase from zero.
13
+ on every task and a fresh reviewer on each high-risk one, each re-reading the codebase from zero.
14
14
  Inline execution pays for one context (yours) plus one reviewer at the end.
15
15
  What it gives up is a fresh context per task and a second pair of eyes per
16
16
  task. This skill keeps what those two things bought, by other means: the
@@ -25,7 +25,7 @@ record that survives your own forgetting.
25
25
  ledger and the tool results carry the record.
26
26
 
27
27
  **Continuous execution:** Do not pause to check in with your human partner
28
- between tasks. They chose inline execution to spend less, not to answer
28
+ between tasks. They approved inline execution to spend less, not to answer
29
29
  "should I continue?" after every task. Execute all tasks from the plan
30
30
  without stopping.
31
31
 
@@ -62,7 +62,7 @@ answers. The worktree and budget limits are in "Vibe mode" in
62
62
  ## When to Use
63
63
 
64
64
  - You have a plan from superpowers:writing-plans and your human partner
65
- chose inline execution at the handoff.
65
+ approved inline (Native) execution at the handoff.
66
66
  - Your harness has no subagent tool (see the per-platform references in
67
67
  `../using-superpowers/references/`). Never fabricate a dispatch; run
68
68
  the plan here.
@@ -74,8 +74,8 @@ it runs well on a mid-tier session model, and the one place the most
74
74
  capable model earns its cost is the final review, which this skill
75
75
  dispatches separately. Tell your human partner so when they choose inline.
76
76
 
77
- Prefer superpowers:subagent-driven-development when your human partner
78
- wants a review gate on every task, or when the plan is long enough that
77
+ Prefer superpowers:subagent-driven-development when the plan marks tasks
78
+ `**Review:** per-task`, when your human partner wants a review gate on every task, or when the plan is long enough that
79
79
  its later tasks would run on a compacted context. Inline execution over a
80
80
  long plan still works — the ledger is what makes it recoverable — but the
81
81
  last tasks get the least of you.
@@ -292,7 +292,9 @@ carries the model — so choosing the reviewer's model means choosing its
292
292
  agent. Dispatch `sdd-final-reviewer`, the whole-branch reviewer this
293
293
  plugin ships, not the bundled `reviewer` or `task` agent. Give it the
294
294
  inputs above and say the plan ran inline, with no task reviewed, so it
295
- checks every change rather than only cross-task seams. Do not paste
295
+ checks every change rather than only cross-task seams. Name every task the
296
+ plan marks `**Review:** per-task`, with its class, so it goes deepest
297
+ there. Do not paste
296
298
  code-reviewer.md into the dispatch: the agent reads the review rubric from
297
299
  it itself, and its own `<output>` governs. Its model is whatever this host
298
300
  maps that agent to: opus-5-5 · max by default (`@slow` when that pin has no
@@ -387,8 +389,8 @@ Use superpowers:finishing-a-development-branch.
387
389
  You: I'm using the executing-plans skill to implement this plan inline.
388
390
 
389
391
  [Setup: worktree verified]
390
- [Read plan once: docs/superpowers/plans/feature-plan.md; spec read]
391
- [Resolve workspace: sdd-workspace docs/superpowers/plans/feature-plan.md — no ledger inside, fresh start]
392
+ [Read plan once: docs/plans/feature-plan.md; spec read]
393
+ [Resolve workspace: sdd-workspace docs/plans/feature-plan.md — no ledger inside, fresh start]
392
394
  [Pre-flight scan: 2 shared-interface rows, 4 self-consistency rows, clean; written to ledger]
393
395
  [Create todos for all tasks]
394
396
 
@@ -12,7 +12,7 @@ Dispatch a code reviewer subagent to catch issues before they cascade. The revie
12
12
  ## When to Request Review
13
13
 
14
14
  **Mandatory:**
15
- - After each task in subagent-driven development
15
+ - After each task on subagent-driven development's review list, and once on the whole branch at the end
16
16
  - After completing major feature
17
17
  - Before merge to main
18
18
 
@@ -57,7 +57,7 @@ HEAD_SHA=$(git rev-parse HEAD)
57
57
 
58
58
  [Dispatch code reviewer subagent]
59
59
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
60
- PLAN_OR_REQUIREMENTS: Task 2 from docs/superpowers/plans/deployment-plan.md
60
+ PLAN_OR_REQUIREMENTS: Task 2 from docs/plans/deployment-plan.md
61
61
  BASE_SHA: a7981ec
62
62
  HEAD_SHA: 3df7661
63
63