@logto/connector-github 1.4.0 → 1.4.2

package/README.md

@@ -55,7 +55,7 @@ Fill out the `clientId` and `clientSecret` field with _Client ID_ and _Client Se
 
 ## Test GitHub connector
 
-That's it. The GitHub connector should be available now. Don't forget to [Enable connector in sign-in experience](https://docs.logto.io/docs/tutorials/get-started/passwordless-sign-in-by-adding-connectors#enable-social-sign-in).
+That's it. The GitHub connector should be available now. Don't forget to [Enable connector in sign-in experience](https://docs.logto.io/docs/recipes/configure-connectors/social-connector/enable-social-sign-in/).
 
 ## Reference
 

package/lib/index.js

@@ -26,6 +26,28 @@ const notFalsy = (value) => Boolean(value);
  */
 const conditional = (exp) => (notFalsy(exp) ? exp : undefined);
 
+// Intended
+// eslint-disable-next-line @typescript-eslint/no-empty-function
+const isPromise = (value) => value !== null &&
+    (typeof value === 'object' || typeof value === 'function') &&
+    'then' in value &&
+    typeof value.then === 'function';
+// eslint-disable-next-line @typescript-eslint/promise-function-async
+const trySafe = (exec, onError) => {
+    try {
+        const unwrapped = typeof exec === 'function' ? exec() : exec;
+        return isPromise(unwrapped)
+            ? // eslint-disable-next-line promise/prefer-await-to-then
+                unwrapped.catch((error) => {
+                    onError?.(error);
+                })
+            : unwrapped;
+    }
+    catch (error) {
+        onError?.(error);
+    }
+};
+
 // eslint-lint-disable-next-line @typescript-eslint/naming-convention
 class HTTPError extends Error {
     constructor(response, request, options) {
@@ -731,9 +753,16 @@ const getUserInfo = (getConfig) => async (data) => {
         },
     });
     try {
-        const [userInfo, userEmails] = await Promise.all([
+        /**
+         * If user(s) is using GitHub Apps (instead of OAuth Apps), they can customize
+         * "Account permissions" and restrict the "email addresses" visibility, and GitHub
+         * hence throws error instead of returning an empty array.
+         *
+         * We try catch the error and return an empty array instead.
+         */
+        const [userInfo, userEmails = []] = await Promise.all([
             authedApi.get(userInfoEndpoint).json(),
-            authedApi.get(userEmailsEndpoint).json(),
+            trySafe(authedApi.get(userEmailsEndpoint).json()),
         ]);
         const userInfoResult = userInfoResponseGuard.safeParse(userInfo);
         const userEmailsResult = emailAddressGuard.array().safeParse(userEmails);

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@logto/connector-github",
-  "version": "1.4.0",
+  "version": "1.4.2",
   "description": "Github web connector implementation.",
   "author": "Silverhand Inc. <contact@silverhand.io>",
   "dependencies": {
-    "@logto/connector-kit": "^3.0.0",
-    "@silverhand/essentials": "^2.9.0",
+    "@logto/connector-kit": "^4.0.0",
+    "@silverhand/essentials": "^2.9.1",
     "ky": "^1.2.3",
     "query-string": "^9.0.0",
     "snakecase-keys": "^8.0.0",
@@ -42,7 +42,7 @@
     "access": "public"
   },
   "devDependencies": {
-    "@rollup/plugin-commonjs": "^25.0.7",
+    "@rollup/plugin-commonjs": "^26.0.0",
     "@rollup/plugin-json": "^6.1.0",
     "@rollup/plugin-node-resolve": "^15.2.3",
     "@rollup/plugin-typescript": "^11.1.6",
@@ -53,7 +53,7 @@
     "@vitest/coverage-v8": "^1.4.0",
     "eslint": "^8.56.0",
     "lint-staged": "^15.0.2",
-    "nock": "14.0.0-beta.6",
+    "nock": "14.0.0-beta.7",
     "prettier": "^3.0.0",
     "rollup": "^4.12.0",
     "rollup-plugin-output-size": "^1.3.0",