@logictan/dsh-imagegen 2.0.5 → 2.0.6

package/lib/client.js

@@ -2416,31 +2416,39 @@ window.__ModuleLoader__.load({
 					invalid: write === void 0 && !(spec.secret === true && staged.text.trim() === "")
 				};
 			}
-			/** The actions the card's slot registration injects. */
+			/**
+			* The actions the card's slot registration injects.
+			*
+			* Built once. The slot calls `inject()` on every render, and a fresh object
+			* with fresh closures each time changes the props the renderer subscribed
+			* with, which re-renders forever (React error #185). These closures only ever
+			* capture `this`, so one instance serves every call.
+			*/
+			actionSet = {
+				edit: (field, text) => {
+					this.stage(field, {
+						text,
+						clear: false
+					});
+				},
+				resetField: (field) => {
+					this.stage(field, {
+						text: this.specOf(field).format(this.baseValue(field)),
+						clear: true
+					});
+				},
+				save: () => {
+					this.save();
+				},
+				discard: () => {
+					if (this.staged.size === 0 && !this.failed) return;
+					this.staged.clear();
+					this.failed = false;
+					this.publish();
+				}
+			};
 			actions() {
-				return {
-					edit: (field, text) => {
-						this.stage(field, {
-							text,
-							clear: false
-						});
-					},
-					resetField: (field) => {
-						this.stage(field, {
-							text: this.specOf(field).format(this.baseValue(field)),
-							clear: true
-						});
-					},
-					save: () => {
-						this.save();
-					},
-					discard: () => {
-						if (this.staged.size === 0 && !this.failed) return;
-						this.staged.clear();
-						this.failed = false;
-						this.publish();
-					}
-				};
+				return this.actionSet;
 			}
 			/**
 			* Write every staged edit, then re-seed from what the Host accepted.
@@ -2671,36 +2679,44 @@ window.__ModuleLoader__.load({
 					failed: this.failed
 				};
 			}
-			/** The actions the card's slot registration injects. */
+			/**
+			* The actions the card's slot registration injects, built once.
+			*
+			* The slot calls `inject()` on every render, and a fresh object with fresh
+			* closures each time changes the props the renderer subscribed with, which
+			* re-renders forever (React error #185). These closures only ever capture
+			* `this`, so one instance serves every call.
+			*/
+			actionSet = {
+				setChannels: (channels) => {
+					this.stageChannels(channels);
+				},
+				setChannelKey: (id, value) => {
+					this.stageKey(id, value);
+				},
+				setDefaultChannel: (id) => {
+					this.stagedDefault = id;
+					this.failed = false;
+					this.publish();
+				},
+				setDefaultModel: (model) => {
+					this.stagedDefaultModel = model;
+					this.failed = false;
+					this.publish();
+				},
+				commit: () => this.commit(),
+				discard: () => {
+					if (this.stagedChannels === null && this.stagedKeys.size === 0 && this.stagedDefault === null && this.stagedDefaultModel === null && !this.failed) return;
+					this.stagedChannels = null;
+					this.stagedKeys.clear();
+					this.stagedDefault = null;
+					this.stagedDefaultModel = null;
+					this.failed = false;
+					this.publish();
+				}
+			};
 			actions() {
-				return {
-					setChannels: (channels) => {
-						this.stageChannels(channels);
-					},
-					setChannelKey: (id, value) => {
-						this.stageKey(id, value);
-					},
-					setDefaultChannel: (id) => {
-						this.stagedDefault = id;
-						this.failed = false;
-						this.publish();
-					},
-					setDefaultModel: (model) => {
-						this.stagedDefaultModel = model;
-						this.failed = false;
-						this.publish();
-					},
-					commit: () => this.commit(),
-					discard: () => {
-						if (this.stagedChannels === null && this.stagedKeys.size === 0 && this.stagedDefault === null && this.stagedDefaultModel === null && !this.failed) return;
-						this.stagedChannels = null;
-						this.stagedKeys.clear();
-						this.stagedDefault = null;
-						this.stagedDefaultModel = null;
-						this.failed = false;
-						this.publish();
-					}
-				};
+				return this.actionSet;
 			}
 			stageChannels(channels) {
 				const cleaned = channels.map(stripChannel);
@@ -2991,73 +3007,73 @@ window.__ModuleLoader__.load({
 			document.head.appendChild(tag);
 		}
 		var settings_card_module_css_default = {
-			"modelRowInputs": "_5JdLea_modelRowInputs",
-			"modelRowBadges": "_5JdLea_modelRowBadges",
-			"readOnly": "_5JdLea_readOnly",
-			"editorClose": "_5JdLea_editorClose",
-			"editorField": "_5JdLea_editorField",
-			"optionalContent": "_5JdLea_optionalContent",
-			"head": "_5JdLea_head",
-			"presetRow": "_5JdLea_presetRow",
-			"manualModelRow": "_5JdLea_manualModelRow",
-			"chevron": "_5JdLea_chevron",
-			"editorSectionHeader": "_5JdLea_editorSectionHeader",
 			"badges": "_5JdLea_badges",
+			"failed": "_5JdLea_failed",
+			"deleteConfirmText": "_5JdLea_deleteConfirmText",
+			"channelRow": "_5JdLea_channelRow",
+			"presetInlineHeader": "_5JdLea_presetInlineHeader",
+			"editorTools": "_5JdLea_editorTools",
+			"chevron": "_5JdLea_chevron",
+			"modelRowRemove": "_5JdLea_modelRowRemove",
+			"inlineDisclosure": "_5JdLea_inlineDisclosure",
+			"editorBackdrop": "_5JdLea_editorBackdrop",
+			"sectionHint": "_5JdLea_sectionHint",
+			"editorPanel": "_5JdLea_editorPanel",
+			"channelMeta": "_5JdLea_channelMeta",
 			"chevronOpen": "_5JdLea_chevronOpen",
+			"headText": "_5JdLea_headText",
+			"footer": "_5JdLea_footer",
+			"editorField": "_5JdLea_editorField",
+			"modelRow": "_5JdLea_modelRow",
+			"disclosure": "_5JdLea_disclosure",
+			"presetMeta": "_5JdLea_presetMeta",
 			"editorDivider": "_5JdLea_editorDivider",
-			"editorFooter": "_5JdLea_editorFooter",
+			"presetInline": "_5JdLea_presetInline",
+			"name": "_5JdLea_name",
+			"invalid": "_5JdLea_invalid",
+			"reset": "_5JdLea_reset",
+			"presetName": "_5JdLea_presetName",
+			"card": "_5JdLea_card",
+			"description": "_5JdLea_description",
+			"channelEmpty": "_5JdLea_channelEmpty",
+			"channelList": "_5JdLea_channelList",
+			"header": "_5JdLea_header",
+			"modelCandidateLabel": "_5JdLea_modelCandidateLabel",
+			"editorSectionHeader": "_5JdLea_editorSectionHeader",
 			"detectOk": "_5JdLea_detectOk",
-			"failed": "_5JdLea_failed",
 			"modelArrow": "_5JdLea_modelArrow",
-			"spacer": "_5JdLea_spacer",
-			"modelCandidateLabel": "_5JdLea_modelCandidateLabel",
-			"pending": "_5JdLea_pending",
-			"channelMain": "_5JdLea_channelMain",
-			"body": "_5JdLea_body",
-			"description": "_5JdLea_description",
-			"label": "_5JdLea_label",
+			"modelRowBadges": "_5JdLea_modelRowBadges",
+			"presetRow": "_5JdLea_presetRow",
+			"presetHint": "_5JdLea_presetHint",
+			"manualModelRow": "_5JdLea_manualModelRow",
 			"notExposed": "_5JdLea_notExposed",
 			"hint": "_5JdLea_hint",
-			"modelRows": "_5JdLea_modelRows",
-			"sectionHeader": "_5JdLea_sectionHeader",
-			"channelControls": "_5JdLea_channelControls",
-			"presetName": "_5JdLea_presetName",
+			"channelMain": "_5JdLea_channelMain",
+			"body": "_5JdLea_body",
+			"optionalContent": "_5JdLea_optionalContent",
 			"channelSection": "_5JdLea_channelSection",
-			"sectionHint": "_5JdLea_sectionHint",
-			"presetMeta": "_5JdLea_presetMeta",
-			"editorTools": "_5JdLea_editorTools",
-			"modelRow": "_5JdLea_modelRow",
-			"name": "_5JdLea_name",
+			"editorFooter": "_5JdLea_editorFooter",
+			"modelRowInputs": "_5JdLea_modelRowInputs",
+			"head": "_5JdLea_head",
+			"pending": "_5JdLea_pending",
+			"editorHeader": "_5JdLea_editorHeader",
+			"channelControls": "_5JdLea_channelControls",
+			"channelName": "_5JdLea_channelName",
+			"readOnly": "_5JdLea_readOnly",
 			"modelCandidate": "_5JdLea_modelCandidate",
-			"editorBackdrop": "_5JdLea_editorBackdrop",
-			"inlineDisclosure": "_5JdLea_inlineDisclosure",
-			"schemaSection": "_5JdLea_schemaSection",
-			"card": "_5JdLea_card",
-			"deleteConfirmText": "_5JdLea_deleteConfirmText",
-			"presetInline": "_5JdLea_presetInline",
+			"channelAddRow": "_5JdLea_channelAddRow",
 			"presetList": "_5JdLea_presetList",
-			"reset": "_5JdLea_reset",
-			"invalid": "_5JdLea_invalid",
-			"editorPanel": "_5JdLea_editorPanel",
-			"headText": "_5JdLea_headText",
-			"channelEmpty": "_5JdLea_channelEmpty",
-			"modelRowRemove": "_5JdLea_modelRowRemove",
-			"presetHint": "_5JdLea_presetHint",
-			"field": "_5JdLea_field",
-			"disclosure": "_5JdLea_disclosure",
-			"editorHeader": "_5JdLea_editorHeader",
-			"channelMeta": "_5JdLea_channelMeta",
 			"modelCandidateList": "_5JdLea_modelCandidateList",
-			"channelRow": "_5JdLea_channelRow",
-			"header": "_5JdLea_header",
+			"editorClose": "_5JdLea_editorClose",
+			"spacer": "_5JdLea_spacer",
+			"label": "_5JdLea_label",
+			"field": "_5JdLea_field",
+			"schemaSection": "_5JdLea_schemaSection",
+			"sectionHeader": "_5JdLea_sectionHeader",
 			"modelChip": "_5JdLea_modelChip",
-			"presetInlineHeader": "_5JdLea_presetInlineHeader",
-			"sectionTitle": "_5JdLea_sectionTitle",
 			"modelSummary": "_5JdLea_modelSummary",
-			"footer": "_5JdLea_footer",
-			"channelAddRow": "_5JdLea_channelAddRow",
-			"channelList": "_5JdLea_channelList",
-			"channelName": "_5JdLea_channelName"
+			"sectionTitle": "_5JdLea_sectionTitle",
+			"modelRows": "_5JdLea_modelRows"
 		};
 		//#endregion
 		//#region src/client/SettingsCard.tsx
@@ -3123,15 +3139,22 @@ window.__ModuleLoader__.load({
 		* plugin's own interface precise instead of adding an index signature to it.
 		*/
 		function asConfigFormHandle(scope) {
+			let cachedFrom;
+			let cached;
+			const project = (snapshot) => ({
+				status: snapshot.status,
+				value: snapshot.value,
+				writable: snapshot.writable,
+				revision: snapshot.revision
+			});
 			return {
 				getSnapshot() {
 					const snapshot = scope.getSnapshot();
-					return {
-						status: snapshot.status,
-						value: snapshot.value,
-						writable: snapshot.writable,
-						revision: snapshot.revision
-					};
+					if (snapshot !== cachedFrom) {
+						cachedFrom = snapshot;
+						cached = project(snapshot);
+					}
+					return cached;
 				},
 				subscribe(listener) {
 					return scope.subscribe(listener);
@@ -3146,11 +3169,27 @@ window.__ModuleLoader__.load({
 			scope;
 			form;
 			channelsForm;
+			/**
+			* The two face values that must keep their identity across `inject()` calls.
+			*
+			* The slot calls `inject()` on every render. Building either of these fresh
+			* there changes the prop identity the renderer subscribed with, which
+			* schedules another render, which calls `inject()` again — React reports that
+			* as error #185 (`Maximum update depth exceeded`) and the slot renders as an
+			* error node with no controls under it.
+			*/
+			cardStore;
+			schemaMirror;
 			/** @param scope - the bound bridge scope for the dsh-imagegen namespace. */
 			constructor(scope) {
 				this.scope = scope;
 				this.form = new CardForm(scope, [secretField("promptApiKey")], { secretSettled: (field) => this.scope.getSecretSetSnapshot(field) });
 				this.channelsForm = new ChannelsForm(scope);
+				this.schemaMirror = createSchemaMirror(scope);
+				this.cardStore = this.form.bind(() => this.projection());
+				this.channelsForm.subscribe(() => {
+					this.cardStore.set(this.projection());
+				});
 			}
 			projection() {
 				const shell = this.form.shell();
@@ -3158,12 +3197,7 @@ window.__ModuleLoader__.load({
 					...shell,
 					dirty: shell.dirty || this.channelsForm.snapshot().dirty,
 					channels: this.channelsForm.snapshot(),
-					enabled: this.form.field("enabled"),
-					announceToAgent: this.form.field("announceToAgent"),
-					allowAgentImageGeneration: this.form.field("allowAgentImageGeneration"),
-					promptApiUrl: this.form.field("promptApiUrl"),
-					promptApiKey: this.form.field("promptApiKey"),
-					promptModel: this.form.field("promptModel")
+					promptApiKey: this.form.field("promptApiKey")
 				};
 			}
 			/**
@@ -3171,15 +3205,11 @@ window.__ModuleLoader__.load({
 			* @returns the card's snapshot and the form/channel actions.
 			*/
 			inject() {
-				const cardStore = this.form.bind(() => this.projection());
-				this.channelsForm.subscribe(() => {
-					cardStore.set(this.projection());
-				});
 				return {
-					hooks: { imageGenSettingsCard: cardStore },
+					hooks: { imageGenSettingsCard: this.cardStore },
 					channels: this.channelsForm.actions(),
 					settingsScope: this.scope,
-					schemaMirror: createSchemaMirror(this.scope),
+					schemaMirror: this.schemaMirror,
 					...this.form.actions()
 				};
 			}
@@ -3202,6 +3232,7 @@ window.__ModuleLoader__.load({
 			const t = tt;
 			useImageGenLanguageTick();
 			const state = props.useImageGenSettingsCard((snapshot) => snapshot);
+			const formHandle = (0, react.useMemo)(() => asConfigFormHandle(props.settingsScope), [props.settingsScope]);
 			const liveModel = props.settingsScope.getSnapshot().value?.promptModel ?? "";
 			const [open, setOpen] = (0, react.useState)(false);
 			const [promptModels, setPromptModels] = (0, react.useState)([]);
@@ -3302,7 +3333,7 @@ window.__ModuleLoader__.load({
 							className: settings_card_module_css_default.schemaSection,
 							children: /* @__PURE__ */ (0, react_jsx_runtime.jsxs)(_logictan_dsh_plugins_shared_client_client.ConfigForm, {
 								namespace: IMAGEGEN_SETTINGS_NAMESPACE,
-								form: asConfigFormHandle(props.settingsScope),
+								form: formHandle,
 								describe: props.schemaMirror,
 								title: t("settings.scalarsTitle"),
 								children: [
@@ -4439,16 +4470,16 @@ window.__ModuleLoader__.load({
 			document.head.appendChild(tag);
 		}
 		var image_toolview_module_css_default = {
+			"images": "UtJPoq_images",
+			"imageLink": "UtJPoq_imageLink",
 			"image": "UtJPoq_image",
-			"status": "UtJPoq_status",
+			"icon": "UtJPoq_icon",
 			"message": "UtJPoq_message",
+			"header": "UtJPoq_header",
 			"loading": "UtJPoq_loading",
-			"images": "UtJPoq_images",
-			"imageLink": "UtJPoq_imageLink",
 			"error": "UtJPoq_error",
-			"icon": "UtJPoq_icon",
 			"root": "UtJPoq_root",
-			"header": "UtJPoq_header"
+			"status": "UtJPoq_status"
 		};
 		//#endregion
 		//#region src/client/image-toolview.tsx