@logictan/dsh-config-manager 0.1.60

package/src/index.facade.test.ts

@@ -0,0 +1,265 @@
+/**
+ * DshPluginsFacade / ensureActivationRow 测试（M5 补写，failing-first 目标）：
+ *   - install 无 marketplace 时走官方 dsh plugin CLI 通道，且绝不抛「插件市场服务不可用」
+ *   - listInstalled 委托 profile 文件实时读取（真实版本）
+ *   - ensureActivationRow 幂等（重复安装不重复行；bundle 包跳过）
+ *
+ * 通过注入 mock runner（DshPluginsFacade 构造器第 4 参）拦截子进程，不触发真实
+ * dsh/pnpm；profile 目录用真实临时目录（node:fs），node_modules 落盘 package.json
+ * 驱动 hasDshBundlePatch 判定。
+ */
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+
+import { DshPluginsFacade, ensureActivationRow } from './index.ts';
+import { resolveProfileDir } from './core/plugin-cli.ts';
+import type { DshPluginResult } from './core/plugin-cli.ts';
+import type { PatchChange, PatchFileFacade } from './core/types.ts';
+
+/* ------------------------------------------------ mock 基础设施 */
+
+class MemPatchFile implements PatchFileFacade {
+  lines = new Map<string, { lineId: string; raw: unknown }>();
+  async readPatchLines(_file: string): Promise<{ lineId: string; raw: unknown }[]> {
+    return [...this.lines.values()];
+  }
+  async applyPatchChanges(_file: string, changes: PatchChange[]): Promise<void> {
+    for (const c of changes) {
+      if (c.action === 'remove') this.lines.delete(c.lineId);
+      else this.lines.set(c.lineId, { lineId: c.lineId, raw: c.raw });
+    }
+  }
+}
+
+interface TempProfile {
+  homeDir: string;
+  profileDir: string;
+  cleanup: () => void;
+}
+
+function makeTempProfile(): TempProfile {
+  const homeDir = mkdtempSync(join(tmpdir(), 'dsh-cm-facade-'));
+  const profileDir = resolveProfileDir(homeDir, 'web');
+  mkdirSync(profileDir, { recursive: true });
+  return {
+    homeDir,
+    profileDir,
+    cleanup: () => rmSync(homeDir, { recursive: true, force: true }),
+  };
+}
+
+/** 写 node_modules/<name>/package.json；bundlePatch 缺省 = 非 bundle。 */
+function writeInstalledPkg(profileDir: string, name: string, version: string, bundlePatch?: string): void {
+  const pkgDir = join(profileDir, 'node_modules', name);
+  mkdirSync(pkgDir, { recursive: true });
+  const manifest: Record<string, unknown> = { name, version };
+  if (bundlePatch !== undefined) manifest['dsh'] = { bundle: { patch: bundlePatch } };
+  writeFileSync(join(pkgDir, 'package.json'), `${JSON.stringify(manifest, null, 2)}\n`, 'utf8');
+}
+
+function okResult(): DshPluginResult {
+  return { exitCode: 0, timedOut: false, stdout: '', stderr: '' };
+}
+
+/* ------------------------------------------------------- 测试主体 */
+
+test('install: 无 marketplace 时走 CLI 通道（mock runner 记录 argv），成功 → needsRestart + 非 bundle 补激活行', async () => {
+  const { homeDir, profileDir, cleanup } = makeTempProfile();
+  try {
+    writeInstalledPkg(profileDir, 'pkg-a', '1.0.0'); // 非 bundle
+    const calls: { profileDir: string; profile: string; args: string[] }[] = [];
+    const runner = async (p: string, profile: string, args: readonly string[]): Promise<DshPluginResult> => {
+      calls.push({ profileDir: p, profile, args: [...args] });
+      return okResult();
+    };
+    const patchFile = new MemPatchFile();
+    const facade = new DshPluginsFacade(homeDir, 'web', patchFile, runner);
+
+    const r = await facade.install('pkg-a');
+    assert.equal(r.needsRestart, true);
+    assert.equal(calls.length, 1, 'install 恰好一次 CLI 调用');
+    assert.equal(calls[0]?.profileDir, profileDir);
+    assert.equal(calls[0]?.profile, 'web');
+    assert.deepEqual(calls[0]?.args, ['add', 'pkg-a'], '必须构造 dsh plugin --profile web add pkg-a 的 argv');
+    // 非 bundle：成功路径幂等补激活行
+    assert.deepEqual(
+      [...patchFile.lines.keys()],
+      ['pm-pkg-a'],
+      '非 bundle 插件安装后写入 pm-<slug> 激活行',
+    );
+    assert.deepEqual(patchFile.lines.get('pm-pkg-a')?.raw, { id: 'pm-pkg-a', name: 'pkg-a' });
+  } finally {
+    cleanup();
+  }
+});
+
+test('install: bundle 包成功 → 不补 patch 行（reconcile 维护 bundles）', async () => {
+  const { homeDir, profileDir, cleanup } = makeTempProfile();
+  try {
+    writeInstalledPkg(profileDir, 'pkg-bundle', '1.0.0', 'patch.yml'); // bundle
+    const runner = async (): Promise<DshPluginResult> => okResult();
+    const patchFile = new MemPatchFile();
+    const facade = new DshPluginsFacade(homeDir, 'web', patchFile, runner);
+
+    await facade.install('pkg-bundle');
+    assert.equal(patchFile.lines.size, 0, 'bundle 包不写 patch 行');
+  } finally {
+    cleanup();
+  }
+});
+
+test('install: 非 registry spec（github:）→ add 按 spec 安装；registry 版本区间 → 裸包名（npm 最新）', async () => {
+  const { homeDir, profileDir, cleanup } = makeTempProfile();
+  try {
+    writeInstalledPkg(profileDir, 'dsh-memory-evolve', '1.0.0');
+    writeInstalledPkg(profileDir, 'dshmarket', '1.0.3');
+    const calls: { args: string[] }[] = [];
+    const runner = async (_p: string, _profile: string, args: readonly string[]): Promise<DshPluginResult> => {
+      calls.push({ args: [...args] });
+      return okResult();
+    };
+    const facade = new DshPluginsFacade(homeDir, 'web', new MemPatchFile(), runner);
+
+    await facade.install('dsh-memory-evolve', 'github:csyangwen/dsh-memory-evolve');
+    await facade.install('dshmarket', '^1.0.3');
+    await facade.install('pkg-plain');
+    assert.deepEqual(calls.map((c) => c.args), [
+      ['add', 'github:csyangwen/dsh-memory-evolve'],
+      ['add', 'dshmarket'],
+      ['add', 'pkg-plain'],
+    ], 'github: 来源按 spec 安装；registry 版本区间与裸包名都走 npm 最新版');
+  } finally {
+    cleanup();
+  }
+});
+
+test('install: CLI 失败 → 分类后的可读错误，且绝不出现「插件市场服务不可用」', async () => {
+  const { homeDir, profileDir, cleanup } = makeTempProfile();
+  try {
+    writeInstalledPkg(profileDir, 'pkg-a', '1.0.0');
+    const runner = async (): Promise<DshPluginResult> => ({
+      exitCode: 1, timedOut: false, stdout: '',
+      stderr: 'ERR_PNPM_FETCH_404 GET https://registry.npmjs.org/ghost-pkg: Not Found - 404',
+    });
+    const facade = new DshPluginsFacade(homeDir, 'web', new MemPatchFile(), runner);
+
+    await assert.rejects(
+      () => facade.install('pkg-a'),
+      (err: unknown) => {
+        const msg = err instanceof Error ? err.message : String(err);
+        assert.match(msg, /fetch-404/, '错误必须带分类 code');
+        assert.doesNotMatch(msg, /插件市场服务不可用/, 'CLI 通道失败绝不能回退到 marketplace 报错');
+        return true;
+      },
+    );
+  } finally {
+    cleanup();
+  }
+});
+
+test('install: 激活行补写失败 → 明确报错（不吞），允许重试幂等补行', async () => {
+  const { homeDir, profileDir, cleanup } = makeTempProfile();
+  try {
+    writeInstalledPkg(profileDir, 'pkg-a', '1.0.0');
+    const runner = async (): Promise<DshPluginResult> => okResult();
+    const brokenPatch = new MemPatchFile();
+    brokenPatch.applyPatchChanges = async () => {
+      throw new Error('disk full');
+    };
+    const facade = new DshPluginsFacade(homeDir, 'web', brokenPatch, runner);
+
+    await assert.rejects(
+      () => facade.install('pkg-a'),
+      /激活行写入 profile 补丁失败/,
+    );
+  } finally {
+    cleanup();
+  }
+});
+
+test('listInstalled: 委托 profile 文件实时读取，返回真实落盘版本', async () => {
+  const { homeDir, profileDir, cleanup } = makeTempProfile();
+  try {
+    writeFileSync(
+      join(profileDir, 'package.json'),
+      JSON.stringify({
+        name: 'dsh-profile-web',
+        dependencies: { '@linxin666/dsh-ssh': '^0.1.0', 'pkg-a': '1.0.0', '@deepseek-ai/dsh-base': '0.1.0-rc.6' },
+        dsh: { profile: { bundles: ['@linxin666/dsh-ssh'] } },
+      }, null, 2) + '\n',
+      'utf8',
+    );
+    writeInstalledPkg(profileDir, '@linxin666/dsh-ssh', '0.1.12', 'patch.yml');
+    writeInstalledPkg(profileDir, 'pkg-a', '1.0.0');
+    writeInstalledPkg(profileDir, '@deepseek-ai/dsh-base', '0.1.0-rc.6');
+
+    const facade = new DshPluginsFacade(homeDir, 'web', new MemPatchFile(), async () => okResult());
+    const list = await facade.listInstalled();
+    const ssh = list.find((p) => p.name === '@linxin666/dsh-ssh');
+    assert.equal(ssh?.version, '0.1.12', '真实落盘版本（声明是 ^0.1.0）');
+    assert.equal(ssh?.isBundle, true);
+    assert.equal(list.some((p) => p.name === '@deepseek-ai/dsh-base'), false);
+  } finally {
+    cleanup();
+  }
+});
+
+test('ensureActivationRow: 幂等——重复安装不重复行', async () => {
+  const { profileDir, cleanup } = makeTempProfile();
+  try {
+    writeInstalledPkg(profileDir, 'pkg-a', '1.0.0');
+    const patchFile = new MemPatchFile();
+
+    await ensureActivationRow(patchFile, join(profileDir, 'node_modules', 'pkg-a'), 'pkg-a');
+    await ensureActivationRow(patchFile, join(profileDir, 'node_modules', 'pkg-a'), 'pkg-a');
+    await ensureActivationRow(patchFile, join(profileDir, 'node_modules', 'pkg-a'), 'pkg-a');
+    assert.equal(patchFile.lines.size, 1, '三次调用只产生一行');
+  } finally {
+    cleanup();
+  }
+});
+
+test('ensureActivationRow: 已有同 name 行（任意 id）→ 不重复插入', async () => {
+  const { profileDir, cleanup } = makeTempProfile();
+  try {
+    writeInstalledPkg(profileDir, 'pkg-a', '1.0.0');
+    const patchFile = new MemPatchFile();
+    patchFile.lines.set('user-line', { lineId: 'user-line', raw: { id: 'user-line', name: 'pkg-a' } });
+
+    await ensureActivationRow(patchFile, join(profileDir, 'node_modules', 'pkg-a'), 'pkg-a');
+    assert.equal(patchFile.lines.size, 1, '按 name 去重，不新增行');
+    assert.equal(patchFile.lines.has('user-line'), true);
+  } finally {
+    cleanup();
+  }
+});
+
+test('ensureActivationRow: bundle 包跳过（reconcile 已维护 bundles）', async () => {
+  const { profileDir, cleanup } = makeTempProfile();
+  try {
+    writeInstalledPkg(profileDir, 'pkg-bundle', '1.0.0', 'patch.yml');
+    const patchFile = new MemPatchFile();
+
+    await ensureActivationRow(patchFile, join(profileDir, 'node_modules', 'pkg-bundle'), 'pkg-bundle');
+    assert.equal(patchFile.lines.size, 0, 'bundle 包不写 patch 行');
+  } finally {
+    cleanup();
+  }
+});
+
+test('ensureActivationRow: scope 包名 slug 形态正确（@scope/name → pm-scope-name）', async () => {
+  const { profileDir, cleanup } = makeTempProfile();
+  try {
+    writeInstalledPkg(profileDir, '@org/pkg-a', '1.0.0');
+    const patchFile = new MemPatchFile();
+
+    await ensureActivationRow(patchFile, join(profileDir, 'node_modules', '@org', 'pkg-a'), '@org/pkg-a');
+    assert.equal(patchFile.lines.size, 1);
+    assert.equal(patchFile.lines.has('pm-org-pkg-a'), true, '去 @ 后连字符 slug');
+  } finally {
+    cleanup();
+  }
+});

package/src/index.sync.test.ts

@@ -0,0 +1,217 @@
+/**
+ * M3：Host 同步路由的 transport 分支解析与校验测试（failing-first 目标）。
+ *
+ * 直接测导出的纯函数（仿 buildRestoreBody 模式），不依赖真实 Cordis Context：
+ * - parseSyncBody：按 body.transport 分支解析 git/webdav（可辨识联合 SyncConfig）；
+ *   必填校验；validateWebDavUrl/validateRepoUrl；password/token 非空写入对应
+ *   独立 credentials ref（SYNC_WEBDAV_CREDENTIAL_REF / SYNC_CREDENTIAL_REF）。
+ * - webdavBaseUrl：由 webdav.url 合成通道 baseUrl（尾部 '/'）；git 通道返回 ''。
+ * - SyncRouteError：非 2xx 请求级错误。
+ *
+ * 凭据用内存 mock（记录 set 的 (ref, value)），不触碰真实 DSH credentials。
+ */
+import test from 'node:test';
+import assert from 'node:assert/strict';
+
+import {
+  parseSyncBody, webdavBaseUrl, extractSyncSections, mergePersistedWebDavUsername, SyncRouteError,
+  SYNC_CREDENTIAL_REF, SYNC_WEBDAV_CREDENTIAL_REF,
+  type ParseSyncBodyDeps,
+} from './index.ts';
+import { isWebDavConfig, type SyncConfig } from './sync/sync-config.ts';
+
+/** 内存凭据 mock：记录写入的 (ref, value) 列表 */
+function memCreds(): ParseSyncBodyDeps & { writes: Array<[string, string]>; } {
+  const writes: Array<[string, string]> = [];
+  return {
+    writes,
+    credentials: {
+      async set(ref: unknown, value: string) {
+        writes.push([String(ref), value]);
+      },
+    } as unknown as ParseSyncBodyDeps['credentials'],
+  };
+}
+
+/* ---------------- git 分支 ---------------- */
+
+test('parseSyncBody: git 分支（缺省 transport）解析 repoUrl（gitBin 已废弃），token 写入 SYNC_CREDENTIAL_REF', async () => {
+  const deps = memCreds();
+  const cfg = await parseSyncBody(
+    { repoUrl: 'https://github.com/foo/bar.git', gitBin: '/usr/bin/git', token: 'tok-123' },
+    deps,
+  );
+  assert.deepEqual(cfg, {
+    schemaVersion: 2,
+    transport: 'git',
+    git: { repoUrl: 'https://github.com/foo/bar.git' },
+  });
+  assert.deepEqual(deps.writes, [[SYNC_CREDENTIAL_REF, 'tok-123']], 'token 写 git credentials ref，不写 webdav ref');
+});
+
+test('parseSyncBody: git 分支无 token → 不写凭据', async () => {
+  const deps = memCreds();
+  const cfg = await parseSyncBody({ repoUrl: 'git@github.com:foo/bar.git' }, deps);
+  assert.deepEqual(cfg, { schemaVersion: 2, transport: 'git', git: { repoUrl: 'git@github.com:foo/bar.git' } });
+  assert.equal(deps.writes.length, 0, '无 token 不产生凭据写入');
+});
+
+test('parseSyncBody: git 分支缺 repoUrl → SyncRouteError', async () => {
+  const deps = memCreds();
+  await assert.rejects(
+    () => parseSyncBody({ transport: 'git' }, deps),
+    (err) => err instanceof SyncRouteError && /repoUrl is required/.test(err.message),
+  );
+});
+
+test('parseSyncBody: git 分支 repoUrl 含 userinfo（token 拼 URL）→ 拒绝', async () => {
+  const deps = memCreds();
+  await assert.rejects(
+    () => parseSyncBody({ repoUrl: 'https://user:pass@github.com/foo/bar.git' }, deps),
+    (err) => err instanceof SyncRouteError,
+  );
+});
+
+/* ---------------- webdav 分支 ---------------- */
+
+test('parseSyncBody: webdav 分支解析 url/username，password 写入 SYNC_WEBDAV_CREDENTIAL_REF', async () => {
+  const deps = memCreds();
+  const cfg = await parseSyncBody(
+    {
+      transport: 'webdav',
+      url: 'https://dav.example.com/remote.php/dav/files/user',
+      username: 'alice',
+      password: 'pw-secret',
+    },
+    deps,
+  );
+  assert.deepEqual(cfg, {
+    schemaVersion: 2,
+    transport: 'webdav',
+    webdav: { url: 'https://dav.example.com/remote.php/dav/files/user', username: 'alice' },
+  });
+  assert.deepEqual(deps.writes, [[SYNC_WEBDAV_CREDENTIAL_REF, 'pw-secret']], 'password 写独立 webdav credentials ref');
+});
+
+test('parseSyncBody: webdav 分支缺 url → SyncRouteError', async () => {
+  const deps = memCreds();
+  await assert.rejects(
+    () => parseSyncBody({ transport: 'webdav', username: 'alice' }, deps),
+    (err) => err instanceof SyncRouteError && /url is required/.test(err.message),
+  );
+});
+
+test('parseSyncBody: webdav 分支 url 非 http(s)/含 userinfo → 拒绝', async () => {
+  const deps = memCreds();
+  await assert.rejects(
+    () => parseSyncBody({ transport: 'webdav', url: 'ftp://dav.example.com' }, deps),
+    (err) => err instanceof SyncRouteError,
+  );
+  await assert.rejects(
+    () => parseSyncBody({ transport: 'webdav', url: 'https://u:p@dav.example.com' }, deps),
+    (err) => err instanceof SyncRouteError,
+  );
+});
+
+test('parseSyncBody: webdav 分支无 password → 不写凭据', async () => {
+  const deps = memCreds();
+  const cfg = await parseSyncBody({ transport: 'webdav', url: 'https://dav.example.com' }, deps);
+  assert.equal(cfg.transport, 'webdav');
+  assert.equal(deps.writes.length, 0);
+});
+
+test('parseSyncBody: HTTP 凭据写入失败 → SyncRouteError（含 ref 名，无 secret）', async () => {
+  const deps: ParseSyncBodyDeps = {
+    credentials: {
+      async set() { throw new Error('denied'); },
+    } as unknown as ParseSyncBodyDeps['credentials'],
+  };
+  await assert.rejects(
+    () => parseSyncBody({ transport: 'webdav', url: 'https://dav.example.com', password: 'pw' }, deps),
+    (err) => err instanceof SyncRouteError && err.message.includes(SYNC_WEBDAV_CREDENTIAL_REF) && !err.message.includes('pw'),
+  );
+});
+
+/* ---------------- webdavBaseUrl ---------------- */
+
+test('webdavBaseUrl: webdav.url 作为 base，尾部规范化带 /；git 通道返回空', () => {
+  const webdav: SyncConfig = { schemaVersion: 2, transport: 'webdav', webdav: { url: 'https://dav.example.com/remote.php/dav/files/user' } };
+  assert.equal(webdavBaseUrl(webdav), 'https://dav.example.com/remote.php/dav/files/user/');
+  assert.equal(
+    webdavBaseUrl({ ...webdav, webdav: { url: 'https://dav.example.com/' } }),
+    'https://dav.example.com/',
+  );
+  const git: SyncConfig = { schemaVersion: 2, transport: 'git', git: { repoUrl: 'git@github.com:foo/bar.git' } };
+  assert.equal(webdavBaseUrl(git), '', 'git 通道无 webdav baseUrl');
+});
+
+/* ---------------- extractSyncSections（push 分区选择） ---------------- */
+
+const KNOWN = new Set(['settings', 'providers', 'plugins', 'skills']);
+
+test('extractSyncSections: 缺省 / 非数组 / 空数组 → undefined（默认全量推荐分区）', () => {
+  assert.equal(extractSyncSections({ repoUrl: 'x' }, KNOWN), undefined);
+  assert.equal(extractSyncSections({ sections: 'settings' }, KNOWN), undefined, '非数组视为未指定');
+  assert.equal(extractSyncSections({ sections: [] }, KNOWN), undefined, '空数组视为未指定');
+});
+
+test('extractSyncSections: 合法分区 → 去重保序返回 SectionId[]', () => {
+  assert.deepEqual(
+    extractSyncSections({ sections: ['plugins', 'settings', 'settings'] }, KNOWN),
+    ['plugins', 'settings'],
+    '重复分区去重，保持首次出现顺序',
+  );
+});
+
+test('extractSyncSections: 元素非字符串 / 空串 → SyncRouteError', () => {
+  assert.throws(
+    () => extractSyncSections({ sections: ['settings', 42] }, KNOWN),
+    (err) => err instanceof SyncRouteError && /sections/.test(err.message),
+  );
+  assert.throws(
+    () => extractSyncSections({ sections: [''] }, KNOWN),
+    (err) => err instanceof SyncRouteError,
+  );
+});
+
+test('extractSyncSections: 元素为未知分区 id → SyncRouteError（不静默吞错）', () => {
+  assert.throws(
+    () => extractSyncSections({ sections: ['settings', 'nope'] }, KNOWN),
+    (err) => err instanceof SyncRouteError && /nope/.test(err.message),
+  );
+});
+
+/* ---------------- mergePersistedWebDavUsername（prepareSync username 回退） ---------------- */
+
+const WEBDAV_CFG: SyncConfig = { schemaVersion: 2, transport: 'webdav', webdav: { url: 'https://dav.example.com/dav' } };
+const WEBDAV_WITH_USER: SyncConfig = {
+  schemaVersion: 2, transport: 'webdav', webdav: { url: 'https://dav.example.com/dav', username: 'alice' },
+};
+const GIT_CFG: SyncConfig = { schemaVersion: 2, transport: 'git', git: { repoUrl: 'git@github.com:foo/bar.git' } };
+
+test('mergePersistedWebDavUsername: webdav 缺 username + 持久化有 username → 回填（snapshotsList 挂载自动加载场景）', () => {
+  const cfg = mergePersistedWebDavUsername({ ...WEBDAV_CFG }, { ...WEBDAV_WITH_USER });
+  assert.ok(isWebDavConfig(cfg) && cfg.webdav.username === 'alice', '回填持久化 username');
+});
+
+test('mergePersistedWebDavUsername: 请求已带 username → 保留新值不回填（用户输入优先）', () => {
+  const cfg = mergePersistedWebDavUsername(
+    { ...WEBDAV_CFG, webdav: { ...WEBDAV_CFG.webdav, username: 'bob' } },
+    { ...WEBDAV_WITH_USER },
+  );
+  assert.ok(isWebDavConfig(cfg) && cfg.webdav.username === 'bob');
+});
+
+test('mergePersistedWebDavUsername: 持久化无 username / 非 webdav / 为 null → 原样返回', () => {
+  const noUser = mergePersistedWebDavUsername({ ...WEBDAV_CFG }, { ...WEBDAV_CFG });
+  assert.ok(isWebDavConfig(noUser) && noUser.webdav.username === undefined, '持久化无 username 不回填');
+
+  const gitPersisted = mergePersistedWebDavUsername({ ...WEBDAV_CFG }, { ...GIT_CFG });
+  assert.ok(isWebDavConfig(gitPersisted) && gitPersisted.webdav.username === undefined, '持久化是 git 通道不回填');
+
+  const nullPersisted = mergePersistedWebDavUsername({ ...WEBDAV_CFG }, null);
+  assert.ok(isWebDavConfig(nullPersisted) && nullPersisted.webdav.username === undefined, '无持久化配置原样返回');
+
+  const gitCfg = mergePersistedWebDavUsername({ ...GIT_CFG }, { ...WEBDAV_WITH_USER });
+  assert.deepEqual(gitCfg, GIT_CFG, 'git 请求体不受影响');
+});