@logbrew/react-native 0.1.24 → 0.1.26

package/android/src/main/cpp/android_diagnostics.cpp

@@ -26,7 +26,7 @@ constexpr size_t kProjectChars = 36;
 constexpr size_t kReleaseChars = 256;
 constexpr size_t kEnvironmentChars = 128;
 constexpr size_t kServiceChars = 128;
-constexpr size_t kMaxModules = 192;
+constexpr size_t kMaxModules = 4096;
 constexpr std::array<int, 6> kSignals = {SIGABRT, SIGBUS, SIGFPE, SIGILL, SIGSEGV, SIGTRAP};
 
 #pragma pack(push, 1)
@@ -57,6 +57,7 @@ struct Module {
 
 std::array<Module, kMaxModules> g_modules{};
 size_t g_module_count = 0;
+bool g_module_overflow = false;
 std::array<struct sigaction, kSignals.size()> g_previous_actions{};
 std::array<char, 1024> g_record_path{};
 SignalRecord g_record_template{};
@@ -111,6 +112,7 @@ bool read_build_id(const dl_phdr_info* info, std::array<uint8_t, 16>* output) {
 
 int collect_module(dl_phdr_info* info, size_t, void*) {
   if (g_module_count == g_modules.size()) {
+    g_module_overflow = true;
     return 1;
   }
   uintptr_t start = UINTPTR_MAX;
@@ -329,7 +331,12 @@ Java_co_logbrew_reactnative_AndroidDiagnosticsRuntime_nativeInstall(
   g_record_template.magic = kMagic;
   g_record_template.version = kVersion;
   g_module_count = 0;
+  g_module_overflow = false;
   dl_iterate_phdr(collect_module, nullptr);
+  if (g_module_overflow) {
+    g_installed.store(false);
+    return JNI_FALSE;
+  }
   struct sigaction action {};
   sigemptyset(&action.sa_mask);
   action.sa_sigaction = signal_handler;

package/android/src/main/java/co/logbrew/reactnative/AndroidNativeDiagnostics.java

@@ -185,7 +185,7 @@ final class AndroidNativeDiagnostics {
         nextId("java"),
         System.currentTimeMillis(),
         "Native application crash",
-        "fatal",
+        "critical",
         safeSymbol(error == null ? null : error.getClass().getName(), 256, "AndroidJavaCrash"),
         "uncaught_exception",
         0,
@@ -221,7 +221,7 @@ final class AndroidNativeDiagnostics {
         record.id,
         record.timestampMs,
         "Native application crash",
-        "fatal",
+        "critical",
         "AndroidNativeCrash",
         "signal",
         0,
@@ -244,8 +244,15 @@ final class AndroidNativeDiagnostics {
     output.append("{\"type\":\"issue\",\"id\":\"").append(id)
         .append("\",\"timestamp\":\"").append(timestamp(timestampMs))
         .append("\",\"attributes\":{\"title\":\"").append(title)
-        .append("\",\"level\":\"").append(level)
-        .append("\",\"exception\":{\"type\":\"").append(exceptionType)
+        .append("\",\"level\":\"").append(level).append('"');
+    appendJavaFrames(output, frames);
+    if (nativeFrame != null) {
+      output.append(",\"nativeStackFrames\":[{\"imageUuid\":\"")
+          .append(nativeFrame.imageUuid).append("\",\"architecture\":\"")
+          .append(nativeFrame.architecture).append("\",\"instructionOffset\":\"")
+          .append(nativeFrame.instructionOffset).append("\"}]");
+    }
+    output.append(",\"exception\":{\"type\":\"").append(exceptionType)
         .append("\",\"mechanism\":{\"type\":\"").append(mechanism)
         .append("\",\"handled\":false}},\"metadata\":{")
         .append("\"crash.mechanism\":\"").append(mechanism)
@@ -262,17 +269,11 @@ final class AndroidNativeDiagnostics {
     }
     output.append('}');
     appendContext(output, eventConfiguration);
-    appendJavaFrames(output, frames);
-    if (nativeFrame != null) {
-      output.append(",\"nativeStackFrames\":[{\"imageUuid\":\"")
-          .append(nativeFrame.imageUuid).append("\",\"architecture\":\"")
-          .append(nativeFrame.architecture).append("\",\"instructionOffset\":\"")
-          .append(nativeFrame.instructionOffset).append("\"}]");
-    }
     return output.append("}}").toString();
   }
 
   private static void appendJavaFrames(StringBuilder output, StackTraceElement[] frames) {
+    int start = output.length();
     output.append(",\"stackFrames\":[");
     int count = 0;
     for (StackTraceElement frame : frames) {
@@ -294,11 +295,15 @@ final class AndroidNativeDiagnostics {
           .append(json(safeSymbol(frame.getClassName(), 512, "unknown"))).append("\"}");
       count += 1;
     }
-    output.append(']');
+    if (count == 0) {
+      output.setLength(start);
+    } else {
+      output.append(']');
+    }
   }
 
   private static void appendContext(StringBuilder output, Configuration value) {
-    output.append(",\"context\":{\"resource\":{\"service\":{\"name\":\"")
+    output.append(",\"context\":{\"schemaVersion\":1,\"resource\":{\"service\":{\"name\":\"")
         .append(json(value.service)).append("\"},\"deployment\":{\"environment\":\"")
         .append(json(value.environment)).append("\",\"release\":\"")
         .append(json(value.release)).append("\"},\"operatingSystem\":{\"name\":\"Android\",\"version\":\"")
@@ -321,16 +326,16 @@ final class AndroidNativeDiagnostics {
 
   private static String safeFilename(String value) {
     String safe = safeSymbol(value, 256, null);
-    return safe == null || safe.contains("/") || safe.contains("\\") ? null : safe;
+    return safe == null || safe.contains("/") || safe.contains("\\") || safe.contains("?") || safe.contains("#") ? null : safe;
   }
 
   private static String safeSymbol(String value, int maximum, String fallback) {
     return value == null
-            || value.isEmpty()
+            || value.trim().isEmpty()
             || value.length() > maximum
             || value.chars().anyMatch(character -> character <= 31 || character == 127)
         ? fallback
-        : value;
+        : value.trim();
   }
 
   private static String json(String value) {

package/index.cjs

@@ -16,7 +16,7 @@ const {
 } = require("./metadata.cjs");
 
 const DEFAULT_SDK_NAME = "logbrew-react-native";
-const DEFAULT_SDK_VERSION = "0.1.24";
+const DEFAULT_SDK_VERSION = "0.1.26";
 const DEFAULT_ENDPOINT = "https://api.logbrew.co/v1/events";
 const NATIVE_RANDOM_HEX = Symbol.for("co.logbrew.react-native.secure-random-hex");
 const MAX_ACTION_NAME_LENGTH = 64;

package/ios/AppleDiagnostics/LBRNAppleNativeDiagnostics.swift

@@ -3,7 +3,7 @@ import Foundation
 @objc(LBRNAppleNativeDiagnostics)
 public final class LBRNAppleNativeDiagnostics: NSObject, @unchecked Sendable {
     private static let shared = LBRNAppleNativeDiagnostics()
-    private static let sdkVersion = "0.1.24"
+    private static let sdkVersion = "0.1.26"
 
     private let lock = NSLock()
     private let replayQueue = DispatchQueue(label: "co.logbrew.react-native.apple-diagnostics-replay")

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@logbrew/react-native",
-  "version": "0.1.24",
+  "version": "0.1.26",
   "description": "React Native offline delivery, native diagnostics, screen, error, trace, action, and network timeline helpers for LogBrew.",
   "type": "module",
   "main": "./index.cjs",
@@ -252,7 +252,7 @@
     "url": "git+https://github.com/LogBrewCo/sdk.git"
   },
   "peerDependencies": {
-    "@logbrew/sdk": "^0.1.15",
+    "@logbrew/sdk": "^0.1.20",
     "expo": ">=49",
     "react": ">=18",
     "react-native": ">=0.72"