@lodev09/react-native-true-sheet 3.9.0-beta.6 → 3.9.0

package/android/src/main/java/com/lodev09/truesheet/TrueSheetView.kt

@@ -551,10 +551,9 @@ class TrueSheetView(private val reactContext: ThemedReactContext) :
   }
 
   override fun viewControllerDidChangeSize(width: Int, height: Int) {
-    // When scrollable, pass actual height so Yoga container matches the real sheet size
-    // (content uses flex:1, needs correct bounds for padding/layout).
-    // When not scrollable, keep height at screen size to avoid feedback loop with "auto" detent.
-    val effectiveHeight = if (viewController.scrollable) height else lastContainerHeight
+    // On android scrollable, we need the actual sheet height to get proper ScrollView height.
+    // Unlike IOS where ScrollView is pinned to the container.
+    val effectiveHeight = if (viewController.scrollable) height else viewController.screenHeight
     updateState(width, effectiveHeight)
   }
 

package/ios/TrueSheetView.mm

@@ -268,9 +268,9 @@ using namespace facebook::react;
 - (void)updateState:(const State::Shared &)state oldState:(const State::Shared &)oldState {
   _state = std::static_pointer_cast<TrueSheetViewShadowNode::ConcreteState const>(state);
 
-  // Initialize with _controller size to set initial width
   if (_controller) {
-    [self updateStateWithSize:_controller.view.frame.size];
+    // Initialize with _controller size to set initial width
+    [self viewControllerDidChangeSize:_controller.view.frame.size];
   }
 }
 
@@ -640,12 +640,10 @@ using namespace facebook::react;
 }
 
 - (void)viewControllerDidChangeSize:(CGSize)size {
-  // When scrollable, pass actual height so Yoga container matches the real sheet size
-  // (content uses flex:1, needs correct bounds for padding/layout).
-  // When not scrollable, keep height at screen size to avoid feedback loop with "auto" detent.
-  CGFloat effectiveHeight = _scrollable ? size.height : _lastStateSize.height;
-  CGSize adjustedSize = CGSizeMake(size.width, effectiveHeight);
-  [self updateStateWithSize:adjustedSize];
+  // TODO: Explicit screen height for now until synchronous layout is supported.
+  CGSize effectiveSize = CGSizeMake(size.width, _controller.screenHeight);
+
+  [self updateStateWithSize:effectiveSize];
 }
 
 - (void)viewControllerWillFocus {

package/ios/TrueSheetViewController.mm

@@ -219,7 +219,6 @@ using namespace facebook::react;
     dispatch_async(dispatch_get_main_queue(), ^{
       NSInteger index = [self currentDetentIndex];
       CGFloat detent = [self detentValueForIndex:index];
-      [self.delegate viewControllerDidChangeSize:self.view.frame.size];
       [self.delegate viewControllerDidPresentAtIndex:index position:self.currentPosition detent:detent];
       [self.delegate viewControllerDidFocus];
 
@@ -314,7 +313,6 @@ using namespace facebook::react;
     dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(0.2 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
       [self storeResolvedPositionForIndex:pendingIndex];
       CGFloat detent = [self detentValueForIndex:pendingIndex];
-      [self.delegate viewControllerDidChangeSize:self.view.frame.size];
       [self.delegate viewControllerDidChangeDetent:pendingIndex position:self.currentPosition detent:detent];
       [self emitChangePositionDelegateWithPosition:self.currentPosition realtime:NO debug:@"pending detent change"];
     });
@@ -809,7 +807,6 @@ using namespace facebook::react;
     NSInteger index = self.currentDetentIndex;
     if (index >= 0) {
       CGFloat detent = [self detentValueForIndex:index];
-      [self.delegate viewControllerDidChangeSize:self.view.frame.size];
       [self.delegate viewControllerDidChangeDetent:index position:self.currentPosition detent:detent];
     }
   });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lodev09/react-native-true-sheet",
-  "version": "3.9.0-beta.6",
+  "version": "3.9.0",
   "description": "The true native bottom sheet experience for your React Native Apps.",
   "source": "./src/index.ts",
   "main": "./lib/module/index.js",