@lodev09/react-native-true-sheet 3.6.8 → 3.6.10

package/android/src/main/java/com/lodev09/truesheet/TrueSheetView.kt

@@ -135,6 +135,11 @@ class TrueSheetView(private val reactContext: ThemedReactContext) :
     val child = getChildAt(index)
     if (child is TrueSheetContainerView) {
       child.delegate = null
+
+      // Dismiss the sheet when container is removed
+      if (viewController.isPresented) {
+        viewController.dismiss(animated = false)
+      }
     }
     viewController.removeView(child)
   }
@@ -159,14 +164,12 @@ class TrueSheetView(private val reactContext: ThemedReactContext) :
   fun onDropInstance() {
     reactContext.removeLifecycleEventListener(this)
 
-    if (viewController.isPresented) {
-      viewController.dismiss(animated = false)
-    }
+    viewController.dismiss()
+    viewController.delegate = null
 
     TrueSheetModule.unregisterView(id)
     TrueSheetStackManager.removeSheet(this)
 
-    viewController.delegate = null
     didInitiallyPresent = false
   }
 
@@ -245,6 +248,10 @@ class TrueSheetView(private val reactContext: ThemedReactContext) :
     viewController.insetAdjustment = insetAdjustment
   }
 
+  fun setScrollable(scrollable: Boolean) {
+    viewController.scrollable = scrollable
+  }
+
   // ==================== State Management ====================
 
   /**

package/android/src/main/java/com/lodev09/truesheet/TrueSheetViewController.kt

@@ -139,7 +139,6 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
 
   // Keyboard State
   private var detentIndexBeforeKeyboard: Int = -1
-  private var isKeyboardTransitioning: Boolean = false
 
   // Promises
   var presentPromise: (() -> Unit)? = null
@@ -171,6 +170,11 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
   override var grabberOptions: GrabberOptions? = null
   override var sheetBackgroundColor: Int? = null
   var insetAdjustment: String = "automatic"
+  var scrollable: Boolean = false
+    set(value) {
+      field = value
+      coordinatorLayout?.scrollable = value
+    }
 
   override var sheetCornerRadius: Float = DEFAULT_CORNER_RADIUS.dpToPx()
     set(value) {
@@ -238,6 +242,14 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
   private val currentKeyboardInset: Int
     get() = keyboardObserver?.currentHeight ?: 0
 
+  private val isKeyboardTransitioning: Boolean
+    get() = keyboardObserver?.isTransitioning ?: false
+
+  private fun isFocusedViewWithinSheet(): Boolean {
+    val sheet = sheetView ?: return false
+    return keyboardObserver?.isFocusedViewWithinSheet(sheet) ?: false
+  }
+
   val bottomInset: Int
     get() = if (edgeToEdgeEnabled) ScreenUtils.getInsets(reactContext).bottom else 0
 
@@ -290,6 +302,7 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
     // Create coordinator layout
     coordinatorLayout = TrueSheetCoordinatorLayout(reactContext).apply {
       delegate = this@TrueSheetViewController
+      scrollable = this@TrueSheetViewController.scrollable
     }
 
     sheetView = TrueSheetBottomSheetView(reactContext).apply {
@@ -320,7 +333,6 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
     isPresented = false
     isSheetVisible = false
     wasHiddenByModal = false
-    isKeyboardTransitioning = false
     isPresentAnimating = false
     lastEmittedPositionPx = -1
     detentIndexBeforeKeyboard = -1
@@ -872,9 +884,11 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
   // MARK: - Keyboard Handling
   // =============================================================================
 
-  private fun shouldHandleKeyboard(): Boolean {
+  private fun shouldHandleKeyboard(checkFocus: Boolean = true): Boolean {
     if (wasHiddenByModal) return false
-    return isTopmostSheet
+    if (!isTopmostSheet) return false
+    if (checkFocus && !isFocusedViewWithinSheet()) return false
+    return true
   }
 
   fun setupKeyboardObserver() {
@@ -886,7 +900,6 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
     keyboardObserver = TrueSheetKeyboardObserver(coordinator, reactContext).apply {
       delegate = object : TrueSheetKeyboardObserverDelegate {
         override fun keyboardWillShow(height: Int) {
-          isKeyboardTransitioning = true
           if (!shouldHandleKeyboard()) return
           detentIndexBeforeKeyboard = currentDetentIndex
           setupSheetDetents()
@@ -894,7 +907,8 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
         }
 
         override fun keyboardWillHide() {
-          if (!shouldHandleKeyboard()) return
+          if (!shouldHandleKeyboard(checkFocus = false)) return
+
           setupSheetDetents()
           if (!isDismissing && detentIndexBeforeKeyboard >= 0) {
             setStateForDetentIndex(detentIndexBeforeKeyboard)
@@ -902,9 +916,7 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
           }
         }
 
-        override fun keyboardDidHide() {
-          isKeyboardTransitioning = false
-        }
+        override fun keyboardDidHide() {}
 
         override fun keyboardDidChangeHeight(height: Int) {
           if (!shouldHandleKeyboard()) return

package/android/src/main/java/com/lodev09/truesheet/TrueSheetViewManager.kt

@@ -190,7 +190,7 @@ class TrueSheetViewManager :
 
   @ReactProp(name = "scrollable", defaultBoolean = false)
   override fun setScrollable(view: TrueSheetView, value: Boolean) {
-    // iOS-specific prop - no-op on Android
+    view.setScrollable(value)
   }
 
   @ReactProp(name = "pageSizing", defaultBoolean = true)

package/android/src/main/java/com/lodev09/truesheet/core/TrueSheetCoordinatorLayout.kt

@@ -2,7 +2,10 @@ package com.lodev09.truesheet.core
 
 import android.annotation.SuppressLint
 import android.content.Context
-import android.view.View
+import android.view.MotionEvent
+import android.view.ViewConfiguration
+import android.view.ViewGroup
+import android.widget.ScrollView
 import androidx.coordinatorlayout.widget.CoordinatorLayout
 import com.facebook.react.uimanager.PointerEvents
 import com.facebook.react.uimanager.ReactPointerEventsView
@@ -22,15 +25,19 @@ class TrueSheetCoordinatorLayout(context: Context) :
   ReactPointerEventsView {
 
   var delegate: TrueSheetCoordinatorLayoutDelegate? = null
+  var scrollable: Boolean = false
+
+  private val touchSlop: Int = ViewConfiguration.get(context).scaledTouchSlop
+  private var dragging = false
+  private var initialY = 0f
+  private var activePointerId = 0
 
   init {
-    // Fill the entire screen
     layoutParams = LayoutParams(
       LayoutParams.MATCH_PARENT,
       LayoutParams.MATCH_PARENT
     )
 
-    // Ensure we don't clip the sheet during animations
     clipChildren = false
     clipToPadding = false
   }
@@ -46,10 +53,87 @@ class TrueSheetCoordinatorLayout(context: Context) :
     delegate?.coordinatorLayoutDidLayout(changed)
   }
 
-  /**
-   * Allow pointer events to pass through to underlying views.
-   * The DimView and BottomSheetView handle their own touch interception.
-   */
   override val pointerEvents: PointerEvents
     get() = PointerEvents.BOX_NONE
+
+  /**
+   * Intercepts touch events for ScrollViews that can't scroll (content < viewport),
+   * allowing the sheet to be dragged in these cases.
+   *
+   * TODO: Remove this workaround once NestedScrollView is merged into react-native core.
+   * See: https://github.com/facebook/react-native/pull/44099
+   */
+  override fun onInterceptTouchEvent(ev: MotionEvent): Boolean {
+    if (!scrollable) {
+      return super.onInterceptTouchEvent(ev)
+    }
+
+    val scrollView = findScrollView(this)
+    val cannotScroll = scrollView != null &&
+      scrollView.scrollY == 0 &&
+      !scrollView.canScrollVertically(1)
+
+    if (cannotScroll) {
+      when (ev.action and MotionEvent.ACTION_MASK) {
+        MotionEvent.ACTION_DOWN -> {
+          dragging = false
+          initialY = ev.y
+          activePointerId = ev.getPointerId(0)
+        }
+
+        MotionEvent.ACTION_MOVE -> {
+          val pointerIndex = ev.findPointerIndex(activePointerId)
+          if (pointerIndex != -1) {
+            val y = ev.getY(pointerIndex)
+            val deltaY = initialY - y
+            if (kotlin.math.abs(deltaY) > touchSlop) {
+              dragging = true
+              parent?.requestDisallowInterceptTouchEvent(true)
+            }
+          }
+        }
+
+        MotionEvent.ACTION_UP,
+        MotionEvent.ACTION_CANCEL -> {
+          dragging = false
+        }
+      }
+    } else {
+      dragging = false
+    }
+
+    return dragging || super.onInterceptTouchEvent(ev)
+  }
+
+  @SuppressLint("ClickableViewAccessibility")
+  override fun onTouchEvent(ev: MotionEvent): Boolean {
+    if (dragging) {
+      when (ev.action and MotionEvent.ACTION_MASK) {
+        MotionEvent.ACTION_UP,
+        MotionEvent.ACTION_CANCEL -> {
+          dragging = false
+        }
+      }
+      // Let parent CoordinatorLayout handle the touch for BottomSheetBehavior
+      return super.onTouchEvent(ev)
+    }
+    return super.onTouchEvent(ev)
+  }
+
+  private fun findScrollView(view: android.view.View): ScrollView? {
+    if (view is ScrollView) {
+      return view
+    }
+
+    if (view is ViewGroup) {
+      for (i in 0 until view.childCount) {
+        val scrollView = findScrollView(view.getChildAt(i))
+        if (scrollView != null) {
+          return scrollView
+        }
+      }
+    }
+
+    return null
+  }
 }

package/android/src/main/java/com/lodev09/truesheet/core/TrueSheetKeyboardObserver.kt

@@ -31,6 +31,20 @@ class TrueSheetKeyboardObserver(private val targetView: View, private val reactC
   var targetHeight: Int = 0
     private set
 
+  var isTransitioning: Boolean = false
+    private set
+
+  fun isFocusedViewWithinSheet(sheetView: View): Boolean {
+    val focusedView = reactContext.currentActivity?.currentFocus ?: return false
+    var current: View? = focusedView
+    while (current != null && current !== targetView) {
+      if (current === sheetView) return true
+      val parent = current.parent
+      current = if (parent is View) parent else null
+    }
+    return false
+  }
+
   private var isHiding: Boolean = false
   private var globalLayoutListener: ViewTreeObserver.OnGlobalLayoutListener? = null
   private var activityRootView: View? = null
@@ -80,6 +94,7 @@ class TrueSheetKeyboardObserver(private val targetView: View, private val reactC
           endHeight = getKeyboardHeight()
           targetHeight = endHeight
           isHiding = endHeight < startHeight
+          isTransitioning = true
           if (endHeight > startHeight) {
             delegate?.keyboardWillShow(endHeight)
           } else if (isHiding) {
@@ -102,6 +117,7 @@ class TrueSheetKeyboardObserver(private val targetView: View, private val reactC
         override fun onEnd(animation: WindowInsetsAnimationCompat) {
           val finalHeight = getKeyboardHeight()
           updateHeight(startHeight, finalHeight, 1f)
+          isTransitioning = false
           if (isHiding) {
             delegate?.keyboardDidHide()
             isHiding = false
@@ -134,6 +150,7 @@ class TrueSheetKeyboardObserver(private val targetView: View, private val reactC
       targetHeight = newHeight
       isHiding = newHeight < previousHeight
 
+      isTransitioning = true
       if (newHeight > previousHeight) {
         delegate?.keyboardWillShow(newHeight)
       } else if (isHiding) {
@@ -142,6 +159,7 @@ class TrueSheetKeyboardObserver(private val targetView: View, private val reactC
 
       // On legacy API, keyboard has already animated - just update immediately
       updateHeight(previousHeight, newHeight, 1f)
+      isTransitioning = false
 
       if (isHiding && newHeight == 0) {
         delegate?.keyboardDidHide()

package/ios/TrueSheetView.mm

@@ -96,7 +96,12 @@ using namespace facebook::react;
 
 - (void)dealloc {
   if (_controller && _controller.presentingViewController) {
-    [_controller dismissViewControllerAnimated:NO completion:nil];
+    // Find the root presenting controller to dismiss the entire stack
+    UIViewController *root = _controller.presentingViewController;
+    while (root.presentingViewController != nil) {
+      root = root.presentingViewController;
+    }
+    [root dismissViewControllerAnimated:YES completion:nil];
   }
 
   _controller.delegate = nil;
@@ -258,10 +263,6 @@ using namespace facebook::react;
 - (void)prepareForRecycle {
   [super prepareForRecycle];
 
-  if (_controller && _controller.presentingViewController) {
-    [_controller dismissViewControllerAnimated:YES completion:nil];
-  }
-
   [TrueSheetModule unregisterViewWithTag:@(self.tag)];
 
   _lastStateSize = CGSizeZero;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lodev09/react-native-true-sheet",
-  "version": "3.6.8",
+  "version": "3.6.10",
   "description": "The true native bottom sheet experience for your React Native Apps.",
   "source": "./src/index.ts",
   "main": "./lib/module/index.js",