@lodestar/state-transition 1.51.0-dev.2593063a82 → 1.51.0-dev.4157a0dec4

package/src/util/clock.ts

@@ -133,7 +133,7 @@ export class Clock implements IClock {
         if (timeItem === TimeItem.Slot) {
           if (nextSlot > slot + 1) {
             // It's not very likely that we skip more than one slot as HTTP timeout is set
-            // to SLOT_DURATION_MS so we will fail task before skipping another slot.
+            // to at most one slot duration so we will fail task before skipping another slot.
             this.logger.warn("Skipped slot due to task taking more than one slot to run", {
               skippedSlot: slot + 1,
             });

package/src/util/slot.ts

@@ -1,27 +1,92 @@
 import {ChainConfig, ChainForkConfig} from "@lodestar/config";
-import {GENESIS_SLOT} from "@lodestar/params";
+import {GENESIS_EPOCH, GENESIS_SLOT} from "@lodestar/params";
 import {Epoch, Slot, TimeSeconds} from "@lodestar/types";
 import {computeEpochAtSlot, computeStartSlotAtEpoch} from "./epoch.js";
 
+/**
+ * Slot durations with their activation epochs, derived from the configuration.
+ * A fork that changes the slot duration must add an entry here and in `ForkConfig.getSlotDurationMs`.
+ */
+export function getSlotDurations(config: ChainConfig): [Epoch, number][] {
+  const durations: [Epoch, number][] = [[GENESIS_EPOCH, config.SLOT_DURATION_MS]];
+  if (config.HEZE_FORK_EPOCH !== Infinity) {
+    durations.push([config.HEZE_FORK_EPOCH, config.SLOT_DURATION_MS_HEZE]);
+  }
+  return durations;
+}
+
+/** Slot duration in ms in effect at a given epoch */
+export function getSlotDurationMsAtEpoch(config: ChainConfig, epoch: Epoch): number {
+  let slotDurationMs = config.SLOT_DURATION_MS;
+  for (const [forkEpoch, forkSlotDurationMs] of getSlotDurations(config)) {
+    if (epoch >= forkEpoch) {
+      slotDurationMs = forkSlotDurationMs;
+    }
+  }
+  return slotDurationMs;
+}
+
 /** Slot duration in ms for a given slot */
 export function getSlotDurationMs(config: ChainForkConfig, slot: Slot): number {
   return config.getSlotDurationMs(config.getForkName(slot));
 }
 
+export function computeTimeAtSlotMs(config: ChainConfig, slot: Slot, genesisTimeMs: number): number {
+  let endSlot = slot;
+  let timeMs = genesisTimeMs;
+  for (const [forkEpoch, slotDurationMs] of getSlotDurations(config).reverse()) {
+    const forkSlot = computeStartSlotAtEpoch(forkEpoch);
+    if (forkSlot < endSlot) {
+      timeMs += (endSlot - forkSlot) * slotDurationMs;
+      endSlot = forkSlot;
+    }
+  }
+  // Pre-genesis slots extrapolate linearly so the clock keeps ticking before genesis
+  return timeMs + (endSlot - GENESIS_SLOT) * getSlotDurationMsAtEpoch(config, GENESIS_EPOCH);
+}
+
+export function computeTimeAtSlot(config: ChainConfig, slot: Slot, genesisTime: TimeSeconds): TimeSeconds {
+  return computeTimeAtSlotMs(config, slot, genesisTime * 1000) / 1000;
+}
+
+export function computeSlotAtTimeMs(config: ChainConfig, timeMs: number, genesisTimeMs: number): Slot {
+  let startSlot = GENESIS_SLOT;
+  let startTimeMs = genesisTimeMs;
+  let slotDurationMs = getSlotDurationMsAtEpoch(config, GENESIS_EPOCH);
+  for (const [forkEpoch, forkSlotDurationMs] of getSlotDurations(config)) {
+    const forkSlot = computeStartSlotAtEpoch(forkEpoch);
+    const forkTimeMs = computeTimeAtSlotMs(config, forkSlot, genesisTimeMs);
+    if (timeMs >= forkTimeMs) {
+      startSlot = forkSlot;
+      startTimeMs = forkTimeMs;
+      slotDurationMs = forkSlotDurationMs;
+    }
+  }
+  return startSlot + Math.floor((timeMs - startTimeMs) / slotDurationMs);
+}
+
 export function getSlotsSinceGenesis(config: ChainConfig, genesisTime: TimeSeconds): Slot {
-  const diffInSeconds = Date.now() / 1000 - genesisTime;
-  return Math.floor(diffInSeconds / (config.SLOT_DURATION_MS / 1000));
+  return computeSlotAtTimeMs(config, Date.now(), genesisTime * 1000) - GENESIS_SLOT;
 }
 
 export function getCurrentSlot(config: ChainConfig, genesisTime: TimeSeconds): Slot {
   return GENESIS_SLOT + getSlotsSinceGenesis(config, genesisTime);
 }
 
+/**
+ * Start epoch of the blob data retention window, preserving its wall-clock length
+ * across slot duration changes
+ */
+export function getBlobDataRetentionStartEpoch(config: ChainConfig, epoch: Epoch): Epoch {
+  const windowMs = config.MIN_BLOB_DATA_RETENTION_MS;
+  const currentStartMs = computeTimeAtSlotMs(config, computeStartSlotAtEpoch(epoch), 0);
+  if (currentStartMs < windowMs) {
+    return GENESIS_EPOCH;
+  }
+  return computeEpochAtSlot(computeSlotAtTimeMs(config, currentStartMs - windowMs, 0));
+}
+
 export function computeSlotsSinceEpochStart(slot: Slot, epoch?: Epoch): Slot {
   const computeEpoch = epoch ?? computeEpochAtSlot(slot);
   return slot - computeStartSlotAtEpoch(computeEpoch);
 }
-
-export function computeTimeAtSlot(config: ChainConfig, slot: Slot, genesisTime: TimeSeconds): TimeSeconds {
-  return genesisTime + slot * (config.SLOT_DURATION_MS / 1000);
-}

package/src/util/syncCommittee.ts

@@ -1,18 +1,21 @@
 import {aggregateSerializedPublicKeys} from "@chainsafe/lodestar-z/blst";
+import {ChainConfig} from "@lodestar/config";
 import {
   BASE_REWARD_FACTOR,
   EFFECTIVE_BALANCE_INCREMENT,
   ForkSeq,
+  GENESIS_EPOCH,
   SLOTS_PER_EPOCH,
   SYNC_COMMITTEE_SIZE,
   SYNC_REWARD_WEIGHT,
   WEIGHT_DENOMINATOR,
 } from "@lodestar/params";
-import {altair} from "@lodestar/types";
+import {Epoch, altair} from "@lodestar/types";
 import {bigIntSqrt} from "@lodestar/utils";
 import {EffectiveBalanceIncrements} from "../cache/effectiveBalanceIncrements.js";
 import {BeaconStateAllForks} from "../types.js";
 import {getNextSyncCommitteeIndices} from "./seed.js";
+import {getSlotDurationMsAtEpoch} from "./slot.js";
 
 /**
  * Return the sync committee for a given state and epoch.
@@ -45,11 +48,12 @@ export function getNextSyncCommittee(
 /**
  * Same logic in https://github.com/ethereum/eth2.0-specs/blob/v1.1.0-alpha.5/specs/altair/beacon-chain.md#sync-committee-processing
  */
-export function computeSyncParticipantReward(totalActiveBalanceIncrements: number): number {
-  const totalActiveBalance = BigInt(totalActiveBalanceIncrements) * BigInt(EFFECTIVE_BALANCE_INCREMENT);
-  const baseRewardPerIncrement = Math.floor(
-    (EFFECTIVE_BALANCE_INCREMENT * BASE_REWARD_FACTOR) / Number(bigIntSqrt(totalActiveBalance))
-  );
+export function computeSyncParticipantReward(
+  config: ChainConfig,
+  epoch: Epoch,
+  totalActiveBalanceIncrements: number
+): number {
+  const baseRewardPerIncrement = computeBaseRewardPerIncrement(config, epoch, totalActiveBalanceIncrements);
   const totalBaseRewards = baseRewardPerIncrement * totalActiveBalanceIncrements;
   const maxParticipantRewards = Math.floor(
     Math.floor((totalBaseRewards * SYNC_REWARD_WEIGHT) / WEIGHT_DENOMINATOR) / SLOTS_PER_EPOCH
@@ -61,9 +65,17 @@ export function computeSyncParticipantReward(totalActiveBalanceIncrements: numbe
  * Before we manage bigIntSqrt(totalActiveStake) as BigInt and return BigInt.
  * bigIntSqrt(totalActiveStake) should fit a number (2 ** 53 -1 max)
  **/
-export function computeBaseRewardPerIncrement(totalActiveStakeByIncrement: number): number {
+export function computeBaseRewardPerIncrement(
+  config: ChainConfig,
+  epoch: Epoch,
+  totalActiveStakeByIncrement: number
+): number {
+  // Divide last so the exact slot duration ratio applies
+  const numerator = Math.floor(
+    (EFFECTIVE_BALANCE_INCREMENT * BASE_REWARD_FACTOR * getSlotDurationMsAtEpoch(config, epoch)) /
+      getSlotDurationMsAtEpoch(config, GENESIS_EPOCH)
+  );
   return Math.floor(
-    (EFFECTIVE_BALANCE_INCREMENT * BASE_REWARD_FACTOR) /
-      Number(bigIntSqrt(BigInt(totalActiveStakeByIncrement) * BigInt(EFFECTIVE_BALANCE_INCREMENT)))
+    numerator / Number(bigIntSqrt(BigInt(totalActiveStakeByIncrement) * BigInt(EFFECTIVE_BALANCE_INCREMENT)))
   );
 }

package/src/util/validator.ts

@@ -2,6 +2,7 @@ import {ChainForkConfig} from "@lodestar/config";
 import {
   EFFECTIVE_BALANCE_INCREMENT,
   ForkSeq,
+  GENESIS_EPOCH,
   MAX_EFFECTIVE_BALANCE,
   MAX_EFFECTIVE_BALANCE_ELECTRA,
   MIN_ACTIVATION_BALANCE,
@@ -11,6 +12,7 @@ import {intDiv} from "@lodestar/utils";
 import {BeaconStateAllForks, CachedBeaconStateElectra, CachedBeaconStateGloas, EpochCache} from "../types.js";
 import {hasEth1WithdrawalCredential} from "./capella.js";
 import {hasCompoundingWithdrawalCredential, hasExecutionWithdrawalCredential} from "./electra.js";
+import {getSlotDurationMsAtEpoch} from "./slot.js";
 
 /**
  * Check if [[validator]] is active
@@ -93,23 +95,35 @@ export function getActivationExitChurnLimit(epochCtx: EpochCache): number {
  * https://github.com/ethereum/consensus-specs/blob/v1.7.0-alpha.6/specs/gloas/beacon-chain.md#new-get_activation_churn_limit
  */
 export function getActivationChurnLimit(epochCtx: EpochCache): number {
-  const churn = getBalanceChurnLimit(
-    epochCtx.totalActiveBalanceIncrements,
-    epochCtx.config.CHURN_LIMIT_QUOTIENT_GLOAS,
-    epochCtx.config.MIN_PER_EPOCH_CHURN_LIMIT_ELECTRA
+  const {config, epoch, totalActiveBalanceIncrements} = epochCtx;
+  const churnByBalance = Math.floor(
+    (totalActiveBalanceIncrements / config.CHURN_LIMIT_QUOTIENT_GLOAS) * EFFECTIVE_BALANCE_INCREMENT
+  );
+  const churn = Math.min(
+    config.MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT_GLOAS,
+    Math.max(churnByBalance, config.MIN_PER_EPOCH_CHURN_LIMIT_ELECTRA)
   );
-  return Math.min(epochCtx.config.MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT_GLOAS, churn);
+  // Scale by the slot duration ratio, rounding to the increment once after scaling
+  const scaled = Math.floor(
+    (churn * getSlotDurationMsAtEpoch(config, epoch)) / getSlotDurationMsAtEpoch(config, GENESIS_EPOCH)
+  );
+  return scaled - (scaled % EFFECTIVE_BALANCE_INCREMENT);
 }
 
 /**
  * https://github.com/ethereum/consensus-specs/blob/v1.7.0-alpha.6/specs/gloas/beacon-chain.md#new-get_exit_churn_limit
  */
 export function getExitChurnLimit(epochCtx: EpochCache): number {
-  return getBalanceChurnLimit(
-    epochCtx.totalActiveBalanceIncrements,
-    epochCtx.config.CHURN_LIMIT_QUOTIENT_GLOAS,
-    epochCtx.config.MIN_PER_EPOCH_CHURN_LIMIT_ELECTRA
+  const {config, epoch, totalActiveBalanceIncrements} = epochCtx;
+  const churnByBalance = Math.floor(
+    (totalActiveBalanceIncrements / config.CHURN_LIMIT_QUOTIENT_GLOAS) * EFFECTIVE_BALANCE_INCREMENT
+  );
+  const churn = Math.max(churnByBalance, config.MIN_PER_EPOCH_CHURN_LIMIT_ELECTRA);
+  // Scale by the slot duration ratio, rounding to the increment once after scaling
+  const scaled = Math.floor(
+    (churn * getSlotDurationMsAtEpoch(config, epoch)) / getSlotDurationMsAtEpoch(config, GENESIS_EPOCH)
   );
+  return scaled - (scaled % EFFECTIVE_BALANCE_INCREMENT);
 }
 
 /**
@@ -118,12 +132,16 @@ export function getExitChurnLimit(epochCtx: EpochCache): number {
  */
 export function getConsolidationChurnLimit(fork: ForkSeq, epochCtx: EpochCache): number {
   if (fork >= ForkSeq.gloas) {
-    // No MIN floor — pass 0 so getBalanceChurnLimit's max(churn, min) is a no-op.
-    return getBalanceChurnLimit(
-      epochCtx.totalActiveBalanceIncrements,
-      epochCtx.config.CONSOLIDATION_CHURN_LIMIT_QUOTIENT,
-      0
+    const {config, epoch, totalActiveBalanceIncrements} = epochCtx;
+    // No MIN floor in gloas
+    const churn = Math.floor(
+      (totalActiveBalanceIncrements / config.CONSOLIDATION_CHURN_LIMIT_QUOTIENT) * EFFECTIVE_BALANCE_INCREMENT
     );
+    // Scale by the slot duration ratio, rounding to the increment once after scaling
+    const scaled = Math.floor(
+      (churn * getSlotDurationMsAtEpoch(config, epoch)) / getSlotDurationMsAtEpoch(config, GENESIS_EPOCH)
+    );
+    return scaled - (scaled % EFFECTIVE_BALANCE_INCREMENT);
   }
   return getBalanceChurnLimitFromCache(epochCtx) - getActivationExitChurnLimit(epochCtx);
 }
@@ -131,17 +149,26 @@ export function getConsolidationChurnLimit(fork: ForkSeq, epochCtx: EpochCache):
 // NOTE: duplicates the quotient/min choices in get{Exit,Activation,Consolidation}ChurnLimit.
 export function getGloasChurnLimits(
   config: ChainForkConfig,
+  epoch: Epoch,
   totalActiveBalanceIncrements: number
 ): {exit: number; activation: number; consolidation: number} {
-  const exit = getBalanceChurnLimit(
-    totalActiveBalanceIncrements,
-    config.CHURN_LIMIT_QUOTIENT_GLOAS,
+  const ratioNumerator = getSlotDurationMsAtEpoch(config, epoch);
+  const ratioDenominator = getSlotDurationMsAtEpoch(config, GENESIS_EPOCH);
+  const exitUnscaled = Math.max(
+    Math.floor((totalActiveBalanceIncrements / config.CHURN_LIMIT_QUOTIENT_GLOAS) * EFFECTIVE_BALANCE_INCREMENT),
     config.MIN_PER_EPOCH_CHURN_LIMIT_ELECTRA
   );
+  const activationUnscaled = Math.min(config.MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT_GLOAS, exitUnscaled);
+  const consolidationUnscaled = Math.floor(
+    (totalActiveBalanceIncrements / config.CONSOLIDATION_CHURN_LIMIT_QUOTIENT) * EFFECTIVE_BALANCE_INCREMENT
+  );
+  const exit = Math.floor((exitUnscaled * ratioNumerator) / ratioDenominator);
+  const activation = Math.floor((activationUnscaled * ratioNumerator) / ratioDenominator);
+  const consolidation = Math.floor((consolidationUnscaled * ratioNumerator) / ratioDenominator);
   return {
-    exit,
-    activation: Math.min(config.MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT_GLOAS, exit),
-    consolidation: getBalanceChurnLimit(totalActiveBalanceIncrements, config.CONSOLIDATION_CHURN_LIMIT_QUOTIENT, 0),
+    exit: exit - (exit % EFFECTIVE_BALANCE_INCREMENT),
+    activation: activation - (activation % EFFECTIVE_BALANCE_INCREMENT),
+    consolidation: consolidation - (consolidation % EFFECTIVE_BALANCE_INCREMENT),
   };
 }
 

package/src/util/weakSubjectivity.ts

@@ -2,7 +2,6 @@ import {ChainForkConfig} from "@lodestar/config";
 import {
   EFFECTIVE_BALANCE_INCREMENT,
   ForkSeq,
-  GENESIS_SLOT,
   MAX_DEPOSITS,
   MAX_EFFECTIVE_BALANCE,
   SLOTS_PER_EPOCH,
@@ -13,6 +12,7 @@ import {Epoch, Root, Slot, TimeSeconds, ssz} from "@lodestar/types";
 import {ZERO_HASH} from "../constants/constants.js";
 import {BeaconStateAllForks, CachedBeaconStateAllForks} from "../types.js";
 import {computeCheckpointEpochAtStateSlot, computeEpochAtSlot, getCurrentEpoch} from "./epoch.js";
+import {computeSlotAtTimeMs} from "./slot.js";
 import {StateBytesMetadata, getStateTypeFromBytes, scanActiveValidatorsFromStateBytes} from "./sszBytes.js";
 import {
   getActivationChurnLimit,
@@ -107,7 +107,7 @@ function computeWeakSubjectivityPeriodFromActiveValidators(
 ): number {
   const fork = config.getForkName(slot);
 
-  const churnLimitsGloas = getGloasChurnLimits(config, totalActiveBalanceIncrements);
+  const churnLimitsGloas = getGloasChurnLimits(config, computeEpochAtSlot(slot), totalActiveBalanceIncrements);
 
   return isForkPostGloas(fork)
     ? computeWeakSubjectivityPeriodFromConstituentsGloas(
@@ -223,6 +223,6 @@ export function isWithinWeakSubjectivityPeriodFromSummary(
   summary: WeakSubjectivitySummary,
   now: TimeSeconds = Date.now() / 1000
 ): boolean {
-  const clockSlot = GENESIS_SLOT + Math.floor((now - summary.genesisTime) / (config.SLOT_DURATION_MS / 1000));
+  const clockSlot = computeSlotAtTimeMs(config, now * 1000, summary.genesisTime * 1000);
   return computeEpochAtSlot(clockSlot) <= summary.checkpointEpoch + summary.period;
 }