@lodestar/beacon-node 1.51.0-dev.c99cf49add → 1.51.0-dev.cda05d18f1

package/src/chain/archiveStore/utils/archiveBlocks.ts

@@ -1,11 +1,18 @@
 import path from "node:path";
 import {ChainForkConfig} from "@lodestar/config";
 import {KeyValue} from "@lodestar/db";
-import {CheckpointWithHex, ExecutionStatus, IForkChoice, PayloadStatus, ProtoBlock} from "@lodestar/fork-choice";
+import {
+  CheckpointWithHex,
+  ExecutionStatus,
+  IForkChoice,
+  PayloadStatus,
+  ProtoBlock,
+  isGloasBlock,
+} from "@lodestar/fork-choice";
 import {ForkSeq, SLOTS_PER_EPOCH} from "@lodestar/params";
 import {computeEpochAtSlot, computeStartSlotAtEpoch, getBlobDataRetentionStartEpoch} from "@lodestar/state-transition";
 import {Epoch, Slot} from "@lodestar/types";
-import {Logger, fromAsync, fromHex, prettyPrintIndices, toRootHex} from "@lodestar/utils";
+import {Logger, fromHex, prettyPrintIndices, toRootHex} from "@lodestar/utils";
 import {IBeaconDb} from "../../../db/index.js";
 import {BlockArchiveBatchPutBinaryItem, encodeArchivedHeaderEnvelope} from "../../../db/repositories/index.js";
 import {Metrics} from "../../../metrics/metrics.js";
@@ -49,6 +56,17 @@ async function persistOrphanedBlock(
   await writeIfNotExist(filepath, bytes);
 }
 
+/**
+ * Oldest epoch for which data column sidecars are kept
+ */
+export function getDataColumnSidecarsMinEpoch(
+  config: ChainForkConfig,
+  currentEpoch: Epoch,
+  archiveDataEpochs?: number
+): Epoch {
+  return Math.min(getBlobDataRetentionStartEpoch(config, currentEpoch), currentEpoch - (archiveDataEpochs ?? 0));
+}
+
 /**
  * Archives finalized blocks from active bucket to archive bucket.
  *
@@ -136,23 +154,6 @@ export async function archiveBlocks(
       logger.verbose("Migrated blobSidecars from hot DB to cold DB", {...logCtx, migratedEntries});
     }
 
-    // Keep the normal LevelDB hot-to-cold flow for legacy columns. New columns are written
-    // directly to flat files, so this only moves fallback data left by older versions.
-    if (finalizedPostFulu) {
-      const migratedSlots = await migrateDataColumnSidecarsFromHotToColdDb(
-        config,
-        db,
-        logger,
-        finalizedCanonicalBlocks,
-        currentEpoch
-      );
-      logger.verbose("Migrated legacy dataColumnSidecars from hot DB to cold DB", {
-        ...logCtx,
-        migratedEntries: migratedSlots.length,
-        slotRange: prettyPrintIndices(migratedSlots),
-      });
-    }
-
     if (finalizedPostGloas) {
       const migratedSlots = await migrateExecutionPayloadEnvelopesFromHotToColdDb(
         config,
@@ -169,44 +170,34 @@ export async function archiveBlocks(
     }
   }
 
-  // deleteNonCanonicalBlocks
-  // loop through forkchoice single time
+  const canonicalRoots = new Set(finalizedCanonicalBlocks.map((block) => block.blockRoot));
+  const orphanedBlocks: ProtoBlock[] = [];
+  const orphanedPayloads: ProtoBlock[] = [];
 
-  const nonCanonicalBlockRoots = finalizedNonCanonicalBlocks.map((summary) => fromHex(summary.blockRoot));
-  if (nonCanonicalBlockRoots.length > 0) {
-    if (persistOrphanedBlocks) {
-      // Persist orphaned blocks to disk before deleting them from hot db
-      await Promise.all(
-        nonCanonicalBlockRoots.map(async (root, index) => {
-          const block = finalizedNonCanonicalBlocks[index];
-          const blockBytes = await db.block.getBinary(root);
-          const blockLogCtx = {slot: block.slot, root: block.blockRoot};
-          if (blockBytes) {
-            await persistOrphanedBlock(block.slot, block.blockRoot, blockBytes, {
-              persistOrphanedBlocksDir: persistOrphanedBlocksDir ?? "orphaned_blocks",
-            });
-            logger.verbose("Persisted orphaned block", {...logCtx, ...blockLogCtx});
-          } else {
-            logger.warn("Tried to persist orphaned block but no block found", {...logCtx, ...blockLogCtx});
-          }
-        })
-      );
+  for (const block of finalizedNonCanonicalBlocks) {
+    if (block.payloadStatus === PayloadStatus.FULL) {
+      orphanedPayloads.push(block);
     }
+    // Every Gloas block gets EMPTY before FULL. If only FULL survives pruning, an earlier archive run
+    // already handled the root's block-level data.
+    const isBlockNode = !isGloasBlock(block) || block.payloadStatus === PayloadStatus.EMPTY;
+    if (isBlockNode && !canonicalRoots.has(block.blockRoot)) {
+      orphanedBlocks.push(block);
+    }
+  }
+  const orphanedBlockRoots = orphanedBlocks.map((block) => fromHex(block.blockRoot));
 
-    const nonCanonicalSlots = finalizedNonCanonicalBlocks.map((summary) => summary.slot).sort((a, b) => a - b);
-    const nonCanonicalLogCtx = {
+  if (orphanedPayloads.length > 0) {
+    const orphanedPayloadRoots = orphanedPayloads.map((block) => fromHex(block.blockRoot));
+    const orphanedPayloadLogCtx = {
       ...logCtx,
-      count: nonCanonicalBlockRoots.length,
-      slotRange: prettyPrintIndices(nonCanonicalSlots),
+      count: orphanedPayloads.length,
+      slotRange: prettyPrintIndices(orphanedPayloads.map((block) => block.slot).sort((a, b) => a - b)),
     };
 
-    const columnItems = finalizedNonCanonicalBlocks
-      // Gloas EMPTY and FULL variants share a block root. EMPTY has no sidecars, so deleting by its root could
-      // remove the canonical FULL variant's columns. Pre-Gloas blocks are always FULL.
-      .filter(
-        (summary) => config.getForkSeq(summary.slot) >= ForkSeq.fulu && summary.payloadStatus === PayloadStatus.FULL
-      )
-      .map((summary) => ({slot: summary.slot, blockRoot: summary.blockRoot}));
+    const columnItems = orphanedPayloads
+      .filter((block) => config.getForkSeq(block.slot) >= ForkSeq.fulu)
+      .map((block) => ({slot: block.slot, blockRoot: block.blockRoot}));
     if (columnItems.length > 0) {
       // Delete sidecars first so their block roots remain available to retry cleanup after a failure or crash.
       await db.dataColumns.deleteMany(columnItems);
@@ -217,20 +208,44 @@ export async function archiveBlocks(
       });
     }
 
-    await db.block.batchDelete(nonCanonicalBlockRoots);
-    logger.verbose("Deleted non canonical blocks from hot DB", nonCanonicalLogCtx);
-
     if (finalizedPostDeneb) {
-      await db.blobSidecars.batchDelete(nonCanonicalBlockRoots);
-      logger.verbose("Deleted non canonical blobSidecars from hot DB", nonCanonicalLogCtx);
+      await db.blobSidecars.batchDelete(orphanedPayloadRoots);
+      logger.verbose("Deleted non canonical blobSidecars from hot DB", orphanedPayloadLogCtx);
     }
 
     if (finalizedPostGloas) {
-      await db.executionPayloadEnvelope.batchDelete(nonCanonicalBlockRoots);
-      logger.verbose("Deleted non canonical executionPayloadEnvelopes from hot DB", nonCanonicalLogCtx);
+      await db.executionPayloadEnvelope.batchDelete(orphanedPayloadRoots);
+      logger.verbose("Deleted non canonical executionPayloadEnvelopes from hot DB", orphanedPayloadLogCtx);
     }
   }
 
+  if (orphanedBlocks.length > 0) {
+    if (persistOrphanedBlocks) {
+      // Persist orphaned blocks to disk before deleting them from hot db
+      await Promise.all(
+        orphanedBlocks.map(async (block) => {
+          const blockBytes = await db.block.getBinary(fromHex(block.blockRoot));
+          const blockLogCtx = {slot: block.slot, root: block.blockRoot};
+          if (blockBytes) {
+            await persistOrphanedBlock(block.slot, block.blockRoot, blockBytes, {
+              persistOrphanedBlocksDir: persistOrphanedBlocksDir ?? "orphaned_blocks",
+            });
+            logger.verbose("Persisted orphaned block", {...logCtx, ...blockLogCtx});
+          } else {
+            logger.debug("Tried to persist orphaned block but no block found", {...logCtx, ...blockLogCtx});
+          }
+        })
+      );
+    }
+
+    await db.block.batchDelete(orphanedBlockRoots);
+    logger.verbose("Deleted non canonical blocks from hot DB", {
+      ...logCtx,
+      count: orphanedBlocks.length,
+      slotRange: prettyPrintIndices(orphanedBlocks.map((block) => block.slot).sort((a, b) => a - b)),
+    });
+  }
+
   // Delete expired blobs
   // Keep only `[current_epoch - max(MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS, archiveDataEpochs)]`
   // if archiveDataEpochs set to Infinity do not prune`
@@ -256,10 +271,7 @@ export async function archiveBlocks(
   // Keep only `[min(compute_blob_data_retention_start_epoch(current_epoch), current_epoch - archiveDataEpochs)]`
   if (finalizedPostFulu) {
     if (archiveDataEpochs !== Infinity) {
-      const dataColumnSidecarsMinEpoch = Math.min(
-        getBlobDataRetentionStartEpoch(config, currentEpoch),
-        currentEpoch - (archiveDataEpochs ?? 0)
-      );
+      const dataColumnSidecarsMinEpoch = getDataColumnSidecarsMinEpoch(config, currentEpoch, archiveDataEpochs);
       if (dataColumnSidecarsMinEpoch >= config.FULU_FORK_EPOCH) {
         const columnsPruneSlot = computeStartSlotAtEpoch(dataColumnSidecarsMinEpoch);
         const prunedColumnSlots = await db.dataColumns.pruneBefore(columnsPruneSlot);
@@ -283,9 +295,9 @@ export async function archiveBlocks(
     }
   }
 
-  // Prunning potential checkpoint data
+  // Pruning potential checkpoint data
   const finalizedCanonicalNonCheckpointBlocks = getNonCheckpointBlocks(finalizedCanonicalBlockRoots);
-  const nonCheckpointBlockRoots: Uint8Array[] = [...nonCanonicalBlockRoots];
+  const nonCheckpointBlockRoots: Uint8Array[] = [...orphanedBlockRoots];
   for (const block of finalizedCanonicalNonCheckpointBlocks) {
     nonCheckpointBlockRoots.push(block.root);
   }
@@ -408,72 +420,6 @@ async function migrateBlobSidecarsFromHotToColdDb(
   return migratedWrappedBlobSidecars;
 }
 
-// TODO: This function can be simplified further by reducing layers of promises in a loop
-/**
- * Post-gloas the data columns of a Gloas block are tied to its execution payload envelope.
- * Columns only exist once the FULL variant of the block is in the proto-array. Pre-Gloas
- * blocks only have a FULL variant, so the payload-status filter passes them all.
- */
-async function migrateDataColumnSidecarsFromHotToColdDb(
-  config: ChainForkConfig,
-  db: IBeaconDb,
-  logger: Logger,
-  canonicalBlocks: ProtoBlock[],
-  currentEpoch: Epoch
-): Promise<Slot[]> {
-  const columnBlocks = canonicalBlocks.filter(
-    (block) => config.getForkSeq(block.slot) < ForkSeq.gloas || block.payloadStatus === PayloadStatus.FULL
-  );
-  if (columnBlocks.length === 0) return [];
-  const blocks: BlockRootSlot[] = columnBlocks.map((block) => ({slot: block.slot, root: fromHex(block.blockRoot)}));
-
-  const migratedSlots: Slot[] = [];
-  for (let i = 0; i < blocks.length; i += BLOB_SIDECAR_BATCH_SIZE) {
-    const toIdx = Math.min(i + BLOB_SIDECAR_BATCH_SIZE, blocks.length);
-    const batch = blocks.slice(i, toIdx);
-    if (batch.length === 0) break;
-
-    const promises: Promise<void>[] = [];
-    for (const block of batch) {
-      const blockEpoch = computeEpochAtSlot(block.slot);
-      if (
-        config.getForkSeq(block.slot) < ForkSeq.fulu ||
-        blockEpoch < getBlobDataRetentionStartEpoch(config, currentEpoch)
-      ) {
-        continue;
-      }
-
-      const dataColumnSidecarBytes = await fromAsync(db.dataColumnSidecar.valuesStreamBinary(block.root));
-      if (dataColumnSidecarBytes.length === 0) {
-        logger.debug("DataColumnSidecars in forkchoice but missing in hot db, could be already archived", {
-          slot: block.slot,
-          root: toRootHex(block.root),
-        });
-        continue;
-      }
-      logger.verbose("Migrated legacy dataColumnSidecars for block", {
-        currentEpoch,
-        slot: block.slot,
-        root: toRootHex(block.root),
-        numSidecars: dataColumnSidecarBytes.length,
-      });
-      promises.push(
-        db.dataColumnSidecarArchive.putManyBinary(
-          block.slot,
-          dataColumnSidecarBytes.map((entry) => ({key: entry.id, value: entry.value}))
-        )
-      );
-      migratedSlots.push(block.slot);
-    }
-
-    await Promise.all(promises);
-    await db.dataColumnSidecar.deleteMany(batch.map((block) => block.root));
-  }
-
-  // Ancestor walk is newest to oldest; sort ascending so `prettyPrintIndices` renders cleanly.
-  return migratedSlots.sort((a, b) => a - b);
-}
-
 /**
  * Post-gloas given a finalized checkpoint at a block root, payload of that block root
  * is not considered finalized, hence they are archived in the next run.

package/src/chain/blocks/blockInput/blockInput.ts

@@ -1,15 +1,12 @@
-import {ForkName, ForkPostFulu, ForkPostGloas, ForkPreDeneb, ForkPreGloas, NUMBER_OF_COLUMNS} from "@lodestar/params";
-import {BeaconBlockBody, BlobIndex, ColumnIndex, SignedBeaconBlock, Slot, deneb, fulu, gloas} from "@lodestar/types";
-import {byteArrayEquals, fromHex, prettyBytes, toRootHex, withTimeout} from "@lodestar/utils";
+import {ForkName, ForkPostFulu, ForkPostGloas, ForkPreFulu, ForkPreGloas, NUMBER_OF_COLUMNS} from "@lodestar/params";
+import {BeaconBlockBody, ColumnIndex, SignedBeaconBlock, Slot, deneb, fulu, gloas} from "@lodestar/types";
+import {prettyBytes, toRootHex, withTimeout} from "@lodestar/utils";
 import {VersionedHashes} from "../../../execution/index.js";
 import {kzgCommitmentToVersionedHash} from "../../../util/blobs.js";
 import {BlockInputError, BlockInputErrorCode} from "./errors.js";
 import {
-  AddBlob,
   AddBlock,
   AddColumn,
-  BlobMeta,
-  BlobWithSource,
   BlockInputInit,
   ColumnWithSource,
   CreateBlockInputMeta,
@@ -17,22 +14,17 @@ import {
   DAType,
   IBlockInput,
   LogMetaBasic,
-  LogMetaBlobs,
   LogMetaColumns,
   MissingColumnMeta,
   PromiseParts,
   SourceMeta,
 } from "./types.js";
 
-export type BlockInput = BlockInputPreData | BlockInputBlobs | BlockInputColumns | BlockInputNoData;
+export type BlockInput = BlockInputPreData | BlockInputColumns | BlockInputNoData;
 
-export function isBlockInputPreDeneb(blockInput: IBlockInput): blockInput is BlockInputPreData {
+export function isBlockInputPreData(blockInput: IBlockInput): blockInput is BlockInputPreData {
   return blockInput.type === DAType.PreData;
 }
-export function isBlockInputBlobs(blockInput: IBlockInput): blockInput is BlockInputBlobs {
-  return blockInput.type === DAType.Blobs;
-}
-
 export function isBlockInputColumns(blockInput: IBlockInput): blockInput is BlockInputColumns {
   return blockInput.type === DAType.Columns;
 }
@@ -189,16 +181,18 @@ abstract class AbstractBlockInput<F extends ForkName = ForkName, TData extends D
 type BlockInputPreDataState = {
   hasBlock: true;
   hasAllData: true;
-  block: SignedBeaconBlock<ForkPreDeneb>;
+  block: SignedBeaconBlock<ForkPreFulu>;
   source: SourceMeta;
   timeCompleteSec: number;
 };
 
 /**
- * Pre-DA, BlockInput only has a single state.
+ * Pre-fulu BlockInput, it only has a single state.
  * - the block simply exists
+ *
+ * Legacy deneb..electra blob sidecars are not tracked.
  */
-export class BlockInputPreData extends AbstractBlockInput<ForkPreDeneb, null> {
+export class BlockInputPreData extends AbstractBlockInput<ForkPreFulu, null> {
   type = DAType.PreData as const;
 
   state: BlockInputPreDataState;
@@ -210,7 +204,7 @@ export class BlockInputPreData extends AbstractBlockInput<ForkPreDeneb, null> {
     this.blockPromise.resolve(state.block);
   }
 
-  static createFromBlock(props: AddBlock<ForkPreDeneb> & CreateBlockInputMeta): BlockInputPreData {
+  static createFromBlock(props: AddBlock<ForkPreFulu> & CreateBlockInputMeta): BlockInputPreData {
     const init: BlockInputInit = {
       daOutOfRange: props.daOutOfRange,
       timeCreated: props.seenTimestampSec,
@@ -250,332 +244,6 @@ export class BlockInputPreData extends AbstractBlockInput<ForkPreDeneb, null> {
   }
 }
 
-// Blobs DA
-
-export type ForkBlobsDA = ForkName.deneb | ForkName.electra;
-
-type BlockInputBlobsState =
-  | {
-      hasBlock: true;
-      hasAllData: true;
-      versionedHashes: VersionedHashes;
-      block: SignedBeaconBlock<ForkBlobsDA>;
-      source: SourceMeta;
-      timeCompleteSec: number;
-    }
-  | {
-      hasBlock: true;
-      hasAllData: false;
-      versionedHashes: VersionedHashes;
-      block: SignedBeaconBlock<ForkBlobsDA>;
-      source: SourceMeta;
-    }
-  | {
-      hasBlock: false;
-      hasAllData: false;
-    };
-
-/**
- * With blobs, BlockInput has several states:
- * - The block is seen and all blobs are seen
- * - The block is seen and all blobs are not yet seen
- * - The block is yet not seen and its unknown if all blobs are seen
- */
-export class BlockInputBlobs extends AbstractBlockInput<ForkBlobsDA, deneb.BlobSidecars> {
-  type = DAType.Blobs as const;
-
-  state: BlockInputBlobsState;
-  private blobsCache = new Map<BlobIndex, BlobWithSource>();
-
-  private constructor(init: BlockInputInit, state: BlockInputBlobsState) {
-    super(init);
-    this.state = state;
-  }
-
-  static createFromBlock(props: AddBlock<ForkBlobsDA> & CreateBlockInputMeta): BlockInputBlobs {
-    const hasAllData = props.daOutOfRange || props.block.message.body.blobKzgCommitments.length === 0;
-
-    const state = {
-      hasBlock: true,
-      hasAllData,
-      versionedHashes: props.block.message.body.blobKzgCommitments.map(kzgCommitmentToVersionedHash),
-      block: props.block,
-      source: {
-        source: props.source,
-        seenTimestampSec: props.seenTimestampSec,
-        peerIdStr: props.peerIdStr,
-      },
-      timeCompleteSec: hasAllData ? props.seenTimestampSec : undefined,
-    } as BlockInputBlobsState;
-    const init: BlockInputInit = {
-      daOutOfRange: props.daOutOfRange,
-      timeCreated: props.seenTimestampSec,
-      forkName: props.forkName,
-      slot: props.block.message.slot,
-      blockRootHex: props.blockRootHex,
-      parentRootHex: toRootHex(props.block.message.parentRoot),
-    };
-    const blockInput = new BlockInputBlobs(init, state);
-    blockInput.blockPromise.resolve(props.block);
-    if (hasAllData) {
-      blockInput.dataPromise.resolve([]);
-    }
-    return blockInput;
-  }
-
-  static createFromBlob(props: AddBlob & CreateBlockInputMeta): BlockInputBlobs {
-    const state: BlockInputBlobsState = {
-      hasBlock: false,
-      hasAllData: false,
-    };
-    const init: BlockInputInit = {
-      daOutOfRange: props.daOutOfRange,
-      timeCreated: props.seenTimestampSec,
-      forkName: props.forkName,
-      blockRootHex: props.blockRootHex,
-      parentRootHex: toRootHex(props.blobSidecar.signedBlockHeader.message.parentRoot),
-      slot: props.blobSidecar.signedBlockHeader.message.slot,
-    };
-    const blockInput = new BlockInputBlobs(init, state);
-    blockInput.blobsCache.set(props.blobSidecar.index, {
-      blobSidecar: props.blobSidecar,
-      source: props.source,
-      seenTimestampSec: props.seenTimestampSec,
-      peerIdStr: props.peerIdStr,
-    });
-    return blockInput;
-  }
-
-  getLogMeta(): LogMetaBlobs {
-    return {
-      slot: this.slot,
-      blockRoot: prettyBytes(this.blockRootHex),
-      timeCreatedSec: this.timeCreatedSec,
-      expectedBlobs: this.state.hasBlock ? this.state.block.message.body.blobKzgCommitments.length : "unknown",
-      receivedBlobs: this.blobsCache.size,
-    };
-  }
-
-  addBlock(
-    {blockRootHex, block, source, seenTimestampSec, peerIdStr}: AddBlock<ForkBlobsDA>,
-    opts = {throwOnDuplicateAdd: true}
-  ): void {
-    // this check suffices for checking slot, parentRoot, and forkName
-    if (blockRootHex !== this.blockRootHex) {
-      throw new BlockInputError(
-        {
-          code: BlockInputErrorCode.MISMATCHED_ROOT_HEX,
-          blockInputRoot: this.blockRootHex,
-          mismatchedRoot: blockRootHex,
-          source,
-          peerId: `${peerIdStr}`,
-        },
-        "addBlock blockRootHex does not match BlockInput.blockRootHex"
-      );
-    }
-
-    if (!opts.throwOnDuplicateAdd) {
-      return;
-    }
-
-    if (this.state.hasBlock) {
-      throw new BlockInputError(
-        {
-          code: BlockInputErrorCode.INVALID_CONSTRUCTION,
-          blockRoot: this.blockRootHex,
-        },
-        "Cannot addBlock to BlockInputBlobs after it already has a block"
-      );
-    }
-
-    for (const {blobSidecar} of this.blobsCache.values()) {
-      if (!blockAndBlobArePaired(block, blobSidecar)) {
-        this.blobsCache.delete(blobSidecar.index);
-        // TODO: (@matthewkeil) spec says to ignore invalid blobs but should we downscore the peer maybe?
-        // this.logger?.error(`Removing blobIndex=${blobSidecar.index} from BlockInput`, {}, err);
-      }
-    }
-
-    const hasAllData = this.blobsCache.size === block.message.body.blobKzgCommitments.length;
-
-    this.state = {
-      ...this.state,
-      hasBlock: true,
-      hasAllData,
-      block,
-      versionedHashes: block.message.body.blobKzgCommitments.map(kzgCommitmentToVersionedHash),
-      source: {
-        source,
-        seenTimestampSec,
-        peerIdStr,
-      },
-      timeCompleteSec: hasAllData ? seenTimestampSec : undefined,
-    } as BlockInputBlobsState;
-    this.blockPromise.resolve(block);
-    if (hasAllData) {
-      this.dataPromise.resolve(this.getBlobs());
-    }
-  }
-
-  hasBlob(blobIndex: BlobIndex): boolean {
-    return this.blobsCache.has(blobIndex);
-  }
-
-  getBlob(blobIndex: BlobIndex): deneb.BlobSidecar | undefined {
-    return this.blobsCache.get(blobIndex)?.blobSidecar;
-  }
-
-  addBlob(
-    {blockRootHex, blobSidecar, source, peerIdStr, seenTimestampSec}: AddBlob,
-    opts = {throwOnDuplicateAdd: true}
-  ): void {
-    // this check suffices for checking slot, parentRoot, and forkName
-    if (blockRootHex !== this.blockRootHex) {
-      throw new BlockInputError(
-        {
-          code: BlockInputErrorCode.MISMATCHED_ROOT_HEX,
-          blockInputRoot: this.blockRootHex,
-          mismatchedRoot: blockRootHex,
-          source: source,
-          peerId: `${peerIdStr}`,
-        },
-        "Blob BeaconBlockHeader blockRootHex does not match BlockInput.blockRootHex"
-      );
-    }
-
-    const isDuplicate = this.blobsCache.has(blobSidecar.index);
-    if (isDuplicate && opts.throwOnDuplicateAdd) {
-      throw new BlockInputError(
-        {
-          code: BlockInputErrorCode.INVALID_CONSTRUCTION,
-          blockRoot: this.blockRootHex,
-        },
-        "Cannot addBlob to BlockInputBlobs with duplicate blobIndex"
-      );
-    }
-
-    if (this.state.hasBlock) {
-      assertBlockAndBlobArePaired(this.blockRootHex, this.state.block, blobSidecar);
-    }
-
-    if (isDuplicate) {
-      return;
-    }
-
-    this.blobsCache.set(blobSidecar.index, {blobSidecar, source, seenTimestampSec, peerIdStr});
-
-    if (this.state.hasBlock && this.blobsCache.size === this.state.block.message.body.blobKzgCommitments.length) {
-      this.state = {
-        ...this.state,
-        hasAllData: true,
-        timeCompleteSec: seenTimestampSec,
-      };
-      this.dataPromise.resolve([...this.blobsCache.values()].map(({blobSidecar}) => blobSidecar));
-    }
-  }
-
-  getVersionedHashes(): VersionedHashes {
-    if (!this.state.hasBlock) {
-      throw new BlockInputError(
-        {
-          code: BlockInputErrorCode.INCOMPLETE_DATA,
-          ...this.getLogMeta(),
-        },
-        "Cannot get versioned hashes. Block is unknown"
-      );
-    }
-    return this.state.versionedHashes;
-  }
-
-  getMissingBlobMeta(): BlobMeta[] {
-    if (!this.state.hasBlock) {
-      throw new BlockInputError(
-        {
-          code: BlockInputErrorCode.INCOMPLETE_DATA,
-          ...this.getLogMeta(),
-        },
-        "Cannot get missing blobs. Block is unknown"
-      );
-    }
-    if (this.state.hasAllData) {
-      return [];
-    }
-
-    const blobMeta: BlobMeta[] = [];
-    const versionedHashes = this.state.versionedHashes;
-    for (let index = 0; index < versionedHashes.length; index++) {
-      if (!this.blobsCache.has(index)) {
-        blobMeta.push({
-          index,
-          blockRoot: fromHex(this.blockRootHex),
-          versionedHash: versionedHashes[index],
-        });
-      }
-    }
-    return blobMeta;
-  }
-
-  getAllBlobsWithSource(): BlobWithSource[] {
-    if (!this.state.hasAllData) {
-      throw new BlockInputError(
-        {
-          code: BlockInputErrorCode.INCOMPLETE_DATA,
-          ...this.getLogMeta(),
-        },
-        "Cannot get all blobs. DA status is not complete"
-      );
-    }
-    return [...this.blobsCache.values()];
-  }
-
-  getBlobs(): deneb.BlobSidecars {
-    return this.getAllBlobsWithSource().map(({blobSidecar}) => blobSidecar);
-  }
-
-  getSerializedCacheKeys(): object[] {
-    const objects: object[] = [];
-
-    if (this.state.hasBlock) {
-      objects.push(this.state.block);
-    }
-
-    for (const {blobSidecar} of this.blobsCache.values()) {
-      objects.push(blobSidecar);
-    }
-
-    return objects;
-  }
-}
-
-function blockAndBlobArePaired(block: SignedBeaconBlock<ForkBlobsDA>, blobSidecar: deneb.BlobSidecar): boolean {
-  const blockCommitment = block.message.body.blobKzgCommitments[blobSidecar.index];
-  if (!blockCommitment || !blobSidecar.kzgCommitment) {
-    return false;
-  }
-  return byteArrayEquals(blockCommitment, blobSidecar.kzgCommitment);
-}
-
-function assertBlockAndBlobArePaired(
-  blockRootHex: string,
-  block: SignedBeaconBlock<ForkBlobsDA>,
-  blobSidecar: deneb.BlobSidecar
-): void {
-  if (!blockAndBlobArePaired(block, blobSidecar)) {
-    // TODO: (@matthewkeil) should this eject the bad blob instead? No way to tell if the blob or the block
-    //       has the invalid commitment. Guessing it would be the blob though because we match via block
-    //       hashTreeRoot and we do not take a hashTreeRoot of the BlobSidecar
-    throw new BlockInputError(
-      {
-        code: BlockInputErrorCode.MISMATCHED_KZG_COMMITMENT,
-        blockRoot: blockRootHex,
-        slot: block.message.slot,
-        sidecarIndex: blobSidecar.index,
-      },
-      "BlobSidecar commitment does not match block commitment"
-    );
-  }
-}
-
 // Columns DA
 
 export type ForkColumnsDA = ForkName.fulu;

package/src/chain/blocks/blockInput/errors.ts

@@ -1,7 +1,7 @@
 import {Slot} from "@lodestar/types";
 import {LodestarError} from "@lodestar/utils";
 import {PeerIdStr} from "../../../util/peerId.js";
-import {BlockInputSource, LogMetaBlobs, LogMetaColumns} from "./types.js";
+import {BlockInputSource, LogMetaColumns} from "./types.js";
 
 export enum BlockInputErrorCode {
   // Bad Arguments
@@ -42,7 +42,6 @@ export type BlockInputErrorType =
       sidecarIndex: number;
       commitmentIndex?: number;
     }
-  | (LogMetaBlobs & {code: BlockInputErrorCode.INCOMPLETE_DATA})
   | (LogMetaColumns & {code: BlockInputErrorCode.INCOMPLETE_DATA});
 
 export class BlockInputError extends LodestarError<BlockInputErrorType> {}