@locksmithdon/dons-flow 2.1.1 → 2.2.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (57) hide show
  1. package/README.md +19 -71
  2. package/docs/conventions.md +1 -2
  3. package/docs/memory/.upstream-last-sync.json +4 -0
  4. package/docs/memory/MEMORY.md +2 -1
  5. package/docs/memory/monitor_upstream_evolution.md +8 -6
  6. package/docs/memory/upstream-sync-2026-06-13.md +61 -0
  7. package/docs/runbooks/monitor-upstream-evolution.md +74 -45
  8. package/package.json +21 -5
  9. package/scripts/sync-upstream.sh +193 -0
  10. package/skills/dons-flow/SKILL.md +9 -11
  11. package/skills/land/SKILL.md +2 -2
  12. package/skills/setup-dons-flow/SKILL.md +24 -102
  13. package/skills/sync-upstream/SKILL.md +94 -0
  14. package/vendor/superpowers/LICENSE +21 -0
  15. package/vendor/superpowers/skills/brainstorming/SKILL.md +164 -0
  16. package/vendor/superpowers/skills/brainstorming/scripts/frame-template.html +214 -0
  17. package/vendor/superpowers/skills/brainstorming/scripts/helper.js +88 -0
  18. package/vendor/superpowers/skills/brainstorming/scripts/server.cjs +354 -0
  19. package/vendor/superpowers/skills/brainstorming/scripts/start-server.sh +148 -0
  20. package/vendor/superpowers/skills/brainstorming/scripts/stop-server.sh +56 -0
  21. package/vendor/superpowers/skills/brainstorming/spec-document-reviewer-prompt.md +49 -0
  22. package/vendor/superpowers/skills/brainstorming/visual-companion.md +287 -0
  23. package/vendor/superpowers/skills/dispatching-parallel-agents/SKILL.md +182 -0
  24. package/vendor/superpowers/skills/executing-plans/SKILL.md +70 -0
  25. package/vendor/superpowers/skills/receiving-code-review/SKILL.md +213 -0
  26. package/vendor/superpowers/skills/requesting-code-review/SKILL.md +103 -0
  27. package/vendor/superpowers/skills/requesting-code-review/code-reviewer.md +168 -0
  28. package/vendor/superpowers/skills/subagent-driven-development/SKILL.md +279 -0
  29. package/vendor/superpowers/skills/subagent-driven-development/code-quality-reviewer-prompt.md +25 -0
  30. package/vendor/superpowers/skills/subagent-driven-development/implementer-prompt.md +113 -0
  31. package/vendor/superpowers/skills/subagent-driven-development/spec-reviewer-prompt.md +61 -0
  32. package/vendor/superpowers/skills/systematic-debugging/CREATION-LOG.md +119 -0
  33. package/vendor/superpowers/skills/systematic-debugging/SKILL.md +296 -0
  34. package/vendor/superpowers/skills/systematic-debugging/condition-based-waiting-example.ts +158 -0
  35. package/vendor/superpowers/skills/systematic-debugging/condition-based-waiting.md +115 -0
  36. package/vendor/superpowers/skills/systematic-debugging/defense-in-depth.md +122 -0
  37. package/vendor/superpowers/skills/systematic-debugging/find-polluter.sh +63 -0
  38. package/vendor/superpowers/skills/systematic-debugging/root-cause-tracing.md +169 -0
  39. package/vendor/superpowers/skills/systematic-debugging/test-academic.md +14 -0
  40. package/vendor/superpowers/skills/systematic-debugging/test-pressure-1.md +58 -0
  41. package/vendor/superpowers/skills/systematic-debugging/test-pressure-2.md +68 -0
  42. package/vendor/superpowers/skills/systematic-debugging/test-pressure-3.md +69 -0
  43. package/vendor/superpowers/skills/test-driven-development/SKILL.md +371 -0
  44. package/vendor/superpowers/skills/test-driven-development/testing-anti-patterns.md +299 -0
  45. package/vendor/superpowers/skills/using-superpowers/SKILL.md +117 -0
  46. package/vendor/superpowers/skills/using-superpowers/references/codex-tools.md +59 -0
  47. package/vendor/superpowers/skills/using-superpowers/references/copilot-tools.md +42 -0
  48. package/vendor/superpowers/skills/using-superpowers/references/gemini-tools.md +51 -0
  49. package/vendor/superpowers/skills/writing-plans/SKILL.md +152 -0
  50. package/vendor/superpowers/skills/writing-plans/plan-document-reviewer-prompt.md +49 -0
  51. package/vendor/superpowers/skills/writing-skills/SKILL.md +655 -0
  52. package/vendor/superpowers/skills/writing-skills/anthropic-best-practices.md +1150 -0
  53. package/vendor/superpowers/skills/writing-skills/examples/CLAUDE_MD_TESTING.md +189 -0
  54. package/vendor/superpowers/skills/writing-skills/graphviz-conventions.dot +172 -0
  55. package/vendor/superpowers/skills/writing-skills/persuasion-principles.md +187 -0
  56. package/vendor/superpowers/skills/writing-skills/render-graphs.js +168 -0
  57. package/vendor/superpowers/skills/writing-skills/testing-skills-with-subagents.md +384 -0
@@ -0,0 +1,117 @@
1
+ ---
2
+ name: using-superpowers
3
+ description: Use when starting any conversation - establishes how to find and use skills, requiring Skill tool invocation before ANY response including clarifying questions
4
+ ---
5
+
6
+ <SUBAGENT-STOP>
7
+ If you were dispatched as a subagent to execute a specific task, skip this skill.
8
+ </SUBAGENT-STOP>
9
+
10
+ <EXTREMELY-IMPORTANT>
11
+ If you think there is even a 1% chance a skill might apply to what you are doing, you ABSOLUTELY MUST invoke the skill.
12
+
13
+ IF A SKILL APPLIES TO YOUR TASK, YOU DO NOT HAVE A CHOICE. YOU MUST USE IT.
14
+
15
+ This is not negotiable. This is not optional. You cannot rationalize your way out of this.
16
+ </EXTREMELY-IMPORTANT>
17
+
18
+ ## Instruction Priority
19
+
20
+ Superpowers skills override default system prompt behavior, but **user instructions always take precedence**:
21
+
22
+ 1. **User's explicit instructions** (CLAUDE.md, GEMINI.md, AGENTS.md, direct requests) — highest priority
23
+ 2. **Superpowers skills** — override default system behavior where they conflict
24
+ 3. **Default system prompt** — lowest priority
25
+
26
+ If CLAUDE.md, GEMINI.md, or AGENTS.md says "don't use TDD" and a skill says "always use TDD," follow the user's instructions. The user is in control.
27
+
28
+ ## How to Access Skills
29
+
30
+ **In Claude Code:** Use the `Skill` tool. When you invoke a skill, its content is loaded and presented to you—follow it directly. Never use the Read tool on skill files.
31
+
32
+ **In Copilot CLI:** Use the `skill` tool. Skills are auto-discovered from installed plugins. The `skill` tool works the same as Claude Code's `Skill` tool.
33
+
34
+ **In Gemini CLI:** Skills activate via the `activate_skill` tool. Gemini loads skill metadata at session start and activates the full content on demand.
35
+
36
+ **In other environments:** Check your platform's documentation for how skills are loaded.
37
+
38
+ ## Platform Adaptation
39
+
40
+ Skills use Claude Code tool names. Non-CC platforms: see `references/copilot-tools.md` (Copilot CLI), `references/codex-tools.md` (Codex) for tool equivalents. Gemini CLI users get the tool mapping loaded automatically via GEMINI.md.
41
+
42
+ # Using Skills
43
+
44
+ ## The Rule
45
+
46
+ **Invoke relevant or requested skills BEFORE any response or action.** Even a 1% chance a skill might apply means that you should invoke the skill to check. If an invoked skill turns out to be wrong for the situation, you don't need to use it.
47
+
48
+ ```dot
49
+ digraph skill_flow {
50
+ "User message received" [shape=doublecircle];
51
+ "About to EnterPlanMode?" [shape=doublecircle];
52
+ "Already brainstormed?" [shape=diamond];
53
+ "Invoke brainstorming skill" [shape=box];
54
+ "Might any skill apply?" [shape=diamond];
55
+ "Invoke Skill tool" [shape=box];
56
+ "Announce: 'Using [skill] to [purpose]'" [shape=box];
57
+ "Has checklist?" [shape=diamond];
58
+ "Create TodoWrite todo per item" [shape=box];
59
+ "Follow skill exactly" [shape=box];
60
+ "Respond (including clarifications)" [shape=doublecircle];
61
+
62
+ "About to EnterPlanMode?" -> "Already brainstormed?";
63
+ "Already brainstormed?" -> "Invoke brainstorming skill" [label="no"];
64
+ "Already brainstormed?" -> "Might any skill apply?" [label="yes"];
65
+ "Invoke brainstorming skill" -> "Might any skill apply?";
66
+
67
+ "User message received" -> "Might any skill apply?";
68
+ "Might any skill apply?" -> "Invoke Skill tool" [label="yes, even 1%"];
69
+ "Might any skill apply?" -> "Respond (including clarifications)" [label="definitely not"];
70
+ "Invoke Skill tool" -> "Announce: 'Using [skill] to [purpose]'";
71
+ "Announce: 'Using [skill] to [purpose]'" -> "Has checklist?";
72
+ "Has checklist?" -> "Create TodoWrite todo per item" [label="yes"];
73
+ "Has checklist?" -> "Follow skill exactly" [label="no"];
74
+ "Create TodoWrite todo per item" -> "Follow skill exactly";
75
+ }
76
+ ```
77
+
78
+ ## Red Flags
79
+
80
+ These thoughts mean STOP—you're rationalizing:
81
+
82
+ | Thought | Reality |
83
+ |---------|---------|
84
+ | "This is just a simple question" | Questions are tasks. Check for skills. |
85
+ | "I need more context first" | Skill check comes BEFORE clarifying questions. |
86
+ | "Let me explore the codebase first" | Skills tell you HOW to explore. Check first. |
87
+ | "I can check git/files quickly" | Files lack conversation context. Check for skills. |
88
+ | "Let me gather information first" | Skills tell you HOW to gather information. |
89
+ | "This doesn't need a formal skill" | If a skill exists, use it. |
90
+ | "I remember this skill" | Skills evolve. Read current version. |
91
+ | "This doesn't count as a task" | Action = task. Check for skills. |
92
+ | "The skill is overkill" | Simple things become complex. Use it. |
93
+ | "I'll just do this one thing first" | Check BEFORE doing anything. |
94
+ | "This feels productive" | Undisciplined action wastes time. Skills prevent this. |
95
+ | "I know what that means" | Knowing the concept ≠ using the skill. Invoke it. |
96
+
97
+ ## Skill Priority
98
+
99
+ When multiple skills could apply, use this order:
100
+
101
+ 1. **Process skills first** (brainstorming, debugging) - these determine HOW to approach the task
102
+ 2. **Implementation skills second** (frontend-design, mcp-builder) - these guide execution
103
+
104
+ "Let's build X" → brainstorming first, then implementation skills.
105
+ "Fix this bug" → debugging first, then domain-specific skills.
106
+
107
+ ## Skill Types
108
+
109
+ **Rigid** (TDD, debugging): Follow exactly. Don't adapt away discipline.
110
+
111
+ **Flexible** (patterns): Adapt principles to context.
112
+
113
+ The skill itself tells you which.
114
+
115
+ ## User Instructions
116
+
117
+ Instructions say WHAT, not HOW. "Add X" or "Fix Y" doesn't mean skip workflows.
@@ -0,0 +1,59 @@
1
+ # Codex Tool Mapping
2
+
3
+ Skills use Claude Code tool names. When you encounter these in a skill, use your platform equivalent:
4
+
5
+ | Skill references | Codex equivalent |
6
+ |-----------------|------------------|
7
+ | `Task` tool (dispatch subagent) | `spawn_agent` (see [Subagent dispatch requires multi-agent support](#subagent-dispatch-requires-multi-agent-support)) |
8
+ | Multiple `Task` calls (parallel) | Multiple `spawn_agent` calls |
9
+ | Task returns result | `wait_agent` |
10
+ | Task completes automatically | `close_agent` to free slot |
11
+ | `TodoWrite` (task tracking) | `update_plan` |
12
+ | `Skill` tool (invoke a skill) | Skills load natively — just follow the instructions |
13
+ | `Read`, `Write`, `Edit` (files) | Use your native file tools |
14
+ | `Bash` (run commands) | Use your native shell tools |
15
+
16
+ ## Subagent dispatch requires multi-agent support
17
+
18
+ Add to your Codex config (`~/.codex/config.toml`):
19
+
20
+ ```toml
21
+ [features]
22
+ multi_agent = true
23
+ ```
24
+
25
+ This enables `spawn_agent`, `wait_agent`, and `close_agent` for skills like `dispatching-parallel-agents` and `subagent-driven-development`.
26
+
27
+ Legacy note: Codex builds before `rust-v0.115.0` exposed spawned-agent
28
+ waiting as `wait`. Current Codex uses `wait_agent` for spawned agents. The
29
+ `wait` name now belongs to code-mode `exec/wait`, which resumes a yielded exec
30
+ cell by `cell_id`; it is not the spawned-agent result tool.
31
+
32
+ ## Environment Detection
33
+
34
+ Skills that create worktrees or finish branches should detect their
35
+ environment with read-only git commands before proceeding:
36
+
37
+ ```bash
38
+ GIT_DIR=$(cd "$(git rev-parse --git-dir)" 2>/dev/null && pwd -P)
39
+ GIT_COMMON=$(cd "$(git rev-parse --git-common-dir)" 2>/dev/null && pwd -P)
40
+ BRANCH=$(git branch --show-current)
41
+ ```
42
+
43
+ - `GIT_DIR != GIT_COMMON` → already in a linked worktree (skip creation)
44
+ - `BRANCH` empty → detached HEAD (cannot branch/push/PR from sandbox)
45
+
46
+ See `using-git-worktrees` Step 0 and `finishing-a-development-branch`
47
+ Step 1 for how each skill uses these signals.
48
+
49
+ ## Codex App Finishing
50
+
51
+ When the sandbox blocks branch/push operations (detached HEAD in an
52
+ externally managed worktree), the agent commits all work and informs
53
+ the user to use the App's native controls:
54
+
55
+ - **"Create branch"** — names the branch, then commit/push/PR via App UI
56
+ - **"Hand off to local"** — transfers work to the user's local checkout
57
+
58
+ The agent can still run tests, stage files, and output suggested branch
59
+ names, commit messages, and PR descriptions for the user to copy.
@@ -0,0 +1,42 @@
1
+ # Copilot CLI Tool Mapping
2
+
3
+ Skills use Claude Code tool names. When you encounter these in a skill, use your platform equivalent:
4
+
5
+ | Skill references | Copilot CLI equivalent |
6
+ |-----------------|----------------------|
7
+ | `Read` (file reading) | `view` |
8
+ | `Write` (file creation) | `create` |
9
+ | `Edit` (file editing) | `edit` |
10
+ | `Bash` (run commands) | `bash` |
11
+ | `Grep` (search file content) | `grep` |
12
+ | `Glob` (search files by name) | `glob` |
13
+ | `Skill` tool (invoke a skill) | `skill` |
14
+ | `WebFetch` | `web_fetch` |
15
+ | `Task` tool (dispatch subagent) | `task` with `agent_type: "general-purpose"` or `"explore"` |
16
+ | Multiple `Task` calls (parallel) | Multiple `task` calls |
17
+ | Task status/output | `read_agent`, `list_agents` |
18
+ | `TodoWrite` (task tracking) | `sql` with built-in `todos` table |
19
+ | `WebSearch` | No equivalent — use `web_fetch` with a search engine URL |
20
+ | `EnterPlanMode` / `ExitPlanMode` | No equivalent — stay in the main session |
21
+
22
+ ## Async shell sessions
23
+
24
+ Copilot CLI supports persistent async shell sessions, which have no direct Claude Code equivalent:
25
+
26
+ | Tool | Purpose |
27
+ |------|---------|
28
+ | `bash` with `async: true` | Start a long-running command in the background |
29
+ | `write_bash` | Send input to a running async session |
30
+ | `read_bash` | Read output from an async session |
31
+ | `stop_bash` | Terminate an async session |
32
+ | `list_bash` | List all active shell sessions |
33
+
34
+ ## Additional Copilot CLI tools
35
+
36
+ | Tool | Purpose |
37
+ |------|---------|
38
+ | `store_memory` | Persist facts about the codebase for future sessions |
39
+ | `report_intent` | Update the UI status line with current intent |
40
+ | `sql` | Query the session's SQLite database (todos, metadata) |
41
+ | `fetch_copilot_cli_documentation` | Look up Copilot CLI documentation |
42
+ | GitHub MCP tools (`github-mcp-server-*`) | Native GitHub API access (issues, PRs, code search) |
@@ -0,0 +1,51 @@
1
+ # Gemini CLI Tool Mapping
2
+
3
+ Skills use Claude Code tool names. When you encounter these in a skill, use your platform equivalent:
4
+
5
+ | Skill references | Gemini CLI equivalent |
6
+ |-----------------|----------------------|
7
+ | `Read` (file reading) | `read_file` |
8
+ | `Write` (file creation) | `write_file` |
9
+ | `Edit` (file editing) | `replace` |
10
+ | `Bash` (run commands) | `run_shell_command` |
11
+ | `Grep` (search file content) | `grep_search` |
12
+ | `Glob` (search files by name) | `glob` |
13
+ | `TodoWrite` (task tracking) | `write_todos` |
14
+ | `Skill` tool (invoke a skill) | `activate_skill` |
15
+ | `WebSearch` | `google_web_search` |
16
+ | `WebFetch` | `web_fetch` |
17
+ | `Task` tool (dispatch subagent) | `@agent-name` (see [Subagent support](#subagent-support)) |
18
+
19
+ ## Subagent support
20
+
21
+ Gemini CLI supports subagents natively via the `@` syntax. Use the built-in `@generalist` agent to dispatch any task — it has access to all tools and follows the prompt you provide.
22
+
23
+ When a skill says to dispatch a named agent type, use `@generalist` with the full prompt from the skill's prompt template:
24
+
25
+ | Skill instruction | Gemini CLI equivalent |
26
+ |-------------------|----------------------|
27
+ | `Task tool (superpowers:implementer)` | `@generalist` with the filled `implementer-prompt.md` template |
28
+ | `Task tool (superpowers:spec-reviewer)` | `@generalist` with the filled `spec-reviewer-prompt.md` template |
29
+ | `Task tool (superpowers:code-reviewer)` | `@code-reviewer` (bundled agent) or `@generalist` with the filled review prompt |
30
+ | `Task tool (superpowers:code-quality-reviewer)` | `@generalist` with the filled `code-quality-reviewer-prompt.md` template |
31
+ | `Task tool (general-purpose)` with inline prompt | `@generalist` with your inline prompt |
32
+
33
+ ### Prompt filling
34
+
35
+ Skills provide prompt templates with placeholders like `{WHAT_WAS_IMPLEMENTED}` or `[FULL TEXT of task]`. Fill all placeholders and pass the complete prompt as the message to `@generalist`. The prompt template itself contains the agent's role, review criteria, and expected output format — `@generalist` will follow it.
36
+
37
+ ### Parallel dispatch
38
+
39
+ Gemini CLI supports parallel subagent dispatch. When a skill asks you to dispatch multiple independent subagent tasks in parallel, request all of those `@generalist` or named subagent tasks together in the same prompt. Keep dependent tasks sequential, but do not serialize independent subagent tasks just to preserve a simpler history.
40
+
41
+ ## Additional Gemini CLI tools
42
+
43
+ These tools are available in Gemini CLI but have no Claude Code equivalent:
44
+
45
+ | Tool | Purpose |
46
+ |------|---------|
47
+ | `list_directory` | List files and subdirectories |
48
+ | `save_memory` | Persist facts to GEMINI.md across sessions |
49
+ | `ask_user` | Request structured input from the user |
50
+ | `tracker_create_task` | Rich task management (create, update, list, visualize) |
51
+ | `enter_plan_mode` / `exit_plan_mode` | Switch to read-only research mode before making changes |
@@ -0,0 +1,152 @@
1
+ ---
2
+ name: writing-plans
3
+ description: Use when you have a spec or requirements for a multi-step task, before touching code
4
+ ---
5
+
6
+ # Writing Plans
7
+
8
+ ## Overview
9
+
10
+ Write comprehensive implementation plans assuming the engineer has zero context for our codebase and questionable taste. Document everything they need to know: which files to touch for each task, code, testing, docs they might need to check, how to test it. Give them the whole plan as bite-sized tasks. DRY. YAGNI. TDD. Frequent commits.
11
+
12
+ Assume they are a skilled developer, but know almost nothing about our toolset or problem domain. Assume they don't know good test design very well.
13
+
14
+ **Announce at start:** "I'm using the writing-plans skill to create the implementation plan."
15
+
16
+ **Context:** If working in an isolated worktree, it should have been created via the `superpowers:using-git-worktrees` skill at execution time.
17
+
18
+ **Save plans to:** `docs/superpowers/plans/YYYY-MM-DD-<feature-name>.md`
19
+ - (User preferences for plan location override this default)
20
+
21
+ ## Scope Check
22
+
23
+ If the spec covers multiple independent subsystems, it should have been broken into sub-project specs during brainstorming. If it wasn't, suggest breaking this into separate plans — one per subsystem. Each plan should produce working, testable software on its own.
24
+
25
+ ## File Structure
26
+
27
+ Before defining tasks, map out which files will be created or modified and what each one is responsible for. This is where decomposition decisions get locked in.
28
+
29
+ - Design units with clear boundaries and well-defined interfaces. Each file should have one clear responsibility.
30
+ - You reason best about code you can hold in context at once, and your edits are more reliable when files are focused. Prefer smaller, focused files over large ones that do too much.
31
+ - Files that change together should live together. Split by responsibility, not by technical layer.
32
+ - In existing codebases, follow established patterns. If the codebase uses large files, don't unilaterally restructure - but if a file you're modifying has grown unwieldy, including a split in the plan is reasonable.
33
+
34
+ This structure informs the task decomposition. Each task should produce self-contained changes that make sense independently.
35
+
36
+ ## Bite-Sized Task Granularity
37
+
38
+ **Each step is one action (2-5 minutes):**
39
+ - "Write the failing test" - step
40
+ - "Run it to make sure it fails" - step
41
+ - "Implement the minimal code to make the test pass" - step
42
+ - "Run the tests and make sure they pass" - step
43
+ - "Commit" - step
44
+
45
+ ## Plan Document Header
46
+
47
+ **Every plan MUST start with this header:**
48
+
49
+ ```markdown
50
+ # [Feature Name] Implementation Plan
51
+
52
+ > **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
53
+
54
+ **Goal:** [One sentence describing what this builds]
55
+
56
+ **Architecture:** [2-3 sentences about approach]
57
+
58
+ **Tech Stack:** [Key technologies/libraries]
59
+
60
+ ---
61
+ ```
62
+
63
+ ## Task Structure
64
+
65
+ ````markdown
66
+ ### Task N: [Component Name]
67
+
68
+ **Files:**
69
+ - Create: `exact/path/to/file.py`
70
+ - Modify: `exact/path/to/existing.py:123-145`
71
+ - Test: `tests/exact/path/to/test.py`
72
+
73
+ - [ ] **Step 1: Write the failing test**
74
+
75
+ ```python
76
+ def test_specific_behavior():
77
+ result = function(input)
78
+ assert result == expected
79
+ ```
80
+
81
+ - [ ] **Step 2: Run test to verify it fails**
82
+
83
+ Run: `pytest tests/path/test.py::test_name -v`
84
+ Expected: FAIL with "function not defined"
85
+
86
+ - [ ] **Step 3: Write minimal implementation**
87
+
88
+ ```python
89
+ def function(input):
90
+ return expected
91
+ ```
92
+
93
+ - [ ] **Step 4: Run test to verify it passes**
94
+
95
+ Run: `pytest tests/path/test.py::test_name -v`
96
+ Expected: PASS
97
+
98
+ - [ ] **Step 5: Commit**
99
+
100
+ ```bash
101
+ git add tests/path/test.py src/path/file.py
102
+ git commit -m "feat: add specific feature"
103
+ ```
104
+ ````
105
+
106
+ ## No Placeholders
107
+
108
+ Every step must contain the actual content an engineer needs. These are **plan failures** — never write them:
109
+ - "TBD", "TODO", "implement later", "fill in details"
110
+ - "Add appropriate error handling" / "add validation" / "handle edge cases"
111
+ - "Write tests for the above" (without actual test code)
112
+ - "Similar to Task N" (repeat the code — the engineer may be reading tasks out of order)
113
+ - Steps that describe what to do without showing how (code blocks required for code steps)
114
+ - References to types, functions, or methods not defined in any task
115
+
116
+ ## Remember
117
+ - Exact file paths always
118
+ - Complete code in every step — if a step changes code, show the code
119
+ - Exact commands with expected output
120
+ - DRY, YAGNI, TDD, frequent commits
121
+
122
+ ## Self-Review
123
+
124
+ After writing the complete plan, look at the spec with fresh eyes and check the plan against it. This is a checklist you run yourself — not a subagent dispatch.
125
+
126
+ **1. Spec coverage:** Skim each section/requirement in the spec. Can you point to a task that implements it? List any gaps.
127
+
128
+ **2. Placeholder scan:** Search your plan for red flags — any of the patterns from the "No Placeholders" section above. Fix them.
129
+
130
+ **3. Type consistency:** Do the types, method signatures, and property names you used in later tasks match what you defined in earlier tasks? A function called `clearLayers()` in Task 3 but `clearFullLayers()` in Task 7 is a bug.
131
+
132
+ If you find issues, fix them inline. No need to re-review — just fix and move on. If you find a spec requirement with no task, add the task.
133
+
134
+ ## Execution Handoff
135
+
136
+ After saving the plan, offer execution choice:
137
+
138
+ **"Plan complete and saved to `docs/superpowers/plans/<filename>.md`. Two execution options:**
139
+
140
+ **1. Subagent-Driven (recommended)** - I dispatch a fresh subagent per task, review between tasks, fast iteration
141
+
142
+ **2. Inline Execution** - Execute tasks in this session using executing-plans, batch execution with checkpoints
143
+
144
+ **Which approach?"**
145
+
146
+ **If Subagent-Driven chosen:**
147
+ - **REQUIRED SUB-SKILL:** Use superpowers:subagent-driven-development
148
+ - Fresh subagent per task + two-stage review
149
+
150
+ **If Inline Execution chosen:**
151
+ - **REQUIRED SUB-SKILL:** Use superpowers:executing-plans
152
+ - Batch execution with checkpoints for review
@@ -0,0 +1,49 @@
1
+ # Plan Document Reviewer Prompt Template
2
+
3
+ Use this template when dispatching a plan document reviewer subagent.
4
+
5
+ **Purpose:** Verify the plan is complete, matches the spec, and has proper task decomposition.
6
+
7
+ **Dispatch after:** The complete plan is written.
8
+
9
+ ```
10
+ Task tool (general-purpose):
11
+ description: "Review plan document"
12
+ prompt: |
13
+ You are a plan document reviewer. Verify this plan is complete and ready for implementation.
14
+
15
+ **Plan to review:** [PLAN_FILE_PATH]
16
+ **Spec for reference:** [SPEC_FILE_PATH]
17
+
18
+ ## What to Check
19
+
20
+ | Category | What to Look For |
21
+ |----------|------------------|
22
+ | Completeness | TODOs, placeholders, incomplete tasks, missing steps |
23
+ | Spec Alignment | Plan covers spec requirements, no major scope creep |
24
+ | Task Decomposition | Tasks have clear boundaries, steps are actionable |
25
+ | Buildability | Could an engineer follow this plan without getting stuck? |
26
+
27
+ ## Calibration
28
+
29
+ **Only flag issues that would cause real problems during implementation.**
30
+ An implementer building the wrong thing or getting stuck is an issue.
31
+ Minor wording, stylistic preferences, and "nice to have" suggestions are not.
32
+
33
+ Approve unless there are serious gaps — missing requirements from the spec,
34
+ contradictory steps, placeholder content, or tasks so vague they can't be acted on.
35
+
36
+ ## Output Format
37
+
38
+ ## Plan Review
39
+
40
+ **Status:** Approved | Issues Found
41
+
42
+ **Issues (if any):**
43
+ - [Task X, Step Y]: [specific issue] - [why it matters for implementation]
44
+
45
+ **Recommendations (advisory, do not block approval):**
46
+ - [suggestions for improvement]
47
+ ```
48
+
49
+ **Reviewer returns:** Status, Issues (if any), Recommendations