@localnerve/get-attribute 1.1.0 → 1.3.0

package/README.md

@@ -8,10 +8,10 @@
 
 ## Example
 
-Grab the full url from a specific anchor tag of interest:
+Grab the full url from a specific anchor tag of interest (all options shown):
 
 ```shell
-get-attribute --url=https://host.com/path --selector='a[href^="/videos"]' --attribute=href --useprop=true --timeout=5000
+get-attribute --url=https://host.com/path --selector='a[href^="/videos"]' --attribute=href --useprop=true --timeout=5000 --launchargs='{"headless":true}'
 
 # echoes the first matching href with full url from property: 'https://host.com/path/videos/123456789'
 ```

package/eslint.config.js

@@ -7,7 +7,8 @@ const ignores = {
   ignores: [
     'bin/**',
     'node_modules/**',
-    'tmp/**'
+    'tmp/**',
+    'coverage/**'
   ]
 };
 

package/lib/cli.js

@@ -21,6 +21,36 @@ function getCommandLineArgs (argv) {
   if (!prerequisite) {
     return null;
   }
+
+  if (args.useprop) {
+    const useprop = args.useprop.trim().toLowerCase();
+    if (useprop !== 'true' && useprop !== 'false') {
+      debug('useprop was not "true" or "false"', useprop);
+      return null;
+    }
+    args.useprop = useprop === 'true';
+  }
+
+  if (args.timeout) {
+    const timeout = parseInt(args.timeout, 10); 
+    if (!timeout) {
+      debug('could not parse timeout to decimal integer', args.timeout);
+      return null;
+    }
+    args.timeout = timeout;
+  }
+
+  if (args.launchargs) {
+    let launchargs;
+    try {
+      launchargs = JSON.parse(args.launchargs);
+    } catch (e) {
+      debug('launchargs was not valid json', args.launchargs, e);
+      return null;
+    }
+    args.launchargs = launchargs;
+  }
+
   return args;
 }
 

package/lib/get-attribute.js

@@ -9,17 +9,19 @@ const debug = require('debug')('get-attribute');
 
 async function getAttribute (url, selector, attribute, {
   useProp = false,
-  timeout = 10000
+  timeout = 10000,
+  launchArgs = {}
 } = {}) {
   debug('args', 
     `url=${url}`,
     `selector=${selector}`, 
     `attribute=${attribute}`, 
     `useProp=${useProp}`,
-    `timeout=${timeout}`
+    `timeout=${timeout}`,
+    `launchargs=${JSON.stringify(launchArgs)}`
   );
 
-  const browser = await puppeteer.launch();
+  const browser = await puppeteer.launch(launchArgs);
   let attributeValue = null;
 
   debug('launched successfully');
@@ -52,6 +54,7 @@ async function getAttribute (url, selector, attribute, {
     if (!(e instanceof TimeoutError)) {
       throw e;
     }
+    debug('received TimeoutError', e.message);
   } finally {
     await browser.close();
   }

package/lib/index.js

@@ -9,7 +9,7 @@
 const getArgs = require('./cli');
 const getAttr = require('./get-attribute');
 
-const syntax = 'get-attribute --url=https://host.dom --selector=a[href^="/videos"] --attribute=href [--useprop=false] [--timeout=10000]';
+const syntax = 'get-attribute --url=https://host.dom --selector=a[href^="/videos"] --attribute=href [--useprop=false] [--timeout=10000] [--launchargs=\'{"json":true}\']';
 const args = getArgs(process.argv);
 
 if (args) {
@@ -17,7 +17,8 @@ if (args) {
     const attributeValue = 
       await getAttr(args.url, args.selector, args.attribute, {
         useProp: args.useprop,
-        timeout: args.timeout
+        timeout: args.timeout,
+        launchArgs: args.launchargs
       });
     if (!attributeValue) {
       console.error('Failed to retrieve attribute');
@@ -28,5 +29,6 @@ if (args) {
   })();
 } else {
   console.error(`Argument error:\n\t${syntax}`);
+  console.error('Use DEBUG=cli for more info');
   process.exit(1);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@localnerve/get-attribute",
-  "version": "1.1.0",
+  "version": "1.3.0",
   "description": "Get an attribute from a webpage, echo to stdout",
   "main": "lib/index.js",
   "scripts": {
@@ -27,14 +27,14 @@
   },
   "homepage": "https://github.com/localnerve/get-attribute#readme",
   "dependencies": {
-    "puppeteer": "^22.6.5",
+    "puppeteer": "^22.7.1",
     "yargs": "^17.7.2",
     "debug": "^4.3.4"
   },
   "devDependencies": {
-    "eslint": "^9.1.0",
+    "eslint": "^9.1.1",
     "@eslint/js": "^9.1.1",
-    "eslint-plugin-jest": "^28.2.0",
+    "eslint-plugin-jest": "^28.3.0",
     "express": "^4.19.2",
     "globals": "^15.0.0",
     "jest": "^29.7.0",