@lobehub/lobehub 2.0.0-next.37 → 2.0.0-next.39

package/src/store/chat/slices/message/selectors/chat.test.ts

@@ -1,11 +1,6 @@
 import { UIChatMessage } from '@lobechat/types';
-import { LobeAgentConfig } from '@lobechat/types';
-import { act } from '@testing-library/react';
 import { describe, expect, it } from 'vitest';
 
-import { DEFAULT_INBOX_AVATAR } from '@/const/meta';
-import { INBOX_SESSION_ID } from '@/const/session';
-import { useAgentStore } from '@/store/agent';
 import { ChatStore } from '@/store/chat';
 import { initialState } from '@/store/chat/initialState';
 import { messageMapKey } from '@/store/chat/utils/messageMapKey';
@@ -15,7 +10,7 @@ import { merge } from '@/utils/merge';
 import { chatSelectors } from './chat';
 
 vi.mock('i18next', () => ({
-  t: vi.fn((key) => key), // Simplified mock return value
+  t: vi.fn((key) => key),
 }));
 
 const initialStore = initialState as ChatStore;
@@ -31,108 +26,15 @@ const mockMessages = [
     content: 'Goodbye World',
     role: 'user',
   },
-  {
-    id: 'msg3',
-    content: 'Function Message',
-    role: 'tool',
-    tools: [
-      {
-        arguments: ['arg1', 'arg2'],
-        identifier: 'func1',
-        apiName: 'ttt',
-        type: 'pluginType',
-        id: 'abc',
-      },
-    ],
-  },
-] as UIChatMessage[];
-
-const mockReasoningMessages = [
-  {
-    id: 'msg1',
-    content: 'Hello World',
-    role: 'user',
-  },
-  {
-    id: 'msg2',
-    content: 'Goodbye World',
-    role: 'user',
-  },
-  {
-    id: 'msg3',
-    content: 'Content Message',
-    role: 'assistant',
-    reasoning: {
-      content: 'Reasoning Content',
-    },
-  },
-] as UIChatMessage[];
-
-const mockedChats = [
-  {
-    id: 'msg1',
-    content: 'Hello World',
-    role: 'user',
-    meta: {
-      avatar: '😀',
-    },
-  },
-  {
-    id: 'msg2',
-    content: 'Goodbye World',
-    role: 'user',
-    meta: {
-      avatar: '😀',
-    },
-  },
-  {
-    id: 'msg3',
-    content: 'Function Message',
-    role: 'tool',
-    meta: {
-      avatar: DEFAULT_INBOX_AVATAR,
-      backgroundColor: 'rgba(0,0,0,0)',
-      description: 'inbox.desc',
-      title: 'inbox.title',
-    },
-    tools: [
-      {
-        arguments: ['arg1', 'arg2'],
-        identifier: 'func1',
-        apiName: 'ttt',
-        type: 'pluginType',
-        id: 'abc',
-      },
-    ],
-  },
 ] as UIChatMessage[];
 
-const mockChatStore = {
-  messagesMap: {
-    [messageMapKey('abc')]: mockMessages,
-  },
-  activeId: 'abc',
-} as ChatStore;
-
 beforeAll(() => {
   createServerConfigStore();
 });
 
-afterEach(() => {
-  const store = createServerConfigStore();
-  store.setState((state) => ({
-    featureFlags: { ...state.featureFlags, isAgentEditable: true },
-  }));
-});
-
-describe('chatSelectors', () => {
+describe('chatSelectors - Backward Compatibility Layer', () => {
   describe('getMessageById', () => {
-    it('should return undefined if the message with the given id does not exist', () => {
-      const message = chatSelectors.getMessageById('non-existent-id')(initialStore);
-      expect(message).toBeUndefined();
-    });
-
-    it('should return the message object with the matching id', () => {
+    it('should work as backward compatibility alias for getDisplayMessageById', () => {
       const state = merge(initialStore, {
         messagesMap: {
           [messageMapKey('abc')]: mockMessages,
@@ -140,218 +42,13 @@ describe('chatSelectors', () => {
         activeId: 'abc',
       });
       const message = chatSelectors.getMessageById('msg1')(state);
-      expect(message).toEqual(mockedChats[0]);
-    });
-
-    it('should return the message with the matching id', () => {
-      const message = chatSelectors.getMessageById('msg1')(mockChatStore);
-      expect(message).toEqual(mockedChats[0]);
-    });
-
-    it('should return undefined if no message matches the id', () => {
-      const message = chatSelectors.getMessageById('nonexistent')(mockChatStore);
-      expect(message).toBeUndefined();
-    });
-  });
-
-  describe('currentChatsWithHistoryConfig', () => {
-    it('should slice the messages according to the current agent config', () => {
-      const state = merge(initialStore, {
-        messagesMap: {
-          [messageMapKey('abc')]: mockMessages,
-        },
-        activeId: 'abc',
-      });
-
-      const chats = chatSelectors.mainAIChatsWithHistoryConfig(state);
-      expect(chats).toHaveLength(3);
-      expect(chats).toEqual(mockedChats);
-    });
-    it('should slice the messages according to config, assuming historyCount is mocked to 2', async () => {
-      const state = merge(initialStore, {
-        messagesMap: {
-          [messageMapKey('abc')]: mockMessages,
-        },
-        activeId: 'abc',
-      });
-      act(() => {
-        useAgentStore.setState({
-          activeId: 'inbox',
-          agentMap: {
-            inbox: {
-              chatConfig: {
-                historyCount: 2,
-                enableHistoryCount: true,
-              },
-              model: 'abc',
-            } as LobeAgentConfig,
-          },
-        });
-      });
-
-      const chats = chatSelectors.mainAIChatsWithHistoryConfig(state);
-
-      expect(chats).toHaveLength(2);
-      expect(chats).toEqual([
-        {
-          id: 'msg2',
-          content: 'Goodbye World',
-          role: 'user',
-          meta: {
-            avatar: '😀',
-          },
-        },
-        {
-          id: 'msg3',
-          content: 'Function Message',
-          role: 'tool',
-          meta: {
-            avatar: DEFAULT_INBOX_AVATAR,
-            backgroundColor: 'rgba(0,0,0,0)',
-            description: 'inbox.desc',
-            title: 'inbox.title',
-          },
-          tools: [
-            {
-              apiName: 'ttt',
-              arguments: ['arg1', 'arg2'],
-              identifier: 'func1',
-              id: 'abc',
-              type: 'pluginType',
-            },
-          ],
-        },
-      ]);
-    });
-  });
-
-  describe('chatsMessageString', () => {
-    it('should concatenate the contents of all messages returned by currentChatsWithHistoryConfig', () => {
-      // Prepare a state with a few messages
-      const state = merge(initialStore, {
-        messagesMap: {
-          [messageMapKey('active-session')]: mockMessages,
-        },
-        activeId: 'active-session',
-      });
-
-      // Assume that the currentChatsWithHistoryConfig will return the last two messages
-      const expectedString = mockMessages
-        .slice(-2)
-        .map((m) => m.content)
-        .join('');
-
-      // Call the selector and verify the result
-      const concatenatedString = chatSelectors.mainAIChatsMessageString(state);
-      expect(concatenatedString).toBe(expectedString);
-
-      // Restore the mocks after the test
-      vi.restoreAllMocks();
-    });
-  });
-
-  describe('latestMessageReasoningContent', () => {
-    it('should return the reasoning content of the latest message', () => {
-      // Prepare a state with a few messages
-      const state = merge(initialStore, {
-        messagesMap: {
-          [messageMapKey('active-session')]: mockReasoningMessages,
-        },
-        activeId: 'active-session',
-      });
-
-      const expectedString = mockReasoningMessages.at(-1)?.reasoning?.content;
-
-      // Call the selector and verify the result
-      const reasoningContent = chatSelectors.mainAILatestMessageReasoningContent(state);
-      expect(reasoningContent).toBe(expectedString);
-
-      // Restore the mocks after the test
-      vi.restoreAllMocks();
-    });
-  });
-
-  describe('showInboxWelcome', () => {
-    it('should return false if the active session is not the inbox session', () => {
-      const state = merge(initialStore, { activeId: 'someActiveId' });
-      const result = chatSelectors.showInboxWelcome(state);
-      expect(result).toBe(false);
-    });
-
-    it('should return false if there are existing messages in the inbox session', () => {
-      const state = merge(initialStore, {
-        activeId: INBOX_SESSION_ID,
-        messagesMap: {
-          [messageMapKey('inbox')]: mockMessages,
-        },
-      });
-      const result = chatSelectors.showInboxWelcome(state);
-      expect(result).toBe(false);
-    });
-
-    it('should return true if the active session is the inbox session and there are no existing messages', () => {
-      const state = merge(initialStore, {
-        activeId: INBOX_SESSION_ID,
-        messages: [],
-      });
-      const result = chatSelectors.showInboxWelcome(state);
-      expect(result).toBe(true);
-    });
-  });
-
-  describe('currentToolMessages', () => {
-    it('should return only tool messages', () => {
-      const messages = [
-        { id: '1', role: 'user', content: 'Hello' },
-        { id: '2', role: 'assistant', content: 'Hi' },
-        { id: '3', role: 'tool', content: 'Tool message 1' },
-        { id: '4', role: 'user', content: 'Query' },
-        { id: '5', role: 'tool', tools: [] },
-      ] as UIChatMessage[];
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        dbMessagesMap: {
-          [messageMapKey('test-id')]: messages,
-        },
-        messagesMap: {
-          [messageMapKey('test-id')]: messages,
-        },
-      };
-      const result = chatSelectors.currentToolMessages(state as ChatStore);
-      expect(result).toHaveLength(2);
-      expect(result.every((msg) => msg.role === 'tool')).toBe(true);
-    });
-
-    it('should return an empty array when no tool messages exist', () => {
-      const messages = [
-        { id: '1', role: 'user', content: 'Hello' },
-        { id: '2', role: 'assistant', content: 'Hi' },
-      ] as UIChatMessage[];
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        dbMessagesMap: {
-          [messageMapKey('test-id')]: messages,
-        },
-        messagesMap: {
-          [messageMapKey('test-id')]: messages,
-        },
-      };
-      const result = chatSelectors.currentToolMessages(state as ChatStore);
-      expect(result).toHaveLength(0);
+      expect(message?.id).toBe('msg1');
+      expect(message?.content).toBe('Hello World');
     });
   });
 
   describe('currentChatKey', () => {
-    it('should generate correct key with activeId only', () => {
-      const state: Partial<ChatStore> = {
-        activeId: 'testId',
-        activeTopicId: undefined,
-      };
-      const result = chatSelectors.currentChatKey(state as ChatStore);
-      expect(result).toBe(messageMapKey('testId', undefined));
-    });
-
-    it('should generate correct key with both activeId and activeTopicId', () => {
+    it('should work as backward compatibility alias for currentDisplayChatKey', () => {
       const state: Partial<ChatStore> = {
         activeId: 'testId',
         activeTopicId: 'topicId',
@@ -359,314 +56,37 @@ describe('chatSelectors', () => {
       const result = chatSelectors.currentChatKey(state as ChatStore);
       expect(result).toBe(messageMapKey('testId', 'topicId'));
     });
-
-    it('should generate key with undefined activeId', () => {
-      const state: Partial<ChatStore> = {
-        activeId: undefined,
-        activeTopicId: 'topicId',
-      };
-      const result = chatSelectors.currentChatKey(state as ChatStore);
-      expect(result).toBe(messageMapKey(undefined as any, 'topicId'));
-    });
-
-    it('should generate key with empty string activeId', () => {
-      const state: Partial<ChatStore> = {
-        activeId: '',
-        activeTopicId: undefined,
-      };
-      const result = chatSelectors.currentChatKey(state as ChatStore);
-      expect(result).toBe(messageMapKey('', undefined));
-    });
   });
 
-  describe('activeBaseChats with group chat messages', () => {
-    it('should retrieve agent meta for group chat messages with groupId and agentId', () => {
-      const groupChatMessages = [
-        {
-          id: 'msg1',
-          content: 'Hello from agent',
-          role: 'assistant',
-          groupId: 'group-123',
-          agentId: 'agent-456',
-        },
-      ] as UIChatMessage[];
-
+  describe('activeBaseChats', () => {
+    it('should work as backward compatibility alias for activeDisplayMessages', () => {
       const state = merge(initialStore, {
         messagesMap: {
-          [messageMapKey('group-123')]: groupChatMessages,
+          [messageMapKey('abc')]: mockMessages,
         },
-        activeId: 'group-123',
+        activeId: 'abc',
       });
-
       const chats = chatSelectors.activeBaseChats(state);
-      expect(chats).toHaveLength(1);
+      expect(chats).toHaveLength(2);
       expect(chats[0].id).toBe('msg1');
-      expect(chats[0].meta).toBeDefined();
     });
   });
 
-  describe('getGroupLatestMessageWithoutTools', () => {
-    it('should return the last child without tools', () => {
-      const groupMessage = {
-        id: 'group-1',
-        role: 'assistantGroup',
-        content: '',
-        children: [
-          {
-            id: 'child-1',
-            content: 'First response',
-            tools: [
-              {
-                id: 'tool-1',
-                identifier: 'test',
-                apiName: 'test',
-                arguments: '{}',
-                type: 'default',
-              },
-            ],
-          },
-          {
-            id: 'child-2',
-            content: 'Second response',
-            tools: [],
-          },
-          {
-            id: 'child-3',
-            content: 'Final response',
-          },
-        ],
-      } as UIChatMessage;
-
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        messagesMap: {
-          [messageMapKey('test-id')]: [groupMessage],
-        },
-      };
-
-      const result = chatSelectors.getGroupLatestMessageWithoutTools('group-1')(state as ChatStore);
-      expect(result).toBeDefined();
-      expect(result?.id).toBe('child-3');
-      expect(result?.content).toBe('Final response');
-    });
-
-    it('should return null if the last child has tools', () => {
-      const groupMessage = {
-        id: 'group-2',
-        role: 'assistantGroup',
-        content: '',
-        children: [
-          {
-            id: 'child-1',
-            content: 'First response',
-          },
-          {
-            id: 'child-2',
-            content: 'Second response with tools',
-            tools: [
-              {
-                id: 'tool-1',
-                identifier: 'test',
-                apiName: 'test',
-                arguments: '{}',
-                type: 'default',
-              },
-            ],
-          },
-        ],
-      } as UIChatMessage;
-
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        messagesMap: {
-          [messageMapKey('test-id')]: [groupMessage],
-        },
-      };
-
-      const result = chatSelectors.getGroupLatestMessageWithoutTools('group-2')(state as ChatStore);
-      expect(result).toBeUndefined();
-    });
-
-    it('should return the last child when it has empty tools array', () => {
-      const groupMessage = {
-        id: 'group-3',
-        role: 'assistantGroup',
-        content: '',
-        children: [
-          {
-            id: 'child-1',
-            content: 'First response with tools',
-            tools: [
-              {
-                id: 'tool-1',
-                identifier: 'test',
-                apiName: 'test',
-                arguments: '{}',
-                type: 'default',
-              },
-            ],
-          },
-          {
-            id: 'child-2',
-            content: 'Final response',
-            tools: [],
-          },
-        ],
-      } as UIChatMessage;
-
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        messagesMap: {
-          [messageMapKey('test-id')]: [groupMessage],
-        },
-      };
-
-      const result = chatSelectors.getGroupLatestMessageWithoutTools('group-3')(state as ChatStore);
-      expect(result).toBeDefined();
-      expect(result?.id).toBe('child-2');
-      expect(result?.content).toBe('Final response');
-    });
-
-    it('should return null for non-group messages', () => {
-      const assistantMessage = {
-        id: 'msg-1',
-        role: 'assistant',
-        content: 'Regular message',
-      } as UIChatMessage;
-
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        messagesMap: {
-          [messageMapKey('test-id')]: [assistantMessage],
-        },
-      };
-
-      const result = chatSelectors.getGroupLatestMessageWithoutTools('msg-1')(state as ChatStore);
-      expect(result).toBeUndefined();
-    });
-
-    it('should return null for group messages without children', () => {
-      const groupMessage = {
-        id: 'group-4',
-        role: 'assistantGroup',
-        content: '',
-        children: undefined,
-      } as UIChatMessage;
-
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        messagesMap: {
-          [messageMapKey('test-id')]: [groupMessage],
-        },
-      };
-
-      const result = chatSelectors.getGroupLatestMessageWithoutTools('group-4')(state as ChatStore);
-      expect(result).toBeUndefined();
-    });
-
-    it('should return null for group messages with empty children array', () => {
-      const groupMessage = {
-        id: 'group-5',
-        role: 'assistantGroup',
-        content: '',
-        children: [],
-      } as unknown as UIChatMessage;
-
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        messagesMap: {
-          [messageMapKey('test-id')]: [groupMessage],
-        },
-      };
-
-      const result = chatSelectors.getGroupLatestMessageWithoutTools('group-5')(state as ChatStore);
-      expect(result).toBeUndefined();
-    });
-
-    it('should return null if all children have tools', () => {
-      const groupMessage = {
-        id: 'group-6',
-        role: 'assistantGroup',
-        content: '',
-        children: [
-          {
-            id: 'child-1',
-            content: 'First response',
-            tools: [
-              {
-                id: 'tool-1',
-                identifier: 'test',
-                apiName: 'test',
-                arguments: '{}',
-                type: 'default',
-              },
-            ],
-          },
-          {
-            id: 'child-2',
-            content: 'Second response',
-            tools: [
-              {
-                id: 'tool-2',
-                identifier: 'test2',
-                apiName: 'test2',
-                arguments: '{}',
-                type: 'default',
-              },
-            ],
-          },
-        ],
-      } as unknown as UIChatMessage;
-
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        messagesMap: {
-          [messageMapKey('test-id')]: [groupMessage],
-        },
-      };
-
-      const result = chatSelectors.getGroupLatestMessageWithoutTools('group-6')(state as ChatStore);
-      expect(result).toBeUndefined();
-    });
-
-    it('should handle empty tools array as no tools', () => {
-      const groupMessage = {
-        id: 'group-7',
-        role: 'assistantGroup',
-        content: '',
-        children: [
-          {
-            id: 'child-1',
-            content: 'Response with empty tools',
-            tools: [],
-          },
-        ],
-      } as unknown as UIChatMessage;
-
-      const state: Partial<ChatStore> = {
-        activeId: 'test-id',
-        messagesMap: {
-          [messageMapKey('test-id')]: [groupMessage],
-        },
-      };
-
-      const result = chatSelectors.getGroupLatestMessageWithoutTools('group-7')(state as ChatStore);
-      expect(result).toBeDefined();
-      expect(result?.id).toBe('child-1');
-    });
-
-    it('should return null when message is not found', () => {
+  describe('currentToolMessages', () => {
+    it('should work as backward compatibility alias for dbToolMessages', () => {
+      const messages = [
+        { id: '1', role: 'user', content: 'Hello' },
+        { id: '2', role: 'tool', content: 'Tool message' },
+      ] as UIChatMessage[];
       const state: Partial<ChatStore> = {
         activeId: 'test-id',
-        messagesMap: {
-          [messageMapKey('test-id')]: [],
+        dbMessagesMap: {
+          [messageMapKey('test-id')]: messages,
         },
       };
-
-      const result = chatSelectors.getGroupLatestMessageWithoutTools('non-existent')(
-        state as ChatStore,
-      );
-      expect(result).toBeUndefined();
+      const result = chatSelectors.currentToolMessages(state as ChatStore);
+      expect(result).toHaveLength(1);
+      expect(result[0].role).toBe('tool');
     });
   });
 });

package/src/store/chat/slices/message/selectors/chat.ts

@@ -76,8 +76,6 @@ export const chatSelectors = {
 
   getBaseChatsByKey: displayMessageSelectors.getDisplayMessagesByKey,
 
-  getGroupLatestMessageWithoutTools: displayMessageSelectors.getGroupLatestMessageWithoutTools,
-
   getMessageById: displayMessageSelectors.getDisplayMessageById,
 
   getSupervisorTodos: displayMessageSelectors.getSupervisorTodos,