@lobehub/lobehub 2.0.0-next.294 → 2.0.0-next.296

package/packages/builtin-tool-gtd/src/client/components/SortableTodoList/store/store.test.ts

@@ -8,7 +8,7 @@ import { ADD_ITEM_ID } from './types';
 
 // Helper to create TodoItem array from text strings
 const toTodoItems = (...texts: string[]): TodoItem[] =>
-  texts.map((text) => ({ completed: false, text }));
+  texts.map((text) => ({ status: 'todo', text }));
 
 describe('TodoListStore', () => {
   beforeEach(() => {
@@ -39,7 +39,7 @@ describe('TodoListStore', () => {
 
       expect(state.items).toHaveLength(2);
       expect(state.items[0].text).toBe('Task 1');
-      expect(state.items[0].completed).toBe(false);
+      expect(state.items[0].status).toBe('todo');
       expect(state.items[1].text).toBe('Task 2');
     });
 
@@ -63,7 +63,7 @@ describe('TodoListStore', () => {
       const state = store.getState();
       expect(state.items).toHaveLength(1);
       expect(state.items[0].text).toBe('New Task');
-      expect(state.items[0].completed).toBe(false);
+      expect(state.items[0].status).toBe('todo');
       expect(state.newItemText).toBe('');
     });
 
@@ -152,23 +152,29 @@ describe('TodoListStore', () => {
   });
 
   describe('toggleItem', () => {
-    it('should toggle item completed state', () => {
+    it('should cycle through status: todo → processing → completed → todo', () => {
       const store = createTodoListStore(toTodoItems('Task 1'));
       const itemId = store.getState().items[0].id;
 
-      expect(store.getState().items[0].completed).toBe(false);
+      expect(store.getState().items[0].status).toBe('todo');
 
       act(() => {
         store.getState().toggleItem(itemId);
       });
 
-      expect(store.getState().items[0].completed).toBe(true);
+      expect(store.getState().items[0].status).toBe('processing');
 
       act(() => {
         store.getState().toggleItem(itemId);
       });
 
-      expect(store.getState().items[0].completed).toBe(false);
+      expect(store.getState().items[0].status).toBe('completed');
+
+      act(() => {
+        store.getState().toggleItem(itemId);
+      });
+
+      expect(store.getState().items[0].status).toBe('todo');
     });
 
     it('should mark store as dirty after toggling item', () => {
@@ -362,7 +368,7 @@ describe('TodoListStore', () => {
 
       expect(onSave).toHaveBeenCalledTimes(1);
       // onSave receives TodoItem[] (without id), not TodoListItem[]
-      expect(onSave).toHaveBeenCalledWith([{ completed: false, text: 'Updated' }]);
+      expect(onSave).toHaveBeenCalledWith([{ status: 'todo', text: 'Updated' }]);
     });
 
     it('should set saveStatus to saving during save', async () => {

package/packages/builtin-tool-gtd/src/executor/index.test.ts

@@ -22,7 +22,7 @@ describe('GTDExecutor', () => {
       expect(result.content).toContain('Call mom');
       expect(result.state?.todos.items).toHaveLength(2);
       expect(result.state?.todos.items[0].text).toBe('Buy milk');
-      expect(result.state?.todos.items[0].completed).toBe(false);
+      expect(result.state?.todos.items[0].status).toBe('todo');
       expect(result.state?.todos.items[1].text).toBe('Call mom');
     });
 
@@ -32,8 +32,8 @@ describe('GTDExecutor', () => {
       const result = await gtdExecutor.createTodos(
         {
           items: [
-            { text: 'Buy milk', completed: false },
-            { text: 'Call mom', completed: true },
+            { text: 'Buy milk', status: 'todo' },
+            { text: 'Call mom', status: 'completed' },
           ],
         },
         ctx,
@@ -43,15 +43,15 @@ describe('GTDExecutor', () => {
       expect(result.content).toContain('Added 2 items');
       expect(result.state?.todos.items).toHaveLength(2);
       expect(result.state?.todos.items[0].text).toBe('Buy milk');
-      expect(result.state?.todos.items[0].completed).toBe(false);
+      expect(result.state?.todos.items[0].status).toBe('todo');
       expect(result.state?.todos.items[1].text).toBe('Call mom');
-      expect(result.state?.todos.items[1].completed).toBe(true);
+      expect(result.state?.todos.items[1].status).toBe('completed');
     });
 
     it('should append items to existing todo list', async () => {
       const ctx = createMockContext({
         todos: {
-          items: [{ text: 'Existing task', completed: false }],
+          items: [{ text: 'Existing task', status: 'todo' }],
           updatedAt: '2024-01-01T00:00:00.000Z',
         },
       });
@@ -89,7 +89,7 @@ describe('GTDExecutor', () => {
       const result = await gtdExecutor.createTodos(
         {
           adds: ['AI task'],
-          items: [{ text: 'User edited task', completed: true }],
+          items: [{ text: 'User edited task', status: 'completed' }],
         },
         ctx,
       );
@@ -97,7 +97,7 @@ describe('GTDExecutor', () => {
       expect(result.success).toBe(true);
       expect(result.state?.todos.items).toHaveLength(1);
       expect(result.state?.todos.items[0].text).toBe('User edited task');
-      expect(result.state?.todos.items[0].completed).toBe(true);
+      expect(result.state?.todos.items[0].status).toBe('completed');
     });
   });
 
@@ -105,7 +105,7 @@ describe('GTDExecutor', () => {
     it('should add new items via operations', async () => {
       const ctx = createMockContext({
         todos: {
-          items: [{ text: 'Existing task', completed: false }],
+          items: [{ text: 'Existing task', status: 'todo' }],
           updatedAt: '2024-01-01T00:00:00.000Z',
         },
       });
@@ -125,7 +125,7 @@ describe('GTDExecutor', () => {
     it('should update item text via operations', async () => {
       const ctx = createMockContext({
         todos: {
-          items: [{ text: 'Old task', completed: false }],
+          items: [{ text: 'Old task', status: 'todo' }],
           updatedAt: '2024-01-01T00:00:00.000Z',
         },
       });
@@ -144,7 +144,7 @@ describe('GTDExecutor', () => {
     it('should complete items via operations', async () => {
       const ctx = createMockContext({
         todos: {
-          items: [{ text: 'Task', completed: false }],
+          items: [{ text: 'Task', status: 'todo' }],
           updatedAt: '2024-01-01T00:00:00.000Z',
         },
       });
@@ -157,15 +157,15 @@ describe('GTDExecutor', () => {
       );
 
       expect(result.success).toBe(true);
-      expect(result.state?.todos.items[0].completed).toBe(true);
+      expect(result.state?.todos.items[0].status).toBe('completed');
     });
 
     it('should remove items via operations', async () => {
       const ctx = createMockContext({
         todos: {
           items: [
-            { text: 'Task 1', completed: false },
-            { text: 'Task 2', completed: false },
+            { text: 'Task 1', status: 'todo' },
+            { text: 'Task 2', status: 'todo' },
           ],
           updatedAt: '2024-01-01T00:00:00.000Z',
         },
@@ -198,11 +198,11 @@ describe('GTDExecutor', () => {
         createdItems: ['Task A', 'Task B', 'Task C', 'Task D', 'Task E'],
         todos: {
           items: [
-            { completed: false, text: 'Task A' },
-            { completed: false, text: 'Task B' },
-            { completed: false, text: 'Task C' },
-            { completed: false, text: 'Task D' },
-            { completed: false, text: 'Task E' },
+            { status: 'todo', text: 'Task A' },
+            { status: 'todo', text: 'Task B' },
+            { status: 'todo', text: 'Task C' },
+            { status: 'todo', text: 'Task D' },
+            { status: 'todo', text: 'Task E' },
           ],
           updatedAt: '2025-01-01T00:00:00.000Z',
         },
@@ -211,8 +211,8 @@ describe('GTDExecutor', () => {
       const result = await gtdExecutor.updateTodos(
         {
           operations: [
-            { completed: true, index: 5, newText: '', text: '', type: 'complete' }, // out of range
-            { completed: true, index: 2, newText: '', text: '', type: 'complete' }, // valid
+            { index: 5, type: 'complete' }, // out of range
+            { index: 2, type: 'complete' }, // valid
           ],
         },
         ctx,
@@ -223,146 +223,12 @@ describe('GTDExecutor', () => {
       expect(result.state?.todos.items).toHaveLength(5);
       // Index 5 is out of range (0-4), so should be skipped
       // Index 2 should be completed
-      expect(result.state?.todos.items[2].completed).toBe(true);
+      expect(result.state?.todos.items[2].status).toBe('completed');
       // Other items should remain uncompleted
-      expect(result.state?.todos.items[0].completed).toBe(false);
-      expect(result.state?.todos.items[1].completed).toBe(false);
-      expect(result.state?.todos.items[3].completed).toBe(false);
-      expect(result.state?.todos.items[4].completed).toBe(false);
-    });
-  });
-
-  describe('completeTodos', () => {
-    it('should mark items as done by indices', async () => {
-      const ctx = createMockContext({
-        todos: {
-          items: [
-            { text: 'Task 1', completed: false },
-            { text: 'Task 2', completed: false },
-            { text: 'Task 3', completed: false },
-          ],
-          updatedAt: '2024-01-01T00:00:00.000Z',
-        },
-      });
-
-      const result = await gtdExecutor.completeTodos({ indices: [0, 2] }, ctx);
-
-      expect(result.success).toBe(true);
-      expect(result.content).toContain('Completed 2 items');
-      expect(result.state?.todos.items[0].completed).toBe(true);
-      expect(result.state?.todos.items[1].completed).toBe(false);
-      expect(result.state?.todos.items[2].completed).toBe(true);
-    });
-
-    it('should return error when no indices provided', async () => {
-      const ctx = createMockContext();
-
-      const result = await gtdExecutor.completeTodos({ indices: [] }, ctx);
-
-      expect(result.success).toBe(false);
-      expect(result.content).toContain('No indices provided');
-    });
-
-    it('should handle empty todo list', async () => {
-      const ctx = createMockContext({
-        todos: { items: [], updatedAt: '2024-01-01T00:00:00.000Z' },
-      });
-
-      const result = await gtdExecutor.completeTodos({ indices: [0] }, ctx);
-
-      expect(result.success).toBe(true);
-      expect(result.content).toContain('No todos to complete');
-    });
-
-    it('should return error when all indices are invalid', async () => {
-      const ctx = createMockContext({
-        todos: {
-          items: [{ text: 'Task 1', completed: false }],
-          updatedAt: '2024-01-01T00:00:00.000Z',
-        },
-      });
-
-      const result = await gtdExecutor.completeTodos({ indices: [5, 10] }, ctx);
-
-      expect(result.success).toBe(false);
-      expect(result.content).toContain('Invalid indices');
-    });
-
-    it('should complete valid indices and warn about invalid ones', async () => {
-      const ctx = createMockContext({
-        todos: {
-          items: [
-            { text: 'Task 1', completed: false },
-            { text: 'Task 2', completed: false },
-          ],
-          updatedAt: '2024-01-01T00:00:00.000Z',
-        },
-      });
-
-      const result = await gtdExecutor.completeTodos({ indices: [0, 99] }, ctx);
-
-      expect(result.success).toBe(true);
-      expect(result.content).toContain('Completed 1 item');
-      expect(result.content).toContain('Ignored invalid indices');
-      expect(result.state?.todos.items[0].completed).toBe(true);
-      expect(result.state?.todos.items[1].completed).toBe(false);
-    });
-
-    it('should handle single item completion with correct grammar', async () => {
-      const ctx = createMockContext({
-        todos: {
-          items: [{ text: 'Task 1', completed: false }],
-          updatedAt: '2024-01-01T00:00:00.000Z',
-        },
-      });
-
-      const result = await gtdExecutor.completeTodos({ indices: [0] }, ctx);
-
-      expect(result.success).toBe(true);
-      expect(result.content).toContain('Completed 1 item');
-      expect(result.content).not.toContain('items');
-    });
-  });
-
-  describe('removeTodos', () => {
-    it('should remove items by indices', async () => {
-      const ctx = createMockContext({
-        todos: {
-          items: [
-            { text: 'Task 1', completed: false },
-            { text: 'Task 2', completed: false },
-            { text: 'Task 3', completed: false },
-          ],
-          updatedAt: '2024-01-01T00:00:00.000Z',
-        },
-      });
-
-      const result = await gtdExecutor.removeTodos({ indices: [0, 2] }, ctx);
-
-      expect(result.success).toBe(true);
-      expect(result.content).toContain('Removed 2 items');
-      expect(result.state?.todos.items).toHaveLength(1);
-      expect(result.state?.todos.items[0].text).toBe('Task 2');
-    });
-
-    it('should return error when no indices provided', async () => {
-      const ctx = createMockContext();
-
-      const result = await gtdExecutor.removeTodos({ indices: [] }, ctx);
-
-      expect(result.success).toBe(false);
-      expect(result.content).toContain('No indices provided');
-    });
-
-    it('should handle empty todo list', async () => {
-      const ctx = createMockContext({
-        todos: { items: [], updatedAt: '2024-01-01T00:00:00.000Z' },
-      });
-
-      const result = await gtdExecutor.removeTodos({ indices: [0] }, ctx);
-
-      expect(result.success).toBe(true);
-      expect(result.content).toContain('No todos to remove');
+      expect(result.state?.todos.items[0].status).toBe('todo');
+      expect(result.state?.todos.items[1].status).toBe('todo');
+      expect(result.state?.todos.items[3].status).toBe('todo');
+      expect(result.state?.todos.items[4].status).toBe('todo');
     });
   });
 
@@ -371,8 +237,8 @@ describe('GTDExecutor', () => {
       const ctx = createMockContext({
         todos: {
           items: [
-            { text: 'Task 1', completed: false },
-            { text: 'Task 2', completed: true },
+            { text: 'Task 1', status: 'todo' },
+            { text: 'Task 2', status: 'completed' },
           ],
           updatedAt: '2024-01-01T00:00:00.000Z',
         },
@@ -389,9 +255,9 @@ describe('GTDExecutor', () => {
       const ctx = createMockContext({
         todos: {
           items: [
-            { text: 'Task 1', completed: false },
-            { text: 'Task 2', completed: true },
-            { text: 'Task 3', completed: true },
+            { text: 'Task 1', status: 'todo' },
+            { text: 'Task 2', status: 'completed' },
+            { text: 'Task 3', status: 'completed' },
           ],
           updatedAt: '2024-01-01T00:00:00.000Z',
         },
@@ -421,7 +287,7 @@ describe('GTDExecutor', () => {
     it('should handle no completed items to clear', async () => {
       const ctx = createMockContext({
         todos: {
-          items: [{ text: 'Task 1', completed: false }],
+          items: [{ text: 'Task 1', status: 'todo' }],
           updatedAt: '2024-01-01T00:00:00.000Z',
         },
       });
@@ -442,13 +308,13 @@ describe('GTDExecutor', () => {
         operationId: 'test-operation-id',
         pluginState: {
           todos: {
-            items: [{ text: 'Old task from pluginState', completed: false }],
+            items: [{ text: 'Old task from pluginState', status: 'todo' }],
             updatedAt: '2024-01-01T00:00:00.000Z',
           },
         },
         stepContext: {
           todos: {
-            items: [{ text: 'New task from stepContext', completed: true }],
+            items: [{ text: 'New task from stepContext', status: 'completed' }],
             updatedAt: '2024-06-01T00:00:00.000Z',
           },
         },
@@ -461,7 +327,7 @@ describe('GTDExecutor', () => {
       expect(result.state?.todos.items).toHaveLength(2);
       // First item should be from stepContext, not pluginState
       expect(result.state?.todos.items[0].text).toBe('New task from stepContext');
-      expect(result.state?.todos.items[0].completed).toBe(true);
+      expect(result.state?.todos.items[0].status).toBe('completed');
       expect(result.state?.todos.items[1].text).toBe('Another task');
     });
 
@@ -471,7 +337,7 @@ describe('GTDExecutor', () => {
         operationId: 'test-operation-id',
         pluginState: {
           todos: {
-            items: [{ text: 'Task from pluginState', completed: false }],
+            items: [{ text: 'Task from pluginState', status: 'todo' }],
             updatedAt: '2024-01-01T00:00:00.000Z',
           },
         },
@@ -502,50 +368,6 @@ describe('GTDExecutor', () => {
       expect(result.state?.todos.items[0].text).toBe('First task');
     });
 
-    it('should work with stepContext.todos for completeTodos', async () => {
-      const ctx: BuiltinToolContext = {
-        messageId: 'test-message-id',
-        operationId: 'test-operation-id',
-        stepContext: {
-          todos: {
-            items: [
-              { text: 'Task 1', completed: false },
-              { text: 'Task 2', completed: false },
-            ],
-            updatedAt: '2024-06-01T00:00:00.000Z',
-          },
-        },
-      };
-
-      const result = await gtdExecutor.completeTodos({ indices: [0] }, ctx);
-
-      expect(result.success).toBe(true);
-      expect(result.state?.todos.items[0].completed).toBe(true);
-      expect(result.state?.todos.items[1].completed).toBe(false);
-    });
-
-    it('should work with stepContext.todos for removeTodos', async () => {
-      const ctx: BuiltinToolContext = {
-        messageId: 'test-message-id',
-        operationId: 'test-operation-id',
-        stepContext: {
-          todos: {
-            items: [
-              { text: 'Task 1', completed: false },
-              { text: 'Task 2', completed: false },
-            ],
-            updatedAt: '2024-06-01T00:00:00.000Z',
-          },
-        },
-      };
-
-      const result = await gtdExecutor.removeTodos({ indices: [0] }, ctx);
-
-      expect(result.success).toBe(true);
-      expect(result.state?.todos.items).toHaveLength(1);
-      expect(result.state?.todos.items[0].text).toBe('Task 2');
-    });
-
     it('should work with stepContext.todos for clearTodos', async () => {
       const ctx: BuiltinToolContext = {
         messageId: 'test-message-id',
@@ -553,8 +375,8 @@ describe('GTDExecutor', () => {
         stepContext: {
           todos: {
             items: [
-              { text: 'Task 1', completed: true },
-              { text: 'Task 2', completed: false },
+              { text: 'Task 1', status: 'completed' },
+              { text: 'Task 2', status: 'todo' },
             ],
             updatedAt: '2024-06-01T00:00:00.000Z',
           },
@@ -574,27 +396,26 @@ describe('GTDExecutor', () => {
       expect(gtdExecutor.identifier).toBe('lobe-gtd');
     });
 
-    it('should support all MVP APIs', () => {
+    it('should support all APIs', () => {
       expect(gtdExecutor.hasApi('createTodos')).toBe(true);
       expect(gtdExecutor.hasApi('updateTodos')).toBe(true);
-      expect(gtdExecutor.hasApi('completeTodos')).toBe(true);
-      expect(gtdExecutor.hasApi('removeTodos')).toBe(true);
       expect(gtdExecutor.hasApi('clearTodos')).toBe(true);
-    });
-
-    it('should not support non-MVP APIs', () => {
-      expect(gtdExecutor.hasApi('createPlan')).toBe(false);
-      expect(gtdExecutor.hasApi('updatePlan')).toBe(false);
+      expect(gtdExecutor.hasApi('createPlan')).toBe(true);
+      expect(gtdExecutor.hasApi('updatePlan')).toBe(true);
+      expect(gtdExecutor.hasApi('execTask')).toBe(true);
+      expect(gtdExecutor.hasApi('execTasks')).toBe(true);
     });
 
     it('should return correct API names', () => {
       const apiNames = gtdExecutor.getApiNames();
       expect(apiNames).toContain('createTodos');
       expect(apiNames).toContain('updateTodos');
-      expect(apiNames).toContain('completeTodos');
-      expect(apiNames).toContain('removeTodos');
       expect(apiNames).toContain('clearTodos');
-      expect(apiNames).toHaveLength(5);
+      expect(apiNames).toContain('createPlan');
+      expect(apiNames).toContain('updatePlan');
+      expect(apiNames).toContain('execTask');
+      expect(apiNames).toContain('execTasks');
+      expect(apiNames).toHaveLength(7);
     });
   });
 });