@lobehub/lobehub 2.0.0-next.254 → 2.0.0-next.256

package/CHANGELOG.md

@@ -2,6 +2,56 @@
 
 # Changelog
 
+## [Version 2.0.0-next.256](https://github.com/lobehub/lobe-chat/compare/v2.0.0-next.255...v2.0.0-next.256)
+
+<sup>Released on **2026-01-10**</sup>
+
+#### ♻ Code Refactoring
+
+- **misc**: Refactor page and notebook document usage.
+
+<br/>
+
+<details>
+<summary><kbd>Improvements and Fixes</kbd></summary>
+
+#### Code refactoring
+
+- **misc**: Refactor page and notebook document usage, closes [#11345](https://github.com/lobehub/lobe-chat/issues/11345) ([88721eb](https://github.com/lobehub/lobe-chat/commit/88721eb))
+
+</details>
+
+<div align="right">
+
+[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)
+
+</div>
+
+## [Version 2.0.0-next.255](https://github.com/lobehub/lobe-chat/compare/v2.0.0-next.254...v2.0.0-next.255)
+
+<sup>Released on **2026-01-10**</sup>
+
+#### 🐛 Bug Fixes
+
+- **misc**: Fix auto add group member crash.
+
+<br/>
+
+<details>
+<summary><kbd>Improvements and Fixes</kbd></summary>
+
+#### What's fixed
+
+- **misc**: Fix auto add group member crash, closes [#11387](https://github.com/lobehub/lobe-chat/issues/11387) ([fe4ff91](https://github.com/lobehub/lobe-chat/commit/fe4ff91))
+
+</details>
+
+<div align="right">
+
+[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)
+
+</div>
+
 ## [Version 2.0.0-next.254](https://github.com/lobehub/lobe-chat/compare/v2.0.0-next.253...v2.0.0-next.254)
 
 <sup>Released on **2026-01-10**</sup>

package/changelog/v1.json

@@ -1,4 +1,22 @@
 [
+  {
+    "children": {
+      "improvements": [
+        "Refactor page and notebook document usage."
+      ]
+    },
+    "date": "2026-01-10",
+    "version": "2.0.0-next.256"
+  },
+  {
+    "children": {
+      "fixes": [
+        "Fix auto add group member crash."
+      ]
+    },
+    "date": "2026-01-10",
+    "version": "2.0.0-next.255"
+  },
   {
     "children": {
       "improvements": [

package/locales/en-US/plugin.json

@@ -92,6 +92,7 @@
   "builtins.lobe-local-system.inspector.noResults": "No results",
   "builtins.lobe-local-system.inspector.rename.result": "<old>{{oldName}}</old> → <new>{{newName}}</new>",
   "builtins.lobe-local-system.title": "Local System",
+  "builtins.lobe-notebook.actions.collapse": "Collapse",
   "builtins.lobe-notebook.actions.copy": "Copy",
   "builtins.lobe-notebook.actions.creating": "Creating document...",
   "builtins.lobe-notebook.actions.edit": "Edit",

package/locales/zh-CN/plugin.json

@@ -92,6 +92,7 @@
   "builtins.lobe-local-system.inspector.noResults": "无结果",
   "builtins.lobe-local-system.inspector.rename.result": "<old>{{oldName}}</old> → <new>{{newName}}</new>",
   "builtins.lobe-local-system.title": "本地系统",
+  "builtins.lobe-notebook.actions.collapse": "收起",
   "builtins.lobe-notebook.actions.copy": "复制",
   "builtins.lobe-notebook.actions.creating": "文档创建中...",
   "builtins.lobe-notebook.actions.edit": "编辑",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lobehub/lobehub",
-  "version": "2.0.0-next.254",
+  "version": "2.0.0-next.256",
   "description": "LobeHub - an open-source,comprehensive AI Agent framework that supports speech synthesis, multimodal, and extensible Function Call plugin system. Supports one-click free deployment of your private ChatGPT/LLM web application.",
   "keywords": [
     "framework",

package/packages/builtin-tool-notebook/src/client/Placeholder/CreateDocument.tsx

@@ -21,7 +21,7 @@ const styles = createStaticStyles(({ css, cssVar }) => ({
     border: 1px solid ${cssVar.colorBorderSecondary};
     border-radius: 16px;
 
-    background: ${cssVar.colorBgElevated};
+    background: ${cssVar.colorBgContainer};
   `,
   content: css`
     padding-block: 16px;
@@ -42,11 +42,11 @@ const styles = createStaticStyles(({ css, cssVar }) => ({
     transform: translateX(-50%);
 
     display: inline-flex;
-    gap: 6px;
+    gap: 8px;
     align-items: center;
 
-    padding-block: 4px;
-    padding-inline: 12px;
+    height: 32px;
+    padding-inline: 16px;
     border: 1px solid ${cssVar.colorBorderSecondary};
     border-radius: 16px;
 
@@ -90,8 +90,8 @@ export const CreateDocumentPlaceholder = memo<BuiltinPlaceholderProps<CreateDocu
           )}
         </ScrollShadow>
         <div className={styles.statusTag}>
-          <NeuralNetworkLoading size={14} />
-          <span style={{ fontSize: 12 }}>{t('builtins.lobe-notebook.actions.creating')}</span>
+          <NeuralNetworkLoading size={16} />
+          <span>{t('builtins.lobe-notebook.actions.creating')}</span>
         </div>
       </Flexbox>
     );

package/packages/builtin-tool-notebook/src/client/Render/CreateDocument/DocumentCard.tsx

@@ -3,11 +3,12 @@
 import { ActionIcon, CopyButton, Flexbox, Markdown, ScrollShadow } from '@lobehub/ui';
 import { Button } from 'antd';
 import { createStaticStyles } from 'antd-style';
-import { Maximize2, NotebookText, PencilLine } from 'lucide-react';
+import { Maximize2, Minimize2, NotebookText, PencilLine } from 'lucide-react';
 import { memo } from 'react';
 import { useTranslation } from 'react-i18next';
 
 import { useChatStore } from '@/store/chat';
+import { chatPortalSelectors } from '@/store/chat/slices/portal/selectors';
 
 import { NotebookDocument } from '../../../types';
 
@@ -21,7 +22,7 @@ const styles = createStaticStyles(({ css, cssVar }) => ({
     border: 1px solid ${cssVar.colorBorderSecondary};
     border-radius: 16px;
 
-    background: ${cssVar.colorBgElevated};
+    background: ${cssVar.colorBgContainer};
   `,
   content: css`
     padding-inline: 16px;
@@ -60,10 +61,20 @@ interface DocumentCardProps {
 
 const DocumentCard = memo<DocumentCardProps>(({ document }) => {
   const { t } = useTranslation('plugin');
-  const openDocument = useChatStore((s) => s.openDocument);
+  const [portalDocumentId, openDocument, closeDocument] = useChatStore((s) => [
+    chatPortalSelectors.portalDocumentId(s),
+    s.openDocument,
+    s.closeDocument,
+  ]);
 
-  const handleExpand = () => {
-    openDocument(document.id);
+  const isExpanded = portalDocumentId === document.id;
+
+  const handleToggle = () => {
+    if (isExpanded) {
+      closeDocument();
+    } else {
+      openDocument(document.id);
+    }
   };
 
   return (
@@ -82,7 +93,7 @@ const DocumentCard = memo<DocumentCardProps>(({ document }) => {
           />
           <ActionIcon
             icon={PencilLine}
-            onClick={handleExpand}
+            onClick={handleToggle}
             size={'small'}
             title={t('builtins.lobe-notebook.actions.edit')}
           />
@@ -95,16 +106,18 @@ const DocumentCard = memo<DocumentCardProps>(({ document }) => {
         </Markdown>
       </ScrollShadow>
 
-      {/* Floating expand button */}
+      {/* Floating expand/collapse button */}
       <Button
         className={styles.expandButton}
         color={'default'}
-        icon={<Maximize2 size={14} />}
-        onClick={handleExpand}
+        icon={isExpanded ? <Minimize2 size={14} /> : <Maximize2 size={14} />}
+        onClick={handleToggle}
         shape={'round'}
         variant={'outlined'}
       >
-        {t('builtins.lobe-notebook.actions.expand')}
+        {isExpanded
+          ? t('builtins.lobe-notebook.actions.collapse')
+          : t('builtins.lobe-notebook.actions.expand')}
       </Button>
     </Flexbox>
   );

package/packages/builtin-tool-notebook/src/client/Streaming/CreateDocument/index.tsx

@@ -20,7 +20,7 @@ const styles = createStaticStyles(({ css, cssVar }) => ({
     border: 1px solid ${cssVar.colorBorderSecondary};
     border-radius: 16px;
 
-    background: ${cssVar.colorBgElevated};
+    background: ${cssVar.colorBgContainer};
   `,
   header: css`
     padding-block: 10px;

package/packages/database/src/models/__tests__/agent.test.ts

@@ -155,6 +155,33 @@ describe('AgentModel', () => {
       expect(result).not.toBeNull();
       expect(result!.files).toHaveLength(0);
     });
+
+    it('should not return agent belonging to another user', async () => {
+      const agentId = 'test-agent-other-user';
+      // Create agent for user2
+      await serverDB.insert(agents).values({ id: agentId, userId: userId2 });
+
+      // Try to access with user1's model
+      const result = await agentModel.getAgentConfigById(agentId);
+
+      expect(result).toBeNull();
+    });
+
+    it('should not return knowledge from another user agent', async () => {
+      const agentId = 'test-agent-cross-user-knowledge';
+      // Create agent for user2 with knowledge
+      await serverDB.insert(agents).values({ id: agentId, userId: userId2 });
+      await serverDB
+        .insert(agentsKnowledgeBases)
+        .values({ agentId, knowledgeBaseId: 'kb2', userId: userId2 });
+      await serverDB.insert(agentsFiles).values({ agentId, fileId: '3', userId: userId2 });
+
+      // Try to access with user1's model
+      const result = await agentModel.getAgentConfigById(agentId);
+
+      // Should return null since user1 cannot access user2's agent
+      expect(result).toBeNull();
+    });
   });
 
   describe('getAgentConfig', () => {
@@ -197,15 +224,14 @@ describe('AgentModel', () => {
       expect(result).toBeNull();
     });
 
-    it('should find agent by ID even if it belongs to another user', async () => {
+    it('should not find agent by ID if it belongs to another user', async () => {
       const agentId = 'test-agent-cross-user';
       await serverDB.insert(agents).values({ id: agentId, userId: userId2 });
 
-      // ID lookup should work across users (ID is globally unique)
+      // ID lookup should not work across users for security
       const result = await agentModel.getAgentConfig(agentId);
 
-      expect(result).toBeDefined();
-      expect(result?.id).toBe(agentId);
+      expect(result).toBeNull();
     });
 
     it('should prefer ID match over slug match', async () => {
@@ -257,6 +283,67 @@ describe('AgentModel', () => {
 
       expect(result).toBeUndefined();
     });
+
+    it('should not return agent from another user session', async () => {
+      const agentId = 'test-agent-other-user-session';
+      const sessionId = 'test-session-other-user';
+      // Create agent and session for user2
+      await serverDB.insert(agents).values({ id: agentId, userId: userId2 });
+      await serverDB.insert(sessions).values({ id: sessionId, userId: userId2 });
+      await serverDB
+        .insert(agentsToSessions)
+        .values({ agentId, sessionId, userId: userId2 });
+
+      // Try to access with user1's model
+      const result = await agentModel.findBySessionId(sessionId);
+
+      expect(result).toBeUndefined();
+    });
+  });
+
+  describe('getAgentAssignedKnowledge', () => {
+    it('should return knowledge bases and files for the agent', async () => {
+      const agentId = 'test-agent-knowledge';
+      await serverDB.insert(agents).values({ id: agentId, userId });
+      await serverDB
+        .insert(agentsKnowledgeBases)
+        .values({ agentId, knowledgeBaseId: 'kb1', userId, enabled: true });
+      await serverDB.insert(agentsFiles).values({ agentId, fileId: '1', userId, enabled: true });
+
+      const result = await agentModel.getAgentAssignedKnowledge(agentId);
+
+      expect(result.knowledgeBases).toHaveLength(1);
+      expect(result.files).toHaveLength(1);
+    });
+
+    it('should not return knowledge from another user', async () => {
+      const agentId = 'test-agent-knowledge-other-user';
+      // Create agent with knowledge for user2
+      await serverDB.insert(agents).values({ id: agentId, userId: userId2 });
+      await serverDB
+        .insert(agentsKnowledgeBases)
+        .values({ agentId, knowledgeBaseId: 'kb2', userId: userId2, enabled: true });
+      await serverDB
+        .insert(agentsFiles)
+        .values({ agentId, fileId: '3', userId: userId2, enabled: true });
+
+      // Try to access with user1's model
+      const result = await agentModel.getAgentAssignedKnowledge(agentId);
+
+      // Should return empty arrays since user1 cannot access user2's knowledge
+      expect(result.knowledgeBases).toHaveLength(0);
+      expect(result.files).toHaveLength(0);
+    });
+
+    it('should handle empty knowledge bases and files', async () => {
+      const agentId = 'test-agent-no-knowledge';
+      await serverDB.insert(agents).values({ id: agentId, userId });
+
+      const result = await agentModel.getAgentAssignedKnowledge(agentId);
+
+      expect(result.knowledgeBases).toHaveLength(0);
+      expect(result.files).toHaveLength(0);
+    });
   });
 
   describe('createAgentKnowledgeBase', () => {

package/packages/database/src/models/agent.ts

@@ -28,7 +28,9 @@ export class AgentModel {
   }
 
   getAgentConfigById = async (id: string) => {
-    const agent = await this.db.query.agents.findFirst({ where: eq(agents.id, id) });
+    const agent = await this.db.query.agents.findFirst({
+      where: and(eq(agents.id, id), eq(agents.userId, this.userId)),
+    });
 
     if (!agent) return null;
 
@@ -76,9 +78,9 @@ export class AgentModel {
    */
   getAgentConfig = async (idOrSlug: string) => {
     const agent = await this.db.query.agents.findFirst({
-      where: or(
-        eq(agents.id, idOrSlug),
-        and(eq(agents.slug, idOrSlug), eq(agents.userId, this.userId)),
+      where: and(
+        eq(agents.userId, this.userId),
+        or(eq(agents.id, idOrSlug), eq(agents.slug, idOrSlug)),
       ),
     });
 
@@ -118,17 +120,20 @@ export class AgentModel {
 
   getAgentAssignedKnowledge = async (id: string) => {
     // Run both queries in parallel for better performance
+    // Include userId check to ensure user can only access their own agent's knowledge
     const [knowledgeBaseResult, fileResult] = await Promise.all([
       this.db
         .select({ enabled: agentsKnowledgeBases.enabled, knowledgeBases })
         .from(agentsKnowledgeBases)
-        .where(eq(agentsKnowledgeBases.agentId, id))
+        .where(
+          and(eq(agentsKnowledgeBases.agentId, id), eq(agentsKnowledgeBases.userId, this.userId)),
+        )
         .orderBy(desc(agentsKnowledgeBases.createdAt))
         .leftJoin(knowledgeBases, eq(knowledgeBases.id, agentsKnowledgeBases.knowledgeBaseId)),
       this.db
         .select({ enabled: agentsFiles.enabled, files })
         .from(agentsFiles)
-        .where(eq(agentsFiles.agentId, id))
+        .where(and(eq(agentsFiles.agentId, id), eq(agentsFiles.userId, this.userId)))
         .orderBy(desc(agentsFiles.createdAt))
         .leftJoin(files, eq(files.id, agentsFiles.fileId)),
     ]);
@@ -150,7 +155,10 @@ export class AgentModel {
    */
   findBySessionId = async (sessionId: string) => {
     const item = await this.db.query.agentsToSessions.findFirst({
-      where: eq(agentsToSessions.sessionId, sessionId),
+      where: and(
+        eq(agentsToSessions.sessionId, sessionId),
+        eq(agentsToSessions.userId, this.userId),
+      ),
     });
 
     if (!item) return;

package/packages/editor-runtime/src/EditorRuntime.ts

@@ -109,7 +109,7 @@ export class EditorRuntime {
     }
 
     // Set markdown content directly - the editor will convert it internally
-    editor.setDocument('markdown', markdown);
+    editor.setDocument('markdown', markdown, { keepId: true });
 
     // Get the resulting document to count nodes
     const jsonState = editor.getDocument('json') as any;

package/packages/editor-runtime/src/__tests__/EditorRuntime.real.test.ts

@@ -2,6 +2,7 @@ import {
   CommonPlugin,
   type IEditor,
   Kernel,
+  ListPlugin,
   LitexmlPlugin,
   MarkdownPlugin,
   moment,
@@ -10,6 +11,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest';
 
 import { EditorRuntime } from '../EditorRuntime';
 import editAllFixture from './fixtures/edit-all.json';
+import removeThenAddFixture from './fixtures/remove-then-add.json';
 import removeFixture from './fixtures/remove.json';
 
 describe('EditorRuntime - Real Cases', () => {
@@ -20,7 +22,7 @@ describe('EditorRuntime - Real Cases', () => {
 
   beforeEach(() => {
     editor = new Kernel();
-    editor.registerPlugins([CommonPlugin, MarkdownPlugin, LitexmlPlugin]);
+    editor.registerPlugins([CommonPlugin, MarkdownPlugin, ListPlugin, LitexmlPlugin]);
     editor.initNodeEditor();
 
     runtime = new EditorRuntime();
@@ -163,9 +165,6 @@ describe('EditorRuntime - Real Cases', () => {
 
       // Verify paragraphs were removed
       const xmlAfter = editor.getDocument('litexml') as unknown as string;
-      const paragraphsAfter = [...xmlAfter.matchAll(/<p id="([^"]+)"/g)];
-
-      expect(paragraphsAfter.length).toBe(initialCount - 7);
 
       // Verify the removed IDs are no longer present
       expect(xmlAfter).not.toContain('id="wps3"');
@@ -179,4 +178,66 @@ describe('EditorRuntime - Real Cases', () => {
       expect(xmlAfter).toMatchSnapshot();
     });
   });
+
+  describe('modifyNodes - remove then add', () => {
+    it('should remove 13 paragraphs then insert a list', async () => {
+      // Initialize editor with the JSON fixture
+      editor.setDocument('json', removeThenAddFixture);
+      await moment();
+
+      // First operation: remove 13 paragraphs
+      const removeResult = await runtime.modifyNodes({
+        operations: [
+          { action: 'remove', id: 'x4qr' },
+          { action: 'remove', id: 'xfvd' },
+          { action: 'remove', id: 'xqzz' },
+          { action: 'remove', id: 'zrby' },
+          { action: 'remove', id: '02gk' },
+          { action: 'remove', id: '0dl6' },
+          { action: 'remove', id: '0ops' },
+          { action: 'remove', id: '1rnx' },
+          { action: 'remove', id: '22sj' },
+          { action: 'remove', id: '2dx5' },
+          { action: 'remove', id: '3gva' },
+          { action: 'remove', id: '3rzw' },
+          { action: 'remove', id: '434i' },
+        ],
+      });
+
+      await moment();
+
+      // Verify all remove operations succeeded
+      expect(removeResult.successCount).toBe(13);
+      expect(removeResult.totalCount).toBe(13);
+      expect(removeResult.results.every((r) => r.success)).toBe(true);
+      expect(removeResult.results.every((r) => r.action === 'remove')).toBe(true);
+
+      // Verify the content was removed
+      const removed = editor.getDocument('litexml') as unknown as string;
+      expect(removed).toMatchSnapshot('remove 13 paragraphs');
+
+      // Second operation: insert a list after wtm5
+      const insertResult = await runtime.modifyNodes({
+        operations: [
+          {
+            action: 'insert',
+            afterId: 'wtm5',
+            litexml:
+              '<ul><li>西湖风景区：杭州的灵魂，世界文化遗产</li><li>灵隐寺：杭州最著名的佛教寺庙</li><li>西溪国家湿地公园：中国第一个国家湿地公园</li><li>宋城：以宋代文化为主题的大型主题公园</li></ul>',
+          },
+        ],
+      });
+      await moment();
+
+      // Verify insert operation succeeded
+      expect(insertResult.successCount).toBe(1);
+      expect(insertResult.totalCount).toBe(1);
+      expect(insertResult.results.every((r) => r.success)).toBe(true);
+      expect(insertResult.results.every((r) => r.action === 'insert')).toBe(true);
+
+      // Verify full output
+      const xmlAfter = editor.getDocument('litexml') as unknown as string;
+      expect(xmlAfter).toMatchSnapshot('insert new');
+    });
+  });
 });