@lobehub/chat 1.141.6 → 1.141.7

package/.github/PULL_REQUEST_TEMPLATE.md

@@ -12,10 +12,36 @@
 - [ ] 📝 docs
 - [ ] 🔨 chore
 
+#### 🔗 Related Issue
+
+<!-- Link to the issue that is fixed by this PR -->
+
+<!-- Example: Fixes #123, Closes #456, Related to #789 -->
+
 #### 🔀 Description of Change
 
 <!-- Thank you for your Pull Request. Please provide a description above. -->
 
+#### 🧪 How to Test
+
+<!-- Please describe how you tested your changes -->
+
+<!-- For AI features, please include test prompts or scenarios -->
+
+- [ ] Tested locally
+- [ ] Added/updated tests
+- [ ] No tests needed
+
+#### 📸 Screenshots / Videos
+
+<!-- If this PR includes UI changes, please provide screenshots or videos -->
+
+| Before | After |
+| ------ | ----- |
+| ...    | ...   |
+
 #### 📝 Additional Information
 
 <!-- Add any other context about the Pull Request here. -->
+
+<!-- Breaking changes? Migration guide? Performance impact? -->

package/.github/workflows/e2e.yml

@@ -35,18 +35,18 @@ jobs:
                   PORT: 3010
               run: bun run e2e
 
-            - name: Upload Playwright HTML report (on failure)
+            - name: Upload Cucumber HTML report (on failure)
               if: failure()
               uses: actions/upload-artifact@v4
               with:
-                  name: playwright-report
-                  path: playwright-report
+                  name: cucumber-report
+                  path: e2e/reports
                   if-no-files-found: ignore
 
-            - name: Upload Playwright traces (on failure)
+            - name: Upload screenshots (on failure)
               if: failure()
               uses: actions/upload-artifact@v4
               with:
-                  name: test-results
-                  path: test-results
+                  name: test-screenshots
+                  path: e2e/screenshots
                   if-no-files-found: ignore

package/CHANGELOG.md

@@ -2,6 +2,31 @@
 
 # Changelog
 
+### [Version 1.141.7](https://github.com/lobehub/lobe-chat/compare/v1.141.6...v1.141.7)
+
+<sup>Released on **2025-10-23**</sup>
+
+#### 💄 Styles
+
+- **misc**: Allow removal of `top_p` and similar request parameters.
+
+<br/>
+
+<details>
+<summary><kbd>Improvements and Fixes</kbd></summary>
+
+#### Styles
+
+- **misc**: Allow removal of `top_p` and similar request parameters, closes [#9498](https://github.com/lobehub/lobe-chat/issues/9498) ([4c313ce](https://github.com/lobehub/lobe-chat/commit/4c313ce))
+
+</details>
+
+<div align="right">
+
+[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)
+
+</div>
+
 ### [Version 1.141.6](https://github.com/lobehub/lobe-chat/compare/v1.141.5...v1.141.6)
 
 <sup>Released on **2025-10-22**</sup>

package/changelog/v1.json

@@ -1,4 +1,13 @@
 [
+  {
+    "children": {
+      "improvements": [
+        "Allow removal of top_p and similar request parameters."
+      ]
+    },
+    "date": "2025-10-23",
+    "version": "1.141.7"
+  },
   {
     "children": {},
     "date": "2025-10-22",

package/e2e/README.md

@@ -0,0 +1,143 @@
+# E2E Tests for LobeChat
+
+This directory contains end-to-end (E2E) tests for LobeChat using Cucumber (BDD) and Playwright.
+
+## Directory Structure
+
+````
+e2e/
+├── src/               # Source files
+│   ├── features/      # Gherkin feature files
+│   │   └── discover/  # Discover page tests
+│   ├── steps/         # Step definitions
+│   │   ├── common/    # Reusable step definitions
+│   │   └── discover/  # Discover-specific steps
+│   └── support/       # Test support files
+│       └── world.ts   # Custom World context
+├── reports/           # Test reports (generated)
+├── cucumber.config.js # Cucumber configuration
+├── tsconfig.json      # TypeScript configuration
+└── package.json       # Dependencies and scripts
+
+## Prerequisites
+
+- Node.js 20, 22, or >=24
+- Dev server running on `http://localhost:3010` (or set `BASE_URL` env var)
+
+## Installation
+
+Install dependencies:
+
+```bash
+cd e2e
+pnpm install
+````
+
+Install Playwright browsers:
+
+```bash
+npx playwright install chromium
+```
+
+## Running Tests
+
+Run all tests:
+
+```bash
+npm test
+```
+
+Run tests in headed mode (see browser):
+
+```bash
+npm run test:headed
+```
+
+Run only smoke tests:
+
+```bash
+npm run test:smoke
+```
+
+Run discover tests:
+
+```bash
+npm run test:discover
+```
+
+## Environment Variables
+
+- `BASE_URL`: Base URL for the application (default: `http://localhost:3010`)
+- `PORT`: Port number (default: `3010`)
+- `HEADLESS`: Run browser in headless mode (default: `true`, set to `false` to see browser)
+
+Example:
+
+```bash
+HEADLESS=false BASE_URL=http://localhost:3000 npm run test:smoke
+```
+
+## Writing Tests
+
+### Feature Files
+
+Feature files are written in Gherkin syntax and placed in the `src/features/` directory:
+
+```gherkin
+@discover @smoke
+Feature: Discover Smoke Tests
+  Critical path tests to ensure the discover module is functional
+
+  @DISCOVER-SMOKE-001 @P0
+  Scenario: Load discover assistant list page
+    Given I navigate to "/discover/assistant"
+    Then the page should load without errors
+    And I should see the page body
+    And I should see the search bar
+    And I should see assistant cards
+```
+
+### Step Definitions
+
+Step definitions are TypeScript files in the `src/steps/` directory that implement the steps from feature files:
+
+```typescript
+import { Given, Then } from '@cucumber/cucumber';
+import { expect } from '@playwright/test';
+
+import { CustomWorld } from '../../support/world';
+
+Given('I navigate to {string}', async function (this: CustomWorld, path: string) {
+  await this.page.goto(path);
+  await this.page.waitForLoadState('domcontentloaded');
+});
+```
+
+## Test Reports
+
+After running tests, HTML and JSON reports are generated in the `reports/` directory:
+
+- `reports/cucumber-report.html` - Human-readable HTML report
+- `reports/cucumber-report.json` - Machine-readable JSON report
+
+## Troubleshooting
+
+### Browser not found
+
+If you see errors about missing browser executables:
+
+```bash
+npx playwright install chromium
+```
+
+### Port already in use
+
+Make sure the dev server is running on the expected port (3010 by default), or set `PORT` or `BASE_URL` environment variable.
+
+### Test timeout
+
+Increase timeout in `cucumber.config.js` or `src/steps/hooks.ts`:
+
+```typescript
+setDefaultTimeout(120000); // 2 minutes
+```

package/e2e/cucumber.config.js

@@ -0,0 +1,20 @@
+/**
+ * @type {import('@cucumber/cucumber').IConfiguration}
+ */
+export default {
+  format: [
+    'progress-bar',
+    'html:reports/cucumber-report.html',
+    'json:reports/cucumber-report.json',
+  ],
+  formatOptions: {
+    snippetInterface: 'async-await',
+  },
+  parallel: process.env.CI ? 1 : 4,
+  paths: ['src/features/**/*.feature'],
+  publishQuiet: true,
+  require: ['src/steps/**/*.ts', 'src/support/**/*.ts'],
+  requireModule: ['tsx/cjs'],
+  retry: 0,
+  timeout: 120_000,
+};

package/e2e/package.json

@@ -0,0 +1,24 @@
+{
+  "name": "@lobechat/e2e-tests",
+  "version": "0.1.0",
+  "private": true,
+  "description": "E2E tests for LobeChat using Cucumber and Playwright",
+  "scripts": {
+    "test": "cucumber-js --config cucumber.config.js",
+    "test:discover": "cucumber-js --config cucumber.config.js src/features/discover/",
+    "test:headed": "HEADLESS=false cucumber-js --config cucumber.config.js",
+    "test:routes": "cucumber-js --config cucumber.config.js --tags '@routes'",
+    "test:routes:ci": "cucumber-js --config cucumber.config.js --tags '@routes and not @ci-skip'",
+    "test:smoke": "cucumber-js --config cucumber.config.js --tags '@smoke'"
+  },
+  "dependencies": {
+    "@cucumber/cucumber": "^12.2.0",
+    "@playwright/test": "^1.56.1",
+    "playwright": "^1.56.1"
+  },
+  "devDependencies": {
+    "@types/node": "^22.10.5",
+    "tsx": "^4.20.6",
+    "typescript": "^5.7.3"
+  }
+}

package/e2e/src/features/discover/smoke.feature

@@ -0,0 +1,11 @@
+@discover @smoke
+Feature: Discover Smoke Tests
+  Critical path tests to ensure the discover module is functional
+
+  @DISCOVER-SMOKE-001 @P0
+  Scenario: Load discover assistant list page
+    Given I navigate to "/discover/assistant"
+    Then the page should load without errors
+    And I should see the page body
+    And I should see the search bar
+    And I should see assistant cards

package/e2e/src/features/routes/core-routes.feature

@@ -0,0 +1,43 @@
+@routes @smoke
+Feature: Core Routes Accessibility
+  As a user
+  I want all core application routes to be accessible
+  So that I can navigate the application without errors
+
+  Background:
+    Given the application is running
+
+  @ROUTES-001 @P0
+  Scenario Outline: Access core routes without errors
+    When I navigate to "<route>"
+    Then the response status should be less than 400
+    And the page should load without errors
+    And I should see the page body
+    And the page title should not contain "error" or "not found"
+
+    Examples:
+      | route      |
+      | /          |
+      | /chat      |
+      | /discover  |
+      | /files     |
+      | /repos     |
+
+  @ROUTES-002 @P0
+  Scenario Outline: Access settings routes without errors
+    When I navigate to "/settings?active=<tab>"
+    Then the response status should be less than 400
+    And the page should load without errors
+    And I should see the page body
+    And the page title should not contain "error" or "not found"
+
+    Examples:
+      | tab          |
+      | about        |
+      | agent        |
+      | hotkey       |
+      | provider     |
+      | proxy        |
+      | storage      |
+      | system-agent |
+      | tts          |

package/e2e/src/steps/common/navigation.steps.ts

@@ -0,0 +1,36 @@
+import { Given, Then } from '@cucumber/cucumber';
+import { expect } from '@playwright/test';
+
+import { CustomWorld } from '../../support/world';
+
+// ============================================
+// Given Steps (Preconditions)
+// ============================================
+
+Given('I navigate to {string}', async function (this: CustomWorld, path: string) {
+  const response = await this.page.goto(path, { waitUntil: 'commit' });
+  this.testContext.lastResponse = response;
+  await this.page.waitForLoadState('domcontentloaded');
+});
+
+// ============================================
+// Then Steps (Assertions)
+// ============================================
+
+Then('the page should load without errors', async function (this: CustomWorld) {
+  // Check for no JavaScript errors
+  expect(this.testContext.jsErrors).toHaveLength(0);
+
+  // Check page didn't navigate to error page
+  const url = this.page.url();
+  expect(url).not.toMatch(/\/404|\/error|not-found/i);
+
+  // Check no error title
+  const title = await this.page.title();
+  expect(title).not.toMatch(/not found|error/i);
+});
+
+Then('I should see the page body', async function (this: CustomWorld) {
+  const body = this.page.locator('body');
+  await expect(body).toBeVisible();
+});

package/e2e/src/steps/discover/smoke.steps.ts

@@ -0,0 +1,34 @@
+import { Then } from '@cucumber/cucumber';
+import { expect } from '@playwright/test';
+
+import { CustomWorld } from '../../support/world';
+
+// ============================================
+// Then Steps (Assertions)
+// ============================================
+
+Then('I should see the search bar', async function (this: CustomWorld) {
+  // Wait for network to be idle to ensure Suspense components are loaded
+  await this.page.waitForLoadState('networkidle', { timeout: 120_000 });
+
+  // The SearchBar component from @lobehub/ui may not pass through data-testid
+  // Try to find the input element within the search component
+  const searchBar = this.page.locator('input[type="text"]').first();
+  await expect(searchBar).toBeVisible({ timeout: 120_000 });
+});
+
+Then('I should see assistant cards', async function (this: CustomWorld) {
+  // Wait for content to load
+  await this.page.waitForLoadState('networkidle', { timeout: 120_000 });
+
+  // After migrating to SPA (react-router), links use relative paths like /assistant/:id
+  // Look for assistant items by data-testid instead of href
+  const assistantItems = this.page.locator('[data-testid="assistant-item"]');
+
+  // Wait for at least one item to be visible
+  await expect(assistantItems.first()).toBeVisible({ timeout: 120_000 });
+
+  // Check we have multiple items
+  const count = await assistantItems.count();
+  expect(count).toBeGreaterThan(0);
+});

package/e2e/src/steps/hooks.ts

@@ -0,0 +1,69 @@
+import { After, AfterAll, Before, BeforeAll, Status, setDefaultTimeout } from '@cucumber/cucumber';
+
+import { startWebServer, stopWebServer } from '../support/webServer';
+import { CustomWorld } from '../support/world';
+
+// Set default timeout for all steps to 120 seconds
+setDefaultTimeout(120_000);
+
+BeforeAll({ timeout: 120_000 }, async function () {
+  console.log('🚀 Starting E2E test suite...');
+
+  const PORT = process.env.PORT ? Number(process.env.PORT) : 3010;
+  const BASE_URL = process.env.BASE_URL || `http://localhost:${PORT}`;
+
+  console.log(`Base URL: ${BASE_URL}`);
+
+  // Start web server if not using external BASE_URL
+  if (!process.env.BASE_URL) {
+    await startWebServer({
+      command: 'npm run dev',
+      port: PORT,
+      reuseExistingServer: !process.env.CI,
+    });
+  }
+});
+
+Before(async function (this: CustomWorld, { pickle }) {
+  await this.init();
+
+  const testId = pickle.tags.find((tag) => tag.name.startsWith('@DISCOVER-'));
+  console.log(`\n📝 Running: ${pickle.name}${testId ? ` (${testId.name.replace('@', '')})` : ''}`);
+});
+
+After(async function (this: CustomWorld, { pickle, result }) {
+  const testId = pickle.tags
+    .find((tag) => tag.name.startsWith('@DISCOVER-'))
+    ?.name.replace('@', '');
+
+  if (result?.status === Status.FAILED) {
+    const screenshot = await this.takeScreenshot(`${testId || 'failure'}-${Date.now()}`);
+    this.attach(screenshot, 'image/png');
+
+    const html = await this.page.content();
+    this.attach(html, 'text/html');
+
+    if (this.testContext.jsErrors.length > 0) {
+      const errors = this.testContext.jsErrors.map((e) => e.message).join('\n');
+      this.attach(`JavaScript Errors:\n${errors}`, 'text/plain');
+    }
+
+    console.log(`❌ Failed: ${pickle.name}`);
+    if (result.message) {
+      console.log(`   Error: ${result.message}`);
+    }
+  } else if (result?.status === Status.PASSED) {
+    console.log(`✅ Passed: ${pickle.name}`);
+  }
+
+  await this.cleanup();
+});
+
+AfterAll(async function () {
+  console.log('\n🏁 Test suite completed');
+
+  // Stop web server if we started it
+  if (!process.env.BASE_URL && process.env.CI) {
+    await stopWebServer();
+  }
+});

package/e2e/src/steps/routes/routes.steps.ts

@@ -0,0 +1,41 @@
+import { Given, Then } from '@cucumber/cucumber';
+import { expect } from '@playwright/test';
+
+import { CustomWorld } from '../../support/world';
+
+// ============================================
+// Given Steps (Preconditions)
+// ============================================
+
+Given('the application is running', async function (this: CustomWorld) {
+  // This is a placeholder step to indicate that the app should be running
+  // The actual server startup is handled outside the test (in CI or locally)
+  // We just verify we can reach the base URL
+  const response = await this.page.goto('/');
+  expect(response).toBeTruthy();
+  // Store the response for later assertions
+  this.testContext.lastResponse = response;
+});
+
+// ============================================
+// Then Steps (Assertions)
+// ============================================
+
+Then(
+  'the response status should be less than {int}',
+  async function (this: CustomWorld, maxStatus: number) {
+    const status = this.testContext.lastResponse?.status() ?? 0;
+    expect(status, `Expected status < ${maxStatus}, but got ${status}`).toBeLessThan(maxStatus);
+  },
+);
+
+Then(
+  'the page title should not contain {string} or {string}',
+  async function (this: CustomWorld, text1: string, text2: string) {
+    const title = await this.page.title();
+    const regex = new RegExp(`${text1}|${text2}`, 'i');
+    expect(title, `Page title "${title}" should not contain "${text1}" or "${text2}"`).not.toMatch(
+      regex,
+    );
+  },
+);

package/e2e/src/support/webServer.ts

@@ -0,0 +1,96 @@
+import { type ChildProcess, exec } from 'node:child_process';
+import { resolve } from 'node:path';
+
+let serverProcess: ChildProcess | null = null;
+let serverStartPromise: Promise<void> | null = null;
+
+interface WebServerOptions {
+  command: string;
+  env?: Record<string, string>;
+  port: number;
+  reuseExistingServer?: boolean;
+  timeout?: number;
+}
+
+async function isServerRunning(port: number): Promise<boolean> {
+  try {
+    const response = await fetch(`http://localhost:${port}/chat`, {
+      method: 'HEAD',
+    });
+    return response.ok;
+  } catch {
+    return false;
+  }
+}
+
+export async function startWebServer(options: WebServerOptions): Promise<void> {
+  const { command, port, timeout = 120_000, env = {}, reuseExistingServer = true } = options;
+
+  // If server is already being started by another worker, wait for it
+  if (serverStartPromise) {
+    console.log(`⏳ Waiting for server to start (started by another worker)...`);
+    return serverStartPromise;
+  }
+
+  // Check if server is already running
+  if (reuseExistingServer && (await isServerRunning(port))) {
+    console.log(`✅ Reusing existing server on port ${port}`);
+    return;
+  }
+
+  // Create a promise for the server startup and store it
+  serverStartPromise = (async () => {
+    console.log(`🚀 Starting web server: ${command}`);
+
+    // Get the project root directory (parent of e2e folder)
+    const projectRoot = resolve(__dirname, '../../..');
+
+    // Start the server process
+    serverProcess = exec(command, {
+      cwd: projectRoot,
+      env: {
+        ...process.env,
+        ENABLE_AUTH_PROTECTION: '0',
+        ENABLE_OIDC: '0',
+        NEXT_PUBLIC_ENABLE_CLERK_AUTH: '0',
+        NEXT_PUBLIC_ENABLE_NEXT_AUTH: '0',
+        NODE_OPTIONS: '--max-old-space-size=6144',
+        PORT: String(port),
+        ...env,
+      },
+    });
+
+    // Forward server output to console for debugging
+    serverProcess.stdout?.on('data', (data) => {
+      console.log(`[server] ${data}`);
+    });
+
+    serverProcess.stderr?.on('data', (data) => {
+      console.error(`[server] ${data}`);
+    });
+
+    // Wait for server to be ready
+    const startTime = Date.now();
+    while (!(await isServerRunning(port))) {
+      if (Date.now() - startTime > timeout) {
+        throw new Error(`Server failed to start within ${timeout}ms`);
+      }
+      await new Promise((resolve) => {
+        setTimeout(resolve, 1000);
+      });
+    }
+
+    console.log(`✅ Web server is ready on port ${port}`);
+  })();
+
+  return serverStartPromise;
+}
+
+export async function stopWebServer(): Promise<void> {
+  if (serverProcess) {
+    console.log('🛑 Stopping web server...');
+    serverProcess.kill();
+    serverProcess = null;
+    serverStartPromise = null;
+  }
+}