@lobb-js/core 0.19.0 → 0.20.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lobb-js/core",
   "license": "UNLICENSED",
-  "version": "0.19.0",
+  "version": "0.20.0",
   "type": "module",
   "publishConfig": {
     "access": "public"

package/src/config/ConfigManager.ts

@@ -58,7 +58,7 @@ export class ConfigManager {
           if (!this.config.collections[fieldValue.references.collection]) {
             throw new LobbError({
               code: "INTERNAL_SERVER_ERROR",
-              message: `Field (${collectionName}.${fieldName}) references collection (${fieldValue.references.collection}) which does not exist`,
+              message: `"${collectionName}.${fieldName}" references "${fieldValue.references.collection}" which is not defined in your collections.`,
             });
           }
           if (!this.config.relations) {

package/src/database/DatabaseSyncManager.ts

@@ -36,21 +36,6 @@ export class DatabaseSyncManager {
   ) {
     if (!dbSchemaDiff.length) return;
 
-    if (!forceSync) {
-      console.error(
-        "These are the differences between the config schema and the database schema",
-      );
-      console.error(
-        "You should add migrations to match the collection schema with the database schema",
-      );
-      console.error(dbSchemaDiff);
-      throw new LobbError({
-        code: "INTERNAL_SERVER_ERROR",
-        message:
-          "The schema of the configuration collection does not align with the actual schema of the connected database.",
-      });
-    }
-
     // just-diff may produce deep paths (length > 3) for sub-field changes within
     // an existing index (e.g. renaming a column the index covers). Convert those
     // into explicit drop+recreate (replace) ops, deduplicating by index name.
@@ -84,6 +69,8 @@ export class DatabaseSyncManager {
     };
     normalizedDiff.sort((a, b) => opOrder(a) - opOrder(b));
 
+    await this.assertNoDataLoss(normalizedDiff, forceSync);
+
     for (let index = 0; index < normalizedDiff.length; index++) {
       const change = normalizedDiff[index];
       if (change.path.length === 1 && change.op === "add") {
@@ -152,6 +139,59 @@ export class DatabaseSyncManager {
     }
   }
 
+  private async assertNoDataLoss(
+    diff: Array<{ op: string; path: (string | number)[]; value: unknown }>,
+    forceSync: boolean,
+  ) {
+    if (forceSync) return;
+    const destructiveOps = diff.filter(
+      (change) =>
+        (change.path.length === 1 && change.op === "remove") ||
+        (change.path[1] === "fields" && change.op === "remove"),
+    );
+
+    if (destructiveOps.length === 0) return;
+
+    const blocked: string[] = [];
+
+    for (const change of destructiveOps) {
+      const collectionName = change.path[0] as string;
+
+      if (change.path.length === 1 && change.op === "remove") {
+        const { meta } = await this.dbDriver.findAll(collectionName, { limit: 1, offset: 0, fields: "id" });
+        if (meta.totalCount > 0) {
+          blocked.push(
+            `Table "${collectionName}" has ${meta.totalCount} row(s) and cannot be dropped automatically. Write a migration to handle the data first.`,
+          );
+        }
+      } else if (change.path[1] === "fields" && change.op === "remove") {
+        const fieldName = change.path[2] as string;
+        const { meta } = await this.dbDriver.findAll(collectionName, {
+          limit: 1,
+          offset: 0,
+          fields: "id",
+          filter: { [fieldName]: { $ne: null } },
+        });
+        if (meta.totalCount > 0) {
+          blocked.push(
+            `Column "${collectionName}.${fieldName}" has ${meta.totalCount} non-null row(s) and cannot be dropped automatically. Write a migration to handle the data first.`,
+          );
+        }
+      }
+    }
+
+    if (blocked.length > 0) {
+      console.error("Blocked destructive schema changes detected:");
+      for (const msg of blocked) console.error(` • ${msg}`);
+      throw new LobbError({
+        code: "INTERNAL_SERVER_ERROR",
+        message:
+          "Refusing to apply destructive schema changes on tables/columns that contain data. " +
+          "Write explicit migrations to handle the data, then re-run.",
+      });
+    }
+  }
+
   private async getDbDifferences(specificColleciton?: string) {
     let dbSchema = await this.dbDriver.getDbSchema();
     let configDbSchema = Lobb.instance.configManager.getDbSchema();