@loadsmart/loadsmart-ui 5.8.0 → 5.8.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@loadsmart/loadsmart-ui",
-  "version": "5.8.0",
+  "version": "5.8.1",
   "description": "Miranda UI, a React UI library",
   "main": "dist",
   "files": [

package/src/components/Select/Select.test.tsx

@@ -12,6 +12,7 @@ import selectEvent from '../../testing/SelectEvent'
 import type { SelectProps, Option, GenericOption } from './Select.types'
 import Select from './Select'
 import userEvent from '@testing-library/user-event'
+import type { Selectable } from 'hooks/useSelectable'
 
 const {
   Playground,
@@ -854,6 +855,32 @@ describe('Select', () => {
         expect(options[options.length - 1]).toHaveTextContent(/add ""/i)
       }
     )
+
+    it.each([[{ multiple: false }], [{ multiple: true }]])(
+      'keep creatable option on the list even when any value is selected - %s',
+      async (args) => {
+        const CreatableOption = () => {
+          return (
+            <Select.CreatableOption data-testid="custom-creatable">Add item</Select.CreatableOption>
+          )
+        }
+
+        const value = generator.pickone(FRUITS) as Selectable
+
+        setup({
+          ...args,
+          isValidNewOption: true,
+          createOptionPosition: 'first',
+          value,
+          components: {
+            CreatableOption,
+          },
+        })
+
+        await expandSelect(true)
+        expect(await screen.findByText(/add item/i)).toBeVisible()
+      }
+    )
   })
 
   describe('Creatable Async', () => {

package/src/components/Select/useSelect.ts

@@ -432,18 +432,13 @@ function useSelect(props: SelectProps): useSelectReturn {
 
       function getIsValidNewOption() {
         if (isFunction(isValidNewOption)) {
-          return isValidNewOption(query)
+          return isValidNewOption(query) && !isQueryEqualAnOption()
         }
 
         return isValidNewOption
       }
 
-      return (
-        isFunction(onCreate) &&
-        getIsValidNewOption() &&
-        options.status === 'queried' &&
-        !isQueryEqualAnOption()
-      )
+      return isFunction(onCreate) && options.status === 'queried' && getIsValidNewOption()
     },
     [getSelectableOption, isValidNewOption, onCreate, options, query, selectable.selected]
   )