@loadsmart/loadsmart-ui 5.3.0 → 5.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@loadsmart/loadsmart-ui",
-  "version": "5.3.0",
+  "version": "5.4.0",
   "description": "Miranda UI, a React UI library",
   "main": "dist",
   "files": [
@@ -103,7 +103,6 @@
     "@testing-library/react-hooks": "5.1.2",
     "@testing-library/user-event": "13.1.9",
     "@types/chance": "1.1.1",
-    "@types/enzyme": "3.10.8",
     "@types/jest": "26.0.23",
     "@types/lodash.debounce": "4.0.6",
     "@types/lodash.flatten": "4.4.6",
@@ -117,7 +116,6 @@
     "@types/styled-components": "5.1.9",
     "@typescript-eslint/eslint-plugin": "4.22.1",
     "@typescript-eslint/parser": "4.22.1",
-    "@wojtekmaj/enzyme-adapter-react-17": "0.6.1",
     "@zerollup/ts-transform-paths": "1.7.18",
     "autoprefixer": "9",
     "babel-jest": "26.6.3",
@@ -130,7 +128,6 @@
     "commitizen": "4.2.4",
     "cross-env": "7.0.3",
     "cz-conventional-changelog": "3.3.0",
-    "enzyme": "3.11.0",
     "eslint": "7.26.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-jest-dom": "3.8.1",

package/src/components/Breadcrumbs/Breadbrumbs.test.tsx

@@ -14,7 +14,7 @@ describe('<Breadcrumbs />', () => {
 
     setup({ entries })
 
-    expect(screen.getByTestId('breadcrumbs')).not.toBeEmptyDOMElement()
+    expect(screen.getByRole('list')).not.toBeEmptyDOMElement()
 
     for (let i = 0; i < entries.length; i++) {
       screen.getByText(entries[i].label)
@@ -26,7 +26,7 @@ describe('<Breadcrumbs />', () => {
 
     setup({ entries })
 
-    expect(screen.getByTestId('breadcrumbs')).toBeEmptyDOMElement()
+    expect(screen.getByRole('list')).toBeEmptyDOMElement()
   })
 
   it('renders active breadcrumb correctly', () => {
@@ -36,13 +36,15 @@ describe('<Breadcrumbs />', () => {
       ({ index }) => ({
         label: generator.word(),
         active: index === activeIndex,
+        url: '/',
       }),
       9
     )
 
     setup({ entries })
 
-    expect(screen.getAllByTestId('breadcrumb')[activeIndex]).toHaveClass('is-active')
+    expect(screen.getAllByRole('listitem')[activeIndex]).toHaveClass('is-active')
+    expect(screen.getAllByRole('link')[activeIndex]).toHaveAttribute('aria-current', 'page')
   })
 
   it('render non-url and non-onClick breadcrumb correctly', () => {
@@ -114,6 +116,10 @@ describe('<Breadcrumbs />', () => {
 
     setup({ entries, onBack: jest.fn() })
 
-    expect(screen.getByTestId('breadcrumbs-back')).toBeInTheDocument()
+    expect(
+      screen.getByRole('button', {
+        name: 'Back to previous page',
+      })
+    ).toBeInTheDocument()
   })
 })

package/src/components/Breadcrumbs/Breadcrumb.tsx

@@ -47,22 +47,30 @@ const StyledLi = styled.li<BreadcrumbProps>`
     position: absolute;
     left: calc(100% + 14px);
 
-    font-weight: normal;
+    font-weight: ${token('font-weight-bold')};
     font-size: ${token('breadcrumbs-font-size')};
 
+    line-height: ${token('breadcrumbs-font-height')};
+
     content: '/';
   }
 `
 
 function getWrappedLabel(props: Partial<BreadcrumbProps>) {
-  const { url, label, onClick, ...rest } = props
+  const { url, label, onClick, active, ...rest } = props
 
   if (isNil(url) && !onClick) {
     return label
   }
 
   return (
-    <StyledLink href={url} target="_self" onClick={onClick} {...rest}>
+    <StyledLink
+      href={url}
+      target="_self"
+      onClick={onClick}
+      {...(active && {'aria-current': 'page'})}
+      {...rest}
+    >
       {label}
     </StyledLink>
   )
@@ -76,7 +84,7 @@ function Breadcrumb({ active, label, url, ...rest }: BreadcrumbProps): JSX.Eleme
       data-testid="breadcrumb"
       active={active}
     >
-      {getWrappedLabel({ label, url, ...rest })}
+      {getWrappedLabel({ label, url, active, ...rest })}
     </StyledLi>
   )
 }

package/src/components/Breadcrumbs/Breadcrumbs.tsx

@@ -12,12 +12,12 @@ export interface BreadcrumbsProps {
   onBack?: (e: MouseEvent<HTMLButtonElement>) => void
 }
 
-const StyledWrapper = styled.div`
+const StyledWrapper = styled.nav`
   display: flex;
   flex-direction: row;
 `
 
-const StyledUl = styled.ul`
+const StyledOl = styled.ol`
   display: flex;
   flex-direction: row;
   margin: 0;
@@ -31,18 +31,23 @@ const StyledBackButton = styled(BackButton)`
   margin: 0 ${token('space-m')} 0 0;
 `
 
-function Breadcrumbs({ entries, onBack, disabled, ...others }: BreadcrumbsProps): JSX.Element {
+function Breadcrumbs({ entries = [], onBack, disabled, ...others }: BreadcrumbsProps): JSX.Element {
   return (
-    <StyledWrapper {...others}>
+    <StyledWrapper aria-label="Breadcrumb" {...others}>
       {onBack && (
-        <StyledBackButton data-testid="breadcrumbs-back" onClick={onBack} disabled={disabled} />
+        <StyledBackButton
+          data-testid="breadcrumbs-back"
+          onClick={onBack}
+          disabled={disabled}
+          aria-label="Back to previous page"
+        />
       )}
 
-      <StyledUl data-testid="breadcrumbs">
-        {(entries || []).map((entry: BreadcrumbProps) => {
+      <StyledOl data-testid="breadcrumbs">
+        {entries.map((entry: BreadcrumbProps) => {
           return <Breadcrumb key={entry.label} {...entry} />
         })}
-      </StyledUl>
+      </StyledOl>
     </StyledWrapper>
   )
 }

package/src/components/Card/Card.tsx

@@ -60,11 +60,6 @@ const Container = styled.div<{ flagged: boolean }>`
   flex: 1;
   flex-direction: column;
 
-  margin-left: ${conditional({
-    'space-s': whenProps({ flagged: true }),
-    'space-none': whenProps({ flagged: false }),
-  })};
-
   line-height: ${token('card-font-height')};
 
   ${({ flagged }) =>

package/src/components/TablePagination/TablePagination.stories.tsx

@@ -15,6 +15,11 @@ export const Playground: Story<TablePaginationProps> = (args: TablePaginationPro
   const [page, setPage] = useState(args.page)
   const [rowsPerPage, setRowsPerPage] = useState(args.rowsPerPage)
 
+  const handleRowsPerPageChange = (rowsPerPage: number) => {
+    setRowsPerPage(rowsPerPage)
+    setPage(0)
+  }
+
   return (
     <Layout.Group>
       <TablePagination
@@ -22,7 +27,7 @@ export const Playground: Story<TablePaginationProps> = (args: TablePaginationPro
         onPageChange={(page) => setPage(page)}
         page={page}
         rowsPerPage={rowsPerPage}
-        onRowsPerPageChange={setRowsPerPage}
+        onRowsPerPageChange={handleRowsPerPageChange}
       />
     </Layout.Group>
   )

package/src/components/TablePagination/TablePagination.test.tsx

@@ -70,7 +70,6 @@ describe('TablePagination', () => {
     userEvent.click(screen.getByText(/50 per page/i))
 
     expect(onRowsPerPageChange).toHaveBeenLastCalledWith(50)
-    expect(onPageChange).toHaveBeenLastCalledWith(0)
   })
 
   it('hides some actions for the compact variant', () => {

package/src/components/TablePagination/TablePagination.tsx

@@ -20,17 +20,12 @@ function TablePagination(props: TablePaginationProps): JSX.Element {
     ...rest
   } = props
 
-  const handleRowsPerPageChange = (selectedOption: number) => {
-    onRowsPerPageChange(selectedOption)
-    onPageChange(0)
-  }
-
   return (
     <Layout.Group space="xl" align="center" justify="space-between" {...rest}>
       <RowsPerPage
         page={page}
         count={count}
-        onRowsPerPageChange={handleRowsPerPageChange}
+        onRowsPerPageChange={onRowsPerPageChange}
         rowsPerPage={rowsPerPage}
         rowsPerPageOptions={rowsPerPageOptions}
         labelRowsPerPage={labelRowsPerPage}

package/src/components/TablePagination/TablePagination.types.ts

@@ -21,6 +21,9 @@ export interface TablePaginationProps extends GroupProps {
   onPageChange: (page: number) => void
   /**
    * Callback fired when the number of rows per page is changed.
+   *
+   * Note: Resetting the page to zero after the number of rows per page is changed isn't part of
+   * the component and has to be implemented where it's necessary
    */
   onRowsPerPageChange: (rowsPerPage: number) => void
   /**