@loaders.gl/tile-converter 4.0.0-alpha.24 → 4.0.0-alpha.25

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@loaders.gl/tile-converter",
-  "version": "4.0.0-alpha.24",
+  "version": "4.0.0-alpha.25",
   "description": "Converter",
   "license": "MIT",
   "publishConfig": {
@@ -45,18 +45,18 @@
     "build-i3s-server-bundle": "esbuild src/i3s-server/bin/www.ts --outfile=dist/esm/i3s-server/bin/i3s-server.min.js --platform=node --target=esnext,node14 --external:join-images --minify --bundle --define:__VERSION__=\\\"$npm_package_version\\\""
   },
   "dependencies": {
-    "@loaders.gl/3d-tiles": "4.0.0-alpha.24",
-    "@loaders.gl/crypto": "4.0.0-alpha.24",
-    "@loaders.gl/draco": "4.0.0-alpha.24",
-    "@loaders.gl/gltf": "4.0.0-alpha.24",
-    "@loaders.gl/i3s": "4.0.0-alpha.24",
-    "@loaders.gl/images": "4.0.0-alpha.24",
-    "@loaders.gl/loader-utils": "4.0.0-alpha.24",
-    "@loaders.gl/polyfills": "4.0.0-alpha.24",
-    "@loaders.gl/textures": "4.0.0-alpha.24",
-    "@loaders.gl/tiles": "4.0.0-alpha.24",
-    "@loaders.gl/worker-utils": "4.0.0-alpha.24",
-    "@loaders.gl/zip": "4.0.0-alpha.24",
+    "@loaders.gl/3d-tiles": "4.0.0-alpha.25",
+    "@loaders.gl/crypto": "4.0.0-alpha.25",
+    "@loaders.gl/draco": "4.0.0-alpha.25",
+    "@loaders.gl/gltf": "4.0.0-alpha.25",
+    "@loaders.gl/i3s": "4.0.0-alpha.25",
+    "@loaders.gl/images": "4.0.0-alpha.25",
+    "@loaders.gl/loader-utils": "4.0.0-alpha.25",
+    "@loaders.gl/polyfills": "4.0.0-alpha.25",
+    "@loaders.gl/textures": "4.0.0-alpha.25",
+    "@loaders.gl/tiles": "4.0.0-alpha.25",
+    "@loaders.gl/worker-utils": "4.0.0-alpha.25",
+    "@loaders.gl/zip": "4.0.0-alpha.25",
     "@math.gl/core": "^3.5.1",
     "@math.gl/culling": "^3.5.1",
     "@math.gl/geoid": "^3.5.1",
@@ -80,7 +80,7 @@
     "join-images": "^1.1.3",
     "sharp": "^0.31.3"
   },
-  "gitHead": "97a8990595c132fb14e3445a8768d9f4cb98ff05",
+  "gitHead": "40135f391b869388dbbcd615bbe51178d0c370be",
   "devDependencies": {
     "@types/express": "^4.17.17",
     "@types/node": "^20.4.2"

package/src/3d-tiles-converter/helpers/b3dm-converter.ts

@@ -33,7 +33,7 @@ export default class B3dmConverter {
     i3sAttributesData: I3SAttributesData,
     featureAttributes: any = null
   ): Promise<ArrayBuffer> {
-    const gltf = await this.buildGltf(i3sAttributesData, featureAttributes);
+    const gltf = await this.buildGLTF(i3sAttributesData, featureAttributes);
     const b3dm = encodeSync(
       {
         gltfEncoded: new Uint8Array(gltf),
@@ -51,7 +51,7 @@ export default class B3dmConverter {
    * @param i3sTile - Tile3D instance for I3S node
    * @returns - encoded glb content
    */
-  async buildGltf(
+  async buildGLTF(
     i3sAttributesData: I3SAttributesData,
     featureAttributes: any
   ): Promise<ArrayBuffer> {
@@ -59,8 +59,8 @@ export default class B3dmConverter {
     const {material, attributes, indices: originalIndices, modelMatrix} = tileContent;
     const gltfBuilder = new GLTFScenegraph();
 
-    const textureIndex = await this._addI3sTextureToGltf(tileContent, textureFormat, gltfBuilder);
-    const pbrMaterialInfo = this._convertI3sMaterialToGltfMaterial(material, textureIndex);
+    const textureIndex = await this._addI3sTextureToGLTF(tileContent, textureFormat, gltfBuilder);
+    const pbrMaterialInfo = this._convertI3sMaterialToGLTFMaterial(material, textureIndex);
     const materialIndex = gltfBuilder.addMaterial(pbrMaterialInfo);
 
     const positions = attributes.positions;
@@ -115,7 +115,7 @@ export default class B3dmConverter {
    * @param {GLTFScenegraph} gltfBuilder - gltfScenegraph instance to construct GLTF
    * @returns {Promise<number | null>} - GLTF texture index
    */
-  async _addI3sTextureToGltf(tileContent, textureFormat, gltfBuilder) {
+  async _addI3sTextureToGLTF(tileContent, textureFormat, gltfBuilder) {
     const {texture, material, attributes} = tileContent;
     let textureIndex = null;
     let selectedTexture = texture;
@@ -222,7 +222,7 @@ export default class B3dmConverter {
    * @param {number | null} textureIndex - texture index in GLTF
    * @returns {object} GLTF material
    */
-  _convertI3sMaterialToGltfMaterial(material, textureIndex) {
+  _convertI3sMaterialToGLTFMaterial(material, textureIndex) {
     const isTextureIndexExists = textureIndex !== null;
 
     if (!material) {
@@ -248,7 +248,7 @@ export default class B3dmConverter {
     }
 
     if (textureIndex !== null) {
-      material = this._setGltfTexture(material, textureIndex);
+      material = this._setGLTFTexture(material, textureIndex);
     }
 
     return material;
@@ -260,7 +260,7 @@ export default class B3dmConverter {
    * @param {number} textureIndex - texture index in GLTF
    * @returns {void}
    */
-  _setGltfTexture(materialDefinition, textureIndex) {
+  _setGLTFTexture(materialDefinition, textureIndex) {
     const material = {
       ...materialDefinition,
       pbrMetallicRoughness: {...materialDefinition.pbrMetallicRoughness}

package/src/i3s-converter/helpers/batch-ids-extensions.ts

@@ -3,8 +3,7 @@ import type {NumericArray} from '@loaders.gl/loader-utils';
 import type {
   GLTF_EXT_feature_metadata_FeatureIdTexture,
   GLTF_EXT_feature_metadata_GLTF,
-  GLTF_EXT_feature_metadata_Primitive,
-  GLTF_EXT_structural_metadata
+  GLTF_EXT_feature_metadata_Primitive
 } from '@loaders.gl/gltf';
 
 import type {GLTF_EXT_mesh_features} from '@loaders.gl/gltf';
@@ -12,11 +11,14 @@ import type {GLTF_EXT_mesh_features} from '@loaders.gl/gltf';
 import {TypedArray} from '@math.gl/core';
 import {TextureImageProperties} from '../types';
 import {emod} from '@loaders.gl/math';
-import {EXT_STRUCTURAL_METADATA, EXT_MESH_FEATURES, EXT_FEATURE_METADATA} from '@loaders.gl/gltf';
+import {EXT_MESH_FEATURES, EXT_FEATURE_METADATA} from '@loaders.gl/gltf';
 import {Tiles3DTileContent} from '@loaders.gl/3d-tiles';
 
 /**
- * Get featureTexture by metadataClass
+ * Get featureTexture by a metadata class.
+ * Metadata classes come from a structural metadata extesion (EXT_feature_metadata or EXT_structural_metadata).
+ * The glTF might contain multiple texel-level metadata textures related to different classes. Having only one metadata class
+ * selected to convert to I3S, we have to pick only one texture to convert to per-vertex property.
  * @param tileContent - 3d tile content
  * @param metadataClass - user selected feature metadata class name
  * @returns featureTexture key
@@ -72,12 +74,6 @@ export function handleBatchIdsExtensions(
         );
       case EXT_MESH_FEATURES:
         return handleExtMeshFeaturesExtension(attributes, extensionData as GLTF_EXT_mesh_features);
-      case EXT_STRUCTURAL_METADATA:
-        return handleExtStructuralMetadataExtension(
-          attributes,
-          extensionData as GLTF_EXT_structural_metadata
-        );
-
       default:
         return [];
     }
@@ -86,23 +82,6 @@ export function handleBatchIdsExtensions(
   return [];
 }
 
-function handleExtStructuralMetadataExtension(
-  attributes: {
-    [key: string]: GLTFAccessorPostprocessed;
-  },
-  extStructuralMetadata: GLTF_EXT_structural_metadata
-): NumericArray {
-  // Take only first extension object to get batchIds attribute name.
-  const dataAttributeNames = extStructuralMetadata?.dataAttributeNames;
-  if (dataAttributeNames?.length) {
-    // Let's use the first element of the array
-    // TODO: What to do with others if any?
-    const batchIdsAttribute = attributes[dataAttributeNames[0]];
-    return batchIdsAttribute.value;
-  }
-  return [];
-}
-
 /**
  * Getting batchIds from EXT_mesh_features extensions.
  * @param attributes - gltf accessors
@@ -115,19 +94,19 @@ function handleExtMeshFeaturesExtension(
   },
   extMeshFeatures: GLTF_EXT_mesh_features
 ): NumericArray {
-  const dataAttributeNames = extMeshFeatures?.dataAttributeNames;
-  if (dataAttributeNames?.length) {
-    // Let's use the first element of the array
-    // TODO: What to do with others if any?
-    const batchIdsAttribute = attributes[dataAttributeNames[0]];
-    return batchIdsAttribute.value;
+  for (let ids of extMeshFeatures.featureIds) {
+    if (typeof ids.propertyTable !== 'undefined') {
+      // propertyTable is an index that can be 0
+      // return the first featureID set that corresponts to property table.
+      return ids.data as NumericArray;
+    }
   }
   return [];
 }
 
 /**
  * Get batchIds from EXT_feature_metadata extension.
- * Docs - https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_feature_metadata
+ * @see - https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_feature_metadata
  * @param attributes - glTF attributes
  * @param extFeatureMetadata - primitive-level EXT_FEATURE_METADATA extension data
  * @param textures - texture images
@@ -182,7 +161,7 @@ function handleExtFeatureMetadataExtension(
 
 /**
  * Generates implicit feature ids
- * Spec - https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_feature_metadata#implicit-feature-ids
+ * @see - https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_feature_metadata#implicit-feature-ids
  * @param featuresCount
  * @param constant
  * @param devisor

package/src/i3s-converter/helpers/geometry-converter.ts

@@ -1,14 +1,13 @@
 import type {FeatureTableJson, Tiles3DTileContent} from '@loaders.gl/3d-tiles';
 import type {
-  GLTF_EXT_mesh_features,
-  GLTF_EXT_structural_metadata,
   GLTFAccessorPostprocessed,
   GLTFMaterialPostprocessed,
   GLTFNodePostprocessed,
   GLTFMeshPrimitivePostprocessed,
   GLTFMeshPostprocessed,
   GLTFTexturePostprocessed,
-  GLTF_EXT_feature_metadata_GLTF
+  GLTF_EXT_feature_metadata_GLTF,
+  GLTF_EXT_structural_metadata_GLTF
 } from '@loaders.gl/gltf';
 
 import {Vector3, Matrix4, Vector4} from '@math.gl/core';
@@ -50,7 +49,12 @@ import type {GLTFAttributesData, TextureImageProperties, TypedArrayConstructor}
 import {generateSyntheticIndices} from '../../lib/utils/geometry-utils';
 import {BoundingSphere, OrientedBoundingBox} from '@math.gl/culling';
 
-import {EXT_MESH_FEATURES, EXT_FEATURE_METADATA, EXT_STRUCTURAL_METADATA} from '@loaders.gl/gltf';
+import {
+  EXT_FEATURE_METADATA,
+  EXT_STRUCTURAL_METADATA,
+  getPropertyTableFromExtFeatureMetadata,
+  getPropertyTableFromExtStructuralMetadata
+} from '@loaders.gl/gltf';
 
 // Spec - https://github.com/Esri/i3s-spec/blob/master/docs/1.7/pbrMetallicRoughness.cmn.md
 const DEFAULT_ROUGHNESS_FACTOR = 1;
@@ -385,7 +389,7 @@ export async function convertAttributes(
 }
 
 /**
- * Gltf has hierarchical structure of nodes. This function converts nodes starting from those which are in gltf scene object.
+ * glTF has hierarchical structure of nodes. This function converts nodes starting from those which are in gltf scene object.
  *   The goal is applying tranformation matrix for all children. Functions "convertNodes" and "convertNode" work together recursively.
  * @param nodes - gltf nodes array
  * @param images - gltf images array
@@ -1053,7 +1057,7 @@ function convertMaterial(sourceMaterial: GLTFMaterialPostprocessed): I3SMaterial
 
 /**
  * Converts from `alphaMode` material property from GLTF to I3S format
- * @param gltfAlphaMode Gltf material `alphaMode` property
+ * @param gltfAlphaMode glTF material `alphaMode` property
  * @returns I3SMaterialDefinition.alphaMode property
  */
 function convertAlphaMode(
@@ -1606,7 +1610,7 @@ function generateFeatureIndexAttribute(
  * For example it can be batchTable for b3dm files or property table in gLTF extension.
  * @param tileContent - 3DTiles tile content
  * @param metadataClass - user selected feature metadata class name
- * @return batch table from b3dm / feature properties from EXT_FEATURE_METADATA, EXT_MESH_FEATURES or EXT_STRUCTURAL_METADATA
+ * @return batch table from b3dm / feature properties from EXT_FEATURE_METADATA or EXT_STRUCTURAL_METADATA.
  */
 export function getPropertyTable(
   tileContent: Tiles3DTileContent | null,
@@ -1616,7 +1620,7 @@ export function getPropertyTable(
     return null;
   }
   let propertyTable: FeatureTableJson | null;
-  const batchTableJson = tileContent?.batchTableJson;
+  const batchTableJson = tileContent.batchTableJson;
 
   if (batchTableJson) {
     return batchTableJson;
@@ -1625,16 +1629,9 @@ export function getPropertyTable(
   const {extensionName, extension} = getPropertyTableExtension(tileContent);
 
   switch (extensionName) {
-    case EXT_MESH_FEATURES: {
-      propertyTable = getPropertyTableFromExtMeshFeatures(
-        extension as GLTF_EXT_mesh_features,
-        metadataClass
-      );
-      return propertyTable;
-    }
     case EXT_STRUCTURAL_METADATA: {
       propertyTable = getPropertyTableFromExtStructuralMetadata(
-        extension as GLTF_EXT_structural_metadata,
+        extension as GLTF_EXT_structural_metadata_GLTF,
         metadataClass
       );
       return propertyTable;
@@ -1657,18 +1654,9 @@ export function getPropertyTable(
  */
 function getPropertyTableExtension(tileContent: Tiles3DTileContent): {
   extensionName: null | string;
-  extension:
-    | string
-    | GLTF_EXT_feature_metadata_GLTF
-    | GLTF_EXT_structural_metadata
-    | GLTF_EXT_mesh_features
-    | null;
+  extension: string | GLTF_EXT_feature_metadata_GLTF | GLTF_EXT_structural_metadata_GLTF | null;
 } {
-  const extensionsWithPropertyTables = [
-    EXT_FEATURE_METADATA,
-    EXT_STRUCTURAL_METADATA,
-    EXT_MESH_FEATURES
-  ];
+  const extensionsWithPropertyTables = [EXT_FEATURE_METADATA, EXT_STRUCTURAL_METADATA];
   const extensionsUsed = tileContent?.gltf?.extensionsUsed;
 
   if (!extensionsUsed) {
@@ -1679,6 +1667,12 @@ function getPropertyTableExtension(tileContent: Tiles3DTileContent): {
   for (const extensionItem of tileContent?.gltf?.extensionsUsed || []) {
     if (extensionsWithPropertyTables.includes(extensionItem)) {
       extensionName = extensionItem;
+      /*
+        It returns the first extension containing the property table.
+        We assume that there can be only one extension containing the property table:
+        either EXT_FEATURE_METADATA, which is a depricated extension,
+        or EXT_STRUCTURAL_METADATA.
+      */
       break;
     }
   }
@@ -1689,147 +1683,8 @@ function getPropertyTableExtension(tileContent: Tiles3DTileContent): {
 
   const extension = tileContent?.gltf?.extensions?.[extensionName] as
     | string // EXT_mesh_features doesn't have global metadata
-    | GLTF_EXT_feature_metadata_GLTF;
+    | GLTF_EXT_feature_metadata_GLTF
+    | GLTF_EXT_structural_metadata_GLTF;
 
   return {extensionName, extension};
 }
-
-/**
- * Handle EXT_feature_metadata to get property table
- * @param extension - global level of EXT_FEATURE_METADATA extension
- * @param metadataClass - user selected feature metadata class name
- * @returns {FeatureTableJson | null} Property table or null if the extension can't be handled properly.
- */
-function getPropertyTableFromExtFeatureMetadata(
-  extension: GLTF_EXT_feature_metadata_GLTF,
-  metadataClass?: string
-): FeatureTableJson | null {
-  if (extension?.featureTables) {
-    /**
-     * Take only first feature table to generate attributes storage info object.
-     * TODO: Think about getting data from all feature tables?
-     * It can be tricky just because 3dTiles is able to have multiple featureId attributes and multiple feature tables.
-     * In I3S we should decide which featureIds attribute will be passed to geometry data.
-     */
-    const firstFeatureTableName = Object.keys(extension.featureTables)?.[0];
-
-    if (firstFeatureTableName) {
-      const featureTable = extension?.featureTables[firstFeatureTableName];
-      const propertyTable = {};
-
-      for (const propertyName in featureTable.properties) {
-        propertyTable[propertyName] = featureTable.properties[propertyName].data;
-      }
-
-      return propertyTable;
-    }
-  }
-
-  if (extension?.featureTextures) {
-    let featureTexture: string | undefined;
-    for (const textureKey in extension.featureTextures) {
-      const texture = extension.featureTextures[textureKey];
-      if (texture.class === metadataClass) {
-        featureTexture = textureKey;
-      }
-    }
-
-    if (typeof featureTexture === 'string') {
-      const featureTable = extension?.featureTextures[featureTexture];
-      const propertyTable = {};
-
-      for (const propertyName in featureTable.properties) {
-        propertyTable[propertyName] = featureTable.properties[propertyName].data;
-      }
-
-      return propertyTable;
-    }
-  }
-
-  console.warn(
-    "The I3S converter couldn't handle EXT_feature_metadata extension: There is neither featureTables, no featureTextures in the extension."
-  );
-  return null;
-}
-
-/**
- * Handle EXT_structural_metadata to get property table
- * @param extension - global level of EXT_STRUCTURAL_METADATA extension
- * @param metadataClass - user selected feature metadata class name
- * @returns {FeatureTableJson | null} Property table or null if the extension can't be handled properly.
- */
-function getPropertyTableFromExtStructuralMetadata(
-  extension: GLTF_EXT_structural_metadata,
-  metadataClass?: string
-): FeatureTableJson | null {
-  if (extension?.propertyTables) {
-    /**
-     * Take only first feature table to generate attributes storage info object.
-     * TODO: Think about getting data from all feature tables?
-     * It can be tricky just because 3dTiles is able to have multiple featureId attributes and multiple feature tables.
-     * In I3S we should decide which featureIds attribute will be passed to geometry data.
-     */
-    const firstPropertyTable = extension?.propertyTables[0];
-    const propertyTableWithData = {};
-
-    for (const propertyName in firstPropertyTable.properties) {
-      propertyTableWithData[propertyName] = firstPropertyTable.properties[propertyName].data;
-    }
-
-    return propertyTableWithData;
-  }
-
-  if (extension?.propertyTextures) {
-    /**
-     * Take only first feature table to generate attributes storage info object.
-     * TODO: Think about getting data from all feature tables?
-     * It can be tricky just because 3dTiles is able to have multiple featureId attributes and multiple feature tables.
-     * In I3S we should decide which featureIds attribute will be passed to geometry data.
-     */
-    if (extension?.propertyTextures) {
-      const firstPropertyTexture = extension?.propertyTextures[0];
-      const propertyTableWithData = {};
-
-      for (const propertyName in firstPropertyTexture.properties) {
-        propertyTableWithData[propertyName] = firstPropertyTexture.properties[propertyName].data;
-      }
-
-      return propertyTableWithData;
-    }
-  }
-
-  console.warn(
-    "The I3S converter couldn't handle EXT_structural_metadata extension: There is neither propertyTables, no propertyTextures in the extension."
-  );
-  return null;
-}
-
-/**
- * Handle EXT_mesh_features to get property table
- * @param extension - global level of EXT_MESH_FEATURES extension
- * @param metadataClass - user selected feature metadata class name
- * @returns {FeatureTableJson | null} Property table or null if the extension can't be handled properly.
- */
-function getPropertyTableFromExtMeshFeatures(
-  extension: GLTF_EXT_mesh_features,
-  metadataClass?: string
-): FeatureTableJson | null {
-  if (extension?.featureIds) {
-    const firstFeatureId = extension?.featureIds[0];
-    const propertyTableWithData = {};
-
-    // When firstFeatureId.propertyTable is defined, the property data will be taken from EXT_structural_metadata extension
-    if (!firstFeatureId.propertyTable) {
-      console.warn(
-        'Should be implemented as we have the tileset with Ext_mesh_features not linked with EXT_structural_metadata extension'
-      );
-    }
-
-    return propertyTableWithData;
-  }
-
-  console.warn(
-    "The I3S converter couldn't handle EXT_mesh_features extension: There is no featureIds in the extension."
-  );
-  return null;
-}

package/src/i3s-converter/helpers/preprocess-3d-tiles.ts

@@ -1,6 +1,12 @@
 import {Tiles3DTileContent} from '@loaders.gl/3d-tiles';
 import {GLTFPrimitiveModeString, PreprocessData} from '../types';
-import {GLTF, GLTFLoader, GLTF_EXT_feature_metadata_GLTF} from '@loaders.gl/gltf';
+import {
+  EXT_STRUCTURAL_METADATA,
+  GLTF,
+  GLTFLoader,
+  GLTF_EXT_feature_metadata_GLTF,
+  GLTF_EXT_structural_metadata_GLTF
+} from '@loaders.gl/gltf';
 import {parse} from '@loaders.gl/core';
 import {EXT_FEATURE_METADATA} from '@loaders.gl/gltf';
 
@@ -43,8 +49,8 @@ export const analyzeTileContent = async (
   if (!gltf) {
     return defaultResult;
   }
-  const meshTopologyTypes = getMeshTypesFromGltf(gltf);
-  const metadataClasses = getMetadataClassesFromGltf(gltf);
+  const meshTopologyTypes = getMeshTypesFromGLTF(gltf);
+  const metadataClasses = getMetadataClassesFromGLTF(gltf);
   return {
     meshTopologyTypes,
     metadataClasses
@@ -56,7 +62,7 @@ export const analyzeTileContent = async (
  * @param gltfJson - JSON part of GLB content
  * @returns array of mesh types found
  */
-const getMeshTypesFromGltf = (gltfJson: GLTF): Set<GLTFPrimitiveModeString> => {
+const getMeshTypesFromGLTF = (gltfJson: GLTF): Set<GLTFPrimitiveModeString> => {
   const result: Set<GLTFPrimitiveModeString> = new Set();
   for (const mesh of gltfJson.meshes || []) {
     for (const primitive of mesh.primitives) {
@@ -72,17 +78,32 @@ const getMeshTypesFromGltf = (gltfJson: GLTF): Set<GLTFPrimitiveModeString> => {
 
 /**
  * Get feature metadata classes from glTF
+ * The tileset might contain multiple metadata classes provided by EXT_feature_metadata and EXT_structural_metadata extensions.
+ * Every class is a set of properties. But I3S can consume only one set of properties.
+ * On the pre-process we collect all classes from the tileset in order to show the prompt to select one class for conversion to I3S.
  * @param gltfJson - JSON part of GLB content
  * @returns array of classes
  */
-const getMetadataClassesFromGltf = (gltfJson: GLTF): Set<string> => {
+const getMetadataClassesFromGLTF = (gltfJson: GLTF): Set<string> => {
   const result: Set<string> = new Set();
 
-  const classes = (gltfJson.extensions?.[EXT_FEATURE_METADATA] as GLTF_EXT_feature_metadata_GLTF)
-    ?.schema?.classes;
+  // Try to parse from EXT_feature_metadata
+  const extFeatureMetadataClasses = (
+    gltfJson.extensions?.[EXT_FEATURE_METADATA] as GLTF_EXT_feature_metadata_GLTF
+  )?.schema?.classes;
 
-  if (classes) {
-    for (const classKey of Object.keys(classes)) {
+  if (extFeatureMetadataClasses) {
+    for (const classKey of Object.keys(extFeatureMetadataClasses)) {
+      result.add(classKey);
+    }
+  }
+
+  // Try to parse from EXT_structural_metadata
+  const extStructuralMetadataClasses = (
+    gltfJson.extensions?.[EXT_STRUCTURAL_METADATA] as GLTF_EXT_structural_metadata_GLTF
+  )?.schema?.classes;
+  if (extStructuralMetadataClasses) {
+    for (const classKey of Object.keys(extStructuralMetadataClasses)) {
       result.add(classKey);
     }
   }

package/src/i3s-converter/i3s-converter.ts

@@ -656,7 +656,6 @@ export default class I3SConverter {
         We will append new attributes only in case the property table is updated.
         According to ver 1.9 (see https://github.com/Esri/i3s-spec/blob/master/docs/1.9/attributeStorageInfo.cmn.md):
         "The attributeStorageInfo object describes the structure of the binary attribute data resource of a layer, which is the same for every node in the layer."
-        But the specification of ver 2.1 doesn't have such a requirement ("...the same for every node...")
       */
       this._convertPropertyTableToNodeAttributes(propertyTable);
     }
@@ -1167,7 +1166,6 @@ export default class I3SConverter {
         We will append new attributes only in case the property table is updated.
         According to ver 1.9 (see https://github.com/Esri/i3s-spec/blob/master/docs/1.9/attributeStorageInfo.cmn.md):
         "The attributeStorageInfo object describes the structure of the binary attribute data resource of a layer, which is the same for every node in the layer."
-        But the specification of ver 2.1 doesn't have such a requirement ("...the same for every node...")
       */
       const found = this.layers0!.attributeStorageInfo!.find((element) => element.name === key);
       if (!found) {

package/src/i3s-converter/types.ts

@@ -187,7 +187,12 @@ export enum GLTFPrimitiveModeString {
 export type PreprocessData = {
   /** Mesh topology types used in gltf primitives of the tileset */
   meshTopologyTypes: Set<GLTFPrimitiveModeString>;
-  /** Featrue metadata classes found in glTF extensions */
+  /**
+   * Featrue metadata classes found in glTF extensions
+   * The tileset might contain multiple metadata classes provided by EXT_feature_metadata and EXT_structural_metadata extensions.
+   * Every class is a set of properties. But I3S can consume only one set of properties.
+   * On the pre-process we collect all classes from the tileset in order to show the prompt to select one class for conversion to I3S.
+   */
   metadataClasses: Set<string>;
 };