@loaders.gl/gltf 4.0.0-alpha.5 → 4.0.0-alpha.6

package/dist/lib/encoders/encode-glb.d.ts

@@ -1,2 +1,3 @@
-export default function encodeGLBSync(glb: any, dataView: any, byteOffset?: number, options?: {}): number;
+export type GLBEncodeOptions = {};
+export default function encodeGLBSync(glb: any, dataView: any, byteOffset?: number, options?: GLBEncodeOptions): number;
 //# sourceMappingURL=encode-glb.d.ts.map

package/dist/lib/encoders/encode-glb.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"encode-glb.d.ts","sourceRoot":"","sources":["../../../src/lib/encoders/encode-glb.ts"],"names":[],"mappings":"AAeA,MAAM,CAAC,OAAO,UAAU,aAAa,CAAC,GAAG,KAAA,EAAE,QAAQ,KAAA,EAAE,UAAU,SAAI,EAAE,OAAO,KAAK,UA2DhF"}
+{"version":3,"file":"encode-glb.d.ts","sourceRoot":"","sources":["../../../src/lib/encoders/encode-glb.ts"],"names":[],"mappings":"AAYA,MAAM,MAAM,gBAAgB,GAAG,EAAE,CAAC;AAKlC,MAAM,CAAC,OAAO,UAAU,aAAa,CACnC,GAAG,KAAA,EACH,QAAQ,KAAA,EACR,UAAU,SAAI,EACd,OAAO,GAAE,gBAAqB,UA4D/B"}

package/dist/lib/encoders/encode-glb.js

@@ -1,63 +1,61 @@
-import { copyPaddedStringToDataView, copyPaddedArrayBufferToDataView } from '@loaders.gl/loader-utils';
-const MAGIC_glTF = 0x46546c67;
-const MAGIC_JSON = 0x4e4f534a;
-const MAGIC_BIN = 0x004e4942;
-const LE = true;
-export default function encodeGLBSync(glb, dataView, byteOffset = 0, options = {}) {
-  const {
-    magic = MAGIC_glTF,
-    version = 2,
-    json = {},
-    binary
-  } = glb;
-  const byteOffsetStart = byteOffset;
-
-  if (dataView) {
-    dataView.setUint32(byteOffset + 0, magic, LE);
-    dataView.setUint32(byteOffset + 4, version, LE);
-    dataView.setUint32(byteOffset + 8, 0, LE);
-  }
-
-  const byteOffsetFileLength = byteOffset + 8;
-  byteOffset += 12;
-  const byteOffsetJsonHeader = byteOffset;
-
-  if (dataView) {
-    dataView.setUint32(byteOffset + 0, 0, LE);
-    dataView.setUint32(byteOffset + 4, MAGIC_JSON, LE);
-  }
-
-  byteOffset += 8;
-  const jsonString = JSON.stringify(json);
-  byteOffset = copyPaddedStringToDataView(dataView, byteOffset, jsonString, 4);
-
-  if (dataView) {
-    const jsonByteLength = byteOffset - byteOffsetJsonHeader - 8;
-    dataView.setUint32(byteOffsetJsonHeader + 0, jsonByteLength, LE);
-  }
-
-  if (binary) {
-    const byteOffsetBinHeader = byteOffset;
-
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+/* eslint-disable camelcase, max-statements */
+const loader_utils_1 = require("@loaders.gl/loader-utils");
+const MAGIC_glTF = 0x46546c67; // glTF in ASCII
+const MAGIC_JSON = 0x4e4f534a; // JSON in ASCII
+const MAGIC_BIN = 0x004e4942; // BIN\0 in ASCII
+const LE = true; // Binary GLTF is little endian.
+// Encode the full GLB buffer with header etc
+// https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#
+// glb-file-format-specification
+function encodeGLBSync(glb, dataView, byteOffset = 0, options = {}) {
+    const { magic = MAGIC_glTF, version = 2, json = {}, binary } = glb;
+    const byteOffsetStart = byteOffset;
+    // Write GLB Header
     if (dataView) {
-      dataView.setUint32(byteOffset + 0, 0, LE);
-      dataView.setUint32(byteOffset + 4, MAGIC_BIN, LE);
+        dataView.setUint32(byteOffset + 0, magic, LE); // Magic number (the ASCII string 'glTF').
+        dataView.setUint32(byteOffset + 4, version, LE); // Version 2 of binary glTF container format uint32
+        dataView.setUint32(byteOffset + 8, 0, LE); // Total byte length of generated file (uint32), will be set last
     }
-
-    byteOffset += 8;
-    byteOffset = copyPaddedArrayBufferToDataView(dataView, byteOffset, binary, 4);
-
+    const byteOffsetFileLength = byteOffset + 8;
+    byteOffset += 12; // GLB_FILE_HEADER_SIZE
+    // Write the JSON chunk header
+    const byteOffsetJsonHeader = byteOffset;
     if (dataView) {
-      const binByteLength = byteOffset - byteOffsetBinHeader - 8;
-      dataView.setUint32(byteOffsetBinHeader + 0, binByteLength, LE);
+        dataView.setUint32(byteOffset + 0, 0, LE); // Byte length of json chunk (will be written later)
+        dataView.setUint32(byteOffset + 4, MAGIC_JSON, LE); // Chunk type
     }
-  }
-
-  if (dataView) {
-    const fileByteLength = byteOffset - byteOffsetStart;
-    dataView.setUint32(byteOffsetFileLength, fileByteLength, LE);
-  }
-
-  return byteOffset;
+    byteOffset += 8; // GLB_CHUNK_HEADER_SIZE
+    // Write the JSON chunk
+    const jsonString = JSON.stringify(json);
+    byteOffset = (0, loader_utils_1.copyPaddedStringToDataView)(dataView, byteOffset, jsonString, 4);
+    // Now we know the JSON chunk length so we can write it.
+    if (dataView) {
+        const jsonByteLength = byteOffset - byteOffsetJsonHeader - 8; // GLB_CHUNK_HEADER_SIZE
+        dataView.setUint32(byteOffsetJsonHeader + 0, jsonByteLength, LE); // Byte length of json chunk (uint32)
+    }
+    // Write the BIN chunk if present. The BIN chunk is optional.
+    if (binary) {
+        const byteOffsetBinHeader = byteOffset;
+        // Write the BIN chunk header
+        if (dataView) {
+            dataView.setUint32(byteOffset + 0, 0, LE); // Byte length BIN (uint32)
+            dataView.setUint32(byteOffset + 4, MAGIC_BIN, LE); // Chunk type
+        }
+        byteOffset += 8; // GLB_CHUNK_HEADER_SIZE
+        byteOffset = (0, loader_utils_1.copyPaddedArrayBufferToDataView)(dataView, byteOffset, binary, 4);
+        // Now we know the BIN chunk length so we can write it.
+        if (dataView) {
+            const binByteLength = byteOffset - byteOffsetBinHeader - 8; // GLB_CHUNK_HEADER_SIZE
+            dataView.setUint32(byteOffsetBinHeader + 0, binByteLength, LE); // Byte length BIN (uint32)
+        }
+    }
+    // Now we know the glb file length so we can write it.
+    if (dataView) {
+        const fileByteLength = byteOffset - byteOffsetStart;
+        dataView.setUint32(byteOffsetFileLength, fileByteLength, LE); // Total byte length of generated file (uint32)
+    }
+    return byteOffset;
 }
-//# sourceMappingURL=encode-glb.js.map
+exports.default = encodeGLBSync;

package/dist/lib/encoders/encode-gltf.d.ts

@@ -1,2 +1,20 @@
+export type GLTFEncodeOptions = Record<string, any>;
+/**
+ * Encode the full glTF file as a binary GLB file
+ * Returns an ArrayBuffer that represents the complete GLB image that can be saved to file
+ *
+ * @todo - Does not support encoding to non-GLB versions of glTF format. Other formats
+ * - Encode as a textual JSON file with binary data in base64 data URLs.
+ * - Encode as a JSON with all images (and buffers?) in separate binary files
+ *
+ * glb-file-format-specification
+ * @see https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#
+ *
+ * @param gltf
+ * @param arrayBuffer
+ * @param byteOffset
+ * @param options
+ * @returns
+ */
 export declare function encodeGLTFSync(gltf: any, arrayBuffer: any, byteOffset: any, options: any): number;
 //# sourceMappingURL=encode-gltf.d.ts.map

package/dist/lib/encoders/encode-gltf.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"encode-gltf.d.ts","sourceRoot":"","sources":["../../../src/lib/encoders/encode-gltf.ts"],"names":[],"mappings":"AAYA,wBAAgB,cAAc,CAAC,IAAI,KAAA,EAAE,WAAW,KAAA,EAAE,UAAU,KAAA,EAAE,OAAO,KAAA,UAMpE"}
+{"version":3,"file":"encode-gltf.d.ts","sourceRoot":"","sources":["../../../src/lib/encoders/encode-gltf.ts"],"names":[],"mappings":"AAEA,MAAM,MAAM,iBAAiB,GAAG,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC;AAEpD;;;;;;;;;;;;;;;;GAgBG;AACH,wBAAgB,cAAc,CAAC,IAAI,KAAA,EAAE,WAAW,KAAA,EAAE,UAAU,KAAA,EAAE,OAAO,KAAA,UAMpE"}

package/dist/lib/encoders/encode-gltf.js

@@ -1,14 +1,35 @@
-import encodeGLBSync from './encode-glb';
-export function encodeGLTFSync(gltf, arrayBuffer, byteOffset, options) {
-  convertBuffersToBase64(gltf);
-  return encodeGLBSync(gltf, arrayBuffer, byteOffset, options);
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.encodeGLTFSync = void 0;
+const encode_glb_1 = __importDefault(require("./encode-glb"));
+/**
+ * Encode the full glTF file as a binary GLB file
+ * Returns an ArrayBuffer that represents the complete GLB image that can be saved to file
+ *
+ * @todo - Does not support encoding to non-GLB versions of glTF format. Other formats
+ * - Encode as a textual JSON file with binary data in base64 data URLs.
+ * - Encode as a JSON with all images (and buffers?) in separate binary files
+ *
+ * glb-file-format-specification
+ * @see https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#
+ *
+ * @param gltf
+ * @param arrayBuffer
+ * @param byteOffset
+ * @param options
+ * @returns
+ */
+function encodeGLTFSync(gltf, arrayBuffer, byteOffset, options) {
+    convertBuffersToBase64(gltf);
+    // TODO: Copy buffers to binary
+    return (0, encode_glb_1.default)(gltf, arrayBuffer, byteOffset, options);
 }
-
-function convertBuffersToBase64(gltf, {
-  firstBuffer = 0
-} = {}) {
-  if (gltf.buffers && gltf.buffers.length > firstBuffer) {
-    throw new Error('encodeGLTF: multiple buffers not yet implemented');
-  }
+exports.encodeGLTFSync = encodeGLTFSync;
+function convertBuffersToBase64(gltf, { firstBuffer = 0 } = {}) {
+    if (gltf.buffers && gltf.buffers.length > firstBuffer) {
+        throw new Error('encodeGLTF: multiple buffers not yet implemented');
+    }
 }
-//# sourceMappingURL=encode-gltf.js.map

package/dist/lib/extensions/EXT_meshopt_compression.d.ts

@@ -1,9 +1,6 @@
 import type { GLTF } from '../types/gltf-types';
 import type { GLTFLoaderOptions } from '../../gltf-loader';
 export declare const name = "EXT_meshopt_compression";
-export declare function preprocess(gltfData: {
-    json: GLTF;
-}): void;
 export declare function decode(gltfData: {
     json: GLTF;
 }, options: GLTFLoaderOptions): Promise<void>;

package/dist/lib/extensions/EXT_meshopt_compression.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"EXT_meshopt_compression.d.ts","sourceRoot":"","sources":["../../../src/lib/extensions/EXT_meshopt_compression.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAC,IAAI,EAA+C,MAAM,qBAAqB,CAAC;AAC5F,OAAO,KAAK,EAAC,iBAAiB,EAAC,MAAM,mBAAmB,CAAC;AAczD,eAAO,MAAM,IAAI,4BAA0B,CAAC;AAE5C,wBAAgB,UAAU,CAAC,QAAQ,EAAE;IAAC,IAAI,EAAE,IAAI,CAAA;CAAC,QAQhD;AAED,wBAAsB,MAAM,CAAC,QAAQ,EAAE;IAAC,IAAI,EAAE,IAAI,CAAA;CAAC,EAAE,OAAO,EAAE,iBAAiB,iBAiB9E"}
+{"version":3,"file":"EXT_meshopt_compression.d.ts","sourceRoot":"","sources":["../../../src/lib/extensions/EXT_meshopt_compression.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAC,IAAI,EAA+C,MAAM,qBAAqB,CAAC;AAC5F,OAAO,KAAK,EAAC,iBAAiB,EAAC,MAAM,mBAAmB,CAAC;AAczD,eAAO,MAAM,IAAI,4BAA0B,CAAC;AAE5C,wBAAsB,MAAM,CAAC,QAAQ,EAAE;IAAC,IAAI,EAAE,IAAI,CAAA;CAAC,EAAE,OAAO,EAAE,iBAAiB,iBAiB9E"}

package/dist/lib/extensions/EXT_meshopt_compression.js

@@ -1,56 +1,45 @@
-import GLTFScenegraph from '../api/gltf-scenegraph';
-import { isMeshoptSupported, meshoptDecodeGltfBuffer } from '../../meshopt/meshopt-decoder';
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.decode = exports.name = void 0;
+const gltf_scenegraph_1 = __importDefault(require("../api/gltf-scenegraph"));
+const meshopt_decoder_1 = require("../../meshopt/meshopt-decoder");
+// @ts-ignore
+// eslint-disable-next-line
 const DEFAULT_MESHOPT_OPTIONS = {
-  byteOffset: 0,
-  filter: 'NONE'
+    byteOffset: 0,
+    filter: 'NONE'
 };
+/** Extension name */
 const EXT_MESHOPT_COMPRESSION = 'EXT_meshopt_compression';
-export const name = EXT_MESHOPT_COMPRESSION;
-export function preprocess(gltfData) {
-  const scenegraph = new GLTFScenegraph(gltfData);
-
-  if (scenegraph.getRequiredExtensions().includes(EXT_MESHOPT_COMPRESSION) && !isMeshoptSupported()) {
-    throw new Error("gltf: Required extension ".concat(EXT_MESHOPT_COMPRESSION, " not supported by browser"));
-  }
-}
-export async function decode(gltfData, options) {
-  var _options$gltf;
-
-  const scenegraph = new GLTFScenegraph(gltfData);
-
-  if (!(options !== null && options !== void 0 && (_options$gltf = options.gltf) !== null && _options$gltf !== void 0 && _options$gltf.decompressMeshes)) {
-    return;
-  }
-
-  const promises = [];
-
-  for (const bufferViewIndex of gltfData.json.bufferViews || []) {
-    promises.push(decodeMeshoptBufferView(scenegraph, bufferViewIndex));
-  }
-
-  await Promise.all(promises);
-  scenegraph.removeExtension(EXT_MESHOPT_COMPRESSION);
+exports.name = EXT_MESHOPT_COMPRESSION;
+async function decode(gltfData, options) {
+    const scenegraph = new gltf_scenegraph_1.default(gltfData);
+    if (!options?.gltf?.decompressMeshes) {
+        return;
+    }
+    const promises = [];
+    for (const bufferViewIndex of gltfData.json.bufferViews || []) {
+        promises.push(decodeMeshoptBufferView(scenegraph, bufferViewIndex));
+    }
+    // Decompress meshes in parallel
+    await Promise.all(promises);
+    // We have now decompressed all primitives, so remove the top-level extension
+    scenegraph.removeExtension(EXT_MESHOPT_COMPRESSION);
 }
-
+exports.decode = decode;
+/** Decode one meshopt buffer view */
 async function decodeMeshoptBufferView(scenegraph, bufferView) {
-  const meshoptExtension = scenegraph.getObjectExtension(bufferView, EXT_MESHOPT_COMPRESSION);
-
-  if (meshoptExtension) {
-    const buffer = bufferView.buffer;
-    const {
-      byteOffset = 0,
-      byteLength = 0,
-      byteStride,
-      count,
-      mode,
-      filter = 'NONE'
-    } = meshoptExtension;
-    const source = new Uint8Array(buffer, byteOffset, byteLength);
-    const result = new ArrayBuffer(count * byteStride);
-    await meshoptDecodeGltfBuffer(new Uint8Array(result), count, byteStride, source, mode, filter);
-    return result;
-  }
-
-  return null;
+    const meshoptExtension = scenegraph.getObjectExtension(bufferView, EXT_MESHOPT_COMPRESSION);
+    if (meshoptExtension) {
+        const { byteOffset = 0, byteLength = 0, byteStride, count, mode, filter = 'NONE', buffer: bufferIndex } = meshoptExtension;
+        const buffer = scenegraph.gltf.buffers[bufferIndex];
+        const source = new Uint8Array(buffer.arrayBuffer, buffer.byteOffset + byteOffset, byteLength);
+        const result = new Uint8Array(scenegraph.gltf.buffers[bufferView.buffer].arrayBuffer, bufferView.byteOffset, bufferView.byteLength);
+        await (0, meshopt_decoder_1.meshoptDecodeGltfBuffer)(result, count, byteStride, source, mode, filter);
+        return result;
+    }
+    return null;
 }
-//# sourceMappingURL=EXT_meshopt_compression.js.map

package/dist/lib/extensions/EXT_texture_webp.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"EXT_texture_webp.d.ts","sourceRoot":"","sources":["../../../src/lib/extensions/EXT_texture_webp.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAC,IAAI,EAAwB,MAAM,qBAAqB,CAAC;AACrE,OAAO,KAAK,EAAC,iBAAiB,EAAC,MAAM,mBAAmB,CAAC;AAOzD,qBAAqB;AACrB,eAAO,MAAM,IAAI,qBAAmB,CAAC;AAErC;;;GAGG;AACH,wBAAgB,UAAU,CAAC,QAAQ,EAAE;IAAC,IAAI,EAAE,IAAI,CAAA;CAAC,EAAE,OAAO,EAAE,iBAAiB,GAAG,IAAI,CAyBnF"}
+{"version":3,"file":"EXT_texture_webp.d.ts","sourceRoot":"","sources":["../../../src/lib/extensions/EXT_texture_webp.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAC,IAAI,EAAwB,MAAM,qBAAqB,CAAC;AACrE,OAAO,KAAK,EAAC,iBAAiB,EAAC,MAAM,mBAAmB,CAAC;AAOzD,qBAAqB;AACrB,eAAO,MAAM,IAAI,qBAAmB,CAAC;AAErC;;;GAGG;AACH,wBAAgB,UAAU,CAAC,QAAQ,EAAE;IAAC,IAAI,EAAE,IAAI,CAAA;CAAC,EAAE,OAAO,EAAE,iBAAiB,GAAG,IAAI,CA0BnF"}

package/dist/lib/extensions/EXT_texture_webp.js

@@ -1,32 +1,39 @@
-import { _isImageFormatSupported } from '@loaders.gl/images';
-import GLTFScenegraph from '../api/gltf-scenegraph';
+"use strict";
+// GLTF EXTENSION: EXT_TEXTURE_WEBP
+// https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/EXT_TEXTURE_WEBP
+/* eslint-disable camelcase */
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.preprocess = exports.name = void 0;
+const images_1 = require("@loaders.gl/images");
+const gltf_scenegraph_1 = __importDefault(require("../api/gltf-scenegraph"));
 const EXT_TEXTURE_WEBP = 'EXT_texture_webp';
-export const name = EXT_TEXTURE_WEBP;
-export function preprocess(gltfData, options) {
-  const scenegraph = new GLTFScenegraph(gltfData);
-
-  if (!_isImageFormatSupported('image/webp')) {
-    if (scenegraph.getRequiredExtensions().includes(EXT_TEXTURE_WEBP)) {
-      throw new Error("gltf: Required extension ".concat(EXT_TEXTURE_WEBP, " not supported by browser"));
+/** Extension name */
+exports.name = EXT_TEXTURE_WEBP;
+/**
+ * Replaces a texture source reference with the extension texture
+ * Done in preprocess() to prevent load of default image
+ */
+function preprocess(gltfData, options) {
+    const scenegraph = new gltf_scenegraph_1.default(gltfData);
+    if (!(0, images_1.isImageFormatSupported)('image/webp')) {
+        if (scenegraph.getRequiredExtensions().includes(EXT_TEXTURE_WEBP)) {
+            throw new Error(`gltf: Required extension ${EXT_TEXTURE_WEBP} not supported by browser`);
+        }
+        return;
     }
-
-    return;
-  }
-
-  const {
-    json
-  } = scenegraph;
-
-  for (const texture of json.textures || []) {
-    const extension = scenegraph.getObjectExtension(texture, EXT_TEXTURE_WEBP);
-
-    if (extension) {
-      texture.source = extension.source;
+    const { json } = scenegraph;
+    for (const texture of json.textures || []) {
+        const extension = scenegraph.getObjectExtension(texture, EXT_TEXTURE_WEBP);
+        if (extension) {
+            // TODO - if multiple texture extensions are present which one wins?
+            texture.source = extension.source;
+        }
+        scenegraph.removeObjectExtension(texture, EXT_TEXTURE_WEBP);
     }
-
-    scenegraph.removeObjectExtension(texture, EXT_TEXTURE_WEBP);
-  }
-
-  scenegraph.removeExtension(EXT_TEXTURE_WEBP);
+    // Remove the top-level extension
+    scenegraph.removeExtension(EXT_TEXTURE_WEBP);
 }
-//# sourceMappingURL=EXT_texture_webp.js.map
+exports.preprocess = preprocess;

package/dist/lib/extensions/KHR_binary_gltf.js

@@ -1,26 +1,42 @@
-import GLTFScenegraph from '../api/gltf-scenegraph';
+"use strict";
+// GLTF 1.0 EXTENSION: KHR_binary_glTF
+// https://github.com/KhronosGroup/glTF/tree/master/extensions/1.0/Khronos/KHR_binary_glTF
+/* eslint-disable camelcase */
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.preprocess = exports.name = void 0;
+const gltf_scenegraph_1 = __importDefault(require("../api/gltf-scenegraph"));
 const KHR_BINARY_GLTF = 'KHR_binary_glTF';
-export const name = KHR_BINARY_GLTF;
-export function preprocess(gltfData) {
-  const gltfScenegraph = new GLTFScenegraph(gltfData);
-  const {
-    json
-  } = gltfScenegraph;
-
-  for (const image of json.images || []) {
-    const extension = gltfScenegraph.getObjectExtension(image, KHR_BINARY_GLTF);
-
-    if (extension) {
-      Object.assign(image, extension);
+/** Extension name */
+exports.name = KHR_BINARY_GLTF;
+function preprocess(gltfData) {
+    const gltfScenegraph = new gltf_scenegraph_1.default(gltfData);
+    const { json } = gltfScenegraph;
+    // Note: json.buffers.binary_glTF also needs to be replaced
+    // This is currently done during gltf normalization
+    // Image and shader nodes can have the extension
+    // https://github.com/KhronosGroup/glTF/blob/master/extensions/1.0/Khronos/KHR_binary_glTF/schema/image.KHR_binary_glTF.schema.json
+    for (const image of json.images || []) {
+        const extension = gltfScenegraph.getObjectExtension(image, KHR_BINARY_GLTF);
+        // The data in the extension is valid as glTF 2.0 data inside the object, so just copy it in
+        if (extension) {
+            Object.assign(image, extension);
+        }
+        gltfScenegraph.removeObjectExtension(image, KHR_BINARY_GLTF);
     }
-
-    gltfScenegraph.removeObjectExtension(image, KHR_BINARY_GLTF);
-  }
-
-  if (json.buffers && json.buffers[0]) {
-    delete json.buffers[0].uri;
-  }
-
-  gltfScenegraph.removeExtension(KHR_BINARY_GLTF);
+    // TODO shaders - At least traverse and throw error if used?
+    // https://github.com/KhronosGroup/glTF/blob/master/extensions/1.0/Khronos/KHR_binary_glTF/schema/shader.KHR_binary_glTF.schema.json
+    // glTF v1 one files have a partially formed URI field that is not expected in (and causes problems in) 2.0
+    if (json.buffers && json.buffers[0]) {
+        delete json.buffers[0].uri;
+    }
+    // Remove the top-level extension as it has now been processed
+    gltfScenegraph.removeExtension(KHR_BINARY_GLTF);
 }
-//# sourceMappingURL=KHR_binary_gltf.js.map
+exports.preprocess = preprocess;
+// KHR_binary_gltf is a 1.0 extension that is supported natively by 2.0
+// export function encode() {
+//   throw new Error(KHR_BINARY_GLTF);
+// }