@loaders.gl/core 4.0.0-alpha.5 → 4.0.0-alpha.6

package/src/index.ts

@@ -1,3 +1,20 @@
+// loaders.gl, MIT license
+
+// TYPES
+export type {
+  Loader,
+  LoaderWithParser,
+  LoaderContext,
+  LoaderOptions,
+  Writer,
+  WriterOptions,
+  DataType,
+  SyncDataType,
+  BatchableDataType,
+  IFileSystem,
+  IRandomAccessReadFileSystem
+} from '@loaders.gl/loader-utils';
+
 // FILE READING AND WRITING
 export {fetchFile} from './lib/fetch/fetch-file';
 
@@ -6,7 +23,7 @@ export {readFileSync} from './lib/fetch/read-file';
 export {writeFile, writeFileSync} from './lib/fetch/write-file';
 
 // CONFIGURATION
-export {setLoaderOptions} from './lib/api/set-loader-options';
+export {setLoaderOptions, getLoaderOptions} from './lib/api/loader-options';
 export {registerLoaders} from './lib/api/register-loaders';
 export {selectLoader, selectLoaderSync} from './lib/api/select-loader';
 
@@ -19,6 +36,7 @@ export {load} from './lib/api/load';
 export {loadInBatches} from './lib/api/load-in-batches';
 
 // ENCODING (ENCODING AND WRITING)
+export {encodeTable, encodeTableAsText, encodeTableInBatches} from './lib/api/encode-table';
 export {encode, encodeSync, encodeInBatches, encodeText, encodeURLtoURL} from './lib/api/encode';
 export {save, saveSync} from './lib/api/save';
 

package/src/iterators/make-stream/make-dom-stream.ts

@@ -24,7 +24,6 @@ export function makeStream<ArrayBuffer>(
       // Create a byte stream (enables `Response(stream).arrayBuffer()`)
       // Only supported on Chrome
       // See: https://developer.mozilla.org/en-US/docs/Web/API/ReadableByteStreamController
-      // @ts-expect-error Only Chrome supports byte streams
       type: 'bytes',
 
       async pull(controller) {
@@ -34,6 +33,7 @@ export function makeStream<ArrayBuffer>(
             controller.close();
           } else {
             // TODO - ignores controller.desiredSize
+            // @ts-expect-error Unclear why value is not correctly typed
             controller.enqueue(new Uint8Array(value));
           }
         } catch (error) {

package/src/iterators/make-stream/make-node-stream.ts

@@ -1,4 +1,10 @@
-import {Readable, ReadableOptions} from 'stream';
+import type {ReadableOptions} from 'stream';
+import * as Stream from 'stream';
+
+class _Readable {}
+
+type ReadableType = Stream.Readable | _Readable;
+const Readable = Stream.Readable || _Readable;
 
 export type MakeStreamOptions = ReadableOptions;
 
@@ -6,7 +12,7 @@ export type MakeStreamOptions = ReadableOptions;
 export function makeStream<ArrayBuffer>(
   source: Iterable<ArrayBuffer> | AsyncIterable<ArrayBuffer>,
   options?: ReadableOptions
-): Readable {
+): ReadableType {
   const iterator = source[Symbol.asyncIterator]
     ? source[Symbol.asyncIterator]()
     : source[Symbol.iterator]();

package/src/lib/api/encode-table.ts

@@ -0,0 +1,71 @@
+// loaders.gl, MIT license
+// Copyright 2022 Foursquare Labs, Inc
+
+/* global TextEncoder, TextDecoder */
+import {concatenateArrayBuffers, Writer, WriterOptionsType} from '@loaders.gl/loader-utils';
+import {Table} from '@loaders.gl/schema';
+
+export async function encodeTable<WriterT extends Writer = Writer>(
+  data: Table,
+  writer: WriterT,
+  options?: WriterOptionsType<WriterT>
+): Promise<ArrayBuffer> {
+  if (writer.encode) {
+    return await writer.encode(data, options);
+  }
+
+  if (writer.encodeText) {
+    const text = await writer.encodeText(data, options);
+    return new TextEncoder().encode(text);
+  }
+
+  if (writer.encodeInBatches) {
+    // Create an iterator representing the data
+    // TODO - Assumes this is a table
+    const batches = encodeTableInBatches(data, writer, options);
+
+    // Concatenate the output
+    const chunks: ArrayBuffer[] = [];
+    for await (const batch of batches) {
+      chunks.push(batch);
+    }
+    return concatenateArrayBuffers(...chunks);
+  }
+
+  throw new Error('Writer could not encode data');
+}
+
+export async function encodeTableAsText<WriterT extends Writer = Writer>(
+  data: Table,
+  writer: WriterT,
+  options?: WriterOptionsType<WriterT>
+): Promise<string> {
+  if (writer.text && writer.encodeText) {
+    return await writer.encodeText(data, options);
+  }
+
+  if (writer.text && (writer.encode || writer.encodeInBatches)) {
+    const arrayBuffer = await encodeTable(data, writer, options);
+    return new TextDecoder().decode(arrayBuffer);
+  }
+  throw new Error('Writer could not encode data as text');
+}
+
+export function encodeTableInBatches<WriterT extends Writer = Writer>(
+  data: Table,
+  writer: WriterT,
+  options?: WriterOptionsType<WriterT>
+): AsyncIterable<ArrayBuffer> {
+  if (writer.encodeInBatches) {
+    const dataIterator = getIterator(data);
+    // @ts-expect-error
+    return writer.encodeInBatches(dataIterator, options);
+  }
+  // TODO -fall back to atomic encode?
+  throw new Error('Writer could not encode data in batches');
+}
+
+function getIterator(data) {
+  const dataIterator = [{table: data, start: 0, end: data.length}];
+  return dataIterator;
+}

package/src/lib/api/encode.ts

@@ -1,8 +1,10 @@
-import type {Writer, LoaderOptions} from '@loaders.gl/loader-utils';
+import {Writer, WriterOptions, canEncodeWithWorker} from '@loaders.gl/loader-utils';
+import {processOnWorker} from '@loaders.gl/worker-utils';
 import {concatenateArrayBuffers, resolvePath} from '@loaders.gl/loader-utils';
 import {isBrowser} from '@loaders.gl/loader-utils';
 import {writeFile} from '../fetch/write-file';
 import {fetchFile} from '../fetch/fetch-file';
+import {getLoaderOptions} from './loader-options';
 
 /**
  * Encode loaded data into a binary ArrayBuffer using the specified Writer.
@@ -10,8 +12,15 @@ import {fetchFile} from '../fetch/fetch-file';
 export async function encode(
   data: any,
   writer: Writer,
-  options?: LoaderOptions
+  options?: WriterOptions
 ): Promise<ArrayBuffer> {
+  const globalOptions = getLoaderOptions() as WriterOptions;
+  // const globalOptions: WriterOptions = {}; // getWriterOptions();
+  options = {...globalOptions, ...options};
+  if (canEncodeWithWorker(writer, options)) {
+    return await processOnWorker(writer, data, options);
+  }
+
   // TODO Merge default writer options with options argument like it is done in load module.
   if (writer.encode) {
     return await writer.encode(data, options);
@@ -63,7 +72,7 @@ export async function encode(
 /**
  * Encode loaded data into a binary ArrayBuffer using the specified Writer.
  */
-export function encodeSync(data: any, writer: Writer, options?: LoaderOptions): ArrayBuffer {
+export function encodeSync(data: any, writer: Writer, options?: WriterOptions): ArrayBuffer {
   if (writer.encodeSync) {
     return writer.encodeSync(data, options);
   }
@@ -79,7 +88,7 @@ export function encodeSync(data: any, writer: Writer, options?: LoaderOptions):
 export async function encodeText(
   data: any,
   writer: Writer,
-  options?: LoaderOptions
+  options?: WriterOptions
 ): Promise<string> {
   if (writer.text && writer.encodeText) {
     return await writer.encodeText(data, options);
@@ -99,10 +108,11 @@ export async function encodeText(
 export function encodeInBatches(
   data: any,
   writer: Writer,
-  options?: LoaderOptions
+  options?: WriterOptions
 ): AsyncIterable<ArrayBuffer> {
   if (writer.encodeInBatches) {
     const dataIterator = getIterator(data);
+    // @ts-expect-error
     return writer.encodeInBatches(dataIterator, options);
   }
   // TODO -fall back to atomic encode?

package/src/lib/api/load-in-batches.ts

@@ -1,6 +1,6 @@
 import type {LoaderWithParser, LoaderOptions, LoaderContext} from '@loaders.gl/loader-utils';
 import {isLoaderObject} from '../loader-utils/normalize-loader';
-import {getFetchFunction} from '../loader-utils/option-utils';
+import {getFetchFunction} from '../loader-utils/get-fetch-function';
 
 import {parseInBatches} from './parse-in-batches';
 

package/src/lib/api/load.ts

@@ -1,7 +1,10 @@
+// loaders.gl, MIT license
+
 import type {DataType, Loader, LoaderContext, LoaderOptions} from '@loaders.gl/loader-utils';
+import type {LoaderOptionsType, LoaderReturnType} from '@loaders.gl/loader-utils';
 import {isBlob} from '../../javascript-utils/is-type';
 import {isLoaderObject} from '../loader-utils/normalize-loader';
-import {getFetchFunction} from '../loader-utils/option-utils';
+import {getFetchFunction} from '../loader-utils/get-fetch-function';
 
 import {parse} from './parse';
 
@@ -14,22 +17,46 @@ import {parse} from './parse';
  * @param options
  * @param context
  */
+
+export async function load<LoaderT extends Loader>(
+  url: string | DataType,
+  loader: LoaderT,
+  options?: LoaderOptionsType<LoaderT>,
+  context?: LoaderContext
+): Promise<LoaderReturnType<LoaderT>>;
+
+export async function load<
+  LoaderT extends Loader,
+  LoaderOptionsT extends LoaderOptions = LoaderOptions
+>(
+  url: string | DataType,
+  loaders: Loader[] | LoaderOptions,
+  options?: LoaderOptionsT,
+  context?: LoaderContext
+): Promise<any>;
+
 // implementation signature
-export async function load(
+export async function load<LoaderOptionsT extends LoaderOptions>(
   url: string | DataType,
-  loaders?: Loader | Loader[] | LoaderOptions,
-  options?: LoaderOptions,
+  loaders?: Loader[] | LoaderOptions,
+  options?: LoaderOptionsT,
   context?: LoaderContext
 ): Promise<any> {
+  let resolvedLoaders: Loader | Loader[];
+  let resolvedOptions: LoaderOptionsT | undefined;
+
   // Signature: load(url, options)
   if (!Array.isArray(loaders) && !isLoaderObject(loaders)) {
+    resolvedLoaders = [];
+    resolvedOptions = loaders as LoaderOptionsT;
     context = undefined; // context not supported in short signature
-    options = loaders as LoaderOptions;
-    loaders = undefined;
+  } else {
+    resolvedLoaders = loaders as Loader | Loader[];
+    resolvedOptions = options;
   }
 
   // Select fetch function
-  const fetch = getFetchFunction(options);
+  const fetch = getFetchFunction(resolvedOptions);
 
   // at this point, `url` could be already loaded binary data
   let data = url;
@@ -41,9 +68,13 @@ export async function load(
 
   if (isBlob(url)) {
     // The fetch response object will contain blob.name
+    // @ts-expect-error TODO - This may not work for overridden fetch functions
     data = await fetch(url);
   }
 
   // Data is loaded (at least we have a `Response` object) so time to hand over to `parse`
-  return await parse(data, loaders, options);
+  // return await parse(data, loaders as Loader[], options);
+  return Array.isArray(resolvedLoaders)
+    ? await parse(data, resolvedLoaders, resolvedOptions) // loader array overload
+    : await parse(data, resolvedLoaders, resolvedOptions); // single loader overload
 }

package/src/lib/api/loader-options.ts

@@ -0,0 +1,2 @@
+export {setGlobalOptions as setLoaderOptions} from '../loader-utils/option-utils';
+export {getGlobalLoaderOptions as getLoaderOptions} from '../loader-utils/option-utils';

package/src/lib/api/parse.ts

@@ -1,13 +1,41 @@
+// loaders.gl, MIT license
+
 import type {DataType, Loader, LoaderContext, LoaderOptions} from '@loaders.gl/loader-utils';
+import type {LoaderOptionsType, LoaderReturnType} from '@loaders.gl/loader-utils';
 import {assert, validateWorkerVersion} from '@loaders.gl/worker-utils';
 import {parseWithWorker, canParseWithWorker} from '@loaders.gl/loader-utils';
 import {isLoaderObject} from '../loader-utils/normalize-loader';
+import {isResponse} from '../../javascript-utils/is-type';
 import {normalizeOptions} from '../loader-utils/option-utils';
 import {getArrayBufferOrStringFromData} from '../loader-utils/get-data';
 import {getLoaderContext, getLoadersFromContext} from '../loader-utils/loader-context';
 import {getResourceUrlAndType} from '../utils/resource-utils';
 import {selectLoader} from './select-loader';
 
+// type LoaderArrayType<T> = T extends (infer Loader)[] ? LoaderOptionsType<Loader> : T
+
+export async function parse<
+  LoaderT extends Loader,
+  OptionsT extends LoaderOptions = LoaderOptionsType<LoaderT>
+>(
+  data: DataType | Promise<DataType>,
+  loader: LoaderT,
+  options?: OptionsT,
+  context?: LoaderContext
+): Promise<LoaderReturnType<LoaderT>>;
+
+export async function parse(
+  data: DataType | Promise<DataType>,
+  loaders: Loader[],
+  options?: LoaderOptions,
+  context?: LoaderContext
+): Promise<any>;
+
+export async function parse(
+  data: DataType | Promise<DataType>,
+  options?: LoaderOptions
+): Promise<any>;
+
 /**
  * Parses `data` using a specified loader
  * @param data
@@ -15,6 +43,7 @@ import {selectLoader} from './select-loader';
  * @param options
  * @param context
  */
+// implementation signature
 export async function parse(
   data: DataType | Promise<DataType>,
   loaders?: Loader | Loader[] | LoaderOptions,
@@ -32,7 +61,7 @@ export async function parse(
   }
 
   data = await data; // Resolve any promise
-  options = options || {};
+  options = options || ({} as LoaderOptions); // Could be invalid...
 
   // Extract a url for auto detection
   const {url} = getResourceUrlAndType(data);
@@ -49,7 +78,7 @@ export async function parse(
   }
 
   // Normalize options
-  options = normalizeOptions(options, loader, candidateLoaders, url);
+  options = normalizeOptions(options, loader, candidateLoaders, url); // Could be invalid...
 
   // Get a context (if already present, will be unchanged)
   context = getLoaderContext({url, parse, loaders: candidateLoaders}, options, context);
@@ -62,6 +91,14 @@ export async function parse(
 async function parseWithLoader(loader, data, options, context) {
   validateWorkerVersion(loader);
 
+  if (isResponse(data)) {
+    // Serialize to support passing the response to web worker
+    const response = data as Response;
+    const {ok, redirected, status, statusText, type, url} = response;
+    const headers = Object.fromEntries(response.headers.entries());
+    context.response = {headers, ok, redirected, status, statusText, type, url};
+  }
+
   data = await getArrayBufferOrStringFromData(data, loader, options);
 
   // First check for synchronous text parser, wrap results in promises

package/src/lib/api/register-loaders.ts

@@ -11,7 +11,7 @@ const getGlobalLoaderRegistry = () => {
 };
 
 /** Register a list of global loaders */
-export function registerLoaders(loaders: Loader[]) {
+export function registerLoaders(loaders: Loader[] | Loader) {
   const loaderRegistry = getGlobalLoaderRegistry();
 
   loaders = Array.isArray(loaders) ? loaders : [loaders];

package/src/lib/api/select-loader.ts

@@ -1,6 +1,7 @@
 import type {LoaderContext, LoaderOptions, Loader} from '@loaders.gl/loader-utils';
 import {compareArrayBuffers, path} from '@loaders.gl/loader-utils';
 import {normalizeLoader} from '../loader-utils/normalize-loader';
+import {log} from '../utils/log';
 import {getResourceUrlAndType} from '../utils/resource-utils';
 import {getRegisteredLoaders} from './register-loaders';
 import {isBlob} from '../../javascript-utils/is-type';
@@ -103,6 +104,7 @@ export function selectLoaderSync(
 }
 
 /** Implements loaders selection logic */
+// eslint-disable-next-line complexity
 function selectLoaderInternal(
   data: Response | Blob | ArrayBuffer | string,
   loaders: Loader[],
@@ -114,19 +116,33 @@ function selectLoaderInternal(
   const testUrl = url || context?.url;
 
   let loader: Loader | null = null;
+  let reason: string = '';
 
   // if options.mimeType is supplied, it takes precedence
   if (options?.mimeType) {
     loader = findLoaderByMIMEType(loaders, options?.mimeType);
+    reason = `match forced by supplied MIME type ${options?.mimeType}`;
   }
+
   // Look up loader by url
   loader = loader || findLoaderByUrl(loaders, testUrl);
+  reason = reason || (loader ? `matched url ${testUrl}` : '');
+
   // Look up loader by mime type
   loader = loader || findLoaderByMIMEType(loaders, type);
+  reason = reason || (loader ? `matched MIME type ${type}` : '');
+
   // Look for loader via initial bytes (Note: not always accessible (e.g. Response, stream, async iterator)
   loader = loader || findLoaderByInitialBytes(loaders, data);
+  reason = reason || (loader ? `matched initial data ${getFirstCharacters(data)}` : '');
+
   // Look up loader by fallback mime type
   loader = loader || findLoaderByMIMEType(loaders, options?.fallbackMimeType);
+  reason = reason || (loader ? `matched fallback MIME type ${type}` : '');
+
+  if (reason) {
+    log.log(1, `selectLoader selected ${loader?.name}: ${reason}.`);
+  }
 
   return loader;
 }

package/src/lib/init.ts

@@ -1,10 +1,17 @@
+// loaders.gl, MIT license
+import {log} from './utils/log';
+
 // @ts-ignore TS2304: Cannot find name '__VERSION__'.
 const version = typeof __VERSION__ !== 'undefined' ? __VERSION__ : '';
 
 // @ts-ignore
-globalThis.loaders = Object.assign(globalThis.loaders || {}, {
-  VERSION: version
-});
+if (!globalThis.loaders) {
+  log.log(1, `loaders.gl ${version}`)();
 
+  globalThis.loaders = Object.assign(globalThis.loaders || {}, {
+    VERSION: version,
+    log
+  });
+}
 // @ts-ignore
 export default globalThis.loaders;

package/src/lib/loader-utils/get-fetch-function.ts

@@ -0,0 +1,38 @@
+// loaders.gl, MIT license
+
+import type {LoaderContext, LoaderOptions} from '@loaders.gl/loader-utils';
+import {isObject} from '../../javascript-utils/is-type';
+import {fetchFile} from '../fetch/fetch-file';
+import {getGlobalLoaderOptions} from './option-utils';
+
+/**
+ * Gets the current fetch function from options and context
+ * @param options
+ * @param context
+ */
+export function getFetchFunction(
+  options?: LoaderOptions,
+  context?: Omit<LoaderContext, 'fetch'> & Partial<Pick<LoaderContext, 'fetch'>>
+) {
+  const globalOptions = getGlobalLoaderOptions();
+
+  const fetchOptions = options || globalOptions;
+
+  // options.fetch can be a function
+  if (typeof fetchOptions.fetch === 'function') {
+    return fetchOptions.fetch;
+  }
+
+  // options.fetch can be an options object
+  if (isObject(fetchOptions.fetch)) {
+    return (url) => fetchFile(url, fetchOptions as RequestInit);
+  }
+
+  // else refer to context (from parent loader) if available
+  if (context?.fetch) {
+    return context?.fetch;
+  }
+
+  // else return the default fetch function
+  return fetchFile;
+}

package/src/lib/loader-utils/loader-context.ts

@@ -1,5 +1,5 @@
 import type {Loader, LoaderOptions, LoaderContext} from '@loaders.gl/loader-utils';
-import {getFetchFunction} from './option-utils';
+import {getFetchFunction} from './get-fetch-function';
 
 /**
  * "sub" loaders invoked by other loaders get a "context" injected on `this`

package/src/lib/loader-utils/loggers.ts

@@ -1,5 +1,5 @@
 // probe.gl Log compatible loggers
-import {Log} from 'probe.gl';
+import {Log} from '@probe.gl/log';
 
 export const probeLog = new Log({id: 'loaders.gl'});
 

package/src/lib/loader-utils/option-defaults.ts

@@ -1,4 +1,5 @@
 import type {LoaderOptions} from '@loaders.gl/loader-utils';
+import {isBrowser} from '@loaders.gl/loader-utils';
 import {ConsoleLog} from './loggers';
 
 export const DEFAULT_LOADER_OPTIONS: LoaderOptions = {
@@ -12,7 +13,8 @@ export const DEFAULT_LOADER_OPTIONS: LoaderOptions = {
   worker: true, // By default, use worker if provided by loader.
   maxConcurrency: 3, // How many worker instances should be created for each loader.
   maxMobileConcurrency: 1, // How many worker instances should be created for each loader on mobile devices.
-  reuseWorkers: true, // By default reuse workers,
+  reuseWorkers: isBrowser, // By default reuse workers in browser (Node.js refuses to terminate if browsers are running)
+  _nodeWorkers: false, // By default do not support node workers
   _workerType: '', // 'test' to use locally generated workers
 
   limit: 0,

package/src/lib/loader-utils/option-utils.ts

@@ -1,14 +1,16 @@
-import type {Loader, LoaderContext, LoaderOptions} from '@loaders.gl/loader-utils';
+// loaders.gl, MIT license
+
+import type {Loader, LoaderOptions} from '@loaders.gl/loader-utils';
 import {isPureObject, isObject} from '../../javascript-utils/is-type';
-import {fetchFile} from '../fetch/fetch-file';
 import {probeLog, NullLog} from './loggers';
 import {DEFAULT_LOADER_OPTIONS, REMOVED_LOADER_OPTIONS} from './option-defaults';
+
 /**
  * Global state for loaders.gl. Stored on `global.loaders._state`
  */
 type GlobalLoaderState = {
   loaderRegistry: Loader[];
-  globalOptions: {[key: string]: any};
+  globalOptions: LoaderOptions;
 };
 
 /**
@@ -26,9 +28,12 @@ export function getGlobalLoaderState(): GlobalLoaderState {
   return loaders._state;
 }
 
-// Store global loader options on the global object to increase chances of cross loaders-version interoperability
-// NOTE: This use case is not reliable but can help when testing new versions of loaders.gl with existing frameworks
-const getGlobalLoaderOptions = () => {
+/**
+ * Store global loader options on the global object to increase chances of cross loaders-version interoperability
+ * NOTE: This use case is not reliable but can help when testing new versions of loaders.gl with existing frameworks
+ * @returns global loader options merged with default loader options
+ */
+export const getGlobalLoaderOptions = (): LoaderOptions => {
   const state = getGlobalLoaderState();
   // Ensure all default loader options from this library are mentioned
   state.globalOptions = state.globalOptions || {...DEFAULT_LOADER_OPTIONS};
@@ -39,7 +44,7 @@ const getGlobalLoaderOptions = () => {
  * Set global loader options
  * @param options
  */
-export function setGlobalOptions(options: object): void {
+export function setGlobalOptions(options: LoaderOptions): void {
   const state = getGlobalLoaderState();
   const globalOptions = getGlobalLoaderOptions();
   state.globalOptions = normalizeOptionsInternal(globalOptions, options);
@@ -53,11 +58,11 @@ export function setGlobalOptions(options: object): void {
  * @param url
  */
 export function normalizeOptions(
-  options: object,
+  options: LoaderOptions,
   loader: Loader,
   loaders?: Loader[],
   url?: string
-): object {
+): LoaderOptions {
   loaders = loaders || [];
   loaders = Array.isArray(loaders) ? loaders : [loaders];
 
@@ -65,38 +70,6 @@ export function normalizeOptions(
   return normalizeOptionsInternal(loader, options, url);
 }
 
-/**
- * Gets the current fetch function from options and context
- * @param options
- * @param context
- */
-export function getFetchFunction(
-  options?: LoaderOptions,
-  context?: Omit<LoaderContext, 'fetch'> & Partial<Pick<LoaderContext, 'fetch'>>
-) {
-  const globalOptions = getGlobalLoaderOptions();
-
-  const fetchOptions = options || globalOptions;
-
-  // options.fetch can be a function
-  if (typeof fetchOptions.fetch === 'function') {
-    return fetchOptions.fetch;
-  }
-
-  // options.fetch can be an options object
-  if (isObject(fetchOptions.fetch)) {
-    return (url) => fetchFile(url, fetchOptions);
-  }
-
-  // else refer to context (from parent loader) if available
-  if (context?.fetch) {
-    return context?.fetch;
-  }
-
-  // else return the default fetch function
-  return fetchFile;
-}
-
 // VALIDATE OPTIONS
 
 /**
@@ -211,11 +184,14 @@ function mergeNestedFields(mergedOptions, options) {
   }
 }
 
-// Harvest information from the url
-// TODO - baseUri should be a directory, i.e. remove file component from baseUri
-// TODO - extract extension?
-// TODO - extract query parameters?
-// TODO - should these be injected on context instead of options?
+/**
+ * Harvest information from the url
+ * @deprecated This is mainly there to support a hack in the GLTFLoader
+ * TODO - baseUri should be a directory, i.e. remove file component from baseUri
+ * TODO - extract extension?
+ * TODO - extract query parameters?
+ * TODO - should these be injected on context instead of options?
+ */
 function addUrlOptions(options, url?: string) {
   if (url && !('baseUri' in options)) {
     options.baseUri = url;

package/src/lib/progress/fetch-progress.ts

@@ -20,8 +20,8 @@ export default async function fetchProgress(
     return response;
   }
   const contentLength = response.headers.get('content-length') || 0;
-  const totalBytes = contentLength && parseInt(contentLength);
-  if (!(contentLength > 0)) {
+  const totalBytes = contentLength ? parseInt(contentLength) : 0;
+  if (!(totalBytes > 0)) {
     return response;
   }
   // Currently override only implemented in browser

package/src/lib/utils/log.ts

@@ -0,0 +1,4 @@
+// loaders.gl, MIT license
+import {Log} from '@probe.gl/log';
+
+export const log = new Log({id: 'loaders.gl'});