@lmzhen/dsh-tool-skill-manage 0.3.82 → 0.4.0

package/README.md

@@ -1,36 +1,31 @@
-# @deepseek-ai/dsh-tool-skill-manage
+# @lmzhen/dsh-tool-skill-manage
 
-Model-facing skill_manage tool
+Model-facing `skill_manage` tool: it exposes skill-library mutations to the model and
+routes them through the evolution approval seam when one is mounted; it owns neither the
+library nor its lifecycle rules.
 
-## Model Experience
+## Model surface
 
-### skill_manage tool surface
-
-#### What the model sees
-
-The model sees the `skill_manage` tool schema and tool results containing success or validation messages.
-
-#### Token effect
-
-Adds the `skill_manage` tool schema to the request catalog; result tokens scale with returned messages.
-
-#### KV Cache effect
-
-Tool schema is prefix-stable. Skill writes do not alter the current request prompt; catalog invalidation affects the next request.
+- **Model-visible:** the `skill_manage` tool schema and its success/validation messages; result tokens scale with what is returned.
+- **Prompt prefix / KV cache:** the tool schema is prefix-stable, and skill writes do not alter the current request prompt; catalog invalidation affects the next request; family rules: `packages/README.md` §"Model-visible prompt prefix and the KV cache".
+- **Mount it?** yes — the `tool-skill-manage` row, carried by the `evolution-all` and one-click `evolution-preset` bundles and the Evolution agent preset delta.
 
 ## Safety model
 
 ### Approval seam
 
-Mutations (create/edit/update/patch/delete/write_file/remove_file/restructure) pass through the evolution approval seam when `evolution-approval` is mounted; approved/staged writes are replayed by the registered runner with the library origin preserved.
-
-### pin/unpin: explicit exception (0.3.18, E-70)
+Mutations (create/edit/update/patch/delete/write_file/remove_file/restructure) pass through the evolution approval seam when `evolution-approval` is mounted; approved/staged writes are replayed by the registered runner with the library origin preserved. The missing-required-argument pre-check runs BEFORE that boundary — one shared table and one refusal builder with `executeCore`, so the stage boundary and the execution check cannot diverge: a write that cannot execute is refused, never staged for approval.
 
-`pin` and `unpin` are deliberately **outside** the approval seam. Pinning only lifts/restores the curator-lifecycle freeze — it changes a lifecycle flag, never content — and is fully reversible by the same tool. Routing it through `policy:'ask'` would let a staged-but-never-approved request hold the library in a pinned state invisibly. Tradeoff accepted: no approval on a lifecycle-flag flip; if product policy changes, pin/unpin should be wired into the same staging path as `patch`.
+### pin/unpin: explicit exception
 
-## Known Limitations and Deferred Work
+`pin` and `unpin` are deliberately **outside** the approval seam. Pinning only lifts/restores the curator-lifecycle freeze (a lifecycle flag, never content) and is fully reversible by the same tool. Routing it through `policy:'ask'` would let a staged-but-never-approved request hold the library in a pinned state invisibly. Tradeoff accepted: no approval on a lifecycle-flag flip; if product policy changes, pin/unpin should be wired into the same staging path as `patch`.
 
+## Known limitations
 
 - No known durable consumer gaps at this time. Runtime contracts are covered by package and boundary tests.
 
 **Runtime invariant:** No companion is published. The platform auto-assembles nothing and the family mounts no `<pkg>/invariant` cordis row, so a companion here would never execute (v37 S2.1 / I-3).
+
+## Notes and history
+
+- pin/unpin: explicit exception (0.3.18, E-70)

package/lib/index.js

@@ -44,6 +44,18 @@ const Config = z.object({
 function policySnapshotOf(source) {
 	return source?.get?.();
 }
+function missingRequiredArgs(args) {
+	const action = args.action;
+	const scalarArgs = args;
+	return (action === void 0 || typeof action !== "string" || !Object.hasOwn(SKILL_ACTION_REQUIRED_FIELDS, action) ? [] : SKILL_ACTION_REQUIRED_FIELDS[action] ?? []).filter((field) => scalarArgs[field] === void 0 || scalarArgs[field] === null);
+}
+function missingArgsRefusal(action, missing) {
+	return {
+		ok: false,
+		message: `skill_manage ${action} requires ${missing.join(", ")}; the tool description lists the arguments per action.`,
+		skills: []
+	};
+}
 function apply(ctx, rawConfig = {}) {
 	const systemPrompt = ctx.get("systemPrompt");
 	if (systemPrompt) ctx.effect(() => systemPrompt.section({
@@ -158,13 +170,8 @@ function apply(ctx, rawConfig = {}) {
 				skills: []
 			};
 		}
-		const REQUIRED_ARGS = SKILL_ACTION_REQUIRED_FIELDS;
-		const missing = (action === void 0 || typeof action !== "string" || !Object.hasOwn(REQUIRED_ARGS, action) ? [] : REQUIRED_ARGS[action] ?? []).filter((field) => scalarArgs[field] === void 0 || scalarArgs[field] === null);
-		if (missing.length > 0) return {
-			ok: false,
-			message: `skill_manage ${action} requires ${missing.join(", ")}; the tool description lists the arguments per action.`,
-			skills: []
-		};
+		const missing = missingRequiredArgs(args);
+		if (missing.length > 0) return missingArgsRefusal(action, missing);
 		let feedbackLines = [];
 		const stagedAnchor = typeof args.staged_from_sha256 === "string" && args.staged_from_sha256 !== "" ? args.staged_from_sha256 === "absent" ? { absent: true } : { sha256: args.staged_from_sha256 } : void 0;
 		if ((action === "create" || action === "edit" || action === "update") && args.content) {
@@ -238,12 +245,20 @@ function apply(ctx, rawConfig = {}) {
 			return `- ${summary.name} | ${record?.state ?? "active"} | use:${record?.use_count ?? 0} view:${record?.view_count ?? 0} patch:${record?.patch_count ?? 0}${quality}${protection}`;
 		});
 		const contents = /* @__PURE__ */ new Map();
+		let excludedBodies = 0;
 		for (let offset = 0; offset < list.length; offset += 16) await Promise.all(list.slice(offset, offset + 16).map(async (summary) => {
 			const body = await library.read(summary.name).catch(() => null);
-			contents.set(summary.name, body ?? "");
+			if (body === null || body.trim() === "") {
+				excludedBodies += 1;
+				return;
+			}
+			contents.set(summary.name, body);
 		}));
-		const groups = computeDedupGroups({ contents });
+		const dedup = computeDedupGroups({ contents });
+		const groups = dedup.groups;
 		const dedupLines = groups.slice(0, MAX_DEDUP_GROUPS_IN_REVIEW).map((group) => `- ${group.join(" ~ ")}`);
+		if (dedup.truncated) dedupLines.push(`- note: dedup scan truncated at the pair-comparison budget (${groups.length} group(s) so far); groups may be incomplete`);
+		const excludedLine = excludedBodies === 0 ? "" : `\n${excludedBodies} skill bodies were unreadable/empty and excluded from dedup grouping.`;
 		const warned = list.filter((summary) => warnedFlag(summary.name)).map((summary) => summary.name);
 		const warningLine = warned.length === 0 ? "" : `\nWarning skills (${warned.length}): ${warned.join(", ")} — low quality; consider consolidating them before authoring new skills.`;
 		return [
@@ -251,6 +266,7 @@ function apply(ctx, rawConfig = {}) {
 			"",
 			...lines,
 			...dedupLines,
+			...excludedBodies > 0 ? [excludedLine] : [],
 			warningLine
 		].join("\n");
 	}
@@ -337,6 +353,8 @@ function apply(ctx, rawConfig = {}) {
 					skills: []
 				};
 			}
+			const missing = missingRequiredArgs(args);
+			if (missing.length > 0) return missingArgsRefusal(args.action, missing);
 			const approval = ctx.get("evolutionApproval");
 			if (approval && args.action !== "list" && args.action !== "review" && args.action !== "pin" && args.action !== "unpin") {
 				if ((args.action === "update" || args.action === "edit") && typeof args.name === "string" && args.name !== "") {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-tool-skill-manage",
   "description": "Model-facing skill_manage tool (community build)",
-  "version": "0.3.82",
+  "version": "0.4.0",
   "publishConfig": {
     "access": "public"
   },
@@ -27,24 +27,24 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.82",
-    "@lmzhen/dsh-evolution-core": "^0.3.82"
+    "@lmzhen/dsh-evolution-approval": "^0.4.0",
+    "@lmzhen/dsh-evolution-core": "^0.4.0"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
     "@deepseek-ai/dsh-skill": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-system-prompt": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.5-rc.2",
-    "@lmzhen/dsh-evolution-io": "^0.3.82",
-    "@lmzhen/dsh-skill-usage": "^0.3.82"
+    "@lmzhen/dsh-evolution-io": "^0.4.0",
+    "@lmzhen/dsh-skill-usage": "^0.4.0"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent-loop-testkit": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-skill": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-system-prompt": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.5-rc.2",
-    "@lmzhen/dsh-evolution-core": "^0.3.82",
-    "@lmzhen/dsh-evolution-io": "^0.3.82",
-    "@lmzhen/dsh-skill-usage": "^0.3.82"
+    "@lmzhen/dsh-evolution-core": "^0.4.0",
+    "@lmzhen/dsh-evolution-io": "^0.4.0",
+    "@lmzhen/dsh-skill-usage": "^0.4.0"
   }
 }