@lmzhen/dsh-tool-skill-manage 0.3.65 → 0.3.67

package/lib/index.js

@@ -1,7 +1,7 @@
 import { effectiveSessionPolicy } from "@lmzhen/dsh-evolution-approval";
 import z from "@deepseek-ai/schemastery";
 import { defineTool } from "@deepseek-ai/dsh-tools";
-import { DEFAULT_SKILL_LIMITS, DSH_AUTHORING_STANDARDS, SKILLS_GUIDANCE, SkillLibrary, authoringFeedback, clampedNumber, computeDedupGroups, evolutionIoAdapter, parseFrontmatter, resolveOrigins, resolveSkillsRoot } from "@lmzhen/dsh-evolution-core";
+import { DEFAULT_SKILL_LIMITS, DSH_AUTHORING_STANDARDS, SKILLS_GUIDANCE, SkillLibrary, authoringFeedback, clampedNumber, computeDedupGroups, contentHash, evolutionIoAdapter, parseFrontmatter, resolveOrigins, resolveSkillsRoot } from "@lmzhen/dsh-evolution-core";
 //#region lib/types/index.js
 /**
 * Model-facing skill_manage tool over ctx.evolutionIo + ctx.skillUsage.
@@ -77,7 +77,33 @@ function apply(ctx, rawConfig = {}) {
 				skills: list.map((s) => s.name)
 			};
 		}
+		const scalarArgs = args;
+		for (const field of [
+			"name",
+			"content",
+			"old_string",
+			"new_string",
+			"file_path",
+			"file_content",
+			"absorbed_into"
+		]) {
+			const value = scalarArgs[field];
+			if (value !== void 0 && value !== null && typeof value !== "string") return {
+				ok: false,
+				message: `skill_manage: "${field}" must be a string (got ${typeof value}); refusing the write.`,
+				skills: []
+			};
+		}
 		let feedbackLines = [];
+		if ((action === "edit" || action === "update") && typeof args.staged_from_sha256 === "string" && args.staged_from_sha256 !== "") {
+			const currentContent = await library.read(name).catch(() => null);
+			const actual = contentHash(currentContent ?? "");
+			if (currentContent === null || actual !== args.staged_from_sha256) return {
+				ok: false,
+				message: `Skill "${name}" changed after this write was staged (content ${currentContent === null ? "no longer exists" : "hash mismatch"}); refusing to replay the stale snapshot. Re-apply the edit to stage a fresh copy.`,
+				skills: []
+			};
+		}
 		if ((action === "create" || action === "edit" || action === "update") && args.content) {
 			const parsed = parseFrontmatter(args.content);
 			if (parsed) {
@@ -99,9 +125,16 @@ function apply(ctx, rawConfig = {}) {
 		else if (action === "remove_file") result = await library.removeSupportFile(name, args.file_path ?? "", origin);
 		else if (action === "restructure") {
 			const moves = Array.isArray(args.restructure) ? args.restructure : [];
-			result = await library.restructure(name, moves.map((move) => ({
-				heading: move.heading ?? "",
-				toFile: move.to_file ?? ""
+			if (moves.some((move) => {
+				const raw = move;
+				return raw === null || typeof raw !== "object";
+			})) result = {
+				ok: false,
+				message: "Every entry of restructure must be an object with heading and to_file."
+			};
+			else result = await library.restructure(name, moves.map((move) => ({
+				heading: typeof move.heading === "string" ? move.heading : "",
+				toFile: typeof move.to_file === "string" ? move.to_file : ""
 			})), origin);
 		} else if (action === "pin") result = await library.setPinned(name, true, origin);
 		else if (action === "unpin") result = await library.setPinned(name, false, origin);
@@ -224,6 +257,10 @@ function apply(ctx, rawConfig = {}) {
 			const sessionPolicy = effectiveSessionPolicy(ctx, exec.agent?.session);
 			const approval = ctx.get("evolutionApproval");
 			if (approval && args.action !== "list" && args.action !== "review" && args.action !== "pin" && args.action !== "unpin") {
+				if ((args.action === "update" || args.action === "edit") && typeof args.name === "string" && args.name !== "") {
+					const stageCurrent = await library.read(args.name).catch(() => null);
+					if (stageCurrent !== null) args.staged_from_sha256 = contentHash(stageCurrent);
+				}
 				const decision = await approval.request({
 					kind: "skill",
 					summary: `skill ${args.action ?? "?"} ${args.name ?? ""}`.trim(),

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-tool-skill-manage",
   "description": "Model-facing skill_manage tool (community build)",
-  "version": "0.3.65",
+  "version": "0.3.67",
   "publishConfig": {
     "access": "public"
   },
@@ -31,24 +31,24 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.65",
-    "@lmzhen/dsh-evolution-core": "^0.3.65"
+    "@lmzhen/dsh-evolution-approval": "^0.3.67",
+    "@lmzhen/dsh-evolution-core": "^0.3.67"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-system-prompt": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-io": "^0.3.65",
-    "@lmzhen/dsh-skill-usage": "^0.3.65"
+    "@lmzhen/dsh-evolution-io": "^0.3.67",
+    "@lmzhen/dsh-skill-usage": "^0.3.67"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent-loop-testkit": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-system-prompt": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-core": "^0.3.65",
-    "@lmzhen/dsh-evolution-io": "^0.3.65",
-    "@lmzhen/dsh-skill-usage": "^0.3.65"
+    "@lmzhen/dsh-evolution-core": "^0.3.67",
+    "@lmzhen/dsh-evolution-io": "^0.3.67",
+    "@lmzhen/dsh-skill-usage": "^0.3.67"
   }
 }