@lmzhen/dsh-tool-skill-manage 0.3.16 → 0.3.18

package/README.md

@@ -18,6 +18,16 @@ Adds the `skill_manage` tool schema to the request catalog; result tokens scale
 
 Tool schema is prefix-stable. Skill writes do not alter the current request prompt; catalog invalidation affects the next request.
 
+## Safety model
+
+### Approval seam
+
+Mutations (create/edit/update/patch/delete/write_file/remove_file/restructure) pass through the evolution approval seam when `evolution-approval` is mounted; approved/staged writes are replayed by the registered runner with the library origin preserved.
+
+### pin/unpin: explicit exception (0.3.18, E-70)
+
+`pin` and `unpin` are deliberately **outside** the approval seam. Pinning only lifts/restores the curator-lifecycle freeze — it changes a lifecycle flag, never content — and is fully reversible by the same tool. Routing it through `policy:'ask'` would let a staged-but-never-approved request hold the library in a pinned state invisibly. Tradeoff accepted: no approval on a lifecycle-flag flip; if product policy changes, pin/unpin should be wired into the same staging path as `patch`.
+
 ## Known Limitations and Deferred Work
 
 

package/lib/index.js

@@ -1,6 +1,6 @@
 import z from "@deepseek-ai/schemastery";
 import { defineTool } from "@deepseek-ai/dsh-tools";
-import { DEFAULT_SKILL_LIMITS, DSH_AUTHORING_STANDARDS, SKILLS_GUIDANCE, SkillLibrary, authoringFeedback, computeDedupGroups, evolutionIoAdapter, parseFrontmatter, resolveOrigins } from "@lmzhen/dsh-evolution-core";
+import { DEFAULT_SKILL_LIMITS, DSH_AUTHORING_STANDARDS, SKILLS_GUIDANCE, SkillLibrary, authoringFeedback, computeDedupGroups, evolutionIoAdapter, parseFrontmatter, resolveOrigins, resolveSkillsRoot } from "@lmzhen/dsh-evolution-core";
 //#region lib/types/index.js
 /**
 * Model-facing skill_manage tool over ctx.evolutionIo + ctx.skillUsage.
@@ -9,6 +9,13 @@ import { DEFAULT_SKILL_LIMITS, DSH_AUTHORING_STANDARDS, SKILLS_GUIDANCE, SkillLi
 * approved/staged background writes are replayed by the registered runner.
 * The skill library itself never hard-deletes: archive is the maximum
 * destructive action and every curator mutation is snapshot-reversible.
+*
+* 0.3.18 (E-70) — pin/unpin are deliberately OUTSIDE the approval seam:
+* pinning only lifts/restores the curator-lifecycle freeze and is fully
+* reversible by the same tool; routing it through `policy:'ask'` would let a
+* staged-then-stale request hold the library in a pinned state invisibly.
+* The tradeoff (no approval on a lifecycle-flag flip) is accepted and
+* documented in the README Safety model section.
 * @module @lmzhen/dsh-tool-skill-manage
 */
 const name = "tool-skill-manage";
@@ -17,12 +24,15 @@ const inject = [
 	"skillUsage",
 	"evolutionIo"
 ];
+/** 0.3.18 (E-70): review output lists at most this many near-duplicate groups
+* (a cap, not a per-group limit) — the one named bound for the slice below. */
+const MAX_DEDUP_GROUPS_IN_REVIEW = 3;
 const Config = z.object({
 	root: z.string().default(""),
-	maxSkillNameLength: z.number().default(DEFAULT_SKILL_LIMITS.maxNameLength),
-	maxDescriptionLength: z.number().default(DEFAULT_SKILL_LIMITS.maxDescriptionLength),
-	maxSkillContentChars: z.number().default(DEFAULT_SKILL_LIMITS.maxSkillContentChars),
-	maxSkillFileBytes: z.number().default(DEFAULT_SKILL_LIMITS.maxSkillFileBytes),
+	maxSkillNameLength: z.number().min(1).default(DEFAULT_SKILL_LIMITS.maxNameLength),
+	maxDescriptionLength: z.number().min(1).default(DEFAULT_SKILL_LIMITS.maxDescriptionLength),
+	maxSkillContentChars: z.number().min(1).default(DEFAULT_SKILL_LIMITS.maxSkillContentChars),
+	maxSkillFileBytes: z.number().min(1).default(DEFAULT_SKILL_LIMITS.maxSkillFileBytes),
 	descriptionStrict: z.boolean().default(false)
 });
 /**
@@ -44,7 +54,7 @@ function apply(ctx, rawConfig = {}) {
 		text: SKILLS_GUIDANCE
 	}), "tool-skill-manage.skills-guidance");
 	const io = evolutionIoAdapter(() => ctx.evolutionIo.provider());
-	const library = new SkillLibrary(rawConfig.root || void 0, io, {
+	const library = new SkillLibrary(resolveSkillsRoot(rawConfig), io, {
 		maxNameLength: rawConfig.maxSkillNameLength ?? DEFAULT_SKILL_LIMITS.maxNameLength,
 		maxDescriptionLength: rawConfig.maxDescriptionLength ?? DEFAULT_SKILL_LIMITS.maxDescriptionLength,
 		maxSkillContentChars: rawConfig.maxSkillContentChars ?? DEFAULT_SKILL_LIMITS.maxSkillContentChars,
@@ -106,12 +116,9 @@ function apply(ctx, rawConfig = {}) {
 		if (result.ok) {
 			if (result.normalizedFrontmatterFields && result.normalizedFrontmatterFields.length > 0) feedbackLines.push(`frontmatter auto-quoted (YAML compatibility): ${result.normalizedFrontmatterFields.join(", ")}`);
 			const mutating = action !== "list" && action !== "review" && action !== "skip" && action !== "pin" && action !== "unpin";
-			if (name && action === "create") {
-				await ctx.skillUsage.ensureRecord(name);
-				if (origin !== "foreground") await ctx.skillUsage.markAgentCreated(name);
-			}
+			if (name && action === "create") await ctx.skillUsage.ensureRecordCreated(name, origin !== "foreground");
 			if (name && action === "delete") await ctx.skillUsage.markArchived(name);
-			else if (name && mutating && action !== "create") await ctx.skillUsage.record(name, "patch");
+			else if (name && mutating && action !== "create" && result.noop !== true) await ctx.skillUsage.record(name, "patch");
 		}
 		return {
 			ok: result.ok,
@@ -128,7 +135,7 @@ function apply(ctx, rawConfig = {}) {
 			return `- ${summary.name} | ${record?.state ?? "active"} | use:${record?.use_count ?? 0} view:${record?.view_count ?? 0} patch:${record?.patch_count ?? 0}${quality}${summary.protectedBy ? ` [${summary.protectedBy}]` : ""}`;
 		});
 		const groups = computeDedupGroups({ contents: new Map(await Promise.all(list.map(async (summary) => [summary.name, await library.read(summary.name) ?? ""]))) });
-		const dedupLines = groups.slice(0, 3).map((group) => `- ${group.join(" ~ ")}`);
+		const dedupLines = groups.slice(0, MAX_DEDUP_GROUPS_IN_REVIEW).map((group) => `- ${group.join(" ~ ")}`);
 		const warned = list.filter((summary) => report.get(summary.name)?.quality_warn === true).map((summary) => summary.name);
 		const warningLine = warned.length === 0 ? "" : `\nWarning skills (${warned.length}): ${warned.join(", ")} — low quality; consider consolidating them before authoring new skills.`;
 		return [
@@ -231,7 +238,7 @@ function apply(ctx, rawConfig = {}) {
 					ok: true,
 					message: decision.message,
 					skills: [],
-					pending_id: decision.pendingId ?? ""
+					...decision.pendingId !== void 0 ? { pending_id: decision.pendingId } : {}
 				};
 			}
 			return await executeCore(args, libraryOrigin);

package/lib/types/index.d.ts

@@ -5,6 +5,13 @@
  * approved/staged background writes are replayed by the registered runner.
  * The skill library itself never hard-deletes: archive is the maximum
  * destructive action and every curator mutation is snapshot-reversible.
+ *
+ * 0.3.18 (E-70) — pin/unpin are deliberately OUTSIDE the approval seam:
+ * pinning only lifts/restores the curator-lifecycle freeze and is fully
+ * reversible by the same tool; routing it through `policy:'ask'` would let a
+ * staged-then-stale request hold the library in a pinned state invisibly.
+ * The tradeoff (no approval on a lifecycle-flag flip) is accepted and
+ * documented in the README Safety model section.
  * @module @deepseek-ai/dsh-tool-skill-manage
  */
 import type { Context } from '@deepseek-ai/cordis';

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-tool-skill-manage",
   "description": "Model-facing skill_manage tool (community build)",
-  "version": "0.3.16",
+  "version": "0.3.18",
   "publishConfig": {
     "access": "public"
   },
@@ -33,21 +33,21 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.3.16"
+    "@lmzhen/dsh-evolution-core": "^0.3.18"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-io": "^0.3.16",
-    "@lmzhen/dsh-skill-usage": "^0.3.16"
+    "@lmzhen/dsh-evolution-io": "^0.3.18",
+    "@lmzhen/dsh-skill-usage": "^0.3.18"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent-loop-testkit": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-core": "^0.3.16",
-    "@lmzhen/dsh-evolution-io": "^0.3.16",
-    "@lmzhen/dsh-skill-usage": "^0.3.16"
+    "@lmzhen/dsh-evolution-core": "^0.3.18",
+    "@lmzhen/dsh-evolution-io": "^0.3.18",
+    "@lmzhen/dsh-skill-usage": "^0.3.18"
   }
 }