@lmzhen/dsh-tool-skill-manage 0.1.0-rc.8 → 0.1.0

package/lib/index.js

@@ -1,6 +1,6 @@
 import z from "@deepseek-ai/schemastery";
 import { defineTool } from "@deepseek-ai/dsh-tools";
-import { DEFAULT_SKILL_LIMITS, DSH_AUTHORING_STANDARDS, SkillLibrary, evolutionIoAdapter } from "@lmzhen/dsh-evolution-core";
+import { DEFAULT_SKILL_LIMITS, DSH_AUTHORING_STANDARDS, SKILLS_GUIDANCE, SkillLibrary, authoringFeedback, computeDedupGroups, evolutionIoAdapter, parseFrontmatter, resolveOrigins } from "@lmzhen/dsh-evolution-core";
 //#region lib/types/index.js
 /**
 * Model-facing skill_manage tool over ctx.evolutionIo + ctx.skillUsage.
@@ -22,19 +22,49 @@ const Config = z.object({
 	maxSkillNameLength: z.number().default(DEFAULT_SKILL_LIMITS.maxNameLength),
 	maxDescriptionLength: z.number().default(DEFAULT_SKILL_LIMITS.maxDescriptionLength),
 	maxSkillContentChars: z.number().default(DEFAULT_SKILL_LIMITS.maxSkillContentChars),
-	maxSkillFileBytes: z.number().default(DEFAULT_SKILL_LIMITS.maxSkillFileBytes)
+	maxSkillFileBytes: z.number().default(DEFAULT_SKILL_LIMITS.maxSkillFileBytes),
+	descriptionStrict: z.boolean().default(false)
 });
+/**
+* The requesting session's effective approval policy, mirroring
+* `dsh-user-approval` (override ?? configured default). Returns undefined when
+* the approval service is not mounted or no session is available — callers
+* keep their previous behavior.
+*/
+function effectiveSessionPolicy(ctx, session) {
+	const approval = ctx.get("approval");
+	if (!approval || session === void 0) return void 0;
+	return approval.overrideOf(session) ?? approval.config.policy ?? "ask";
+}
 function apply(ctx, rawConfig = {}) {
+	const systemPrompt = ctx.get("systemPrompt");
+	if (systemPrompt) ctx.effect(() => systemPrompt.section({
+		name: "evolution-skills-guidance",
+		order: 900,
+		text: SKILLS_GUIDANCE
+	}), "tool-skill-manage.skills-guidance");
 	const io = evolutionIoAdapter(() => ctx.evolutionIo.provider());
 	const library = new SkillLibrary(rawConfig.root || void 0, io, {
 		maxNameLength: rawConfig.maxSkillNameLength ?? DEFAULT_SKILL_LIMITS.maxNameLength,
 		maxDescriptionLength: rawConfig.maxDescriptionLength ?? DEFAULT_SKILL_LIMITS.maxDescriptionLength,
 		maxSkillContentChars: rawConfig.maxSkillContentChars ?? DEFAULT_SKILL_LIMITS.maxSkillContentChars,
 		maxSkillFileBytes: rawConfig.maxSkillFileBytes ?? DEFAULT_SKILL_LIMITS.maxSkillFileBytes
+	}, (event) => {
+		ctx.emit("evolution/skill-mutated", event);
 	});
 	async function executeCore(args, origin = "foreground") {
 		const action = args.action;
 		const name = args.name ?? "";
+		if (action === "review") return {
+			ok: true,
+			message: await buildSkillReviewText(),
+			skills: []
+		};
+		if (action === "skip") return {
+			ok: true,
+			message: "Skipped; no skill changes this pass.",
+			skills: []
+		};
 		if (action === "list") {
 			const list = await library.list();
 			return {
@@ -43,40 +73,77 @@ function apply(ctx, rawConfig = {}) {
 				skills: list.map((s) => s.name)
 			};
 		}
+		let feedbackLines = [];
+		if ((action === "create" || action === "edit" || action === "update") && args.content) {
+			const parsed = parseFrontmatter(args.content);
+			if (parsed) {
+				const feedback = authoringFeedback(parsed.frontmatter);
+				feedbackLines = feedback.lines;
+				if (rawConfig.descriptionStrict === true && feedback.over60) return {
+					ok: false,
+					message: `Authoring check: description ${feedback.descriptionChars}/60 characters exceeds the strict bar; tighten it to <=60 or set descriptionStrict=false.`,
+					skills: []
+				};
+			}
+		}
 		let result;
 		if (action === "create") result = await library.create(name, args.content ?? "", origin);
-		else if (action === "edit" || action === "update") result = await library.update(name, args.content ?? "");
-		else if (action === "patch") result = await library.patch(name, args.old_string ?? "", args.new_string ?? "", args.file_path ?? "", args.replace_all === true);
-		else if (action === "delete") result = await library.archive(name, args.absorbed_into ?? "");
-		else if (action === "write_file") result = await library.writeSupportFile(name, args.file_path ?? "", args.file_content ?? "");
-		else if (action === "remove_file") result = await library.removeSupportFile(name, args.file_path ?? "");
+		else if (action === "edit" || action === "update") result = await library.update(name, args.content ?? "", origin);
+		else if (action === "patch") result = await library.patch(name, args.old_string ?? "", args.new_string ?? "", args.file_path ?? "", args.replace_all === true, origin);
+		else if (action === "delete") result = await library.archive(name, args.absorbed_into ? { absorbedInto: args.absorbed_into } : {});
+		else if (action === "write_file") result = await library.writeSupportFile(name, args.file_path ?? "", args.file_content ?? "", origin);
+		else if (action === "remove_file") result = await library.removeSupportFile(name, args.file_path ?? "", origin);
+		else if (action === "pin") result = await library.setPinned(name, true, origin);
+		else if (action === "unpin") result = await library.setPinned(name, false, origin);
 		else result = {
 			ok: false,
 			message: `Unknown action "${action}".`
 		};
 		if (result.ok) {
-			if (name && action === "create" && origin === "background_review") await ctx.skillUsage.markAgentCreated(name);
-			if (name && action !== "list") await ctx.skillUsage.record(name, "patch");
-			ctx.emit("evolution/skill-mutated", {
-				action: action ?? "?",
-				name,
-				...result.path && action === "delete" ? { archivedPath: result.path } : result.path ? { filePath: result.path } : {}
-			});
+			const mutating = action !== "list" && action !== "review" && action !== "skip" && action !== "pin" && action !== "unpin";
+			if (name && action === "create") {
+				await ctx.skillUsage.ensureRecord(name);
+				if (origin !== "foreground") await ctx.skillUsage.markAgentCreated(name);
+			}
+			if (name && action === "delete") await ctx.skillUsage.markArchived(name);
+			else if (name && mutating && action !== "create") await ctx.skillUsage.record(name, "patch");
 		}
 		return {
 			ok: result.ok,
-			message: result.message,
+			message: result.ok && feedbackLines.length > 0 ? `${result.message}\n\nAuthoring check:\n${feedbackLines.map((line) => `- ${line}`).join("\n")}` : result.message,
 			skills: []
 		};
 	}
+	async function buildSkillReviewText() {
+		const list = await library.list();
+		const report = await ctx.skillUsage.report();
+		const lines = list.map((summary) => {
+			const record = report.get(summary.name);
+			const quality = record?.quality_score !== void 0 ? ` quality:${record.quality_score.toFixed(2)}${record.quality_warn ? "⚠" : ""}` : "";
+			return `- ${summary.name} | ${record?.state ?? "active"} | use:${record?.use_count ?? 0} view:${record?.view_count ?? 0} patch:${record?.patch_count ?? 0}${quality}${summary.protectedBy ? ` [${summary.protectedBy}]` : ""}`;
+		});
+		const groups = computeDedupGroups({ contents: new Map(await Promise.all(list.map(async (summary) => [summary.name, await library.read(summary.name) ?? ""]))) });
+		const dedupLines = groups.slice(0, 3).map((group) => `- ${group.join(" ~ ")}`);
+		const warned = list.filter((summary) => report.get(summary.name)?.quality_warn === true).map((summary) => summary.name);
+		const warningLine = warned.length === 0 ? "" : `\nWarning skills (${warned.length}): ${warned.join(", ")} — low quality; consider consolidating them before authoring new skills.`;
+		return [
+			list.length === 0 ? "No skills yet. Create one with action=create, or it is safe to author a new class-level umbrella." : `Skills: ${list.length} total. Below each name: state, use/view/patch counts, quality (0-1, ⚠ = low) and protection.${groups.length > 0 ? `\n\nNear-duplicate groups (${groups.length}):` : ""}`,
+			"",
+			...lines,
+			...dedupLines,
+			warningLine
+		].join("\n");
+	}
 	ctx.tools.register(defineTool({
 		name: "skill_manage",
-		description: "Manage reusable skills. create/edit take full SKILL.md content; patch applies old_string -> new_string; delete archives to .archive. Protected bundled/hub skills reject mutation; pinned skills reject delete only. Prefer patching an umbrella over creating narrow skills. Created/edited SKILL.md MUST start with YAML frontmatter (a name/description block), or creation is rejected. " + DSH_AUTHORING_STANDARDS,
+		description: "Manage reusable skills. review returns the library review text (state/usage/quality per skill); list returns names only; create/edit take full SKILL.md content; patch applies old_string -> new_string; delete archives to .archive; pin protects a skill from deletion, background review, and the lifecycle (pin/unpin are never allowed from a background review — foreground and delegated subagents may). Protected bundled/hub skills reject any mutation; pinned skills reject deletion and are read-only to the background review.Prefer patching an umbrella over creating narrow skills. Created/edited SKILL.md MUST start with YAML frontmatter (a name/description block), or creation is rejected. " + DSH_AUTHORING_STANDARDS,
 		parameters: {
 			action: {
 				type: "string",
 				required: true,
 				enum: [
+					"review",
+					"list",
 					"create",
 					"edit",
 					"update",
@@ -84,7 +151,9 @@ function apply(ctx, rawConfig = {}) {
 					"delete",
 					"write_file",
 					"remove_file",
-					"list"
+					"skip",
+					"pin",
+					"unpin"
 				]
 			},
 			name: { type: "string" },
@@ -124,17 +193,22 @@ function apply(ctx, rawConfig = {}) {
 		},
 		isConcurrencySafe: () => false,
 		async execute(args, exec) {
-			const origin = exec.agent?.session.header.origin === "subagent" ? "background_review" : "foreground";
+			const origins = resolveOrigins(exec.agent?.session.header.origin);
+			const reviewOrigin = origins.approval;
+			const libraryOrigin = origins.library;
+			const sessionPolicy = effectiveSessionPolicy(ctx, exec.agent?.session);
 			const approval = ctx.get("evolutionApproval");
-			if (approval && args.action !== "list") {
+			if (approval && args.action !== "list" && args.action !== "review" && args.action !== "skip" && args.action !== "pin" && args.action !== "unpin") {
 				const decision = await approval.request({
 					kind: "skill",
 					summary: `skill ${args.action ?? "?"} ${args.name ?? ""}`.trim(),
 					args: {
 						operation: args,
-						origin
+						origin: reviewOrigin,
+						libraryOrigin
 					},
-					origin
+					origin: reviewOrigin,
+					...sessionPolicy !== void 0 ? { sessionPolicy } : {}
 				});
 				if (decision.action === "staged") return {
 					ok: true,
@@ -143,13 +217,13 @@ function apply(ctx, rawConfig = {}) {
 					pending_id: decision.pendingId ?? ""
 				};
 			}
-			return await executeCore(args, origin);
+			return await executeCore(args, libraryOrigin);
 		}
 	}));
 	ctx.inject(["evolutionApproval"], (approvalCtx) => {
 		const dispose = approvalCtx.evolutionApproval.registerRunner("skill", (args) => {
 			const wrapped = args ?? {};
-			return executeCore(wrapped.operation ?? {}, wrapped.origin ?? "background_review");
+			return executeCore(wrapped.operation ?? {}, wrapped.libraryOrigin ?? wrapped.origin ?? "background_review");
 		});
 		approvalCtx.effect(() => dispose, "tool-skill-manage.approval-runner");
 	});

package/lib/types/index.d.ts

@@ -18,6 +18,8 @@ export interface Config {
     maxDescriptionLength?: number;
     maxSkillContentChars?: number;
     maxSkillFileBytes?: number;
+    /** When true, create/update refuse a description over the 60-char authoring bar (default: advisory feedback only). */
+    descriptionStrict?: boolean;
 }
 export declare const Config: z<Config>;
 export declare function apply(ctx: Context, rawConfig?: Config): void;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-tool-skill-manage",
   "description": "Model-facing skill_manage tool (community build)",
-  "version": "0.1.0-rc.8",
+  "version": "0.1.0",
   "publishConfig": {
     "access": "public"
   },
@@ -33,21 +33,21 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.8"
+    "@lmzhen/dsh-evolution-core": "^0.1.0"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
-    "@deepseek-ai/dsh-invariants": "^0.1.0-rc.6",
-    "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.8",
-    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.8"
+    "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
+    "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
+    "@lmzhen/dsh-evolution-io": "^0.1.0",
+    "@lmzhen/dsh-skill-usage": "^0.1.0"
   },
   "devDependencies": {
-    "@deepseek-ai/dsh-agent-loop-testkit": "^0.1.0-rc.6",
-    "@deepseek-ai/dsh-invariants": "^0.1.0-rc.6",
-    "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
-    "@lmzhen/dsh-evolution-core": "^0.1.0-rc.8",
-    "@lmzhen/dsh-evolution-io": "^0.1.0-rc.8",
-    "@lmzhen/dsh-skill-usage": "^0.1.0-rc.8"
+    "@deepseek-ai/dsh-agent-loop-testkit": "^0.1.1-rc.2",
+    "@deepseek-ai/dsh-invariants": "^0.1.1-rc.2",
+    "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
+    "@lmzhen/dsh-evolution-core": "^0.1.0",
+    "@lmzhen/dsh-evolution-io": "^0.1.0",
+    "@lmzhen/dsh-skill-usage": "^0.1.0"
   }
 }