@lmzhen/dsh-tool-memory 0.1.0-rc.4 → 0.1.0-rc.41

package/lib/index.js

@@ -11,6 +11,33 @@ const inject = [
 	"systemPrompt",
 	"memory"
 ];
+/**
+* System-prompt memory guidance, aligned with Hermes `MEMORY_GUIDANCE`.
+* Reached by the model every turn, so it is the place to steer behavior: what
+* to save durably, what not to save, and how to phrase an entry. The tool
+* schema description (`MEMORY_TOOL_DESCRIPTION`) carries the complementary
+* operation-level guidance (add/replace/remove, batch, targets, when).
+*/
+const MEMORY_GUIDANCE = "You have durable memory across sessions. Save stable user preferences, environment facts, conventions, and tool quirks with the `memory` tool. The most valuable memory is one that stops the user correcting or reminding you again, so user preferences and recurring corrections outrank procedural task details.\nWrite entries as declarative facts, not instructions to yourself: \"User prefers concise responses\" (good); \"Always respond concisely\" (bad). Imperative phrasing is re-read as a directive in later sessions and can override the user’s current request.\nDo NOT save task progress, session outcomes, completed-work logs, PR/issue numbers, commit SHAs, or anything stale within a week — use `session_search` to recall past sessions instead. Reusable procedures belong in a skill, not memory.";
+/**
+* Tool-schema description for `memory`, aligned with Hermes `MEMORY_SCHEMA`.
+* Carries the operation-level guidance: how to batch, when to save, the
+* priority order, the target semantics, and what to skip. Reached only when
+* the model is choosing/using the tool, so it complements the always-on
+* `MEMORY_GUIDANCE` system prompt.
+*/
+const MEMORY_TOOL_DESCRIPTION = "Save durable facts to persistent memory that survive across sessions. Memory is injected into future turns, so keep entries compact and high-signal.\n\nHOW: make all changes in ONE call via an `operations` array (each item {action, content?, old_text?}). The batch applies atomically and the char limit is checked on the final result — so one call can remove/replace stale entries to free room AND add new ones. Use bare action/content/old_text only for a single lone change.\n\nWHEN: save proactively when the user states a preference, correction, or personal detail, or you learn a stable fact about their environment, conventions, or workflow. Priority: user preferences & corrections > environment facts > procedures. The best memory stops the user repeating themselves.\n\nTARGETS: \"user\" = who the user is (name, role, preferences, style). \"memory\" = your notes (environment, conventions, tool quirks, lessons).\n\nSKIP: trivial/obvious info, easily re-discovered facts, task progress, completed-work logs, temporary TODO state. To recall a past session use `session_search`, not memory. Reusable procedures belong in a skill, not memory.";
+/**
+* The requesting session's effective approval policy, mirroring
+* `dsh-user-approval` (override ?? configured default). Returns undefined when
+* the approval service is not mounted or no session is available — callers
+* keep their previous behavior.
+*/
+function effectiveSessionPolicy(ctx, session) {
+	const approval = ctx.get("approval");
+	if (!approval || session === void 0) return void 0;
+	return approval.overrideOf(session) ?? approval.config.policy ?? "ask";
+}
 const Config = z.object({
 	memoryEnabled: z.boolean().default(true),
 	entryPreviewChars: z.number().default(200)
@@ -21,7 +48,7 @@ async function apply(ctx, rawConfig) {
 	ctx.systemPrompt.section({
 		name: "evolution:memory-guidance",
 		order: 150,
-		text: "You have durable memory. Save stable user preferences and environment facts with the `memory` tool. Prefer one atomic `operations` batch."
+		text: MEMORY_GUIDANCE
 	});
 	ctx.systemPrompt.context({
 		name: "evolution:memory-snapshot",
@@ -45,7 +72,7 @@ async function apply(ctx, rawConfig) {
 	}
 	ctx.tools.register(defineTool({
 		name: "memory",
-		description: "Save durable facts to persistent memory. target \"user\" = who the user is; target \"memory\" = your notes. Use operations for atomic add/replace/remove. Save proactively; do not save task progress or one-off narratives.",
+		description: MEMORY_TOOL_DESCRIPTION,
 		parameters: {
 			target: {
 				type: "string",
@@ -121,6 +148,25 @@ async function apply(ctx, rawConfig) {
 		},
 		isConcurrencySafe: () => false,
 		async execute(args, exec) {
+			const conflict = (a) => {
+				if (a.facts === void 0 || a.content === void 0) return false;
+				return a.facts !== a.content;
+			};
+			if (Array.isArray(args.operations)) {
+				for (const op of args.operations) if (conflict(op)) return {
+					ok: false,
+					message: "Provide only one of facts or content per operation (same field); different values were given.",
+					entries: [],
+					chars: 0,
+					limit: 0
+				};
+			} else if (conflict(args)) return {
+				ok: false,
+				message: "Provide only one of facts or content (same field); different values were given.",
+				entries: [],
+				chars: 0,
+				limit: 0
+			};
 			const target = args.target === "user" ? "user" : "memory";
 			const normalized = Array.isArray(args.operations) ? {
 				target,
@@ -132,13 +178,15 @@ async function apply(ctx, rawConfig) {
 				old_text: args.old_text
 			};
 			const origin = exec.agent?.session.header.origin === "subagent" ? "background_review" : "foreground";
+			const sessionPolicy = effectiveSessionPolicy(ctx, exec.agent?.session);
 			const approval = ctx.get("evolutionApproval");
 			if (approval) {
 				const decision = await approval.request({
 					kind: "memory",
 					summary: `memory ${target} ${Array.isArray(args.operations) ? `${args.operations.length} ops` : args.action ?? "add"}`,
 					args: normalized,
-					origin
+					origin,
+					...sessionPolicy !== void 0 ? { sessionPolicy } : {}
 				});
 				if (decision.action === "staged") return {
 					ok: true,
@@ -158,4 +206,4 @@ async function apply(ctx, rawConfig) {
 	});
 }
 //#endregion
-export { Config, apply, inject, name };
+export { Config, MEMORY_GUIDANCE, MEMORY_TOOL_DESCRIPTION, apply, inject, name };

package/lib/types/index.d.ts

@@ -6,6 +6,22 @@ import type { Context } from '@deepseek-ai/cordis';
 import z from '@deepseek-ai/schemastery';
 export declare const name = "tool-memory";
 export declare const inject: string[];
+/**
+ * System-prompt memory guidance, aligned with Hermes `MEMORY_GUIDANCE`.
+ * Reached by the model every turn, so it is the place to steer behavior: what
+ * to save durably, what not to save, and how to phrase an entry. The tool
+ * schema description (`MEMORY_TOOL_DESCRIPTION`) carries the complementary
+ * operation-level guidance (add/replace/remove, batch, targets, when).
+ */
+export declare const MEMORY_GUIDANCE: string;
+/**
+ * Tool-schema description for `memory`, aligned with Hermes `MEMORY_SCHEMA`.
+ * Carries the operation-level guidance: how to batch, when to save, the
+ * priority order, the target semantics, and what to skip. Reached only when
+ * the model is choosing/using the tool, so it complements the always-on
+ * `MEMORY_GUIDANCE` system prompt.
+ */
+export declare const MEMORY_TOOL_DESCRIPTION: string;
 export interface Config {
     memoryEnabled?: boolean;
     /** Maximum characters of each memory entry echoed back in tool results. */

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-tool-memory",
   "description": "Model-facing memory tool and prompt context (community build)",
-  "version": "0.1.0-rc.4",
+  "version": "0.1.0-rc.41",
   "publishConfig": {
     "access": "public"
   },
@@ -39,15 +39,15 @@
     "@deepseek-ai/cordis": "^4.0.1",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-system-prompt": "^0.1.0-rc.6",
-    "@lmzhen/dsh-memory": "^0.1.0-rc.4",
-    "@lmzhen/dsh-memory-files": "^0.1.0-rc.4"
+    "@lmzhen/dsh-memory": "^0.1.0-rc.41",
+    "@lmzhen/dsh-memory-files": "^0.1.0-rc.41"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-invariants": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-tools": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-system-prompt": "^0.1.0-rc.6",
     "@deepseek-ai/dsh-agent-loop-testkit": "^0.1.0-rc.6",
-    "@lmzhen/dsh-memory": "^0.1.0-rc.4",
-    "@lmzhen/dsh-memory-files": "^0.1.0-rc.4"
+    "@lmzhen/dsh-memory": "^0.1.0-rc.41",
+    "@lmzhen/dsh-memory-files": "^0.1.0-rc.41"
   }
 }