@lmzhen/dsh-evolution-review 0.4.1 → 0.6.0

package/README.md

@@ -33,6 +33,10 @@ own, and the delivery mode lives on the `evolution-policy` row, not here.
 - `reviewToolAllow`: the allow-list review subagents are spawned with (default `[skill]`).
 - `reviewWakeInject` (default `true`): waking (`agent.followup`) delivery instead of the non-waking `agent.inject`.
 - `skillReviewTrigger` (`'cadence'` default, or `'completion'` / `'both'`): gates only the completion channel.
+- Deprecated names (G0/S0.3): `memoryInterval` and `skillInterval` are the legacy
+  spellings of the policy row's `reviewMemoryInterval` / `reviewSkillInterval`
+  (the snapshot shadows them in every shipped composition). Reading them still
+  works; writing them is refused, and both are removed in 0.7.0.
 
 ### Review delivery contract
 

package/lib/index.js

@@ -2,7 +2,7 @@ import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
 import { createUserMessage } from "@deepseek-ai/dsh-llm";
 import { SessionId } from "@deepseek-ai/dsh-session";
-import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_MEMORY_REVIEW_MODEL, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_LIMITS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_MODEL, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_SUBSTANTIVE_MIN_AGENT_CHARS, DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS, DEFAULT_SUBSTANTIVE_MIN_USER_CHARS, DEFAULT_USER_CHAR_LIMIT, MAX_TIMER_DELAY_MS, PROMPT_BUNDLE, advanceReview, assertSkillsRootAliasRetired, clampedNumber, clearReviewChannel, contentHash, evolutionIoAdapter, foldToolDispatches, foldTurn, markReviewChannel, newSkillLibrary, readDispatchSignal, redactSecrets, resolveOrigins, resolveRootConfig, reviewPrompt, sessionAudited, skillReadNameOf, sweepReviewChannelSessions, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_MEMORY_REVIEW_MODEL, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_LIMITS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_MODEL, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_SUBSTANTIVE_MIN_AGENT_CHARS, DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS, DEFAULT_SUBSTANTIVE_MIN_USER_CHARS, DEFAULT_USER_CHAR_LIMIT, MAX_TIMER_DELAY_MS, PARAM_NAMESPACES, PROMPT_BUNDLE, advanceReview, assertSkillsRootAliasRetired, clampedNumber, clearReviewChannel, contentHash, evolutionIoAdapter, foldToolDispatches, foldTurn, installParamSection, markReviewChannel, newSkillLibrary, policyStageLimits, readDispatchSignal, readNumberParam, redactSecrets, resolveOrigins, resolveRootConfig, reviewPrompt, sessionAudited, skillReadNameOf, sweepReviewChannelSessions, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 //#region lib/types/session-state.js
 /**
@@ -138,8 +138,8 @@ function clampReviewConfig(rawConfig, ctx) {
 		return result;
 	};
 	const config = Object.assign({}, rawConfig, {
-		memoryInterval: field("memoryInterval", rawConfig.memoryInterval, DEFAULT_REVIEW_MEMORY_INTERVAL, 1),
-		skillInterval: field("skillInterval", rawConfig.skillInterval, DEFAULT_REVIEW_SKILL_INTERVAL, 1),
+		memoryInterval: field("memoryInterval", readNumberParam(rawConfig, "reviewMemoryInterval"), DEFAULT_REVIEW_MEMORY_INTERVAL, 1),
+		skillInterval: field("skillInterval", readNumberParam(rawConfig, "reviewSkillInterval"), DEFAULT_REVIEW_SKILL_INTERVAL, 1),
 		reviewTimeoutMs: field("reviewTimeoutMs", rawConfig.reviewTimeoutMs, DEFAULT_REVIEW_TIMEOUT_MS, 1, MAX_TIMER_DELAY_MS),
 		reviewContextMessages: field("reviewContextMessages", rawConfig.reviewContextMessages, DEFAULT_REVIEW_CONTEXT_MESSAGES, 1),
 		reviewMessageChars: field("reviewMessageChars", rawConfig.reviewMessageChars, DEFAULT_REVIEW_MESSAGE_CHARS, 1),
@@ -149,12 +149,26 @@ function clampReviewConfig(rawConfig, ctx) {
 	if (clamped.length > 0) ctx.logger.warn(`dsh-evolution-review: ${clamped.join(", ")} provided an invalid value; falling back to the default`);
 	return config;
 }
-/** v30 REV-04/REV-02: read the policy snapshot off the (optional) policy
-* service through an `unknown` boundary — the Context augmentation types the
-* getter non-optionally, but at runtime the row can be absent. */
 function policySnapshotOf(source) {
 	return source?.get?.();
 }
+/** Namespace the review group's user-writable knobs live in (core's PARAM_NAMESPACES). */
+const REVIEW_SETTINGS_NAMESPACE = "evolution-review";
+/** Schema the platform validates the user layer against; defaults mirror the
+* core constants so an empty document resolves to today's behaviour. */
+const REVIEW_SETTINGS_SCHEMA = z.object({
+	reviewSkillInterval: z.number().min(1).default(DEFAULT_REVIEW_SKILL_INTERVAL),
+	reviewMemoryInterval: z.number().min(1).default(DEFAULT_REVIEW_MEMORY_INTERVAL),
+	skillReviewTrigger: z.union([
+		z.const("cadence"),
+		z.const("completion"),
+		z.const("both")
+	]).default(DEFAULT_SKILL_REVIEW_TRIGGER),
+	skillReviewCompletionMinToolCalls: z.number().min(1).default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS),
+	reviewEnabled: z.boolean().default(true),
+	reviewMode: z.union([z.const("subagent"), z.const("inject")]).default("inject"),
+	reviewWakeInject: z.boolean().default(true)
+});
 function apply(ctx, rawConfig = {}) {
 	if (!verifyPromptBundle(PROMPT_BUNDLE)) throw new Error("dsh-evolution prompt bundle integrity check failed; refusing to schedule review work");
 	const config = clampReviewConfig(rawConfig, ctx);
@@ -173,6 +187,30 @@ function apply(ctx, rawConfig = {}) {
 	const cadenceResetWarned = sessionState.add("cadenceResetWarned", /* @__PURE__ */ new Set());
 	let reviewInFlight = false;
 	const policy = () => ctx.get("evolutionPolicy")?.get();
+	const settingsBase = {
+		reviewSkillInterval: config.skillInterval,
+		reviewMemoryInterval: config.memoryInterval,
+		skillReviewTrigger: config.skillReviewTrigger ?? DEFAULT_SKILL_REVIEW_TRIGGER,
+		skillReviewCompletionMinToolCalls: config.skillReviewCompletionMinToolCalls,
+		reviewEnabled: config.reviewEnabled ?? true,
+		reviewMode: config.reviewMode ?? "inject",
+		reviewWakeInject: config.reviewWakeInject ?? true
+	};
+	const overrides = installParamSection(ctx, PARAM_NAMESPACES["evolution-review"] ?? "evolution-review", REVIEW_SETTINGS_SCHEMA, settingsBase, { warn: (message) => {
+		ctx.logger.warn("dsh-evolution-review: " + message);
+	} });
+	const params = () => {
+		const snapshot = policy();
+		return {
+			reviewSkillInterval: overrides.get("reviewSkillInterval") ?? snapshot?.reviewSkillInterval ?? config.skillInterval,
+			reviewMemoryInterval: overrides.get("reviewMemoryInterval") ?? snapshot?.reviewMemoryInterval ?? config.memoryInterval,
+			skillReviewTrigger: overrides.get("skillReviewTrigger") ?? config.skillReviewTrigger ?? DEFAULT_SKILL_REVIEW_TRIGGER,
+			skillReviewCompletionMinToolCalls: overrides.get("skillReviewCompletionMinToolCalls") ?? config.skillReviewCompletionMinToolCalls,
+			reviewEnabled: overrides.get("reviewEnabled") ?? config.reviewEnabled ?? true,
+			reviewMode: overrides.get("reviewMode") ?? snapshot?.reviewMode ?? config.reviewMode ?? "inject",
+			reviewWakeInject: overrides.get("reviewWakeInject") ?? config.reviewWakeInject ?? true
+		};
+	};
 	const schemaDefaults = Config["~standard"].validate({}).value;
 	const shadowedRowFields = [
 		"reviewMode",
@@ -191,7 +229,7 @@ function apply(ctx, rawConfig = {}) {
 			warnShadowed();
 		});
 	}
-	if ((policy()?.reviewMode ?? config.reviewMode) === "inject") ctx.logger.warn("dsh-evolution-review: reviewMode \"inject\" (default) runs the review in the parent session and emits NO evolution/plan-applied ledger entry — evolution-activity and evolution-replay stay empty in this mode (see the evolution-review README, \"Known Limitations and Deferred Work\"). Set reviewMode: \"subagent\" on the evolution-policy row to keep the audited plan path.");
+	if (params().reviewMode === "inject") ctx.logger.warn("dsh-evolution-review: reviewMode \"inject\" (default) runs the review in the parent session and emits NO evolution/plan-applied ledger entry — evolution-activity and evolution-replay stay empty in this mode (see the evolution-review README, \"Known Limitations and Deferred Work\"). Set reviewMode: \"subagent\" on the evolution-policy row to keep the audited plan path.");
 	const reviewStateLocks = sessionState.add("reviewStateLocks", /* @__PURE__ */ new Map());
 	async function withReviewStateLock(id, task) {
 		const next = (reviewStateLocks.get(id) ?? Promise.resolve()).catch(() => {}).then(task);
@@ -240,7 +278,7 @@ function apply(ctx, rawConfig = {}) {
 		}
 	}
 	async function runOnTurnEnd(session, event) {
-		if (!config.reviewEnabled) return;
+		if (!params().reviewEnabled) return;
 		if (session.header.origin === "subagent") return;
 		const agent = ctx.agents.get(session.id);
 		if (!agent) return;
@@ -272,8 +310,8 @@ function apply(ctx, rawConfig = {}) {
 				lastTurn: -1
 			};
 			advanced.kind = advanceReview(state, event.data.turn, signal, {
-				memoryInterval: snapshot?.reviewMemoryInterval ?? config.memoryInterval,
-				skillInterval: snapshot?.reviewSkillInterval ?? config.skillInterval,
+				memoryInterval: params().reviewMemoryInterval,
+				skillInterval: params().reviewSkillInterval,
 				substantiveMinToolCalls: snapshot?.substantiveMinToolCalls ?? DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS,
 				substantiveMinUserChars: snapshot?.substantiveMinUserChars ?? DEFAULT_SUBSTANTIVE_MIN_USER_CHARS,
 				substantiveMinAgentChars: snapshot?.substantiveMinAgentChars ?? DEFAULT_SUBSTANTIVE_MIN_AGENT_CHARS,
@@ -288,7 +326,7 @@ function apply(ctx, rawConfig = {}) {
 			const pendingKind = kind ?? pendingCadenceReviews.get(session.id) ?? void 0;
 			if (pendingKind !== void 0) {
 				pendingCadenceReviews.delete(session.id);
-				if ((policy()?.reviewMode ?? config.reviewMode) === "inject") {
+				if (params().reviewMode === "inject") {
 					if (!deliverMessage(agent, reviewPrompt(pendingKind), cadenceSummary(pendingKind), true)) {
 						pendingCadenceReviews.set(session.id, pendingKind);
 						return;
@@ -366,10 +404,10 @@ function apply(ctx, rawConfig = {}) {
 			return;
 		}
 		if (skipFire) return;
-		const trigger = config.skillReviewTrigger;
+		const trigger = params().skillReviewTrigger;
 		if (trigger !== "completion" && trigger !== "both") return;
 		if (completionInjected.has(session.id)) return;
-		if (!shouldCompletionReview(event.data.reason, cumulative, config.skillReviewCompletionMinToolCalls)) return;
+		if (!shouldCompletionReview(event.data.reason, cumulative, params().skillReviewCompletionMinToolCalls)) return;
 		completionInjected.add(session.id);
 		if (reviewInFlight) {
 			if (deferredFallbackReviews.length < DEFERRED_REVIEW_CAP) deferredFallbackReviews.push({
@@ -486,7 +524,7 @@ function apply(ctx, rawConfig = {}) {
 			ctx.logger.warn(`dsh-evolution-review: inbox coalescing failed (${error instanceof Error ? error.message : String(error)}) — delivering a fresh message instead`);
 		}
 		try {
-			if (config.reviewWakeInject && typeof wake.followup === "function") {
+			if (params().reviewWakeInject && typeof wake.followup === "function") {
 				wake.followup(message);
 				skipNextCadenceFire.set(agent.session.id, { afterTurn: lastTurnStart.get(agent.session.id) ?? -1 });
 			} else agent.inject(message);
@@ -560,7 +598,7 @@ function apply(ctx, rawConfig = {}) {
 		return hashes;
 	}
 	async function trySubagentReview(session, agent, kind, signal) {
-		if ((policy()?.reviewMode ?? config.reviewMode) === "inject") return false;
+		if (params().reviewMode === "inject") return false;
 		const subagents = ctx.get("subagents");
 		if (!subagents) return false;
 		if (reviewInFlight) {
@@ -904,6 +942,7 @@ function apply(ctx, rawConfig = {}) {
 				io: evolutionIoAdapter(() => io.provider()),
 				limits: {
 					...DEFAULT_SKILL_LIMITS,
+					...policyStageLimits(policySnapshot),
 					maxSkillContentChars: policySnapshot?.skillContentChars ?? DEFAULT_SKILL_LIMITS.maxSkillContentChars
 				},
 				ctx
@@ -1234,4 +1273,4 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars)
 	].join("\n");
 }
 //#endregion
-export { Config, REVIEW_OUTPUT_SCHEMA, apply, buildReviewRequest, clampReviewConfig, filterUnreadSkillOps, inject, name, renderToolResultLine, shouldCompletionReview, sweepDeadSessionEntries };
+export { Config, REVIEW_OUTPUT_SCHEMA, REVIEW_SETTINGS_NAMESPACE, REVIEW_SETTINGS_SCHEMA, apply, buildReviewRequest, clampReviewConfig, filterUnreadSkillOps, inject, name, renderToolResultLine, shouldCompletionReview, sweepDeadSessionEntries };

package/lib/types/index.d.ts

@@ -24,8 +24,12 @@ export interface Config {
      * row's value, which the plugin reports once at load (v37 P2-24). */
     reviewMode?: 'subagent' | 'inject';
     /** Shadowed by the policy snapshot in every shipped composition — configure
-     * `reviewMemoryInterval` on the `evolution-policy` row instead (v37 P2-24). */
+     * `reviewMemoryInterval` on the `evolution-policy` row instead (v37 P2-24).
+     * Deprecated alias (G0/S0.3): still readable, refused by writes; removed 0.7.0. */
     memoryInterval?: number;
+    /** Shadowed by the policy snapshot in every shipped composition — configure
+     * `reviewSkillInterval` on the `evolution-policy` row instead. Deprecated
+     * alias (G0/S0.3): still readable, refused by writes; removed 0.7.0. */
     skillInterval?: number;
     /**
      * Tools the one-shot review subagent may use. Only actually-existing tools
@@ -125,6 +129,30 @@ type ClampedReviewConfig = Config & {
     skillReviewCompletionMinToolCalls: number;
 };
 export declare function clampReviewConfig(rawConfig: Config, ctx: Context): ClampedReviewConfig;
+/** Namespace the review group's user-writable knobs live in (core's PARAM_NAMESPACES). */
+export declare const REVIEW_SETTINGS_NAMESPACE = "evolution-review";
+/** Review behaviour a user may change (G3/S3.1). Field names are the CANONICAL
+ * parameter ids from the registry, so the settings document, the params output,
+ * the doctor report and the cards all spell one name. */
+export interface ReviewSettings {
+    /** Activity units between skill-review injections. */
+    reviewSkillInterval: number;
+    /** Activity units between memory-review injections. */
+    reviewMemoryInterval: number;
+    /** Which channel may inject a skill review. */
+    skillReviewTrigger: 'cadence' | 'completion' | 'both';
+    /** Tool calls a task needs before the completion channel injects. */
+    skillReviewCompletionMinToolCalls: number;
+    /** Master switch for the review plugin. */
+    reviewEnabled: boolean;
+    /** Run the review in the parent session (inject) or on a subagent. */
+    reviewMode: 'subagent' | 'inject';
+    /** Deliver the deferred review as a waking follow-up message. */
+    reviewWakeInject: boolean;
+}
+/** Schema the platform validates the user layer against; defaults mirror the
+ * core constants so an empty document resolves to today's behaviour. */
+export declare const REVIEW_SETTINGS_SCHEMA: z<ReviewSettings>;
 export declare function apply(ctx: Context, rawConfig?: Config): void;
 /** Completion-channel decision: task finished normally AND the session is proven long. */
 export declare function shouldCompletionReview(reason: {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.4.1",
+  "version": "0.6.0",
   "publishConfig": {
     "access": "public"
   },
@@ -27,9 +27,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.4.1",
-    "@lmzhen/dsh-evolution-core": "^0.4.1",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.4.1"
+    "@lmzhen/dsh-evolution-approval": "^0.6.0",
+    "@lmzhen/dsh-evolution-core": "^0.6.0",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.6.0"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -37,8 +37,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.5-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.4.1",
-    "@lmzhen/dsh-evolution-policy": "^0.4.1"
+    "@lmzhen/dsh-evolution-state": "^0.6.0",
+    "@lmzhen/dsh-evolution-policy": "^0.6.0"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.5-rc.2",
@@ -48,10 +48,10 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.5-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.4.1",
-    "@lmzhen/dsh-evolution-core": "^0.4.1",
-    "@lmzhen/dsh-evolution-curator": "^0.4.1",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.4.1",
-    "@lmzhen/dsh-evolution-state": "^0.4.1"
+    "@lmzhen/dsh-evolution-approval": "^0.6.0",
+    "@lmzhen/dsh-evolution-core": "^0.6.0",
+    "@lmzhen/dsh-evolution-curator": "^0.6.0",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.6.0",
+    "@lmzhen/dsh-evolution-state": "^0.6.0"
   }
 }