@lmzhen/dsh-evolution-review 0.4.0 → 0.5.0

package/lib/index.js

@@ -2,7 +2,7 @@ import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
 import { createUserMessage } from "@deepseek-ai/dsh-llm";
 import { SessionId } from "@deepseek-ai/dsh-session";
-import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_MEMORY_REVIEW_MODEL, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_LIMITS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_MODEL, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_SUBSTANTIVE_MIN_AGENT_CHARS, DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS, DEFAULT_SUBSTANTIVE_MIN_USER_CHARS, DEFAULT_USER_CHAR_LIMIT, MAX_TIMER_DELAY_MS, PROMPT_BUNDLE, advanceReview, assertSkillsRootAliasRetired, clampedNumber, clearReviewChannel, contentHash, evolutionIoAdapter, foldToolDispatches, foldTurn, markReviewChannel, newSkillLibrary, readDispatchSignal, redactSecrets, resolveOrigins, resolveRootConfig, reviewPrompt, sessionAudited, skillReadNameOf, sweepReviewChannelSessions, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_MEMORY_REVIEW_MODEL, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_LIMITS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_MODEL, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_SUBSTANTIVE_MIN_AGENT_CHARS, DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS, DEFAULT_SUBSTANTIVE_MIN_USER_CHARS, DEFAULT_USER_CHAR_LIMIT, MAX_TIMER_DELAY_MS, PROMPT_BUNDLE, advanceReview, assertSkillsRootAliasRetired, clampedNumber, clearReviewChannel, contentHash, evolutionIoAdapter, foldToolDispatches, foldTurn, markReviewChannel, newSkillLibrary, policyStageLimits, readDispatchSignal, redactSecrets, resolveOrigins, resolveRootConfig, reviewPrompt, sessionAudited, skillReadNameOf, sweepReviewChannelSessions, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 //#region lib/types/session-state.js
 /**
@@ -149,9 +149,6 @@ function clampReviewConfig(rawConfig, ctx) {
 	if (clamped.length > 0) ctx.logger.warn(`dsh-evolution-review: ${clamped.join(", ")} provided an invalid value; falling back to the default`);
 	return config;
 }
-/** v30 REV-04/REV-02: read the policy snapshot off the (optional) policy
-* service through an `unknown` boundary — the Context augmentation types the
-* getter non-optionally, but at runtime the row can be absent. */
 function policySnapshotOf(source) {
 	return source?.get?.();
 }
@@ -213,7 +210,7 @@ function apply(ctx, rawConfig = {}) {
 			return;
 		}
 		if (event.type !== "turn/end") return;
-		if (turnStarts.size >= COUNTER_SWEEP_THRESHOLD || cumulativeToolCalls.size >= COUNTER_SWEEP_THRESHOLD || completionInjected.size >= COUNTER_SWEEP_THRESHOLD || pendingCadenceReviews.size >= COUNTER_SWEEP_THRESHOLD || skipNextCadenceFire.size >= COUNTER_SWEEP_THRESHOLD || cadenceResetWarned.size >= COUNTER_SWEEP_THRESHOLD || lastTurnStart.size >= COUNTER_SWEEP_THRESHOLD) {
+		if (turnStarts.size >= COUNTER_SWEEP_THRESHOLD || pendingCadenceWarned.size >= COUNTER_SWEEP_THRESHOLD || cumulativeToolCalls.size >= COUNTER_SWEEP_THRESHOLD || completionInjected.size >= COUNTER_SWEEP_THRESHOLD || pendingCadenceReviews.size >= COUNTER_SWEEP_THRESHOLD || skipNextCadenceFire.size >= COUNTER_SWEEP_THRESHOLD || cadenceResetWarned.size >= COUNTER_SWEEP_THRESHOLD || lastTurnStart.size >= COUNTER_SWEEP_THRESHOLD) {
 			const isAlive = (id) => ctx.agents.get(id) !== void 0;
 			sweepDeadSessionEntries(turnStarts, isAlive);
 			sweepDeadSessionEntries(lastTurnStart, isAlive);
@@ -904,6 +901,7 @@ function apply(ctx, rawConfig = {}) {
 				io: evolutionIoAdapter(() => io.provider()),
 				limits: {
 					...DEFAULT_SKILL_LIMITS,
+					...policyStageLimits(policySnapshot),
 					maxSkillContentChars: policySnapshot?.skillContentChars ?? DEFAULT_SKILL_LIMITS.maxSkillContentChars
 				},
 				ctx
@@ -1113,24 +1111,56 @@ function resultCallIdOf(event) {
 	return null;
 }
 /**
-* V10-10 (P2-11): render one `[result]` evidence line from a tool-result
-* event payload. The former read (`data.output`) targeted a field that does
-* not exist on the upstream rc.2 payload, so EVERY result line rendered an
-* empty payload and the review subagent never saw tool output — the evidence
-* chain silently starved while still spending its line budget. The payload
-* text now comes from `data.message.content` tool-result blocks (inner text
-* blocks joined, mirroring the user/assistant rendering above). A failure is
-* marked by the payload-level `error` OR a block-level `isError`. The legacy
-* pre-rc.2 shape (no `message`) is tolerated as an empty payload — it never
-* throws. Budget: 500 chars per line (the 12-line cap lives in
-* buildReviewRequest and is unchanged).
+* V10-10 (P2-11) / A1 (audit P1-1): render one `[result]` evidence line from
+* a tool-result event payload. The former read (`data.output`) targeted a
+* field that does not exist on the rc.2 payload; the current contract covers
+* BOTH rc.2 result shapes:
+*   - native `tool/result`: the outcome lives in `message.content`
+*     tool-result blocks (inner text blocks joined); a failure is marked by
+*     the payload-level `error` OR a block-level `isError`;
+*   - PTC `tool/ptc-dispatch` settle: the outcome lives at the TOP level —
+*     `content` is the logged ContentBlock list and `isError` the flag; there
+*     is no `message` wrapper. (Before A1 this shape rendered an empty line,
+*     so every PTC session's evidence block starved while its plan prompt
+*     still demanded evidence.)
+* The legacy pre-rc.2 shape (neither `message` nor a PTC settle marker) is
+* tolerated as an empty payload — it never throws. `identity`, when given, is
+* the dispatched tool's name + raw arguments, prepended so a settled dispatch
+* keeps the call identity its `[call]` line would have had. Budget: 500 chars
+* per line (the 12-line cap lives in buildReviewRequest and is unchanged).
 */
-function renderToolResultLine(data) {
+function renderToolResultLine(data, identity) {
 	const shape = data;
-	const content = shape?.message?.content;
-	const resultBlocks = (Array.isArray(content) ? content : []).filter((block) => block.type === "tool-result");
-	const output = resultBlocks.map((block) => Array.isArray(block.content) ? block.content.map((inner) => inner.type === "text" && typeof inner.text === "string" ? inner.text : "").join(" ") : typeof block.text === "string" ? block.text : "").join(" ").trim();
-	return `[result]${shape?.error || resultBlocks.some((block) => block.isError === true) ? " [ERROR]" : ""} ${output.slice(0, 500)}`;
+	const nativeContent = shape?.message?.content;
+	const resultBlocks = Array.isArray(nativeContent) ? nativeContent.filter((block) => block.type === "tool-result") : [];
+	let output;
+	let failed;
+	if (shape?.message !== void 0) {
+		output = resultBlocks.map((block) => Array.isArray(block.content) ? block.content.map((inner) => inner.type === "text" && typeof inner.text === "string" ? inner.text : "").join(" ") : typeof block.text === "string" ? block.text : "").join(" ").trim();
+		failed = Boolean(shape.error) || resultBlocks.some((block) => block.isError === true);
+	} else if (typeof shape?.subCallId === "string" && typeof shape.isError === "boolean") {
+		output = textOfLoggedContent(shape.content);
+		failed = shape.isError;
+	} else {
+		output = "";
+		failed = false;
+	}
+	const head = identity === void 0 ? "" : `${identity.name} ${identity.argsRaw.slice(0, 200)} → `;
+	return `[result]${failed ? " [ERROR]" : ""} ${head}${output.slice(0, 500)}`;
+}
+/** Text of a PTC settle `content` payload (the logged ContentBlock list):
+* text blocks and plain strings joined, anything else skipped. */
+function textOfLoggedContent(content) {
+	if (typeof content === "string") return content.trim();
+	if (!Array.isArray(content)) return "";
+	return content.map((block) => {
+		if (typeof block === "string") return block;
+		if (block !== null && typeof block === "object") {
+			const candidate = block;
+			if (candidate.type === "text" && typeof candidate.text === "string") return candidate.text;
+		}
+		return "";
+	}).join(" ").trim();
 }
 /**
 * PLAN S4.1 (2026-09-16, audit P2-12): text of one persisted content block,
@@ -1157,6 +1187,17 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars)
 	}
 	const toolLines = [];
 	const events = session.snapshotEvents();
+	const callIdentity = /* @__PURE__ */ new Map();
+	const identityWindowStart = Math.max(0, events.length - 2e3);
+	for (let index = events.length - 1; index >= identityWindowStart; index -= 1) {
+		const event = events[index];
+		const opened = readDispatchSignal(event);
+		if (opened === null || callIdentity.has(opened.callId)) continue;
+		callIdentity.set(opened.callId, {
+			name: opened.name,
+			argsRaw: typeof opened.arguments === "string" ? opened.arguments : JSON.stringify(opened.arguments ?? {})
+		});
+	}
 	const openedCallIds = /* @__PURE__ */ new Set();
 	for (let index = events.length - 1; index >= 0 && toolLines.length < 12; index -= 1) {
 		const event = events[index];
@@ -1164,7 +1205,13 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars)
 		if (answeredCallId !== null) {
 			if (openedCallIds.has(answeredCallId)) continue;
 			openedCallIds.add(answeredCallId);
-			toolLines.push(renderToolResultLine(event?.data));
+			const rawSettle = event?.data;
+			const settleData = rawSettle !== null && typeof rawSettle === "object" ? rawSettle : void 0;
+			const identity = settleData !== void 0 && typeof settleData.name === "string" && settleData.name !== "" ? {
+				name: settleData.name,
+				argsRaw: typeof settleData.arguments === "string" ? settleData.arguments : JSON.stringify(settleData.arguments ?? {})
+			} : callIdentity.get(answeredCallId);
+			toolLines.push(renderToolResultLine(event?.data, identity));
 			continue;
 		}
 		const opened = readDispatchSignal(event);

package/lib/types/index.d.ts

@@ -151,19 +151,28 @@ export declare function filterUnreadSkillOps(ops: Array<{
     name?: string;
 }>, readNames: ReadonlySet<string>): number;
 /**
- * V10-10 (P2-11): render one `[result]` evidence line from a tool-result
- * event payload. The former read (`data.output`) targeted a field that does
- * not exist on the upstream rc.2 payload, so EVERY result line rendered an
- * empty payload and the review subagent never saw tool output — the evidence
- * chain silently starved while still spending its line budget. The payload
- * text now comes from `data.message.content` tool-result blocks (inner text
- * blocks joined, mirroring the user/assistant rendering above). A failure is
- * marked by the payload-level `error` OR a block-level `isError`. The legacy
- * pre-rc.2 shape (no `message`) is tolerated as an empty payload — it never
- * throws. Budget: 500 chars per line (the 12-line cap lives in
- * buildReviewRequest and is unchanged).
+ * V10-10 (P2-11) / A1 (audit P1-1): render one `[result]` evidence line from
+ * a tool-result event payload. The former read (`data.output`) targeted a
+ * field that does not exist on the rc.2 payload; the current contract covers
+ * BOTH rc.2 result shapes:
+ *   - native `tool/result`: the outcome lives in `message.content`
+ *     tool-result blocks (inner text blocks joined); a failure is marked by
+ *     the payload-level `error` OR a block-level `isError`;
+ *   - PTC `tool/ptc-dispatch` settle: the outcome lives at the TOP level —
+ *     `content` is the logged ContentBlock list and `isError` the flag; there
+ *     is no `message` wrapper. (Before A1 this shape rendered an empty line,
+ *     so every PTC session's evidence block starved while its plan prompt
+ *     still demanded evidence.)
+ * The legacy pre-rc.2 shape (neither `message` nor a PTC settle marker) is
+ * tolerated as an empty payload — it never throws. `identity`, when given, is
+ * the dispatched tool's name + raw arguments, prepended so a settled dispatch
+ * keeps the call identity its `[call]` line would have had. Budget: 500 chars
+ * per line (the 12-line cap lives in buildReviewRequest and is unchanged).
  */
-export declare function renderToolResultLine(data: unknown): string;
+export declare function renderToolResultLine(data: unknown, identity?: {
+    name: string;
+    argsRaw: string;
+}): string;
 export declare function buildReviewRequest(session: Session, kind: ReviewKind, signal: {
     toolCalls: number;
     userChars: number;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "publishConfig": {
     "access": "public"
   },
@@ -27,9 +27,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.4.0",
-    "@lmzhen/dsh-evolution-core": "^0.4.0",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.4.0"
+    "@lmzhen/dsh-evolution-approval": "^0.5.0",
+    "@lmzhen/dsh-evolution-core": "^0.5.0",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.5.0"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -37,8 +37,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.5-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.4.0",
-    "@lmzhen/dsh-evolution-policy": "^0.4.0"
+    "@lmzhen/dsh-evolution-state": "^0.5.0",
+    "@lmzhen/dsh-evolution-policy": "^0.5.0"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.5-rc.2",
@@ -48,10 +48,10 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.5-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.4.0",
-    "@lmzhen/dsh-evolution-core": "^0.4.0",
-    "@lmzhen/dsh-evolution-curator": "^0.4.0",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.4.0",
-    "@lmzhen/dsh-evolution-state": "^0.4.0"
+    "@lmzhen/dsh-evolution-approval": "^0.5.0",
+    "@lmzhen/dsh-evolution-core": "^0.5.0",
+    "@lmzhen/dsh-evolution-curator": "^0.5.0",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.5.0",
+    "@lmzhen/dsh-evolution-state": "^0.5.0"
   }
 }