@lmzhen/dsh-evolution-review 0.30.23 → 0.30.25

package/lib/index.js

@@ -1,9 +1,9 @@
-import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_MEMORY_REVIEW_MODEL, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_LIMITS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_MODEL, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_SUBSTANTIVE_MIN_AGENT_CHARS, DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS, DEFAULT_SUBSTANTIVE_MIN_USER_CHARS, DEFAULT_USER_CHAR_LIMIT, MAX_TIMER_DELAY_MS, PROMPT_BUNDLE, advanceReview, assertSkillsRootAliasRetired, authorityFrom, clampOnce, classifySessionEvent, clearReviewChannel, contentHash, createSubagentChannel, evolutionIoAdapter, filterUnreadSkillOps, filterUnreadSkillOps as filterUnreadSkillOps$1, foldUntrustedLines, isPresent, isUnknown, liveBool, markReviewChannel, newSkillLibrary, paramRowId, payloadText, pickWithPolicy, policyStageLimits, readDispatchSignal, redactSecrets, resolveOrigins, resolveRootConfig, reviewPrompt, sessionAudited, sessionEvidenceIndex, sessionReadNames, sessionTurnSignals, sweepReviewChannelSessions, unwrapLive, userSetKeys, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_MEMORY_REVIEW_MODEL, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_LIMITS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_MODEL, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_SUBSTANTIVE_MIN_AGENT_CHARS, DEFAULT_SUBSTANTIVE_MIN_TOOL_CALLS, DEFAULT_SUBSTANTIVE_MIN_USER_CHARS, DEFAULT_USER_CHAR_LIMIT, MAX_TIMER_DELAY_MS, PROMPT_BUNDLE, advanceReview, assertSkillsRootAliasRetired, authorityFrom, clampOnce, classifySessionEvent, clearReviewChannel, contentHash, createSubagentChannel, ensureSkillFrontmatter, evolutionIoAdapter, filterUnreadSkillOps, filterUnreadSkillOps as filterUnreadSkillOps$1, foldUntrustedLines, isPresent, isUnknown, liveBool, markReviewChannel, newSkillLibrary, paramRowId, payloadText, pickWithPolicy, policyStageLimits, readDispatchSignal, redactSecrets, resolveOrigins, resolveRootConfig, reviewPrompt, sessionAudited, sessionEvidenceIndex, sessionReadNames, sessionTurnSignals, sweepReviewChannelSessions, unwrapLive, userSetKeys, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
 import { createUserMessage } from "@deepseek-ai/dsh-llm";
 import { SessionId } from "@deepseek-ai/dsh-session";
-import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
+import { planContractPrompt, validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 /**
 * Whether a message is a notice this plugin delivered, judged only by durable source fields.
 *
@@ -143,6 +143,10 @@ function emitReviewScheduled(ctx, event) {
 /** Error name marking the S2-6 watchdog expiry (see the catch in trySubagentReview). */
 const name = "evolution-review";
 const inject = ["agents"];
+/** Result notices are optional; a review PROMPT is the review itself in inject mode. */
+function noticeAllowed(reviewPrompt, notice) {
+	return reviewPrompt || notice;
+}
 const Config = z.object({
 	reviewEnabled: z.boolean().default(true).volatile(),
 	reviewMode: z.union([z.const("subagent"), z.const("inject")]).default("inject").volatile(),
@@ -162,6 +166,7 @@ const Config = z.object({
 		z.const("both")
 	]).default(DEFAULT_SKILL_REVIEW_TRIGGER).volatile(),
 	reviewWakeInject: z.boolean().default(true).volatile(),
+	reviewNotice: z.boolean().default(true).volatile(),
 	sessionScoped: z.boolean().default(false),
 	skillReviewCompletionMinToolCalls: z.number().min(1).default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS).volatile(),
 	root: z.string().default(""),
@@ -235,7 +240,8 @@ function resolveReviewRowSettings(rawConfig, warn) {
 		skillReviewCompletionMinToolCalls: clampOnce(warned, warn, "skillReviewCompletionMinToolCalls", rawConfig.skillReviewCompletionMinToolCalls, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, 1),
 		reviewEnabled: liveBool(rawConfig.reviewEnabled, true),
 		reviewMode: unwrapLive(rawConfig.reviewMode) ?? "inject",
-		reviewWakeInject: liveBool(rawConfig.reviewWakeInject, true)
+		reviewWakeInject: liveBool(rawConfig.reviewWakeInject, true),
+		reviewNotice: liveBool(rawConfig.reviewNotice, true)
 	};
 }
 function apply(ctx, rawConfig = {}) {
@@ -289,7 +295,8 @@ function apply(ctx, rawConfig = {}) {
 			skillReviewCompletionMinToolCalls: row.skillReviewCompletionMinToolCalls,
 			reviewEnabled: row.reviewEnabled,
 			reviewMode: mode(),
-			reviewWakeInject: row.reviewWakeInject
+			reviewWakeInject: row.reviewWakeInject,
+			reviewNotice: row.reviewNotice
 		};
 	};
 	const schemaDefaults = Config["~standard"].validate({}).value;
@@ -639,6 +646,10 @@ function apply(ctx, rawConfig = {}) {
 	const deliverMessage = (agent, text, summary, reviewPrompt = false) => {
 		const wake = agent;
 		const inbox = agent.inbox;
+		if (!noticeAllowed(reviewPrompt, params().reviewNotice)) {
+			ctx.logger.info(`dsh-evolution-review: suppressed a result notice (${summary}) — reviewNotice is off`);
+			return true;
+		}
 		if (reviewPrompt && noticeIsOutstanding(agent.session.id, inbox)) {
 			if (!reviewNoticeOutstandingWarned) {
 				reviewNoticeOutstandingWarned = true;
@@ -982,6 +993,13 @@ function apply(ctx, rawConfig = {}) {
 					...op,
 					evidence: op.evidence
 				};
+				if ((args.action === "create" || args.action === "edit" || args.action === "update") && typeof args.content === "string" && typeof args.name === "string") {
+					const repaired = ensureSkillFrontmatter(args.content, args.name, args.description);
+					if (repaired.repaired) {
+						args.content = repaired.content;
+						ctx.logger.warn(`dsh-evolution-review: synthesized missing SKILL.md frontmatter for ${args.name}`);
+					}
+				}
 				let stagedBytes;
 				if ((args.action === "update" || args.action === "edit") && hashLibrary && typeof args.name === "string" && args.name !== "") {
 					const probe = await hashLibrary.readSkillProbe(args.name);
@@ -1256,6 +1274,7 @@ function appendDispatchFrame(digest, id, event) {
 	const frames = digest.get(id) ?? [];
 	frames.push({
 		type: event.type,
+		...event.seq === void 0 ? {} : { seq: event.seq },
 		...event.data === void 0 ? {} : { data: event.data }
 	});
 	if (frames.length > DISPATCH_DIGEST_FRAMES) frames.splice(0, frames.length - DISPATCH_DIGEST_FRAMES);
@@ -1321,7 +1340,7 @@ function resultCallIdOf(event) {
 * keeps the call identity its `[call]` line would have had. Budget: 500 chars
 * per line (the 12-line cap lives in buildReviewRequest and is unchanged).
 */
-function renderToolResultLine(data, identity) {
+function renderToolResultLine(data, identity, seq) {
 	const shape = data;
 	const nativeContent = shape?.message?.content;
 	const resultBlocks = Array.isArray(nativeContent) ? nativeContent.filter((block) => block.type === "tool-result") : [];
@@ -1338,7 +1357,8 @@ function renderToolResultLine(data, identity) {
 		failed = false;
 	}
 	const head = identity === void 0 ? "" : `${foldUntrustedLines(identity.name, 0)} ${foldUntrustedLines(identity.argsRaw, 200)} → `;
-	return `[result]${failed ? " [ERROR]" : ""} ${head}${foldUntrustedLines(output, 500)}`;
+	const failure = failed ? " [ERROR]" : "";
+	return (seq === void 0 ? "" : "seq=" + String(seq) + " ") + "[result]" + failure + " " + head + foldUntrustedLines(output, 500);
 }
 /** Text of a PTC settle `content` payload (the logged ContentBlock list):
 * text blocks and plain strings joined, anything else skipped. */
@@ -1402,14 +1422,15 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars,
 				name: settleData.name,
 				argsRaw: typeof settleData.arguments === "string" ? settleData.arguments : JSON.stringify(settleData.arguments ?? {})
 			} : callIdentity.get(answeredCallId);
-			toolLines.push(renderToolResultLine(event?.data, identity));
+			toolLines.push(renderToolResultLine(event?.data, identity, event?.seq));
 			continue;
 		}
 		const opened = readDispatchSignal(event);
 		if (opened === null || openedCallIds.has(opened.callId)) continue;
 		openedCallIds.add(opened.callId);
 		const argsRaw = typeof opened.arguments === "string" ? opened.arguments : JSON.stringify(opened.arguments ?? {});
-		toolLines.push(`[call] ${foldUntrustedLines(opened.name, 0)} ${foldUntrustedLines(argsRaw, 500)}`);
+		const seq = typeof event?.seq === "number" ? "seq=" + String(event.seq) + " " : "";
+		toolLines.push(seq + "[call] " + foldUntrustedLines(opened.name, 0) + " " + foldUntrustedLines(argsRaw, 500));
 	}
 	toolLines.reverse();
 	return [
@@ -1418,9 +1439,10 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars,
 		`Recent tool activity (${toolLines.length}):`,
 		...toolLines,
 		"Return ONLY the structured JSON plan. Evidence is mandatory for every op.",
+		planContractPrompt(),
 		"",
 		...messages
 	].join("\n");
 }
 //#endregion
-export { Config, REVIEW_OUTPUT_SCHEMA, apply, buildReviewRequest, clampReviewConfig, filterUnreadSkillOps, inject, name, renderToolResultLine, resolveReviewRowSettings, shouldCompletionReview, sweepDeadSessionEntries };
+export { Config, REVIEW_OUTPUT_SCHEMA, apply, buildReviewRequest, clampReviewConfig, filterUnreadSkillOps, inject, name, noticeAllowed, renderToolResultLine, resolveReviewRowSettings, shouldCompletionReview, sweepDeadSessionEntries };

package/lib/types/index.d.ts

@@ -25,6 +25,8 @@ export { filterUnreadSkillOps } from '@lmzhen/dsh-evolution-core';
 /** Error name marking the S2-6 watchdog expiry (see the catch in trySubagentReview). */
 export declare const name = "evolution-review";
 export declare const inject: string[];
+/** Result notices are optional; a review PROMPT is the review itself in inject mode. */
+export declare function noticeAllowed(reviewPrompt: boolean, notice: boolean): boolean;
 export interface Config {
     reviewEnabled?: Volatile<boolean>;
     /** How the flush delivers the review: `'inject'` (default since 0.3.74) hands
@@ -85,6 +87,10 @@ export interface Config {
      * differs). Default true; false degrades to the non-waking inject (the
      * summary then waits for the next driver wake). */
     reviewWakeInject?: Volatile<boolean>;
+    /** Deliver result notices into the parent conversation. Default true. A review PROMPT is the
+     * review itself in inject mode, so this never suppresses prompt delivery — only the result
+     * notice (and late/zero-landing notices) that wakes a turn just to report a count. */
+    reviewNotice?: Volatile<boolean>;
     /** V10-11 (P2-7): skill tree root for the review's direct skill writes.
      * Empty (the default) resolves through `resolveSkillsRoot` to the shared
      * default root — the historical behavior. A custom root keeps review-created
@@ -119,6 +125,7 @@ export declare const Config: z<Schemastery.ObjectS<NoInfer<{
     reviewProvider: z<string, string, "plain">;
     skillReviewTrigger: z<"cadence" | "completion" | "both", "cadence" | "completion" | "both", "volatile-defined">;
     reviewWakeInject: z<boolean, boolean, "volatile-defined">;
+    reviewNotice: z<boolean, boolean, "volatile-defined">;
     sessionScoped: z<boolean, boolean, "defined">;
     skillReviewCompletionMinToolCalls: z<number, number, "volatile-defined">;
     root: z<string, string, "defined">;
@@ -138,6 +145,7 @@ export declare const Config: z<Schemastery.ObjectS<NoInfer<{
     reviewProvider: z<string, string, "plain">;
     skillReviewTrigger: z<"cadence" | "completion" | "both", "cadence" | "completion" | "both", "volatile-defined">;
     reviewWakeInject: z<boolean, boolean, "volatile-defined">;
+    reviewNotice: z<boolean, boolean, "volatile-defined">;
     sessionScoped: z<boolean, boolean, "defined">;
     skillReviewCompletionMinToolCalls: z<number, number, "volatile-defined">;
     root: z<string, string, "defined">;
@@ -208,6 +216,8 @@ export interface ReviewSettings {
     reviewMode: 'subagent' | 'inject';
     /** Deliver the deferred review as a waking follow-up message. */
     reviewWakeInject: boolean;
+    /** Deliver result notices (not review prompts). */
+    reviewNotice: boolean;
 }
 /**
  * This row's review knobs as they stand RIGHT NOW (G1 §8.3) — the base layer of the
@@ -228,6 +238,8 @@ export declare function shouldCompletionReview(reason: {
 /** One dispatch frame the review digest can render (a native call/result or a PTC sub-dispatch). */
 interface ReviewDispatchFrame {
     readonly type: string;
+    /** Session seq of the frame, so a plan can cite a real `event_seq`. */
+    readonly seq?: number;
     readonly data?: unknown;
 }
 /**
@@ -260,7 +272,7 @@ export declare function sweepDeadSessionEntries<K>(entries: Map<K, unknown> | Se
 export declare function renderToolResultLine(data: unknown, identity?: {
     name: string;
     argsRaw: string;
-}): string;
+}, seq?: number): string;
 export declare function buildReviewRequest(session: Session, kind: ReviewKind, signal: {
     toolCalls: number;
     userChars: number;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.30.23",
+  "version": "0.30.25",
   "publishConfig": {
     "access": "public"
   },
@@ -27,9 +27,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.5",
-    "@lmzhen/dsh-evolution-approval": "^0.30.23",
-    "@lmzhen/dsh-evolution-core": "^0.30.23",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.30.23"
+    "@lmzhen/dsh-evolution-approval": "^0.30.25",
+    "@lmzhen/dsh-evolution-core": "^0.30.25",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.30.25"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.5",
@@ -37,8 +37,8 @@
     "@deepseek-ai/dsh-llm": "^0.2.1-rc.1",
     "@deepseek-ai/dsh-session": "^0.2.1-rc.1",
     "@deepseek-ai/dsh-tools": "^0.2.1-rc.1",
-    "@lmzhen/dsh-evolution-policy": "^0.30.23",
-    "@lmzhen/dsh-evolution-state": "^0.30.23"
+    "@lmzhen/dsh-evolution-policy": "^0.30.25",
+    "@lmzhen/dsh-evolution-state": "^0.30.25"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.2.1-rc.1",
@@ -48,11 +48,11 @@
     "@deepseek-ai/dsh-session-persistence": "^0.2.1-rc.1",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.2.1-rc.1",
     "@deepseek-ai/dsh-tools": "^0.2.1-rc.1",
-    "@lmzhen/dsh-evolution-approval": "^0.30.23",
-    "@lmzhen/dsh-evolution-core": "^0.30.23",
-    "@lmzhen/dsh-evolution-curator": "^0.30.23",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.30.23",
-    "@lmzhen/dsh-evolution-state": "^0.30.23"
+    "@lmzhen/dsh-evolution-approval": "^0.30.25",
+    "@lmzhen/dsh-evolution-core": "^0.30.25",
+    "@lmzhen/dsh-evolution-curator": "^0.30.25",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.30.25",
+    "@lmzhen/dsh-evolution-state": "^0.30.25"
   },
   "engines": {
     "dsh": ">=0.2.1-rc.1 <0.2.2-0"