@lmzhen/dsh-evolution-review 0.3.71 → 0.3.73

package/README.md

@@ -40,5 +40,5 @@ Independent of request-prefix construction. This package does not alter the asse
 
 - **Both channels execute at conversation end only** (a `turn/end` with `reason.kind === 'completed'`): a cadence threshold fire mid-task merely latches the kind — no subagent spawn, no inject. The flush runs BEFORE the latch block (the completing turn may itself be a threshold-firing turn). `reviewMode` (`'subagent'` default / `'inject'`) selects how the flush delivers; the explicit `'inject'` mode's historical "immediate on threshold" contract was superseded in 0.3.39 — both modes are end-of-conversation.
 - **`skillReviewTrigger`** (default `'cadence'`): the cadence channel is **always on** (one end-of-conversation review from the cadence latch per task segment); the flag gates **only the completion channel** — `'cadence'` disables it, `'completion'` enables it (cadence still fires), `'both'` enables it on top of the always-on cadence. At one boundary a turn is served by exactly one review: the cadence flush runs first and returns, so `'both'` never double-sends a second task-complete prompt at the same boundary (V10-13).
-- **`reviewWakeInject`** (default `true`): deliveries use `agent.followup` (next-turn + wake — the model starts processing immediately) instead of the non-waking `agent.inject` (which waits for the next driver wake). The host falls back to `inject` when it has no followup or the option is `false`. The woken turn's own cadence fire is suppressed once (an injected review prompt alone must not re-trigger a review under `interval=1`); a restart clears the queue, so the loop cannot survive it.
+- **`reviewWakeInject`** (default `true`): deliveries use `agent.followup` (next-turn + wake — the model starts processing immediately) instead of the non-waking `agent.inject` (which waits for the next driver wake). The host falls back to `inject` when it has no followup or the option is `false`. **The wake primitive is always called ON the agent instance** — the platform's `Agent.followup`/`inject` are prototype methods that call `this.send(...)`, so extracting one into a local and calling the detached reference throws (0.3.73: that throw was caught and logged while the cadence reset still ran, silently consuming every segment's review from 2026-09-07). A refused delivery now returns `false` and the caller keeps its latch and counters, so the review retries at the next completed boundary instead of vanishing; `evolution-host/tests/wake-delivery-guard.spec.ts` pins the call form mechanically. The woken turn's own cadence fire is suppressed once (an injected review prompt alone must not re-trigger a review under `interval=1`); a restart clears the queue, so the loop cannot survive it.
 - **Counting window = injection-to-injection**: the `turnsSinceMemory`/`turnsSinceSkill` counters are monotonic across threshold fires (`resetOnFire: false`) and are zeroed at the flush delivery — a continued conversation starts a fresh segment from the injection. A threshold fire on the completing turn is caught by the flush (`pendingKind = latch ?? kind`). All deliveries (review prompt AND result notices) share the same waking channel; a failed counter-reset persist warns once per session (a stateful reload may re-deliver).

package/lib/index.js

@@ -173,8 +173,11 @@ function apply(ctx, rawConfig = {}) {
 			const pendingKind = kind ?? pendingCadenceReviews.get(session.id) ?? void 0;
 			if (pendingKind !== void 0) {
 				pendingCadenceReviews.delete(session.id);
-				if ((policy()?.reviewMode ?? config.reviewMode) === "inject") try {
-					deliverMessage(agent, reviewPrompt(pendingKind), "auto-review");
+				if ((policy()?.reviewMode ?? config.reviewMode) === "inject") {
+					if (!deliverMessage(agent, reviewPrompt(pendingKind), "auto-review")) {
+						pendingCadenceReviews.set(session.id, pendingKind);
+						return;
+					}
 					try {
 						ctx.emit("evolution/review-scheduled", {
 							sessionId: session.id,
@@ -187,10 +190,7 @@ function apply(ctx, rawConfig = {}) {
 					} catch (emitError) {
 						ctx.logger.warn(`dsh-evolution-review: review-scheduled emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
 					}
-				} catch (injectError) {
-					ctx.logger.warn(`dsh-evolution-review: deferred review inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
-				}
-				else {
+				} else {
 					const reviewOutcome = await trySubagentReview(session, agent, pendingKind, signal);
 					if (reviewOutcome === true) try {
 						ctx.emit("evolution/review-scheduled", {
@@ -207,8 +207,11 @@ function apply(ctx, rawConfig = {}) {
 					else if (reviewOutcome === "dropped") {
 						pendingCadenceReviews.set(session.id, pendingKind);
 						return;
-					} else if (reviewOutcome !== "deferred") try {
-						deliverMessage(agent, reviewPrompt(pendingKind), "auto-review");
+					} else if (reviewOutcome !== "deferred") {
+						if (!deliverMessage(agent, reviewPrompt(pendingKind), "auto-review")) {
+							pendingCadenceReviews.set(session.id, pendingKind);
+							return;
+						}
 						try {
 							ctx.emit("evolution/review-scheduled", {
 								sessionId: session.id,
@@ -221,8 +224,6 @@ function apply(ctx, rawConfig = {}) {
 						} catch (emitError) {
 							ctx.logger.warn(`dsh-evolution-review: review-scheduled emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
 						}
-					} catch (injectError) {
-						ctx.logger.warn(`dsh-evolution-review: deferred review inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
 					}
 				}
 				try {
@@ -271,11 +272,8 @@ function apply(ctx, rawConfig = {}) {
 			}
 			return;
 		}
-		try {
-			deliverMessage(agent, COMPLETION_SKILL_REVIEW_PROMPT, "completion review");
-		} catch (injectError) {
+		if (!deliverMessage(agent, COMPLETION_SKILL_REVIEW_PROMPT, "completion review")) {
 			completionInjected.delete(session.id);
-			ctx.logger.warn(`dsh-evolution-review: completion review inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
 			return;
 		}
 		try {
@@ -294,7 +292,16 @@ function apply(ctx, rawConfig = {}) {
 	/** V7-03 (0.3.42): shared waking delivery — review prompts AND result
 	* notices go through the same followup-first channel (skip the woken turn's
 	* cadence fire once, degrade to inject when reviewWakeInject is off or the
-	* host lacks followup). */
+	* host lacks followup).
+	*
+	* 0.3.73: returns false when the host refused the delivery, and never throws.
+	* Callers that own a one-shot latch or the cadence reset MUST honour the
+	* result: the pre-0.3.73 form read `agent.followup` into a local and called
+	* the detached reference, so EVERY real delivery threw
+	* `TypeError: … reading 'send'` inside the platform's ReactLoopAgent (a
+	* prototype method), the caller's catch demoted that to a console warning,
+	* and the cadence reset ran anyway — the segment's review was consumed with
+	* nothing queued (silent no-delivery window: 2026-09-07 → 0.3.73). */
 	const deliverMessage = (agent, text, summary) => {
 		const message = createUserMessage({
 			content: [{
@@ -308,11 +315,17 @@ function apply(ctx, rawConfig = {}) {
 				summary
 			}
 		});
-		const followup = agent.followup;
-		if (config.reviewWakeInject && typeof followup === "function") {
-			followup(message);
-			skipNextCadenceFire.set(agent.session.id, true);
-		} else agent.inject(message);
+		const wake = agent;
+		try {
+			if (config.reviewWakeInject && typeof wake.followup === "function") {
+				wake.followup(message);
+				skipNextCadenceFire.set(agent.session.id, true);
+			} else agent.inject(message);
+			return true;
+		} catch (error) {
+			ctx.logger.warn(`dsh-evolution-review: review delivery failed (${error instanceof Error ? error.message : String(error)}) — nothing was queued; the review is NOT consumed and retries at the next completed boundary`);
+			return false;
+		}
 	};
 	const withTimeout = (promise, ms, label) => new Promise((resolve, reject) => {
 		const timer = setTimeout(() => {
@@ -376,6 +389,7 @@ function apply(ctx, rawConfig = {}) {
 			const agentOptions = { model };
 			if (config.reviewProvider) agentOptions.provider = config.reviewProvider;
 			const preRunHashes = await treeSkillHashes();
+			const sessionSeqAtPlanTime = session.seq - 1;
 			const run = await subagents.start("spawn", {
 				label: "dsh-evolution-review",
 				prompt: [{
@@ -398,14 +412,17 @@ function apply(ctx, rawConfig = {}) {
 					} catch (emitError) {
 						ctx.logger.warn(`dsh-evolution-review: review-error emit failed: ${emitError instanceof Error ? emitError.message : String(emitError)}`);
 					}
-					ctx.logger.warn("dsh-evolution-review: review subagent returned no structured plan");
+					const failureShape = result;
+					const stopDetail = typeof failureShape.stopReason === "string" ? failureShape.stopReason : void 0;
+					const diagDetail = typeof failureShape.diagnostic === "string" ? failureShape.diagnostic : void 0;
+					ctx.logger.warn(`dsh-evolution-review: review subagent returned no structured plan${stopDetail !== void 0 ? ` (stopReason=${stopDetail}${diagDetail !== void 0 ? `; diagnostic=${diagDetail}` : ""})` : ""}`);
 					return false;
 				}
 				const childReads = run.localAgent ? collectReadSkillNames(run.localAgent.session) : /* @__PURE__ */ new Set();
 				const plan = result.structured;
 				const policyFingerprint = fingerprintPolicy(snapshot);
 				const validation = validateEvolutionPlan(plan, {
-					sessionSeq: session.seq - 1,
+					sessionSeq: sessionSeqAtPlanTime,
 					maxOpsPerPlan: snapshot?.maxOpsPerPlan ?? DEFAULT_MAX_OPS_PER_PLAN,
 					protectedSkillNames: new Set(snapshot?.protectedSkillNames ?? []),
 					maxMemoryChars: snapshot?.memoryChars ?? DEFAULT_MEMORY_CHAR_LIMIT,
@@ -449,13 +466,8 @@ function apply(ctx, rawConfig = {}) {
 				if (actions.length > 0) {
 					const applied = actions.join(" · ");
 					const failedNote = executed.failedOps.length > 0 ? ` 失败 ${executed.failedOps.length} 个：${executed.failedOps.join("；")}。` : "";
-					const note = executed.ok ? "" : `\n部分操作失败。${failedNote}以上操作已应用，请勿重复执行。`;
-					try {
-						deliverMessage(agent, `💾 Self-improvement review: ${applied}${note}`, "self-improvement review");
-					} catch (injectError) {
-						ctx.logger.warn(`dsh-evolution-review: result notice inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
-					}
-				} else try {
+					deliverMessage(agent, `💾 Self-improvement review: ${applied}${executed.ok ? "" : `\n部分操作失败。${failedNote}以上操作已应用，请勿重复执行。`}`, "self-improvement review");
+				} else {
 					const reasons = [];
 					if (validation.rejected.length > 0) reasons.push(`${validation.rejected.length} op(s) rejected by validation`);
 					if (skippedUnread > 0) reasons.push(`${skippedUnread} op(s) skipped (skill not read this session)`);
@@ -465,8 +477,6 @@ function apply(ctx, rawConfig = {}) {
 					let text = `💾 Self-improvement review: 0 ops landed. ${reasons.join(" ")}`;
 					if (text.length > 500) text = `${text.slice(0, 497)}…`;
 					deliverMessage(agent, text, "self-improvement review");
-				} catch (injectError) {
-					ctx.logger.warn(`dsh-evolution-review: zero-landing notice inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
 				}
 				emitApplied({
 					actions,
@@ -489,11 +499,8 @@ function apply(ctx, rawConfig = {}) {
 			reviewInFlight = false;
 			const deferred = deferredFallbackReviews.splice(0);
 			for (const { agent: waitingAgent, sessionId: entrySession, kind: waitingKind, prompt, label, channel, counts: entryCounts } of deferred) {
-				try {
-					deliverMessage(waitingAgent, prompt, label);
-				} catch (injectError) {
+				if (!deliverMessage(waitingAgent, prompt, label)) {
 					if (channel === "completion") completionInjected.delete(entrySession);
-					ctx.logger.warn(`dsh-evolution-review: deferred review inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
 					continue;
 				}
 				try {
@@ -566,13 +573,13 @@ function apply(ctx, rawConfig = {}) {
 					if (stageFile !== void 0) args.staged_from_sha256 = stageFile === null ? "absent" : contentHash(stageFile);
 				}
 				const opName = typeof args.name === "string" ? args.name : "";
-				const hashChecked = (args.action === "update" || args.action === "edit") && opName !== "" && preRunHashes?.has(opName) === true;
+				const hashChecked = (args.action === "update" || args.action === "edit" || args.action === "patch") && opName !== "" && preRunHashes?.has(opName) === true;
 				if (hashChecked) {
-					const live = stageCurrent;
+					const live = args.action === "patch" ? hashLibrary ? await hashLibrary.read(opName).catch(() => null) : null : stageCurrent;
 					const preRun = preRunHashes.get(opName);
 					if (live === null || preRun !== void 0 && contentHash(live) !== preRun) {
 						ok = false;
-						failedOps.push(`skill ${args.action} ${args.name}: the skill changed while this review ran — update refused as stale; produce a fresh plan`);
+						failedOps.push(`skill ${args.action} ${args.name}: the skill changed while this review ran — ${args.action === "patch" ? "patch" : "update"} refused as stale; produce a fresh plan`);
 						continue;
 					}
 				}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.71",
+  "version": "0.3.73",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.71",
-    "@lmzhen/dsh-evolution-core": "^0.3.71",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.71"
+    "@lmzhen/dsh-evolution-approval": "^0.3.73",
+    "@lmzhen/dsh-evolution-core": "^0.3.73",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.73"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.5-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.71",
-    "@lmzhen/dsh-evolution-policy": "^0.3.71"
+    "@lmzhen/dsh-evolution-state": "^0.3.73",
+    "@lmzhen/dsh-evolution-policy": "^0.3.73"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.5-rc.2",
@@ -54,10 +54,10 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.5-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.5-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.71",
-    "@lmzhen/dsh-evolution-core": "^0.3.71",
-    "@lmzhen/dsh-evolution-curator": "^0.3.71",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.71",
-    "@lmzhen/dsh-evolution-state": "^0.3.71"
+    "@lmzhen/dsh-evolution-approval": "^0.3.73",
+    "@lmzhen/dsh-evolution-core": "^0.3.73",
+    "@lmzhen/dsh-evolution-curator": "^0.3.73",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.73",
+    "@lmzhen/dsh-evolution-state": "^0.3.73"
   }
 }