@lmzhen/dsh-evolution-review 0.3.62 → 0.3.64

package/lib/index.js

@@ -1,7 +1,7 @@
 import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
 import { createUserMessage } from "@deepseek-ai/dsh-llm";
-import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_USER_CHAR_LIMIT, PROMPT_BUNDLE, SkillLibrary, advanceReview, clampedNumber, evolutionIoAdapter, foldTurn, redactSecrets, resolveOrigins, resolveSkillsRoot, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_USER_CHAR_LIMIT, PROMPT_BUNDLE, SkillLibrary, advanceReview, clampedNumber, evolutionIoAdapter, foldTurn, redactSecrets, resolveOrigins, resolveRootConfig, resolveSkillsRoot, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 //#region lib/types/index.js
 /**
@@ -10,13 +10,20 @@ import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 */
 const name = "evolution-review";
 const inject = ["agents"];
+/** Node's 32-bit timer-delay ceiling (`AbortSignal.timeout`/`setTimeout`):
+* a larger value throws RangeError. B-2 (v18): without a max, a misconfigured
+* `reviewTimeoutMs` made `AbortSignal.timeout` throw inside the subagent
+* start call; the outer catch logged it and silently degraded the review to
+* the inject path. The schema and the assembly clamp both reject it (same
+* bound as commands/maintenance). */
+const MAX_TIMER_DELAY_MS = 4294967295;
 const Config = z.object({
 	reviewEnabled: z.boolean().default(true),
 	reviewMode: z.union([z.const("subagent"), z.const("inject")]).default("subagent"),
 	memoryInterval: z.number().min(1).default(DEFAULT_REVIEW_MEMORY_INTERVAL),
 	skillInterval: z.number().min(1).default(DEFAULT_REVIEW_SKILL_INTERVAL),
 	reviewToolAllow: z.array(z.string()).default(["skill"]),
-	reviewTimeoutMs: z.number().min(1).default(DEFAULT_REVIEW_TIMEOUT_MS),
+	reviewTimeoutMs: z.number().min(1).max(MAX_TIMER_DELAY_MS).default(DEFAULT_REVIEW_TIMEOUT_MS),
 	reviewContextMessages: z.number().min(1).default(DEFAULT_REVIEW_CONTEXT_MESSAGES),
 	reviewMessageChars: z.number().min(1).default(DEFAULT_REVIEW_MESSAGE_CHARS),
 	reviewMaxDepth: z.number().min(1).default(1),
@@ -28,6 +35,7 @@ const Config = z.object({
 	]).default(DEFAULT_SKILL_REVIEW_TRIGGER),
 	reviewWakeInject: z.boolean().default(true),
 	skillReviewCompletionMinToolCalls: z.number().min(1).default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS),
+	root: z.string().default(""),
 	skillsRoot: z.string().default("")
 });
 /** V8-01 (0.3.45): the review subagent's structured-output contract. The
@@ -48,18 +56,20 @@ const REVIEW_OUTPUT_SCHEMA = {
 		summary: { type: "string" }
 	}
 };
-let statelessReviewStateWarned = false;
 function clampReviewConfig(rawConfig, ctx) {
 	const clamped = [];
-	const field = (name, value, fallback, min) => {
-		const result = clampedNumber(value, fallback, { min });
+	const field = (name, value, fallback, min, max) => {
+		const result = clampedNumber(value, fallback, max === void 0 ? { min } : {
+			min,
+			max
+		});
 		if (value !== void 0 && result !== value) clamped.push(name);
 		return result;
 	};
 	const config = Object.assign({}, rawConfig, {
 		memoryInterval: field("memoryInterval", rawConfig.memoryInterval, DEFAULT_REVIEW_MEMORY_INTERVAL, 1),
 		skillInterval: field("skillInterval", rawConfig.skillInterval, DEFAULT_REVIEW_SKILL_INTERVAL, 1),
-		reviewTimeoutMs: field("reviewTimeoutMs", rawConfig.reviewTimeoutMs, DEFAULT_REVIEW_TIMEOUT_MS, 1),
+		reviewTimeoutMs: field("reviewTimeoutMs", rawConfig.reviewTimeoutMs, DEFAULT_REVIEW_TIMEOUT_MS, 1, MAX_TIMER_DELAY_MS),
 		reviewContextMessages: field("reviewContextMessages", rawConfig.reviewContextMessages, DEFAULT_REVIEW_CONTEXT_MESSAGES, 1),
 		reviewMessageChars: field("reviewMessageChars", rawConfig.reviewMessageChars, DEFAULT_REVIEW_MESSAGE_CHARS, 1),
 		reviewMaxDepth: field("reviewMaxDepth", rawConfig.reviewMaxDepth, 1, 1),
@@ -68,10 +78,13 @@ function clampReviewConfig(rawConfig, ctx) {
 	if (clamped.length > 0) ctx.logger.warn(`dsh-evolution-review: ${clamped.join(", ")} provided an invalid value; falling back to the default`);
 	return config;
 }
-function apply(ctx, rawConfig) {
+function apply(ctx, rawConfig = {}) {
 	if (!verifyPromptBundle(PROMPT_BUNDLE)) throw new Error("dsh-evolution prompt bundle integrity check failed; refusing to schedule review work");
 	const config = clampReviewConfig(rawConfig, ctx);
+	const rootConfig = resolveRootConfig(rawConfig);
+	if (rootConfig.usedDeprecatedAlias) ctx.logger.warn("evolution-review: config \"skillsRoot\" is deprecated (E-7); use \"root\" — the alias is honoured until 0.3.65");
 	const turnStarts = /* @__PURE__ */ new Map();
+	let statelessReviewStateWarned = false;
 	const cumulativeToolCalls = /* @__PURE__ */ new Map();
 	const completionInjected = /* @__PURE__ */ new Set();
 	const pendingCadenceReviews = /* @__PURE__ */ new Map();
@@ -185,6 +198,7 @@ function apply(ctx, rawConfig) {
 			}
 			return;
 		}
+		if (skipFire) return;
 		const trigger = config.skillReviewTrigger;
 		if (trigger !== "completion" && trigger !== "both") return;
 		if (completionInjected.has(session.id)) return;
@@ -348,7 +362,11 @@ function apply(ctx, rawConfig) {
 		let ok = true;
 		try {
 			for (const op of plan.memoryOps ?? []) {
-				if (!Array.isArray(op.evidence) || op.evidence.length === 0) continue;
+				if (!Array.isArray(op.evidence) || op.evidence.length === 0) {
+					ok = false;
+					failedOps.push(`memory ${op.action ?? "add"} ${op.target}: missing evidence (defense-in-depth rejection)`);
+					continue;
+				}
 				const normalized = {
 					target: op.target === "user" ? "user" : "memory",
 					action: op.action ?? "add",
@@ -363,7 +381,11 @@ function apply(ctx, rawConfig) {
 				}
 			}
 			for (const op of plan.skillOps ?? []) {
-				if (!Array.isArray(op.evidence) || op.evidence.length === 0 || !op.name) continue;
+				if (!Array.isArray(op.evidence) || op.evidence.length === 0 || !op.name) {
+					ok = false;
+					failedOps.push(`skill ${op.action ?? "patch"} ${op.name ?? "<unnamed>"}: missing evidence or name (defense-in-depth rejection)`);
+					continue;
+				}
 				const args = {
 					...op,
 					evidence: op.evidence
@@ -448,7 +470,7 @@ function apply(ctx, rawConfig) {
 				ok: false,
 				message: "evolution-io service not mounted"
 			};
-			const library = new SkillLibrary(resolveSkillsRoot({ root: config.skillsRoot }), evolutionIoAdapter(() => io.provider()), void 0, (event) => {
+			const library = new SkillLibrary(resolveSkillsRoot({ root: rootConfig.root }), evolutionIoAdapter(() => io.provider()), void 0, (event) => {
 				ctx.emit("evolution/skill-mutated", event);
 			});
 			const op = skillArgs;
@@ -471,7 +493,7 @@ function apply(ctx, rawConfig) {
 				if (archived.ok) await ctx.get("skillUsage")?.markArchived?.(name);
 				return archived;
 			}
-			if (op.action === "write_file") return await library.writeSupportFile(name, op.file_path ?? "", op.file_content ?? op.content ?? "", origin);
+			if (op.action === "write_file") return await library.writeSupportFile(name, op.file_path ?? "", op.file_content ?? "", origin);
 			if (op.action === "remove_file") return await library.removeSupportFile(name, op.file_path ?? "", origin);
 			if (op.action === "restructure") {
 				const moves = (op.restructure ?? []).filter((move) => move !== null).map((move) => ({

package/lib/types/index.d.ts

@@ -45,7 +45,10 @@ export interface Config {
      * Empty (the default) resolves through `resolveSkillsRoot` to the shared
      * default root — the historical behavior. A custom root keeps review-created
      * skills in the SAME tree the catalog/tools read instead of writing a
-     * parallel tree the rest of the family cannot see. */
+     * parallel tree the rest of the family cannot see. E-7 (v18): canonical key. */
+    root?: string;
+    /** Deprecated alias of `root` (E-7, v18); honoured only while `root` is
+     * empty, with a warning; removed after 0.3.65. */
     skillsRoot?: string;
 }
 export declare const Config: z<Config>;
@@ -97,7 +100,7 @@ type ClampedReviewConfig = Config & {
     skillReviewCompletionMinToolCalls: number;
 };
 export declare function clampReviewConfig(rawConfig: Config, ctx: Context): ClampedReviewConfig;
-export declare function apply(ctx: Context, rawConfig: Config): void;
+export declare function apply(ctx: Context, rawConfig?: Config): void;
 /** Completion-channel decision: task finished normally AND the session is proven long. */
 export declare function shouldCompletionReview(reason: {
     kind?: string;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.62",
+  "version": "0.3.64",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.62",
-    "@lmzhen/dsh-evolution-core": "^0.3.62",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.62"
+    "@lmzhen/dsh-evolution-approval": "^0.3.64",
+    "@lmzhen/dsh-evolution-core": "^0.3.64",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.64"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.62",
-    "@lmzhen/dsh-evolution-policy": "^0.3.62"
+    "@lmzhen/dsh-evolution-state": "^0.3.64",
+    "@lmzhen/dsh-evolution-policy": "^0.3.64"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.62",
-    "@lmzhen/dsh-evolution-core": "^0.3.62",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.62",
-    "@lmzhen/dsh-evolution-state": "^0.3.62"
+    "@lmzhen/dsh-evolution-approval": "^0.3.64",
+    "@lmzhen/dsh-evolution-core": "^0.3.64",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.64",
+    "@lmzhen/dsh-evolution-state": "^0.3.64"
   }
 }