@lmzhen/dsh-evolution-review 0.3.61 → 0.3.63

package/README.md

@@ -28,12 +28,13 @@ Independent of request-prefix construction. This package does not alter the asse
 - The completion-channel counters (`cumulativeToolCalls` / `completionInjected`) are in-memory only. A process restart resets them, which is accepted behavior: the completion review is a one-per-session post-task adaptation and a restart is treated as a fresh conversation boundary. The cadence state (`turnsSinceMemory` / `turnsSinceSkill`) is persisted via `ReviewState` and survives restart.
 - `evolution/review-scheduled` and `evolution/review-error` are emitted for platform/user wiring only — this family has no in-repo production `ctx.on` consumer for them. They are declared externally owned (the platform side wires consumption), which matches the `EXEMPT_ORPHANS` set in `scripts/verify-event-pairing.mjs`.
 - When the `evolution-state` service is not mounted, the memory/skill cadence state is not persisted and every turn restarts from a clean `{ turnsSinceMemory: 0, turnsSinceSkill: 0 }` baseline — the review schedule is stateless and re-decided each turn rather than accumulating across the conversation. The loss is surfaced once per process as a logger warning at the first turn/end.
+- Read-before-write can see the review subagent's own `skill` reads only when the subagent backend exposes `localAgent` (the in-process driver does; out-of-process backends such as ACP and the CLI providers set `localAgent: undefined`). With a remote backend the subagent's reads are invisible, so a plan item patching a skill the subagent itself loaded is dropped as "unread" — the review then falls back to the parent session's reads only. Documented rather than worked around: recovering the child read set needs a `SubagentLike` contract change (v14 P2-6).
 
 ## Configuration
 
 `reviewProvider` selects the LLM provider for review subagents. When omitted, the subagent inherits the deployment default route instead of a hardcoded provider name. Model selection stays on the policy (`memoryReviewModel` / `skillReviewModel`).
 
-`reviewTimeoutMs` bounds each review subagent run (an `AbortSignal.timeout`; `0` aborts immediately). `executionTimeoutMs` is a leftover declaration and is **not consumed** — it is kept only as a code comment and has no effect; configure `reviewTimeoutMs` instead.
+`reviewTimeoutMs` bounds each review subagent run (an `AbortSignal.timeout`; `0` aborts immediately). The former `executionTimeoutMs` declaration was removed in v14 (nothing read it, so it was configuration that did nothing); use `reviewTimeoutMs`.
 
 ### Review delivery contract (0.3.38-0.3.42)
 

package/lib/index.js

@@ -1,7 +1,7 @@
 import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
 import { createUserMessage } from "@deepseek-ai/dsh-llm";
-import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_USER_CHAR_LIMIT, PROMPT_BUNDLE, SkillLibrary, advanceReview, clampedNumber, evolutionIoAdapter, foldTurn, redactSecrets, resolveOrigins, resolveSkillsRoot, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_REVIEW_CONTEXT_MESSAGES, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_MESSAGE_CHARS, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_REVIEW_TIMEOUT_MS, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_USER_CHAR_LIMIT, PROMPT_BUNDLE, SkillLibrary, advanceReview, clampedNumber, evolutionIoAdapter, foldTurn, redactSecrets, resolveOrigins, resolveSkillsRoot, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 //#region lib/types/index.js
 /**
@@ -16,10 +16,9 @@ const Config = z.object({
 	memoryInterval: z.number().min(1).default(DEFAULT_REVIEW_MEMORY_INTERVAL),
 	skillInterval: z.number().min(1).default(DEFAULT_REVIEW_SKILL_INTERVAL),
 	reviewToolAllow: z.array(z.string()).default(["skill"]),
-	reviewTimeoutMs: z.number().min(1).default(12e4),
-	executionTimeoutMs: z.number().min(1).default(3e4),
-	reviewContextMessages: z.number().min(1).default(60),
-	reviewMessageChars: z.number().min(1).default(2e3),
+	reviewTimeoutMs: z.number().min(1).default(DEFAULT_REVIEW_TIMEOUT_MS),
+	reviewContextMessages: z.number().min(1).default(DEFAULT_REVIEW_CONTEXT_MESSAGES),
+	reviewMessageChars: z.number().min(1).default(DEFAULT_REVIEW_MESSAGE_CHARS),
 	reviewMaxDepth: z.number().min(1).default(1),
 	reviewProvider: z.string(),
 	skillReviewTrigger: z.union([
@@ -49,7 +48,6 @@ const REVIEW_OUTPUT_SCHEMA = {
 		summary: { type: "string" }
 	}
 };
-let statelessReviewStateWarned = false;
 function clampReviewConfig(rawConfig, ctx) {
 	const clamped = [];
 	const field = (name, value, fallback, min) => {
@@ -60,9 +58,9 @@ function clampReviewConfig(rawConfig, ctx) {
 	const config = Object.assign({}, rawConfig, {
 		memoryInterval: field("memoryInterval", rawConfig.memoryInterval, DEFAULT_REVIEW_MEMORY_INTERVAL, 1),
 		skillInterval: field("skillInterval", rawConfig.skillInterval, DEFAULT_REVIEW_SKILL_INTERVAL, 1),
-		reviewTimeoutMs: field("reviewTimeoutMs", rawConfig.reviewTimeoutMs, 12e4, 1),
-		reviewContextMessages: field("reviewContextMessages", rawConfig.reviewContextMessages, 60, 1),
-		reviewMessageChars: field("reviewMessageChars", rawConfig.reviewMessageChars, 2e3, 1),
+		reviewTimeoutMs: field("reviewTimeoutMs", rawConfig.reviewTimeoutMs, DEFAULT_REVIEW_TIMEOUT_MS, 1),
+		reviewContextMessages: field("reviewContextMessages", rawConfig.reviewContextMessages, DEFAULT_REVIEW_CONTEXT_MESSAGES, 1),
+		reviewMessageChars: field("reviewMessageChars", rawConfig.reviewMessageChars, DEFAULT_REVIEW_MESSAGE_CHARS, 1),
 		reviewMaxDepth: field("reviewMaxDepth", rawConfig.reviewMaxDepth, 1, 1),
 		skillReviewCompletionMinToolCalls: field("skillReviewCompletionMinToolCalls", rawConfig.skillReviewCompletionMinToolCalls, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, 1)
 	});
@@ -73,6 +71,7 @@ function apply(ctx, rawConfig) {
 	if (!verifyPromptBundle(PROMPT_BUNDLE)) throw new Error("dsh-evolution prompt bundle integrity check failed; refusing to schedule review work");
 	const config = clampReviewConfig(rawConfig, ctx);
 	const turnStarts = /* @__PURE__ */ new Map();
+	let statelessReviewStateWarned = false;
 	const cumulativeToolCalls = /* @__PURE__ */ new Map();
 	const completionInjected = /* @__PURE__ */ new Set();
 	const pendingCadenceReviews = /* @__PURE__ */ new Map();
@@ -349,7 +348,11 @@ function apply(ctx, rawConfig) {
 		let ok = true;
 		try {
 			for (const op of plan.memoryOps ?? []) {
-				if (!Array.isArray(op.evidence) || op.evidence.length === 0) continue;
+				if (!Array.isArray(op.evidence) || op.evidence.length === 0) {
+					ok = false;
+					failedOps.push(`memory ${op.action ?? "add"} ${op.target}: missing evidence (defense-in-depth rejection)`);
+					continue;
+				}
 				const normalized = {
 					target: op.target === "user" ? "user" : "memory",
 					action: op.action ?? "add",
@@ -364,7 +367,11 @@ function apply(ctx, rawConfig) {
 				}
 			}
 			for (const op of plan.skillOps ?? []) {
-				if (!Array.isArray(op.evidence) || op.evidence.length === 0 || !op.name) continue;
+				if (!Array.isArray(op.evidence) || op.evidence.length === 0 || !op.name) {
+					ok = false;
+					failedOps.push(`skill ${op.action ?? "patch"} ${op.name ?? "<unnamed>"}: missing evidence or name (defense-in-depth rejection)`);
+					continue;
+				}
 				const args = {
 					...op,
 					evidence: op.evidence
@@ -472,7 +479,7 @@ function apply(ctx, rawConfig) {
 				if (archived.ok) await ctx.get("skillUsage")?.markArchived?.(name);
 				return archived;
 			}
-			if (op.action === "write_file") return await library.writeSupportFile(name, op.file_path ?? "", op.file_content ?? op.content ?? "", origin);
+			if (op.action === "write_file") return await library.writeSupportFile(name, op.file_path ?? "", op.file_content ?? "", origin);
 			if (op.action === "remove_file") return await library.removeSupportFile(name, op.file_path ?? "", origin);
 			if (op.action === "restructure") {
 				const moves = (op.restructure ?? []).filter((move) => move !== null).map((move) => ({

package/lib/types/index.d.ts

@@ -18,7 +18,6 @@ export interface Config {
      */
     reviewToolAllow?: string[];
     reviewTimeoutMs?: number;
-    executionTimeoutMs?: number;
     reviewContextMessages?: number;
     reviewMessageChars?: number;
     /** ABSOLUTE cap of the review subagent's own delegation depth (platform

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.61",
+  "version": "0.3.63",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.61",
-    "@lmzhen/dsh-evolution-core": "^0.3.61",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.61"
+    "@lmzhen/dsh-evolution-approval": "^0.3.63",
+    "@lmzhen/dsh-evolution-core": "^0.3.63",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.63"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.61",
-    "@lmzhen/dsh-evolution-policy": "^0.3.61"
+    "@lmzhen/dsh-evolution-state": "^0.3.63",
+    "@lmzhen/dsh-evolution-policy": "^0.3.63"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.61",
-    "@lmzhen/dsh-evolution-core": "^0.3.61",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.61",
-    "@lmzhen/dsh-evolution-state": "^0.3.61"
+    "@lmzhen/dsh-evolution-approval": "^0.3.63",
+    "@lmzhen/dsh-evolution-core": "^0.3.63",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.63",
+    "@lmzhen/dsh-evolution-state": "^0.3.63"
   }
 }