@lmzhen/dsh-evolution-review 0.3.57 → 0.3.59

package/README.md

@@ -38,6 +38,6 @@ Independent of request-prefix construction. This package does not alter the asse
 ### Review delivery contract (0.3.38-0.3.42)
 
 - **Both channels execute at conversation end only** (a `turn/end` with `reason.kind === 'completed'`): a cadence threshold fire mid-task merely latches the kind — no subagent spawn, no inject. The flush runs BEFORE the latch block (the completing turn may itself be a threshold-firing turn). `reviewMode` (`'subagent'` default / `'inject'`) selects how the flush delivers; the explicit `'inject'` mode's historical "immediate on threshold" contract was superseded in 0.3.39 — both modes are end-of-conversation.
-- **`skillReviewTrigger`** (default `'cadence'`): `'cadence'` runs one end-of-conversation review from the cadence latch; `'completion'` uses the separate long-session completion gate (session-cumulative tool-call threshold); `'both'` enables both (note: with the deferred cadence execution the `'both'` combination would inject a second task-complete prompt at the same boundary — prefer `'cadence'`).
+- **`skillReviewTrigger`** (default `'cadence'`): the cadence channel is **always on** (one end-of-conversation review from the cadence latch per task segment); the flag gates **only the completion channel** — `'cadence'` disables it, `'completion'` enables it (cadence still fires), `'both'` enables it on top of the always-on cadence. At one boundary a turn is served by exactly one review: the cadence flush runs first and returns, so `'both'` never double-sends a second task-complete prompt at the same boundary (V10-13).
 - **`reviewWakeInject`** (default `true`): deliveries use `agent.followup` (next-turn + wake — the model starts processing immediately) instead of the non-waking `agent.inject` (which waits for the next driver wake). The host falls back to `inject` when it has no followup or the option is `false`. The woken turn's own cadence fire is suppressed once (an injected review prompt alone must not re-trigger a review under `interval=1`); a restart clears the queue, so the loop cannot survive it.
 - **Counting window = injection-to-injection**: the `turnsSinceMemory`/`turnsSinceSkill` counters are monotonic across threshold fires (`resetOnFire: false`) and are zeroed at the flush delivery — a continued conversation starts a fresh segment from the injection. A threshold fire on the completing turn is caught by the flush (`pendingKind = latch ?? kind`). All deliveries (review prompt AND result notices) share the same waking channel; a failed counter-reset persist warns once per session (a stateful reload may re-deliver).

package/lib/index.js

@@ -50,17 +50,6 @@ const REVIEW_OUTPUT_SCHEMA = {
 	}
 };
 let statelessReviewStateWarned = false;
-/**
-* G3.1 (0.3.23): clamp the numeric review config at assembly so a 0/negative/
-* NaN/±Infinity value falls back to the package default instead of folding as a
-* "disabled" special value (a 0 interval would fire a review every turn; NaN
-* folds as NaN into the cadence/timeout). The schema `.min(1)` guards the
-* loader path; this clamp also covers NaN/±Infinity (which schemastery lets a
-* bare number schema through) and direct construction. `reviewMaxDepth` clamps
-* to at least 1 because 0 is the historical 0.3.1 maximum-depth defect (a 0
-* rejects the spawn outright). Warn once when a user-supplied value had to be
-* corrected.
-*/
 function clampReviewConfig(rawConfig, ctx) {
 	const clamped = [];
 	const field = (name, value, fallback, min) => {
@@ -203,18 +192,7 @@ function apply(ctx, rawConfig) {
 		if (!shouldCompletionReview(event.data.reason, cumulative, config.skillReviewCompletionMinToolCalls)) return;
 		completionInjected.add(session.id);
 		try {
-			agent.inject(createUserMessage({
-				content: [{
-					type: "text",
-					text: COMPLETION_SKILL_REVIEW_PROMPT
-				}],
-				source: {
-					kind: "plugin",
-					plugin: "dsh-evolution-review",
-					form: "notice",
-					summary: "completion review"
-				}
-			}));
+			deliverMessage(agent, COMPLETION_SKILL_REVIEW_PROMPT, "completion review");
 		} catch (injectError) {
 			completionInjected.delete(session.id);
 			ctx.logger.warn(`dsh-evolution-review: completion review inject failed: ${injectError instanceof Error ? injectError.message : String(injectError)}`);
@@ -278,7 +256,7 @@ function apply(ctx, rawConfig) {
 				maxDepth: config.reviewMaxDepth,
 				agentOptions,
 				persona: reviewPrompt(kind, "plan"),
-				toolFilter: { allow: [...config.reviewToolAllow] },
+				toolFilter: { allow: [...config.reviewToolAllow ?? []] },
 				outputSchema: REVIEW_OUTPUT_SCHEMA
 			});
 			try {

package/lib/types/index.d.ts

@@ -28,8 +28,12 @@ export interface Config {
     reviewMaxDepth?: number;
     /** LLM provider for review subagents. Omit to inherit the deployment default route. */
     reviewProvider?: string;
-    /** Which channel runs the end-of-conversation summary: the cadence latch
-     * ('cadence'), the long-session completion gate ('completion'), or both. */
+    /** E3/P1-8 (v11) — TRUE semantics: this flag gates ONLY the completion
+     * channel. The cadence latch stays active regardless of the value (a
+     * completion-gated deployment still fires at the policy cadence), so
+     * 'completion' does NOT mean "cadence off", and 'both' is effectively
+     * "completion on top of the always-on cadence". The mutually-exclusive
+     * channel reading in earlier docs was wrong. */
     skillReviewTrigger?: 'cadence' | 'completion' | 'both';
     /** Cumulative session tool calls before a session counts as proven-long for the completion channel. */
     skillReviewCompletionMinToolCalls?: number;
@@ -81,7 +85,19 @@ export declare const REVIEW_OUTPUT_SCHEMA: {
  * rejects the spawn outright). Warn once when a user-supplied value had to be
  * corrected.
  */
-export declare function clampReviewConfig(rawConfig: Config, ctx: Context): Required<Config>;
+/** F5 (P2-16, v11): the clamp sets exactly these seven numeric fields — the
+ * old `as Required<Config>` lied about `reviewToolAllow` etc. being populated
+ * (`[...undefined]` TypeErrors under a direct `apply(ctx, {})`). */
+type ClampedReviewConfig = Config & {
+    memoryInterval: number;
+    skillInterval: number;
+    reviewTimeoutMs: number;
+    reviewContextMessages: number;
+    reviewMessageChars: number;
+    reviewMaxDepth: number;
+    skillReviewCompletionMinToolCalls: number;
+};
+export declare function clampReviewConfig(rawConfig: Config, ctx: Context): ClampedReviewConfig;
 export declare function apply(ctx: Context, rawConfig: Config): void;
 /** Completion-channel decision: task finished normally AND the session is proven long. */
 export declare function shouldCompletionReview(reason: {
@@ -121,4 +137,5 @@ export declare function filterUnreadSkillOps(ops: Array<{
  * buildReviewRequest and is unchanged).
  */
 export declare function renderToolResultLine(data: unknown): string;
+export {};
 //# sourceMappingURL=index.d.ts.map

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.57",
+  "version": "0.3.59",
   "publishConfig": {
     "access": "public"
   },
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.57",
-    "@lmzhen/dsh-evolution-core": "^0.3.57",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.57"
+    "@lmzhen/dsh-evolution-approval": "^0.3.59",
+    "@lmzhen/dsh-evolution-core": "^0.3.59",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.59"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.57",
-    "@lmzhen/dsh-evolution-policy": "^0.3.57"
+    "@lmzhen/dsh-evolution-state": "^0.3.59",
+    "@lmzhen/dsh-evolution-policy": "^0.3.59"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.57",
-    "@lmzhen/dsh-evolution-core": "^0.3.57",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.57",
-    "@lmzhen/dsh-evolution-state": "^0.3.57"
+    "@lmzhen/dsh-evolution-approval": "^0.3.59",
+    "@lmzhen/dsh-evolution-core": "^0.3.59",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.59",
+    "@lmzhen/dsh-evolution-state": "^0.3.59"
   }
 }