@lmzhen/dsh-evolution-review 0.3.51 → 0.3.53

package/lib/index.js

@@ -1,7 +1,7 @@
 import { createHash, randomUUID } from "node:crypto";
 import z from "@deepseek-ai/schemastery";
 import { createUserMessage } from "@deepseek-ai/dsh-llm";
-import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_USER_CHAR_LIMIT, PROMPT_BUNDLE, SkillLibrary, advanceReview, clampedNumber, evolutionIoAdapter, foldTurn, redactSecrets, resolveOrigins, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
+import { COMPLETION_SKILL_REVIEW_PROMPT, DEFAULT_MAX_OPS_PER_PLAN, DEFAULT_MEMORY_CHAR_LIMIT, DEFAULT_REVIEW_MEMORY_INTERVAL, DEFAULT_REVIEW_SKILL_INTERVAL, DEFAULT_SKILL_CONTENT_CHARS, DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS, DEFAULT_SKILL_REVIEW_TRIGGER, DEFAULT_USER_CHAR_LIMIT, PROMPT_BUNDLE, SkillLibrary, advanceReview, clampedNumber, evolutionIoAdapter, foldTurn, redactSecrets, resolveOrigins, resolveSkillsRoot, reviewPrompt, verifyPromptBundle } from "@lmzhen/dsh-evolution-core";
 import { validateEvolutionPlan } from "@lmzhen/dsh-evolution-plan-validator";
 //#region lib/types/index.js
 /**
@@ -28,7 +28,8 @@ const Config = z.object({
 		z.const("both")
 	]).default(DEFAULT_SKILL_REVIEW_TRIGGER),
 	reviewWakeInject: z.boolean().default(true),
-	skillReviewCompletionMinToolCalls: z.number().min(1).default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS)
+	skillReviewCompletionMinToolCalls: z.number().min(1).default(DEFAULT_SKILL_REVIEW_COMPLETION_MIN_TOOL_CALLS),
+	skillsRoot: z.string().default("")
 });
 /** V8-01 (0.3.45): the review subagent's structured-output contract. The
 * `subagents.start` outputSchema is RAW JSON Schema validated by
@@ -185,6 +186,7 @@ function apply(ctx, rawConfig) {
 						ctx.logger.warn(`dsh-evolution-review: cadence counter reset could not be persisted after a delivered review (${resetError instanceof Error ? resetError.message : String(resetError)}) — a stateful reload may re-deliver this review`);
 					}
 				}
+				return;
 			}
 		}
 		if (kind && event.data.reason.kind !== "completed") {
@@ -469,7 +471,7 @@ function apply(ctx, rawConfig) {
 				ok: false,
 				message: "evolution-io service not mounted"
 			};
-			const library = new SkillLibrary(void 0, evolutionIoAdapter(() => io.provider()), void 0, (event) => {
+			const library = new SkillLibrary(resolveSkillsRoot({ root: config.skillsRoot }), evolutionIoAdapter(() => io.provider()), void 0, (event) => {
 				ctx.emit("evolution/skill-mutated", event);
 			});
 			const op = skillArgs;
@@ -598,6 +600,26 @@ function fingerprintPolicy(snapshot) {
 		return;
 	}
 }
+/**
+* V10-10 (P2-11): render one `[result]` evidence line from a 'tool/result'
+* event payload. The former read (`data.output`) targeted a field that does
+* not exist on the upstream rc.2 payload, so EVERY result line rendered an
+* empty payload and the review subagent never saw tool output — the evidence
+* chain silently starved while still spending its line budget. The payload
+* text now comes from `data.message.content` tool-result blocks (inner text
+* blocks joined, mirroring the user/assistant rendering above). A failure is
+* marked by the payload-level `error` OR a block-level `isError`. The legacy
+* pre-rc.2 shape (no `message`) is tolerated as an empty payload — it never
+* throws. Budget: 500 chars per line (the 12-line cap lives in
+* buildReviewRequest and is unchanged).
+*/
+function renderToolResultLine(data) {
+	const shape = data;
+	const content = shape?.message?.content;
+	const resultBlocks = (Array.isArray(content) ? content : []).filter((block) => block.type === "tool-result");
+	const output = resultBlocks.map((block) => Array.isArray(block.content) ? block.content.map((inner) => inner.type === "text" && typeof inner.text === "string" ? inner.text : "").join(" ") : typeof block.text === "string" ? block.text : "").join(" ").trim();
+	return `[result]${shape?.error || resultBlocks.some((block) => block.isError === true) ? " [ERROR]" : ""} ${output.slice(0, 500)}`;
+}
 function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars) {
 	const messages = [];
 	const surface = session.deriveMessages();
@@ -613,12 +635,7 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars)
 			const data = event.data;
 			const argsRaw = typeof data?.arguments === "string" ? data.arguments : JSON.stringify(data?.arguments ?? {});
 			toolLines.push(`[call] ${data?.name ?? "?"} ${argsRaw.slice(0, 500)}`);
-		} else if (event?.type === "tool/result") {
-			const data = event.data;
-			const output = typeof data?.output === "string" ? data.output : "";
-			const failure = data?.error ? " [ERROR]" : "";
-			toolLines.push(`[result]${failure} ${output.slice(0, 500)}`);
-		}
+		} else if (event?.type === "tool/result") toolLines.push(renderToolResultLine(event.data));
 	}
 	toolLines.reverse();
 	return [
@@ -632,4 +649,4 @@ function buildReviewRequest(session, kind, signal, maxMessages, maxMessageChars)
 	].join("\n");
 }
 //#endregion
-export { Config, REVIEW_OUTPUT_SCHEMA, apply, clampReviewConfig, filterUnreadSkillOps, inject, name, shouldCompletionReview, sweepDeadSessionEntries };
+export { Config, REVIEW_OUTPUT_SCHEMA, apply, clampReviewConfig, filterUnreadSkillOps, inject, name, renderToolResultLine, shouldCompletionReview, sweepDeadSessionEntries };

package/lib/types/index.d.ts

@@ -38,6 +38,12 @@ export interface Config {
      * differs). Default true; false degrades to the non-waking inject (the
      * summary then waits for the next driver wake). */
     reviewWakeInject?: boolean;
+    /** V10-11 (P2-7): skill tree root for the review's direct skill writes.
+     * Empty (the default) resolves through `resolveSkillsRoot` to the shared
+     * default root — the historical behavior. A custom root keeps review-created
+     * skills in the SAME tree the catalog/tools read instead of writing a
+     * parallel tree the rest of the family cannot see. */
+    skillsRoot?: string;
 }
 export declare const Config: z<Config>;
 /** V8-01 (0.3.45): the review subagent's structured-output contract. The
@@ -101,4 +107,18 @@ export declare function filterUnreadSkillOps(ops: Array<{
     action?: string;
     name?: string;
 }>, readNames: ReadonlySet<string>): number;
+/**
+ * V10-10 (P2-11): render one `[result]` evidence line from a 'tool/result'
+ * event payload. The former read (`data.output`) targeted a field that does
+ * not exist on the upstream rc.2 payload, so EVERY result line rendered an
+ * empty payload and the review subagent never saw tool output — the evidence
+ * chain silently starved while still spending its line budget. The payload
+ * text now comes from `data.message.content` tool-result blocks (inner text
+ * blocks joined, mirroring the user/assistant rendering above). A failure is
+ * marked by the payload-level `error` OR a block-level `isError`. The legacy
+ * pre-rc.2 shape (no `message`) is tolerated as an empty payload — it never
+ * throws. Budget: 500 chars per line (the 12-line cap lives in
+ * buildReviewRequest and is unchanged).
+ */
+export declare function renderToolResultLine(data: unknown): string;
 //# sourceMappingURL=index.d.ts.map

package/package.json

@@ -1,14 +1,14 @@
 {
   "name": "@lmzhen/dsh-evolution-review",
   "description": "Background review orchestration (community build)",
-  "version": "0.3.51",
+  "version": "0.3.53",
   "publishConfig": {
     "access": "public"
   },
   "repository": {
     "type": "git",
     "url": "git+https://github.com/lmzhen/dsh-evolution.git",
-    "directory": "packages/dsh-evolution-review"
+    "directory": "packages/evolution-review"
   },
   "type": "module",
   "main": "lib/index.js",
@@ -31,9 +31,9 @@
   "license": "MIT",
   "dependencies": {
     "@deepseek-ai/schemastery": "^3.18.1",
-    "@lmzhen/dsh-evolution-approval": "^0.3.51",
-    "@lmzhen/dsh-evolution-core": "^0.3.51",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.51"
+    "@lmzhen/dsh-evolution-approval": "^0.3.53",
+    "@lmzhen/dsh-evolution-core": "^0.3.53",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.53"
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
@@ -42,8 +42,8 @@
     "@deepseek-ai/dsh-llm": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-state": "^0.3.51",
-    "@lmzhen/dsh-evolution-policy": "^0.3.51"
+    "@lmzhen/dsh-evolution-state": "^0.3.53",
+    "@lmzhen/dsh-evolution-policy": "^0.3.53"
   },
   "devDependencies": {
     "@deepseek-ai/dsh-agent": "^0.1.1-rc.2",
@@ -54,9 +54,9 @@
     "@deepseek-ai/dsh-session-persistence": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-session-persistence-jsonl": "^0.1.1-rc.2",
     "@deepseek-ai/dsh-tools": "^0.1.1-rc.2",
-    "@lmzhen/dsh-evolution-approval": "^0.3.51",
-    "@lmzhen/dsh-evolution-core": "^0.3.51",
-    "@lmzhen/dsh-evolution-plan-validator": "^0.3.51",
-    "@lmzhen/dsh-evolution-state": "^0.3.51"
+    "@lmzhen/dsh-evolution-approval": "^0.3.53",
+    "@lmzhen/dsh-evolution-core": "^0.3.53",
+    "@lmzhen/dsh-evolution-plan-validator": "^0.3.53",
+    "@lmzhen/dsh-evolution-state": "^0.3.53"
   }
 }